Timeline

Jul 2, 2004:

10:27 AM Changeset in webkit [6958] by darin

• 3 edits in trunk/WebKit

Reviewed by Dave.

• fixed problem where tabsToLinks and privateBrowsingEnabled did not work with non- standard WebPreferences objects

• WebView.subproj/WebPreferences.m: (-[WebPreferences _valueForKey:]): New helper. (-[WebPreferences _stringValueForKey:]): Use _valueForKey. (-[WebPreferences _integerValueForKey:]): Use _valueForKey. (-[WebPreferences _boolValueForKey:]): Use _valueForKey. (-[WebPreferences tabsToLinks]): Use _boolValueForKey; this is the bug fix. (-[WebPreferences privateBrowsingEnabled]): Ditto. (+[WebPreferences _setIBCreatorID:]): Use copy instead of retain for keeping an NSString.

10:03 AM Changeset in webkit [6957] by darin

• 2 edits in trunk/WebCore

Reviewed by Dave.

• fixed half of <rdar://problem/3709244> utf-8 meta tag not parsed when page title contains angle brackets or if </meta> tag used

• khtml/misc/decoder.cpp: (Decoder::decode): Allow </meta> tags without deciding we are done with the header.

Jul 1, 2004:

1:41 PM Changeset in webkit [6956] by trey

• 2 edits in trunk/WebKit

3556159 - Crashes in -[WebFrame(WebPrivate) _transitionToCommitted:] at www.mastercardbusiness.com

We know from the line number of the crash that it is due to [self parentFrame]==nil.

Looking at the HTML and that of the related bugs, they do special stuff with onload
handlers. It is no longer repro, presumably because the includes JS files changed,
as the bugs only included the top level HTML. I suspect that the problem is that the
WebFrameLoadTypeOnLoadEvent case was added, and in some weird sequence specific to
MasterCard, they hit a case where we would be in WebFrameLoadTypeOnLoadEvent mode but
not have a parent frame.

So we guard in the code against hitting a nil parentFrame, and log an error just in
case this ever crops up again and we can learn more about it.

Reviewed by Richard.

• WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Guard against nil parentFrame.

10:41 AM Changeset in webkit [6955] by sullivan

• 3 edits in trunk/WebKit

Reviewed by Trey.

• fixed these bugs: <rdar://problem/3709110> REGRESSION (Tiger): Pressing Tab key to move focus onto links skips every other link <rdar://problem/3692576> focus ring is in odd place after clicking RSS button with "Tab to links" enabled

WebHTMLView has some trickery by which we advance the focused link when nextKeyView
or previousKeyView is called within nextValidKeyView or previousValidKeyView. This
broke in Tiger because AppKit now (sometimes at least) calls nextKeyView more than
once within nextValidKeyView. Fixed 3709110 by making sure we only advance the focus
once within a call to nextValidKeyView or previousValidKeyView.

Also, this same trickery didn't work right with hidden views. Fixed 3692576 by checking
whether the view is hidden and bypassing the focus-moving trickery in that case.

• WebView.subproj/WebHTMLViewInternal.h: renamed inNextValidKeyView -> nextKeyViewAccessShouldMoveFocus

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView nextKeyView]): now clears nextKeyViewAccessShouldMoveFocus (-[WebHTMLView previousKeyView]): ditto (-[WebHTMLView nextValidKeyView]): now doesn't set focus-moving trigger ivar if view is hidden or has hidden ancestor (-[WebHTMLView previousValidKeyView]): ditto