Timeline
Jul 7, 2004:
- 4:24 PM Changeset in webkit [6971] by
-
- 4 edits in trunk/WebCore
Fix for 3712133, crash from first-line pseudo-style use.
Reviewed by kocienda
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement):
- khtml/css/cssstyleselector.h:
- khtml/rendering/render_object.cpp: (RenderObject::getPseudoStyle):
- 2:36 PM Changeset in webkit [6970] by
-
- 2 edits in trunk/WebKit
3719051 - Safari doesn't update form inputs when a page was refreshed by javascript window.location
... and at least 5 other cases in Radar
Very similar problem to the Harvard PIN bug. We need to be sure
to not carry any state over when we are processing a client
redirect, which reuses the same WebHistoryItem.
Reviewed by John.
- WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Comment (-[WebFrame _opened]): Clear form and scroll state on client redirect.
- 1:13 PM Changeset in webkit [6969] by
-
- 5 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3716479> calling setInnerHTML during a webViewDidChange delegate call causes a crash
The fix involves some rearrangement of code in TypingCommand and TypingCommandImpl.
Formerly, new TypingCommands would apply themselves (which was a no-op) and then
do their action in some code a way different than other commands. This type of command
application is different than for all other commands since TypingCommands can be coalesced.
The crash occurred as a result of the "no-op" TypingCommand having the unconsidered
consequence of causing editing delegate notifications to be sent before the command
has actually run. This change takes a small step towards making TypingCommandImpl function like
other commands, where the command work is done in doApply. This makes the notification
happen in the right order.
- khtml/editing/htmlediting.cpp: (khtml::TypingCommand::TypingCommand): (khtml::TypingCommand::insertText): (khtml::TypingCommand::insertNewline): (khtml::TypingCommand::deleteKeyPressed):
- khtml/editing/htmlediting.h: (khtml::TypingCommand::):
- khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::TypingCommandImpl): (khtml::TypingCommandImpl::doApply):
- khtml/editing/htmlediting_impl.h:
Jul 6, 2004:
- 4:11 PM Changeset in webkit [6968] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers
Reviewed by john, trey, kocienda.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
- 3:18 PM Changeset in webkit [6967] by
-
- 2 edits in trunk/WebCore
Reviewed by me
- khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild): Added a better comment in the code I just checked in a few minutes ago.
- 3:07 PM Changeset in webkit [6966] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3672377> assertion failure in AppendNodeCommandImpl::doApply
due to non-0 exception code trying to insert a DIV markup string
The solution was to revert to the code that was rolled out, and removing
the child checks from NodeImpl::checkAddChild. However, this time, I added
code very similar to this check into the code that runs while HTML is
being parsed to build up tables. This code relies on child-add failure
to ensure the proper construction of well-formed tables (as gross as that
sounds), so the check needs to be retained there. No other code seems to
be so affected. Layout tests are unchanged by this patch.
- khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild):
- 10:58 AM Changeset in webkit [6965] by
-
- 5 edits in trunk/WebCore
Reviewed by John
Simple change. I switched the arguments of the appendNode helper function
and the AppendNodeCommand and AppendNodeCommandImpl classes. The node to
insert now comes before the parent node in the argument list. I did this
to make this function match the convention of others in the HTML editing code.
This was the only one that was "different" in the way that it ordered arguments.
As a result, I was always looking to see that I was passing things in the right
order.
- khtml/editing/htmlediting.cpp: (khtml::AppendNodeCommand::AppendNodeCommand): (khtml::AppendNodeCommand::appendChild): (khtml::AppendNodeCommand::parentNode):
- khtml/editing/htmlediting.h:
- khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::insertNodeAfter): (khtml::CompositeEditCommandImpl::insertNodeAt): (khtml::CompositeEditCommandImpl::appendNode): (khtml::AppendNodeCommandImpl::AppendNodeCommandImpl): (khtml::AppendNodeCommandImpl::~AppendNodeCommandImpl): (khtml::AppendNodeCommandImpl::doApply): (khtml::AppendNodeCommandImpl::doUnapply): (khtml::ApplyStyleCommandImpl::surroundNodeRangeWithElement): (khtml::DeleteSelectionCommandImpl::doApply): (khtml::InputNewlineCommandImpl::insertNodeAfterPosition): (khtml::InputNewlineCommandImpl::insertNodeBeforePosition): (khtml::InputTextCommandImpl::prepareForTextInsertion):
- khtml/editing/htmlediting_impl.h: (khtml::AppendNodeCommandImpl::parentNode):
- 10:04 AM Changeset in webkit [6964] by
-
- 3 edits in trunk/WebCore
Reviewed by Trey
Fixed several problems with traversal classes. For one, NodeIterators treat
FILTER_REJECT and FILTER_SKIP the same, since it treats the DOM tree as a
flat collection of nodes free of hierarchy. The code before this change did
not do this correctly. It sure pays to go back and read the specs. :)
Also, the code to traverse from node to node when filters were applied was
not working correctly. My first attemmpt to implement this was just plain
buggy, as I discovered when I tried to write tests for my WWDC talk. I have
settled on an implementation which is much simpler and worked for all the
tests I threw at it.
- khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::findNextNode): (DOM::NodeIteratorImpl::nextNode): (DOM::NodeIteratorImpl::findPreviousNode): (DOM::NodeIteratorImpl::previousNode): (DOM::TreeWalkerImpl::parentNode): (DOM::TreeWalkerImpl::firstChild): (DOM::TreeWalkerImpl::lastChild): (DOM::TreeWalkerImpl::previousSibling): (DOM::TreeWalkerImpl::nextSibling): (DOM::TreeWalkerImpl::previousNode): (DOM::TreeWalkerImpl::nextNode): (DOM::TreeWalkerImpl::ancestorRejected):
- khtml/xml/dom2_traversalimpl.h:
- 9:45 AM Changeset in webkit [6963] by
-
- 2 edits in trunk/WebKit
Reviewed by Trey.
- fixed <rdar://problem/3717147> folder icon used for error page in back/forward menu when iTunes is not installed
- WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): When displaying the error page for an unreachable URL, leave the requested URL in the WebHistoryItem; don't clobber it with a bogus one that represents the error page. This not only avoids the wrong-icon problem, but should also help in cases where an unreachable URL becomes reachable later on.
- 9:23 AM Changeset in webkit [6962] by
-
- 2 edits in trunk
Reviewed by kocienda.
- added backColorCommand, foreColorCommand, fontNameCommand, and fontSizeCommand
- layout-tests/editing/editing.js:
- 9:13 AM Changeset in webkit [6961] by
-
- 8 edits in trunk
WebCore:
3716053 - www.theage.com.au has extra back/forward items due to ads
This turned out to be easily fixed by generalizing the fix to 3438441. We prevent
addition to the b/f list not just during an onload event, but during any non-user
gesture, which includes top level script executing.
Reviewed by Richard.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Only real change - prevent adding to b/f list if not a user gesture. (KWQKHTMLPart::openURLRequest): Rename "onLoadEvent" to "userGesture", swap sense (KWQKHTMLPart::submitForm): Ditto (KWQKHTMLPart::urlSelected): Ditto
- kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Ditto
- kwq/WebCoreBridge.h:
WebKit:
3716053 - www.theage.com.au has extra back/forward items due to ads
The real change was in WebKit. Here was are just renaming a method and folding
all the WebFrameLoadTypeOnLoadEvent uses to be WebFrameLoadTypeInternal, since there
was never any difference anyway.
Reviewed by Richard
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): rename part of the method.
- WebView.subproj/WebFrame.m: Nuke WebFrameLoadTypeOnLoadEvent. (-[WebFrame _transitionToCommitted:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _itemForRestoringDocState]):
- WebView.subproj/WebFramePrivate.h:
- 8:46 AM Changeset in webkit [6960] by
-
- 2 edits in trunk/WebKit
Reviewed by Trey
Only register the editing delegate for those notifications for which it implements the callbacks.
- WebView.subproj/WebView.m: (-[WebView registerForEditingDelegateNotification:selector:]): (-[WebView setEditingDelegate:]):
- 8:40 AM Changeset in webkit [6959] by
-
- 2 edits in trunk/WebKit
3294652 - Failed drag of links doesn't slide back
The only reason for this is that because of some hacks, we lie to
AK about the drag image offset, which means we slide back to
slightly the wrong place. But it's very minor, so we should
just fix it.
Reviewed by Ken.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Ask for slideback.
