Timeline



Jul 12, 2004:

11:40 PM Changeset in webkit [7015] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/3673988>: (REGRESSION(141-144): connection assertion failure at ​http://traffic.511.org/sfgate)

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Don't check connection consistency if this load got cancelled while finishing, because in this case we have cleared the connection field already. This can happen when a redirect fires from an onload handler.
5:26 PM Changeset in webkit [7014] by mjs
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/3632570>: (REGRESSION: SocialText.net wiki keeps asking for auth, even though pages load)

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader didReceiveAuthenticationChallenge:]): Ignore the challenge - we don't want an auth panel for favicons. (-[WebIconLoader didCancelAuthenticationChallenge:]): Ignore cancel, since we are ignoring the challenge.
4:57 PM Changeset in webkit [7013]
  • 12 copies
    2 deletes in tags/WebCore-85~6~1

This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~1'.

4:57 PM Changeset in webkit [7012] by vicki
  • 2 edits in branches/Safari-1-0-branch/WebCore

fix CFBundleShortVersionString in WebCore. This should be 1.0.2, the Safari marketing version for the last update on Jaguar.

4:33 PM Changeset in webkit [7011] by rjw
  • 2 edits in trunk/WebCore

Fixed 3717982. Implemented navigator.language!

Reviewed by John.

  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty):
4:01 PM Changeset in webkit [7010] by kdecker
  • 2 adds in trunk/LayoutTests/fast/css

Reviewed by Dave

Added a layout test for css 'width:auto'

3:58 PM Changeset in webkit [7009] by hyatt
  • 2 edits in trunk/WebCore/khtml/rendering

Back out my changes to the fix for my previous checkin, since it broke the inline-block layout test.

3:30 PM Changeset in webkit [7008] by kocienda
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by me

Remove cvs conflict indicators from ChangeLog

3:29 PM Changeset in webkit [7007] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

  • khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent): I broke selection drawing with my last patch. This function is now used in selection drawing, and it was making an unneeded check to see that content was editable to answer whether or not is was rendered. Bad. Fixed.
3:26 PM Changeset in webkit [7006] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3621138, crash on hrweb.apple.com. Make sure that in the case where objects get pulled up from merging
blocks that we just delete all line boxes.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):
3:03 PM Changeset in webkit [7005] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3706080>: (REGRESSION (125.8-147u): Nested <ul> do not display bullets)
<rdar://problem/3676376>: (Second level bullets not printed when printing Xcode release notes)

  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (CGColorFromNSColor): (QPainter::drawEllipse): (QPainter::setShadow):
2:57 PM Changeset in webkit [7004] by kocienda
  • 1 edit
    20 adds in trunk

Reviewed by me

Added new editing-related layout tests

  • layout-tests/editing/deleting/delete-after-span-ws-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-after-span-ws-001.html: Added.
  • layout-tests/editing/deleting/delete-after-span-ws-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-after-span-ws-002.html: Added.
  • layout-tests/editing/deleting/delete-after-span-ws-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-after-span-ws-003.html: Added.
  • layout-tests/editing/selection/unrendered-001-expected.txt: Added.
  • layout-tests/editing/selection/unrendered-001.html: Added.
  • layout-tests/editing/selection/unrendered-002-expected.txt: Added.
  • layout-tests/editing/selection/unrendered-002.html: Added.
  • layout-tests/editing/selection/unrendered-003-expected.txt: Added.
  • layout-tests/editing/selection/unrendered-003.html: Added.
  • layout-tests/editing/selection/unrendered-004-expected.txt: Added.
  • layout-tests/editing/selection/unrendered-004.html: Added.
  • layout-tests/editing/selection/unrendered-005-expected.txt: Added.
  • layout-tests/editing/selection/unrendered-005.html: Added.
  • layout-tests/traversal/node-iterator-008-expected.txt: Added.
  • layout-tests/traversal/node-iterator-008.html: Added.
  • layout-tests/traversal/tree-walker-005-expected.txt: Added.
  • layout-tests/traversal/tree-walker-005.html: Added.
2:51 PM Changeset in webkit [7003] by kocienda
  • 7 edits in trunk/WebCore

Reviewed by Hyatt

Fixes for these bugs:

<rdar://problem/3723359> Extending then "unextending" selection with arrow keys should draw caret but doesn't
<rdar://problem/3724626> White-space deletion code deletes wrong character when space follows span

  • khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): Modify special-case white-space deletion code so it runs only in the special case. It was throwing its net too widely, catching the case described in 3724626. By tightening up the special-case white-space deletion, and allowing the more general-purpose code to run, the bug is fixed.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Use recently-added closestRenderedPosition helper in Position class to figure out the start and end positions for selection drawing.
  • khtml/xml/dom_position.cpp: (DOM::Position::equivalentUpstreamPosition): Added code to handle white-space that causes line breaks. (DOM::Position::equivalentDownstreamPosition): Ditto. (DOM::Position::closestRenderedPosition): Trap empty selections at function entry, return *this. (DOM::Position::isFirstRenderedPositionOnLine): Can't be first rendered position on line if not rendered. Add check for this. (DOM::Position::isLastRenderedPositionOnLine): Ditto, but s/first/last/
  • khtml/xml/dom_selection.cpp: (DOM::Selection::validate): A selection is in caret state if the start and end are equal *or* equivalent. The equivalence case is new, and fixes 3723359.
1:13 PM Changeset in webkit [7002] by hyatt
  • 4 edits in trunk/LayoutTests/fast

Fix the fast layout tests.

12:02 AM Changeset in webkit [7001]
  • 9 copies
    2 deletes in tags/WebKit-85~7~1

This commit was manufactured by cvs2svn to create tag
'WebKit-85~7~1'.

12:02 AM Changeset in webkit [7000]
  • 9 copies
    2 deletes in branches/WebKit-85~7-branch

This commit was manufactured by cvs2svn to create branch
'WebKit-85~7-branch'.

12:02 AM Changeset in webkit [6999]
  • 9 copies
    2 deletes in tags/WebKit-85~7-anchor

This commit was manufactured by cvs2svn to create tag
'WebKit-85~7-anchor'.

12:02 AM Changeset in webkit [6998] by vicki
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • fix CFBundleShortVersionString in WebKit. This should be 1.0.2, the Safari marketing version for the last update on Jaguar, not 1.0.3, which is the "Macromedia fixes" version that has not yet shipped

Jul 11, 2004:

11:49 PM Changeset in webkit [6997] by vicki
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • versioning for July Security Update (WebKit-85.7.1), and a bit of cleanup to the Changelog. We had already rolled a fix for Safari 1.0.3 to the branch, but do not want to include this in the Security Update.

Jul 9, 2004:

5:04 PM Changeset in webkit [6996] by vicki
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • merge these two fixes from HEAD for July 2004 Security Update

2004-07-09 Chris Blumenberg <​cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge

2004-07-06 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers

Reviewed by john, trey, kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
4:50 PM Changeset in webkit [6995] by kdecker
  • 4 edits in trunk

Reviewed by Hyatt.

fixes the width:auto problem in
<rdar://problem/3698344> REGRESSION (143?-144): macrumors.com tabs are compressed and illegible

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
4:41 PM Changeset in webkit [6994] by vicki
  • 2 edits in branches/Safari-1-0-branch/WebCore

WebCore versioning for July 2004 Security Update, WebCore-85.6.1

4:29 PM Changeset in webkit [6993] by vicki
  • 3 edits in branches/Safari-1-0-branch/WebCore
  • merge this fix from HEAD, so that the July 2004 Security Update will compile on Jaguar

2004-07-09 Chris Blumenberg <​cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar
4:23 PM Changeset in webkit [6992] by kocienda
  • 3 edits in trunk

Reviewed by me

Updated some layout test results.

  • layout-tests/editing/deleting/delete-image-004-expected.txt:
  • layout-tests/editing/selection/extend-by-character-006-expected.txt:
3:10 PM Changeset in webkit [6991]
  • 21 copies
    3 deletes in tags/WebKit-125~3~1

This commit was manufactured by cvs2svn to create tag
'WebKit-125~3~1'.

3:10 PM Changeset in webkit [6990] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebKit

WebKit versioning for July Security Update, WebKit-125.3.1

3:06 PM Changeset in webkit [6989]
  • 61 copies
    2 deletes in tags/WebCore-125~7~1

This commit was manufactured by cvs2svn to create tag
'WebCore-125~7~1'.

3:06 PM Changeset in webkit [6988] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • WebCore versioning for July Security Update, WebCore-125.7.1
2:56 PM Changeset in webkit [6987] by vicki
  • 5 edits in branches/Safari-1-2-branch

WebCore:

  • merge this fix from HEAD so that July Security Update will compile on Jaguar

2004-07-09 Chris Blumenberg <​cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar

WebKit:

  • merge this fix from HEAD so that the fix for the July Security Update will compile on Jaguar

2004-07-09 Chris Blumenberg <​cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge
2:46 PM Changeset in webkit [6986] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebKit
  • merge this fix from HEAD for July Security Update, 3717262

2004-07-06 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers

Reviewed by john, trey, kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
2:24 PM Changeset in webkit [6985] by cblu
  • 5 edits in trunk

WebCore:

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar

WebKit:

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge
11:31 AM Changeset in webkit [6984] by kocienda
  • 12 edits in trunk/WebCore

Reviewed by Hyatt

Some improvements to fix:

<rdar://problem/3723111> Caret not drawn when selection set to unrendered content

  • khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::issueCommandForDeleteKey): Adjust selection to delete if selected position is not rendered.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Use new caretPosition() function on Selection to figure out whether to paint.
  • khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): Now correctly deals with a start position that is not rendered. (DOM::Position::nextCharacterPosition): Ditto. (DOM::Position::closestRenderedPosition): New helper.
  • khtml/xml/dom_position.h: (DOM::): Moved in EAffinity from Selection header. Now used in closestRenderedPosition function.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): Added new m_caretPosition member. This is the position of the caret after a caret layout. This may be different from start or end if start and end are not rendered. (DOM::Selection::init): (DOM::Selection::modifyExtendingRightForward): New helper to clean up modify() and make it more readble. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Use new helpers to make this more readble. (DOM::Selection::layoutCaret): Uses new closestRenderedPosition helper to place the caret if in unrendered content. (DOM::Selection::paintCaret): Remove moveToRenderedContent. obsolete.
  • khtml/xml/dom_selection.h: (DOM::Selection::caretPosition): New accessor.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): EAffinity no longer a member enum of Selection class.
10:40 AM Changeset in webkit [6983] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by John

  • Plugins.subproj/npruntime.h: Updated license to lawyer-approved joint Apple-Mozilla BSD-style license.

Jul 8, 2004:

3:54 PM Changeset in webkit [6982] by hyatt
  • 2 edits in trunk/WebCore

Fix for the table layout test that failed because of a change in how innerText worked. We need to do
updateLayout now when using innerText, since the method has been changed to use line boxes in the render tree
that might otherwise be out of date.

Reviewed by kocienda

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText):
2:31 PM Changeset in webkit [6981] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3691569> REGRESSION (142): cmd-shift-clicking on a link now also extends selection (even if there wasn't one before)
  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventSingleClick): if there's a URL associated with the event, don't extend the selection
2:08 PM Changeset in webkit [6980] by kocienda
  • 19 edits in trunk/WebCore

Reviewed by Vicki

Added some helper functions which provide strings to display in the
Xcode debugger's variable inspector window. These functions are called
from the LabyrinthDataFormatter debugger plugin I just checked in to
the Labyrinth/Tools directory.

Note that these functions are compiled in on Development builds only.

  • WebCore-combined.exp:
  • WebCore-tests.exp: Export all the formatForDebugger symbols so the debugger program can link with them.
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::formatForDebugger):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::formatForDebugger):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::formatForDebugger):
  • khtml/xml/dom_position.h:
  • khtml/xml/dom_selection.cpp: (DOM::Selection::formatForDebugger):
  • khtml/xml/dom_selection.h:
  • khtml/xml/dom_textimpl.cpp: (TextImpl::formatForDebugger):
  • khtml/xml/dom_textimpl.h:
2:01 PM Changeset in webkit [6979] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fixed <rdar://problem/3721544> crash increasing font size; entrezeroetun.com (works in IE and Firefox)
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter): Check for nil originalString() before dereffing
1:49 PM Changeset in webkit [6978] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3720728> REGRESSION (125.8-146): Crash moving mouse over plugin at manray-photo.com

Reviewed by john.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginScriptableObject]): don't call NPP_GetValue unless the plug-in implements it
1:28 PM Changeset in webkit [6977] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3706296> VIP: ifilm.com crashing reproducibly with Safari

Reviewed by kocienda.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage launchRealPlayer]): don't release a NULL appURL
1:22 PM Changeset in webkit [6976] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3721453, CSS3 initial property caused crashes because the macros were not written correctly.

Reviewed by john

  • khtml/css/cssstyleselector.cpp:
12:33 PM Changeset in webkit [6975] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3650140> reproducible assertion failure going to plugin page with JavaScript disabled

Reviewed by john.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): don't call NPP_NewStream and other stream methods if there is no JS result to deliver. This is what Mozilla does. (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Return NPERR_GENERIC_ERROR if JS is disabled. This is what Mozilla does.
11:46 AM Changeset in webkit [6974] by vicki
  • 3 edits in trunk

change the version number from '151' to '152u'

11:38 AM Changeset in webkit [6973]
  • 3 copies in tags/Safari-151

This commit was manufactured by cvs2svn to create tag 'Safari-151'.

11:38 AM Changeset in webkit [6972] by vicki
  • 6 edits in trunk

Safari-151 stamp!

Note: See TracTimeline for information about the timeline view.