Timeline
Jul 15, 2004:
- 5:05 PM Changeset in webkit [7034] by
-
- 2 edits in trunk/WebCore
Fix for 3625611, images offset on first visit to page. The method for determining the last clean line was
flawed and would incorrectly miss dirty lines that occurred after the first clean line.
Reviewed by john
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::determineEndPosition):
- 10:20 AM Changeset in webkit [7033] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3587601> reproducible assertion failure in Blot deleting text, then image at Yahoo.com
- khtml/editing/htmlediting_impl.cpp: (khtml::DeleteCollapsibleWhitespaceCommandImpl::deleteWhitespace): Relax assertion that nodes are text nodes during the walk of eligible nodes that could possibly be deleted. Change the assertion to an conditional check for text nodes. We may have unrendered nodes in the mix here (as is the case in the bug where the assertion failed on an AREA element), and the conditional check is sufficient to skip them while leaving the delete logic we want unperturbed.
Jul 14, 2004:
- 5:14 PM Changeset in webkit [7032] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by John.
<rdar://problem/3711474>: (REGRESSION (125-146): JavaScript 'toString(16)' is broken)
<rdar://problem/3644873>: (REGRESSION (125-140u): secondary list doesn't fill in at Southwest.com)
- kjs/number_object.cpp: (NumberProtoFuncImp::call): Initialize radix from dradix, not from itself!
- 4:35 PM Changeset in webkit [7031] by
-
- 2 edits in trunk/WebCore
Reviewed by John
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Add null check on DOM node before asking if it is contentEditable.
- 4:03 PM Changeset in webkit [7030] by
-
- 2 edits in trunk/WebCore
Fix for 3595073, setting innerHTML on a <table> should work.
Reviewed by rjw
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment):
- 2:45 PM Changeset in webkit [7029] by
-
- 5 edits in trunk
Reviewed by Hyatt
Updated these layout tests as a result of the last patch.
These results are better.
- layout-tests/editing/execCommand/selectAll-expected.txt
- layout-tests/editing/selection/extend-by-character-006-expected.txt
- layout-tests/editing/selection/unrendered-001-expected.txt
- layout-tests/editing/selection/unrendered-003-expected.txt
- 2:43 PM Changeset in webkit [7028] by
-
- 10 edits in trunk/WebCore
Reviewed by Hyatt
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Change back to start() from caretPosition(). Since the policy is now to move the selection to rendered content, if possible, when the selection is set, there is no longer any reason to have the additional caretPosition() function to store where the caret should be drawn.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): No longer any need to call closestRenderedPosition here. This is done in Selection::validate.
- khtml/xml/dom_position.cpp: (DOM::Position::closestRenderedPosition): Improved algorithm. Now much simpler.
- khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): caretPosition() and m_caretPosition now obsolete. (DOM::Selection::init): Ditto. (DOM::Selection::modifyExtendingRightForward): No longer any need to call closestRenderedPosition here. This is done in Selection::validate. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::layoutCaret): Ditto. (DOM::Selection::validate): Add code to move the selection to rendered content if possible.
- khtml/xml/dom_selection.h: caretPosition() and m_caretPosition now obsolete.
- 2:01 PM Changeset in webkit [7027] by
-
- 2 adds in trunk/LayoutTests/fast/dynamic
Add layout test for dynamic float/position change.
- 1:13 PM Changeset in webkit [7026] by
-
- 2 edits in trunk/WebCore
Fix for 3716082, assert when you dynamically remove float or position styles.
Reviewed by kevin
- khtml/rendering/render_object.cpp: (RenderObject::setStyle):
- 12:56 PM Changeset in webkit [7025] by
-
- 2 adds in trunk/LayoutTests/fast/table
new layout test to cover percentage heights inside auto tables.
- 12:49 PM Changeset in webkit [7024] by
-
- 4 edits in trunk/WebCore
Fix for various table regressions (malumovies.com and cityofheroes.gameamp.com) involving bungling of
percentage heights.
Reviewed by kocienda
- khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight): (RenderBox::availableHeightUsing):
- khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (RenderTableCell::updateFromElement):
- khtml/rendering/render_table.h:
- 12:48 PM Changeset in webkit [7023] by
-
- 3 edits in trunk/WebCore
Reviewed by John
- khtml/xml/dom_position.cpp: (DOM::Position::equivalentDeepPosition): New helper function to improve selection handling. Soon, I plan to land some changes that use this new function.
- khtml/xml/dom_position.h:
- 10:32 AM Changeset in webkit [7022] by
-
- 3 edits in trunk/WebCore
Reviewed by Vicki
- WebCore-combined.exp: Added QString.at symbol to tests exports to facilitate debugging data formatting change that is to come.
- WebCore-tests.exp:
Jul 13, 2004:
- 10:27 PM Changeset in webkit [7021] by
-
- 1 edit2 adds in trunk/JavaScriptCore/tests/mozilla
Reviewed by mjs
- Modified the test driver to spew out each test as it processes it. This is such a good thing to see from a performance perspective because it illustrates which tests JavaScriptCore chokes heavily.
- 5:57 PM Changeset in webkit [7020] by
-
- 2 adds in trunk/JavaScriptCore/tests/mozilla/Getopt
- added a necessary support library for jsDriver.pl
- 5:38 PM Changeset in webkit [7019] by
-
- 1 edit12 adds in trunk/LayoutTests/editing
* empty log message *
- 4:21 PM Changeset in webkit [7018] by
-
- 1 edit in trunk/JavaScriptCore/tests/mozilla/jsDriver.pl
Reviewed by mjs
- added support for the kjs engine type
- 4:00 PM Changeset in webkit [7017] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by kocienda.
- made testkjs and JavaScriptCore a subtarget of 'All'
- testkjs now builds in $SYMROOTS
- JavaScriptCore.pbproj/project.pbxproj:
- 2:50 PM Changeset in webkit [7016] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3705500> REGRESSION (125.8-146): Cmd-E on an HTML page puts a trailing space on Find pasteboard
- khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::handleTextBox): In the case where a subrun doesn't extend to the end of the text box, the well-commented code was supposed to return from this routine, but the wrong variable was being compared. This would send us through another pass of the loop, which would end up worrying about collapsed space at the end of the current box, even though we only cared about the beginning of the current box.
Jul 12, 2004:
- 11:40 PM Changeset in webkit [7015] by
-
- 3 edits in trunk/WebKit
Reviewed by Kevin.
<rdar://problem/3673988>: (REGRESSION(141-144): connection assertion failure at http://traffic.511.org/sfgate)
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Don't check connection consistency if this load got cancelled while finishing, because in this case we have cleared the connection field already. This can happen when a redirect fires from an onload handler.
- 5:26 PM Changeset in webkit [7014] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
<rdar://problem/3632570>: (REGRESSION: SocialText.net wiki keeps asking for auth, even though pages load)
- Misc.subproj/WebIconLoader.m: (-[WebIconLoader didReceiveAuthenticationChallenge:]): Ignore the challenge - we don't want an auth panel for favicons. (-[WebIconLoader didCancelAuthenticationChallenge:]): Ignore cancel, since we are ignoring the challenge.
- 4:57 PM Changeset in webkit [7013]
-
- 12 copies2 deletes in tags/WebCore-85~6~1
This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~1'.
- 4:57 PM Changeset in webkit [7012] by
-
- 2 edits in branches/Safari-1-0-branch/WebCore
fix CFBundleShortVersionString in WebCore. This should be 1.0.2, the Safari marketing version for the last update on Jaguar.
- 4:33 PM Changeset in webkit [7011] by
-
- 2 edits in trunk/WebCore
Fixed 3717982. Implemented navigator.language!
Reviewed by John.
- khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty):
- 4:01 PM Changeset in webkit [7010] by
-
- 2 adds in trunk/LayoutTests/fast/css
Reviewed by Dave
Added a layout test for css 'width:auto'
- 3:58 PM Changeset in webkit [7009] by
-
- 2 edits in trunk/WebCore/khtml/rendering
Back out my changes to the fix for my previous checkin, since it broke the inline-block layout test.
- 3:30 PM Changeset in webkit [7008] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Reviewed by me
Remove cvs conflict indicators from ChangeLog
- 3:29 PM Changeset in webkit [7007] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
- khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent): I broke selection drawing with my last patch. This function is now used in selection drawing, and it was making an unneeded check to see that content was editable to answer whether or not is was rendered. Bad. Fixed.
- 3:26 PM Changeset in webkit [7006] by
-
- 3 edits in trunk/WebCore
Fix for 3621138, crash on hrweb.apple.com. Make sure that in the case where objects get pulled up from merging
blocks that we just delete all line boxes.
Reviewed by kocienda
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):
- 3:03 PM Changeset in webkit [7005] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
<rdar://problem/3706080>: (REGRESSION (125.8-147u): Nested <ul> do not display bullets)
<rdar://problem/3676376>: (Second level bullets not printed when printing Xcode release notes)
- kwq/KWQPainter.h:
- kwq/KWQPainter.mm: (CGColorFromNSColor): (QPainter::drawEllipse): (QPainter::setShadow):
- 2:57 PM Changeset in webkit [7004] by
-
- 1 edit20 adds in trunk
Reviewed by me
Added new editing-related layout tests
- layout-tests/editing/deleting/delete-after-span-ws-001-expected.txt: Added.
- layout-tests/editing/deleting/delete-after-span-ws-001.html: Added.
- layout-tests/editing/deleting/delete-after-span-ws-002-expected.txt: Added.
- layout-tests/editing/deleting/delete-after-span-ws-002.html: Added.
- layout-tests/editing/deleting/delete-after-span-ws-003-expected.txt: Added.
- layout-tests/editing/deleting/delete-after-span-ws-003.html: Added.
- layout-tests/editing/selection/unrendered-001-expected.txt: Added.
- layout-tests/editing/selection/unrendered-001.html: Added.
- layout-tests/editing/selection/unrendered-002-expected.txt: Added.
- layout-tests/editing/selection/unrendered-002.html: Added.
- layout-tests/editing/selection/unrendered-003-expected.txt: Added.
- layout-tests/editing/selection/unrendered-003.html: Added.
- layout-tests/editing/selection/unrendered-004-expected.txt: Added.
- layout-tests/editing/selection/unrendered-004.html: Added.
- layout-tests/editing/selection/unrendered-005-expected.txt: Added.
- layout-tests/editing/selection/unrendered-005.html: Added.
- layout-tests/traversal/node-iterator-008-expected.txt: Added.
- layout-tests/traversal/node-iterator-008.html: Added.
- layout-tests/traversal/tree-walker-005-expected.txt: Added.
- layout-tests/traversal/tree-walker-005.html: Added.
- 2:51 PM Changeset in webkit [7003] by
-
- 7 edits in trunk/WebCore
Reviewed by Hyatt
Fixes for these bugs:
<rdar://problem/3723359> Extending then "unextending" selection with arrow keys should draw caret but doesn't
<rdar://problem/3724626> White-space deletion code deletes wrong character when space follows span
- khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): Modify special-case white-space deletion code so it runs only in the special case. It was throwing its net too widely, catching the case described in 3724626. By tightening up the special-case white-space deletion, and allowing the more general-purpose code to run, the bug is fixed.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Use recently-added closestRenderedPosition helper in Position class to figure out the start and end positions for selection drawing.
- khtml/xml/dom_position.cpp: (DOM::Position::equivalentUpstreamPosition): Added code to handle white-space that causes line breaks. (DOM::Position::equivalentDownstreamPosition): Ditto. (DOM::Position::closestRenderedPosition): Trap empty selections at function entry, return *this. (DOM::Position::isFirstRenderedPositionOnLine): Can't be first rendered position on line if not rendered. Add check for this. (DOM::Position::isLastRenderedPositionOnLine): Ditto, but s/first/last/
- khtml/xml/dom_selection.cpp: (DOM::Selection::validate): A selection is in caret state if the start and end are equal *or* equivalent. The equivalence case is new, and fixes 3723359.
- 1:13 PM Changeset in webkit [7002] by
-
- 4 edits in trunk/LayoutTests/fast
Fix the fast layout tests.
- 12:02 AM Changeset in webkit [7001]
-
- 9 copies2 deletes in tags/WebKit-85~7~1
This commit was manufactured by cvs2svn to create tag
'WebKit-85~7~1'.
- 12:02 AM Changeset in webkit [7000]
-
- 9 copies2 deletes in branches/WebKit-85~7-branch
This commit was manufactured by cvs2svn to create branch
'WebKit-85~7-branch'.
- 12:02 AM Changeset in webkit [6999]
-
- 9 copies2 deletes in tags/WebKit-85~7-anchor
This commit was manufactured by cvs2svn to create tag
'WebKit-85~7-anchor'.
- 12:02 AM Changeset in webkit [6998] by
-
- 2 edits in branches/Safari-1-0-branch/WebKit
- fix CFBundleShortVersionString in WebKit. This should be 1.0.2, the Safari marketing version for the last update on Jaguar, not 1.0.3, which is the "Macromedia fixes" version that has not yet shipped
Jul 11, 2004:
- 11:49 PM Changeset in webkit [6997] by
-
- 2 edits in branches/Safari-1-0-branch/WebKit
- versioning for July Security Update (WebKit-85.7.1), and a bit of cleanup to the Changelog. We had already rolled a fix for Safari 1.0.3 to the branch, but do not want to include this in the Security Update.
