Timeline
Jul 17, 2004:
- 9:59 PM Changeset in webkit [7050]
-
- 63 copies2 deletes in tags/WebCore-125~8
This commit was manufactured by cvs2svn to create tag
'WebCore-125~8'.
- 9:59 PM Changeset in webkit [7049] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
- versioning for next SUPanMoccasin submission (SAP fixes), WebCore-125.8
- 9:57 PM Changeset in webkit [7048] by
-
- 3 edits in branches/Safari-1-2-branch/WebCore
Roll this Security Update change out for the next SUPanMoccasin
submission. Security Update changes can't be included in Software
Updates.
2004-07-09 Chris Blumenberg <cblu@apple.com>
Allowed my change for 3715785 to compile on Jaguar.
Reviewed by kocienda.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar
Jul 16, 2004:
- 3:56 PM Changeset in webkit [7047] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fixed <rdar://problem/3714644> REGRESSION (125.8-146): bugzilla submit link hangs browser with javascript
- kjs/array_object.cpp: (ArrayProtoFuncImp::call): Check for undefined type for args[0] the same way we were already checking for args[1]. In this case, args was zero-length, but we were treating args[0] like an integer anyway. Resulted in some code looping from a NAN value to 4, taking approximately forever.
- JavaScriptCore.pbproj/project.pbxproj: version wars
- 3:20 PM Changeset in webkit [7046] by
-
- 2 edits in trunk/WebCore
Fix for 3726471, need to ensure that it's safe to do updateRendering from within layout, since isContentEditable
relies on it. The fix is to just recalcStyle up front before beginning the layout, so that all of our renderobjects
will be up-to-date.
Reviewed by john
- khtml/khtmlview.cpp: (KHTMLView::layout):
- 2:51 PM Changeset in webkit [7045] by
-
- 3 edits in branches/Safari-1-2-branch/WebCore
Reviewed by vicki.
- merge these changes from HEAD for SUPanMoccasin, 3730021
2004-07-06 Ken Kocienda <kocienda@apple.com>
Reviewed by me
- khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild): Added a better comment in the code I just checked in a few minutes ago.
2004-07-06 Ken Kocienda <kocienda@apple.com>
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3672377> assertion failure in AppendNodeCommandImpl::doApply
due to non-0 exception code trying to insert a DIV markup string
The solution was to revert to the code that was rolled out, and removing
the child checks from NodeImpl::checkAddChild. However, this time, I added
code very similar to this check into the code that runs while HTML is
being parsed to build up tables. This code relies on child-add failure
to ensure the proper construction of well-formed tables (as gross as that
sounds), so the check needs to be retained there. No other code seems to
be so affected. Layout tests are unchanged by this patch.
- khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::addChild):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild):
- 2:29 PM Changeset in webkit [7044] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
Reviewed by vicki.
- merge this change from HEAD for SUPanMoccasin, 3730017
2004-07-14 David Hyatt <hyatt@apple.com>
Fix for 3595073, setting innerHTML on a <table> should work.
Reviewed by rjw
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment):
- 2:19 PM Changeset in webkit [7043] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3722153> Random crash while typing (DOM::NodeImpl::parentNode (this=0x0))
- khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): This check merely makes the code more robust. I do not understand how Grant ended up with null start or end blocks in the case of his bug report, but by adding two null checks, the code is now hardened a bit in case it happens again.
- 2:14 PM Changeset in webkit [7042] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt
Fix for these bugs:
<rdar://problem/3730785> Crash when arrow navigation goes to empty table cell
<rdar://problem/3730790> Caret does not blink when placed in empty table cell
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Caret node's renderer might be this block, so don't block the painting of the caret in this case. This was the case in 3730790. We had the right geometry for the caret but blocked its painting.
- khtml/xml/dom_position.cpp: (DOM::Position::previousLinePosition): Rework the logic here. This function asserted that the new position we would navigate to had a line box, but empty table cells, for instance will not. So, deal with this situation as well. The end result is a function that worked like it did before in cases where the previous line position has a line box, but now also will allow navigation to work when it does not. (DOM::Position::nextLinePosition): Ditto.
- 1:37 PM Changeset in webkit [7041] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3687216> editable inline causes crash when focused
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::relinquishesEditingFocus): Add null check for rootEditableElement. (DocumentImpl::acceptsEditingFocus): Ditto.
- 1:25 PM Changeset in webkit [7040] by
-
- 2 edits in trunk/LayoutTests
Return Panther baseline to layout tests.
- 1:17 PM Changeset in webkit [7039] by
-
- 2 adds in trunk/LayoutTests/fast/compact
Add a layout test for the crashing compact case.
- 1:15 PM Changeset in webkit [7038] by
-
- 2 edits in trunk/WebCore
Fix for 3709337, crash when using display: compact. Need to make sure that the isCompact() check in bidi.cpp is
also checking for RenderBlocks, since otherwise you match text nodes (and that's just wrong).
Reviewed by kocienda
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
- 11:00 AM Changeset in webkit [7037] by
-
- 3 edits in trunk
change version number to '153u'. the tree is open!
- 10:55 AM Changeset in webkit [7036]
-
- 3 copies in tags/Safari-152
This commit was manufactured by cvs2svn to create tag 'Safari-152'.
- 10:55 AM Changeset in webkit [7035] by
-
- 6 edits in trunk
Safari-152 stamp
Jul 15, 2004:
- 5:05 PM Changeset in webkit [7034] by
-
- 2 edits in trunk/WebCore
Fix for 3625611, images offset on first visit to page. The method for determining the last clean line was
flawed and would incorrectly miss dirty lines that occurred after the first clean line.
Reviewed by john
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::determineEndPosition):
- 10:20 AM Changeset in webkit [7033] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3587601> reproducible assertion failure in Blot deleting text, then image at Yahoo.com
- khtml/editing/htmlediting_impl.cpp: (khtml::DeleteCollapsibleWhitespaceCommandImpl::deleteWhitespace): Relax assertion that nodes are text nodes during the walk of eligible nodes that could possibly be deleted. Change the assertion to an conditional check for text nodes. We may have unrendered nodes in the mix here (as is the case in the bug where the assertion failed on an AREA element), and the conditional check is sufficient to skip them while leaving the delete logic we want unperturbed.
Jul 14, 2004:
- 5:14 PM Changeset in webkit [7032] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by John.
<rdar://problem/3711474>: (REGRESSION (125-146): JavaScript 'toString(16)' is broken)
<rdar://problem/3644873>: (REGRESSION (125-140u): secondary list doesn't fill in at Southwest.com)
- kjs/number_object.cpp: (NumberProtoFuncImp::call): Initialize radix from dradix, not from itself!
- 4:35 PM Changeset in webkit [7031] by
-
- 2 edits in trunk/WebCore
Reviewed by John
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Add null check on DOM node before asking if it is contentEditable.
- 4:03 PM Changeset in webkit [7030] by
-
- 2 edits in trunk/WebCore
Fix for 3595073, setting innerHTML on a <table> should work.
Reviewed by rjw
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment):
- 2:45 PM Changeset in webkit [7029] by
-
- 5 edits in trunk
Reviewed by Hyatt
Updated these layout tests as a result of the last patch.
These results are better.
- layout-tests/editing/execCommand/selectAll-expected.txt
- layout-tests/editing/selection/extend-by-character-006-expected.txt
- layout-tests/editing/selection/unrendered-001-expected.txt
- layout-tests/editing/selection/unrendered-003-expected.txt
- 2:43 PM Changeset in webkit [7028] by
-
- 10 edits in trunk/WebCore
Reviewed by Hyatt
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject): Change back to start() from caretPosition(). Since the policy is now to move the selection to rendered content, if possible, when the selection is set, there is no longer any reason to have the additional caretPosition() function to store where the caret should be drawn.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): No longer any need to call closestRenderedPosition here. This is done in Selection::validate.
- khtml/xml/dom_position.cpp: (DOM::Position::closestRenderedPosition): Improved algorithm. Now much simpler.
- khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): caretPosition() and m_caretPosition now obsolete. (DOM::Selection::init): Ditto. (DOM::Selection::modifyExtendingRightForward): No longer any need to call closestRenderedPosition here. This is done in Selection::validate. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::layoutCaret): Ditto. (DOM::Selection::validate): Add code to move the selection to rendered content if possible.
- khtml/xml/dom_selection.h: caretPosition() and m_caretPosition now obsolete.
- 2:01 PM Changeset in webkit [7027] by
-
- 2 adds in trunk/LayoutTests/fast/dynamic
Add layout test for dynamic float/position change.
- 1:13 PM Changeset in webkit [7026] by
-
- 2 edits in trunk/WebCore
Fix for 3716082, assert when you dynamically remove float or position styles.
Reviewed by kevin
- khtml/rendering/render_object.cpp: (RenderObject::setStyle):
- 12:56 PM Changeset in webkit [7025] by
-
- 2 adds in trunk/LayoutTests/fast/table
new layout test to cover percentage heights inside auto tables.
- 12:49 PM Changeset in webkit [7024] by
-
- 4 edits in trunk/WebCore
Fix for various table regressions (malumovies.com and cityofheroes.gameamp.com) involving bungling of
percentage heights.
Reviewed by kocienda
- khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight): (RenderBox::availableHeightUsing):
- khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (RenderTableCell::updateFromElement):
- khtml/rendering/render_table.h:
- 12:48 PM Changeset in webkit [7023] by
-
- 3 edits in trunk/WebCore
Reviewed by John
- khtml/xml/dom_position.cpp: (DOM::Position::equivalentDeepPosition): New helper function to improve selection handling. Soon, I plan to land some changes that use this new function.
- khtml/xml/dom_position.h:
- 10:32 AM Changeset in webkit [7022] by
-
- 3 edits in trunk/WebCore
Reviewed by Vicki
- WebCore-combined.exp: Added QString.at symbol to tests exports to facilitate debugging data formatting change that is to come.
- WebCore-tests.exp:
Jul 13, 2004:
- 10:27 PM Changeset in webkit [7021] by
-
- 1 edit2 adds in trunk/JavaScriptCore/tests/mozilla
Reviewed by mjs
- Modified the test driver to spew out each test as it processes it. This is such a good thing to see from a performance perspective because it illustrates which tests JavaScriptCore chokes heavily.
- 5:57 PM Changeset in webkit [7020] by
-
- 2 adds in trunk/JavaScriptCore/tests/mozilla/Getopt
- added a necessary support library for jsDriver.pl
- 5:38 PM Changeset in webkit [7019] by
-
- 1 edit12 adds in trunk/LayoutTests/editing
* empty log message *
- 4:21 PM Changeset in webkit [7018] by
-
- 1 edit in trunk/JavaScriptCore/tests/mozilla/jsDriver.pl
Reviewed by mjs
- added support for the kjs engine type
- 4:00 PM Changeset in webkit [7017] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by kocienda.
- made testkjs and JavaScriptCore a subtarget of 'All'
- testkjs now builds in $SYMROOTS
- JavaScriptCore.pbproj/project.pbxproj:
- 2:50 PM Changeset in webkit [7016] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3705500> REGRESSION (125.8-146): Cmd-E on an HTML page puts a trailing space on Find pasteboard
- khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::handleTextBox): In the case where a subrun doesn't extend to the end of the text box, the well-commented code was supposed to return from this routine, but the wrong variable was being compared. This would send us through another pass of the loop, which would end up worrying about collapsed space at the end of the current box, even though we only cared about the beginning of the current box.
