Timeline



Jul 21, 2004:

11:42 AM Changeset in webkit [7086] by kocienda
  • 10 edits in trunk

WebCore:

Reviewed by John

  • khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Add LINE_BOUNDARY case to the switch statement in this function. Use the startAndEndLineNodesIncludingNode helper which already existed to get the right position. (DOM::Selection::modifyMovingRightForward): Ditto (DOM::Selection::modifyExtendingLeftBackward): Ditto (DOM::Selection::modifyMovingLeftBackward): Ditto
  • khtml/xml/dom_selection.h: (DOM::Selection::): Add LINE_BOUNDARY constant to ETextGranularity enum. This specifies a new kind of movement that we need to implement the "move-to beggining/end of line" behavior which AppKit binds to cmd+left/right arrow keys.
  • kwq/WebCoreBridge.h: Add WebSelectToLineBoundary constant. This matches

WebKit:

Reviewed by John

Add implementations for these methods. Formerly, they logged an error.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView moveToBeginningOfLine:]): (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]): (-[WebHTMLView moveToEndOfLine:]): (-[WebHTMLView moveToEndOfLineAndModifySelection:]):
10:47 AM Changeset in webkit [7085] by kocienda
  • 4 edits in trunk/WebKit

Reviewed by John

Added some more handlers for standard Cocoa key bindings.
These are "secrets" of NSText, meaning they are not public API, but we choose to mimic.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]): (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): (-[WebHTMLView moveToEndOfLineAndModifySelection:]): (-[WebHTMLView moveToEndOfParagraph:]): (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]):
  • WebView.subproj/WebView.h: Add these declarations to the comment in the header listing the responder-like methods we support.
  • WebView.subproj/WebView.m: (-[WebView moveToBeginningOfParagraphAndModifySelection:]): (-[WebView moveToEndOfParagraphAndModifySelection:]): (-[WebView moveToBeginningOfLineAndModifySelection:]): (-[WebView moveToEndOfLineAndModifySelection:]): (-[WebView moveToBeginningOfDocumentAndModifySelection:]): (-[WebView moveToEndOfDocumentAndModifySelection:]):
9:09 AM Changeset in webkit [7084] by darin
  • 2 edits in trunk/JavaScriptCore
  • bindings/npruntime.h: Fixed typo.

Jul 20, 2004:

5:00 PM Changeset in webkit [7083]
  • 21 copies
    3 deletes in tags/WebKit-125~4~1

This commit was manufactured by cvs2svn to create tag
'WebKit-125~4~1'.

5:00 PM Changeset in webkit [7082] by darin
  • 2 edits in branches/Safari-1-2-branch/WebKit

Set version to 125.4.1.

4:52 PM Changeset in webkit [7081] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3714434, user stylesheet is always parsed in strict mode, when it should honor the document's setting.

Reviewed by john

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector):
4:49 PM Changeset in webkit [7080]
  • 20 copies
    3 deletes in tags/WebKit-125~4

This commit was manufactured by cvs2svn to create tag 'WebKit-125~4'.

4:49 PM Changeset in webkit [7079] by darin
  • 1 edit in branches/WebKit-125~4-branch/WebKit/WebKit.pbproj/project.pbxproj

Update version to 125.4.

4:48 PM Changeset in webkit [7078] by darin
  • 1 edit in branches/WebKit-125~4-branch/WebKit/ChangeLog
  • merge this fix from HEAD for SUPanMoccasin

2004-07-20 Richard Williamson <​rjw@apple.com>

Fix for 3728558. Fixed the key event handling in the carbon/cocoa
integration code. This does not fix the arrow keys not working on
initial focus problem also mentioned in the bug.

Reviewed by John.

  • Carbon.subproj/HIWebView.m: (OwningWindowChanged): (WindowHandler):
4:32 PM Changeset in webkit [7077] by kocienda
  • 6 edits in trunk

WebCore:

Reviewed by Richard

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::defaultEventHandler): No longer check whether the command key is modifying the key event. This check is now done elsewhere in the code. See the WebKit checkin that added the _web_keyBindingManagerHasBinding method to WebNSEventExtras.

WebKit:

Reviewed by Richard

  • Misc.subproj/WebNSEventExtras.h: Added helper that returns whether a key event has a binding in the key binding manager.
  • Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_keyBindingManagerHasBinding]): New helper mentioned above.
  • Plugins.subproj/npruntime.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]): Add a check of whether the key event has a binding in the key binding manager. This works around the fact that NSResponder's interpretKeyEvents does not return a value telling whether or not the key was handled. This now makes it possible for us to trap modified key events we know we can handle (like those command-key + arrow events used for text navigation), while letting all others pass.
4:17 PM Changeset in webkit [7076] by darin
  • 2 edits in branches/Safari-1-2-branch/WebKit
  • merge this fix from HEAD for SUPanMoccasin and the July Security Update

2004-07-20 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris.

<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames that are in the same window (Mozilla does this too).
4:14 PM Changeset in webkit [7075]
  • 20 copies
    3 deletes in branches/WebKit-125~4-branch

This commit was manufactured by cvs2svn to create branch
'WebKit-125~4-branch'.

4:14 PM Changeset in webkit [7074]
  • 20 copies
    3 deletes in tags/WebKit-125~4-anchor

This commit was manufactured by cvs2svn to create tag
'WebKit-125~4-anchor'.

4:14 PM Changeset in webkit [7073] by darin
  • 2 edits in branches/Safari-1-2-branch/WebKit
  • merge this fix from HEAD for SUPanMoccasin

2004-07-20 Richard Williamson <​rjw@apple.com>

Fix for 3728558. Fixed the key event handling in the carbon/cocoa
integration code. This does not fix the arrow keys not working on
initial focus problem also mentioned in the bug.

Reviewed by John.

  • Carbon.subproj/HIWebView.m: (OwningWindowChanged): (WindowHandler):
3:27 PM Changeset in webkit [7072] by cblu
  • 5 edits in trunk

WebCore:

Fixed:
<rdar://problem/3580589> REGRESSION (1.1-1.2): can't open a new window for an image that has not loaded
<rdar://problem/3612691> Missing image icons (blue ?) lack context menu

Reviewed by john.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if there is no image, put the image URL on the element anyway

WebKit:

Fixed:
<rdar://problem/3580589> REGRESSION (1.1-1.2): can't open a new window for an image that has not loaded
<rdar://problem/3612691> Missing image icons (blue ?) lack context menu

Reviewed by john.

  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): if there is no image, but there is an image URL, provide image context menu items besides "Copy Image"
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): don't drag an image with an actual image (-[WebHTMLView _mayStartDragAtEventLocation:]): ditto

WebBrowser:

Fixed:
<rdar://problem/3580589> REGRESSION (1.1-1.2): can't open a new window for an image that has not loaded
<rdar://problem/3612691> Missing image icons (blue ?) lack context menu

Reviewed by john.

  • ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): if there is no image, but there is an image URL, provide image context menu items besides copy and save menu items.
  • WebBrowser.pbproj/project.pbxproj:
3:11 PM Changeset in webkit [7071] by hyatt
  • 6 edits in trunk/LayoutTests/fast

Reduced size of error images which affects test and fixed alt scaling bugs.

2:58 PM Changeset in webkit [7070] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Chris.

<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame

  • Plugins.subproj/npruntime.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames that are in the same window (Mozilla does this too).
2:54 PM Changeset in webkit [7069] by hyatt
  • 2 edits in trunk/WebCore

Fix for alt text not working on images.

Reviewed by john

  • khtml/rendering/render_image.cpp: (RenderImage::RenderImage): (RenderImage::setPixmap): (RenderImage::paint): (RenderImage::calcReplacedWidth): (RenderImage::calcReplacedHeight):
1:45 PM Changeset in webkit [7068] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3720111> REGRESSION(125-152): map fails to load depending on banner ad; weather.com (works in IE and Firefox)

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): Initialize currentPrependingSrc. (khtml::HTMLTokenizer::scriptHandler): Store a pointer to the currently active prependingSrc variable on the stack, the better to handle weird cases of scripts writing out additional script tags and so forth. (khtml::HTMLTokenizer::write): Deal with the above.
  • khtml/html/htmltokenizer.h: Declare new member field.
1:41 PM Changeset in webkit [7067] by rjw
  • 4 edits in trunk/WebKit

Fix for 3728558. Fixed the key event handling in the carbon/cocoa
integration code. This does not fix the arrow keys not working on
initial focus problem also mentioned in the bug.

Bumped the version of the NP function structures.

Reviewed by John.

  • Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
  • Carbon.subproj/HIWebView.m: (OwningWindowChanged): (WindowHandler):
  • Plugins.subproj/npapi.h:
1:39 PM Changeset in webkit [7066] by hyatt
  • 2 edits
    2 adds in trunk/LayoutTests/fast/overflow

Add overflow test and fix rss test to not be rss.

1:35 PM Changeset in webkit [7065] by hyatt
  • 2 edits in trunk/WebCore

Fix for layer positioning error that occurs when absolute positioned blocks are inside static positioned overflow:auto
elements.

Reviewed by john

  • khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
12:05 PM Changeset in webkit [7064] by trey
  • 2 edits in trunk/WebKit

3733698 REGRESSION: sometimes dragging photos on homepage.mac.com leads to an assertion

Relax an assertion, as we ran into a valid case where it's not true.

Reviewed by Chris.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Removing this assert allows for the oddball case of a drag gesture that starts on one element, but then the element is no longer there when the drag is about to start.
11:56 AM Changeset in webkit [7063] by trey
  • 2 edits in trunk/WebCore

3705624 REGRESSION: can't rearrange photos on homepage.mac.com album

A subtle problem stemming from some interaction between focus handing and
event propagation. We previously made it so when a focus shift fails we
don't propagate the event to KHTML. The fix is to get rid of the inverse
effect, so now even if a focus shift succeeds, we don't propagate to KHTML if
the page already canceled default behavior.

In this specific case, the page is cancelling default behavior since it
does its own dragging, and the bug was our new system dragging was
kicking in.

Reviewed by Ken.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): What he said.
11:06 AM Changeset in webkit [7062] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3695240> pasting plain text with newlines in it turns them into spaces

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithText:]): Refine this function to be smart about converting line endings into BR elements.
8:38 AM Changeset in webkit [7061] by kocienda
  • 9 edits in trunk

WebCore:

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3707505> HTMLCompose: blinking cursor in both an address text field and the message body

  • khtml/khtml_part.cpp: (KHTMLPart::setCaretVisible): This method renamed from setSelectionVisible. Since it really only operates on the caret, this seems like a better name.
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::focusInEvent): Call setCaretVisible(true) (KHTMLView::focusOutEvent): Call setCaretVisible(false)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setShowsFirstResponder): Name change: setSelectionVisible becomes setCaretVisible.
  • kwq/WebCoreBridge.h: Expose setCaretVisible as a bridge method.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setCaretVisible:]): Ditto.

WebKit:

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3707505> HTMLCompose: blinking cursor in both an address text field and the message body

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView setCaretVisible:]): New helper. Calls over bridge to do the work. (-[WebHTMLView windowDidBecomeKey:]): This function cannot just assume that self is first responder (and do things like adjusting text background color and restoring focus rings). First-responder-ness needs to be checked first. Now it is. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView becomeFirstResponder]): Call new helper to make caret visible. (-[WebHTMLView resignFirstResponder]): Call new helper to make caret invisible.
1:12 AM Changeset in webkit [7060] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Trey.

<rdar://problem/3721428> REGRESSION (125.8-146): external javascript statements produce extra garbage character (sina.com)

  • khtml/misc/stringit.h: (khtml::TokenizerSubstring::TokenizerSubstring): For the apple branch, use the new stableUnicode() method to get the unicode pointer.
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (QString::detachIfInternal): Reorganize this to be a bit less wacky about refcounts. It does not leave around a zombie internal data handle but rather destroys it right away, and leaves the object pointing to the new handle (which it can then deref). This makes the code more clear. (QString::~QString): Simplify. (QString::stableUnicode): New method that detaches a copy of the KWQStringData if it is internal to a string besides this one. This guarantees that if you get the unicode() pointer, it won't go bad so long as this string is still alive.

Jul 19, 2004:

4:43 PM Changeset in webkit [7059] by sullivan
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • bulletproofed array.slice() against NAN arguments. Harri noticed this vulnerability in my patch for 3714644
  • kjs/array_object.cpp: (ArrayProtoFuncImp::call): handle NAN parameters passed to slice() by clamping to 0 and length.
4:34 PM Changeset in webkit [7058] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

* empty log message *

4:33 PM Changeset in webkit [7057] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3715117, crash from a bug in removeChildren. Clean up node removal and fix an n-squared removal
bug. Also clean up checks in removeChild and in the dispatch of removedFromDocument mutation events to
make node removal more efficient.

Reviewed by kocienda

  • khtml/xml/dom_nodeimpl.cpp:
3:40 PM Changeset in webkit [7056] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Trey.

  • fixed <rdar://problem/3141150> can't undo in form textarea fields
  • kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): call setAllowsUndo:YES. My, wasn't this easy?
3:32 PM Changeset in webkit [7055] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed 3733349. Prevent Java applet callbacks into JavaScript after applet
has been destroyed.

Reviewed by John.

  • bindings/jni/jni_jsobject.cpp: (JSObject::invoke): (JSObject::JSObject):
3:32 PM Changeset in webkit [7054] by rjw
  • 3 edits in trunk/WebKit

Fixed 3721917. The RealPlayer plugin doesn't support the new
NPPVpluginScriptableNPObject variable passed to NPP_GetValue and
incorrectly returns NPERR_NO_ERROR. We interpret this to the
mean the variable has been set. The variable has not been set
and will consequently be uninitialized.

Reviewed by NOBODY (OOPS!).

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginScriptableObject]):
2:50 PM Changeset in webkit [7053] by hyatt
  • 4 edits in trunk

Merge @import fix for CSS1 test suite from Stephan Kulow.

Reviewed by hyatt

  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
  • layout-tests/css1/basic/containment-expected.txt:
2:40 PM Changeset in webkit [7052] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3718697, crash clicking on JS tab at alaskaair.com.

Reviewed by kocienda

  • khtml/rendering/render_flow.cpp: (RenderFlow::detach): (RenderFlow::dirtyLinesFromChangedChild):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_object.cpp: (RenderObject::dirtyLinesFromChangedChild):
  • khtml/rendering/render_object.h:
1:58 PM Changeset in webkit [7051] by kocienda
  • 5 edits in trunk/WebKit

Reviewed by Richard

Fix for this bug:

<rdar://problem/3707504> HTMLCompose: key events are stolen by Web(HTML)View

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView firstResponderIsSelfOrDescendantView]): New helper to (-[WebHTMLView performKeyEquivalent:]): Do not pass key events through to the editing key handler unless the WebHTMLView is first responder or contains the first responder. This prevents the "stealing" of key events mentioned in the bug.
  • WebView.subproj/WebView.m: (-[WebView _performResponderOperation:with:]): Uses the new firstResponderIsSelfOrDescendantView helper. The code I replaced used the same logic as the new helper.

Jul 17, 2004:

9:59 PM Changeset in webkit [7050]
  • 63 copies
    2 deletes in tags/WebCore-125~8

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8'.

9:59 PM Changeset in webkit [7049] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • versioning for next SUPanMoccasin submission (SAP fixes), WebCore-125.8
9:57 PM Changeset in webkit [7048] by vicki
  • 3 edits in branches/Safari-1-2-branch/WebCore

Roll this Security Update change out for the next SUPanMoccasin
submission. Security Update changes can't be included in Software
Updates.

2004-07-09 Chris Blumenberg <​cblu@apple.com>

Allowed my change for 3715785 to compile on Jaguar.

Reviewed by kocienda.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar
Note: See TracTimeline for information about the timeline view.