Timeline
Jul 26, 2004:
- 4:25 PM Changeset in webkit [7128] by
-
- 3 edits in trunk/WebKit
Fixed 3739737. When setting the focus to a NSView, set the focus
carbon focus to kControlIndicatorPart. kControlIndicatorPart is a
placeholder value for use to indicate that Cocoa has the focus.
Reviewed by Ken.
- Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter makeFirstResponder:]):
- Carbon.subproj/HIWebView.m: (Click): (SetFocusPart):
- 4:13 PM Changeset in webkit [7127] by
-
- 2 edits in trunk/WebCore
Fixed: WebView scrolls to the top after making an editing change via drag & drop
Fixed by Ken, reviewed by me.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureCaretVisible]): do nothing if the selection is not a caret
- 4:13 PM Changeset in webkit [7126] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3689734> dragging to an editable WebView does not scroll document
Reviewed by rjw.
- WebView.subproj/WebView.m: (-[WebView documentViewAtWindowPoint:]): new, factored from draggingDocumentViewAtWindowPoint: (-[WebView _draggingDocumentViewAtWindowPoint:]): call documentViewAtWindowPoint: (-[WebView _autoscrollForDraggingInfo:timeDelta:]): forward call to the document view (-[WebView _shouldAutoscrollForDraggingInfo:]): ditto
- 4:09 PM Changeset in webkit [7125] by
-
- 3 edits in trunk
change version number to 154u, 2.0
- 4:01 PM Changeset in webkit [7124]
-
- 3 copies in tags/Safari-153
This commit was manufactured by cvs2svn to create tag 'Safari-153'.
- 4:01 PM Changeset in webkit [7123] by
-
- 6 edits in trunk
Safari-153 stamp
- 3:45 PM Changeset in webkit [7122] by
-
- 2 edits9 adds in trunk
Reviewed by John.
<rdar://problem/3740855> REGRESSION: Flash incorrectly positioned at macromedia.com
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptExecution): Do the prepending-src trick as for inline script execution.
Added new layout tests covering this and other recent tokenizer
bugs.
- layout-tests/fast/tokenizer/001-expected.txt: Added.
- layout-tests/fast/tokenizer/001.html: Added.
- layout-tests/fast/tokenizer/002-expected.txt: Added.
- layout-tests/fast/tokenizer/002.html: Added.
- layout-tests/fast/tokenizer/003-expected.txt: Added.
- layout-tests/fast/tokenizer/003.html: Added.
- layout-tests/fast/tokenizer/resources/003-script.js: Added.
- 3:31 PM Changeset in webkit [7121] by
-
- 8 edits1 delete in trunk/JavaScriptCore
Changes done by Darin, reviewed by Kevin.
- changed testkjs to build in Xcode rather than from Makefile
- .cvsignore: Removed obsolete files from this list.
- Makefile.am: Removed code to build testkjs; we do this in Xcode now. Changed to build target "All" rather than default target. This makes us build the testkjs test tool.
- dummy.cpp: Removed.
- kjs/.cvsignore: Removed obsolete files from this list, including the testkjs tool, which is now built in the symroots directory.
- kjs/testkjs.cpp: Added copyright notice that was missing, since we have changed this file. Also this has the nice side effect of causing the tool to be rebuilt in the new location even if there are no other changes in your tree when you check this out.
- tests/mozilla/run-mozilla-tests: Invoke perl explicitly so this works without setting the execute bit on jsDriver.pl.
- 2:13 PM Changeset in webkit [7120] by
-
- 5 edits in branches/Safari-1-0-branch/WebKit
Fix for 3739752. We now clear the carbon control focus when setting
the focus on a Cocoa NSView. When a carbon control receives a click we de-focus any Cocoa NSView. This fixes the problem, but we still
have 3739736, which may never be fixed for Jaguar.
Reviewed by Ken.
- Carbon.subproj/CarbonWindowAdapter.h:
- Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter relinquishFocus]): (-[CarbonWindowAdapter makeFirstResponder:]):
- Carbon.subproj/HIWebView.m: (Click): (OwningWindowChanged): (WindowHandler):
- WebKit.pbproj/project.pbxproj:
- 11:34 AM Changeset in webkit [7119]
-
- 21 copies3 deletes in tags/WebKit-125~4~2
This commit was manufactured by cvs2svn to create tag
'WebKit-125~4~2'.
- 11:34 AM Changeset in webkit [7118] by
-
- 2 edits in branches/Safari-1-2-branch/WebKit
- WebKit-125.4.2 stamp
- 10:58 AM Changeset in webkit [7117] by
-
- 2 edits in branches/Safari-1-2-branch/WebKit
- fix 3721690 bug fix so it compiles
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Change this so it compiles.
Jul 23, 2004:
- 4:17 PM Changeset in webkit [7116] by
-
- 8 edits in trunk
WebCore:
Reviewed by Trey
Fix for this bug:
<rdar://problem/3738920> Caret blinks in inactive window
As part of the fix, I cleaned up the way we handle special drawing that needs
to be done in the HTML view that is first responder in the key window (e.g the
drawing of text selection highlight and caret blinking).
- khtml/khtml_part.cpp: Removed setCaretVisible function. Updating caret visibility is now done in setDisplaysWithFocusAttributes, described below.
- khtml/khtml_part.h: Ditto.
- khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): m_caretVisible now defaults to false. This prevents the caret from blinking when an app is started from the command line and remains in the background.
- khtml/khtmlview.cpp: (KHTMLView::focusInEvent): Remove caret code from here. Not needed. (KHTMLView::focusOutEvent): Ditto.
- kwq/KWQKHTMLPart.h: (KWQKHTMLPart::displaysWithFocusAttributes): New accessor to return cached value to other code in WebCore.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::setDisplaysWithFocusAttributes): Renamed from setShowsFirstResponder and modified to do the display updating in a clearer way....and now has comments!
- kwq/WebCoreBridge.h: Remove several obsolete functions that use to try to do the work of the new setDisplaysWithFocusAttributes function (and did so less well).
- kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:]): Now calls displaysWithFocusAttributes to figure out how to draw the text selection background. (-[WebCoreBridge setDisplaysWithFocusAttributes:]): Calls through to setDisplaysWithFocusAttributes in KWQKHTMLPart. (-[WebCoreBridge selectionColor]): Flipped the value of this ternary expression to accommodate the change from usesInactiveTextBackgroundColor to setDisplaysWithFocusAttributes. (-[WebCoreBridge setCaretVisible:]): Removed.
WebKit:
Reviewed by Trey
Fix for this bug:
<rdar://problem/3738920> Caret blinks in inactive window
As part of the fix, I cleaned up the way we handle special drawing that needs
to be done in the HTML view that is first responder in the key window (e.g the
drawing of text selection highlight and caret blinking).
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateFocusDisplay]): New method that centralizes the changes we need to make when the first responder-ness of the view or key-ness of the window changes. (-[WebHTMLView viewDidMoveToWindow]): Call new updateFocusDisplay helper. (-[WebHTMLView windowDidBecomeKey:]): Ditto. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView becomeFirstResponder]): Ditto. (-[WebHTMLView resignFirstResponder]): Ditto.
- 2:42 PM Changeset in webkit [7115] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed <rdar://problem/3691569> REGRESSION (142): cmd-shift-clicking on a link now also extends selection (even if there wasn't one before)
- khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventSingleClick): Uh, duh. Got a ! wrong last time somehow, so it did even more the wrong thing than ever. I did test this before, so my best guess is an accidental undo or something before committing.
- 10:58 AM Changeset in webkit [7114] by
-
- 2 edits in trunk/WebCore
Fix for 3735084 and 3737209, when you can find no line boxes in your previous sibling, the line box to dirty
should be the *first* line box and not the last.
Reviewed by kocienda
- khtml/rendering/render_flow.cpp: (RenderFlow::dirtyLinesFromChangedChild):
- 10:08 AM Changeset in webkit [7113]
-
- 63 copies2 deletes in tags/WebCore-125~8~1
This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~1'.
- 10:08 AM Changeset in webkit [7112] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
WebCore-125.8.1 stamp
- 9:59 AM Changeset in webkit [7111] by
-
- 3 edits in branches/Safari-1-2-branch/WebCore
- roll this change back to the branch for the Security Update
2004-07-09 Chris Blumenberg <cblu@apple.com>
Allowed my change for 3715785 to compile on Jaguar.
Reviewed by kocienda.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar
- 9:16 AM Changeset in webkit [7110] by
-
- 4 edits in trunk/WebCore
Reviewed by John
- khtml/xml/dom_selection.cpp: (DOM::Selection::validate): Not exactly a fix of anything per se, but more of a refinement of how selection validation works. The idea is to let the selection validation process end up with an empty selection given real DOM position inputs if the validation code cannot find a rendered position. Since selection is all about display, this makes sense. Currently, the code will allow the selection to be placed in a location that is not rendered, and this does nobody any good, as it can lead to bugs like accepting key input in a div that is set to display:none.
- 7:39 AM Changeset in webkit [7109] by
-
- 5 edits in trunk
Reviewed by me
Updated layout tests with new expected results.
- layout-tests/editing/execCommand/boldSelection-expected.txt
- layout-tests/editing/selection/extend-by-character-001-expected.txt
- layout-tests/editing/selection/extend-by-character-003-expected.txt
- layout-tests/editing/selection/unrendered-005-expected.txt
- 12:25 AM Changeset in webkit [7108] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin.
<rdar://problem/3725467> REGRESSION(140-142) nothing displayed at http://Ye-Olde-Movies.tripod.com
<rdar://problem/3599494> REGRESSION (100-125): Frame does not refresh until user clicks on browser.
- khtml/rendering/render_frames.cpp: (RenderFrameSet::layout): When returning early because there are no children, make sure to mark self as no longer needing layout. Otherwise, when children are added, we'll fail to propagate childrenNeedLayout to our own parent! This is almost certainly a long-standing bug that was just masked by our old layout tomfoolery.
Jul 22, 2004:
- 6:21 PM Changeset in webkit [7107] by
-
- 23 edits in branches/Safari-1-0-branch
WebKit:
Fixes for:
<rdar://problem/3668209>: after typing double-byte text, delete return and arrow keys don't work in form field (Jaguar only)
<rdar://problem/3668252>: can't type using Roman alphabet within Japanese input method in form fields on Jaguar
<rdar://problem/3668300>: Jaguar: Contribute hangs when you print from Safari
<rdar://problem/3706572>: Jag: Context menu in Contrib. not appearing according to where mouse is clicked
<rdar://problem/3730044>: Contribute: Setting focus to browser view has problems (clone for Safari 1.0.3)
<rdar://problem/3730127>: Macromedia Flash 6 cannot take Asian text entry in Safari (clone for Safari 1.0.3)
This patch back ports several fixes from Panther to Jaguar, specifically to address the needs
Macromedia's Contribute application.
Reviewed by Darin.
- Carbon.subproj/CarbonUtils.m: (getNumPools): (WebInitForCarbon): (PoolCleaner):
- Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): (-[CarbonWindowAdapter sendSuperEvent:]): (-[CarbonWindowAdapter makeKeyWindow]): (-[CarbonWindowAdapter _growBoxRect]):
- Carbon.subproj/CarbonWindowFrame.m: (-[CarbonWindowFrame titlebarRect]):
- Carbon.subproj/HIWebView.m: (MouseMoved): (MouseDragged): (ContextMenuClick): (OwningWindowChanged): (WindowHandler): (HIWebViewEventHandler):
- Misc.subproj/WebNSPrintOperationExtras.h: Added.
- Misc.subproj/WebNSPrintOperationExtras.m: Added. (-[NSPrintOperation _web_pageSetupScaleFactor]):
- Plugins.subproj/WebBaseNetscapePluginView.h:
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView restartNullEvents]): (-[WebBaseNetscapePluginView installKeyEventHandler]): (-[WebBaseNetscapePluginView removeKeyEventHandler]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView keyMessageForEvent:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (TSMEventHandler): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView windowBecameKey:]):
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView layout]): (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): (-[WebHTMLView _availablePaperWidthForPrintOperation:]): (-[WebHTMLView _scaleFactorForPrintOperation:]): (-[WebHTMLView _provideTotalScaleFactorForPrintOperation:]): (-[WebHTMLView setPageWidthForPrinting:]): (-[WebHTMLView knowsPageRange:]): (-[WebHTMLView rectForPage:]): (-[WebHTMLView _calculatePrintHeight]): (-[WebHTMLView drawPageBorderWithSize:]): (-[WebHTMLView endDocument]):
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebView.m: (-[WebView _headerHeight]): (-[WebView _footerHeight]): (-[WebView _drawHeaderInRect:]): (-[WebView _drawFooterInRect:]): (-[WebView _adjustPrintingMarginsForHeaderAndFooter]): (-[WebView _drawHeaderAndFooter]):
- WebView.subproj/WebViewPrivate.h:
WebCore:
Fixes for:
<rdar://problem/3668209>: after typing double-byte text, delete return and arrow keys don't work in form field (Jaguar only)
<rdar://problem/3668252>: can't type using Roman alphabet within Japanese input method in form fields on Jaguar
<rdar://problem/3668300>: Jaguar: Contribute hangs when you print from Safari
<rdar://problem/3706572>: Jag: Context menu in Contrib. not appearing according to where mouse is clicked
<rdar://problem/3730044>: Contribute: Setting focus to browser view has problems (clone for Safari 1.0.3)
<rdar://problem/3730127>: Macromedia Flash 6 cannot take Asian text entry in Safari (clone for Safari 1.0.3)
This patch back ports several fixes from Panther to Jaguar, specifically to address the needs
Macromedia's Contribute application.
Reviewed by Darin.
- WebCore.pbproj/project.pbxproj:
- khtml/khtmlview.cpp: (KHTMLView::adjustViewSize):
- khtml/khtmlview.h:
- khtml/rendering/render_text.cpp: (RenderText::paintObject):
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutWithPageWidthRange):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayoutAdjustingViewSize:]): (-[WebCoreBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreBridge adjustViewSize]):
- 4:43 PM Changeset in webkit [7106] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin
Fixed <rdar://problem/3682340> (error console does not include source urls or line numbers of event exceptions).
- khtml/ecma/kjs_events.cpp: (JSLazyEventListener::JSLazyEventListener): (JSLazyEventListener::parseCode):
- khtml/ecma/kjs_events.h:
- khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::createHTMLEventHandler):
- khtml/ecma/kjs_window.cpp: (Window::getJSLazyEventListener):
- khtml/ecma/kjs_window.h:
- 4:30 PM Changeset in webkit [7105] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Darin
Fixed <rdar://problem/3682340> (error console does not include source urls or line numbers of event exceptions).
- kjs/function_object.cpp: (FunctionObjectImp::construct):
- kjs/function_object.h:
- kjs/object.cpp: (KJS::ObjectImp::construct):
- kjs/object.h: (KJS::Object::construct):
- 4:04 PM Changeset in webkit [7104] by
-
- 5 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3724344> Bolding and unbolding creates extraneous tags
- khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): Move the start of the selection upstream before calling removeStyle. This makes sure we remove all styles that could apply to the selection, and not just ones in from the start position of the selection passed to us. This fixes the bug.
- khtml/xml/dom_selection.cpp: (DOM::Selection::validate): Related fix to "constrain" the selection to be the smallest equivalent range of nodes, in effect making a "canonical" version of the selection. While this is not strictly necessary to fix the bug, it is a step I have been wanting to take this step for a long time, and some recent improvements made it possible for me to do now in just two lines of code.
- 3:44 PM Changeset in webkit [7103]
-
- 9 copies2 deletes in tags/WebKit-85~7~2
This commit was manufactured by cvs2svn to create tag
'WebKit-85~7~2'.
- 3:44 PM Changeset in webkit [7102] by
-
- 2 edits in branches/WebKit-85~7-branch/WebKit
Reviewed by Richard.
- fix frame check to compile in Jaguar version
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]):
- 3:41 PM Changeset in webkit [7101] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3711264> difficult (impossible?) to get cursor in an editable webview containing only tags
- khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates): Don't assume you can pass off the check to a first child if there is one, since the child can be an element we do not want to place the caret in, like a table row with no cells (the case in the bug above). So now, we iterate of the renderer's children looking for the closest one, but only consider those renderers which either have children themselves, or are render block flows or are render inlines.
- 3:35 PM Changeset in webkit [7100] by
-
- 2 edits in branches/Safari-1-0-branch/WebKit
Reviewed by Richard.
- fix frame check to compile in Jaguar version
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]):
- 3:26 PM Changeset in webkit [7099] by
-
- 1 edit7 deletes in trunk/WebCore
- remove a bunch of now-unused code
- ForwardingHeaders/qxml.h: Removed.
- kwq/KWQXmlAttributes.h: Removed.
- kwq/KWQXmlAttributes.mm: Removed.
- kwq/KWQXmlDefaultHandler.h: Removed.
- kwq/KWQXmlDefaultHandler.mm: Removed.
- kwq/KWQXmlSimpleReader.h: Removed.
- kwq/KWQXmlSimpleReader.mm: Removed.
- 3:14 PM Changeset in webkit [7098] by
-
- 2 edits in trunk/WebKit
- Plugins.subproj/npruntime.h: Update with new version from newer JavaScriptCore.
- 2:04 PM Changeset in webkit [7097]
-
- 12 copies2 deletes in tags/WebCore-85~6~2
This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~2'.
- 2:04 PM Changeset in webkit [7096] by
-
- 2 edits in branches/Safari-1-0-branch/WebCore
Reviewed by Chris.
- change to get things compiling
- kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): Add cast to HTMLDocumentImpl so call to domain() function compiles.
- 2:04 PM Changeset in webkit [7095] by
-
- 2 edits in branches/Safari-1-0-branch/WebCore
Reviewed by Chris.
- change to get things compiling
- kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): Add cast to HTMLDocumentImpl so call to domain() function compiles.
- 1:50 PM Changeset in webkit [7094] by
-
- 11 edits in trunk/WebCore
Reviewed by Dave.
- got rid of QXml classes and changed XML parsing to use libxml directly
This is the first step toward more direct use of libxml and libxslt.
Dave is planning to build on this to implement XSLT and to improve our handling
of XML documents (faster and more feature complete, including DTDs).
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment):
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer):
- khtml/html/htmltokenizer.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::createTokenizer): (DocumentImpl::open):
- khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::tokenizer):
- khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet):
- khtml/xml/dom_xmlimpl.h:
- khtml/xml/xml_tokenizer.h:
- khtml/xml/xml_tokenizer.cpp: Redid this all to use libxml directly.
- WebCore.pbproj/project.pbxproj: Removed a bunch of files.
- 1:38 PM Changeset in webkit [7093] by
-
- 1 edit in branches/Safari-1-0-branch/WebKit/WebKit.pbproj/project.pbxproj
Bump version to 1.0.3 and 85.8.
- 1:37 PM Changeset in webkit [7092] by
-
- 2 edits in branches/Safari-1-0-branch/WebKit
- merge this fix from HEAD for Safari 1.0.3 (to match July 2004 Security Update)
2004-07-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Chris.
<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame
- Plugins.subproj/npruntime.h:
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames that are in the same window (Mozilla does this too).
- 1:33 PM Changeset in webkit [7091] by
-
- 1 edit in branches/WebKit-85~7-branch/WebKit/WebKit.pbproj/project.pbxproj
Bump copyright year.
- 1:31 PM Changeset in webkit [7090] by
-
- 2 edits in branches/WebKit-85~7-branch/WebKit
Bump version for WebKit 85.7.2
- 1:29 PM Changeset in webkit [7089] by
-
- 2 edits in branches/WebKit-85~7-branch/WebKit
- merge this fix from HEAD for July 2004 Security Update
2004-07-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Chris.
<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame
- Plugins.subproj/npruntime.h:
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames that are in the same window (Mozilla does this too).
- 9:37 AM Changeset in webkit [7088] by
-
- 2 edits in trunk/WebCore
DHTML dragging should use UTI for MIME-pboard type conversion
Reviewed by NOBODY (OOPS!).
- kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType): Use UTI, except for cases we need to hardwire. Only cut off MIME args following a semi-colon for text/plain. (MIMETypeFromCocoaType): Use UTI, except for cases we need to hardwire. (KWQClipboard::types): Filter out ancient NSAsciiPboardType so DHTML never sees this cruft.
- 7:56 AM Changeset in webkit [7087] by
-
- 10 edits in trunk
WebCore:
Reviewed by Trey
Remove handling of HTML editing key events from WebCore.
This now happens in WebKit if an event passes all the
way through WebCore without being handled by the DOM.
In each case below, function were removed, as their
only purpose was to handle editing key events.
- khtml/xml/dom_elementimpl.cpp
- khtml/xml/dom_elementimpl.h
- kwq/KWQKHTMLPart.h
- kwq/KWQKHTMLPart.mm
- kwq/WebCoreBridge.h
WebKit:
Reviewed by Trey
- WebCoreSupport.subproj/WebBridge.m: Remove interceptEditingKeyEvent bridge call over. This method of handling editing key events is now obsolete.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]): Send key event over to the DOM if this view is or contains the first responder. This now happens unconditionally. (-[WebHTMLView keyDown:]): Send key event to the DOM, then see if the web view wants to interpret it an an editing key event. This is the new place to intercept key events for editing.