Timeline



Jul 31, 2004:

10:32 AM Changeset in webkit [7168] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

<rdar://problem/3745498> HTMLCompose: Can't edit new empty message (and typing eventually crashes)
<rdar://problem/3746408> HTMLCompose: cannot type in message body of new messages (and tabbing causes a crash.)

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes): Add in some smarts to look around for a good place to put the caret if focus is turning "on", the part is contentEditable, and it does not currently have a selection. This has the effect of flashing the caret in a contentEditable view automatically without requiring the programmer to set a selection explicitly. This also fixes the bug listed above. Both are cases where the bad behavior happened since the editing code tried to process input without an active selection. I always took the extra step of setting the selection explicitly when opening new windows in programs like Blot, but it seems silly to require developers to do this in general. With this patch, they no longer need to.
10:30 AM Changeset in webkit [7167] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3745498> HTMLCompose: Can't edit new empty message (and typing eventually crashes)

  • khtml/xml/dom_selection.cpp: (DOM::Selection::layoutCaret): Don't bail when the start position of the selection is not in rendered content. The validate() bottleneck function will do all it can to make sure that the start is moved to rendered content if at all possible before this function runs. If no rendered position can be found, like in the case of an empty body element, we still want to flash the caret there. (DOM::Selection::validate): Look for rendered positions for the base and extent, but save off the base before making this move, and set the selection to the enclosing block flow element of this original base if no rendered positions can be found. This has the effect of flashing the caret someplace in an editable block, even if it does not contain any rendered content.

Jul 30, 2004:

11:17 AM Changeset in webkit [7166]
  • 64 copies
    2 deletes in tags/WebCore-125~8~2

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~2'.

11:17 AM Changeset in webkit [7165] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • versioning for SUPanMoccasin, WebCore-125.8.2
11:09 AM Changeset in webkit [7164] by kocienda
  • 5 edits in trunk/WebCore

Reviewed by John

Fix a large number of editing layout test regressions.

  • khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::TextIterator): Use a new way to compute the end offset of a node for purposes of text iteration. The end offset is either child count of a node with children, or the maxOffset() of a node that does not.
  • khtml/xml/dom_nodeimpl.cpp: Remove maxOffset() implementation from NodeBaseImpl. This conflicted with the usage of this function that is needed for editing.
  • khtml/xml/dom_nodeimpl.h: Ditto.
10:32 AM Changeset in webkit [7163] by trey
  • 6 edits in trunk/WebCore

Next steps for spell checking: We have data structures for the marked pieces of
text and the smarts to draw them (although at this point, they just get a green
underline instead of using the real AppKit pattern.)

Note we don't call this code outside of development, since at this point I suspect
it could be made to crash by mixing spelling and editing.

Reviewed by Ken.

  • khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): Paint one marker's intersection with a text run (RenderText::paint): Find intersections of all markers and runs, call paintMarker
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::addMarker): Adds a marker to a DOM Range. (DocumentImpl::removeMarker): Removes a marker from a DOM Range. (DocumentImpl::addMarker): Adds a marker to a single DOM Node, merging previous markers as needed. (DocumentImpl::removeMarker): Removes a marker from a single DOM Node, breaking up previous markers as needed. (DocumentImpl::markersForNode): Return markers for a Node.
  • khtml/xml/dom_docimpl.h: (DOM::DocumentMarker::): New marker struct (DOM::DocumentMarker::operator == ): (DOM::DocumentMarker::operator != ):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): Mark misspelled ranges when we find them. Debug only for now.
10:23 AM Changeset in webkit [7162]
  • 64 copies
    2 deletes in tags/WebCore-125~8~3

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~3'.

10:23 AM Changeset in webkit [7161] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • versioning for resubmission to SUPanXpress. The Security Update has to include all Moccasin changes, since it ships after Moccasin. We have to resubmit to both build trains because of <rdar://problem/3745334> *SUPanMoccasin* Seed: WebKit: Table's caption broken.

Jul 29, 2004:

9:18 PM Changeset in webkit [7160] by mjs
  • 5 edits in trunk/WebKit

Reviewed by John.

Added stubbed-out versions of all the NSTextInput protocol
methods, and put comments in places where we will need to call the
input manager to make input methods work 100%.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge respondToChangedSelection]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): (-[WebHTMLView mouseDragged:]): (-[WebHTMLView mouseUp:]): (-[WebHTMLView _interceptEditingKeyEvent:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView _selectionChanged]): (-[WebHTMLView _delegateDragSourceActionMask]): (-[WebHTMLView validAttributesForMarkedText]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView markedRange]): (-[WebHTMLView attributedSubstringFromRange:]): (-[WebHTMLView conversationIdentifier]): (-[WebHTMLView hasMarkedText]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
  • WebView.subproj/WebHTMLViewInternal.h:
  • WebView.subproj/WebView.m:
6:27 PM Changeset in webkit [7159] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

Rolled in the change below from HEAD to fix this SU bug:

<rdar://problem/3745334> *SUPanMoccasin* Seed: WebKit: Table's caption broken

2004-07-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3745808> Seed: WebKit: Table's caption broken

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): When a caption appears in an illegal place in a table, pop blocks until we hit a place where it's allowed.
6:22 PM Changeset in webkit [7158] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3745808> Seed: WebKit: Table's caption broken

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): When a caption appears in an illegal place in a table, pop blocks until we hit a place where it's allowed.
2:51 PM Changeset in webkit [7157] by vicki
  • 3 edits in trunk

155u, 2.0 for TOT. The tree is open!

2:45 PM Changeset in webkit [7156]
  • 3 copies in tags/Safari-154

This commit was manufactured by cvs2svn to create tag 'Safari-154'.

2:45 PM Changeset in webkit [7155] by vicki
  • 6 edits in trunk

Safari-154 stamp

1:18 PM Changeset in webkit [7154] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fill in some unimplemented methods
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView moveToBeginningOfDocument:]): Implement, using new document granularity. (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveToBeginningOfParagraph:]): Implement, even though the underlying WebCore code is not yet implemented. (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfDocument:]): More of the same. (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfParagraph:]): More of the same. (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): Ditto. (-[WebHTMLView pageDown:]): Added comment describing desired behavior. (-[WebHTMLView pageUp:]): Ditto. (-[WebHTMLView copyFont:]): Ditto. (-[WebHTMLView pasteFont:]): Ditto. (-[WebHTMLView changeAttributes:]): Ditto. (-[WebHTMLView indent:]): Ditto.
1:04 PM Changeset in webkit [7153] by darin
  • 8 edits in trunk/WebCore

Reviewed by Ken.

  • added constants for motion across entire document for use in operations like move to beginning of document
  • khtml/xml/dom_selection.h: Added DOCUMENT to ETextGranularity.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Added case for DOCUMENT. (DOM::Selection::modifyMovingRightForward): Added case for DOCUMENT. (DOM::Selection::modifyExtendingLeftBackward): Added case for DOCUMENT. (DOM::Selection::modifyMovingLeftBackward): Added case for DOCUMENT. (DOM::Selection::validate): Changed if statements into switch statement, added case for DOCUMENT.
  • kwq/WebCoreBridge.h: Added WebCoreBridge to WebSelectionGranularity.
11:06 AM Changeset in webkit [7152] by trey
  • 6 edits in trunk/WebCore

Small refinement of last checkin. The text iterators now return reasonable values
for range() when atEnd, which gets rid of special cases and pitfalls in the client.

Reviewed by Ken.

  • khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::TextIterator): Set endOffset to a valid value instead of using LONG_MAX. (khtml::TextIterator::range): Implement when atEnd. (khtml::CharacterIterator::range): Don't massage result when atEnd. (khtml::WordAwareIterator::WordAwareIterator): Now that this is fixed, we no longer need this special case. (khtml::WordAwareIterator::advance): Always set range, even when atEnd, now that TextIterator::range() always works.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::childNodeCount): Made const (NodeBaseImpl::maxOffset): Add missing implementation
  • khtml/xml/dom_nodeimpl.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): Get rid of special cases, always call range on our iterator even when it is atEnd.

Jul 28, 2004:

5:09 PM Changeset in webkit [7151] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3737864> Can not download image from web by using drag and drop

Reviewed by john.

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]): On Tiger, to use NSFilesPromisePboardType with other pasteboard types, set the file types of the promise on the pasteboard as a property list instead of mucking with the NSFilePromiseDragSource class
4:15 PM Changeset in webkit [7150] by mjs
  • 2 edits in trunk/WebKit

Reviewed by John.

  • avoid triggering an assertion when using dead keys (like option-e)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView insertText:]): Don't pass zero-length strings to WebCore. Dead-key input seems to insert empty strings as a side effect.
3:46 PM Changeset in webkit [7149] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Trey.

<rdar://problem/3678534> controls on page at ​http://help.sap.com don't work properly

To fix this I implemented the various JavaScript BarInfo properties in JavaScript.

  • khtml/ecma/kjs_window.cpp: (Window::Window): (Window::locationbar): (Window::menubar): (Window::personalbar): (Window::statusbar): (Window::toolbar): (Window::scrollbars): (Window::mark): (Window::get): (SelectionFunc::tryCall): (BarInfo::BarInfo): (BarInfo::~BarInfo): (BarInfo::get): (BarInfo::put):
  • khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::BarInfo::): (KJS::BarInfo::part): (KJS::BarInfo::classInfo):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::locationbarVisible): (KWQKHTMLPart::menubarVisible): (KWQKHTMLPart::personalbarVisible): (KWQKHTMLPart::scrollbarsVisible): (KWQKHTMLPart::statusbarVisible): (KWQKHTMLPart::toolbarVisible):
3:38 PM Changeset in webkit [7148] by kocienda
  • 1 edit
    11 adds in trunk

Reviewed by me

Added more layout tests.

  • layout-tests/editing/style/style-3681552-fix-001-expected.txt: Added.
  • layout-tests/editing/style/style-3681552-fix-001.html: Added.
  • layout-tests/editing/style/style-3681552-fix-002-expected.txt: Added.
  • layout-tests/editing/style/style-3681552-fix-002.html: Added.
  • layout-tests/editing/style/style-3690704-fix-expected.txt: Added.
  • layout-tests/editing/style/style-3690704-fix.html: Added.
  • layout-tests/editing/style/typing-style-001-expected.txt: Added.
  • layout-tests/editing/style/typing-style-001.html: Added.
  • layout-tests/editing/style/typing-style-002-expected.txt: Added.
  • layout-tests/editing/style/typing-style-002.html: Added.
2:52 PM Changeset in webkit [7147] by kocienda
  • 1 edit
    6 adds in trunk

Reviewed by me

Added some layout tests.

  • layout-tests/editing/selection/select-all-001-expected.txt: Added.
  • layout-tests/editing/selection/select-all-001.html: Added.
  • layout-tests/editing/selection/select-all-002-expected.txt: Added.
  • layout-tests/editing/selection/select-all-002.html: Added.
  • layout-tests/editing/selection/select-all-003-expected.txt: Added.
  • layout-tests/editing/selection/select-all-003.html: Added.
2:24 PM Changeset in webkit [7146] by trey
  • 18 edits in trunk

Tests:

Cut out unimplemented spelling methods. WebKit implements them.

Reviewed by Ken

  • Blot/BlotDocument.h:
  • Blot/BlotDocument.m:

WebCore:

Spellchecking, Part I. Basic spellcheck is working. Spelling panel is hooked up.

At this point, no special marking of misspellings, no grammar check, no context
menu integration, no "check continually" mode.

Much of the TextIterator and CharacterIterator interface got published outside
of khtml_text_operations.cpp, with a little API rationalizing.

Reviewed by Ken.

  • khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::range): Name changes. (khtml::CharacterIterator::CharacterIterator): Ditto. (khtml::CharacterIterator::range): Ditto. (khtml::CharacterIterator::advance): Ditto. (khtml::CharacterIterator::string): New method to consume chars into a string. (khtml::WordAwareIterator::WordAwareIterator): New class that iterates over the text respecting word boundaries. (khtml::WordAwareIterator::advance): (khtml::WordAwareIterator::length): (khtml::WordAwareIterator::characters): (khtml::plainText): Name changes. (khtml::findPlainText): Ditto.

API moved from cpp to header file.

  • khtml/misc/khtml_text_operations.h: (khtml::TextIterator::atEnd): (khtml::TextIterator::length): (khtml::TextIterator::characters): (khtml::CharacterIterator::atBreak): (khtml::CharacterIterator::atEnd): (khtml::CharacterIterator::length): (khtml::CharacterIterator::characters): (khtml::CharacterIterator::characterOffset): (khtml::WordAwareIterator::atEnd): (khtml::WordAwareIterator::range):
  • khtml/xml/dom_position.cpp: (DOM::Position::previousWordBoundary): New name for the old routine. This routines semantics match the current behavior of this code. (DOM::Position::nextWordBoundary): Ditto. (DOM::Position::previousWordPosition): Call old code with the new name. When we fix word advancement, this routine will have its own impl. (DOM::Position::nextWordPosition): Ditto.
  • khtml/xml/dom_position.h:
  • khtml/xml/dom_selection.h: (DOM::Selection::rangeStart): New convenience methods (DOM::Selection::rangeEnd):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): Ensure we use range-compatible positions. (KWQKHTMLPart::advanceToNextMisspelling): Brand new.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge advanceToNextMisspelling]): Typical bridge glue.

WebKit:

Spellchecking, Part I. Basic spellcheck is working. Spelling panel is hooked up.

At this point, no special marking of misspellings, no grammar check, no context
menu integration, no "check continually" mode.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge spellCheckerDocumentTag]): Typical bridge glue.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView validateUserInterfaceItem:]): Validate various spelling actions. (-[WebHTMLView checkSpelling:]): Call WC for real work, update panel. (-[WebHTMLView showGuessPanel:]): Show panel, call WC for real work. (-[WebHTMLView _changeSpellingToWord:]): Apply correction to our doc. (-[WebHTMLView changeSpelling:]): Simple pass through to above method. (-[WebHTMLView ignoreSpelling:]): Tell checker to ignore the word.
  • WebView.subproj/WebView.m: (-[WebView _close]): Call AK's closeSpellDocumentWithTag: for proper cleanup.
2:14 PM Changeset in webkit [7145] by kocienda
  • 3 edits in trunk/WebCore

Tools:

Reviewed by John

Added debugging summary output for CSSStyleDeclarationImpl

  • LabyrinthDataFormatters/CustomDataViews.plist:
  • LabyrinthDataFormatters/LabyrinthDataFormatters.cpp: (LabyrinthDataFormatCSSStyleDeclarationImpl):
  • LabyrinthDataFormatters/LabyrinthDataFormatters.h:
  • LabyrinthDataFormatters/LabyrinthDataFormatters.xcode/project.pbxproj:

WebCore:

Reviewed by John

Export a couple more symbols for test programs.

  • WebCore-combined.exp:
  • WebCore-tests.exp:
1:43 PM Changeset in webkit [7144] by rjw
  • 6 edits in trunk/WebCore

We're changing the way color is specified as a parameter in the
<canvas> API. Colors are now specified using the CSS color
functions (or old style names or "#"). For example
'context.setStrokeColor ("rgba(128,128,128,0.5)")'. Most of the
patch is cleanup of duplicated code in cssparser.cpp and a new
static function that'll crank up the CSS parser to parse the
color. This patch leaves the old mechanisms in place for now, so
we don't break any existing gadgets.

Reviewed by John.

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/cssparser.cpp: (CSSParser::CSSParser): (CSSParser::setupParser): (CSSParser::parseSheet): (CSSParser::parseRule): (CSSParser::parseValue): (CSSParser::parseColor): (CSSParser::parseDeclaration):
  • khtml/css/cssparser.h:
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
  • kwq/KWQColor.h: (QColor::alpha): Added alpha() function to QColor, use instead of quirky qAlpha() global function.
1:28 PM Changeset in webkit [7143] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Trey

Only apply the typing style if it is non-null and has a length.
This fixes a problem Trey noticed with my last checkin, where
typed characters were placed in empty "typing style" spans.

  • khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply) (khtml::InputTextCommandImpl::prepareForTextInsertion)
12:31 PM Changeset in webkit [7142]
  • 22 copies
    2 deletes in tags/WebKit-85~8~2

This commit was manufactured by cvs2svn to create tag
'WebKit-85~8~2'.

12:31 PM Changeset in webkit [7141] by vicki
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • bump version number to WebKit-85.8.2 to avoid confusion. 85.8.1 was already submitted to another build train
11:52 AM Changeset in webkit [7140] by vicki
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • versioning for Safari 1.0.3 update on Jaguar, WebKit-85.8.1
11:44 AM Changeset in webkit [7139]
  • 17 copies
    2 deletes in tags/WebCore-85~6~3

This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~3'.

11:44 AM Changeset in webkit [7138] by vicki
  • 2 edits in branches/Safari-1-0-branch/WebCore
  • versioning for Safari 1.0.3 on Jaguar, WebCore-85.6.3
11:33 AM Changeset in webkit [7137] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed this bug:

<rdar://problem/3690704> marking partly bold text italic across blocks wrongly extends the bold section

  • khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): Fixed loop that gathers up groups of nodes to pass off to the function that applies styles. While this is meant to be conservative in order to leave the DOM well-formed in all cases, it contained an error where the set of nodes to be styled together erroneously could include a node that was meant for the next set. Fixed. (khtml::ApplyStyleCommandImpl::applyStyleIfNeeded): Unrelated change to remove DOM:: scope resolution qualifier. Unneeded here.
9:36 AM Changeset in webkit [7136] by darin
  • 5 edits in trunk/WebCore

Reviewed by Trey.

  • fixed <rdar://problem/3658471> REGRESSION: Node.appendChild( ) fails when parent already contains that child
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isAncestor): Restore the original meaning of this function. It returns true if the parameter is an ancestor of this, but had been changed to return true if this is an ancestor of the parameter. However, we do retain one change we made at the same time, which is that it does not consider a node an ancestor of itself.
  • khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::nodeFullySelected):
  • khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::notifyBeforeNodeRemoval): Reverse parameters for callers who wanted the new meaning of isAncestor, with care to not use it in any cases where the pointer might be 0.
  • khtml/xml/dom_nodeimpl.h: Added const to the parameter to make things more symmetric and allow the new uses to all compile.
9:22 AM Changeset in webkit [7135] by kocienda
  • 6 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3681552> html editing needs to preserve typing font when replacing selection

  • khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::merge): New helper that merges styles together. Helpful for dealing with typing styles.
  • khtml/css/css_valueimpl.h:
  • khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::computeTypingStyle): New helper that updates the typing style based on the current selection. This is a convenient bottleneck for all the code that needs to worry about typing style. (khtml::DeleteSelectionCommandImpl::doApply): Update typing style before doing the delete. (khtml::InputNewlineCommandImpl::doApply): No need to redeclare exceptionCode local. Improve comments. (khtml::InputTextCommandImpl::prepareForTextInsertion): Remove unneeded complication when figuring out where to insert style node. Not even sure what I was trying to do here, but it does not seem to be needed any more. (khtml::InputTextCommandImpl::execute): Remove unneeded comment.
  • khtml/editing/htmlediting_impl.h: Declare new computeTypingStyle helper.
  • khtml/khtml_part.cpp: (KHTMLPart::setCaretVisible): Call selectionLayoutChanged instead of notifySelectionChanged in this function. The selection did not change simply by calling this function, but it does need a layout. (KHTMLPart::notifySelectionChanged): Treat clearing the typing style much like closing typing, instead of clearing it unconditionally. (KHTMLPart::applyStyle): In the case where the current selection is a caret, merge the style being applied with any current typing style that already exists.
8:45 AM Changeset in webkit [7134] by darin
  • 8 edits in trunk

Reviewed by Ken.

  • fixed <rdar://problem/3711080> REGRESSION (125-146): form fields have shrunk by 1 pixel, and now clip descenders
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Compute the size without ever calling cellSize. After talking with Andrew Platzer, we decided that hard-coding the size of the borders of a text field was the best way for WebCore to handle this.
7:45 AM Changeset in webkit [7133] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3743204> REGRESSION: crash at startribune.com in InlineBox::root()
  • khtml/rendering/render_flow.cpp: (RenderFlow::dirtyLinesFromChangedChild): Added a check for nil.
7:31 AM Changeset in webkit [7132] by darin
  • 2 edits in trunk/WebCore

Reviewed by Trey.

  • fixed <rdar://problem/3743138> opaque colors come out of getComputedStyle as "rgba", transparent ones as "rgb"
  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText): Use "rgb" rather than "rgba" when alpha is 0xFF, not when alpha is 0.
Note: See TracTimeline for information about the timeline view.