⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 2, 2004:

4:49 PM Changeset in webkit [7179] by darin
  • 3 edits
    1 add in trunk/JavaScriptCore
  • tests/mozilla/.cvsignore: Added.
  • tests/mozilla/expected.html: Update results.
4:47 PM Changeset in webkit [7178] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed RegExp.toString so 3 more Mozilla regexp tests pass
  • kjs/regexp_object.cpp: (RegExpProtoFuncImp::call): Append the flags here so more tests paseed.
4:43 PM Changeset in webkit [7177]
  • 4 copies
    2 deletes in tags/WebCore-154~0~1

This commit was manufactured by cvs2svn to create tag
'WebCore-154~0~1'.

4:43 PM Changeset in webkit [7176] by vicki
  • 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Fix the install path so that WebCore will build again in B&I. Looks like some changes to the project file were accidentally committed (I saw "INSTALL_PATH_MODIFIED_BY_SCRIPT_DO_NOT_COMMIT").

4:38 PM Changeset in webkit [7175] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed a couple things making 5 Mozilla regexp tests pass
  • kjs/regexp_object.cpp: (RegExpProtoFuncImp::call): Implement toString for the prototype. (RegExpObjectImp::construct): Fix bug where the string "undefined" would be used as the flags string when no parameter was passed.
  • kjs/regexp_object.h: (KJS::RegExpPrototypeImp::classInfo): Added a class info object for RegExp prototype so it can return a string instead of raising an exception when converting to a string.
  • tests/mozilla/expected.html: Update results.
3:31 PM Changeset in webkit [7174] by sullivan
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/3631868> NSToolbar adoption:
Tab key should cycle around toolbar and page content

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge nextKeyViewInsideWebFrameViews]): Made this method start looking from the current focus node. This won't affect any existing callers because there were no existing callers. (-[WebCoreBridge previousKeyViewInsideWebFrameViews]): ditto

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/3631868> NSToolbar adoption:
Tab key should cycle around toolbar and page content

  • WebView.subproj/WebHTMLView.m: removed overrides of nextKeyView and previousKeyView (-[WebHTMLView nextValidKeyView]): call super only if we can't move the focus within the frame hierarchy (-[WebHTMLView previousValidKeyView]): ditto
  • WebView.subproj/WebHTMLViewInternal.h: removed nextKeyViewAccessShouldMoveFocus ivar
3:15 PM Changeset in webkit [7173] by hyatt
  • 2 edits in trunk/WebCore

Create a #define for XSLT support that at the moment will only be enabled on Tiger.

Reviewed by kocienda

  • WebCorePrefix.h:
3:01 PM Changeset in webkit [7172] by vicki
  • 1 edit in branches/Safari-1-2-branch/WebKit/ChangeLog

Add missing WebKit-125.4 release marker to the Changelog; I diffed to be sure that the fix for 3728558 was included in WebKit-125.4

2:44 PM Changeset in webkit [7171] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by Kevin.

  • fix crashes in mozilla tests due to mishandling NaN
  • kjs/array_object.cpp: (ArrayProtoFuncImp::call): Rerranged range checks after calls to toInteger so that NaN will get turned into something that fits in an integer. These were the ones John already fixed, but his fix used isnan and the new fix is more efficient.
  • kjs/number_object.cpp: (NumberProtoFuncImp::call): Rearranged radix range checks after a call to toInteger to handle NaN properly. Also removed separate check for undefined that's not needed.
  • kjs/string_object.cpp: (StringProtoFuncImp::call): More of the same kinds of changes as in the above two files, but for a lot more functions. Also changed one place with an explicit check for undefined to instead just check isNaN.
  • tests/mozilla/run-mozilla-tests: Changed to invoke jst using $SYMROOTS for people like me who don't keep $SYMROOTS in their $PATH.
11:38 AM Changeset in webkit [7170] by kocienda
  • 5 edits in trunk/WebKit

Tests:

Reviewed by John

Remove special code that placed the caret when the document loads.
This is now handled by WebKit in a more generalized way.

  • Blot/Blot.xcode/project.pbxproj:
  • Blot/BlotDocument.m: (-[BlotDocument webView:didFinishLoadForFrame:]):

WebKit:

Reviewed by John

Update name of firstResponderIsSelfOrDescendantView, adding _web_ prefix to this SPI call.

Do some work to make caret blinking in newly-created editable WebView's that are
similar in structure to Blot more "automatic".

  • Misc.subproj/WebNSViewExtras.h: Change name of firstResponderIsSelfOrDescendantView. Add _web_ prefix.
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_firstResponderIsSelfOrDescendantView]): Name change. (-[NSView _web_firstResponderCausesFocusDisplay]): Adds an additional check for whether the view's is first responder. This helps to make the focus setting in viewDidMoveToWindow work right.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateFocusDisplay]): Use _web_firstResponderCausesFocusDisplay now instead of firstResponderIsSelfOrDescendantView. (-[WebHTMLView viewDidMoveToWindow]): Schedule call to updateFocusDisplay for the next crank of the run loop. The reason is that placing the caret in the just-installed view requires the HTML/XML document to be available on the WebCore side, but it is not at the time this code is running. However, it will be there on the next crank of the run loop. Doing this helps to make a blinking caret appear in a new, empty window "automatic". (-[WebHTMLView performKeyEquivalent:]): _web_firstResponderIsSelfOrDescendantView name change.
  • WebView.subproj/WebView.m: (-[WebView _performResponderOperation:with:]): _web_firstResponderIsSelfOrDescendantView name change.
11:04 AM Changeset in webkit [7169] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3747945> Deleting replaced element can cause crash

  • khtml/xml/dom_selection.cpp: (DOM::Selection::layoutCaret): The crux of the problem is that the caret drawing code tries to draw the caret at the image offset after it has been removed from the document. So, make sure the start node for the selection is in the document before trying to lay out the caret using that node.

Jul 31, 2004:

10:32 AM Changeset in webkit [7168] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

<rdar://problem/3745498> HTMLCompose: Can't edit new empty message (and typing eventually crashes)
<rdar://problem/3746408> HTMLCompose: cannot type in message body of new messages (and tabbing causes a crash.)

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes): Add in some smarts to look around for a good place to put the caret if focus is turning "on", the part is contentEditable, and it does not currently have a selection. This has the effect of flashing the caret in a contentEditable view automatically without requiring the programmer to set a selection explicitly. This also fixes the bug listed above. Both are cases where the bad behavior happened since the editing code tried to process input without an active selection. I always took the extra step of setting the selection explicitly when opening new windows in programs like Blot, but it seems silly to require developers to do this in general. With this patch, they no longer need to.
10:30 AM Changeset in webkit [7167] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3745498> HTMLCompose: Can't edit new empty message (and typing eventually crashes)

  • khtml/xml/dom_selection.cpp: (DOM::Selection::layoutCaret): Don't bail when the start position of the selection is not in rendered content. The validate() bottleneck function will do all it can to make sure that the start is moved to rendered content if at all possible before this function runs. If no rendered position can be found, like in the case of an empty body element, we still want to flash the caret there. (DOM::Selection::validate): Look for rendered positions for the base and extent, but save off the base before making this move, and set the selection to the enclosing block flow element of this original base if no rendered positions can be found. This has the effect of flashing the caret someplace in an editable block, even if it does not contain any rendered content.

Jul 30, 2004:

11:17 AM Changeset in webkit [7166]
  • 64 copies
    2 deletes in tags/WebCore-125~8~2

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~2'.

11:17 AM Changeset in webkit [7165] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • versioning for SUPanMoccasin, WebCore-125.8.2
11:09 AM Changeset in webkit [7164] by kocienda
  • 5 edits in trunk/WebCore

Reviewed by John

Fix a large number of editing layout test regressions.

  • khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::TextIterator): Use a new way to compute the end offset of a node for purposes of text iteration. The end offset is either child count of a node with children, or the maxOffset() of a node that does not.
  • khtml/xml/dom_nodeimpl.cpp: Remove maxOffset() implementation from NodeBaseImpl. This conflicted with the usage of this function that is needed for editing.
  • khtml/xml/dom_nodeimpl.h: Ditto.
10:32 AM Changeset in webkit [7163] by trey
  • 6 edits in trunk/WebCore

Next steps for spell checking: We have data structures for the marked pieces of
text and the smarts to draw them (although at this point, they just get a green
underline instead of using the real AppKit pattern.)

Note we don't call this code outside of development, since at this point I suspect
it could be made to crash by mixing spelling and editing.

Reviewed by Ken.

  • khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): Paint one marker's intersection with a text run (RenderText::paint): Find intersections of all markers and runs, call paintMarker
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::addMarker): Adds a marker to a DOM Range. (DocumentImpl::removeMarker): Removes a marker from a DOM Range. (DocumentImpl::addMarker): Adds a marker to a single DOM Node, merging previous markers as needed. (DocumentImpl::removeMarker): Removes a marker from a single DOM Node, breaking up previous markers as needed. (DocumentImpl::markersForNode): Return markers for a Node.
  • khtml/xml/dom_docimpl.h: (DOM::DocumentMarker::): New marker struct (DOM::DocumentMarker::operator == ): (DOM::DocumentMarker::operator != ):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): Mark misspelled ranges when we find them. Debug only for now.
10:23 AM Changeset in webkit [7162]
  • 64 copies
    2 deletes in tags/WebCore-125~8~3

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~3'.

10:23 AM Changeset in webkit [7161] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • versioning for resubmission to SUPanXpress. The Security Update has to include all Moccasin changes, since it ships after Moccasin. We have to resubmit to both build trains because of <rdar://problem/3745334> *SUPanMoccasin* Seed: WebKit: Table's caption broken.

Jul 29, 2004:

9:18 PM Changeset in webkit [7160] by mjs
  • 5 edits in trunk/WebKit

Reviewed by John.

Added stubbed-out versions of all the NSTextInput protocol
methods, and put comments in places where we will need to call the
input manager to make input methods work 100%.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge respondToChangedSelection]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): (-[WebHTMLView mouseDragged:]): (-[WebHTMLView mouseUp:]): (-[WebHTMLView _interceptEditingKeyEvent:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView _selectionChanged]): (-[WebHTMLView _delegateDragSourceActionMask]): (-[WebHTMLView validAttributesForMarkedText]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView markedRange]): (-[WebHTMLView attributedSubstringFromRange:]): (-[WebHTMLView conversationIdentifier]): (-[WebHTMLView hasMarkedText]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
  • WebView.subproj/WebHTMLViewInternal.h:
  • WebView.subproj/WebView.m:
6:27 PM Changeset in webkit [7159] by mjs
  • 2 edits in branches/Safari-1-2-branch/WebCore

Rolled in the change below from HEAD to fix this SU bug:

<rdar://problem/3745334> *SUPanMoccasin* Seed: WebKit: Table's caption broken

2004-07-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3745808> Seed: WebKit: Table's caption broken

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): When a caption appears in an illegal place in a table, pop blocks until we hit a place where it's allowed.
6:22 PM Changeset in webkit [7158] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3745808> Seed: WebKit: Table's caption broken

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): When a caption appears in an illegal place in a table, pop blocks until we hit a place where it's allowed.
2:51 PM Changeset in webkit [7157] by vicki
  • 3 edits in trunk

155u, 2.0 for TOT. The tree is open!

2:45 PM Changeset in webkit [7156]
  • 3 copies in tags/Safari-154

This commit was manufactured by cvs2svn to create tag 'Safari-154'.

2:45 PM Changeset in webkit [7155] by vicki
  • 6 edits in trunk

Safari-154 stamp

1:18 PM Changeset in webkit [7154] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fill in some unimplemented methods
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView moveToBeginningOfDocument:]): Implement, using new document granularity. (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveToBeginningOfParagraph:]): Implement, even though the underlying WebCore code is not yet implemented. (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfDocument:]): More of the same. (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfParagraph:]): More of the same. (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): Ditto. (-[WebHTMLView pageDown:]): Added comment describing desired behavior. (-[WebHTMLView pageUp:]): Ditto. (-[WebHTMLView copyFont:]): Ditto. (-[WebHTMLView pasteFont:]): Ditto. (-[WebHTMLView changeAttributes:]): Ditto. (-[WebHTMLView indent:]): Ditto.
1:04 PM Changeset in webkit [7153] by darin
  • 8 edits in trunk/WebCore

Reviewed by Ken.

  • added constants for motion across entire document for use in operations like move to beginning of document
  • khtml/xml/dom_selection.h: Added DOCUMENT to ETextGranularity.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Added case for DOCUMENT. (DOM::Selection::modifyMovingRightForward): Added case for DOCUMENT. (DOM::Selection::modifyExtendingLeftBackward): Added case for DOCUMENT. (DOM::Selection::modifyMovingLeftBackward): Added case for DOCUMENT. (DOM::Selection::validate): Changed if statements into switch statement, added case for DOCUMENT.
  • kwq/WebCoreBridge.h: Added WebCoreBridge to WebSelectionGranularity.
11:06 AM Changeset in webkit [7152] by trey
  • 6 edits in trunk/WebCore

Small refinement of last checkin. The text iterators now return reasonable values
for range() when atEnd, which gets rid of special cases and pitfalls in the client.

Reviewed by Ken.

  • khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::TextIterator): Set endOffset to a valid value instead of using LONG_MAX. (khtml::TextIterator::range): Implement when atEnd. (khtml::CharacterIterator::range): Don't massage result when atEnd. (khtml::WordAwareIterator::WordAwareIterator): Now that this is fixed, we no longer need this special case. (khtml::WordAwareIterator::advance): Always set range, even when atEnd, now that TextIterator::range() always works.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::childNodeCount): Made const (NodeBaseImpl::maxOffset): Add missing implementation
  • khtml/xml/dom_nodeimpl.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): Get rid of special cases, always call range on our iterator even when it is atEnd.
Note: See TracTimeline for information about the timeline view.