Timeline



Aug 6, 2004:

5:25 PM Changeset in webkit [7210] by kocienda
  • 19 edits in trunk

WebCore:

Reviewed by Maciej

Finish off spellchecking support to HTML editing. Includes work to
enable continuous spellchecking.

  • khtml/editing/htmlediting_impl.cpp: (khtml::EditCommandImpl::markMisspellingsInSelection): Basically, a one-liner convenience to make the call over to the KWQKHTMLPart. (khtml::ReplaceSelectionCommandImpl::doApply): Did some rearranging of code so that the inserted content can be spell-checked. The function is basically the same, except for the addition of calls to markMisspellingsInSelection. (khtml::TypingCommandImpl::markMisspellingsAfterTyping): New function. Takes a look at the selection that results after typing and determines whether it needs to spellcheck. Since the word containing the current selection is never marked, this does a check to see if typing made a new word that is not in the current selection. Basically, you get this by being at the end of a word and typing a space. (khtml::TypingCommandImpl::typingAddedToOpenCommand): Call markMisspellingsAfterTyping.
  • khtml/editing/htmlediting_impl.h: Add new function declarations.
    • khtml/khtml_part.cpp:

(KHTMLPart::setSelection): Since spell checks are updated when the selection changes,
and every selection change passes through here, this is a good place to put the call
to the spellchecker.

  • khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): Remove temporary misspelling line drawing code. Replace with call that does AppKit-style drawing. Fix up some comments.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::addMarker): Repaint the node that had the marker added. This makes it show up on setting it. (DocumentImpl::removeMarker): Ditto. (DocumentImpl::removeAllMarkers): New function. Convenience for clearing all markers. Used when not in continuous spellchecking mode. (DocumentImpl::shiftMarkers): Moves markers in response to changes in a node's contents. This shifts the marker offsets by a given amount. This keeps the markers in the right place when a user types in a node with markers already set on it.
  • khtml/xml/dom_docimpl.h: Added new functions. Removed unnecessary enum qualifier from some declarations.
  • khtml/xml/dom_position.cpp: (DOM::Position::previousWordBoundary): This function was susceptible to endless loops...and needlessly so. Basically, if the current position is at a word boundary, run the code again to find the previous word boundary. (DOM::Position::nextWordBoundary): Same as above, but for next word boundary.
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): Call shiftMarkers to update markers when this node changes. (CharacterDataImpl::insertData): Ditto. (CharacterDataImpl::deleteData): Ditto. (CharacterDataImpl::replaceData): Ditto.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellingsInSelection): (KWQKHTMLPart::updateSpellChecking): (KWQKHTMLPart::respondToChangedSelection):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawLineForMisspelling): New function. Call over to WebKit to do the drawing.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Pass markMisspellings flag to setSelection call.
  • kwq/WebCoreTextRenderer.h:

WebKit:

Reviewed by Maciej

Finish off spellchecking support to HTML editing. Includes work to
enable continuous spellchecking.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge isContinuousSpellCheckingEnabled]): Simple bridge method.
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForMisspelling:withWidth:]): New method to add AppKit-style misspelling underline.
11:50 AM Changeset in webkit [7209] by vicki
  • 3 edits in trunk

156u, Safari 2.0 for TOT. The tree is open!

11:45 AM Changeset in webkit [7208] by vicki
  • 6 edits in trunk

Safari-155 stamp

Aug 5, 2004:

8:18 PM Changeset in webkit [7207] by darin
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebHTMLView.m: Added a list of methods that NSTextView implements that we don't. All inside #if 0.
6:05 PM Changeset in webkit [7206] by rjw
  • 6 edits in trunk/JavaScriptCore

Fixed part of 3674747. The QT guys need this for feature freeze.

This patch implements support for the

  • (id)invokeUndefinedMethodFromWebScript:(NSString *)name withArguments:(NSArray *)args

method of objects bound to JavaScript.

Reviewed by John.

  • ChangeLog:
  • bindings/objc/objc_class.mm: (ObjcClass::methodsNamed): (ObjcClass::fieldNamed):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcMethod::~ObjcMethod): (KJS::Bindings::ObjcMethod::isFallbackMethod): (KJS::Bindings::ObjcMethod::javaScriptName):
  • bindings/objc/objc_runtime.mm: (ObjcMethod::ObjcMethod): (ObjcMethod::getMethodSignature): (ObjcMethod::setJavaScriptName):
  • bindings/testbindings.mm:
3:32 PM Changeset in webkit [7205]
  • 64 copies
    2 deletes in tags/WebCore-125~8~6

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~6'.

3:32 PM Changeset in webkit [7204] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore

bump the version number again for latest Moccasin fix, WebCore-125.8.6

3:27 PM Changeset in webkit [7203] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • merge this fix from HEAD for SUPanMoccasin

2004-08-05 David Hyatt <​hyatt@apple.com>

Fix for 3752542, stack overflow that crashes Safari at www.dr.dk. This bug is a regression caused by a fix that
attempted to repair <caption> behavior to make it behave like Panther. This fix was incorrect, and in addition
even our <caption> behavior on Panther was incorrect.

The patch that fixes this bug also makes <caption> handling work when <caption>s are contained inside a <td>, a <tr>,
a <th>, or various table section tags (<tbody>, <tfoot>, <thead>). The <caption> is pulled out and inserted just before
the relevant ancestor table section. This behavior matches other browsers.

Reviewed by mjs

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
2:54 PM Changeset in webkit [7202] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3752542, stack overflow that crashes Safari at www.dr.dk. This bug is a regression caused by a fix that
attempted to repair <caption> behavior to make it behave like Panther. This fix was incorrect, and in addition
even our <caption> behavior on Panther was incorrect.

The patch that fixes this bug also makes <caption> handling work when <caption>s are contained inside a <td>, a <tr>,
a <th>, or various table section tags (<tbody>, <tfoot>, <thead>). The <caption> is pulled out and inserted just before
the relevant ancestor table section. This behavior matches other browsers.

Reviewed by mjs

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
2:52 PM Changeset in webkit [7201] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Fixed unnecessary import of NSURLFileTypeMappings.

  • WebView.subproj/WebMainResourceClient.m:

WebBrowser:

Fixed unnecessary import of NSURLFileTypeMappings.

  • BrowserWebController.m:
12:27 PM Changeset in webkit [7200] by rjw
  • 2 edits in trunk/WebKit

Make builds conditionally include -framework Quartz.

Reviewed by Chris.

  • WebKit.pbproj/project.pbxproj:
11:04 AM Changeset in webkit [7199]
  • 64 copies
    2 deletes in tags/WebCore-125~8~4

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~4'.

11:04 AM Changeset in webkit [7198] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • versioning for SUPanMoccasin, WebCore-125.8.4
10:59 AM Changeset in webkit [7197]
  • 64 copies
    2 deletes in tags/WebCore-125~8~5

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~5'.

10:59 AM Changeset in webkit [7196] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • new versioning for SUPanXpress (WebCore-125.8.5), since the fix for 3534851 (Moccasin clone is 3703230) has to be backed out here as well
10:54 AM Changeset in webkit [7195] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • roll out this chang for SUPanMoccasin, since it causes 3751025

2004-06-18 John Sullivan <​sullivan@apple.com>

Reviewed by Darin

  • fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <

Aug 4, 2004:

5:18 PM Changeset in webkit [7194] by vicki
  • 2 adds in trunk/LayoutTests/fast/js

add a layout test for 3649789

4:58 PM Changeset in webkit [7193] by vicki
  • 2 edits in trunk/JavaScriptCore

Reviewed by mjs.

  • fix <rdar://problem/3649789> SAP WebGUI has problems loading first page because of parse error
  • kjs/lexer.cpp: (Lexer::lex): if the current character is a '\' and the next character is a line terminator, go to the next line and continue parsing the string (instead of failing). This matches behavior in Mac IE and Mozilla.
3:05 PM Changeset in webkit [7192] by hyatt
  • 8 edits
    2 adds in trunk/WebCore

The top-level XSL sheet is now loaded and shows up in the activity window. It is not yet parsed.

Reviewed by kocienda

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_base.h: (DOM::StyleBaseImpl::isXSLStyleSheet):
  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl):
  • khtml/css/css_stylesheetimpl.h: (DOM::StyleSheetImpl::isLoading):
  • khtml/misc/loader.cpp:
  • khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::ProcessingInstructionImpl): (DOM::ProcessingInstructionImpl::checkStyleSheet): (DOM::ProcessingInstructionImpl::sheet): (DOM::ProcessingInstructionImpl::isLoading): (DOM::ProcessingInstructionImpl::setStyleSheet):
  • khtml/xml/dom_xmlimpl.h:
1:25 PM Changeset in webkit [7191] by hyatt
  • 3 edits in trunk/WebCore

Add XSL Stylesheets to the WebCore cache.

Reviewed by kocienda

  • khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXSLStyleSheet::ref): (CachedXSLStyleSheet::deref): (CachedXSLStyleSheet::data): (CachedXSLStyleSheet::checkNotify): (CachedXSLStyleSheet::error): (DocLoader::requestXSLStyleSheet): (Cache::requestXSLStyleSheet): (Cache::getStatistics):
  • khtml/misc/loader.h: (khtml::CachedObject::): (khtml::CachedXSLStyleSheet::sheet): (khtml::CachedXSLStyleSheet::schedule):
9:50 AM Changeset in webkit [7190] by darin
  • 2 edits in trunk/WebKit
  • fixed broken Deployment build
  • Carbon.subproj/HIWebView.m: (Click): Remove code that checks err variable before setting it.

Aug 3, 2004:

5:30 PM Changeset in webkit [7189] by rjw
  • 7 edits
    4 adds in trunk/WebKit

First cut at dirt simple PDF support. This feature
depends on Quartz.framework (parent of PDFKit), which only exists
on Tiger. So, we "weak" link against Quartz.

We do very basic PDF rendering. Coming up are support for
"Find..." and linearized PDF (incremental). Linearized PDF
support will require API changes in PDFKit.

No UI is added to Safari, yet.

Reviewed by John.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
  • WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
  • WebView.subproj/WebPDFRepresentation.h: Added.
  • WebView.subproj/WebPDFRepresentation.m: Added. (-[WebPDFRepresentation finishedLoadingWithDataSource:]): (-[WebPDFRepresentation canProvideDocumentSource]): (-[WebPDFRepresentation documentSource]): (-[WebPDFRepresentation title]):
  • WebView.subproj/WebPDFView.h: Added.
  • WebView.subproj/WebPDFView.m: Added. (-[WebPDFView initWithFrame:]): (-[WebPDFView setDataSource:]): (-[WebPDFView dataSourceUpdated:]): (-[WebPDFView setNeedsLayout:]): (-[WebPDFView layout]): (-[WebPDFView viewWillMoveToHostWindow:]): (-[WebPDFView viewDidMoveToHostWindow]):

Copied fix from Jaguar carbon/cocoa work.

Reviewed by Darin (Jaguar version)

  • Carbon.subproj/CarbonWindowAdapter.h:
  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter relinquishFocus]):
  • Carbon.subproj/HIWebView.m: (Click): (OwningWindowChanged): (WindowHandler):
4:58 PM Changeset in webkit [7188] by hyatt
  • 3 edits in trunk/WebKit

Add the text/xsl MIME type as one that can be displayed.

Reviewed by john

  • WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
  • WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
4:40 PM Changeset in webkit [7187] by kocienda
  • 20 edits in trunk/WebCore

Reviewed by Hyatt

Changes to improve our handling of object tags during editing, including
fixing this bug:

<rdar://problem/3744533> Problem editing <OBJECT> elements displayed by WebPlugIns

Part of the fix for this bug involves removing the close() function from render objects.
It was decided that this code was no longer needed, as the work it did could be moved
to other, more modern, places.

Fixed this bug:

<rdar://problem/3748537> crash due to nil node passed into parentNode in computeTypingStyle deleting text

Finally, I filed and fixed this bug I discovered while fixing the one above:

<rdar://problem/3749338> Select-all + delete leaves editing view without blinking caret

  • khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::computeTypingStyle): Fix for 3748537. Put in some more null checks. Bail, returning 0 for typing style if any null checks yield a null. (khtml::DeleteSelectionCommandImpl::doApply): Fix for 3749338. A removeNodeAndPrune call may wind up deleting the node where we calculated that we wanted to put the selection after deleting. If this happens, move this ending selection to a sensible alternative. (khtml::RemoveNodeAndPruneCommandImpl::doApply): Call previousNodeConsideringAtomicNodes instead of traversePreviousNode when doing the prune.
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Part of the fix for 3744533. (HTMLObjectElementImpl::recalcStyle): Change old strcmp check for type of renderer to be a call to canRenderImageType. (HTMLObjectElementImpl::childrenChanged): New function. Helps to keep object tags up to date as their children change. This also will help to make object tags respond properly to having their params changed by DOM calls.
  • khtml/html/html_objectimpl.h: Cosmetic change.
  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Remove call to obsolete closeRenderer() function. (KHTMLParser::popOneBlock): Ditto.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::makeChildrenNonInline): Remove call to obsolete close() function.
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild): Ditto.
  • khtml/rendering/render_form.cpp: Remove obsolete close() function.
  • khtml/rendering/render_form.h: Ditto.
  • khtml/rendering/render_frames.cpp: Ditto.
  • khtml/rendering/render_frames.h: Ditto.
  • khtml/rendering/render_inline.cpp: (RenderInline::splitFlow): Remove calls to obsolete close() function.
  • khtml/rendering/render_object.h: Remove obsolete close() function.
  • khtml/rendering/render_table.cpp: (RenderTableCell::layout): Ditto.
  • khtml/rendering/render_table.h: Ditto.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::closeInternal): Remove call to obsolete close() function.
  • khtml/xml/dom_nodeimpl.cpp: Remove obsolete m_rendererNeedsClose initialization. (NodeImpl::NodeImpl): Remove obsolete closeRenderer() function. (NodeImpl::attach): Remove call to obsolete close() function. (NodeImpl::isAtomicNode): New function. Helps to fix 3744533. Determines if a node should be treated as an atomic node for the purposes of editing. (NodeImpl::previousNodeConsideringAtomicNodes): New helper to traverse tree taking atomic nodes into account. (NodeImpl::nextNodeConsideringAtomicNodes): Ditto. (NodeImpl::previousLeafNode): Now calls nextNodeConsideringAtomicNodes to iterate. This helps to prevent deleting PARAM tag portions of object tags erroneously. (NodeImpl::nextLeafNode): Ditto.
  • khtml/xml/dom_nodeimpl.h: Removed m_rendererNeedsClose bit. Added declarations for new functions.
  • khtml/xml/dom_position.cpp: (DOM::Position::equivalentDeepPosition): Now takes atomic nodes into account as it drills down into the tree.
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::endElement): Remove call to obsolete closeRenderer() function.
4:22 PM Changeset in webkit [7186] by hyatt
  • 4 edits in trunk/WebCore

Add the deprecated text/xsl MIME type (introduced by Internet Explorer 5) as an acceptable MIME type for XML
documents.

Reviewed by john

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty):
  • khtml/khtml_part.cpp: (KHTMLPart::begin):
  • khtml/misc/loader.cpp: (CachedXBLDocument::CachedXBLDocument):
3:45 PM Changeset in webkit [7185] by kdecker
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Rolled in changes from the latest KJS sources that support additional
Number.prototype functions.

Specifically this patch covers the follow parts of the ECMA 3 spec:

15.7.4.5, 15.7.4.6, and 15.7.4.7

Fixes:
<rdar://problem/3663716> missing Number.toFixed (and toPrecision, toExponential)
<rdar://problem/3749492> missing Number.toPrecision prototype implementation
<rdar://problem/3749591> missing Number.toExponential prototype implementation

  • kjs/identifier.h: Added toFixed, toPrecision, and toExponential to the list of supported identifiers (a macro).
  • kjs/number_object.cpp: Implemented support for toFixed(), toPrecision(), and toExponential(). (NumberPrototypeImp::NumberPrototypeImp): (NumberProtoFuncImp::call):
  • kjs/number_object.h: Added property names for toFixed, toPrecision, and toExponential. (KJS::NumberProtoFuncImp::):
  • tests/mozilla/expected.html: Update results.
3:37 PM Changeset in webkit [7184] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • implemented enough of the NSTextInput protocol and added the proper calls to NSInputManager to allow input methods to work. However, the text is not marked yet.
  • WebView.subproj/WebHTMLViewInternal.h: Added new fields to track marked range.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView markedRange]): Implemented (-[WebHTMLView conversationIdentifier]): Implemented (-[WebHTMLView hasMarkedText]): Implemented (-[WebHTMLView unmarkText]): Implemented (-[WebHTMLView setMarkedText:selectedRange:]): Implemented - does not yet handle attributes in attributed strings (-[WebHTMLView insertText:]): Modified to handle replacing or abandoning the marked text when set. (-[WebHTMLView _selectMarkedText]): new helper method, self-explanatory (-[WebHTMLView _setMarkedDOMRange:]): hitto. (-[WebHTMLView _selectRangeInMarkedText:]): ditto (-[WebHTMLView _discardMarkedText]): ditto (-[WebHTMLView _selectionIsInsideMarkedText]): ditto (-[WebHTMLView _updateSelectionForInputManager]): ditto
  • did a bit of refactoring while I was in here.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _shouldReplaceSelectionWithText:givenAction:]): added this new helper method to simplify the common case of calling the shouldInsertText: delegate (-[WebHTMLView pasteAsPlainText:]): use it (-[WebHTMLView insertTab:]): ditto (-[WebHTMLView insertNewline:]): ditto (-[WebHTMLView _changeWordCaseWithSelector:]): ditto (-[WebHTMLView _changeSpellingToWord:]): ditto (-[WebHTMLView _selectionChanged]): ditto
2:56 PM Changeset in webkit [7183] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3572737> Images not resizing at www.bmx-test.com (spoof nofix)

Reviewed by darin.

  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]): hard code image/pjpeg to the list of image mime types that we can handle
2:41 PM Changeset in webkit [7182] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • remove assertions that asserted text is non-empty, just avoid doing anything for the empty case; this is needed because input methods like to insert empty text in various cases.
  • khtml/editing/htmlediting_impl.cpp: (khtml::InsertTextCommandImpl::InsertTextCommandImpl): (khtml::InsertTextCommandImpl::doApply): (khtml::InsertTextCommandImpl::doUnapply):
11:28 AM Changeset in webkit [7181] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • added support for copying RegExp objects so 7 more Mozilla regexp tests pass
  • kjs/regexp_object.cpp: (RegExpObjectImp::construct): Check for case where we are supposed to just copy the regular expression object, and do so. Also tighten up arguments check to handle case where an actual "undefined" is passed rather than just omitting an argument.
  • tests/mozilla/expected.html: Update results.
11:09 AM Changeset in webkit [7180] by darin
  • 8 edits
    2 adds in trunk

WebCore:

Reviewed by Ken.

  • fixed <rdar://problem/3740937> ER: A way to turn a DOMRange into text (equivalent of -innerText)
  • khtml/xml/dom2_rangeimpl.h: Added text function. Like innerText, but on a range.
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::text): Added.
  • kwq/DOM.mm: (-[DOMRange _text]): Added. Calls DOM::RangeImpl::text.
  • kwq/DOMPrivate.h: Added.
  • WebCore.pbproj/project.pbxproj: Added DOMPrivate.h, an internal header (private in WebKit, internal here).

WebKit:

Reviewed by Ken.

  • fixed <rdar://problem/3740937> ER: A way to turn a DOMRange into text (equivalent of -innerText)
  • DOM.subproj/DOMPrivate.h: Added.
  • WebKit.pbproj/project.pbxproj: Added DOMPrivate.h.
  • copy-webcore-files-to-webkit: Added DOMPrivate.h.

Aug 2, 2004:

4:49 PM Changeset in webkit [7179] by darin
  • 3 edits
    1 add in trunk/JavaScriptCore
  • tests/mozilla/.cvsignore: Added.
  • tests/mozilla/expected.html: Update results.
4:47 PM Changeset in webkit [7178] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed RegExp.toString so 3 more Mozilla regexp tests pass
  • kjs/regexp_object.cpp: (RegExpProtoFuncImp::call): Append the flags here so more tests paseed.
4:43 PM Changeset in webkit [7177]
  • 4 copies
    2 deletes in tags/WebCore-154~0~1

This commit was manufactured by cvs2svn to create tag
'WebCore-154~0~1'.

4:43 PM Changeset in webkit [7176] by vicki
  • 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Fix the install path so that WebCore will build again in B&I. Looks like some changes to the project file were accidentally committed (I saw "INSTALL_PATH_MODIFIED_BY_SCRIPT_DO_NOT_COMMIT").

4:38 PM Changeset in webkit [7175] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed a couple things making 5 Mozilla regexp tests pass
  • kjs/regexp_object.cpp: (RegExpProtoFuncImp::call): Implement toString for the prototype. (RegExpObjectImp::construct): Fix bug where the string "undefined" would be used as the flags string when no parameter was passed.
  • kjs/regexp_object.h: (KJS::RegExpPrototypeImp::classInfo): Added a class info object for RegExp prototype so it can return a string instead of raising an exception when converting to a string.
  • tests/mozilla/expected.html: Update results.
3:31 PM Changeset in webkit [7174] by sullivan
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/3631868> NSToolbar adoption:
Tab key should cycle around toolbar and page content

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge nextKeyViewInsideWebFrameViews]): Made this method start looking from the current focus node. This won't affect any existing callers because there were no existing callers. (-[WebCoreBridge previousKeyViewInsideWebFrameViews]): ditto

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/3631868> NSToolbar adoption:
Tab key should cycle around toolbar and page content

  • WebView.subproj/WebHTMLView.m: removed overrides of nextKeyView and previousKeyView (-[WebHTMLView nextValidKeyView]): call super only if we can't move the focus within the frame hierarchy (-[WebHTMLView previousValidKeyView]): ditto
  • WebView.subproj/WebHTMLViewInternal.h: removed nextKeyViewAccessShouldMoveFocus ivar
3:15 PM Changeset in webkit [7173] by hyatt
  • 2 edits in trunk/WebCore

Create a #define for XSLT support that at the moment will only be enabled on Tiger.

Reviewed by kocienda

  • WebCorePrefix.h:
3:01 PM Changeset in webkit [7172] by vicki
  • 1 edit in branches/Safari-1-2-branch/WebKit/ChangeLog

Add missing WebKit-125.4 release marker to the Changelog; I diffed to be sure that the fix for 3728558 was included in WebKit-125.4

2:44 PM Changeset in webkit [7171] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by Kevin.

  • fix crashes in mozilla tests due to mishandling NaN
  • kjs/array_object.cpp: (ArrayProtoFuncImp::call): Rerranged range checks after calls to toInteger so that NaN will get turned into something that fits in an integer. These were the ones John already fixed, but his fix used isnan and the new fix is more efficient.
  • kjs/number_object.cpp: (NumberProtoFuncImp::call): Rearranged radix range checks after a call to toInteger to handle NaN properly. Also removed separate check for undefined that's not needed.
  • kjs/string_object.cpp: (StringProtoFuncImp::call): More of the same kinds of changes as in the above two files, but for a lot more functions. Also changed one place with an explicit check for undefined to instead just check isNaN.
  • tests/mozilla/run-mozilla-tests: Changed to invoke jst using $SYMROOTS for people like me who don't keep $SYMROOTS in their $PATH.
11:38 AM Changeset in webkit [7170] by kocienda
  • 5 edits in trunk/WebKit

Tests:

Reviewed by John

Remove special code that placed the caret when the document loads.
This is now handled by WebKit in a more generalized way.

  • Blot/Blot.xcode/project.pbxproj:
  • Blot/BlotDocument.m: (-[BlotDocument webView:didFinishLoadForFrame:]):

WebKit:

Reviewed by John

Update name of firstResponderIsSelfOrDescendantView, adding _web_ prefix to this SPI call.

Do some work to make caret blinking in newly-created editable WebView's that are
similar in structure to Blot more "automatic".

  • Misc.subproj/WebNSViewExtras.h: Change name of firstResponderIsSelfOrDescendantView. Add _web_ prefix.
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_firstResponderIsSelfOrDescendantView]): Name change. (-[NSView _web_firstResponderCausesFocusDisplay]): Adds an additional check for whether the view's is first responder. This helps to make the focus setting in viewDidMoveToWindow work right.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateFocusDisplay]): Use _web_firstResponderCausesFocusDisplay now instead of firstResponderIsSelfOrDescendantView. (-[WebHTMLView viewDidMoveToWindow]): Schedule call to updateFocusDisplay for the next crank of the run loop. The reason is that placing the caret in the just-installed view requires the HTML/XML document to be available on the WebCore side, but it is not at the time this code is running. However, it will be there on the next crank of the run loop. Doing this helps to make a blinking caret appear in a new, empty window "automatic". (-[WebHTMLView performKeyEquivalent:]): _web_firstResponderIsSelfOrDescendantView name change.
  • WebView.subproj/WebView.m: (-[WebView _performResponderOperation:with:]): _web_firstResponderIsSelfOrDescendantView name change.
11:04 AM Changeset in webkit [7169] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3747945> Deleting replaced element can cause crash

  • khtml/xml/dom_selection.cpp: (DOM::Selection::layoutCaret): The crux of the problem is that the caret drawing code tries to draw the caret at the image offset after it has been removed from the document. So, make sure the start node for the selection is in the document before trying to lay out the caret using that node.
Note: See TracTimeline for information about the timeline view.