Timeline
Aug 8, 2004:
- 1:44 PM Changeset in webkit [7211] by
-
- 2 edits in trunk/WebKit
Reviewed by vicki (changes by rjw)
- make "weak" linking with Quartz work with buildit
- WebKit.pbproj/project.pbxproj:
Aug 6, 2004:
- 5:25 PM Changeset in webkit [7210] by
-
- 19 edits in trunk
WebCore:
Reviewed by Maciej
Finish off spellchecking support to HTML editing. Includes work to
enable continuous spellchecking.
- khtml/editing/htmlediting_impl.cpp: (khtml::EditCommandImpl::markMisspellingsInSelection): Basically, a one-liner convenience to make the call over to the KWQKHTMLPart. (khtml::ReplaceSelectionCommandImpl::doApply): Did some rearranging of code so that the inserted content can be spell-checked. The function is basically the same, except for the addition of calls to markMisspellingsInSelection. (khtml::TypingCommandImpl::markMisspellingsAfterTyping): New function. Takes a look at the selection that results after typing and determines whether it needs to spellcheck. Since the word containing the current selection is never marked, this does a check to see if typing made a new word that is not in the current selection. Basically, you get this by being at the end of a word and typing a space. (khtml::TypingCommandImpl::typingAddedToOpenCommand): Call markMisspellingsAfterTyping.
- khtml/editing/htmlediting_impl.h: Add new function declarations.
- khtml/khtml_part.cpp:
(KHTMLPart::setSelection): Since spell checks are updated when the selection changes,
and every selection change passes through here, this is a good place to put the call
to the spellchecker.
- khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): Remove temporary misspelling line drawing code. Replace with call that does AppKit-style drawing. Fix up some comments.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::addMarker): Repaint the node that had the marker added. This makes it show up on setting it. (DocumentImpl::removeMarker): Ditto. (DocumentImpl::removeAllMarkers): New function. Convenience for clearing all markers. Used when not in continuous spellchecking mode. (DocumentImpl::shiftMarkers): Moves markers in response to changes in a node's contents. This shifts the marker offsets by a given amount. This keeps the markers in the right place when a user types in a node with markers already set on it.
- khtml/xml/dom_docimpl.h: Added new functions. Removed unnecessary enum qualifier from some declarations.
- khtml/xml/dom_position.cpp: (DOM::Position::previousWordBoundary): This function was susceptible to endless loops...and needlessly so. Basically, if the current position is at a word boundary, run the code again to find the previous word boundary. (DOM::Position::nextWordBoundary): Same as above, but for next word boundary.
- khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): Call shiftMarkers to update markers when this node changes. (CharacterDataImpl::insertData): Ditto. (CharacterDataImpl::deleteData): Ditto. (CharacterDataImpl::replaceData): Ditto.
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellingsInSelection): (KWQKHTMLPart::updateSpellChecking): (KWQKHTMLPart::respondToChangedSelection):
- kwq/KWQPainter.h:
- kwq/KWQPainter.mm: (QPainter::drawLineForMisspelling): New function. Call over to WebKit to do the drawing.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Pass markMisspellings flag to setSelection call.
- kwq/WebCoreTextRenderer.h:
WebKit:
Reviewed by Maciej
Finish off spellchecking support to HTML editing. Includes work to
enable continuous spellchecking.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge isContinuousSpellCheckingEnabled]): Simple bridge method.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForMisspelling:withWidth:]): New method to add AppKit-style misspelling underline.
- 11:50 AM Changeset in webkit [7209] by
-
- 3 edits in trunk
156u, Safari 2.0 for TOT. The tree is open!
- 11:45 AM Changeset in webkit [7208] by
-
- 6 edits in trunk
Safari-155 stamp
Aug 5, 2004:
- 8:18 PM Changeset in webkit [7207] by
-
- 2 edits in trunk/WebKit
- WebView.subproj/WebHTMLView.m: Added a list of methods that NSTextView implements that we don't. All inside #if 0.
- 6:05 PM Changeset in webkit [7206] by
-
- 6 edits in trunk/JavaScriptCore
Fixed part of 3674747. The QT guys need this for feature freeze.
This patch implements support for the
- (id)invokeUndefinedMethodFromWebScript:(NSString *)name withArguments:(NSArray *)args
method of objects bound to JavaScript.
Reviewed by John.
- ChangeLog:
- bindings/objc/objc_class.mm: (ObjcClass::methodsNamed): (ObjcClass::fieldNamed):
- bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
- bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcMethod::~ObjcMethod): (KJS::Bindings::ObjcMethod::isFallbackMethod): (KJS::Bindings::ObjcMethod::javaScriptName):
- bindings/objc/objc_runtime.mm: (ObjcMethod::ObjcMethod): (ObjcMethod::getMethodSignature): (ObjcMethod::setJavaScriptName):
- bindings/testbindings.mm:
- 3:32 PM Changeset in webkit [7205]
-
- 64 copies2 deletes in tags/WebCore-125~8~6
This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~6'.
- 3:32 PM Changeset in webkit [7204] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
bump the version number again for latest Moccasin fix, WebCore-125.8.6
- 3:27 PM Changeset in webkit [7203] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
- merge this fix from HEAD for SUPanMoccasin
2004-08-05 David Hyatt <hyatt@apple.com>
Fix for 3752542, stack overflow that crashes Safari at www.dr.dk. This bug is a regression caused by a fix that
attempted to repair <caption> behavior to make it behave like Panther. This fix was incorrect, and in addition
even our <caption> behavior on Panther was incorrect.
The patch that fixes this bug also makes <caption> handling work when <caption>s are contained inside a <td>, a <tr>,
a <th>, or various table section tags (<tbody>, <tfoot>, <thead>). The <caption> is pulled out and inserted just before
the relevant ancestor table section. This behavior matches other browsers.
Reviewed by mjs
- khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
- 2:54 PM Changeset in webkit [7202] by
-
- 2 edits in trunk/WebCore
Fix for 3752542, stack overflow that crashes Safari at www.dr.dk. This bug is a regression caused by a fix that
attempted to repair <caption> behavior to make it behave like Panther. This fix was incorrect, and in addition
even our <caption> behavior on Panther was incorrect.
The patch that fixes this bug also makes <caption> handling work when <caption>s are contained inside a <td>, a <tr>,
a <th>, or various table section tags (<tbody>, <tfoot>, <thead>). The <caption> is pulled out and inserted just before
the relevant ancestor table section. This behavior matches other browsers.
Reviewed by mjs
- khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
- 2:52 PM Changeset in webkit [7201] by
-
- 3 edits in trunk/WebKit
WebKit:
Fixed unnecessary import of NSURLFileTypeMappings.
- WebView.subproj/WebMainResourceClient.m:
WebBrowser:
Fixed unnecessary import of NSURLFileTypeMappings.
- BrowserWebController.m:
- 12:27 PM Changeset in webkit [7200] by
-
- 2 edits in trunk/WebKit
Make builds conditionally include -framework Quartz.
Reviewed by Chris.
- WebKit.pbproj/project.pbxproj:
- 11:04 AM Changeset in webkit [7199]
-
- 64 copies2 deletes in tags/WebCore-125~8~4
This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~4'.
- 11:04 AM Changeset in webkit [7198] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
- versioning for SUPanMoccasin, WebCore-125.8.4
- 10:59 AM Changeset in webkit [7197]
-
- 64 copies2 deletes in tags/WebCore-125~8~5
This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~5'.
- 10:59 AM Changeset in webkit [7196] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
- new versioning for SUPanXpress (WebCore-125.8.5), since the fix for 3534851 (Moccasin clone is 3703230) has to be backed out here as well
- 10:54 AM Changeset in webkit [7195] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
- roll out this chang for SUPanMoccasin, since it causes 3751025
2004-06-18 John Sullivan <sullivan@apple.com>
Reviewed by Darin
- fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)
- khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <
Aug 4, 2004:
- 5:18 PM Changeset in webkit [7194] by
-
- 2 adds in trunk/LayoutTests/fast/js
add a layout test for 3649789
- 4:58 PM Changeset in webkit [7193] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by mjs.
- fix <rdar://problem/3649789> SAP WebGUI has problems loading first page because of parse error
- kjs/lexer.cpp: (Lexer::lex): if the current character is a '\' and the next character is a line terminator, go to the next line and continue parsing the string (instead of failing). This matches behavior in Mac IE and Mozilla.
- 3:05 PM Changeset in webkit [7192] by
-
- 8 edits2 adds in trunk/WebCore
The top-level XSL sheet is now loaded and shows up in the activity window. It is not yet parsed.
Reviewed by kocienda
- WebCore.pbproj/project.pbxproj:
- khtml/css/css_base.h: (DOM::StyleBaseImpl::isXSLStyleSheet):
- khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl):
- khtml/css/css_stylesheetimpl.h: (DOM::StyleSheetImpl::isLoading):
- khtml/misc/loader.cpp:
- khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::ProcessingInstructionImpl): (DOM::ProcessingInstructionImpl::checkStyleSheet): (DOM::ProcessingInstructionImpl::sheet): (DOM::ProcessingInstructionImpl::isLoading): (DOM::ProcessingInstructionImpl::setStyleSheet):
- khtml/xml/dom_xmlimpl.h:
- 1:25 PM Changeset in webkit [7191] by
-
- 3 edits in trunk/WebCore
Add XSL Stylesheets to the WebCore cache.
Reviewed by kocienda
- khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXSLStyleSheet::ref): (CachedXSLStyleSheet::deref): (CachedXSLStyleSheet::data): (CachedXSLStyleSheet::checkNotify): (CachedXSLStyleSheet::error): (DocLoader::requestXSLStyleSheet): (Cache::requestXSLStyleSheet): (Cache::getStatistics):
- khtml/misc/loader.h: (khtml::CachedObject::): (khtml::CachedXSLStyleSheet::sheet): (khtml::CachedXSLStyleSheet::schedule):
- 9:50 AM Changeset in webkit [7190] by
-
- 2 edits in trunk/WebKit
- fixed broken Deployment build
- Carbon.subproj/HIWebView.m: (Click): Remove code that checks err variable before setting it.
