Context Navigation

khtml/rendering/render_form.cpp: (RenderSlider::RenderSlider): Listen for signal. (RenderSlider::slotClicked): Pass to superclass.
khtml/rendering/render_form.h:
kwq/KWQSlider.h:
kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): Generate mouseUp and clicked events, since AK consumes the mouseUp event in a modal tracking loop. (QSlider::QSlider): Make signal. (QSlider::clicked): Send signal.

10:45 AM Changeset in webkit [7256] by darin

4 edits in trunk/WebKit

Reviewed by Chris.

fixed <rdar://problem/3760924> Carbon path passed in NPP_StreamAsFile must be in local character set, not UTF-8

Plugins.subproj/WebBaseNetscapePluginStream.m: (CarbonPathFromPOSIXPath): Added. New function that uses the path pieces from an FSSpec. This has many advantages; the big one that fixes the bug is that it gives the mangled names that work even for files that have names that can't otherwise be encoded in Carbon-style path names. I didn't write this from scratch: I started with the method in Foundation and just changed it to use FSSpec. (-[WebBaseNetscapePluginStream destroyStream]): Remove code that used NSString and just call CarbonPathFromPOSIXPath instead.

Plugins.subproj/npapi.h: The Revision tag wanted to touch this file. I think we are going to have some trouble with this; I'd like to take that out.

English.lproj/StringsNotToBeLocalized.txt: Updated.

10:13 AM Changeset in webkit [7255] by trey

5 edits in trunk

WebCore:

3761329 - query result links all dead in ingrammicro.com (sometimes)
3761328 - links in some docs dead when doc is loaded from WebArchive

Make sure to get part to completed state when end is called,
even if we have no doc. See WebKit changelog for more info.

Reviewed by Richard and Darin.

khtml/khtml_part.cpp: (KHTMLPart::end):

WebKit:

3761329 - query result links all dead in ingrammicro.com (sometimes)
3761328 - links in some docs dead when doc is loaded from WebArchive

Nasty problem. It turns out that these result pages are a parent frame with two child
frames. One of the child frames is a 1 or 2 byte text document. When the text child
is the last doc to complete, because we use a Text rep instead of an HTMLRep, it turns
out we never send [bridge end] from WebKit. That mistake results in checkCompleted not
being called enough in the part, and we never realize the load is done. WebCore does
not allow redirects to happen until the entire load is complete, and the links on this
results page are actually little pieces of JS that set location to a generated URL. Since
redirects are not allowed these links all silently fail to do anything, and the doc never
achieves a completed state where they will work.

Solution is to make sure we always call [bridge end] from the DataSource instead of only
the HTML rep doing it.

Reviewed by Richard and Darin.

WebView.subproj/WebDataSource.m: (-[WebDataSource _finishedLoading]): Call [bridge end] here for all kinds of docs.
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Don't call is just for HTMLReps.

9:57 AM Changeset in webkit [7254] by trey

2 edits in trunk/WebCore

3761098 - red dotted underline for misspelled words shows up in drag image

Reviewed by Ken

khtml/rendering/render_text.cpp: (RenderText::paint): Don't draw misspelling when creating selection image.

9:50 AM Changeset in webkit [7253] by darin

1 edit
1 add in trunk/JavaScriptCore

fix build so we can compile again

bindings/npapi.h: Added. Richard forgot to check this in. The one I'm checking in here is good enough so that we can compile, but it's only a stopgap measure, because I think Richard has a newer one he wants to check in.

Aug 12, 2004:

6:31 PM Changeset in webkit [7252] by rjw

15 edits
1 add in trunk

WebKit:

Bring npruntime.h and friends closer to compliance with
latest spec.

Reviewed by Maciej.

Plugins.subproj/npapi.h:
Plugins.subproj/npfunctions.h:
Plugins.subproj/npruntime.h: (_NPString::): (_NPString::_NPVariant::):
copy-webcore-files-to-webkit:

WebCore:

Bring npruntime.h and friends closer to compliance with
latest spec.

Reviewed by Maciej.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptNPObject):

JavaScriptCore:

Bring npruntime.h and friends closer to compliance with
latest spec.

Reviewed by Maciej.

JavaScriptCore.pbproj/project.pbxproj:
bindings/NP_jsobject.cpp: (jsAllocate): (_NPN_CreateScriptObject): (NPN_Call): (NPN_Evaluate): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty):
bindings/NP_jsobject.h:
bindings/c/c_instance.cpp: (CInstance::invokeMethod):
bindings/c/c_utility.cpp: (convertNPVariantToValue):
bindings/npruntime.cpp: (NPN_IdentifierIsString): (NPN_VariantIsVoid): (NPN_VariantIsNull): (NPN_VariantIsUndefined): (NPN_VariantIsBool): (NPN_VariantIsInt32): (NPN_VariantIsDouble): (NPN_VariantIsString): (NPN_VariantIsObject): (NPN_VariantToBool): (NPN_VariantToString): (NPN_VariantToInt32): (NPN_VariantToDouble): (NPN_VariantToObject): (NPN_InitializeVariantAsVoid): (NPN_InitializeVariantAsNull): (NPN_InitializeVariantAsUndefined): (NPN_InitializeVariantWithBool): (NPN_InitializeVariantWithInt32): (NPN_InitializeVariantWithDouble): (NPN_InitializeVariantWithString): (NPN_InitializeVariantWithStringCopy): (NPN_InitializeVariantWithObject): (NPN_InitializeVariantWithVariant): (NPN_ReleaseVariantValue): (NPN_CreateObject):
bindings/npruntime.h: (_NPString::): (_NPString::_NPVariant::):
bindings/npruntime_priv.h: Added.

5:43 PM Changeset in webkit [7251] by mjs

2 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3245706> URLs with backslashes instead of slashes work on WinIE; should work on Safari (SAP)
<rdar://problem/3506429> <BASE> tag containing backslash is breaking images with absolute URLs

kwq/KWQKURL.mm: (substituteBackslashes): Helper method (KURL::KURL): If the URL contains any backslashes, substitute all that appear before the query or fragment.

5:25 PM Changeset in webkit [7250] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3761097> should be able to option-drag selection so HTML can be copied within a page

Reviewed by rjw.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isMoveDrag]): new, take into account the option key (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): call _isMoveDrag (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): call _isMoveDrag

4:58 PM Changeset in webkit [7249] by kocienda

4 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3761014> command-down-arrow takes you to start of document instead of end of document

khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Code used to assume, incorrectly, that index 1 of the document element was beyond the last node in the document. But this is not true, since the document element is the HTML element (generally). Instead, move to the index equal to the number of children of the document element. This puts us past everything. (DOM::Selection::modifyMovingRightForward): Ditto.

4:28 PM Changeset in webkit [7248] by kocienda

2 edits in trunk/WebCore

Reviewed by Trey

Fix for this bug:

<rdar://problem/3695446> shift-down-arrow on last line of editable text should select to end of document

Detect when current position is on first or last line and move to the
start or end of that line, respectively.

khtml/xml/dom_position.cpp: (DOM::Position::previousLinePosition) (DOM::Position::nextLinePosition)

4:19 PM Changeset in webkit [7247] by rjw

3 edits in trunk/WebKit

Quick fix for 3760903. The real fix is described in 3760920. Needed
by Java plugin guys so they can be unblocked for feature freeze.

Reviewed by Chris.

WebView.subproj/WebFrame.m: (-[WebFrame _reloadForPluginChanges]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]):

4:04 PM Changeset in webkit [7246] by cblu

2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3760898> error pages in subframes attempt to load appledata URLs when reloaded

Reviewed by darin.

WebView.subproj/WebFrame.m: (-[WebFrame _createItem:]): when setting the original URL of the history item, use the unreachable URL

WebBrowser:

Fixed:
<rdar://problem/3760743> "Save As.." and "View Source" context menu items should be omitted from error pages
<rdar://problem/3760892> PARENTAL: buttons in parental control error page do nothing when in subframes

Reviewed by darin

BrowserWebController.m: (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]): handle subframes for error page schemes
ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): omit menu item in error pages

4:04 PM Changeset in webkit [7245] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Adele.

fixed 3 problems with parse functions that I just wrote, fixing 3 more Mozilla JavaScript tests

kjs/function.cpp: (KJS::parseDigit): Fix typo, 'Z' instead of 'z', that prevented lowercase hex digits from working. (KJS::parseInt): Add octal support. Specification says it's optional, but I guess not. (KJS::parseFloat): Fix check for "0x" in parseFloat to return 0 rather than NaN. Also add code to skip leading "+" or "-".

3:57 PM Changeset in webkit [7244] by vicki

3 edits in trunk

back to 157u, 2.0 for TOT. the tree is open!

3:47 PM Changeset in webkit [7243]

3 copies in tags/Safari-156

This commit was manufactured by cvs2svn to create tag 'Safari-156'.

3:47 PM Changeset in webkit [7242] by vicki

6 edits in trunk

Safari-156 stamp

1:53 PM Changeset in webkit [7241] by kocienda

5 edits in trunk/WebCore

Reviewed by Darin

Some consolidation in style application code.

khtml/editing/htmlediting_impl.cpp: (khtml::StyleChange::StyleChange): Made this a full-on class and added a couple of members and a constructors to make a StyleChange from a CSSStyleDeclarationImpl, as well as from a CSSStyleDeclarationImpl and a Position. (khtml::StyleChange::init): Common init function for StyleChange constructors. (khtml::StyleChange::currentlyHasStyle): Moved this here from ApplyStyleCommandImpl. (khtml::CompositeEditCommandImpl::applyTypingStyle): Tweak to adjust to new StyleChange interface. (khtml::ApplyStyleCommandImpl::applyStyleIfNeeded): Ditto.
khtml/editing/htmlediting_impl.h: (khtml::StyleChange::StyleChange): (khtml::StyleChange::cssStyle): New accessor. (khtml::StyleChange::applyBold): Ditto. (khtml::StyleChange::applyItalic): Ditto.
khtml/xml/dom_position.cpp: (DOM::Position::computedStyle): New helper.
khtml/xml/dom_position.h: Ditto.

10:34 AM Changeset in webkit [7240] by kocienda

7 edits in trunk

Reviewed by Darin

Fix for this bug:
<rdar://problem/3751098> HTML email has one set of SPAN tags per character in the message

Progress on this bug:
<rdar://problem/3755562> Typing styles do not use same tag application conventions as font and color panel

khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::applyTypingStyle): Name changed from createTypingStyleElement. Also, interface changed to take the node to which the typing style is to be applied. This makes it easier to apply what may be up to three levels of nested tags to get the desired style (<B>, <I>, and <SPAN STYLE="">). Also, Borrow some of the style change smarts from ApplyStyleCommandImpl to use bold and italic tags for applying styles when that is apprpriate. This creates on opportunity to factor the code to do this so that this function and the ApplyStyleCommandImpl class can share the implementation. I will follow up with a change to do that after landing this change. Some future code factoring could be done here to bring together some similar code into one place. (khtml::ApplyStyleCommandImpl::applyStyleIfNeeded): Add comment about code factoring work. (khtml::ApplyStyleCommandImpl::computeStyleChange): StyleChange struct no longer a member of the ApplyStyleCommandImpl class. CompositeEditCommandImpl needs it now in its applyTypingStyle() function. (khtml::InputNewlineCommandImpl::doApply): Pass along node to style to applyTypingStyle. (khtml::InputTextCommandImpl::prepareForTextInsertion): Ditto.
khtml/editing/htmlediting_impl.h: (khtml::StyleChange::StyleChange): Pull this struct out of ApplyStyleCommandImpl so CompositeEditCommandImpl can use it.
khtml/khtml_part.cpp: (KHTMLPart::notifySelectionChanged): Always clear typing style when the selection changes, not only when closing typing. This fixes 3751098.

These three tests actually had results that treated the buggy behavior as correct!

layout-tests/editing/style/style-3681552-fix-001-expected.txt
layout-tests/editing/style/style-3681552-fix-002-expected.txt
layout-tests/editing/style/typing-style-002-expected.txt

10:21 AM Changeset in webkit [7239] by darin

23 edits in trunk/JavaScriptCore

Reviewed by Ken.

fixed 43 Mozilla JavaScript tests

kjs/date_object.h: Change parseDate and timeClip to take and return doubles.
kjs/date_object.cpp: (DateObjectImp::construct): Change to use a timeClip function that takes and returns a double rather than constructing a number object to pass to it. (DateObjectFuncImp::call): Change to use a parseDate function that returns a double. (KJS::parseDate): Change to return a double instead of creating the Number object here. (KJS::timeClip): Implement this as specified in the language standard.

kjs/error_object.cpp: (NativeErrorImp::NativeErrorImp): Set the DontDelete, ReadOnly, and DontEnum flags on the prototype property.

kjs/function.cpp: (KJS::FunctionImp::get): Return null rather than undefined for arguments when the function is not currently in scope. (KJS::isStrWhiteSpace): Added. Matches specification for StrWhiteSpace. Could move it to some utility file later. (KJS::parseDigit): Added. Helper function for parseInt. (KJS::parseInt): Added. Integer parser that puts result in a double so we're not limited to what strtoll can handle. Also matches standard more closely. (KJS::parseFloat): Added. Handles "0x" properly and passes flag to make empty string turn into NaN instead of 0. (KJS::GlobalFuncImp::call): Use the new parseInt and parseFloat.

kjs/function_object.cpp: (FunctionPrototypeImp::FunctionPrototypeImp): Add a length property.

kjs/lexer.h: Added error flag and sawError() function for detecting errors.
kjs/lexer.cpp: (Lexer::setCode): Clear error state. (Lexer::lex): Set error state if the lexer encounters an error

kjs/internal.cpp: (NumberImp::toString): Roll in change from KDE version to special case 0 so we handle -0 correctly. (Parser::parse): Use new lexer error method so those errors are treated like parser errors.

kjs/math_object.cpp: (MathFuncImp::call): Change min and max to treat -0 as less than +0. Change round to round values between -0.5 and -0 to -0 instead of +0.

kjs/nodes.h: Add evaluateReference function to GroupNode.
kjs/nodes.cpp: (GroupNode::evaluateReference): Pass references through groups (parenthesized expressions) properly so that expressions like "delete (x.y)" work. Before, the parentheses would change x.y into a value that can't be deleted as a side effect.

kjs/string_object.cpp: Change parameter count for indexOf and lastIndexOf from 2 to 1 to match the specification.

kjs/testkjs.cpp: Rolled in changes from KDE to add a "quit" function to the test tool and get rid of the fixed size limit for code.

kjs/ustring.cpp: (KJS::UString::substr): Added optimized case for substr(0, length) so it just returns the string without creating a new Rep, since I'm using substr in a place where it will often be passed a 0.

tests/mozilla/ecma/String/15.5.4.11-1.js: Fixed one wrong entry in the Unicode table I added to the other day that was making a couple tests fail.
tests/mozilla/ecma/String/15.5.4.12-1.js: Ditto.
tests/mozilla/ecma/String/15.5.4.12-2.js: Ditto.
tests/mozilla/ecma/String/15.5.4.12-3.js: Ditto.
tests/mozilla/ecma/String/15.5.4.12-4.js: Ditto.
tests/mozilla/ecma/String/15.5.4.12-5.js: Ditto.

kjs/string_object.lut.h: Regenerated.

9:45 AM Changeset in webkit [7238] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3740485> Repro crash involving replacing content that includes form field

kwq/KWQLineEdit.mm: (QLineEdit::selectAll): Since this function calls selectText: which has a side effect of making the text field be first responder, call to bridge first to make it first responder. The bridge version lets WebHTMLView know we are changing the responder, avoiding some unpleasantness because it sets the "changing focus programmatically" flag. Without that flag set, we were getting an additional setFocusNode(0) call, which is unnecessary and incorrect.

9:39 AM Changeset in webkit [7237] by darin

4 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3758756> copying text selected with down arrow results in all text to end of document

khtml/xml/dom2_rangeimpl.h: Make startNode and pastEndNode public.
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::pastEndNode): Fix bug where this would return one node too far in the case where the end container was not a text node.

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTMLWithOptions): Rewrite loop, using startNode and pastEndNode, to fix bug where it would run past the end node, including too many nodes in the generated HTML. Nice side benefit: easier to read the code.

Aug 11, 2004:

8:17 PM Changeset in webkit [7236] by darin

3 edits in trunk/JavaScriptCore

fixed a tiny problem with the UTF-16 PCRE check-in

pcre/maketables.c: (pcre_maketables): Fix mistake in table-generating code that sometimes caused the ctype_meta flag to get set in items that should not have it.

pcre/chartables.c: Regenerated.

5:36 PM Changeset in webkit [7235] by adele

2 edits in trunk/WebKit

Reviewed by me, bug fix by Darin.

fixed <rdar://problem/3736477> Pages don't load if hard drive is named with non-ASCII Symbol

Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]):

Use UTF8String instead of cString to convert the MIME type to a C string. Safer, since it can't
ever fail due to encoding problems even though this string should always be ASCII.

(-[WebBaseNetscapePluginStream destroyStream]): Use stringWithUTF8String to convert the path name

to an NSString, since stringWithCString is deprecated (doesn't really matter since the path is always
all ASCII). Fix the bug by calling fileSystemRepresentation on the NSString to turn it into a C
string form. Even though the POSIX path can't have any non-ASCII characters in it, the Carbon path
can, so we need to use this instead of cString which can fail depending on characters and encoding.

4:39 PM Changeset in webkit [7234] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3758216> PARENTAL: buttons on parental controls page only work once

Reviewed by john.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): prevent a form from being submitted more than once only if it uses a scheme of http or https

2:35 PM Changeset in webkit [7233] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3715878> 8A162: connect.apple.com password field showed in cleartext

kwq/KWQTextField.mm: (-[KWQSecureTextField textDidEndEditing:]): Enhanced workaround for shifting focus from one secure text field to another so that it works even for the case of shifting focus from a secure text field back to itself.

1:11 PM Changeset in webkit [7232] by kocienda

1 edit
1 add in trunk/WebCore

Reviewed by me

Missed adding this file before.

kwq/KWQTextUtilities.mm: Added. (KWQFindNextWordFromIndex):

10:55 AM Changeset in webkit [7231] by kocienda

2 edits in trunk/WebCore

Reviewed by Trey

Efficiency improvements on string manipulations in these two new function
implementations. Use the versions of QString append/prepend that take
(QChar *c, uint length) instead of creating new strings each time.

khtml/xml/dom_position.cpp: (DOM::Position::previousWordPosition): Changed, as described above. (DOM::Position::nextWordPosition): Ditto.

10:27 AM Changeset in webkit [7230] by kocienda

10 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:
<rdar://problem/3675812> Moving a word at a time does not use the correct conception of "word"

I have implemented versions of previousWordPosition and nextWordPosition that are now
different than previousWordBoundary and nextWordBoundary. The behavior of the new
functions attempts to match what Cocoa does as closely as it can. Let the bug filing begin!

WebCore.pbproj/project.pbxproj: Added KWQTextUtilities.mm
khtml/misc/helper.cpp: (khtml::nextWordFromIndex): Glue to call through to KWQFindNextWordFromIndex.
khtml/misc/helper.h: Declare the function above.
khtml/misc/khtml_text_operations.cpp: Added SimplifiedBackwardsTextIterator class. (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): New (khtml::SimplifiedBackwardsTextIterator::advance): Ditto. (khtml::SimplifiedBackwardsTextIterator::handleTextNode): Ditto. (khtml::SimplifiedBackwardsTextIterator::handleReplacedElement): Ditto. (khtml::SimplifiedBackwardsTextIterator::handleNonTextNode): Ditto. (khtml::SimplifiedBackwardsTextIterator::exitNode): Ditto. (khtml::SimplifiedBackwardsTextIterator::emitCharacter): Ditto. (khtml::SimplifiedBackwardsTextIterator::range): Ditto.
khtml/misc/khtml_text_operations.h: (khtml::SimplifiedBackwardsTextIterator::atEnd): Ditto. (khtml::SimplifiedBackwardsTextIterator::length): Ditto. (khtml::SimplifiedBackwardsTextIterator::characters): Ditto.
khtml/xml/dom_position.cpp: (DOM::Position::previousWordBoundary): Updated to gather appropriate text and call through to AppKit to perform the same calculations NSText uses. (DOM::Position::nextWordBoundary): Ditto. (DOM::Position::previousWordPosition): Unrelated change to fix case where the function could get "stuck". (DOM::Position::nextWordPosition): Ditto (DOM::Position::equivalentDeepPosition): Changed to look backwards if the position's offset is equal to the number of child nodes it has. This handles more cases correctly, like when the position is gives as one beyond the end of a document element's last child.
kwq/KWQTextUtilities.h: Declared KWQFindNextWordFromIndex.
kwq/KWQTextUtilities.mm: Added. (KWQFindNextWordFromIndex): New function.

9:45 AM Changeset in webkit [7229] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3732702> crash in CSSComputedStyleDeclarationImpl running devtools.com editing sample code

khtml/khtml_part.cpp: (KHTMLPart::selectionComputedStyle): Added a null check.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed