⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 17, 2004:

8:13 PM Changeset in webkit [7284] by darin
  • 1 edit in trunk/WebKit/ChangeLog

Change some tabs to spaces.

6:16 PM Changeset in webkit [7283] by rjw
  • 5 edits in trunk/WebKit

Fixed <rdar://problem/3759093> Need PDF context menu: "Open in Preview" or other external app

Added support for "Open with ..." in PDF view.

Reviewed by Chris and Trey.

  • ChangeLog:
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt:
  • WebView.subproj/WebPDFView.h:
  • WebView.subproj/WebPDFView.m: (-[WebPDFView initWithFrame:]): (-[WebPDFView dealloc]): (applicationInfoForMIMEType): (-[WebPDFView path]): (-[WebPDFView menuForEvent:]): (-[WebPDFView setDataSource:]): (-[WebPDFView layout]): (-[WebPDFView viewDidMoveToHostWindow]): (-[WebPDFView openWithFinder:]):
5:09 PM Changeset in webkit [7282] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3703768> CrashTracer: ...50 crashes at com.apple.WebCore: KHTMLPart::xmlDocImpl const + 0

  • khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Add a nil check and an assertion for m_part being null. It seems impossible for this to happen, so we want to debug it ourselves, but in the meantime, let's try to avoid causing crashes for our users.
5:07 PM Changeset in webkit [7281] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adele.

  • fixed <rdar://problem/3746676> SAP WebDynpro app hangs inside JavaScript property map hash table code (deleted sentinel problem)
  • kjs/property_map.h: Added some private functions.
  • kjs/property_map.cpp: (KJS::PropertyMap::clear): Set sentinelCount to 0. (KJS::PropertyMap::put): Complete search for the element before choosing to use the deleted-element sentinel. Also keep sentinel count up to date when we destroy a sentinel by overwriting with a new added element. (KJS::PropertyMap::expand): Added. Calls rehash with a size 2x the old size, or 16. (KJS::PropertyMap::rehash): Added. Refactored the rehash code into a separate function. (KJS::PropertyMap::remove): Add one to sentinelCount, and rehash if 1/4 or more of the elements are deleted-element sentinels. (KJS::PropertyMap::checkConsistency): Check the sentinelCount.
4:19 PM Changeset in webkit [7280] by mjs
  • 2 edits in trunk/JavaScriptCore

Code change by Eric Albert, reviewd by me.

<rdar://problem/3571960> washingtonpost.com claims I don't have cookies enabled and won't let me read articles

  • kjs/date_object.cpp: (timetUsingCF): Clamp time to LONG_MAX (getting rid of time_t entirely would be even better, but is not required to fix this bug.
3:14 PM Changeset in webkit [7279] by rjw
  • 1 edit in trunk/WebKit/Plugins.subproj/WebJavaPlugIn.h

JNI needs both the jmethodID and return type. Changed API to
pass both.

Reviewed by Chris.

  • Plugins.subproj/WebJavaPlugIn.h:
3:03 PM Changeset in webkit [7278] by hyatt
  • 3 edits in trunk/WebCore

Fix the line truncation function for Emerson so that at the far left setting of the slider, only the header
is visible.

Reviewed by darin

  • khtml/rendering/render_block.cpp: (khtml::getHeightForLineCount):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
2:53 PM Changeset in webkit [7277] by kocienda
  • 18 edits in trunk

Reviewed by Hyatt

Rewrite of the command that deletes a selection. I deleted great
big swaths of bug-ridden code to accomplish this and replaced it
with code that is much cleaner and smarter.

Also, renamed equivalentUpstreamPosition and equivalentDownstreamPosition to
upstream to downstream, respectively.

Added a couple of new helper methods.

  • khtml/editing/htmlediting.cpp: DeleteCollapsibleWhitespaceCommand and RemoveNodeAndPruneCommand now obsolete. A huge win.
  • khtml/editing/htmlediting.h: Ditto.
  • khtml/editing/htmlediting_impl.cpp: (khtml::debugPosition): Fix printf which had a placeholder, but no argument passed in the varargs. (khtml::CompositeEditCommandImpl::deleteUnrenderedText): New helper. Much simplified and cleaner version of (khtml::ApplyStyleCommandImpl::doApply): upstream/downstream name change (khtml::ApplyStyleCommandImpl::nodeFullySelected): upstream/downstream name change (khtml::DeleteSelectionCommandImpl::doApply): upstream/downstream name change (khtml::DeleteTextCommandImpl::DeleteTextCommandImpl): Add an assert to check that the passed offset is less than the length of the text node. (khtml::InputNewlineCommandImpl::insertNodeAfterPosition): upstream/downstream name change (khtml::InputNewlineCommandImpl::insertNodeBeforePosition): upstream/downstream name change (khtml::InputNewlineCommandImpl::doApply): upstream/downstream name change (khtml::InputTextCommandImpl::prepareForTextInsertion): upstream/downstream name change (khtml::InputTextCommandImpl::execute): upstream/downstream name change (khtml::InputTextCommandImpl::insertSpace): upstream/downstream name change (khtml::ReplaceSelectionCommandImpl::doApply): upstream/downstream name change (khtml::TypingCommandImpl::issueCommandForDeleteKey): upstream/downstream name change (khtml::TypingCommandImpl::deleteKeyPressed):
  • khtml/editing/htmlediting_impl.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::previousWordBoundary): (DOM::Position::nextWordBoundary): (DOM::Position::upstream): (DOM::Position::downstream): (DOM::Position::inRenderedText): Add null check. (DOM::Position::isRenderedCharacter): New helper. (DOM::isWS): New helper in this file. (DOM::Position::leadingWhitespacePosition): New helper. Factored out from htmlediting_impl.cpp. (DOM::Position::trailingWhitespacePosition): Ditto. (DOM::Position::debugPosition): Add null check.
  • khtml/xml/dom_position.h:
  • khtml/xml/dom_selection.cpp: (DOM::Selection::toRange): upstream/downstream name change (DOM::Selection::validate): upstream/downstream name change (DOM::Selection::debugPosition): upstream/downstream name change
  • layout-tests/editing/deleting/delete-block-contents-003-expected.txt: Updated tests with new expected results.
  • layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt: Ditto.
  • layout-tests/editing/deleting/delete-selection-001-expected.txt: Ditto.
  • layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt: Ditto.
  • layout-tests/editing/inserting/insert-br-case1-expected.txt: Ditto.
  • layout-tests/editing/inserting/insert-br-case2-expected.txt: Ditto.
  • layout-tests/editing/style/style-3681552-fix-002-expected.txt: Ditto.
2:41 PM Changeset in webkit [7276] by trey
  • 5 edits in trunk/WebCore

Various spelling fixes.

Reviewed by Ken.

  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): No misspellings in the spelling code comments
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeMarker): Repaint if doc changes. Sometimes the markers were not being erased when you clicked in a word.
  • khtml/xml/dom_position.cpp: (DOM::Position::previousWordBoundary): Small optimization. Bail after first try if the second try will not come out any different. (DOM::Position::nextWordBoundary): Ditto
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::markMisspellingsInSelection): Comment.
1:42 PM Changeset in webkit [7275] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Added a bug number to the textarea bug fix check-in,
so I can look it up here in ChangeLog.

1:41 PM Changeset in webkit [7274] by darin
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3689700> crash loading page; stoxx.com (works in IE and Firefox)
  • khtml/khtml_part.h: Make completeURL public.
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): Complete the base URL before passing it across the bridge. This sidesteps the crashing bug in CFURL, filed as '<rdar://problem/3764632> CFURLCreateAbsoluteURLWithBytes crashes if passed the string "../.."' and also is obviously correct behavior that may fix other sites too.
  • fixed <rdar://problem/3547725> Crashes at csuohio.edu, list box vs. mouse event problem (Spoof No Fix)
  • kwq/KWQListBox.mm: (QListBox::~QListBox): Nil out the pointer from the KWQTableView back to the widget by calling a new detach method. (-[KWQTableView detach]): Set the pointer to the QListBox to 0. Also set the delegate and data source to nil, so we don't need nil checks in delegate and data source methods. (-[KWQTableView mouseDown:]): Add nil check. (-[KWQTableView keyDown:]): Add nil check. (-[KWQTableView keyUp:]): Add nil check. (-[KWQTableView becomeFirstResponder]): Add nil check. (-[KWQTableView resignFirstResponder]): Add nil check. (-[KWQTableView canBecomeKeyView]): Add nil check. (-[KWQTableView tableViewSelectionDidChange:]): Add nil checks, even though this is a delegate callback, to handle cases where calls to JavaScript result in the QListBox going away partway through. (-[KWQTableView drawRow:clipRect:]): Add nil check. (-[KWQTableView _accessibilityTableCell:tableColumn:]): Add nil check.
12:55 PM Changeset in webkit [7273] by trey
  • 2 edits in trunk/WebCore

Fix ASSERT in spelling marker management.

Reviewed by John.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::shiftMarkers): Use assert instead of ASSERT. Tweak test to allow for a start position of 0.
12:48 PM Changeset in webkit [7272] by trey
  • 5 edits in trunk

WebCore:

3764147 - failure of subframe to load leaves links in parent doc broken

Reviewed by Maciej.

  • khtml/khtml_part.cpp: (KHTMLPart::childBegin): New method to mark part as not complete. (KHTMLPart::processObjectRequest): Mark child part imcomplete, so if we later get a failure on load it won't think it's already complete and do nothing.
  • khtml/khtml_part.h:

WebKit:

3764147 - failure of subframe to load leaves links in parent doc broken

Reviewed by Maciej.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): Need to call [bridge end] in the case of an error, so WC can clean up.
12:05 PM Changeset in webkit [7271] by vicki
  • 3 edits in trunk

set version number to '158u'. the tree is open

11:59 AM Changeset in webkit [7270]
  • 3 copies in tags/Safari-157

This commit was manufactured by cvs2svn to create tag 'Safari-157'.

11:59 AM Changeset in webkit [7269] by vicki
  • 6 edits in trunk

Safari-157 stamp

Aug 16, 2004:

9:53 PM Changeset in webkit [7268] by hyatt
  • 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Fix project so that OTHER_LDFLAGS in the project also links dynamically to libxslt

7:10 PM Changeset in webkit [7267] by hyatt
  • 2 edits in trunk/WebCore

Fix the #define. I had it all backwards.

  • WebCorePrefix.h:
6:54 PM Changeset in webkit [7266] by hyatt
  • 11 edits
    5 adds
    2 deletes in trunk/WebCore

Land initial support for XSLT using xml-stylesheet PIs.

  • WebCore.pbproj/project.pbxproj:
  • khtml/khtml_part.cpp: (KHTMLPart::replaceDocImpl):
  • khtml/khtml_part.h:
  • khtml/khtmlview.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::recalcStyleSelector): (DocumentImpl::applyXSLTransform): (DocumentImpl::setTransformSourceDocument):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::setTransformSource): (DOM::DocumentImpl::transformSource): (DOM::DocumentImpl::transformSourceDocument):
  • khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/dom_xmlimpl.h: (DOM::ProcessingInstructionImpl::isXSL):
  • khtml/xml/xml_tokenizer.cpp: (khtml::matchFunc): (khtml::openFunc): (khtml::createQStringParser): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::finish): (khtml::XMLTokenizer::setTransformSource):
  • khtml/xml/xml_tokenizer.h: (khtml::Tokenizer::setTransformSource):
  • khtml/xml/xsl_stylesheetimpl.cpp: Removed.
  • khtml/xml/xsl_stylesheetimpl.h: Removed.
  • khtml/xsl/xsl_stylesheetimpl.cpp: Added. (DOM::XSLStyleSheetImpl::XSLStyleSheetImpl): (DOM::XSLStyleSheetImpl::~XSLStyleSheetImpl): (DOM::XSLStyleSheetImpl::isLoading): (DOM::XSLStyleSheetImpl::checkLoaded): (DOM::XSLStyleSheetImpl::docLoader): (DOM::XSLStyleSheetImpl::parseString):
  • khtml/xsl/xsl_stylesheetimpl.h: Added. (DOM::XSLStyleSheetImpl::isXSLStyleSheet): (DOM::XSLStyleSheetImpl::type): (DOM::XSLStyleSheetImpl::ownerDocument): (DOM::XSLStyleSheetImpl::document): (DOM::XSLStyleSheetImpl::clearDocument):
  • khtml/xsl/xslt_processorimpl.cpp: Added. (DOM::m_sourceDocument): (DOM::XSLTProcessorImpl::~XSLTProcessorImpl): (DOM::XSLTProcessorImpl::transformDocument): (DOM::bufferWrite): (DOM::XSLTProcessorImpl::addToResult): (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):
  • khtml/xsl/xslt_processorimpl.h: Added.
4:06 PM Changeset in webkit [7265] by mjs
  • 2 edits in trunk/WebCore

Fix build.

  • khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending):
3:26 PM Changeset in webkit [7264] by rjw
  • 4 edits in trunk/WebCore

Fixed <rdar://problem/3704339> Context2D forces integer positions in drawImage

Use floats instead of ints to draw images.

Reviewed by Ken.

  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawPixmap): (QPainter::drawFloatPixmap):
3:21 PM Changeset in webkit [7263] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • fixed <rdar://problem/3752509> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)

(actually the previous fix for this bug was mostly correct, but
this additional change is needed to avoid the regression in
<rdar://problem/3751025> REGRESSION: website rejects Safari 125.9
as "need to upgrade to IE 6", but didn't reject 125.8

So if merging for a software update, make sure to include both
this and the previous fix.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): When there is an immediate reidrect pending, make sure to stop tokenizing, because we need to make sure no further script tags are processed beyond the one that triggered the redirect.
  • khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending): New method to allow checking if a redirect is pending.
  • khtml/khtml_part.h:
2:17 PM Changeset in webkit [7262] by rjw
  • 4 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3581092> cash in KJS::Bindings::JSObject::eval at tcvetantcvetkov.com

Adds bullet proofing to protect against evaluation of bogus JS in all the flavors of bindings (Java, C, and ObjC).

Reviewed by Chris.

  • bindings/NP_jsobject.cpp: (NPN_Evaluate):
  • bindings/jni/jni_jsobject.cpp: (JSObject::eval):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject evaluateWebScript:]):
1:56 PM Changeset in webkit [7261] by hyatt
  • 3 edits in trunk/WebCore

Fix the blank textarea problem by ensuring that any change to a <textarea>'s DOM children causes the form control
to resync with the DOM. This behavior matches WinIE.

Reviewed by kocienda

  • khtml/html/html_formimpl.cpp: (HTMLTextAreaElementImpl::childrenChanged):
  • khtml/html/html_formimpl.h:

Aug 15, 2004:

8:41 PM Changeset in webkit [7260] by rjw
  • 9 edits in trunk

WebKit:

More changes to np headers.

Reviewed by Darin.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
  • Plugins.subproj/npapi.h:
  • Plugins.subproj/npfunctions.h:
  • Plugins.subproj/npruntime.h:

JavaScriptCore:

More updates to np headers. Implemented new NPN functions.

Reviewed by Darin.

  • bindings/NP_jsobject.cpp: (NPN_HasProperty): (NPN_HasMethod):
  • bindings/npapi.h:
  • bindings/npruntime.h:

Aug 13, 2004:

3:04 PM Changeset in webkit [7259] by mjs
  • 2 edits in trunk/WebKit

Back out accidental bad change.

2:58 PM Changeset in webkit [7258] by mjs
  • 2 edits in trunk/WebKit

top level:

Reviewed by Ken.

  • Makefile.am: Remove WebKitExamples for now, until it actually works to include it in a recursive make.

WebKit:

Reviewed by NOBODY (OOPS!).

  • Plugins.subproj/npapi.h:
2:26 PM Changeset in webkit [7257] by trey
  • 5 edits in trunk/WebCore

3761794 Slider doesn't call onmouseup handler

Reviewed by Hyatt

  • khtml/rendering/render_form.cpp: (RenderSlider::RenderSlider): Listen for signal. (RenderSlider::slotClicked): Pass to superclass.
  • khtml/rendering/render_form.h:
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): Generate mouseUp and clicked events, since AK consumes the mouseUp event in a modal tracking loop. (QSlider::QSlider): Make signal. (QSlider::clicked): Send signal.
10:45 AM Changeset in webkit [7256] by darin
  • 4 edits in trunk/WebKit

Reviewed by Chris.

  • fixed <rdar://problem/3760924> Carbon path passed in NPP_StreamAsFile must be in local character set, not UTF-8
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (CarbonPathFromPOSIXPath): Added. New function that uses the path pieces from an FSSpec. This has many advantages; the big one that fixes the bug is that it gives the mangled names that work even for files that have names that can't otherwise be encoded in Carbon-style path names. I didn't write this from scratch: I started with the method in Foundation and just changed it to use FSSpec. (-[WebBaseNetscapePluginStream destroyStream]): Remove code that used NSString and just call CarbonPathFromPOSIXPath instead.
  • Plugins.subproj/npapi.h: The Revision tag wanted to touch this file. I think we are going to have some trouble with this; I'd like to take that out.
  • English.lproj/StringsNotToBeLocalized.txt: Updated.
10:13 AM Changeset in webkit [7255] by trey
  • 5 edits in trunk

WebCore:

3761329 - query result links all dead in ingrammicro.com (sometimes)
3761328 - links in some docs dead when doc is loaded from WebArchive

Make sure to get part to completed state when end is called,
even if we have no doc. See WebKit changelog for more info.

Reviewed by Richard and Darin.

  • khtml/khtml_part.cpp: (KHTMLPart::end):

WebKit:

3761329 - query result links all dead in ingrammicro.com (sometimes)
3761328 - links in some docs dead when doc is loaded from WebArchive

Nasty problem. It turns out that these result pages are a parent frame with two child
frames. One of the child frames is a 1 or 2 byte text document. When the text child
is the last doc to complete, because we use a Text rep instead of an HTMLRep, it turns
out we never send [bridge end] from WebKit. That mistake results in checkCompleted not
being called enough in the part, and we never realize the load is done. WebCore does
not allow redirects to happen until the entire load is complete, and the links on this
results page are actually little pieces of JS that set location to a generated URL. Since
redirects are not allowed these links all silently fail to do anything, and the doc never
achieves a completed state where they will work.

Solution is to make sure we always call [bridge end] from the DataSource instead of only
the HTML rep doing it.

Reviewed by Richard and Darin.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _finishedLoading]): Call [bridge end] here for all kinds of docs.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Don't call is just for HTMLReps.
9:57 AM Changeset in webkit [7254] by trey
  • 2 edits in trunk/WebCore

3761098 - red dotted underline for misspelled words shows up in drag image

Reviewed by Ken

  • khtml/rendering/render_text.cpp: (RenderText::paint): Don't draw misspelling when creating selection image.
9:50 AM Changeset in webkit [7253] by darin
  • 1 edit
    1 add in trunk/JavaScriptCore
  • fix build so we can compile again
  • bindings/npapi.h: Added. Richard forgot to check this in. The one I'm checking in here is good enough so that we can compile, but it's only a stopgap measure, because I think Richard has a newer one he wants to check in.
Note: See TracTimeline for information about the timeline view.