Timeline

Aug 20, 2004:

5:58 PM Changeset in webkit [7320] by hyatt

• 4 edits in trunk/WebCore

Divorce the notion of a marquee being stopped from JS from the notion of being suspended by the back/forward cache.

• khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall):
• khtml/rendering/render_layer.cpp: (m_direction): (Marquee::start): (Marquee::stop): (Marquee::updateMarqueePosition):
• khtml/rendering/render_layer.h: (khtml::):

4:37 PM Changeset in webkit [7319] by hyatt

• 22 edits in trunk/LayoutTests

Fix layout tests.

4:12 PM Changeset in webkit [7318] by hyatt

• 2 edits in trunk/WebKit

Fix the directionality of the unicode hyphen so that on Panther it now matches Tiger.

Reviewed by darin

• Misc.subproj/WebUnicode.m: (_unicodeDirection):

4:09 PM Changeset in webkit [7317] by rjw

• 1 add in trunk/JavaScriptCore/bindings/jni/jni_objc.mm

Added.

2:57 PM Changeset in webkit [7316] by rjw

• 18 edits in trunk

WebKit:

Implemented new JNI abstraction. We no longer invoke Java methods
directly with JNI, rather we call into the plugin. This allows the
plugin to dispatch the call to the appropriate VM thread. This
change should (will?) fix a whole class of threading related problems with
the Java VM.

Reviewed by Hyatt.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getAppletInView:]):

WebCore:

Implemented new JNI abstraction. We no longer invoke Java methods
directly with JNI, rather we call into the plugin. This allows the
plugin to dispatch the call to the appropriate VM thread. This
change should (will?) fix a whole class of threading related problems with
the Java VM.

Reviewed by Hyatt.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView):
• kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge executionContextForView:]):

JavaScriptCore:

Implemented new JNI abstraction. We no longer invoke Java methods
directly with JNI, rather we call into the plugin. This allows the
plugin to dispatch the call to the appropriate VM thread. This
change should (will?) fix a whole class of threading related problems with
the Java VM.

Reviewed by Hyatt.

• JavaScriptCore.pbproj/project.pbxproj:
• bindings/c/c_instance.h: (KJS::Bindings::CInstance::setExecutionContext): (KJS::Bindings::CInstance::executionContext):
• bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::invokeMethod): (JavaInstance::setExecutionContext): (JavaInstance::executionContext):
• bindings/jni/jni_instance.h:
• bindings/jni/jni_jsobject.cpp: (JSObject::convertJObjectToValue):
• bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaArray::JavaArray): (JavaArray::valueAt):
• bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=): (KJS::Bindings::JavaArray::executionContext):
• bindings/jni/jni_utility.h:
• bindings/objc/objc_instance.h: (KJS::Bindings::ObjcInstance::setExecutionContext): (KJS::Bindings::ObjcInstance::executionContext):
• bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
• bindings/runtime.h:
• bindings/runtime_root.h: (KJS::Bindings::RootObject::nativeHandle):

2:15 PM Changeset in webkit [7315] by mjs

• 2 edits in trunk/WebCore

Reviewed by Darin.

More text paint cleanup. Separated the background and foreground
passes instead of doing a weird for loop thing. Eliminated
redundant if conditions. Added comments.

• khtml/rendering/render_text.cpp: (RenderText::paint):

1:19 PM Changeset in webkit [7314] by kocienda

• 14 edits in trunk

Reviewed by Darin

• khtml/css/css_computedstyle.cpp: (DOM::): Changed CopyProperties constant to InheritableProperties. This reflects the name change of copy() to copyInheritableProperties() (DOM::CSSComputedStyleDeclarationImpl::copyInheritableProperties: Renamed from copy(). Now just copies those properties which can be inherited. (DOM::CSSComputedStyleDeclarationImpl::diff): Add a couple null checks.
• khtml/css/css_computedstyle.h: copyInheritableProperties name change. No longer needs to be virtual.
• khtml/css/css_valueimpl.cpp: Removed unneeded copy() function from CSSStyleDeclarationImpl.
• khtml/css/css_valueimpl.h: Ditto.
• khtml/editing/htmlediting.cpp: (khtml::EditCommand::typingStyle): Added. (khtml::EditCommand::setTypingStyle): Added.
• khtml/editing/htmlediting.h:
• khtml/editing/htmlediting_impl.cpp: (khtml::StyleChange::currentlyHasStyle): Fix leak of computed style used in this function. (khtml::EditCommandImpl::EditCommandImpl): Initialize m_typingStyle. (khtml::EditCommandImpl::~EditCommandImpl): Deref m_typingStyle. (khtml::EditCommandImpl::assignTypingStyle): New helper used in setting typing style. (khtml::EditCommandImpl::setTypingStyle): New setter. (khtml::DeleteSelectionCommandImpl::doApply): Use new method for managing typing style.
• khtml/editing/htmlediting_impl.h: (khtml::EditCommandImpl::typingStyle): New accessor.
• khtml/khtml_part.cpp: (KHTMLPart::appliedEditing): Restores typing style from command after setting selection. (KHTMLPart::applyStyle): Does a diff between the current style and the style of the caret.
• khtml/khtml_part.h:
• khtml/xml/dom_position.cpp: (DOM::Position::computedStyle): Now returns a CSSComputedStyleDeclarationImpl instead of a plain CSSStyleDeclarationImpl.
• khtml/xml/dom_position.h:
• layout-tests/editing/style/style-3681552-fix-002-expected.txt:

11:44 AM Changeset in webkit [7313] by trey

• 2 edits in trunk

Get rid of weird chars in bug titles from last checkin (maybe nb spaces?)

11:33 AM Changeset in webkit [7312] by vicki

• 1 edit in branches/Safari-1-0-branch/WebKit/ChangeLog

remove spurious ^{M characters from this ChangeLog, so that it is readable}

11:29 AM Changeset in webkit [7311] by trey

• 6 edits in trunk

WebCore:

3655407 - Editing:�complete:�ethod�nimplemented�WebKit�diting�PI)

One new support routine here.

Reviewed by John

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge caretRectAtNode:offset:]): New routine. (-[WebCoreBridge rangeByExpandingSelectionWithGranularity:]): Fixed former misleading method name.

WebKit:

3655407 - Editing:�complete:�ethod�nimplemented�WebKit�diting�PI)

This feature is mostly implemented. The only loose ends I know of are:

3769654 - text insertions done via complete: should preserve case of full replacement string
3769652 - positioning of complete: popup window wrong for right-to-left languages

Reviewed by John

• WebView.subproj/WebHTMLView.m: (-[WebHTMLViewPrivate dealloc]): Free new object. (-[WebHTMLView menuForEvent:]): Bail on completion session. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView windowWillClose:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. (-[WebHTMLView resignFirstResponder]): Ditto. (-[WebHTMLView keyDown:]): Bail on completion session if WebCore takes the event. Give the CompleteController a crack at the key event. (-[WebHTMLView _expandSelectionToGranularity:]): Adopt method rename (-[WebHTMLView complete:]): Make CompleteController, tell it to do its thing. (-[WebHTMLView checkSpelling:]): Add ERROR(). (-[WebHTMLView showGuessPanel:]): Add ERROR(). (-[WebHTMLView _changeSpellingToWord:]): Add ERROR(). (-[WebHTMLView ignoreSpelling:]): Add ERROR().

(-[WebTextCompleteController initWithHTMLView:]):
(-[WebTextCompleteController dealloc]):
(-[WebTextCompleteController _insertMatch:]): Stick the new string into the doc.
(-[WebTextCompleteController _buildUI]): Make popup window.
(-[WebTextCompleteController _placePopupWindow:]): Position popup window.
(-[WebTextCompleteController doCompletion]): Lookup matches, display window.
(-[WebTextCompleteController endRevertingChange:moveLeft:]): Bail on complete: session.
(-[WebTextCompleteController filterKeyDown:]): Process keys while popup is up.
(-[WebTextCompleteController _reflectSelection]): Handle choice in popup.
(-[WebTextCompleteController tableAction:]): Handle double click in popup
(-[WebTextCompleteController numberOfRowsInTableView:]): Fill table with matches.
(-[WebTextCompleteController tableView:objectValueForTableColumn:row:]): Ditto.
(-[WebTextCompleteController tableViewSelectionDidChange:]): Handle selection change.

• WebView.subproj/WebHTMLViewInternal.h:

9:57 AM Changeset in webkit [7310] by kocienda

• 2 adds in trunk/LayoutTests/editing/inserting

I neglected to add these files on my previous checkin

9:55 AM Changeset in webkit [7309] by kocienda

• 3 edits in trunk

Reviewed by Trey

Fix for this bug:

<rdar://problem/3768378> crash typing newline in Blot

• khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): Adding an assert in a recent change showed up that inserting newlines that was not being handled correctly for the case described in the bug. I added a new case to handle inserting BR's when at the caret max offset for a node, and this new code runs instead of the fall-through case that should not have been running and triggered the assert.
• layout-tests/editing/inserting/insert-br-case2-expected.txt: Regenerated results.
• layout-tests/editing/inserting/insert-br-case6-expected.txt: Added.
• layout-tests/editing/inserting/insert-br-case6.html: Added.

9:53 AM Changeset in webkit [7308] by trey

• 2 edits in trunk/WebCore

Fixing: Spellchecker called once or twice for every char typed.

Reviewed by Ken

• khtml/khtml_part.cpp: (KHTMLPart::setSelection): Don't do any spell checking if we're typing (it's done elsewhere, in markMisspellingsAfterTyping)

9:06 AM Changeset in webkit [7307] by sullivan

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: checked this in; the only difference is that the strings were out of order.

Aug 19, 2004:

8:26 PM Changeset in webkit [7306] by mjs

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3549369> Crash at www.e1.ru in HTMLTokenizer::notifyFinished

Probably also fixed the following likely duplicates:

<rdar://problem/3503938> Safari crashed opening many tabs (HTMLTokenizer::notifyFinished(khtml::CachedObject*))
<rdar://problem/3566332> CrashTracer: ..405 crashes at com.apple.WebCore: QString::QString[unified] + 0x5c
<rdar://problem/3703964> CrashTracer: ...86 crashes at com.apple.WebCore: QString::QString[unified] + 0x5c
<rdar://problem/3703969> CrashTracer: ..234 crashes at com.apple.WebCore: HTMLTokenizer::notifyFinished + 0x1c8

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::open): call setParsing(true), because we need to know we are once again parsing when we re-open a document that has previously completed loading.

7:21 PM Changeset in webkit [7305] by mjs

• 2 edits in trunk/WebCore

Reviewed by Dave and Darin.

• khtml/rendering/render_text.cpp: (RenderText::paint): Split apple and non-apple code paths to allow further cleanup.

5:38 PM Changeset in webkit [7304] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3767274> crash in partForWidget inside setFocus (test page attached)

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Remove code to do position the widget; no longer needed since we reworked how widgets get their positions.
• kwq/KWQWidget.mm: (QWidget::setFocus): Ditto. This was the one that caused the bug.

5:11 PM Changeset in webkit [7303] by rjw

• 2 edits in trunk/WebKit

Continue to call old pollForAppletInView: in Tiger until
we get an plugin that supports the new API.

Reviewed by Chris.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getAppletInView:]):
• WebKit.pbproj/project.pbxproj:

4:23 PM Changeset in webkit [7302] by hyatt

• 2 edits in trunk/WebCore

Fix crash when text is contained inside a table-colgroup.

Reviewed by john

• khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):

4:17 PM Changeset in webkit [7301] by trey

• 2 edits in trunk/WebCore

Unexpected errors hit while finding word boundaries, leading to crash.

Reviewed by Ken.

• kwq/KWQTextUtilities.cpp: (KWQFindWordBoundary): Don't call UCFindTextBreak with edge cases it thinks are param errors, and pass correct mask for forward case. Also fix off-by-one crashers in fallback code.

3:50 PM Changeset in webkit [7300] by hyatt

• 10 edits in trunk/WebCore

Make XSLT imports/includes work. This code has to be turned off until the newer version of libxslt is
available.

Reviewed by kocienda

• khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::init):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::applyXSLTransform):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::setTransformSource): (DOM::DocumentImpl::transformSource):
• khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet):
• khtml/xml/xml_tokenizer.cpp: (khtml::matchFunc): (khtml::openFunc): (khtml::readFunc): (khtml::writeFunc): (khtml::createQStringParser): (khtml::XMLTokenizer::setTransformSource):
• khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::XSLStyleSheetImpl): (DOM::XSLStyleSheetImpl::~XSLStyleSheetImpl): (DOM::XSLStyleSheetImpl::isLoading): (DOM::XSLStyleSheetImpl::clearDocuments): (DOM::XSLStyleSheetImpl::parseString): (DOM::XSLStyleSheetImpl::loadChildSheets): (DOM::XSLStyleSheetImpl::loadChildSheet): (DOM::XSLImportRuleImpl::parentStyleSheet): (DOM::XSLStyleSheetImpl::compileStyleSheet): (DOM::XSLStyleSheetImpl::locateStylesheetSubResource): (DOM::XSLImportRuleImpl::XSLImportRuleImpl): (DOM::XSLImportRuleImpl::~XSLImportRuleImpl): (DOM::XSLImportRuleImpl::setStyleSheet): (DOM::XSLImportRuleImpl::isLoading): (DOM::XSLImportRuleImpl::loadSheet):
• khtml/xsl/xsl_stylesheetimpl.h: (DOM::XSLStyleSheetImpl::setOwnerDocument): (DOM::XSLStyleSheetImpl::setDocument): (DOM::XSLStyleSheetImpl::markAsProcessed): (DOM::XSLStyleSheetImpl::processed): (DOM::XSLImportRuleImpl::href): (DOM::XSLImportRuleImpl::styleSheet): (DOM::XSLImportRuleImpl::isImportRule):
• khtml/xsl/xslt_processorimpl.cpp: (DOM::m_sourceDocument): (DOM::stylesheetLoadFunc): (DOM::XSLTProcessorImpl::transformDocument):
• khtml/xsl/xslt_processorimpl.h:

2:00 PM Changeset in webkit [7299] by vicki

• 3 edits in trunk

set version to Safari 2.0, (v159u) for tip of tree.

1:54 PM Changeset in webkit [7298]

• 3 copies in tags/Safari-159

This commit was manufactured by cvs2svn to create tag 'Safari-159'.

1:54 PM Changeset in webkit [7297]

• 3 copies in tags/Safari-158

This commit was manufactured by cvs2svn to create tag 'Safari-158'.

1:54 PM Changeset in webkit [7296]

• 3 copies in branches/ParisExpo-2004-branch

This commit was manufactured by cvs2svn to create branch
'ParisExpo-2004-branch'.

1:54 PM Changeset in webkit [7295]

• 3 copies in tags/ParisExpo-2004-anchor

This commit was manufactured by cvs2svn to create tag
'ParisExpo-2004-anchor'.

1:54 PM Changeset in webkit [7294] by vicki

• 6 edits in trunk

Safari-158 stamp

10:34 AM Changeset in webkit [7293] by cblu

• 2 edits in trunk/WebKit

Fixed typo in comment.

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _updateFileDatabase]):

10:33 AM Changeset in webkit [7292] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3566336> CrashTracer: .2403 crashes at com.apple.WebKit: -[WebFileDatabase performSetObject:forKey:] + 0x94

Reviewed by trey.

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _updateFileDatabase]): pass WebFileDatabase copies of the mutable dictionaries or else they may be accessed on a separate thread as the main thread is modifying them

9:21 AM Changeset in webkit [7291] by vicki

• 2 edits in trunk/JavaScriptCore

• initialize deletedElementIndex to make the compiler happy

Aug 18, 2004:

5:30 PM Changeset in webkit [7290] by trey

• 2 edits in trunk/WebCore

3765958 - downstreamPosition() can hit infinite loop when at end of doc

The problem was that I had a position that was after the maximum position in the text
node, because it was the old caret position before a backspace was processed. Later
I happened to call downstream() on that position, and hit the bug. Fix is to consider
a position past the end point of its node if it is *greater than* or equal to its max offset.

Reviewed by Ken.

• khtml/xml/dom_positioniterator.cpp: (DOM::PositionIterator::atEnd):

5:15 PM Changeset in webkit [7289] by hyatt

• 2 edits in trunk/WebCore

Make the header overlap the footer in the zero-line case. Changes to Emerson's template will ensure the
header draws over the footer.

Reviewed by darin

• khtml/rendering/render_block.cpp: (khtml::getHeightForLineCount):

4:34 PM Changeset in webkit [7288] by rjw

• 5 edits in trunk

WebKit:

Replace horrible pollForAppletInView: with new
webPlugInGetApplet. The details of how the applet instance
is provided now belong to the Java team. Yeh.

Reviewed by Chris.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getAppletInView:]):

WebCore:

Replace horrible pollForAppletInView: with new
webPlugInGetApplet. The details of how the applet instance
is provided now belong to the Java team. Yeh.

Reviewed by Chris.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView):
• kwq/WebCoreBridge.h:

11:19 AM Changeset in webkit [7287] by cblu

• 6 edits in trunk/WebCore

Fixed: <rdar://problem/3692199> 8A146: Safari crashes in toHTMLWithOptions, selection with no renderer (various sites)

Reviewed by trey.

• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): renamed, don't assume that nodes of the range had renderers, use the common ancestor of the range as the root
• khtml/xml/dom2_rangeimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toHTML): renamed, removed code that determines whether to include the root in the HTML, leave this up to the caller
• khtml/xml/dom_nodeimpl.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]): call renamed methods (-[WebCoreBridge markupStringFromRange:nodes:]): ditto

10:43 AM Changeset in webkit [7286] by kocienda

• 2 edits in trunk/WebCore

Reviewed by me

• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::copy): Roll back silly last minute change that broke this code. Note to self: read code before making changes to it.

10:34 AM Changeset in webkit [7285] by kocienda

• 5 edits in trunk/WebCore

Coded by Darin and Ken

• khtml/css/css_computedstyle.cpp: Added CopyProperties static array. This contains the properties we implement that we also want to copy in the new CSSComputedStyleDeclarationImpl::copy described below. (DOM::CSSComputedStyleDeclarationImpl::copy): New function. In this class, copies the computed values of all the properties listed in CopyProperties. In essence, this makes a freeze-dired version of a computed style. (DOM::CSSComputedStyleDeclarationImpl::diff): Removes every property from the passed-in CSSStyleDeclarationImpl that is also in the computed style.
• khtml/css/css_computedstyle.h:
• khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::copy): New function. In this class, the copy operation is straightforward. Returns a copy that will be unchanged when the original changes.
• khtml/css/css_valueimpl.h: (DOM::CSSStyleDeclarationImpl::values): Added a accessor suitable for use when the CSSStyleDeclarationImpl is const.