Timeline
Aug 24, 2004:
- 5:57 PM Changeset in webkit [7355]
-
- 52 copies2 deletes in tags/WebCore-125~6~9
This commit was manufactured by cvs2svn to create tag
'WebCore-125~6~9'.
- 5:57 PM Changeset in webkit [7354] by
-
- 2 edits in branches/SecurityUpdate-10~3~4-branch/WebCore
Added release marker and bumped version.
- 5:56 PM Changeset in webkit [7353] by
-
- 3 edits in branches/SecurityUpdate-10~3~4-branch/WebCore
Rolled change in for 10.3.4 version of Security Update.
2004-07-09 Chris Blumenberg <cblu@apple.com>
Allowed my change for 3715785 to compile on Jaguar.
Reviewed by kocienda.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge domain]): new, allows access to the domain without using the DOM API which doesn't exist on Jaguar
- 5:48 PM Changeset in webkit [7352]
-
- 12 copies3 deletes in tags/WebKit-125~2~1
This commit was manufactured by cvs2svn to create tag
'WebKit-125~2~1'.
- 5:48 PM Changeset in webkit [7351] by
-
- 2 edits in branches/SecurityUpdate-10~3~4-branch/WebKit
Bump version number, add ChangeLog version marker.
- 5:45 PM Changeset in webkit [7350] by
-
- 2 edits in branches/SecurityUpdate-10~3~4-branch/WebKit
Rolled in security fix for 10.3.4 version of Security Update.
2004-07-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Chris.
<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame
- Plugins.subproj/npruntime.h:
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames that are in the same window (Mozilla does this too).
2004-07-09 Chris Blumenberg <cblu@apple.com>
Allowed my change for 3715785 to compile on Jaguar.
Reviewed by kocienda.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge
2004-07-06 Chris Blumenberg <cblu@apple.com>
Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers
Reviewed by john, trey, kocienda.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
- 5:33 PM Changeset in webkit [7349] by
-
- 3 edits in trunk
set the TOT version number to '161u', since we burned 160 on ParisExpo-2004-branch
- 5:31 PM Changeset in webkit [7348]
-
- 15 copies in tags/Safari-160
This commit was manufactured by cvs2svn to create tag 'Safari-160'.
- 5:31 PM Changeset in webkit [7347] by
-
- 6 edits in branches/ParisExpo-2004-branch
Safari-160 stamp (for the Expo build).
- 5:24 PM Changeset in webkit [7346] by
-
- 2 edits in branches/ParisExpo-2004-branch/WebCore
- merge this fix from HEAD for the Expo build
2004-08-20 Ken Kocienda <kocienda@apple.com>
Reviewed by Trey
Fix for this bug:
<rdar://problem/3768378> crash typing newline in Blot
- khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): Adding an assert in a recent change showed up that inserting newlines that was not being handled correctly for the case described in the bug. I added a new case to handle inserting BR's when at the caret max offset for a node, and this new code runs instead of the fall-through case that should not have been running and triggered the assert.
- 5:09 PM Changeset in webkit [7345] by
-
- 6 edits in branches/ParisExpo-2004-branch/WebCore
- merge this fix from HEAD for the Expo build
2004-08-23 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
<rdar://problem/3770306> XMLHttpRequest does not honor character set encoding
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::slotData): Get encoding from the transfer job.
- kwq/KWQKJobClasses.h:
- kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Added retrievedCharset flag. (KIO::TransferJob::retrieveCharset): New method, gets the charset from the response. (KIO::TransferJob::queryMetaData): Handle charset. (KIO::TransferJob::emitReceivedResponse): Clear retreivedCharset flag.
- kwq/KWQLoader.h:
- kwq/KWQLoader.mm: (KWQResponseTextEncodingName): New function, gets the encoding from the response.
- 4:37 PM Changeset in webkit [7344] by
-
- 2 edits in trunk/WebKit
Fixed with help from Trey:
<rdar://problem/3764856> REGRESSION !25-154): Safari accepts mouse clicks (follows links) when not key
Reviewed by rjw.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionEvent:]): brought back from CVS (-[WebHTMLView acceptsFirstMouse:]): only call eventMayStartDrag if _isSelectionEvent returns YES since we only want to allow selection dragging on the first mouse down (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto
- 4:23 PM Changeset in webkit [7343] by
-
- 8 edits in trunk
WebCore:
Reviewed by Hyatt
Improved the ability of the bridge to report selection state.
- khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::doApply): Bail when there is no selection.
- kwq/WebCoreBridge.h: Added an enum to report selection state. These constants mirror those used in DOM::Selection.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionState]): Replacement for haveSelection. Returns a value from an enum telling whether the selection is in the None, Caret, or Range state, rather than just true/false for the Range state as it did before.
WebKit:
Reviewed by Hyatt
Improved the checks used to see if certain operations can be done based
on the state of the selection and whether the selection is editable. I
added some helpers and improved some others to assist in making these
determinations.
This helps to fix this bug:
<rdar://problem/3764987> Crash after adding newline to quoted text
Since some editing methods expect the the selection to be in a certain state
in order to work, these checks help obviate crashes like 3764987.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): _haveSelection name changed to _hasSelection. (-[WebHTMLView _canCopy]): Checks to see if state is appropriate to perform this operation. (-[WebHTMLView _canCut]): Ditto. Function added. (-[WebHTMLView _canDelete]): Ditto. Function refined. (-[WebHTMLView _canPaste]): Ditto. Function refined. (-[WebHTMLView _canType]): Ditto. Function added. (-[WebHTMLView _hasSelection]): Name changed from _haveSelection. (-[WebHTMLView _hasSelectionOrInsertionPoint]): Added. (-[WebHTMLView _isEditable]): Added. (-[WebHTMLView takeFindStringFromSelection:]): _haveSelection name changed to _hasSelection. (-[WebHTMLView validateUserInterfaceItem:]): Ditto (-[WebHTMLView validRequestorForSendType:returnType:]): Ditto (-[WebHTMLView keyDown:]): (-[WebHTMLView copy:]): Uses new _canCopy check. (-[WebHTMLView cut:]): Uses new _canCut check. (-[WebHTMLView delete:]): Now uses _canDelete check. (-[WebHTMLView paste:]): Now uses _canPaste check. (-[WebHTMLView _updateFontPanel]): _haveSelection name changed to _hasSelection.
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebView.m: (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): Use selectionState check to determine whether or not operation can be done.
- 2:17 PM Changeset in webkit [7342] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3770469> Some PDFs open with line of previous page above PDF view
Set height resize flags on WebPDFView.
Reviewed by Chris.
- WebView.subproj/WebPDFView.m: (-[WebPDFView initWithFrame:]):
- 1:39 PM Changeset in webkit [7341] by
-
- 2 edits in trunk/WebCore
Make sure the ifdef XSLT is present for Panther.
- khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::insertErrorMessageBlock):
- 1:38 PM Changeset in webkit [7340] by
-
- 4 edits in trunk/WebCore
Polish the XML error message so that it indicates when a document is the result of an XSL transformation
when reporting line/col #s.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform):
- khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::insertErrorMessageBlock):
- khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):
- 1:23 PM Changeset in webkit [7339] by
-
- 5 edits in trunk/WebCore
Add support for Atom and RSS MIME types to the set of XML types.
Reviewed by rjw
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty):
- khtml/khtml_part.cpp: (KHTMLPart::begin):
- khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXBLDocument::CachedXBLDocument):
- khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet):
- 1:22 PM Changeset in webkit [7338] by
-
- 3 edits in trunk/WebKit
Add Atom and RSS MIME types to set of supported XML types.
Reviewed by rjw
- WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
- WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
- 11:37 AM Changeset in webkit [7337] by
-
- 2 edits in trunk/LayoutTests/fast/overflow
Change the file so that it isn't even close to RSS any more, since our sniffing code is broken.
- 11:02 AM Changeset in webkit [7336] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3746447> hang loading geocities.com/cinemaorchestra
Reviewed by john.
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): do nothing if the src URL is the same as the part's URL
- 10:00 AM Changeset in webkit [7335] by
-
- 2 edits in trunk/WebCore
Reviewed by Chris
Fix for this bug:
<rdar://problem/3773564> REGRESSION (125-159): Code to remove HTML styles before applying new HTML styles is broken
- khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): Unrelated change to constrain downstream position of selection start to block boundaries. This is a new feature of the downstream function and I missed this usage when adding the feature. (khtml::ApplyStyleCommandImpl::removeCSSStyle): There once was code to remove style attributes from spans which became emptied as a result of removing CSS properties, but I do not see such code in the tree any more. A quick review of the ChangeLog did not reveal anything. I do not remember making such a change myself...
In any case, I have restored logic to prune out styling spans we insert if the process of
removing styles caused a span-plus-styles node to become emptied of markup which changes the style
of its contents. This fixes the bug.
- 8:23 AM Changeset in webkit [7334] by
-
- 5 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3765535> paste of text with newlines into text with newlines results in broken doc, crash
This is a "belt and suspenders" fix. The issue is with the paste code path which was creating
zero-length DOM text nodes when a selection being pasted ended with a newline. The normal
code path for parsing HTML does not allow this, but the code to convert newlines to BR's
during paste was creating such nodes. This will no longer happen.
In the case where someone inserts such zero-length nodes using the DOM API, the render tree
will no longer create render objects for these nodes, and it was these empty render text
nodes that was confusing the code doing editing navigation.
- khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::rendererIsNeeded): Do not create renderers for zero-length DOM text nodes.
- khtml/xml/dom_textimpl.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithText:]): Do not insert zero-length DOM text nodes as part of converting line-end sequences to BR's.
Aug 23, 2004:
- 9:13 PM Changeset in webkit [7333] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard.
- reduce cost of innerHTML from O(N2) to O(N*D) where N is the number of nodes and D is the maximum DOM tree depth.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toString): New static helper method for recursive_toHTML - this is recursive for children but iterative for siblings. (NodeImpl::recursive_toHTML): Call the helper with this as the first argument.
- khtml/xml/dom_nodeimpl.h:
- 8:22 PM Changeset in webkit [7332] by
-
- 7 edits in trunk/WebCore
Fix for 3558334.
Init the encodedURL explicitly for CSSStyleSelectors. Construction time was too early to be passing in the
document m_url, since it doesn't get set during construction.
Fix for 3769643, crash on vancouverblast.org.
Reviewed by darin
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::init): (khtml::CSSStyleSelector::setEncodedURL):
- khtml/css/cssstyleselector.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::setURL): (DocumentImpl::recalcStyleSelector):
- khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::URL):
- 7:50 PM Changeset in webkit [7331] by
-
- 2 edits in trunk/WebKit
Reviewed by Kevin.
- remove annoying ERROR spew and replace with comment
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView validAttributesForMarkedText]):
- 6:19 PM Changeset in webkit [7330] by
-
- 2 edits in trunk/WebKit
Reviewed by Richard.
- a bit of code cleanup
- WebView.subproj/WebDataSource.m: (-[WebDataSource _stringWithData:]): Call textEncodingName instead of copying it's code. (-[WebDataSource textEncodingName]): Tweak formatting.
- 5:12 PM Changeset in webkit [7329] by
-
- 2 edits in trunk/WebKit
Fixed build.
- WebKit.pbproj/project.pbxproj: make sure we're doing -f on a file, not a directory
- 4:36 PM Changeset in webkit [7328] by
-
- 6 edits2 adds in trunk/WebKit
Fixed: <rdar://problem/3674867> use new Security framework SPI's to reenable cert acquisition
Reviewed by john.
- WebCoreSupport.subproj/WebKeyGeneration.cpp:
- WebCoreSupport.subproj/WebKeyGeneration.h:
- WebCoreSupport.subproj/WebKeyGenerator.h:
- WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): re-enabled cert code, call Panther version on Panther, Tiger version on Tiger (-[WebKeyGenerator addCertificatesToKeychainFromData:]): ditto
- WebCoreSupport.subproj/WebNewKeyGeneration.c: Added. (gnrAddContextAttribute): (gnrGetSubjPubKey): (gnrNullAlgParams): (gnrSign): (gnrFreeCssmData): (nssArraySize): (signedPublicKeyAndChallengeString): (addCertificateToKeychainFromData): (addCertificatesToKeychainFromData):
- WebCoreSupport.subproj/WebNewKeyGeneration.h: Added.
- WebKit.pbproj/project.pbxproj:
- 4:02 PM Changeset in webkit [7327] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Get rid of stray conflict markers.
- 2:17 PM Changeset in webkit [7326] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed rdar://problem/3681094> Crash in KJS::WindowFunc::tryCall with application/xhtml+xml Content-Type
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): since this is an xml document, we get the domain from the xmlDocImpl(), not docImpl().
- 12:05 PM Changeset in webkit [7325] by
-
- 3 edits in trunk
bump all version numbers to 160u, since I just submitted WebBrowser-159
- 11:06 AM Changeset in webkit [7324] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/3771426> assertion failed due to reentering dispatchImageLoadEventsNow
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::dispatchImageLoadEventsNow): Avoid re-entering this function, since it uses a data member for the copy of the list of events to be dispatched.
- 10:52 AM Changeset in webkit [7323] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/3770306> XMLHttpRequest does not honor character set encoding
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::slotData): Get encoding from the transfer job.
- kwq/KWQKJobClasses.h:
- kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Added retrievedCharset flag. (KIO::TransferJob::retrieveCharset): New method, gets the charset from the response. (KIO::TransferJob::queryMetaData): Handle charset. (KIO::TransferJob::emitReceivedResponse): Clear retreivedCharset flag.
- kwq/KWQLoader.h:
- kwq/KWQLoader.mm: (KWQResponseTextEncodingName): New function, gets the encoding from the response.
- 10:44 AM Changeset in webkit [7322] by
-
- 2 edits in trunk/WebCore
Apply leo's fix to marquees.
Reviewed by hyatt
- khtml/rendering/render_layer.cpp: (Marquee::start):
- 9:12 AM Changeset in webkit [7321] by
-
- 5 edits in trunk/WebCore
Reviewed by Maciej.
- added an ascii() member function to DOMString and DOMStringImpl to help debugging
- khtml/dom/dom_string.h: Add ascii member function for debugging.
- khtml/dom/dom_string.cpp: (DOM::DOMString::ascii): Added. Calls through to DOMStringImpl::ascii.
- khtml/xml/dom_stringimpl.h: Add ascii member function for debugging.
- khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::ascii): Added. Makes a new buffer and puts a simple ASCII version in it. Maybe make it better about characters outside the 0x20-0x7E range some day, but for now this is way better than what we had before.
Aug 20, 2004:
- 5:58 PM Changeset in webkit [7320] by
-
- 4 edits in trunk/WebCore
Divorce the notion of a marquee being stopped from JS from the notion of being suspended by the back/forward cache.
- khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall):
- khtml/rendering/render_layer.cpp: (m_direction): (Marquee::start): (Marquee::stop): (Marquee::updateMarqueePosition):
- khtml/rendering/render_layer.h: (khtml::):
- 4:37 PM Changeset in webkit [7319] by
-
- 22 edits in trunk/LayoutTests
Fix layout tests.
- 4:12 PM Changeset in webkit [7318] by
-
- 2 edits in trunk/WebKit
Fix the directionality of the unicode hyphen so that on Panther it now matches Tiger.
Reviewed by darin
- Misc.subproj/WebUnicode.m: (_unicodeDirection):
- 4:09 PM Changeset in webkit [7317] by
-
- 1 add in trunk/JavaScriptCore/bindings/jni/jni_objc.mm
Added.
- 2:57 PM Changeset in webkit [7316] by
-
- 18 edits in trunk
WebKit:
Implemented new JNI abstraction. We no longer invoke Java methods
directly with JNI, rather we call into the plugin. This allows the
plugin to dispatch the call to the appropriate VM thread. This
change should (will?) fix a whole class of threading related problems with
the Java VM.
Reviewed by Hyatt.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getAppletInView:]):
WebCore:
Implemented new JNI abstraction. We no longer invoke Java methods
directly with JNI, rather we call into the plugin. This allows the
plugin to dispatch the call to the appropriate VM thread. This
change should (will?) fix a whole class of threading related problems with
the Java VM.
Reviewed by Hyatt.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView):
- kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge executionContextForView:]):
Implemented new JNI abstraction. We no longer invoke Java methods
directly with JNI, rather we call into the plugin. This allows the
plugin to dispatch the call to the appropriate VM thread. This
change should (will?) fix a whole class of threading related problems with
the Java VM.
Reviewed by Hyatt.
- JavaScriptCore.pbproj/project.pbxproj:
- bindings/c/c_instance.h: (KJS::Bindings::CInstance::setExecutionContext): (KJS::Bindings::CInstance::executionContext):
- bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::invokeMethod): (JavaInstance::setExecutionContext): (JavaInstance::executionContext):
- bindings/jni/jni_instance.h:
- bindings/jni/jni_jsobject.cpp: (JSObject::convertJObjectToValue):
- bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaArray::JavaArray): (JavaArray::valueAt):
- bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=): (KJS::Bindings::JavaArray::executionContext):
- bindings/jni/jni_utility.h:
- bindings/objc/objc_instance.h: (KJS::Bindings::ObjcInstance::setExecutionContext): (KJS::Bindings::ObjcInstance::executionContext):
- bindings/runtime.cpp: (Instance::createBindingForLanguageInstance):
- bindings/runtime.h:
- bindings/runtime_root.h: (KJS::Bindings::RootObject::nativeHandle):
- 2:15 PM Changeset in webkit [7315] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
More text paint cleanup. Separated the background and foreground
passes instead of doing a weird for loop thing. Eliminated
redundant if conditions. Added comments.
- khtml/rendering/render_text.cpp: (RenderText::paint):
- 1:19 PM Changeset in webkit [7314] by
-
- 14 edits in trunk
Reviewed by Darin
- khtml/css/css_computedstyle.cpp: (DOM::): Changed CopyProperties constant to InheritableProperties. This reflects the name change of copy() to copyInheritableProperties() (DOM::CSSComputedStyleDeclarationImpl::copyInheritableProperties: Renamed from copy(). Now just copies those properties which can be inherited. (DOM::CSSComputedStyleDeclarationImpl::diff): Add a couple null checks.
- khtml/css/css_computedstyle.h: copyInheritableProperties name change. No longer needs to be virtual.
- khtml/css/css_valueimpl.cpp: Removed unneeded copy() function from CSSStyleDeclarationImpl.
- khtml/css/css_valueimpl.h: Ditto.
- khtml/editing/htmlediting.cpp: (khtml::EditCommand::typingStyle): Added. (khtml::EditCommand::setTypingStyle): Added.
- khtml/editing/htmlediting.h:
- khtml/editing/htmlediting_impl.cpp: (khtml::StyleChange::currentlyHasStyle): Fix leak of computed style used in this function. (khtml::EditCommandImpl::EditCommandImpl): Initialize m_typingStyle. (khtml::EditCommandImpl::~EditCommandImpl): Deref m_typingStyle. (khtml::EditCommandImpl::assignTypingStyle): New helper used in setting typing style. (khtml::EditCommandImpl::setTypingStyle): New setter. (khtml::DeleteSelectionCommandImpl::doApply): Use new method for managing typing style.
- khtml/editing/htmlediting_impl.h: (khtml::EditCommandImpl::typingStyle): New accessor.
- khtml/khtml_part.cpp: (KHTMLPart::appliedEditing): Restores typing style from command after setting selection. (KHTMLPart::applyStyle): Does a diff between the current style and the style of the caret.
- khtml/khtml_part.h:
- khtml/xml/dom_position.cpp: (DOM::Position::computedStyle): Now returns a CSSComputedStyleDeclarationImpl instead of a plain CSSStyleDeclarationImpl.
- khtml/xml/dom_position.h:
- layout-tests/editing/style/style-3681552-fix-002-expected.txt:
- 11:44 AM Changeset in webkit [7313] by
-
- 2 edits in trunk
Get rid of weird chars in bug titles from last checkin (maybe nb spaces?)
- 11:33 AM Changeset in webkit [7312] by
-
- 1 edit in branches/Safari-1-0-branch/WebKit/ChangeLog
remove spurious M characters from this ChangeLog, so that it is readable
- 11:29 AM Changeset in webkit [7311] by
-
- 6 edits in trunk
WebCore:
3655407 - Editing:�complete:�ethod�nimplemented�WebKit�diting�PI)
One new support routine here.
Reviewed by John
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge caretRectAtNode:offset:]): New routine. (-[WebCoreBridge rangeByExpandingSelectionWithGranularity:]): Fixed former misleading method name.
WebKit:
3655407 - Editing:�complete:�ethod�nimplemented�WebKit�diting�PI)
This feature is mostly implemented. The only loose ends I know of are:
3769654 - text insertions done via complete: should preserve case of full replacement string
3769652 - positioning of complete: popup window wrong for right-to-left languages
Reviewed by John
- WebView.subproj/WebHTMLView.m: (-[WebHTMLViewPrivate dealloc]): Free new object. (-[WebHTMLView menuForEvent:]): Bail on completion session. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView windowWillClose:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. (-[WebHTMLView resignFirstResponder]): Ditto. (-[WebHTMLView keyDown:]): Bail on completion session if WebCore takes the event. Give the CompleteController a crack at the key event. (-[WebHTMLView _expandSelectionToGranularity:]): Adopt method rename (-[WebHTMLView complete:]): Make CompleteController, tell it to do its thing. (-[WebHTMLView checkSpelling:]): Add ERROR(). (-[WebHTMLView showGuessPanel:]): Add ERROR(). (-[WebHTMLView _changeSpellingToWord:]): Add ERROR(). (-[WebHTMLView ignoreSpelling:]): Add ERROR().
(-[WebTextCompleteController initWithHTMLView:]):
(-[WebTextCompleteController dealloc]):
(-[WebTextCompleteController _insertMatch:]): Stick the new string into the doc.
(-[WebTextCompleteController _buildUI]): Make popup window.
(-[WebTextCompleteController _placePopupWindow:]): Position popup window.
(-[WebTextCompleteController doCompletion]): Lookup matches, display window.
(-[WebTextCompleteController endRevertingChange:moveLeft:]): Bail on complete: session.
(-[WebTextCompleteController filterKeyDown:]): Process keys while popup is up.
(-[WebTextCompleteController _reflectSelection]): Handle choice in popup.
(-[WebTextCompleteController tableAction:]): Handle double click in popup
(-[WebTextCompleteController numberOfRowsInTableView:]): Fill table with matches.
(-[WebTextCompleteController tableView:objectValueForTableColumn:row:]): Ditto.
(-[WebTextCompleteController tableViewSelectionDidChange:]): Handle selection change.
- WebView.subproj/WebHTMLViewInternal.h:
- 9:57 AM Changeset in webkit [7310] by
-
- 2 adds in trunk/LayoutTests/editing/inserting
I neglected to add these files on my previous checkin
- 9:55 AM Changeset in webkit [7309] by
-
- 3 edits in trunk
Reviewed by Trey
Fix for this bug:
<rdar://problem/3768378> crash typing newline in Blot
- khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): Adding an assert in a recent change showed up that inserting newlines that was not being handled correctly for the case described in the bug. I added a new case to handle inserting BR's when at the caret max offset for a node, and this new code runs instead of the fall-through case that should not have been running and triggered the assert.
- layout-tests/editing/inserting/insert-br-case2-expected.txt: Regenerated results.
- layout-tests/editing/inserting/insert-br-case6-expected.txt: Added.
- layout-tests/editing/inserting/insert-br-case6.html: Added.
- 9:53 AM Changeset in webkit [7308] by
-
- 2 edits in trunk/WebCore
Fixing: Spellchecker called once or twice for every char typed.
Reviewed by Ken
- khtml/khtml_part.cpp: (KHTMLPart::setSelection): Don't do any spell checking if we're typing (it's done elsewhere, in markMisspellingsAfterTyping)
- 9:06 AM Changeset in webkit [7307] by
-
- 2 edits in trunk/WebKit
- English.lproj/StringsNotToBeLocalized.txt: checked this in; the only difference is that the strings were out of order.
