Timeline



Aug 30, 2004:

5:49 PM Changeset in webkit [7409] by darin
  • 10 edits
    1 delete in trunk

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3637519> REGRESSION (125-128): unrepro crash in QListBox::sizeForNumberOfLines at istweb.apple.com
  • kwq/KWQListBox.h: Added a clearCachedTextRenderers function.
  • kwq/KWQListBox.mm: (itemTextRenderer): Change to use globals that are outside the function, and added retain calls. (groupLabelTextRenderer): Ditto. (QListBox::clearCachedTextRenderers): Release global text renderers and nil out the globals.
  • kwq/WebCoreBridge.h: Removed updateAllViews; not needed any more.
  • kwq/WebCoreBridge.mm: Ditto.
  • kwq/WebCoreTextRendererFactory.h: Added a clearCaches method.
  • kwq/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]): Added. Tells all the views to repaint after clearing the cached text renderers from KWQListBox. To be more elegant, we could generalize the KWQListBox trick, but for now why bother?
  • kwq/WebCoreTextRendererFactory.m: Removed. I needed to put some C++ code in here, so changed the extension to .mm.
  • WebCore.pbproj/project.pbxproj: Removed WebCoreTextRendererFactory.m, and added WebCoreTextRendererFactory.mm.

WebKit:

Reviewed by John.

  • part of fix for <rdar://problem/3637519> REGRESSION (125-128): unrepro crash in QListBox::sizeForNumberOfLines at istweb.apple.com
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]): Call [super clearCaches].
3:58 PM Changeset in webkit [7408] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3528538> can paste a Return character into the Search field at amazon.com, other browsers won't
  • kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidChange:]): Truncate text before the first line break.
3:44 PM Changeset in webkit [7407] by darin
  • 2 edits in trunk/WebCore
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): Added some more assertions I used to track down what looks like a TEC bug.
3:36 PM Changeset in webkit [7406] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3779122> No accesskey support on LABEL element
  • khtml/html/html_formimpl.h: Change type of m_currValue to DOMString. Should have been done as part of my form data check-in, but harmless to do now. Add accessKeyAction function for HTMLLabelElementImpl.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLButtonElementImpl::parseHTMLAttribute): Remove conversion of DOMString to QString for m_currValue. (DOM::HTMLLabelElementImpl::formElement): If there's no "for" attribute, search children for the first control. (DOM::HTMLLabelElementImpl::accessKeyAction): Forward the accesskey action to the formElement.
2:50 PM Changeset in webkit [7405] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3303968> final newline character omitted from <textarea> when parsing a new page
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::processListing): Handle newline pending cases as well as space and tab pending spaces at the end of this function. This seems right for both scripts and text areas; it's not clear why omittiing the LF is ever needed. Tested by running all the layout tests; no regressions.
  • fixed <rdar://problem/3552736> word wrapped text fields that blur/focus when you type move the insertion point strangely (vtext.com)
  • khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Call text() instead of calling widget->text() directly. This prevents this function from running in cases where the text didn't really change for text areas in wrap mode.
2:28 PM Changeset in webkit [7404] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • got rid of ERROR message when running layout tests by implementing text-transform in computed style
  • khtml/css/css_computedstyle.cpp: (DOM::numberAsString): Added. Helper that returns "1" rather then "1.0" for integer values. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Fixed use of tabs instead of spaces. Fixed switch statements so they don't use default so we get errors if we leave a case out. Changed callers to use numberAsString instead of QString::number. Added implementation of CSS_PROP_TEXT_TRANSFORM. Added code to prevent falling through to next property when no item in a switch statement matches.
1:35 PM Changeset in webkit [7403] by darin
  • 31 edits
    7 adds in trunk

WebCore:

Reviewed by Chris.

  • did work to prepare for uploading files incrementally when submitting forms
  • khtml/misc/formdata.h: Added. Class for holding form data inside WebCore.
  • khtml/misc/formdata.cpp: Added.
  • khtml/html/html_formimpl.h: Added the FormDataList type, changed the formData function parameters and made it private, renamed the encoding method to appendFormData and changed the parameters around.
  • khtml/html/html_formimpl.cpp: (DOM::FormDataList): Added. Class that replaces the old use of QValueList<QCString> for form data. Later we'll change it to accomodate filenames too. (DOM::HTMLFormElementImpl::formData): Changed code to use FormDataList intsead of the old encodingList. Also changed to return the "OK" result as the function result and put the form data into something passed as an "out" parameter; the old way was the other way around. (DOM::HTMLFormElementImpl::submit): Change to use FormData rather than a QByteArray when getting the form data to submit. (DOM::HTMLButtonElementImpl::appendFormData): Rename from encoding, and use the new appendData function instead of the old way of doing += to put data on the list. (DOM::HTMLInputElementImpl::appendFormData): Ditto. (DOM::HTMLSelectElementImpl::appendFormData): Ditto. (DOM::HTMLKeygenElementImpl::appendFormData): Ditto. (DOM::HTMLTextAreaElementImpl::appendFormData): Ditto. (DOM::FormDataList::FormDataList): Added. (DOM::FormDataList::appendString): Added. (DOM::FormDataList::begin): Added. (DOM::FormDataList::end): Added.
  • khtml/khtml_part.h: Changed the type of the submitForm parameter to FormData instead of QByteArray.
  • khtml/khtmlpart_p.h: Changed the type of the submitFormData data member to FormData instead of QByteArray.
  • khtml/khtml_part.cpp: (KHTMLPart::submitForm): Called the new flattenToString function in all the code that handles mailto forms. Called the new flatten function in the non-Apple code path.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Pass NSArray for form data instead of NSData.
  • kwq/KWQKJob.h: Use FormData instead of QByteArray. A couple other small cleanups.
  • kwq/KWQKJobClasses.h: Ditto.
  • kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Ditto. (KIO::TransferJob::TransferJob): Ditto. (KIO::TransferJob::postData): Ditto.
  • kwq/KWQKPartsBrowserExtension.h: Ditto.
  • kwq/KWQLoader.mm: (KWQServeRequest): Ditto. (KWQServeSynchronousRequest): Ditto.
  • kwq/KWQFormData.h: Added. A function to convert KHTML form data into an NSArray for communication with the WebKit side.
  • kwq/KWQFormData.mm: Added.
  • kwq/WebCoreBridge.h: Pass NSArray instead of NSData for form data.
  • kwq/KWQArrayImpl.h: Added a detach member function. The old version would do unnecessary work when detach was called on an array that had exactly one reference.
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::detach): Added.
  • kwq/KWQMemArray.h: (QMemArray::detach): Call through to KWQArrayImpl.
  • kwq/KWQValueList.h: (QValueList::first): Added overload for non-const. (QValueList::last): Ditto.
  • ForwardingHeaders/misc/formdata.h: Added.
  • WebCore.pbproj/project.pbxproj: Added formdata.h, formdata.cpp, KWQFormData.h, and KWQFormData.cpp.
  • WebCore-tests.exp: Updated for changes to QValueList, and re-sorted.
  • WebCore-combined.exp: Regenerated.

WebKit:

Reviewed by Chris.

  • did work to prepare for uploading files incrementally when submitting forms
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): Use NSArray instead of NSData for form data. (-[WebHistoryItem formData]): Ditto.
  • History.subproj/WebHistoryItemPrivate.h: Ditto.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto. (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Ditto. (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
  • WebCoreSupport.subproj/WebSubresourceClient.h: Ditto.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Ditto. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
  • WebView.subproj/WebFramePrivate.h: Ditto.
  • WebView.subproj/WebFormDataStream.h: Added.
  • WebView.subproj/WebFormDataStream.m: (-[WebFormDataStream initWithFormDataArray:]): Placeholder; not done yet. (-[WebFormDataStream formDataArray]): Ditto.
  • WebKit.pbproj/project.pbxproj: Added WebFormDataStream files.
11:00 AM Changeset in webkit [7402] by darin
  • 4 edits in trunk/WebCore

Reviewed by Ken.

  • improved multiple submit logic in preparation for making command-click on a form button load a form in another frame
  • kwq/KWQKHTMLPart.h: Added const to a bunch of member functions for cleanup. Added prepareForUserAction member function.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Simplified logic and removed special case for "http" and "https". (KWQKHTMLPart::renderer): Added const. (KWQKHTMLPart::keyEvent): Added call to prepareForUserAction. (KWQKHTMLPart::lastEventIsMouseUp): Added const. (KWQKHTMLPart::eventMayStartDrag): Added const. (KWQKHTMLPart::mouseDown): Added call to prepareForUserAction. (KWQKHTMLPart::overrideMediaType): Added const. (KWQKHTMLPart::canGoBackOrForward): Added const. (KWQKHTMLPart::prepareForUserAction): Added. Clears _submittedFormURL.
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityPerformAction:]): Added call to prepareForUserAction.
10:43 AM Changeset in webkit [7401] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3762231> REGRESSION (Mail): tab key inserts a single space

  • khtml/editing/htmlediting_impl.cpp: (khtml::isTab): New helper. Checks a DOMString to see if it is one character and that character is a tab. (khtml::InputTextCommandImpl::execute): Trap tabs before handling insertion of other kinds of whitespace. Treat a tab like four spaces. Rearrange the code to update the ending position after the text insertion to cover the new tab case where the amount of advance is not the same as the number of character in the passed-in DOMString (i.e. tabs expand to four characters).
10:39 AM Changeset in webkit [7400] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Ken.

  • WebKit part of fix for <rdar://problem/3607720> myFrame.print() prints the window but should only print the frame
  • WebView.subproj/WebUIDelegatePrivate.h: declare new delegate method that includes which frame to print
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:printFrameView:]): implement default (no-op) version of new delegate method
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge print]): call new delegate method if available, otherwise call old delegate method, for backward compatibility.
8:38 AM Changeset in webkit [7399] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by John.
Checked in by Ken

Ken comments: It looks like Maciej forgot to land this when he checked in the
WebCore portion of this change.

<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website

Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canGoBackOrForward:]):
8:13 AM Changeset in webkit [7398] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3779706> plain text on pasteboard loses indentation when pasted into Blot

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::documentFragmentWithText): New function that takes over the code from KWQKHTMLPart and improves it to handle converting tabs and spaces for suitable display in HTML.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithText:]): Move smarts from here to KWQKHTMLPart.

Aug 29, 2004:

2:47 PM Changeset in webkit [7397] by mjs
  • 6 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website

Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.

  • khtml/khtml_part.cpp: (KHTMLPart::scheduleHistoryNavigation):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canGoBackOrForward):
  • kwq/KWQKPartsBrowserInterface.h:
  • kwq/WebCoreBridge.h:

Aug 27, 2004:

5:31 PM Changeset in webkit [7396] by mjs
  • 6 edits
    7 adds in trunk

Reviewed by Chris.

  • fixed <rdar://problem/3778043> REGRESSION: innerHTML is broken, breaks automated iBench testing
  • also fixed outerHTML, which would spill over past the node for whch it was supposed to get HTML
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::outerHTML):
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::toHTML): (NodeImpl::recursive_toString): (NodeImpl::recursive_toHTML):
  • khtml/xml/dom_nodeimpl.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]):
  • added new layout tests to cover the problems I fixed
  • layout-tests/fast/innerHTML/001-expected.txt: Added.
  • layout-tests/fast/innerHTML/001.html: Added.
  • layout-tests/fast/innerHTML/002-expected.txt: Added.
  • layout-tests/fast/innerHTML/002.html: Added.
  • layout-tests/fast/innerHTML/003-expected.txt: Added.
  • layout-tests/fast/innerHTML/003.html: Added.
5:07 PM Changeset in webkit [7395] by hyatt
  • 1 edit in trunk/WebCore/khtml/css/css_computedstyle.cpp

* empty log message *

5:06 PM Changeset in webkit [7394] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3739239, getComputedStyle of top not being implemented broke a site that checked for it.

Reviewed by kocienda

  • khtml/css/css_computedstyle.cpp: (DOM::valueForLength): (DOM::CSSComputedStyleDeclarationImpl::getPositionOffsetValue): (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • khtml/css/css_computedstyle.h:
3:39 PM Changeset in webkit [7393] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Ken.

Tweaked option-tab handling to match good suggestion from Tim Omernick of OmniWeb

  • kwq/KWQTextArea.mm: removed override of textDidChange: (-[KWQTextAreaTextView keyDown:]): moved option-tab handling that was in textDidChange to here. Rearranged existing code a little for clarity.
3:03 PM Changeset in webkit [7392] by adele
  • 2 adds in trunk/LayoutTests/fast/frames

Adding layout test for contentWindow for iframe

2:52 PM Changeset in webkit [7391] by adele
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Fix for:
<rdar://problem/3689949> Provide contentWindow access on an iframe

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): added cases for contentWindow for frames and iframes
  • khtml/ecma/kjs_html.h: added contentWindow to the list of properties for frames and iframes
  • khtml/ecma/kjs_html.lut.h: regenerated file
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::contentPart): factored out old contentDocument code to return KHTMLPart for frame (HTMLFrameElementImpl::contentDocument): now just gets the contentDocument from contentPart
  • khtml/html/html_baseimpl.h: added declaration for contentPart
12:07 PM Changeset in webkit [7390] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Chris

Fix for this bug:

<rdar://problem/3756997> WebKit aggressive in making pasted text into a URL, even when it's not much like a URL

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): Don't try so hard to coerce data on the pasteboard into a URL, and do not make an anchor with an href for any URLs that are explicitly present on the pasteboard. Also, move URL pasteboard type check beneath the RTF checks.
11:59 AM Changeset in webkit [7389] by vicki
  • 3 edits in trunk

back to 2.0, v162u for tip of tree

11:49 AM Changeset in webkit [7388]
  • 3 copies in tags/Safari-161

This commit was manufactured by cvs2svn to create tag 'Safari-161'.

11:49 AM Changeset in webkit [7387] by vicki
  • 6 edits in trunk

Safari-161 stamp

10:26 AM Changeset in webkit [7386] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3778059> Odd behaviour when editing between blockquote elements

  • khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::deleteUnrenderedText): This function should not move the selection out of the current block, ever. This is exactly what the bug reported. What was I thinking? Now, the code looks at the passed-in position and then the equivalent upstream and downstream positions to see if the selection can be placed there after the delete, and settles on the block containing the passed-in position as a fallback.
  • layout-tests/editing/inserting/insert-3778059-fix-expected.txt: Added.
  • layout-tests/editing/inserting/insert-3778059-fix.html: Added.

Aug 26, 2004:

6:40 PM Changeset in webkit [7385] by rjw
  • 4 edits in trunk/WebCore

Boiler plate for canvas gradients and patterns.

Reviewed by John.

  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): (Context2D::tryPut): (Context2D::~Context2D): (KJS::GradientFunction::tryCall): (Gradient::Gradient): (Gradient::tryGet): (Gradient::getValueProperty): (Gradient::tryPut): (Gradient::putValue): (Gradient::~Gradient): (ImagePattern::ImagePattern): (ImagePattern::tryGet): (ImagePattern::getValueProperty): (ImagePattern::tryPut): (ImagePattern::putValue): (ImagePattern::~ImagePattern):
  • khtml/ecma/kjs_html.h: (KJS::Gradient::toBoolean): (KJS::Gradient::classInfo): (KJS::Gradient::): (KJS::ImagePattern::toBoolean): (KJS::ImagePattern::classInfo): (KJS::ImagePattern::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
6:02 PM Changeset in webkit [7384] by cblu
  • 2 edits in trunk/WebKit

Fixed build failure on Panther.

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): ifdef'd out call to AppKit SPI (-[WebHTMLView _attributeStringFromDOMRange:]): ditto
5:38 PM Changeset in webkit [7383] by cblu
  • 2 edits in trunk/WebKit

Tweak to last check-in.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]):
5:10 PM Changeset in webkit [7382] by cblu
  • 4 edits in trunk/WebKit

Fixed:
<rdar://problem/3546412> support for pasting and drag and dropping of RTF and RTFD to editable WebViews
<rdar://problem/3745345> use AppKit for converting from DOM to RTF

Reviewed by rjw.

  • DOM.subproj/WebDOMOperations.m: (-[DOMDocument _documentRange]): new
  • DOM.subproj/WebDOMOperationsPrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call AppKit SPI to get a document fragment from an attributed string (-[WebHTMLView string]): added a FIXME (-[WebHTMLView _attributeStringFromDOMRange:]): new, calls AppKit SPI that creates an attributed string from a DOM Range (-[WebHTMLView attributedString]): call _attributeStringFromDOMRange:, fallback to old code if it returns nil (-[WebHTMLView selectedAttributedString]): ditto
4:54 PM Changeset in webkit [7381] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3777899> REGRESSION (Mail): only first of several misspelled words separated by
carriage returns is marked

  • khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::markMisspellingsAfterTyping): Give the spellchecker a slightly larger selection to work with while typing. This should preclude bugs of this type.
3:43 PM Changeset in webkit [7380] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3777804> Deleting all content in a document can result in giant tall-as-window insertion point

  • khtml/rendering/render_box.cpp: (RenderBox::caretPos): Always use the font height for calculating the caret height in non-replaced elements (like blocks), rather than the height of the box.
3:20 PM Changeset in webkit [7379] by kocienda
  • 1 edit
    1 add in trunk

Reviewed by me

Silly me. Forgot to add this file before.

  • layout-tests/editing/inserting/insert-3775316-fix-expected.txt: Added.
3:19 PM Changeset in webkit [7378] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3774178> Plugin hooks for selected state aren't being called

Reviewed by darin.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIsSelected:forView:]): don't forget colons in method names
2:59 PM Changeset in webkit [7377] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3768439> can't click in WebView in Carbon WebKit apps (GetEventPlatformEventRecord returns false)

Reviewed by rjw.

  • Carbon.subproj/HIWebView.m: (Click): use WebGetEventPlatformEventRecord not GetEventPlatformEventRecord (MouseUp): ditto (MouseMoved): ditto (MouseDragged): ditto (MouseWheelMoved): ditto (WindowHandler): ditto (HIWebViewEventHandler): ditto (UpdateObserver): ditto (WebGetEventPlatformEventRecord): Call GetEventPlatformEventRecord, if that fails fallback to the current event. This is code Eric Schlegel to me to use.
2:36 PM Changeset in webkit [7376] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3777172, crash from nested colgroup. Don't allow nested table sections or col groups.

Reviewed by darin

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
2:34 PM Changeset in webkit [7375] by kocienda
  • 2 edits
    1 add in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3775316> document sprouts an extra newline character at the end

  • khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): There was in insufficient check in the code which adds extra BR elements at the ends of blocks, which we do to work around the fact that BR elements, when they are the last element in a block, do not render. Now the code sees whether there already is one of these extra BR's in the document and won't add and "extra" extra.
  • layout-tests/editing/inserting/insert-3775316-fix.html: Added.
10:37 AM Changeset in webkit [7374] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3710721 and 3504114, crashes because of bad ownership model for list markers.

Reviewed by mjs

  • khtml/rendering/render_container.cpp: (RenderContainer::detach):
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::detach): (RenderListItem::updateMarkerLocation):
  • khtml/rendering/render_list.h:
9:46 AM Changeset in webkit [7373] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by John

  • khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): Remove the StayInBlock modifier from the call to upstream when passing the start position to removeStyle(). This makes the start position sufficiently upstream so that all relevant style tags are removed. (khtml::ApplyStyleCommandImpl::removeStyle): Pass the start position to nodeFullySelected. (khtml::ApplyStyleCommandImpl::nodeFullySelected): Change interface so start position for calculation is passed in, rather than recalculating it every time.
  • khtml/editing/htmlediting_impl.h: nodeFullySelected interface change.
  • khtml/xml/dom_position.h: Add a comment about the working of upstream() and downstream().
9:17 AM Changeset in webkit [7372] by kocienda
  • 2 edits in trunk

Reviewed by me

Fix garbled contenteditable attribute. I must have checked
this in with a typo.

  • layout-tests/editing/deleting/delete-3775172-fix.html
Note: See TracTimeline for information about the timeline view.