Timeline



Sep 12, 2004:

11:23 PM Changeset in webkit [7522] by darin
  • 2 edits in trunk/JavaScriptCore
  • tests/mozilla/expected.html: Updated test results for 3 more tests that pass with the new version of escape and unescape.
11:22 PM Changeset in webkit [7521] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed <rdar://problem/3798209> any non-ASCII characters are garbled in the result of toLocaleString
  • kjs/date_object.cpp: (formatLocaleDate): Replaced two old functions that used LongDateTime with this one new function that uses CFDateFormatter. (DateProtoFuncImp::call): Call the new formatLocaleDate instead of both formatLocaleDate and formatLocaleTime.
11:05 PM Changeset in webkit [7520] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3797758> REGRESSION (155-156): Cannot tab between input fields at switchboard.com
  • kwq/KWQLineEdit.mm: (QLineEdit::selectAll): Use setFocus() instead of calling makeFirstResponder directly since it handles the case where the field editor has focus.
11:05 PM Changeset in webkit [7519] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3792082> zero character codes in UTF-16 input cause crash
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Fixed code that was using the wrong variable to decrement the input length, causing buffer overrun.
11:04 PM Changeset in webkit [7518] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3798240> computed style error log messages seen with numbers in the range 74-77
  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added implementations for CSS_PROPKHTML_MARQUEE_INCREMENT, CSS_PROP_MAX_HEIGHT, CSS_PROP_MAX_WIDTH, CSS_PROP_MIN_HEIGHT, CSS_PROP_MIN_WIDTH, and CSS_PROP_VISIBILITY.
11:03 PM Changeset in webkit [7517] by darin
  • 1 edit
    1 delete in trunk
  • layout-tests/css1/text_properties/text-transform-expected.txt: Removed unused test result.

Sep 11, 2004:

1:22 AM Changeset in webkit [7516] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3787208> can't log in to SAP SDN site (JS parse error)

  • kwq/KWQKURL.mm: (KURL::decode_string): Check for find result >= 0 instead of >0, to handle case of first character in a string being encoded.

Sep 10, 2004:

4:26 PM Changeset in webkit [7515] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3782533> CrashTracer: .1459 crashes at com.apple.WebKit: -[WebTextRenderer initWithFont:usingPrinterFont:] + 0x138

We were explicitly failing when we encountered deprecated fonts.
(Those with unsupported glyph packings).
Deprecated fonts should only appear on a system that have
stuff migrated from OS 9. Ugh, thats probably why we've never seen
the problem here.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
4:15 PM Changeset in webkit [7514] by vicki
  • 4 edits in branches/Safari-1-2-branch/WebCore
  • merge these changes for SUPanNavy, <rdar://problem/3773150>

2004-08-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • fixed <rdar://problem/3752509> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)

(actually the previous fix for this bug was mostly correct, but
this additional change is needed to avoid the regression in
<rdar://problem/3751025> REGRESSION: website rejects Safari 125.9
as "need to upgrade to IE 6", but didn't reject 125.8

So if merging for a software update, make sure to include both
this and the previous fix.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): When there is an immediate reidrect pending, make sure to stop tokenizing, because we need to make sure no further script tags are processed beyond the one that triggered the redirect.
  • khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending): New method to allow checking if a redirect is pending.
  • khtml/khtml_part.h:

2004-06-18 John Sullivan <​sullivan@apple.com>

Reviewed by Darin

  • fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <
4:12 PM Changeset in webkit [7513] by vicki
  • 3 edits in branches/Safari-1-2-branch/WebKit

WebKit:

  • merge this change for <rdar://problem/3791183> Need to choose "best" frame instead of printing all frames clipped to window size (clone for SUPanNavy). The original fix would not compile on 10.3.5.

2004-09-10 John Sullivan <​sullivan@apple.com>

Reviewed by Chris.

  • added _isFrameSet as a private method, so it can be used in WebBrowser. This is needed to merge the fix for 3123987 to SUPanNavy.
  • WebView.subproj/WebFrame.m: (-[WebFrame _isFrameSet]): new method
  • WebView.subproj/WebFramePrivate.h: declare new method

WebBrowser:

  • merge this change for <rdar://problem/3791183> Need to choose "best" frame instead of printing all frames clipped to window size (clone for SUPanNavy). The original fix would not compile on 10.3.5.

2004-09-10 John Sullivan <​sullivan@apple.com>

Reviewed by Chris.

  • changed implementation of -[WebFrameView isFrameset] so that it's more easily mergeable back to 10.3.5. This is needed to merge 3123987 to SUPanNavy.
  • BrowserWebViewExtras.m: (-[WebFrameView isFrameset]): Call private WebFrame method instead of using DOM.
3:21 PM Changeset in webkit [7512] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

  • added _isFrameSet as a private method, so it can be used in WebBrowser. This is needed to merge the fix for 3123987 to SUPanNavy.
  • WebView.subproj/WebFrame.m: (-[WebFrame _isFrameSet]): new method
  • WebView.subproj/WebFramePrivate.h: declare new method

WebBrowser:

Reviewed by Chris.

  • changed implementation of -[WebFrameView isFrameset] so that it's more easily mergeable back to 10.3.5. This is needed to merge 3123987 to SUPanNavy.
  • BrowserWebViewExtras.m: (-[WebFrameView isFrameset]): Call private WebFrame method instead of using DOM.
1:53 PM Changeset in webkit [7511] by vicki
  • 3 edits in branches/Safari-1-2-branch/WebCore
  • code changes by Darin, reviewed by Vicki

Fix build breakage on the branch caused by bad merging for <rdar://problem/3772916> controls
on page at ​http://help.sap.com don't work properly (clone for SUPanNavy)

  • khtml/ecma/kjs_dom.lut.h: (KJS::):
  • khtml/ecma/kjs_window.cpp: (Window::Window): (BarInfo::BarInfo):
9:18 AM Changeset in webkit [7510] by cblu
  • 1 edit in trunk/WebKit/ChangeLog

Fixed previous "Reviewed by" line.

  • ChangeLog:
8:58 AM Changeset in webkit [7509] by cblu
  • 10 edits in trunk

WebCore:

Support for: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by rjw.

  • khtml/khtml_part.h: (KHTMLPart::didFirstLayout): new
  • khtml/khtmlview.cpp: (KHTMLView::layout): call didFirstLayout
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::didFirstLayout): new
  • kwq/WebCoreBridge.h:

WebKit:

Support for: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by NOBODY (OOPS!).

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge didFirstLayout]): new
  • WebView.subproj/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didFirstLayoutInFrame:]): new
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Fixed: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by rjw.

  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController startRSSAnimationForFrame:error:]): new (-[BrowserWindowController webFrameLoadDidFirstLayout:]): new (-[BrowserWindowController webFrameLoadFinished:withError:]): call startRSSAnimationForFrame:error:
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): added toggle for RSS animation (-[BrowserDocument toggleRSSAnimateAfterFirstLayout:]): new (-[BrowserDocument validate_toggleRSSAnimateAfterFirstLayout:]): new
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:didFirstLayoutInFrame:]): new
  • PreferenceKeys.h:

Sep 9, 2004:

7:31 PM Changeset in webkit [7508] by rjw
  • 7 edits
    2 adds in trunk/WebKit

Alternate implementation of image rendering. Use CGImageRefs instead
of NSImages.

Mostly works, but currently disabled because of issues w/ CG.

Reviewed by Chris.

  • ChangeLog:
  • WebCoreSupport.subproj/WebImageData.h: Added.
  • WebCoreSupport.subproj/WebImageData.m: Added. (-[WebImageData _commonTermination]): (-[WebImageData dealloc]): (-[WebImageData finalize]): (-[WebImageData copyWithZone:]): (-[WebImageData numberOfImages]): (-[WebImageData currentFrame]): (-[WebImageData _invalidateImages]): (-[WebImageData imageAtIndex:]): (-[WebImageData incrementalLoadWithBytes:length:complete:]): (drawPattern): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData isNull]): (-[WebImageData size]): (-[WebImageData _frameDuration]): (-[WebImageData _repetitionCount]): (-[WebImageData isAnimationFinished]): (+[WebImageData stopAnimationsInView:]): (-[WebImageData addAnimatingRenderer:inView:]): (-[WebImageData removeAnimatingRenderer:]): (-[WebImageData _stopAnimation]): (-[WebImageData _nextFrame:]): (-[WebImageData animate]):
  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer dealloc]): (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer retainOrCopyIfNeeded]): (-[WebImageRenderer resize:]): (-[WebImageRenderer size]): (-[WebImageRenderer MIMEType]): (-[WebImageRenderer frameCount]): (-[WebImageRenderer isNull]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): (-[WebImageRenderer tileInRect:fromPoint:context:]): (-[WebImageRenderer _startOrContinueAnimationIfNecessary]): (+[WebImageRenderer stopAnimationsInView:]): (-[WebImageRenderer stopAnimation]): (-[WebImageRenderer targetAnimationRect]): (-[WebImageRenderer increaseUseCount]): (-[WebImageRenderer decreaseUseCount]): (-[WebImageRenderer flushRasterCache]): (-[WebImageRenderer imageRef]): (-[WebImageRenderer TIFFRepresentation]): (-[WebImageRenderer image]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]): (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): (-[WebImageRendererFactory imageRendererWithSize:]): (-[WebImageRendererFactory imageRendererWithName:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebImageView.m: (-[WebImageView image]):
6:52 PM Changeset in webkit [7507] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Richard.

<rdar://problem/3493140> REGRESSION (85-100): cedille displays %-escaped in JavaScript message at hotmail.com

  • kjs/function.cpp: (KJS::GlobalFuncImp::call): Replace our escape() and unescape() implementations with ones from KDE KJS, which have the proper latin-1 behavior to match Win IE.
  • kjs/lexer.cpp: (Lexer::isHexDigit): Made static and non-const.
  • kjs/lexer.h:
6:41 PM Changeset in webkit [7506] by vicki
  • 3 edits in trunk

change version number to 2.0, 164u for TOT

6:29 PM Changeset in webkit [7505]
  • 3 copies in tags/Safari-163

This commit was manufactured by cvs2svn to create tag 'Safari-163'.

6:29 PM Changeset in webkit [7504] by vicki
  • 6 edits in trunk

Safari-163 stamp for everything except WebBrowser. In these projects, CFBundleShortVersionString matches CFBundleVersion (163 in both cases).

6:02 PM Changeset in webkit [7503] by mjs
  • 13 edits in trunk/WebCore
  • roll out the last change, it appears to cause a performance regression
  • khtml/rendering/render_box.cpp: (RenderBox::caretRect):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::caretRect):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_object.cpp: (RenderObject::caretRect):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_text.cpp: (RenderText::caretRect):
  • khtml/rendering/render_text.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm:
6:01 PM Changeset in webkit [7502] by mjs
  • 2 edits in trunk/WebKit
  • rolled out last two changes, they seem to cause a performance regression
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]):
3:25 PM Changeset in webkit [7501] by mjs
  • 2 edits in trunk/WebKit
  • fixed build
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]):
2:02 PM Changeset in webkit [7500] by mjs
  • 15 edits in trunk

WebCore:

Reviewed by Dave.

WebCore part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge firstRectForDOMRange:]): New method to compute the rect for a DOMRange, or if the range is split into multiple lines, the rect for the part on the first line only.
  • khtml/rendering/render_object.cpp: (RenderObject::caretRect): Added extraWidthToEndOfLine parameter and ditto for the overrides below.
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_box.cpp: (RenderBox::caretRect):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::caretRect):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_text.cpp: (RenderText::caretRect):

WebKit:

Reviewed by Dave.

WebKit part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Call the appropriate new bridge method, and translate to screen coordinates.
10:56 AM Changeset in webkit [7499]
  • 21 copies
    3 deletes in tags/WebKit-125~5

This commit was manufactured by cvs2svn to create tag 'WebKit-125~5'.

10:56 AM Changeset in webkit [7498] by vicki
  • 1 edit in branches/Safari-1-2-branch/WebKit/ChangeLog

add release marker and comment for WebKit-125.5

10:49 AM Changeset in webkit [7497] by vicki
  • 1 edit in branches/Safari-1-2-branch/WebKit/WebKit.pbproj/project.pbxproj

change the WebKit version number from 125.4.2 to 125.5, for Security Update

8:00 AM Changeset in webkit [7496] by darin
  • 20 edits in trunk

WebCore:

Reviewed by Ken.

  • fixed <rdar://problem/3790526> mark-related methods not implemented (needed for people with them in their key bindings files)
  • khtml/khtml_part.h: Added mark and setMark.
  • khtml/khtmlpart_p.h: Added m_mark.
  • khtml/khtml_part.cpp: (KHTMLPart::mark): Added. (KHTMLPart::setMark): Added.
  • kwq/KWQKHTMLPart.h: Change name of markedRange to markedTextRange to decrease the change it will be confused with the mark.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clear): Update for name change. (KWQKHTMLPart::markedTextRange): Ditto. (KWQKHTMLPart::setMarkedTextRange): Ditto.
  • khtml/rendering/render_text.cpp: (RenderText::paint): Update for name change.
  • kwq/WebCoreBridge.h: Remove setSelectionFrom, selectionStart, selectionStartOffset, selectionEnd, selectionEndOffset, and clearMarkedDOMRange. Renamed setMarkedDOMRange to setMarkedTextDOMRange and markedDOMRange to markedTextDOMRange. Added setMarkDOMRange and markDOMRange for the Emacs "mark".
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setMarkDOMRange:]): Added. (-[WebCoreBridge markDOMRange]): Added. (-[WebCoreBridge setMarkedTextDOMRange:]): Renamed. (-[WebCoreBridge markedTextDOMRange]): Renamed.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::validate): Make paragraph positions canonical by using deep rendered positions. Maybe someday this won't be an ad hoc decision any more.
  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::removeChildren): Use ref and deref rather than the unconventional check for 0 refCount. This makes us a bit more robust against a node going away partway through the removal process.
  • WebCore.pbproj/project.pbxproj: Update MACOSX_DEPLOYMENT_TARGET to 10.3.

WebKit:

Reviewed by Ken.

  • fixed <rdar://problem/3790526> mark-related methods not implemented (needed for people with them in their key bindings files)
  • WebKit.pbproj/project.pbxproj: Update MACOSX_DEPLOYMENT_TARGET to 10.3 and add -fobjc-exceptions so we can use new exceptions.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView setMark:]): Added. (unionDOMRanges): Added. (-[WebHTMLView deleteToMark:]): Added. (-[WebHTMLView selectToMark:]): Added. (-[WebHTMLView swapWithMark:]): Added. (-[WebHTMLView markedRange]): Updated for change to bridge method names. (-[WebHTMLView hasMarkedText]): Ditto. (-[WebHTMLView unmarkText]): Ditto. (-[WebHTMLView _selectMarkedText]): Ditto. (-[WebHTMLView _selectRangeInMarkedText:]): Ditto. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView _insertText:selectInsertedText:]): Removed check for empty string. An empty string should not be filtered out here. We need to allow inserting an empty string. (-[WebHTMLView _selectionIsInsideMarkedText]): Updated for change to bridge method names. (-[WebHTMLView _updateSelectionForInputManager]): Ditto.
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Changed to use selectionDOMRange instead of selectionStart.
  • WebView.subproj/WebHTMLRepresentation.h: Removed unused setSelectionFrom method.
  • WebView.subproj/WebHTMLRepresentation.m: Ditto.

Sep 8, 2004:

4:56 PM Changeset in webkit [7495] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • check in regenerated file khtml/ecma/kjs_window.lut.h, for 3772916
  • khtml/ecma/kjs_window.lut.h: (KJS::):
4:53 PM Changeset in webkit [7494] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

  • fixed the localization aspect of: <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

We now have all the strings ready for localization; we just don't actually use them yet.

  • English.lproj/Localizable.strings: updated for this change
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setUndoActionNamePlaceholder]): added this placeholder method whose purpose is to hold localizable strings for all the Undo action names that NSTextView uses. Later we will use some or all of these, but we can do that part after the localization freeze.

WebBrowser:

Reviewed by Darin.

  • English.lproj/StringsNotToBeLocalized.txt: updated for my recent changes
4:43 PM Changeset in webkit [7493] by vicki
  • 4 edits in branches/Safari-1-2-branch/WebCore
  • merge this fix from HEAD for SUPanNavy, <rdar://problem/3791496>

2004-08-10 Darin Adler <Darin Adler>

Reviewed by Trey.

  • fixed <rdar://problem/3710123> Loading iframe that replaces content in the parent document crashes Safari

I fixed three problems:

1) script interpreter destroyed while it was interpreting scripts, caused random havoc
2) code trying to get to view after view was detached from part, caused nil-deref
3) signals sent to parent after child was no longer in the parent's frames list, caused nil-deref

Now the test page works fine. Hope the real sites do too.

  • khtml/khtml_part.h: Add connectChild and disconnectChild helper functions (private).
  • khtml/khtml_part.cpp: (KHTMLPart::clear): Call disconnectChild on each frame as we detach it (see below). (KHTMLPart::end): Ref the part at the start, and deref the part at the end, of this function. Otherwise, we can end up destroying the part, and hence the interpreter, inside a script that the interpreter itself is running. (KHTMLPart::slotFinishedParsing): Add another check for a nil m_view, after the call to checkCompleted. (KHTMLPart::checkCompleted): Remove bogus if statement with empty body. (KHTMLPart::processObjectRequest): Call disconnectChild to disconnect the child <-> parent signals of the old child that the new one is replacing, and connectChild to connect the signals (nicer factoring). (KHTMLPart::slotChildCompleted): Fixed up a confusing boolean if/expression to be simpler. Not related to the bug fix, but an earlier version of the fix had changes in this function. (KHTMLPart::connectChild): Added. Connects the appropriate signals for a child frame. (KHTMLPart::disconnectChild): Added. Disconnects the same signals that connectChild connects.
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached): Added a call to disconnectChild before removing the child from the frames list.
4:13 PM Changeset in webkit [7492] by cblu
  • 1 edit in trunk/WebKit/ChangeLog

Fixed previous "Reviewed by" line.

  • ChangeLog:
4:12 PM Changeset in webkit [7491] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3778785> REGRESSION (Mail): copying from MS word and pasting into editable region leaves internal clipboard data

Reviewed by NOBODY (OOPS!).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): ignore Microsoft's header meta data
3:23 PM Changeset in webkit [7490] by vicki
  • 3 edits in branches/Safari-1-2-branch/WebCore
  • A few follow up changes necessary to really fix the colgroup crash, <rdar://problem/3791559>. I've included the original ChangeLog comments below. I did not merge the changes in render_block.cpp to eliminate redundant setPos -500000 calls, since those weren't necessary for this fix.
  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):

2004-09-01 David Hyatt <​hyatt@apple.com>

Fix for 3769409, a regression from 10.3.4 to 10.3.5 involving <colgroup>s in malformed HTML.

Reviewed by mjs

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):

2004-09-01 David Hyatt <​hyatt@apple.com>

Fix for the <colgroup> crasher. Make sure adding to an anonymous box just returns immediately. Also eliminate
all the redundant setPos -500000 calls, since we don't need those at all.

Reviewed by john

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::addChildToFlow):
3:07 PM Changeset in webkit [7489] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebKit
  • follow-up fix for <rdar://problem/3791526>, for SUPanNavy

2004-08-13 Darin Adler <Darin Adler>

Reviewed by Chris.

  • fixed <rdar://problem/3760924> Carbon path passed in NPP_StreamAsFile must be in local character set, not UTF-8
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (CarbonPathFromPOSIXPath): Added. New function that uses the path pieces from an FSSpec. This has many advantages; the big one that fixes the bug is that it gives the mangled names that work even for files that have names that can't otherwise be encoded in Carbon-style path names. I didn't write this from scratch: I started with the method in Foundation and just changed it to use FSSpec. (-[WebBaseNetscapePluginStream destroyStream]): Remove code that used NSString and just call CarbonPathFromPOSIXPath instead.
2:48 PM Changeset in webkit [7488] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3792893> WebBaseResourceHandleDelegate always returns cached data for subresource loads

Reviewed by rjw.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceForRequest:]): new (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceForRequest:
2:46 PM Changeset in webkit [7487] by mjs
  • 3 edits in trunk/WebCore
  • fixed deployment build problems noticed by Grant
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
  • khtml/rendering/render_text.cpp: (RenderText::caretRect):
1:26 PM Changeset in webkit [7486] by hyatt
  • 2 edits in trunk/WebCore

Fix XML so that elements with no namespace never make HTML elements (when their names coincidentally match).

Reviewed by rjw

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS):
1:04 PM Changeset in webkit [7485] by cblu
  • 1 edit
    4 adds in trunk/WebKit

Forgot to add this in previous check-in.

  • English.lproj/WebViewEditingContextMenu.nib: Added.
12:26 PM Changeset in webkit [7484] by mjs
  • 15 edits in trunk/WebCore

Reviewed by John.

  • renamed caretPos to caretRect and made it return a QRect instead of taking four out parameters by reference.
  • khtml/rendering/render_box.cpp: (RenderBox::caretRect):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::caretRect):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_object.cpp: (RenderObject::caretRect):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_text.cpp: (RenderText::caretRect):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_selection.cpp: (DOM::Selection::xPosForVerticalArrowNavigation): (DOM::Selection::layoutCaret):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge caretRectAtNode:offset:]):
11:17 AM Changeset in webkit [7483] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3791240> WebKit uses the NSTextViewContextMenu nib from inside AppKit

Reviewed by john.

  • English.lproj/StringsNotToBeLocalized.txt:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:]): use our copy of the nib
12:07 AM Changeset in webkit [7482] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • merge this fix from HEAD for SUPanNavy, <rdar://problem/3791559>

2004-08-26 David Hyatt <​hyatt@apple.com>

Fix for 3777172, crash from nested colgroup. Don't allow nested table sections or col groups.

Reviewed by darin

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
Note: See TracTimeline for information about the timeline view.