Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 18, 2004:

6:12 PM Changeset in webkit [7596] by darin

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3805627> -[DOMRange _text] sometimes includes all text to the end of the document for certain ranges

• khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::advance): Correctly handle the case when we are already on m_endNode. The concept here is that m_endNode is a node you must never "leave" when iterating.

Sep 17, 2004:

12:22 PM Changeset in webkit [7595] by vicki

• 3 edits in trunk

change version number to 2.0, 165u for TOT

12:06 PM Changeset in webkit [7594]

• 3 copies in tags/Safari-164

This commit was manufactured by cvs2svn to create tag 'Safari-164'.

12:06 PM Changeset in webkit [7593] by vicki

• 6 edits in trunk

Safari-164 stamp for everything except WebBrowser. In these projects, CFBundleShortVersionString matches CFBundleVersion (164 for both).

11:10 AM Changeset in webkit [7592] by cblu

• 2 edits in trunk/WebKit

Fixed:

<rdar://problem/3805757> don't unnecessarily put RTFD on the pasteboard
<rdar://problem/3805756> strip attachments before generating RTF

Reviewed by john.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): only put RTFD on the pasteboard if it has attachments, strip attachments when writing RTF

9:49 AM Changeset in webkit [7591] by kocienda

• 2 edits in trunk

Reviewed by me

• layout-tests/editing/selection/unrendered-004-expected.txt: Updated expected results.

9:44 AM Changeset in webkit [7590] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3780245> REGRESSION (Mail): some lines are skipped when doing arrow navigation

• khtml/xml/dom_position.cpp: (DOM::Position::previousLinePosition): One-line fix. Make sure that BRs at the end of blocks are not skipped.

9:42 AM Changeset in webkit [7589] by kocienda

• 4 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3805594> REGRESSION (Mail): Second return key stroke does not work when first was in blockquote

• khtml/xml/dom_selection.cpp: (DOM::Selection::toRange): Code to convert caret positions moved the position upstream before making a range-compliant position, but erroneously would allow the position to cross blocks. Now it will no longer do so.

Sep 16, 2004:

5:58 PM Changeset in webkit [7588] by rjw

• 9 edits in trunk/WebCore

Part 1 of the feature requested in
<rdar://problem/3752791> Dashboard: Need a better solution for control regions

This patch implements the CSS parsing necessary for dashboard regions.
Here's an example of the syntax we support:

<style>
#aDiv {

-apple-dashboard-region:

dashboard-region-circle(control 0 0 80 0)
dashboard-region-rectangle(control,20,0,20,0)
dashboard-region-circle(control 80 0 0 0);

}
</style>

Part 2 will determine the appropriate regions.

Reviewed by Chris.

• khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
• khtml/css/css_valueimpl.h: (DOM::CSSPrimitiveValueImpl::): (DOM::DashboardRegionImpl::DashboardRegionImpl): (DOM::DashboardRegionImpl::~DashboardRegionImpl): (DOM::DashboardRegionImpl::setNext): (DOM::DashboardRegionImpl::setLabel):
• khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseContent): (skipCommaInDashboardRegion): (CSSParser::parseDashboardRegions):
• khtml/css/cssparser.h:
• khtml/css/cssproperties.c: (hash_prop): (findProp):
• khtml/css/cssproperties.h:
• khtml/css/cssproperties.in:
• khtml/dom/css_value.h: (DOM::CSSPrimitiveValue::):

4:45 PM Changeset in webkit [7587] by darin

• 4 edits in trunk/WebCore

• fixed caret-drawing regression from my last patch

• khtml/xml/dom_selection.cpp: (DOM::Selection::xPosForVerticalArrowNavigation): Pass false, meaning "vertical line caret" rather than true meaning "big box for overtyping". (DOM::Selection::layoutCaret): Ditto.

4:09 PM Changeset in webkit [7586] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/3804648> 8A262: Safari crashed in -[WebView(WebPrivate) _editingDelegateForwarder] inside QuickTime Cocoa Plug-in during WebView deallocation

• WebView.subproj/WebView.m: (-[WebView _editingDelegateForwarder]): Check _private for nil before dereferencing it.

3:24 PM Changeset in webkit [7585] by darin

• 18 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3803280> crash in selectAll on page with no contents

• khtml/khtml_part.cpp: (KHTMLPart::selectAll): Handle case of 0 for documentElement().
• khtml/xml/dom_position.cpp: (DOM::Position::previousWordPosition): Ditto. (DOM::Position::nextWordPosition): Ditto.

• cleaned up caret code
• changed DOM::Selection to use CaretPosition more

• khtml/rendering/render_box.cpp: (RenderBox::caretRect): Change to use empty rectangles instead of an X value of -1 to mean no rectangle.
• khtml/rendering/render_image.cpp: (RenderImage::selectionRect): Take advantage of the fixed QRect constructor.
• khtml/rendering/render_object.cpp: (RenderObject::caretRect): Change to use empty rectangle instead of an X value of -1 to mean no rectangle.
• khtml/rendering/render_text.cpp: (RenderText::caretRect): Cleaned up, and changed to use an empty rectangle instead of an X value of -1 to mean no rectangle.

• khtml/xml/dom_caretposition.h: Made conversion from Position to CaretPosition something you can do implicitly, since it's an unambiguous conversion. Conversion in the other direction needs to be done explicitly. Moved EIncludeLineBreak here, and added startParagraphBoundary and endParagraphBoundary functions.
• khtml/xml/dom_caretposition.cpp: (DOM::startParagraphBoundary): Added. Replaces, and made from, member function of DOM::Position. (DOM::endParagraphBoundary): Ditto.

• khtml/xml/dom_position.h: Removed EIncludeLineBreak and startParagraphBoundary and endParagraphBoundary.
• khtml/xml/dom_position.cpp: Removed startParagraphBoundary and endParagraphBoundary.

• khtml/xml/dom_selection.h: Use CaretPosition instead of Position in a few places. Use a QRect for the caret rect. Change nodeIsBeforeNode to be a static member function.
• khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): Change caret to store QRect instead of 3 separate fields. (DOM::Selection::init): Ditto. (DOM::Selection::operator=): Ditto. (DOM::Selection::modifyExtendingRightForward): Change to use CaretPosition instead of Position. Check for 0. (DOM::Selection::modifyMovingRightForward): Ditto. Check for 0. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Ditto. (DOM::Selection::layoutCaret): Change to use a QRect for the caret rect, and use an empty one to mean no rectangle. (DOM::Selection::getRepaintRect): Ditto. (DOM::Selection::paintCaret): Ditto. (DOM::Selection::validate): Change to use CaretPosition instead of Position. Also fixed PARAGRAPH_BOUNDARY, which was broken and doing the same thing as PARAGRAPH before, but it's not really used so that didn't matter. Check for 0. (DOM::Selection::nodeIsBeforeNode): Tightened up a bit and added some FIXMEs. This function has a number of problems and should probably be discarded in favor of the DOMStringImpl method that does the same thing.

2:16 PM Changeset in webkit [7584] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3787168> REGRESSION (Mail): Deleting text from the beginning of a quoted range removes the quoting from the rest

• khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::moveNodesAfterNode): Only move the text nodes (and their siblings) when doing this move between blocks. This serves to mimic NSText behavior very well.

11:38 AM Changeset in webkit [7583] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/3779150> REGRESSION: images not copied when copying HTML in Safari and pasting into TextEdit

Reviewed by john.

• WebView.subproj/WebHTMLView.m:

(-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): use …

for RTFD

• WebView.subproj/WebHTMLViewPrivate.h:

Sep 15, 2004:

9:57 PM Changeset in webkit [7582] by darin

• 2 edits in trunk/WebCore

• fixed Panther build

• kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityActionDescription:]): Fixed backwards check in #if that was compiling the code on Panther only rather than Tiger only.

5:57 PM Changeset in webkit [7581] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed lockFocus exception I observed; perhaps not a real issue in the field due to exception blocking

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::imageFromRect): Put most of the function inside a big if statement to avoid the exception we get from lockFocus otherwise.

5:57 PM Changeset in webkit [7580] by darin

• 4 edits in trunk/WebCore

Reviewed by Dave.

• fixed <rdar://problem/3786467> REGRESSION (Mail): Reproducible crash replying to an HTML message when your preference is for plain text composing.

• khtml/rendering/render_block.h: Remove removeChildrenFromLineBoxes.
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild): Remove calls to removeChildrenFromLineBoxes which was the old way of working around this.
• khtml/rendering/render_flow.cpp: (RenderFlow::detach): Add comments and code to handle removing children from line boxes we are about to delete.

5:52 PM Changeset in webkit [7579] by rjw

• 2 edits in trunk/WebCore

Fixed <rdar://problem/3781561> REGRESSION (Mail): typing in Mail became suddenly really sluggish (substitute font code)

A DocumentMarker may begin before the InLineBox that includes
it. Ensure that we correctly handle that case. The paintMarker()
method and code that calls it could do with some cleanup to
make it clearer how all the cases are handled, i.e. marker
within box, or intersecting beginning or end of box.

Reviewed by Darin.

• khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): Minimal change to ensure that we handle the case of marker starting before box.

5:51 PM Changeset in webkit [7578] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• get rid of some of the localizable strings in here; we still have to figure out how we're going to localize the last few role descriptions

• kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): Use NSAccessibilityRoleDescription for most descriptions instead of a hard-coded string (inside the UI_STRING placeholder). (-[KWQAccObject accessibilityActionDescription:]): Same thing, with NSAccessibilityActionDescription.

5:46 PM Changeset in webkit [7577] by darin

• 4 edits in trunk/WebCore

Reviewed by John.

• did some QRect-related changes to facilitate later bug fixing

• kwq/KWQPainter.h: Added fillRect overload that takes QRect to match the real Qt one.
• kwq/KWQPainter.mm: (QPainter::fillRect): Added overload that takes QRect.

• kwq/KWQRect.mm: (QRect::QRect): Change default constructed QRect to have a width and height of 0 rather than 1. Contrary to what we believed earlier, this is what Qt does.

5:41 PM Changeset in webkit [7576] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3799512> REGRESSION (Mail): caret flashes 1 pixel too far to the left

• khtml/rendering/render_text.cpp: (RenderText::caretRect): Added one to the horizontal position of the caret rect.

5:31 PM Changeset in webkit [7575] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed assertion I saw using the font panel

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _colorAsString:]): Convert color space before trying to get R, G, and B components.

4:55 PM Changeset in webkit [7574] by adele

• 2 edits in branches/Safari-1-2-branch/WebKit

Code change by Darin, reviewed by me.

• further follow-up fix for for <rdar://problem/3791526>

• WebView.subproj/WebFrame.m: (+[WebFrame _recursiveCheckCompleteFromFrame:]): Don't call _isLoadCompleted on the child frame again, once is enough. The second time hits an assertion failure. This is already fixed on Tiger.

1:58 PM Changeset in webkit [7573] by kocienda

• 2 edits
  12 adds in trunk

Reviewed by Hyatt

• khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): The whitespace fixup code that makes sure proper whitespace renders after deletion was getting confused in cases where the deletion merged blocks. Basically, I needed to move some whitespace fixup code so it runs before deleting in the case where blocks need to be merged. It used to run after, and was getting confused by whitespace left over at the ends of the block after the deletion.
• layout-tests/editing/deleting/delete-block-merge-contents-012-expected.txt: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-012.html: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-013-expected.txt: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-013.html: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-014-expected.txt: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-014.html: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-015-expected.txt: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-015.html: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-016-expected.txt: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-016.html: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt: Added.
• layout-tests/editing/deleting/delete-block-merge-contents-017.html: Added.

11:26 AM Changeset in webkit [7572] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3802232> REGRESSION (Mail): WebCore Editing must do smart copy

Reviewed by kocienda.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]): call instance method not class method to get pasteboard types since the types depends on the current selection granularity (-[WebHTMLView pasteboardTypesForSelection]): if the selection granularity is "word" include the smart pasteboard type (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): put nil on the pasteboard for smart copy

11:02 AM Changeset in webkit [7571] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::moveNodesAfterNode): Renamed from moveNodesToBlock. Just some simplification and cleanup in this function. (khtml::DeleteSelectionCommandImpl::doApply): Remove a hunk of start-of-block code I thought I was going to get around to improving and refining. However, I no longer need this case.
• khtml/editing/htmlediting_impl.h: Function name change.

10:36 AM Changeset in webkit [7570] by darin

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Remove stray change marker.