Timeline



Sep 20, 2004:

6:16 PM Changeset in webkit [7615] by darin
  • 23 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed regression from my recent check-in where misspelled words do not get unmarked when moving the caret
  • changed CaretPosition to hold a Position instead of a node and offset
  • renamed isEmpty to isNull, etc.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): Updated for name changes. (KWQKHTMLPart::advanceToNextMisspelling): Ditto. (KWQKHTMLPart::fontForSelection): Ditto. (KWQKHTMLPart::setDisplaysWithFocusAttributes): Ditto. (KWQKHTMLPart::markMisspellingsInSelection): Ditto. (KWQKHTMLPart::updateSpellChecking): Fixed bug by using LeftWordIfOnBoundary.
  • khtml/xml/dom_position.h: Updated for name changes.
  • khtml/xml/dom_position.cpp: (DOM::Position::element): Change to not use a separate null check. (DOM::Position::computedStyle): Updated for name changes. (DOM::Position::previousCharacterPosition): Ditto. (DOM::Position::nextCharacterPosition): Ditto. (DOM::Position::equivalentRangeCompliantPosition): Ditto. (DOM::Position::equivalentShallowPosition): Ditto. (DOM::Position::equivalentDeepPosition): Ditto. (DOM::Position::closestRenderedPosition): Ditto. (DOM::Position::inRenderedContent): Ditto. (DOM::Position::inRenderedText): Ditto. (DOM::Position::isRenderedCharacter): Ditto. (DOM::Position::rendersInDifferentPosition): Ditto. (DOM::Position::isFirstRenderedPositionOnLine): Ditto. (DOM::Position::isLastRenderedPositionOnLine): Ditto. (DOM::Position::inFirstEditableInRootEditableElement): Ditto. (DOM::Position::leadingWhitespacePosition): Ditto. (DOM::Position::trailingWhitespacePosition): Ditto. (DOM::Position::debugPosition): Ditto. (DOM::Position::formatForDebugger): Ditto.
  • khtml/xml/dom_caretposition.h: Change to use m_position, and change names.
  • khtml/xml/dom_caretposition.cpp: (DOM::CaretPosition::CaretPosition): Remove code to set up m_node. (DOM::CaretPosition::init): Set m_position directly. (DOM::CaretPosition::isLastInBlock): Updated for name changes. (DOM::CaretPosition::next): Set m_position directly. (DOM::CaretPosition::previous): Set m_position directly. (DOM::CaretPosition::previousCaretPosition): Updated for name changes. (DOM::CaretPosition::nextCaretPosition): Ditto. (DOM::CaretPosition::previousPosition): Ditto. (DOM::CaretPosition::nextPosition): Ditto. (DOM::CaretPosition::atStart): Ditto. (DOM::CaretPosition::atEnd): Ditto. (DOM::CaretPosition::isCandidate): Ditto. (DOM::CaretPosition::debugPosition): Ditto. (DOM::CaretPosition::formatForDebugger): Ditto. (DOM::startOfWord): Ditto. (DOM::endOfWord): Ditto. (DOM::previousParagraphPosition): Ditto. (DOM::nextParagraphPosition): Ditto.
  • khtml/xml/dom_selection.h: Updated names. Added isCaret and isRange.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::modifyMovingRightForward): Updated for name changes. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Ditto. (DOM::Selection::expandUsingGranularity): Ditto. (DOM::Selection::xPosForVerticalArrowNavigation): Ditto. (DOM::Selection::toRange): Ditto. (DOM::Selection::layoutCaret): Ditto. (DOM::Selection::needsCaretRepaint): Ditto. (DOM::Selection::validate): Ditto. (DOM::startOfFirstRunAt): Ditto. (DOM::endOfLastRunAt): Ditto. (DOM::selectionForLine): Ditto. (DOM::Selection::formatForDebugger): Ditto.
  • khtml/ecma/kjs_window.cpp: (Selection::get): Updated for name changes. (Selection::toString): Ditto.
  • khtml/editing/htmlediting_impl.cpp: (khtml::debugPosition): Ditto. (khtml::StyleChange::init): Ditto. (khtml::StyleChange::currentlyHasStyle): Ditto. (khtml::CompositeEditCommandImpl::deleteSelection): Ditto. (khtml::CompositeEditCommandImpl::deleteUnrenderedText): Ditto. (khtml::ApplyStyleCommandImpl::doApply): Ditto. (khtml::DeleteSelectionCommandImpl::doApply): Ditto. (khtml::InputNewlineCommandImpl::doApply): Ditto. (khtml::InputTextCommandImpl::prepareForTextInsertion): Ditto. (khtml::InputTextCommandImpl::input): Ditto. (khtml::ReplaceSelectionCommandImpl::doApply): Ditto. (khtml::MoveSelectionCommandImpl::doApply): Ditto. (khtml::TypingCommandImpl::doApply): Ditto. (khtml::TypingCommandImpl::markMisspellingsAfterTyping): Ditto. (khtml::TypingCommandImpl::issueCommandForDeleteKey): Ditto.
  • khtml/editing/jsediting.cpp: (enabledAnySelection): Ditto. (enabledRangeSelection): Ditto.
  • khtml/khtml_part.cpp: (KHTMLPart::hasSelection): Ditto. (KHTMLPart::setFocusNodeIfNeeded): Ditto. (KHTMLPart::selectionLayoutChanged): Ditto. (KHTMLPart::timerEvent): Ditto. (KHTMLPart::isPointInsideSelection): Ditto. (KHTMLPart::selectClosestWordFromMouseEvent): Ditto. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMousePressEventSingleClick): Ditto. (KHTMLPart::handleMouseMoveEventSelection): Ditto. (KHTMLPart::khtmlMouseReleaseEvent): Ditto. (KHTMLPart::selectionHasStyle): Ditto. (KHTMLPart::selectionComputedStyle): Ditto.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Ditto.
  • khtml/xml/dom_positioniterator.cpp: (DOM::PositionIterator::peekPrevious): Ditto. (DOM::PositionIterator::peekNext): Ditto. (DOM::PositionIterator::atStart): Ditto. (DOM::PositionIterator::atEnd): Ditto.
  • khtml/xml/dom_positioniterator.h: (DOM::PositionIterator::isEmpty): Ditto.
  • kwq/KWQRenderTreeDebug.cpp: (writeSelection): Ditto.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge editableDOMRangeForPoint:]): Ditto. (-[WebCoreBridge deleteSelection]): Ditto. (-[WebCoreBridge ensureCaretVisible]): Ditto. (-[WebCoreBridge rangeOfCharactersAroundCaret]): Ditto.
5:28 PM Changeset in webkit [7614] by darin
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3808073> find is broken
  • khtml/misc/khtml_text_operations.h: Add m_pastEndNode and change name of m_endNode to m_endContainer to more accurately reflect its purpose.
  • khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::TextIterator): Use pastEnd() for end of iteration, and change to handle bad ranges better: just return an empty iterator instead of raising an exception. (khtml::TextIterator::advance): Change to use m_pastEndNode to detect the end of iteration. (khtml::TextIterator::handleTextNode): Update for name change. (khtml::TextIterator::handleTextBox): Ditto. (khtml::TextIterator::range): Handle case where m_endContainer is nil.
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::surroundContents): Use offsetInCharacters. (DOM::RangeImpl::startNode): Added check for nil start container and use offsetInCharacters. (DOM::RangeImpl::pastEndNode): Ditto.
4:56 PM Changeset in webkit [7613] by cblu
  • 10 edits in trunk

WebCore:

Fixed: <rdar://problem/3781290> REGRESSION (Mail): Crash in ReplaceSelectionCommandImpl attaching file to new message

Reviewed by kocienda.

  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): setFocusNodeIfNeeded now works on the current selection so call setFocusNodeIfNeeded after setting the selection (KHTMLPart::clearSelection): don't call setFocusNodeIfNeeded with the current selection (KHTMLPart::setCaretVisible): ditto (KHTMLPart::setFocusNodeIfNeeded): do nothing if the part isn't focused, work with the current selection
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): added m_isFocused
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): removed _displaysWithFocusAttributes this is replaced by m_isFocused (KWQKHTMLPart::setSelectionFromNone): new, code factored out from setDisplaysWithFocusAttributes (KWQKHTMLPart::setDisplaysWithFocusAttributes): call setSelectionFromNone (KWQKHTMLPart::displaysWithFocusAttributes): now returns m_isFocused
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectionFromNone]): new

WebKit:

Fixed: <rdar://problem/3781290> REGRESSION (Mail): Crash in ReplaceSelectionCommandImpl attaching file to new message

Reviewed by kocienda.

  • WebView.subproj/WebView.m: (-[WebView setEditable:]): call updateSelectionFromEmpty on the bridge if there is no selection
4:26 PM Changeset in webkit [7612] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed nil-deref happening often in Mail when I delete
  • khtml/rendering/render_br.cpp: (RenderBR::selectionRect): Check for nil lastLeafChild. Dave may want to figure out why it's nil and do a different fix later.
2:53 PM Changeset in webkit [7611] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3672101> HANG: typing into login field at dws-direkt.deutsche-bank.de (infinite recursion)

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): Copy the list of handlers before firing any of them, in case a handler affects the list of event handlers.
2:36 PM Changeset in webkit [7610] by cblu
  • 15 edits in trunk

WebCore:

Fixed:
<rdar://problem/3429921> obey PARAM tags inside of OBJECT tags when necessary
<rdar://problem/3515685> Object tag in Java 1.4.1 / Safari doesn't recognize params

Reviewed by darin.

  • khtml/khtml_part.cpp: (KHTMLPart::requestFrame): take 2 parameter arrays rather than 1 which will have to be parsed (KHTMLPart::requestObject): ditto
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h:
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): use PARAM tags when there is no EMBED specified
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): call renamed bridge method
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): ditto
  • kwq/KWQStringList.h:
  • kwq/KWQStringList.mm: (QStringList::getNSArray): return a const array
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge URLWithAttributeString:]): renamed to match API

WebKit:

Changes to implement renamed bridge methods.

Reviewed by darin.

  • ChangeLog:
  • DOM.subproj/WebDOMOperations.m: (-[DOMDocument URLWithAttributeString:]): call renamed bridge method
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): take 2 parameter arrays rather than 1 which will have to be parsed (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto
1:21 PM Changeset in webkit [7609] by darin
  • 1 edit
    1 add
    1 delete in trunk/WebKit

Reviewed by Chris.

  • WebView.subproj/WebFramePrivate.h: Added back.
  • WebView.subproj/WebFrameViewPrivate.h: Removed.
11:54 AM Changeset in webkit [7608] by darin
  • 39 edits
    2 deletes in trunk

WebCore:

Reviewed by Ken.

  • fixed <rdar://problem/3655360> REGRESSION (Mail): Ctrl-V emacs key binding, -pageDown: method, unimplemented (and pageUp, and selection-modifying versions)
  • fixed <rdar://problem/3735055> REGRESSION (Mail): WebCore double click rules treat style change as a boundary
  • fixed <rdar://problem/3789939> REGRESSION (Mail): double-clicking on border whitespace selects space plus word before/after
  • fixed <rdar://problem/3792138> REGRESSION (Mail): Spell checker doesn't check current selected word
  • fixed <rdar://problem/3806604> REGRESSION (164): Triple-click sometimes selects extra characters
  • fixed <rdar://problem/3806996> REGRESSION (125-162): Triple-click in <pre> tagged text behaves oddly (leuf.net)
  • khtml/xml/dom_caretposition.h: Added a lot of new functions. Removed implicit conversion operator that converts from CaretPosition to Position.
  • khtml/xml/dom_caretposition.cpp: (DOM::CaretPosition::CaretPosition): Change to call deepEquivalent so it works without the implicit Position conversion operator. (DOM::CaretPosition::operator=): Ditto. (DOM::CaretPosition::next): Ditto. (DOM::CaretPosition::previous): Ditto. (DOM::CaretPosition::setPosition): Added an assertion. (DOM::start): Added. (DOM::end): Added. (DOM::setStart): Added. (DOM::setEnd): Added. (DOM::previousWordBoundary): Added. (DOM::nextWordBoundary): Added. (DOM::startWordBoundary): Added. (DOM::startOfWord): Added. (DOM::endWordBoundary): Added. (DOM::endOfWord): Added. (DOM::previousWordPositionBoundary): Added. (DOM::previousWordPosition): Added. (DOM::nextWordPositionBoundary): Added. (DOM::nextWordPosition): Added. (DOM::previousLinePosition): Added. (DOM::nextLinePosition): Added. (DOM::startOfParagraph): Changed function name. (DOM::endOfParagraph): Changed function name. Fixed code in includeLineBreak to work around the CaretPosition constructor issue for <br>, pass the right parameter for the block flow case, and handle <pre> properly. (DOM::inSameParagraph): Added. (DOM::previousParagraphPosition): Added. (DOM::nextParagraphPosition): Added.
  • khtml/xml/dom_position.h: Removed a number of functions no longer used; also made some private.
  • khtml/xml/dom_position.cpp: Removed a number of functions no longer used.
  • khtml/xml/dom_selection.h: Replaced DOCUMENT with DOCUMENT_BOUNDARY. Added overloads of lots of functions that take CaretPosition directly. Added overload of modify that takes a parameter for vertical distance to help implement pageDown: and friends. Replaced getRepaintRect with two new functions named caretRect and caretRepaintRect. Removed nodeIsBeforeNode.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): Added constructor that takes two CaretPosition objects. (DOM::Selection::setModifyBias): Added. Helper function. (DOM::Selection::modifyExtendingRightForward): Don't set modify bias, since that's now the caller's responsibility. Reimplement WORD and LINE in terms of new CaretPosition functions. Implement PARAGRAPH and change PARAGRAPH_BOUNDARY to use CaretPosition function by its new name. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Call setModifyBias, and use a switch statement instead of if. (DOM::caretY): Added. Helper for the new modify function that implements moving a pixel distance, used by pageDown: and friends. (DOM::Selection::modify): Added. (DOM::Selection::toRange): Use RangeImpl::compareBoundaryPoints instead of nodeIsBeforeNode. (DOM::Selection::caretRect): Added. Replaces getRepaintRect, but does not add slop. (DOM::Selection::caretRepaintRect): Added. Replaces getRepaintRect; still adds slop. (DOM::Selection::needsCaretRepaint): Call caretRepaintRect. (DOM::Selection::validate): Use RangeImpl::compareBoundaryPoints instead of nodeIsBeforeNode. Reimplement WORD to use new CaretPosition functions; this fixes the double-clicking problems. Change paragraph calls to use new names.
  • ForwardingHeaders/dom/dom_position.h: Removed. This was in the wrong location.
  • khtml/editing/htmlediting.cpp: Fixed include that said "dom/dom_position.h".
  • khtml/editing/htmlediting_impl.cpp: Fixed include that said "dom/dom_position.h". (khtml::TypingCommandImpl::markMisspellingsAfterTyping): Rewrote this to use the new CaretPosition functions instead of the old Position functions.
  • khtml/misc/helper.h: Added const to character pointer parameter. Also put invertedColor inside an !APPLE_CHANGES since it doesn't do us any good.
  • khtml/misc/helper.cpp: (khtml::findWordBoundary): Added const to character pointer parameter. (khtml::nextWordFromIndex): Ditto.
  • kwq/KWQTextUtilities.h: Change parameters to const.
  • kwq/KWQTextUtilities.cpp: (KWQFindWordBoundary): Change parameter to const.
  • kwq/KWQTextUtilities.mm: (KWQFindNextWordFromIndex): Change parameter to const.
  • khtml/css/cssstyleselector.cpp: Disable code that uses invertedColor when APPLE_CHANGES, since it won't work for us.
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection): Added checks for selection end so we can set the selection end to nodes that are not leaf nodes and it will still work. Also took out bogus firstChild/lastChild loops for the same reason.
  • kwq/KWQKHTMLPart.h: Add "start before selection" flag to advanceToNextMisspelling. Needed to fix bug with spell checking.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): Changed to use CaretPosition. (KWQKHTMLPart::advanceToNextMisspelling): Added code to handle "start before selection" flag and changed to use CaretPosition and new helper functions. (KWQKHTMLPart::markMisspellingsInSelection): More changes to use CaretPosition. (KWQKHTMLPart::updateSpellChecking): Ditto.
  • kwq/WebCoreBridge.h: Replaced WebSelectByDocument with WebSelectToDocumentBoundary. Added advanceToNextMisspellingStartingJustBeforeSelection, rangeByAlteringCurrentSelection:verticalDistance:, and alterCurrentSelection:verticalDistance:.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge advanceToNextMisspellingStartingJustBeforeSelection]): Added. (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Added case for selecting by paragraph to save X position. (-[WebCoreBridge rangeByAlteringCurrentSelection:verticalDistance:]): Added. (-[WebCoreBridge alterCurrentSelection:verticalDistance:]): Added. (-[WebCoreBridge ensureCaretVisible]): Call caretRect instead of getRepaintRect.

WebKit:

Reviewed by Ken.

  • fixed <rdar://problem/3655360> REGRESSION (Mail): Ctrl-V emacs key binding, -pageDown: method, unimplemented (and pageUp, and selection-modifying versions)
  • fixed <rdar://problem/3792138> REGRESSION (Mail): Spell checker doesn't check current selected word
  • WebView.subproj/WebFrameViewInternal.h: Moved WebFrameViewPrivate inside the WebFrameView.m file. Removed a bunch of methods that don't need to be seen in other files, and added _verticalPageScrollDistance.
  • WebView.subproj/WebFrameViewPrivate.h: Removed. Renamed to WebFrameViewInternal.h.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): Move in the file because of internal vs. private. (-[WebFrameView _shouldDrawBorder]): Ditto. (-[WebFrameView _tile]): Ditto. (-[WebFrameView _verticalPageScrollDistance]): Added. Separate method so it can be called by the code to implement pageDown:. (-[WebFrameView _drawBorder]): Move in the file because of internal vs. private. (-[WebFrameView _goBack]): Ditto. (-[WebFrameView _goForward]): Ditto. (-[WebFrameView _scrollVerticallyBy:]): Ditto. (-[WebFrameView _scrollHorizontallyBy:]): Ditto. (-[WebFrameView _horizontalKeyboardScrollDistance]): Ditto. (-[WebFrameView _horizontalPageScrollDistance]): Added. Separate method for consistency with vertical method above. (-[WebFrameView _pageVertically:]): Moved and changed to use _verticalPageScrollDistance. (-[WebFrameView _pageHorizontally:]): Moved and changed to use _horizontalPageScrollDistance. (-[WebFrameView _scrollLineVertically:]): Move in the file because of internal vs. private. (-[WebFrameView _scrollLineHorizontally:]): Ditto. (-[WebFrameView scrollPageUp:]): Ditto. (-[WebFrameView scrollPageDown:]): Ditto. (-[WebFrameView scrollLineUp:]): Ditto. (-[WebFrameView scrollLineDown:]): Ditto. (-[WebFrameView _firstResponderIsControl]): Ditto. (-[WebFrameView keyDown:]): Changed to eliminate _pageLeft, _lineLeft, _pageRight, and _lineRight.
  • WebView.subproj/WebDataSource.m: Use WebFrameView.h instead of WebFrameViewPrivate.h.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): Added. (-[WebHTMLView moveToBeginningOfDocument:]): Use WebSelectToDocumentBoundary. (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveToEndOfDocument:]): Ditto. (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): Ditto. (-[WebHTMLView moveParagraphBackwardAndModifySelection:]): Added. (-[WebHTMLView moveParagraphForwardAndModifySelection:]): Added. (-[WebHTMLView pageUp:]): Added. (-[WebHTMLView pageDown:]): Added. (-[WebHTMLView pageUpAndModifySelection:]): Added. (-[WebHTMLView pageDownAndModifySelection:]): Added. (-[WebHTMLView showGuessPanel:]): Changed to call advanceToNextMisspellingStartingJustBeforeSelection. This fixes the problem with spell checking.
  • WebView.subproj/WebImageView.m: (-[WebImageView webView]): Changed to use _web_parentWebView. (-[WebImageView menuForEvent:]): Changed to use [self webView]. (-[WebImageView mouseDown:]): Ditto. (-[WebImageView mouseDragged:]): Ditto. (-[WebImageView draggedImage:endedAt:operation:]): Ditto.
  • WebView.subproj/WebTextView.m: (-[WebTextView _textSizeMultiplierFromWebView]): Changed to use _web_parentWebView. (-[WebTextView menuForEvent:]): Ditto. (-[WebTextView drawPageBorderWithSize:]): Ditto. (-[WebTextView knowsPageRange:]): Ditto.
  • Plugins.subproj/WebPluginDatabase.m: Updated filename of WebFrameViewInternal.h.
  • WebCoreSupport.subproj/WebBridge.m: Ditto.
  • WebKit.pbproj/project.pbxproj: Ditto.
  • WebView.subproj/WebFrame.m: Ditto.
  • WebView.subproj/WebView.m: Ditto.
  • Misc.subproj/WebNSViewExtras.m: Ditto.
11:52 AM Changeset in webkit [7607] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • cleaned up DOM::RangeImpl a little so compareBoundaryPoints can be used outside the class
  • khtml/xml/dom2_rangeimpl.h: Added const to many of the member functions and made the compareBoundaryPoints that works on parameters be a const member function.
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::commonAncestorContainer): Added const. (DOM::RangeImpl::compareBoundaryPoints): Added const. (DOM::RangeImpl::boundaryPointsValid): Added const, and wrote cleaner version. (DOM::RangeImpl::insertNode): Simplified by calling containedByReadOnly. (DOM::RangeImpl::toString): Added const. (DOM::RangeImpl::toHTML): Added const. (DOM::RangeImpl::createContextualFragment): Added const. (DOM::RangeImpl::cloneRange): Added const. (DOM::RangeImpl::surroundContents): Simplified by calling containedByReadOnly.
11:51 AM Changeset in webkit [7606] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • khtml/rendering/render_replaced.cpp: (RenderWidget::setSelectionState): Added nil check for the widget.
11:50 AM Changeset in webkit [7605] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3773740> calling addEventListener on a frame that hasn't loaded yet crashes
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Add nil checks for the document. The nil check prevents the crash but there's still a bug here; I filed 3807059 about that.
11:49 AM Changeset in webkit [7604] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed problem where up and down arrow keys are not preserving X position
  • khtml/khtml_part.cpp: (KHTMLPart::selectionLayoutChanged): Moved code to clear m_xPosForVerticalArrowNavigation out of here. (KHTMLPart::notifySelectionChanged): Moved it into here.
11:48 AM Changeset in webkit [7603] by darin
  • 1 edit in trunk/WebKit/Misc.subproj/WebNSViewExtras.m

Fix filename.

11:47 AM Changeset in webkit [7602] by darin
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • added helper method _web_parentWebView so fewer files need to get at WebFrame private methods
  • Misc.subproj/WebNSViewExtras.h: Added _web_parentWebView.
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebView]): Added.
10:23 AM Changeset in webkit [7601]
  • 24 copies
    3 deletes in tags/WebKit-125~5~2

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~2'.

10:23 AM Changeset in webkit [7600] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebKit
  • versioning for WebKit, WebKit-125.5.2
10:17 AM Changeset in webkit [7599]
  • 71 copies
    2 deletes in tags/WebCore-125~8~9

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~9'.

10:17 AM Changeset in webkit [7598] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • versioning for SUPanNavy, WebCore-125.8.9
10:12 AM Changeset in webkit [7597] by vicki
  • 2 edits in branches/Safari-1-2-branch/WebCore
  • rolled in the fix for 3801256

2004-09-03 Darin Adler <Darin Adler>

Reviewed by Chris.

  • fixed <rdar://problem/3410112> filename with non-ASCII name for <input type=file> should be sent in the page's encoding
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): Encode filename using the codec rather than doing the &# dance. It turns out that Mozilla only does the &# thing under certain circumstances that are not important. Always encoding the filename is almost certainly better behavior, and will fix many serious problems for Japanese and Korean users and websites.

Sep 18, 2004:

6:12 PM Changeset in webkit [7596] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3805627> -[DOMRange _text] sometimes includes all text to the end of the document for certain ranges
  • khtml/misc/khtml_text_operations.cpp: (khtml::TextIterator::advance): Correctly handle the case when we are already on m_endNode. The concept here is that m_endNode is a node you must never "leave" when iterating.

Sep 17, 2004:

12:22 PM Changeset in webkit [7595] by vicki
  • 3 edits in trunk

change version number to 2.0, 165u for TOT

12:06 PM Changeset in webkit [7594]
  • 3 copies in tags/Safari-164

This commit was manufactured by cvs2svn to create tag 'Safari-164'.

12:06 PM Changeset in webkit [7593] by vicki
  • 6 edits in trunk

Safari-164 stamp for everything except WebBrowser. In these projects, CFBundleShortVersionString matches CFBundleVersion (164 for both).

11:10 AM Changeset in webkit [7592] by cblu
  • 2 edits in trunk/WebKit

Fixed:

<rdar://problem/3805757> don't unnecessarily put RTFD on the pasteboard
<rdar://problem/3805756> strip attachments before generating RTF

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): only put RTFD on the pasteboard if it has attachments, strip attachments when writing RTF
9:49 AM Changeset in webkit [7591] by kocienda
  • 2 edits in trunk

Reviewed by me

  • layout-tests/editing/selection/unrendered-004-expected.txt: Updated expected results.
9:44 AM Changeset in webkit [7590] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3780245> REGRESSION (Mail): some lines are skipped when doing arrow navigation

  • khtml/xml/dom_position.cpp: (DOM::Position::previousLinePosition): One-line fix. Make sure that BRs at the end of blocks are not skipped.
9:42 AM Changeset in webkit [7589] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3805594> REGRESSION (Mail): Second return key stroke does not work when first was in blockquote

  • khtml/xml/dom_selection.cpp: (DOM::Selection::toRange): Code to convert caret positions moved the position upstream before making a range-compliant position, but erroneously would allow the position to cross blocks. Now it will no longer do so.

Sep 16, 2004:

5:58 PM Changeset in webkit [7588] by rjw
  • 9 edits in trunk/WebCore

Part 1 of the feature requested in
<rdar://problem/3752791> Dashboard: Need a better solution for control regions

This patch implements the CSS parsing necessary for dashboard regions.
Here's an example of the syntax we support:

<style>
#aDiv {

-apple-dashboard-region:

dashboard-region-circle(control 0 0 80 0)
dashboard-region-rectangle(control,20,0,20,0)
dashboard-region-circle(control 80 0 0 0);

}
</style>

Part 2 will determine the appropriate regions.

Reviewed by Chris.

  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
  • khtml/css/css_valueimpl.h: (DOM::CSSPrimitiveValueImpl::): (DOM::DashboardRegionImpl::DashboardRegionImpl): (DOM::DashboardRegionImpl::~DashboardRegionImpl): (DOM::DashboardRegionImpl::setNext): (DOM::DashboardRegionImpl::setLabel):
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseContent): (skipCommaInDashboardRegion): (CSSParser::parseDashboardRegions):
  • khtml/css/cssparser.h:
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/dom/css_value.h: (DOM::CSSPrimitiveValue::):
4:45 PM Changeset in webkit [7587] by darin
  • 4 edits in trunk/WebCore
  • fixed caret-drawing regression from my last patch
  • khtml/xml/dom_selection.cpp: (DOM::Selection::xPosForVerticalArrowNavigation): Pass false, meaning "vertical line caret" rather than true meaning "big box for overtyping". (DOM::Selection::layoutCaret): Ditto.
4:09 PM Changeset in webkit [7586] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/3804648> 8A262: Safari crashed in -[WebView(WebPrivate) _editingDelegateForwarder] inside QuickTime Cocoa Plug-in during WebView deallocation
  • WebView.subproj/WebView.m: (-[WebView _editingDelegateForwarder]): Check _private for nil before dereferencing it.
3:24 PM Changeset in webkit [7585] by darin
  • 18 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3803280> crash in selectAll on page with no contents
  • khtml/khtml_part.cpp: (KHTMLPart::selectAll): Handle case of 0 for documentElement().
  • khtml/xml/dom_position.cpp: (DOM::Position::previousWordPosition): Ditto. (DOM::Position::nextWordPosition): Ditto.
  • cleaned up caret code
  • changed DOM::Selection to use CaretPosition more
  • khtml/rendering/render_box.cpp: (RenderBox::caretRect): Change to use empty rectangles instead of an X value of -1 to mean no rectangle.
  • khtml/rendering/render_image.cpp: (RenderImage::selectionRect): Take advantage of the fixed QRect constructor.
  • khtml/rendering/render_object.cpp: (RenderObject::caretRect): Change to use empty rectangle instead of an X value of -1 to mean no rectangle.
  • khtml/rendering/render_text.cpp: (RenderText::caretRect): Cleaned up, and changed to use an empty rectangle instead of an X value of -1 to mean no rectangle.
  • khtml/xml/dom_caretposition.h: Made conversion from Position to CaretPosition something you can do implicitly, since it's an unambiguous conversion. Conversion in the other direction needs to be done explicitly. Moved EIncludeLineBreak here, and added startParagraphBoundary and endParagraphBoundary functions.
  • khtml/xml/dom_caretposition.cpp: (DOM::startParagraphBoundary): Added. Replaces, and made from, member function of DOM::Position. (DOM::endParagraphBoundary): Ditto.
  • khtml/xml/dom_position.h: Removed EIncludeLineBreak and startParagraphBoundary and endParagraphBoundary.
  • khtml/xml/dom_position.cpp: Removed startParagraphBoundary and endParagraphBoundary.
  • khtml/xml/dom_selection.h: Use CaretPosition instead of Position in a few places. Use a QRect for the caret rect. Change nodeIsBeforeNode to be a static member function.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::Selection): Change caret to store QRect instead of 3 separate fields. (DOM::Selection::init): Ditto. (DOM::Selection::operator=): Ditto. (DOM::Selection::modifyExtendingRightForward): Change to use CaretPosition instead of Position. Check for 0. (DOM::Selection::modifyMovingRightForward): Ditto. Check for 0. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::modify): Ditto. (DOM::Selection::layoutCaret): Change to use a QRect for the caret rect, and use an empty one to mean no rectangle. (DOM::Selection::getRepaintRect): Ditto. (DOM::Selection::paintCaret): Ditto. (DOM::Selection::validate): Change to use CaretPosition instead of Position. Also fixed PARAGRAPH_BOUNDARY, which was broken and doing the same thing as PARAGRAPH before, but it's not really used so that didn't matter. Check for 0. (DOM::Selection::nodeIsBeforeNode): Tightened up a bit and added some FIXMEs. This function has a number of problems and should probably be discarded in favor of the DOMStringImpl method that does the same thing.
2:16 PM Changeset in webkit [7584] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3787168> REGRESSION (Mail): Deleting text from the beginning of a quoted range removes the quoting from the rest

  • khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::moveNodesAfterNode): Only move the text nodes (and their siblings) when doing this move between blocks. This serves to mimic NSText behavior very well.
11:38 AM Changeset in webkit [7583] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3779150> REGRESSION: images not copied when copying HTML in Safari and pasting into TextEdit

Reviewed by john.

  • WebView.subproj/WebHTMLView.m:
(-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): use …
for RTFD
  • WebView.subproj/WebHTMLViewPrivate.h:
Note: See TracTimeline for information about the timeline view.