Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 1, 2004:

10:25 AM Changeset in webkit [7746] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken (or arguably done by Ken, reviewed by Darin).

• fixed <rdar://problem/3823828> REGRESSION (Mail): Clicking past end of any line puts insertion point at beginning of next line

• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): Check for an offset of 0 and a <br> and use UPSTREAM affinity in that case. This is a short term fix for something that needs a better longer-term fix.

• fixed <rdar://problem/3823816> REGRESSION (Mail): double-clicking first word on line also selects previous empty line

• khtml/editing/visible_units.cpp: (khtml::previousWordBoundary): Added a special case for <br>. While I'm not sure why this regressed, I'm sure this fix is good.

8:18 AM Changeset in webkit [7745] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3782117> CrashTracer: ..722 crashes at com.apple.WebCore: DOM::HTMLBodyElementImpl::insertedIntoDocument + 0x2c (AOL website)

• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): Check for nil document case. (HTMLFrameElementImpl::isURLAllowed): Ditto. (HTMLFrameElementImpl::openURL): Ditto.

1:02 AM Changeset in webkit [7744] by darin

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3822218> REGRESSION (164-165): images don't update on rollover on directv.com page

I introduced a major regression where various JavaScript window properties would not be found when I
fixed bug 3809600.

• khtml/ecma/kjs_window.h: Added hasProperty.
• khtml/ecma/kjs_window.cpp: (Window::hasProperty): Return true in all the cases where get returns something.

Sep 30, 2004:

11:43 PM Changeset in webkit [7743] by darin

• 5 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/3461499> JavaScript function document.open() is buggy with 2nd argument "replace"

Experiments with Firefox indicate that document.open() should not be treated as window.open() unless there
are more than two parameters. Also, Firefox does not implement the "replace" behavior, so we don't have
to worry about it either.

• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): Only forward to window if there are more than two parameters, rather than if there are more than one.

• fixed <rdar://problem/3672933> oninput is firing at page load time for <input type=range>

• kwq/KWQSlider.mm: (QSlider::setValue): Don't emit a signal here. This follows the usual pattern, where a signal is only emitted for changes that are not explicitly requested by the caller.

• fixed <rdar://problem/3821167> leaks of something allocated by recalcStyle after loading altavista page from cvs-base

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Ref and deref the style we allocate so it's not left floating if setStyle decides not to ref it.

• fixed <rdar://problem/3821172> leak of HTML attribute string after loading the ESPN page from cvs-base

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Use the DOMString version of the lower() operation so we don't end up leaving a DOMStringImpl * floating if AtomicString decides not to ref it.

5:24 PM Changeset in webkit [7742] by rjw

• 15 edits in trunk

WebKit:

Fixed <rdar://problem/3821215> NPN hasMethod and hasProperty functions should take NPObjects, not NPClass

Also changed dashboard regions dictionary to use "control"
for scroller region label, instead of "scroller, per
request from ouch.

Reviewed by Chris.

• Plugins.subproj/npruntime.h:
• WebView.subproj/WebView.m: (-[WebView _addScrollerDashboardRegions:from:]):

JavaScriptCore:

Fixed <rdar://problem/3821215> NPN hasMethod and hasProperty functions should take NPObjects, not NPClass

Reviewed by Chris.

• bindings/NP_jsobject.cpp: (_NPN_GetProperty): (_NPN_HasProperty): (_NPN_HasMethod):
• bindings/c/c_class.cpp: (CClass::methodsNamed): (CClass::fieldNamed):
• bindings/c/c_class.h:
• bindings/c/c_instance.cpp: (CInstance::invokeMethod):
• bindings/jni/jni_class.cpp: (JavaClass::methodsNamed):
• bindings/jni/jni_class.h:
• bindings/npruntime.h:
• bindings/objc/objc_class.h:
• bindings/objc/objc_class.mm: (ObjcClass::methodsNamed):
• bindings/runtime.h:
• bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::hasProperty):

5:18 PM Changeset in webkit [7741] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3498680> switching back and forth between tabs stops calling anything in a plug-in

Reviewed by darin.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): call setWindowIfNecessary because the window may have changed (-[WebBaseNetscapePluginView updateAndSetWindow]): new (-[WebBaseNetscapePluginView setWindowIfNecessary]): was setWindow, this method now just sets the window (-[WebBaseNetscapePluginView start]): call updateAndSetWindow (-[WebBaseNetscapePluginView viewDidMoveToWindow]): ditto (-[WebBaseNetscapePluginView viewHasMoved:]): ditto

4:14 PM Changeset in webkit [7740] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/3498668> switching out of tab doesn't send loseFocusEvent to plug-in

Reviewed by rjw.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setHasFocus:]): new, sends events to plug-in (-[WebBaseNetscapePluginView becomeFirstResponder]): call setHasFocus (-[WebBaseNetscapePluginView resignFirstResponder]): ditto (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): ditto

1:04 PM Changeset in webkit [7739] by rjw

• 2 edits in trunk/WebCore

Fixed <rdar://problem/3822330> REGRESSION: crash on launch when homepage is set to about:blank

Added nil check.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes):

12:48 PM Changeset in webkit [7738] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3792822> Safari is calling the Cocoa QuickTime plugin twice for the OBJECT and EMBED tags

Reviewed by hyatt.

• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): call dispatchHTMLEvent after updateWidget instead of every time this method is called (HTMLObjectElementImpl::recalcStyle): ditto

11:56 AM Changeset in webkit [7737] by darin

• 2 edits in trunk/WebCore

• rolled out bad image change that caused performance regression

• khtml/rendering/render_image.cpp: (RenderImage::setPixmap): Don't reference the new image before doing the assignment. This forced an unwanted.

10:52 AM Changeset in webkit [7736] by cblu

• 6 edits in trunk/WebKit

Fixed:
Assertion failure when loading standalone netscape plug-in content.
Document loads of WebKit plug-in content should be cancelled since the plug-in does its own loading.

Reviewed by john.

• Misc.subproj/WebKitErrors.m: removed deprecated method
• Misc.subproj/WebKitErrorsPrivate.h:
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): fixed the assertion statement
• Plugins.subproj/WebPluginDocumentView.h:
• Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): remove retained plug-in (-[WebPluginDocumentView setDataSource:]): retain the plug-in, cancel the laod

9:59 AM Changeset in webkit [7735] by kocienda

• 3 edits in trunk/WebCore

Reviewed by me, coded by Darin

• fixed <rdar://problem/3818305> REGRESSION (Mail): Shift + page up has no effect; should modify selection

• khtml/editing/selection.cpp: (khtml::Selection::modify): Fix problem where vertical distance was used as a distance threshold, but was a negative number. Now make it positive at the start of the function (and make a couple related changes).

Sep 29, 2004:

6:32 PM Changeset in webkit [7734] by cblu

• 24 edits
  2 adds in trunk/WebKit

Fixed:
<rdar://problem/3763832> Safari-155: Non-Embeded movies fail to open in Cocoa QT plug-in
<rdar://problem/3820517> "* -[WebPluginPackage NPP_New]: selector not recognized [self = 0x5552c10]"

Reviewed by rjw.

• History.subproj/WebHistoryItem.m:
• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_firstResponderCausesFocusDisplay]): (-[NSView _webView]): (-[NSView _frame]): (-[NSView _bridge]): (-[NSView _dataSource]):
• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage hash]): (-[WebBasePluginPackage isQuickTimePlugIn]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginRepresentation.m:
• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithDocumentView:]): (-[WebPluginController addPlugin:]): (-[WebPluginController destroyAllPlugins]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]): (-[WebPluginController webPlugInContainerSelectionColor]): (-[WebPluginController webFrame]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): (-[WebPluginDatabase refresh]): (WebPluginDocumentView::while):
• Plugins.subproj/WebPluginDocumentView.h: Added.
• Plugins.subproj/WebPluginDocumentView.m: Added. (-[WebPluginDocumentView initWithFrame:]): (-[WebPluginDocumentView dealloc]): (-[WebPluginDocumentView drawRect:]): (-[WebPluginDocumentView setDataSource:]): (-[WebPluginDocumentView setNeedsLayout:]): (-[WebPluginDocumentView layout]): (-[WebPluginDocumentView currentWindow]): (-[WebPluginDocumentView viewWillMoveToWindow:]): (-[WebPluginDocumentView viewDidMoveToWindow]): (-[WebPluginDocumentView viewWillMoveToHostWindow:]): (-[WebPluginDocumentView viewDidMoveToHostWindow]): (-[WebPluginDocumentView receivedData:withDataSource:]): (-[WebPluginDocumentView receivedError:withDataSource:]): (-[WebPluginDocumentView finishedLoadingWithDataSource:]): (-[WebPluginDocumentView canProvideDocumentSource]): (-[WebPluginDocumentView documentSource]): (-[WebPluginDocumentView title]):
• Plugins.subproj/npapi.m: (NPN_ReleaseVariantValue): (NPN_GetStringIdentifier): (NPN_GetStringIdentifiers): (NPN_GetIntIdentifier): (NPN_IdentifierIsString): (NPN_UTF8FromIdentifier): (NPN_IntFromIdentifier): (NPN_CreateObject): (NPN_RetainObject): (NPN_ReleaseObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_Evaluate): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty): (NPN_HasProperty): (NPN_HasMethod): (NPN_SetException): (NPN_Call):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:URL:]):
• WebCoreSupport.subproj/WebViewFactory.m:
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDebugDOMNode.m:
• WebView.subproj/WebDocumentInternal.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebImageRepresentation.h:
• WebView.subproj/WebRenderNode.m:
• WebView.subproj/WebView.m:

6:32 PM Changeset in webkit [7733] by cblu

• 8 edits
  1 add in trunk/JavaScriptCore

Prepended underscores to NPN methods so that when the QT plug-in loads these symbols, it uses the non-underscore versions in WebKit. Without this, the QT plug-in was failing to load when launching Safari from the command-line.

Reviewed by rjw.

• JavaScriptCore.pbproj/project.pbxproj:
• bindings/NP_jsobject.cpp: (_NPN_CreateScriptObject): (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
• bindings/c/c_class.cpp: (CClass::methodsNamed): (CClass::fieldNamed):
• bindings/c/c_instance.cpp: (CInstance::CInstance): (CInstance::~CInstance): (CInstance::operator=): (CInstance::invokeMethod): (CInstance::invokeDefaultMethod):
• bindings/c/c_runtime.cpp:
• bindings/c/c_runtime.h: (KJS::Bindings::CField::name): (KJS::Bindings::CMethod::name):
• bindings/npruntime.cpp: (_NPN_GetStringIdentifier): (_NPN_GetStringIdentifiers): (_NPN_GetIntIdentifier): (_NPN_IdentifierIsString): (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier): (NPN_InitializeVariantWithObject): (_NPN_ReleaseVariantValue): (_NPN_CreateObject): (_NPN_RetainObject): (_NPN_ReleaseObject): (_NPN_SetExceptionWithUTF8): (_NPN_SetException):

5:39 PM Changeset in webkit [7732] by rjw

• 8 edits in trunk

WebKit:

Fixed <rdar://problem/3779998> bringing window to front or sending to back does not send focus/blur events to JavaScript window object

The fix has two parts, 1) make onblur and onfocus work for windows,
and 2), allow the dashboard to override WebKit's special key/non-key
behaviors.

Reviewed by Maciej.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView addMouseMovedObserver]): (-[WebHTMLView removeMouseMovedObserver]):
• WebView.subproj/WebView.m: (-[WebView _dashboardBehavior:]):
• WebView.subproj/WebViewInternal.h:
• WebView.subproj/WebViewPrivate.h:

WebCore:

Fixed <rdar://problem/3779998> bringing window to front or sending to back does not send focus/blur events to JavaScript window object

The fix has two parts, 1) make onblur and onfocus work for windows,
and 2), allow the dashboard to override WebKit's special key/non-key
behaviors.

Reviewed by Chris.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes):

2:55 PM Changeset in webkit [7731] by kocienda

• 13 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3705894> REGRESSION (Mail): if a single word is wider than the window,
it doesn't break and just runs off the right side

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Add support for CSS_PROP_WORD_WRAP.
• khtml/css/cssparser.cpp: (CSSParser::parseValue): Ditto.
• khtml/css/cssproperties.c: Generated file.
• khtml/css/cssproperties.h: Ditto.
• khtml/css/cssproperties.in: Add word-wrap property.
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Add support for CSS_PROP_WORD_WRAP.
• khtml/css/cssvalues.c: Generated file.
• khtml/css/cssvalues.h: Ditto.
• khtml/css/cssvalues.in: Add break-word value.
• khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Add code to implement new word wrapping feature.
• khtml/rendering/render_style.cpp: (StyleCSS3InheritedData): Add support for new wordWrap property. (StyleCSS3InheritedData::operator==): Ditto. (RenderStyle::diff): Ditto.
• khtml/rendering/render_style.h: (khtml::RenderStyle::wordWrap): Ditto. (khtml::RenderStyle::setWordWrap): Ditto. (khtml::RenderStyle::initialWordWrap): Ditto.

1:40 PM Changeset in webkit [7730] by mjs

• 24 edits in trunk

WebCore:

Reviewed by John.

• consolidated OS version checks into prefix header

• WebCorePrefix.h:
• khtml/rendering/render_canvasimage.cpp:
• kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityActionDescription:]):
• kwq/KWQComboBox.mm: (QComboBox::QComboBox):
• kwq/KWQFoundationExtras.h:

WebKit:

Reviewed by John.

• consolidated OS version checks into prefix header

• Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase _createLRUList:]): (+[WebFileDatabase _syncLoop:]):
• Misc.subproj/WebKitErrors.m: (registerErrors):
• Misc.subproj/WebNSObjectExtras.h: (WebNSRetainCFRelease):
• Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
• Misc.subproj/WebUnicode.m: (_unicodeDirection):
• WebCoreSupport.subproj/WebImageData.h:
• WebCoreSupport.subproj/WebImageRenderer.h:
• WebCoreSupport.subproj/WebKeyGenerator.h:
• WebCoreSupport.subproj/WebNewKeyGeneration.c:
• WebKitPrefix.h:
• WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]): (-[WebDataSource isLoading]):
• WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebPDFRepresentation.h:
• WebView.subproj/WebPDFRepresentation.m:
• WebView.subproj/WebPDFView.h:
• WebView.subproj/WebPDFView.m:

WebBrowser:

Reviewed by John.

• consolidated OS version checks into prefix header

• AddressBarContentsManager.h:
• AddressBarContentsManager.m:
• AddressBarController.m:
• AppController.m: (-[AppController applicationDidFinishLaunching:]):
• BookmarkCollections.m:
• BookmarksController.h:
• BookmarksController.m:
• BookmarksViewController.m:
• BrowserDocument.h:
• BrowserDocument.m:
• BrowserDocumentController.h:
• BrowserDocumentController.m:
• BrowserNSNetServiceExtras.m:
• BrowserWebBookmarkExtras.m:
• BrowserWebController.m:
• BrowserWebViewPrinting.m:
• BrowserWindow.m: (-[BrowserWindow performKeyEquivalent:]):
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController locationField]): (-[BrowserWindowController searchField]): (-[BrowserWindowController locationBarIsShowing]): (-[BrowserWindowController setUpLocationBar]): (-[BrowserWindowController isShowingBar:]): (-[BrowserWindowController updateKeyboardLoop]): (-[BrowserWindowController windowDidLoad]): (-[BrowserWindowController dealloc]): (-[BrowserWindowController setDocument:]): (-[BrowserWindowController showLocationBarTemporarilyIfHidden]): (-[BrowserWindowController makeLocationBarPermanentIfTemporary]): (-[BrowserWindowController hideLocationBarIfTemporary]): (-[BrowserWindowController selectSearchField:]): (-[BrowserWindowController canShowInputFields]): (-[BrowserWindowController updateStopAndReloadButton]): (-[BrowserWindowController toggleLocationBar:]): (-[BrowserWindowController setToolbarsVisible:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController fixFocusRingAroundLocationField]): (-[BrowserWindowController validateMenuItem:]): (-[BrowserWindowController showWindow:]):
• ContextMenuHandler.m:
• Debug/DebugUtilities.m:
• DownloadProgressEntry.m: (-[NSFileManager setMetadataURL:referrer:atPath:]):
• InternetConfigUtilities.m:
• LoadProgressMonitor.m:
• LocationChangeError.m:
• NetworkController.h:
• NetworkController.m:
• OutlineViewPlus.h:
• OutlineViewPlus.m:
• Preferences.subproj/ISyncController.h:
• Preferences.subproj/RSSPreferences.h:
• Preferences.subproj/RSSPreferences.m:
• Preferences.subproj/SecurityPreferences.m:
• Preferences.subproj/WBPreferences.m:
• PrintingAccessoryViewController.m:
• SyndicationController.m:
• TableViewPlus.m:
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner setSingleTestURL:]):
• ToolbarController.h:
• ToolbarController.m:
• WebBookmark.h:
• WebBookmark.m:
• WebBookmarkGroup.h:
• WebBookmarkGroup.m:
• WebBookmarkGroupPrivate.h:
• WebBookmarkLeaf.m:
• WebBookmarkList.m:
• WebBookmarkPrivate.h:
• WebBrowserPrefix.h:

11:07 AM Changeset in webkit [7729] by hyatt

• 11 edits in trunk/LayoutTests/fast

Fix remaining fast tests to handle br changes.

11:05 AM Changeset in webkit [7728] by hyatt

• 1 edit in trunk/LayoutTests/fast/block/positioning/055-expected.txt

Fix positioning tests to account for br changes.

11:04 AM Changeset in webkit [7727] by hyatt

• 1 edit in trunk/LayoutTests/fast/block/float/015-expected.txt

Fix float 15 test to accurately reflect the image loading regression in that test.

11:02 AM Changeset in webkit [7726] by hyatt

• 4 edits in trunk/LayoutTests/fast/block/float

Fix float tests to account for br changes.

11:01 AM Changeset in webkit [7725] by hyatt

• 2 edits in trunk/LayoutTests/fast/doctypes

Fix doctypes tests for list item changes.

10:59 AM Changeset in webkit [7724] by hyatt

• 3 edits in trunk/LayoutTests/css1

Land changes to CSS1 suite from <br> patch.

10:58 AM Changeset in webkit [7723] by hyatt

• 14 edits in trunk/LayoutTests/editing

Land changes to editing test from <br> patch.

10:55 AM Changeset in webkit [7722] by hyatt

• 10 edits in trunk/WebCore

Make sure <br>s always get line boxes. Also prevent the creation of RenderTexts for whitespace normal/nowrap nodes
that follow <br>s.

Reviewed by kocienda

• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::isCandidate):
• khtml/rendering/render_br.cpp: (RenderBR::RenderBR): (RenderBR::createInlineBox): (RenderBR::baselinePosition): (RenderBR::lineHeight):
• khtml/rendering/render_br.h:
• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::placeBoxesVertically):
• khtml/rendering/render_line.h: (khtml::InlineBox::isText): (khtml::InlineFlowBox::addToLine):
• khtml/rendering/render_text.cpp: (RenderText::detach):
• khtml/rendering/render_text.h: (khtml::InlineTextBox:::InlineRunBox): (khtml::InlineTextBox::isInlineTextBox): (khtml::InlineTextBox::isText): (khtml::InlineTextBox::setIsText):
• khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
• kwq/KWQRenderTreeDebug.cpp: (operator<<):

10:51 AM Changeset in webkit [7721] by kocienda

• 7 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3815895> exception inside fontForSelection causes Mail to abort when selection hits bottom

• khtml/editing/selection.cpp: (khtml::Selection::toRange): Use RangeImpl calls to detect exceptions when creating a Range from a Selection. Return an empty Range when there is an exception.

Fix for this bug:

<rdar://problem/3817268> REGRESSION (Mail): Window does not scroll when selecting out of
visible area of view with arrow keys

• khtml/editing/selection.cpp: Did some name changing. m_needsCaretLayout -> m_needsLayout. Added m_expectedVisibleRect which supplies the right rectangle to update when scrolling. (khtml::Selection::Selection): m_needsCaretLayout -> m_needsLayout name change. (khtml::Selection::init): Handle m_expectedVisibleRect in initialization. (khtml::Selection::operator=): Handle m_expectedVisibleRect in assignment. (khtml::Selection::setNeedsLayout): m_needsCaretLayout -> m_needsLayout name change. (khtml::Selection::layout): Changed name from layoutCaret, since m_expectedVisibleRect is also calculated here. (khtml::Selection::caretRect): m_needsCaretLayout -> m_needsLayout name change. (khtml::Selection::expectedVisibleRect): New. Returns m_expectedVisibleRect, doing a layout if needed. (khtml::Selection::needsCaretRepaint): m_needsCaretLayout -> m_needsLayout name change. (khtml::Selection::paintCaret): Ditto. (khtml::Selection::validate): Ditto.
• khtml/editing/selection.h: Add m_expectedVisibleRect member variable and expectedVisibleRect accessor.
• kwq/WebCoreBridge.h: Change name of ensureCaretVisible to ensureSelectionVisible, since this is not only about making the caret visible anymore. Now it can reveal the varying end of the selection when scrolling with arrow keys.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): ensureCaretVisible to ensureSelectionVisible name change. (-[WebCoreBridge alterCurrentSelection:verticalDistance:]): Ditto (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:smartReplace:]): Ditto (-[WebCoreBridge insertNewline]): Ditto (-[WebCoreBridge insertText:selectInsertedText:]): Ditto (-[WebCoreBridge deleteKeyPressed]): Ditto (-[WebCoreBridge ensureSelectionVisible]): Ditto

7:16 AM Changeset in webkit [7720] by kocienda

• 11 edits in trunk

WebCore:

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3818296> REGRESSION (Mail): centerSelectionInVisibleArea does not work correctly

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::centerSelectionInVisibleArea): New function. Handles both caret and range selections correctly.
• kwq/KWQNSViewExtras.h: Add forceCentering boolean to some methods in this file.
• kwq/KWQNSViewExtras.m: Ditto. This addition has been done since the AppKit method we use to do the centering, -[NSView scrollRectToVisible:], does not alter the view if the rectangle passed to it is already in view. When forceCentering is true, extra math is done to make scrollRectToVisible center the rectangle we want. (-[NSView _KWQ_scrollFrameToVisible]): Pass NO for forceCentering in call through to _KWQ_scrollRectToVisible:forceCentering: (-[NSView _KWQ_scrollRectToVisible:forceCentering:]): Add forceCentering argument. (-[NSView _KWQ_scrollRectToVisible:inView:forceCentering:]): Ditto. (-[NSClipView _KWQ_scrollRectToVisible:inView:forceCentering:]): Ditto. Do extra math to implement the forceCentering effect.
• kwq/KWQScrollView.h: Add forceCentering default argument to ensureRectVisibleCentered.
• kwq/KWQScrollView.mm: (QScrollView::ensureRectVisibleCentered): Ditto.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge centerSelectionInVisibleArea]): New function. Call through to KWQKHTMLPart.

WebKit:

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3818296> REGRESSION (Mail): centerSelectionInVisibleArea does not work correctly

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView centerSelectionInVisibleArea:]): Now calls new centerSelectionInVisibleArea bridge function instead of ensureCaretVisible. Now handles caret selections and range selections correctly.

Sep 28, 2004:

6:54 PM Changeset in webkit [7719] by rjw

• 1 edit in branches/Safari-1-2-branch/WebKit/ChangeLog

Changed incorrect reference to 3791526 to 3710123.

6:49 PM Changeset in webkit [7718] by rjw

• 2 edits in branches/Safari-1-2-branch/WebKit

Fix for follow on problem to fix for 3791526, in particular:

<rdar://problem/3803113> WebFrame object leaked

We should always call end to guarantee that terminal load delegate
callbacks get sent to WebKit clients. In this case the a cancel message
wasn't sent and Safari's activity monitor was holding onto a reference.

Reviewed by Maciej.

• WebView.subproj/WebDataSource.m: (-[WebDataSource _finishedLoading]):

6:19 PM Changeset in webkit [7717] by cblu

• 2 edits in trunk/WebCore

Fixed: WebArchives begin with "<#document/>"

Reviewed by hyatt.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::startMarkup): don't return markup if this is a document node, forgot this when factoring this method out from toHTML

6:02 PM Changeset in webkit [7716] by cblu

• 5 edits in trunk/WebCore

Removed range parameter from recursive_toHTML and friends since that code path is no longer used.

Reviewed by mjs.

• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toString): (NodeImpl::recursive_toHTML):
• khtml/xml/dom_nodeimpl.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]):

5:34 PM Changeset in webkit [7715] by cblu

• 3 edits in trunk/WebKit

Added timing code so that Doug can time RTF conversion.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebHTMLView _attributeStringFromDOMRange:]):

5:17 PM Changeset in webkit [7714] by darin

• 8 edits in trunk/WebCore

Reviewed by Ken.

• improve spell checking so it doesn't unmark and remark as you move the cursor with the arrow

• khtml/editing/htmlediting.h: Remove obsolete markMisspellingsInSelection private function.
• khtml/editing/htmlediting.cpp: (khtml::EditCommand::EditCommand): Blow away the selection when starting an edit command. (khtml::EditCommand::apply): Remove code to mark misspellings because that's now done as part of blowing away the selection. (khtml::EditCommand::unapply): Blow away the selection instead of marking mispellings. (khtml::EditCommand::reapply): Ditto. (khtml::ReplaceSelectionCommand::doApply): Removed incorrect code that does spell checking on inserted text; this doesn't match NSText behavior. (khtml::TypingCommand::markMisspellingsAfterTyping): Use markMisspellingsInAdjacentWords function for greater clarity on what this actually does.

• khtml/khtml_part.h: Replaced setSelection's "unmarkOldSelection" boolean parameter with a "keepTypingStyle" boolean parameter. Removed notifySelectionChanged.
• khtml/khtml_part.cpp: (KHTMLPart::setSelection): Replaced the "unmarkOldSelection" boolean with a new "keepTypingStyle" boolean. This is a step on the way to simplifying how this works. Moved the code from the notifySelectionChanged function here, since there was no clear line between the two functions. (KHTMLPart::clearSelection): Call setSelection rather that having special case code here for the case of an empty selection. (KHTMLPart::appliedEditing): Remove the explicit "false" for "unmarkOldSelection". (KHTMLPart::unappliedEditing): Ditto. (KHTMLPart::reappliedEditing): Ditto.

• kwq/KWQKHTMLPart.h: Replaced markMisspellingsInSelection and updateSpellChecking with markMisspellings and markMisspellingsInAdjacentWords. Added parameters to respondToChangedSelection.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::markMisspellingsInAdjacentWords): Added. (KWQKHTMLPart::markMisspellings): New name for markMisspellingsInSelection. Simplified logic a bit and made it the caller's responsibility to expand the selection passed in to word boundaries. (KWQKHTMLPart::respondToChangedSelection): Added parameter that identifies the old selection, and changed logic so it won't mark mispellings in a word if the selection still starts in that word.

• implemented empty-cells property in computed style

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added code for CSS_PROP_EMPTY_CELLS. I think the HTML converter in AppKit uses this.

3:55 PM Changeset in webkit [7713] by cblu

• 4 edits in trunk/WebCore

Fixed n-squared issues with appending to KWQValueListImpl. This fixes the hang in 3794799.

Fixed by Darin, reviewed by me.

• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): tweaks
• kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::KWQValueListPrivate::copyList): (KWQValueListImpl::clear): (KWQValueListImpl::appendNode): (KWQValueListImpl::prependNode): (KWQValueListImpl::removeEqualNodes): (KWQValueListImpl::containsEqualNodes): (KWQValueListImpl::removeIterator): (KWQValueListImpl::lastNode):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge nodesFromList:]): use iterator, not at()

1:57 PM Changeset in webkit [7712] by rjw

• 18 edits in trunk

WebCore:

More dashboard region changes for John.

<rdar://problem/3817421> add getter for dashboard regions (debugging)

<rdar://problem/3817417> NSScrollView need autoregions for dashboard

<rdar://problem/3817388> should have short form form control regions

<rdar://problem/3817477> visibility does not work with dashboard control regions

Reviewed by Hyatt.

• WebCore-combined.exp:
• WebCore.exp:
• khtml/css/cssparser.cpp: (skipCommaInDashboardRegion): (CSSParser::parseDashboardRegions):
• khtml/khtmlview.cpp: (KHTMLView::updateDashboardRegions):
• khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::addDashboardRegions):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::setDashboardRegions):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::setDashboardRegionsDirty): (DOM::DocumentImpl::dashboardRegionsDirty):
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::dashboardRegionsDictionary): (KWQKHTMLPart::dashboardRegionsChanged):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge dashboardRegions]):
• kwq/WebDashboardRegion.h:
• kwq/WebDashboardRegion.m: (-[WebDashboardRegion description]):

WebKit:

More dashboard region changes for John.

<rdar://problem/3817421> add getter for dashboard regions (debugging)

<rdar://problem/3817417> NSScrollView need autoregions for dashboard
Also KWQScrollBars

Reviewed by Hyatt.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dashboardRegionsChanged:]):
• WebView.subproj/WebView.m: (-[WebView _setInitiatedDrag:]): (-[WebView _addScrollerDashboardRegions:from:]): (-[WebView _addScrollerDashboardRegions:]): (-[WebView _dashboardRegions]):
• WebView.subproj/WebViewPrivate.h:

1:07 PM Changeset in webkit [7711] by sullivan

• 2 edits in trunk/LayoutTests/fast/tokenizer

Updated the output of the script type test for more clarity; updated the expected results too.

11:55 AM Changeset in webkit [7710] by sullivan

• 3 edits in trunk

Reviewed by Chris.

• fixed <rdar://problem/3818558> REGRESSION: "Installed Plug-ins" is blank because of <script type="application/x-javascript">

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): add "application/x-javascript" to the list of legal scripting types. Mozilla accepts this, but WinIE doesn't.

• layout-tests/fast/tokenizer/004.html: updated layout test to test some application/xxxx types

11:33 AM Changeset in webkit [7709] by hyatt

• 2 adds in trunk/LayoutTests/fast/lists

New list results.

11:32 AM Changeset in webkit [7708] by hyatt

• 9 edits in trunk/WebCore

Reworked lists to work well with RTL text. Specifically the following bugs have been fixed:

(1) All bullets use the same offset constant now (a padding of 7 pixels). Before, images used 5 and others used 7.
(2) Line height now works properly, so that list items with no content aren't squished (and missing the line descent).
(3) Punctuation now works correctly with inside and outside style ordered lists in RTL.
(4) RTL lists now properly apply padding and margin to the right side rather than the left. This was done by adding
-khtml-margin-start and -khtml-padding-start properties that are just mapped to left/right based off the direction.

Reviewed by darin

• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssproperties.c: (hash_prop): (findProp):
• khtml/css/cssproperties.h:
• khtml/css/cssproperties.in:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty):
• khtml/css/html4.css:
• khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):
• khtml/rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth): (RenderListMarker::lineHeight): (RenderListMarker::baselinePosition):

11:29 AM Changeset in webkit [7707] by hyatt

• 3 edits in trunk/LayoutTests/fast/lists

List layout test changes.

11:24 AM Changeset in webkit [7706] by kocienda

• 6 edits in trunk/WebCore

Reviewed by Darin

Mark the VisiblePosition taking (Position &, EAffinity=DOWNSTREAM) explicit. Recently, when I added
the EAffinity argument, I left this constructor implicit. Darin pointed out to me that this is
undesirable since implicit use of the the constructor involved making the affinity choice, something
which should be done explicitly.

• khtml/editing/selection.cpp: (khtml::Selection::modifyExtendingRightForward): Make explicit use of constructor mentioned above. (khtml::Selection::modifyMovingRightForward): Ditto. (khtml::Selection::modifyExtendingLeftBackward): Ditto. (khtml::Selection::modifyMovingLeftBackward): Ditto. (khtml::Selection::modify): Ditto. (khtml::Selection::validate): Ditto.
• khtml/editing/visible_position.h: Make constructor taking (Position &, EAffinity) explicit.
• khtml/editing/visible_units.cpp: Ditto. (khtml::previousWordBoundary): Make explicit use of constructor mentioned above. (khtml::nextWordBoundary): Ditto. (khtml::previousLinePosition): Ditto. (khtml::nextLinePosition): Ditto.
• kwq/KWQKHTMLPart.mm: Ditto. (KWQKHTMLPart::findString): Ditto. (KWQKHTMLPart::advanceToNextMisspelling): Ditto. (KWQKHTMLPart::markMisspellingsInSelection): Ditto. (KWQKHTMLPart::updateSpellChecking): Ditto.

9:43 AM Changeset in webkit [7705] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed a storage leak discovered by code inspection

• khtml/html/htmlparser.cpp: (KHTMLParser::~KHTMLParser): Call setCurrent(0) to deref the parser's current node in the rare case where it still has one.