Timeline



Oct 10, 2004:

8:14 AM Changeset in webkit [7803] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3777253> Crash in redirect mechanism trying to display error page for bad scheme
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): add retain/autorelease to the request returned from call to super. In this case, the return value was being dealloc'ed before being returned.
8:13 AM Changeset in webkit [7802] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3664375> repro crash in -[KWQAccObject accessibilityAttributeNames]

(-[KWQAccObject accessibilityActionNames]):
check for nil m_renderer

Oct 9, 2004:

4:32 PM Changeset in webkit [7801] by darin
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

  • fixed <rdar://problem/3828147> REGRESSION: textareas with wrap="off" show their contents in a thin vertical line of text
  • kwq/KWQTextArea.h: Added setTextColor and setBackgroundColor methods. This is really for another fix I'm landing later, but it does no harm to add these now.
  • kwq/KWQTextArea.mm: (-[KWQTextArea _configureTextViewForWordWrapMode]): Set the container size after changing the flag that determines if the width tracks the text view. Otherwise, we won't successfully set the width in the case where we don't want it to track the text view. This caused the bug. (-[KWQTextArea _createTextView]): Remove unneeded call to setMaxSize. The above method already does that. (-[KWQTextArea setTextColor:]): Added. (-[KWQTextArea setBackgroundColor:]): Added.
3:44 PM Changeset in webkit [7800] by darin
  • 7 edits in trunk/WebCore

Reviewed by Adele.

  • fixed <rdar://problem/3829452> REGRESSION (156-157): onload handler doesn't run on page with meta refresh of 0 duration (new Apple start page)

The fix for <rdar://problem/3773150> made it so <meta> redirects prevent tokenizing the rest of the page.
This is incorrect; the reason the JavaScript-triggered loads prevent tokenizing is that they take place
"right away" in other browsers, but that is not true of <meta> redirect. We fixed this by using a separate
call for <meta> redirect and not preventing tokenizing when that's in effect.

  • khtml/khtml_part.h: Removed userGesture parameter from scheduleRedirection. Renamed isImmediateRedirectPending to isScheduledLocationChangePending. Added scheduleLocationChange.
  • khtml/khtml_part.cpp: (KHTMLPart::openURL): Updated for new constant name. (KHTMLPart::scheduleRedirection): Removed now-unneeded userGesture parameter, and removed code that does the special case for redirection during load; a <meta> refresh can never be one of those special redirects during a load because it redirects the frame itself, not another frame. Also tightened up the logic by always stopping the redirect timer even if we aren't restarting it. (KHTMLPart::scheduleLocationChange): Added. Like scheduleRedirection, but with a different constant so we can tell it apart and always a delay of 0. The "redirection during load" case was moved in here and renamed to locationChangeScheduledDuringLoad. (KHTMLPart::isScheduledLocationChangePending): Renamed from isImmediateRedirectPending. This now returns true only for location changes and history navigation, not <meta> redirects. (KHTMLPart::scheduleHistoryNavigation): Tightened up logic to do the stop() outside the if as above, and got rid of a silly timer delay computation that always resulted in 0.
  • khtml/khtmlpart_p.h: Added a new value to the RedirectionScheduled enum for scheduleLocationChange and also renamed one of the existing values.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write): Changed to use isScheduledLocationChangePending instead of isImmediateRedirectPending, because we do want to continue tokenizing if it's actually a redirect.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Changed to call the new scheduleLocationChange instead of calling scheduleRedirection with delay of 0.
  • khtml/ecma/kjs_window.cpp: (Window::put): Ditto. (WindowFunc::tryCall): Ditto. (Location::put): Ditto. (LocationFunc::tryCall): Ditto.
3:36 PM Changeset in webkit [7799] by darin
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

  • fixed <rdar://problem/3658277> REGRESSION (1.1-1.2): form submission should either not simulate a click at all or use (0,0) the way Mozilla does
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::click): Use 0,0 for the coordinates.
3:17 PM Changeset in webkit [7798] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Kevin.

  • fixed <rdar://problem/3804661> REGRESSION: JavaScriptCore framework now has two init routines
  • bindings/NP_jsobject.cpp: Fixed unnecessarily-complex globals set up that was creating an init routine.
  • kjs/ustring.cpp: Changed around the UString::Rep::empty construction to not require a global constructor that creates an init routine.
2:46 PM Changeset in webkit [7797] by darin
  • 5 edits in trunk/WebCore

Reviewed by Kevin.

  • fixed <rdar://problem/3804665> REGRESSION: WebCore framework now has many init routines
  • khtml/xml/dom_nodeimpl.h: Changed anyQName declaration to not use the inline function makeId. Surprisingly, the inline function was not "constant-folded" and we ended up with a copy of the function in each file as an init routine for the framework.
  • khtml/ecma/kjs_html.cpp: (Gradient::colorStops): Get rid of initialized ColorStop globals; their constructors were showing up as init routines for the framework.
  • khtml/rendering/render_style.h: Got rid of inline initialDashboardRegions function.
  • khtml/rendering/render_style.cpp: (RenderStyle::initialDashboardRegions): Made this a normal function. When it was an inline function, the constructors for the per-file copies of the globals were showing up as init routines for the framework.
2:39 PM Changeset in webkit [7796] by darin
  • 4 adds in trunk/LayoutTests/fast/js

Added layout test for just-fixed JavaScriptCore bug.

2:30 PM Changeset in webkit [7795] by cblu
  • 2 edits in trunk

Forgot to include that I also fixed <rdar://problem/3397658> scroll wheel does not work to scroll overflow:auto/scroll/overlay areas (RSS)

2:25 PM Changeset in webkit [7794] by cblu
  • 17 edits in trunk

WebCore:

Fixed:
<rdar://problem/3625352> up and down arrow and page up/down keys don't work to scroll overflow:auto/scroll/overlay areas
<rdar://problem/3822027> REGRESSION (Mail): When selection moves out of visible area, should center as NSText does

Reviewed by hyatt, kocienda.

  • khtml/rendering/render_layer.cpp: (RenderLayer::scroll): new
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::scroll): new
  • khtml/rendering/render_object.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollOverflow): new (KWQKHTMLPart::scrollOverflowWithScrollWheelEvent): new (KWQKHTMLPart::khtmlMousePressEvent): store pressed node so we know where the focus is
  • kwq/KWQScrollBar.h:
  • kwq/KWQScrollBar.mm: (QScrollBar::setValue): return a bool (QScrollBar::scrollbarHit): ditto (QScrollBar::scroll): new
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge scrollOverflowInDirection:granularity:]): new (-[WebCoreBridge scrollOverflowWithScrollWheelEvent:]): new (-[WebCoreBridge ensureSelectionVisible]): visually center the extent of the selection

WebKit:

Fixed: <rdar://problem/3625352> up and down arrow and page up/down keys don't work to scroll overflow:auto/scroll/overlay areas

Reviewed by hyatt.

  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream initWithRequestURL:pluginPointer:notifyData:sendNotification:]): fixed typo in comment
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): ditto
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _bridge]): new (-[WebFrameView scrollToBeginningOfDocument:]): call the bridge to scroll, if that fails, scroll the document view (-[WebFrameView scrollToEndOfDocument:]): ditto (-[WebFrameView _pageVertically:]): ditto (-[WebFrameView _pageHorizontally:]): ditto (-[WebFrameView _scrollLineVertically:]): ditto (-[WebFrameView _scrollLineHorizontally:]): ditto
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollWheel:]): call the bridge to scroll, if that fails, pass to next responder
2:22 PM Changeset in webkit [7793] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Kevin.

  • fixed <rdar://problem/3822618> REGRESSION (164-165): expedia.com's popup help doesn't work
  • kjs/reference.cpp: (Reference::putValue): Change so that references not found in any object work with the window object of the page the function is in, not the page of the caller. This is what all other browsers do. This code was hidden before by the "everything is defined on window object" hack in WebCore.

Oct 8, 2004:

3:27 PM Changeset in webkit [7792]
  • 25 copies
    3 deletes in tags/WebKit-125~5~4

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~4'.

3:27 PM Changeset in webkit [7791] by adele
  • 2 edits in branches/Safari-1-2-branch/WebKit

WebKit Versioning for SUPanNavy WebKit-125.5.4

3:18 PM Changeset in webkit [7790]
  • 71 copies
    2 deletes in tags/WebCore-125~8~10

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~10'.

3:18 PM Changeset in webkit [7789] by adele
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore versioning for SUPanNavy, WebCore-125.8.10

Oct 7, 2004:

4:27 PM Changeset in webkit [7788] by adele
  • 12 edits in branches/Safari-1-2-branch

WebCore:

Reviewed by Darin.

Some of this was rolled from HEAD, and some is a new bug fix that we'll do on TOT separately.

  • fixed <rdar://problem/3827035> REGRESSION (Navy): Safari no longer works with Wachovia online banking after logging in
  • fixed <rdar://problem/3830201> REGRESSION (Navy): onload handler doesn't run on page with meta refresh (0 duration) (clone for SUPanNavy)

The fix for <rdar://problem/3773150> made it so we stopped tokenizing once an immediate redirect was pending.
For the Wachovia bug, there was a failing history.go call in the <head>; even though it did not cause any
navigation, it prevented the rest of the page from being loaded. Now we check to see if the requested history
navigation is possible, and if it's not then we continue processing the rest of the page as normal.

Another problem caused by the same fix is that <meta> redirects were preventing tokenizing in the same way.
This is incorrect; the reason the JavaScript-triggered loads prevent tokenizing is that they take place
"right away" in other browsers, but that is not true of <meta> redirect. We fixed this by using a separate
call for <meta> redirect and not preventing tokenizing when that's in effect.

  • khtml/khtml_part.h: Removed userGesture parameter from scheduleRedirection. Renamed isImmediateRedirectPending to isScheduledLocationChangePending. Added scheduleLocationChange.
  • khtml/khtml_part.cpp: (KHTMLPart::openURL): Updated for new constant name. (KHTMLPart::scheduleRedirection): Removed now-unneeded userGesture parameter, and removed code that does the special case for redirection during load; a <meta> refresh can never be one of those special redirects during a load because it redirects the frame itself, not another frame. Also tightened up the logic by always stopping the redirect timer even if we aren't restarting it. (KHTMLPart::scheduleLocationChange): Added. Like scheduleRedirection, but with a different constant so we can tell it apart and always a delay of 0. The "redirection during load" case was moved in here and renamed to locationChangeScheduledDuringLoad. (KHTMLPart::isScheduledLocationChangePending): Renamed from isImmediateRedirectPending. This now returns true only for location changes and history navigation, not <meta> redirects. (KHTMLPart::scheduleHistoryNavigation): Added a check of canGoBackOrForward across bridge so we don't set up a history navigation that will just fail later. This fixes the Wachovia bug. Also tightened up logic to do the stop() outside the if as above, and got rid of a silly timer delay computation that always resulted in 0.
  • khtml/khtmlpart_p.h: Added a new value to the RedirectionScheduled enum for scheduleLocationChange and also renamed one of the existing values.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write): Changed to use isScheduledLocationChangePending instead of isImmediateRedirectPending, because we do want to continue tokenizing if it's actually a redirect.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Changed to call the new scheduleLocationChange instead of calling scheduleRedirection with delay of 0.
  • khtml/ecma/kjs_window.cpp: (Window::put): Ditto. (WindowFunc::tryCall): Ditto. (Location::put): Ditto. (LocationFunc::tryCall): Ditto.
  • kwq/KWQKHTMLPart.h: Added canGoBackOrForward.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canGoBackOrForward): Added. Calls across bridge to do the real work.
  • kwq/WebCoreBridge.h: Added canGoBackOrForward.

WebKit:

Reviewed by Darin.

  • roll in canGoBackOrForward method from HEAD; needed for WebCore bug fix
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canGoBackOrForward:]): Added.
3:05 PM Changeset in webkit [7787] by rjw
  • 1 edit in trunk/JavaScriptCore/kjs/object.cpp

Fixed build error.

2:30 PM Changeset in webkit [7786] by rjw
  • 3 edits in trunk/JavaScriptCore

Added simple JavaScript call tracing. Very useful for
debugging complex pages.

Tracing is only available in development builds and is
enabled by:

(gdb) set traceJavaScript = 1

or programatically

setTraceJavaScript(true)

Function, args, and return values are printed to console. Very
verbose.

Reviewed by Ken.

  • kjs/function_object.cpp: (FunctionProtoFuncImp::call):
  • kjs/object.cpp: (KJS::Object::call):

Oct 6, 2004:

7:03 PM Changeset in webkit [7785] by hyatt
  • 6 edits in trunk/WebCore

Back out style sharing perf fix.

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::locateCousinList): (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::locateSharedStyle):
  • khtml/css/cssstyleselector.h:
  • khtml/html/html_elementimpl.h: (DOM::HTMLElementImpl::inlineStyleDecl):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
  • khtml/xml/dom_elementimpl.h:
4:27 PM Changeset in webkit [7784] by hyatt
  • 1 edit in trunk/WebCore/khtml/css/cssstyleselector.cpp

Really bring the new code in line with the old style sharing code.

9:50 AM Changeset in webkit [7783]
  • 3 copies in tags/Safari-166

This commit was manufactured by cvs2svn to create tag 'Safari-166'.

9:50 AM Changeset in webkit [7782] by vicki
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

reversion JSC, for the -Wno-long-double changes

9:39 AM Changeset in webkit [7781] by vicki
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Add -Wno-long-double back to our warning flags. Without it, the x86 build fails.

Note: See TracTimeline for information about the timeline view.