Timeline



Oct 12, 2004:

5:09 PM Changeset in webkit [7823] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3836158> REGRESSION (Mail): command-right-arrow moves to beginning of next line

  • khtml/editing/selection.cpp: (khtml::endOfLastRunAt): Do not let the end of the last run on a line be a BR. This will make it seem like the run ends on the next line.
4:25 PM Changeset in webkit [7822] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3836986> Delete code removes elements of table structure; can result in very broken-looking web pages

  • khtml/editing/htmlediting.cpp: (khtml::isTableStructureNode): New helper. Determines whether a node is a table cell, row, section, or column. (khtml::CompositeEditCommand::removeFullySelectedNode): New helper that recurses into elements of table structure when doing deletes, rather than deleting the structure elements themselves. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Do not move content between elements of table structure. We may want to revisit this some day, but this seems like the best behavior to me now. (khtml::DeleteSelectionCommand::doApply): Call removeFullySelectedNode instead of removeNode where needed.
  • khtml/editing/htmlediting.h: Add declarations for new functions.
4:24 PM Changeset in webkit [7821] by rjw
  • 4 edits in trunk/WebKit

WebKit:

Fixed <rdar://problem/3829705> Need to remove filling w/ transparency when not drawing backgroundy.

Reviewed by Ken.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _transparentBackground]): (-[WebHTMLView _setTransparentBackground:]): (-[WebHTMLView drawRect:]):
  • WebView.subproj/WebHTMLViewInternal.h:
  • WebView.subproj/WebHTMLViewPrivate.h:

WebBrowser:

As part of fix <rdar://problem/3829705> Need to remove filling w/ transparency when not drawing backgroundy, we can no longer rely on WebHTMLView filling with transparency, so added additional flag to indicate that we should.

  • Debug/DebugUtilities.m: (-[BrowserDocument toggleTransparentWindow:]):
  • LocationChangeHandler.m: Removed #define to prevent console spew.
3:43 PM Changeset in webkit [7820] by rjw
  • 9 edits in trunk

JavaScriptCore

Fixed access to DOM object via WebScriptObject API.
The execution context for DOM objects wasn't being found.
<rdar://problem/3831372> The valueForKey method for @"offsetLeft" on a paragraph element causes a crash.

Reviewed by Chris.

  • bindings/objc/WebScriptObject.mm: (_didExecute): (-[WebScriptObject KJS::Bindings::]): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject stringRepresentation]):
  • bindings/objc/WebScriptObjectPrivate.h:

WebCore:

Fixed access to DOM object via WebScriptObject API.
The execution context for DOM objects wasn't being found.
<rdar://problem/3831372> The valueForKey method for @"offsetLeft" on a paragraph element causes a crash.
Reviewed by Chris

Fixed <rdar://problem/3831063> regions use left offset instead of top offset
Reviewed by John

  • khtml/khtml_part.h:
  • khtml/rendering/render_object.cpp: (RenderObject::addDashboardRegions):
  • kwq/DOM.mm: (-[DOMNode isContentEditable]): (-[DOMNode KJS::Bindings::]):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::executionContextForDOM):

WebBrowser:

Added debugging code (disable) to assist in debugging DOM/WebScriptObjects.

Reviewed by Chris.

  • LocationChangeHandler.m: (-[Logger logMessage:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
3:25 PM Changeset in webkit [7819] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3834779> Mail crashes when editing HTML message - khtml::Selection::layout()

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::styleForSelectionStart): Table code seems to be more robust when the call to insert our style-checking node is done with an appendChild rather than an insertBefore. Note that this table-related problem was exposed by fixing Selection::layout(), which I did yesterday. This change simply improves things even more so that we do not crash in the scenario described in the bug.

Oct 11, 2004:

10:49 AM Changeset in webkit [7818] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by John

This is a partial fix to this bug:

<rdar://problem/3832886> increase quote level on new mail document leads to immediate
crash in caret painting code

To eliminate the bad behavior for good, I have done some investigations in Mail code,
and I have sent a suggested code change on to Grant. Basically, Mail can't add empty
blocks (like blockquote elements used for quoting) to documents without giving those
blocks some content (so they have a height).

I added some other crash protections below.

  • khtml/editing/selection.cpp: (khtml::Selection::layout): Check for non-null position after calls to VisiblePosition, since the VisiblePosition constructors may fail to find a visible spot in the document. Also, add a couple position-has-renderer assertion checks.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::styleForSelectionStart): Take out pos.isNotNull() assertion since VisiblePosition may not yield a position. This assertion is a holdover from before we had VisiblePosition. (KWQKHTMLPart::fontForSelection): Rearrange the code a little to deal with possible null results from calls to helpers.
10:34 AM Changeset in webkit [7817] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3834230> empty table can result in division by 0
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): Added 0 check; rolled in from KDE.
10:20 AM Changeset in webkit [7816] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3802039> 8A259: Can't use Grab services to grab selection from screen

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]): register service "return types" which are types that can be inserted into a WebView (-[WebHTMLView writeSelectionToPasteboard:types:]): service protocol method, be sure to only write specified types (-[WebHTMLView readSelectionFromPasteboard:]): new, service protocol method, insert types (-[WebHTMLView validRequestorForSendType:returnType:]): moved, handle return types
10:13 AM Changeset in webkit [7815] by darin
  • 2 adds in trunk/LayoutTests/fast/forms

Added layout test for <input> value bug I just fixed.

10:10 AM Changeset in webkit [7814] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3818712> form checkbox value property is read only

The underlying problem was that we were storing two separate values for all
form elements; one for the value property (JavaScript) and the other for the
value attribute (DOM). This is a good idea for text input, but not for other types.

  • khtml/html/html_formimpl.h: Changed setValue to take a const DOMString reference. Added private storesValueSeparateFromAttribute function.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::setType): Handle type changes, including detaching and re-attaching if type changed, and moving value from m_value to ATTR_VALUE and vice versa. (DOM::HTMLInputElementImpl::type): Added a case for ISINDEX and moved the default out of the switch so that we will get a warning if a type is left out. (DOM::HTMLInputElementImpl::parseHTMLAttribute): Tweaked comment format. (DOM::HTMLInputElementImpl::reset): Changed to only nuke the value if the value property is stored separately from the attribute. Otherwise, we just want to lave it alone (DOM::HTMLInputElementImpl::value): Changed to always use m_value if it's not null, then fall back on the attribute, and finally fall back to the "on" for the checkbox only if both are null. (DOM::HTMLInputElementImpl::setValue): Changed to set the attribute unless the value property is supposed to be stored separate from the attribute. (DOM::HTMLInputElementImpl::storesValueSeparateFromAttribute): Added. Returns true for text-type input elements, and false for the others.
9:38 AM Changeset in webkit [7813] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/3834130> nil-object-in-dictionary exception seen in -[WebView _elementAtWindowPoint:]
  • WebView.subproj/WebView.m: (-[WebView _elementAtWindowPoint:]): Added a check for nil frame.
9:34 AM Changeset in webkit [7812] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3296652> checkbox input type does not respond to onchange
  • khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement): Some new code, commented out, for form element colors. (RenderCheckBox::slotStateChanged): Added call to onChange.
9:28 AM Changeset in webkit [7811] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/3834166> <input type=file> sends onchange even when the same file is chosen twice
  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton chooseFilename:]): Do nothing if filename is the same as before.
9:04 AM Changeset in webkit [7810] by kocienda
  • 35 edits in trunk

WebCore:

Reviewed by Darin

Finish selection affinity implementation. This includes code to set the
affinity correctly when clicking with the mouse, and clearing the
affinity when altering the selection using any of the Selection object
mutation functions.

Each instance of the positionForCoordinates, inlineBox and caretRect
functions have been changed to include an EAffinity argument to give results
which take this bit into account.

  • khtml/editing/selection.cpp: (khtml::Selection::init): Default affinity is now UPSTREAM, to match AppKit. (khtml::Selection::modifyAffinity): New function to compute affinity based on modification constants. (khtml::Selection::moveTo): Reset affinity to UPSTREAM. (khtml::Selection::modifyExtendingRightForward): Ditto. (khtml::Selection::modifyMovingRightForward): Ditto. (khtml::Selection::modifyExtendingLeftBackward): Ditto. (khtml::Selection::modifyMovingLeftBackward): Ditto. (khtml::Selection::modify): Support saving, restoring, and then calculating new affinity value as needed. (khtml::Selection::xPosForVerticalArrowNavigation): (khtml::Selection::clear): Reset affinity to UPSTREAM. (khtml::Selection::setBase): Ditto. (khtml::Selection::setExtent): Ditto. (khtml::Selection::setBaseAndExtent): Ditto. (khtml::Selection::layout): Pass affinity to caretRect(). (khtml::Selection::validate): Pass along affinity parameter to new functions that require it. (khtml::startOfFirstRunAt): Changed the way that the y-coordinate search is done, to keep this code working with changes made in selectionForLine(). (khtml::endOfLastRunAt): Ditto. (khtml::selectionForLine): Make this function work for all renderers, not just text renderers.
  • khtml/editing/selection.h: (khtml::operator==): Consider affinity in equality check.
  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition): Pass affinity argument to function so it can take this information into account while processing. (khtml::nextLinePosition): Ditto. (khtml::previousParagraphPosition): Ditto. (khtml::nextParagraphPosition): Ditto.
  • khtml/editing/visible_units.h: Ditto, for each of the functions listed.
  • khtml/khtml_events.cpp: (khtml::MouseEvent::offset): Rework code to remove dependence on NodeImpl::positionForCoordinates, as this function is being removed.
  • khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): Ditto. (KHTMLPart::selectClosestWordFromMouseEvent): Ditto. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMousePressEventSingleClick): Ditto. Plus, pass affinity argument in call to positionForCoordinates, and set resulting affinity on the selection. (KHTMLPart::handleMouseMoveEventSelection): Rework code to remove dependence on NodeImpl::positionForCoordinates, as this function is being removed. (KHTMLPart::khtmlMouseReleaseEvent): Ditto.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): Now takes an affinity argument.
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::caretRect): Ditto.
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::positionForCoordinates): Ditto. (RenderBR::caretRect): Ditto. (RenderBR::inlineBox): Ditto.
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates): Ditto.
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect): Ditto.
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::positionForCoordinates): Ditto.
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::caretRect): Ditto. (RenderObject::positionForCoordinates): Ditto. (RenderObject::inlineBox): Ditto.
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates): Ditto.
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Ditto. (firstRendererOnNextLine): New helper used by caretRect(). (RenderText::caretRect): Now takes an affinity argument. (RenderText::inlineBox): Ditto.
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_nodeimpl.cpp: Remove positionForCoordinates helper.
  • khtml/xml/dom_nodeimpl.h: Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::previousLinePosition): Now takes an affinity argument. (DOM::Position::nextLinePosition): Ditto.
  • khtml/xml/dom_position.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge caretRectAtNode:offset:affinity:]): Ditto. (-[WebCoreBridge setSelectedDOMRange:affinity:]): Ditto. (-[WebCoreBridge _positionForPoint:]): Rework code to remove dependence on NodeImpl::positionForCoordinates, as this function is being removed.

WebKit:

Reviewed by Darin

  • WebView.subproj/WebHTMLView.m: (-[WebTextCompleteController doCompletion]): bridge call to get caret rect at a node now takes an affinity: caretRectAtNode:offset:affinity:.
8:17 AM Changeset in webkit [7809] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3670280> scroll position on overflowed textareas resets when leaving the tab
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Scroll to reveal the text area, don't scroll to reveal the text view itself. Scrolling the text view ended up putting it at the top left, regardless of where the insertion point is.
8:08 AM Changeset in webkit [7808] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3831546> More text is copied than is visually selected

The bug here is that upstream was moving a position too far.

  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): Use the "deep equivalent" node rather than the original node passed in for various checks. Also use local variables a bit more for slightly more efficiency. (DOM::Position::downstream): Ditto.
7:58 AM Changeset in webkit [7807] by kocienda
  • 1 edit in trunk/WebKit/ChangeLog

Removed stray conflict marker

7:57 AM Changeset in webkit [7806] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Chris

Fix for this bug:

<rdar://problem/3814236> REGRESSION (Mail): Can't set the color of text in Mail compose window using drag/drag from color panel

  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _insertablePasteboardTypes]): Add NSColorPboardType to list. (-[WebHTMLView _isNSColorDrag:]): New helper. Determines if drag is an NSColor drag. (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Add a case for NSColor drags, else do what we did before. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Add a case for NSColor drags, which creates a CSS style containing color info and calls the bridge to apply the style. Otherwise, do what we did before.
7:55 AM Changeset in webkit [7805] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3833841> adding an event listener for keypress events does not work
  • khtml/xml/dom2_eventsimpl.h: Added numEventIds and made typeToId take a const DOMString &.
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Changed to use table. Added "keypress", otherwise, the same as before. (EventImpl::idToType): Changed to use table.
7:51 AM Changeset in webkit [7804] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3833848> REGRESSION (133-134): each keydown event is getting sent multiple times
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]): Don't send an event through WebCore if it has already been through once.

Oct 10, 2004:

8:14 AM Changeset in webkit [7803] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3777253> Crash in redirect mechanism trying to display error page for bad scheme
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): add retain/autorelease to the request returned from call to super. In this case, the return value was being dealloc'ed before being returned.
8:13 AM Changeset in webkit [7802] by sullivan
  • 2 edits in trunk/WebCore
  • fixed <rdar://problem/3664375> repro crash in -[KWQAccObject accessibilityAttributeNames]

(-[KWQAccObject accessibilityActionNames]):
check for nil m_renderer

Oct 9, 2004:

4:32 PM Changeset in webkit [7801] by darin
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

  • fixed <rdar://problem/3828147> REGRESSION: textareas with wrap="off" show their contents in a thin vertical line of text
  • kwq/KWQTextArea.h: Added setTextColor and setBackgroundColor methods. This is really for another fix I'm landing later, but it does no harm to add these now.
  • kwq/KWQTextArea.mm: (-[KWQTextArea _configureTextViewForWordWrapMode]): Set the container size after changing the flag that determines if the width tracks the text view. Otherwise, we won't successfully set the width in the case where we don't want it to track the text view. This caused the bug. (-[KWQTextArea _createTextView]): Remove unneeded call to setMaxSize. The above method already does that. (-[KWQTextArea setTextColor:]): Added. (-[KWQTextArea setBackgroundColor:]): Added.
3:44 PM Changeset in webkit [7800] by darin
  • 7 edits in trunk/WebCore

Reviewed by Adele.

  • fixed <rdar://problem/3829452> REGRESSION (156-157): onload handler doesn't run on page with meta refresh of 0 duration (new Apple start page)

The fix for <rdar://problem/3773150> made it so <meta> redirects prevent tokenizing the rest of the page.
This is incorrect; the reason the JavaScript-triggered loads prevent tokenizing is that they take place
"right away" in other browsers, but that is not true of <meta> redirect. We fixed this by using a separate
call for <meta> redirect and not preventing tokenizing when that's in effect.

  • khtml/khtml_part.h: Removed userGesture parameter from scheduleRedirection. Renamed isImmediateRedirectPending to isScheduledLocationChangePending. Added scheduleLocationChange.
  • khtml/khtml_part.cpp: (KHTMLPart::openURL): Updated for new constant name. (KHTMLPart::scheduleRedirection): Removed now-unneeded userGesture parameter, and removed code that does the special case for redirection during load; a <meta> refresh can never be one of those special redirects during a load because it redirects the frame itself, not another frame. Also tightened up the logic by always stopping the redirect timer even if we aren't restarting it. (KHTMLPart::scheduleLocationChange): Added. Like scheduleRedirection, but with a different constant so we can tell it apart and always a delay of 0. The "redirection during load" case was moved in here and renamed to locationChangeScheduledDuringLoad. (KHTMLPart::isScheduledLocationChangePending): Renamed from isImmediateRedirectPending. This now returns true only for location changes and history navigation, not <meta> redirects. (KHTMLPart::scheduleHistoryNavigation): Tightened up logic to do the stop() outside the if as above, and got rid of a silly timer delay computation that always resulted in 0.
  • khtml/khtmlpart_p.h: Added a new value to the RedirectionScheduled enum for scheduleLocationChange and also renamed one of the existing values.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write): Changed to use isScheduledLocationChangePending instead of isImmediateRedirectPending, because we do want to continue tokenizing if it's actually a redirect.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Changed to call the new scheduleLocationChange instead of calling scheduleRedirection with delay of 0.
  • khtml/ecma/kjs_window.cpp: (Window::put): Ditto. (WindowFunc::tryCall): Ditto. (Location::put): Ditto. (LocationFunc::tryCall): Ditto.
3:36 PM Changeset in webkit [7799] by darin
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

  • fixed <rdar://problem/3658277> REGRESSION (1.1-1.2): form submission should either not simulate a click at all or use (0,0) the way Mozilla does
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::click): Use 0,0 for the coordinates.
3:17 PM Changeset in webkit [7798] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Kevin.

  • fixed <rdar://problem/3804661> REGRESSION: JavaScriptCore framework now has two init routines
  • bindings/NP_jsobject.cpp: Fixed unnecessarily-complex globals set up that was creating an init routine.
  • kjs/ustring.cpp: Changed around the UString::Rep::empty construction to not require a global constructor that creates an init routine.
2:46 PM Changeset in webkit [7797] by darin
  • 5 edits in trunk/WebCore

Reviewed by Kevin.

  • fixed <rdar://problem/3804665> REGRESSION: WebCore framework now has many init routines
  • khtml/xml/dom_nodeimpl.h: Changed anyQName declaration to not use the inline function makeId. Surprisingly, the inline function was not "constant-folded" and we ended up with a copy of the function in each file as an init routine for the framework.
  • khtml/ecma/kjs_html.cpp: (Gradient::colorStops): Get rid of initialized ColorStop globals; their constructors were showing up as init routines for the framework.
  • khtml/rendering/render_style.h: Got rid of inline initialDashboardRegions function.
  • khtml/rendering/render_style.cpp: (RenderStyle::initialDashboardRegions): Made this a normal function. When it was an inline function, the constructors for the per-file copies of the globals were showing up as init routines for the framework.
2:39 PM Changeset in webkit [7796] by darin
  • 4 adds in trunk/LayoutTests/fast/js

Added layout test for just-fixed JavaScriptCore bug.

2:30 PM Changeset in webkit [7795] by cblu
  • 2 edits in trunk

Forgot to include that I also fixed <rdar://problem/3397658> scroll wheel does not work to scroll overflow:auto/scroll/overlay areas (RSS)

2:25 PM Changeset in webkit [7794] by cblu
  • 17 edits in trunk

WebCore:

Fixed:
<rdar://problem/3625352> up and down arrow and page up/down keys don't work to scroll overflow:auto/scroll/overlay areas
<rdar://problem/3822027> REGRESSION (Mail): When selection moves out of visible area, should center as NSText does

Reviewed by hyatt, kocienda.

  • khtml/rendering/render_layer.cpp: (RenderLayer::scroll): new
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::scroll): new
  • khtml/rendering/render_object.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollOverflow): new (KWQKHTMLPart::scrollOverflowWithScrollWheelEvent): new (KWQKHTMLPart::khtmlMousePressEvent): store pressed node so we know where the focus is
  • kwq/KWQScrollBar.h:
  • kwq/KWQScrollBar.mm: (QScrollBar::setValue): return a bool (QScrollBar::scrollbarHit): ditto (QScrollBar::scroll): new
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge scrollOverflowInDirection:granularity:]): new (-[WebCoreBridge scrollOverflowWithScrollWheelEvent:]): new (-[WebCoreBridge ensureSelectionVisible]): visually center the extent of the selection

WebKit:

Fixed: <rdar://problem/3625352> up and down arrow and page up/down keys don't work to scroll overflow:auto/scroll/overlay areas

Reviewed by hyatt.

  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream initWithRequestURL:pluginPointer:notifyData:sendNotification:]): fixed typo in comment
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): ditto
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _bridge]): new (-[WebFrameView scrollToBeginningOfDocument:]): call the bridge to scroll, if that fails, scroll the document view (-[WebFrameView scrollToEndOfDocument:]): ditto (-[WebFrameView _pageVertically:]): ditto (-[WebFrameView _pageHorizontally:]): ditto (-[WebFrameView _scrollLineVertically:]): ditto (-[WebFrameView _scrollLineHorizontally:]): ditto
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollWheel:]): call the bridge to scroll, if that fails, pass to next responder
2:22 PM Changeset in webkit [7793] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Kevin.

  • fixed <rdar://problem/3822618> REGRESSION (164-165): expedia.com's popup help doesn't work
  • kjs/reference.cpp: (Reference::putValue): Change so that references not found in any object work with the window object of the page the function is in, not the page of the caller. This is what all other browsers do. This code was hidden before by the "everything is defined on window object" hack in WebCore.

Oct 8, 2004:

3:27 PM Changeset in webkit [7792]
  • 25 copies
    3 deletes in tags/WebKit-125~5~4

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~4'.

3:27 PM Changeset in webkit [7791] by adele
  • 2 edits in branches/Safari-1-2-branch/WebKit

WebKit Versioning for SUPanNavy WebKit-125.5.4

3:18 PM Changeset in webkit [7790]
  • 71 copies
    2 deletes in tags/WebCore-125~8~10

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~10'.

3:18 PM Changeset in webkit [7789] by adele
  • 2 edits in branches/Safari-1-2-branch/WebCore

WebCore versioning for SUPanNavy, WebCore-125.8.10

Note: See TracTimeline for information about the timeline view.