Timeline
Oct 14, 2004:
- 5:01 PM Changeset in webkit [7842] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3839989> REGRESSION (Mail): Left arrow does nothing after inserting attachment
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::deepEquivalent): Remove code that attempted to bridge old-style position code to new-style VisiblePosition code. In retrospect, this code was misguided. Since we do a good job of insulating external code from the internal workings of VisiblePosition, the "hop ahead" being done here was not doing anyone any real good, and in the case of this bug, was doing harm. Simply removing this code makes the bug go away and does not cause any editing layout test regresssions.
- 4:51 PM Changeset in webkit [7841] by
-
- 3 edits2 adds in trunk
Reviewed by Hyatt
- khtml/rendering/bidi.cpp: (khtml::skipNonBreakingSpace): New helper. (khtml::RenderBlock::skipWhitespace): Do not skip non-breaking spaces that are at the start of a block. This was preventing users from typing spaces in empty documents.
- layout-tests/editing/inserting/insert-space-in-empty-doc-expected.txt: Added.
- layout-tests/editing/inserting/insert-space-in-empty-doc.html: Added.
- 2:52 PM Changeset in webkit [7840] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin and Ken.
fix for <rdar://problem/3821070> null de-ref in DelectSelectionCommand::doApply()
This change shifts some code around so that the code that determines what typing style
is in effect is called before deleteUnrenderedText is called. Two asserts are also added
to ensure that start and end nodes of the selection are in the document.
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::doApply):
- 2:35 PM Changeset in webkit [7839] by
-
- 4 edits in trunk/WebCore
Reviewed by Ken
This change makes these three functions virtual so that the work is being done in KWQHTMLPart
instead of khtml_part, eliminating the need for the "#if APPLE_CHANGES" statements in the khtml code.
- khtml/khtml_part.cpp: (KHTMLPart::shouldBeginEditing): (KHTMLPart::shouldEndEditing): (KHTMLPart::isContentEditable):
- khtml/khtml_part.h:
- kwq/KWQKHTMLPart.h:
- 1:38 PM Changeset in webkit [7838] by
-
- 10 edits in trunk
WebCore:
Reviewed by John
Final fix for these bugs:
<rdar://problem/3806306> HTML editing puts spaces at start of line
<rdar://problem/3814252> HTML editing groups space with word causing wrapping
This change sets some new CSS properties that have been added to WebCore to
enable whitespace-handling and line-breaking features that make WebView work
more like a text editor.
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Add and remove special editing CSS properties based on property value.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setContentEditable): Add and remove special editing CSS properties based on attribute value.
- khtml/khtml_part.cpp: (KHTMLPart::applyEditingStyleToBodyElement): New helper. Calls applyEditingStyleToElement on body element. (KHTMLPart::removeEditingStyleFromBodyElement): New helper. Calls removeEditingStyleFromElement on body element. (KHTMLPart::applyEditingStyleToElement): Adds special editing CSS properties to passed in element. (KHTMLPart::removeEditingStyleFromElement): Removes special editing CSS properties from passed in element.
- khtml/khtml_part.h: Add new declarations.
- kwq/WebCoreBridge.h: Ditto.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge applyEditingStyleToBodyElement]): Call through to similarly-named function on KHTMLPart. (-[WebCoreBridge removeEditingStyleFromBodyElement]): Ditto. (-[WebCoreBridge applyEditingStyleToElement:]): Ditto. (-[WebCoreBridge removeEditingStyleFromElement:]): Ditto.
WebKit:
Reviewed by John
Final fix for these bugs:
<rdar://problem/3806306> HTML editing puts spaces at start of line
<rdar://problem/3814252> HTML editing groups space with word causing wrapping
This change sets some new CSS properties that have been added to WebCore to
enable whitespace-handling and line-breaking features that make WebView work
more like a text editor.
- WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Turn on special editing CSS properties when loading an HTML document into a WebView that is editable.
- WebView.subproj/WebView.m: (-[WebView setEditable:]): Add and remove special editing CSS properties in current document being displayed.
- 12:51 PM Changeset in webkit [7837] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3840052> Crash in removeBlockPlaceholderIfNeeded attaching file to empty document
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): needed a nil check to handle empty document case
- 10:14 AM Changeset in webkit [7836] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3823026> making isRoundingHackCharacter use -O3 and an 8-bit lookup-table will speed "XBS" test up by 3% (actually < 1%)
Careful testing shows a small performance gain on very large text files.
I saw large variations in timings, but taking the lowest PLT timing
with and without this change showed a 0.9% gain. Note the cvs-base showed
no improvement. The improvement was for the large page attached to the
bug.
Reviewed by Ken.
- WebCoreSupport.subproj/WebTextRenderer.m: (setupRoundingHackCharacterTable): (isRoundingHackCharacter): (+[WebTextRenderer initialize]):
- 7:31 AM Changeset in webkit [7835] by
-
- 2 edits in trunk/WebKit
Reviewed by me
Fix build breakage. These three functions need to return the values from their
calls to WebCGColorSpaceCreateXXX.
- WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge createRGBColorSpace]) (-[WebGraphicsBridge createGrayColorSpace]) (-[WebGraphicsBridge createCMYKColorSpace])
Oct 13, 2004:
- 6:32 PM Changeset in webkit [7834] by
-
- 2 edits in trunk/WebKit
Addressed concerns in <rdar://problem/3803117> RESP: High complexity in icu uidna_IDNToASCII called by [NSString(WebNSURLExtras) _web_mapHostNameWithRange:encode:makeString:]
In practice I saw NO improvement in performance. Although,
special-case tests could possibly show improvement. Anyway,
the changes don't hurt performance.
Reviewed by Maciej.
- Misc.subproj/WebNSURLExtras.m: (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
- 6:26 PM Changeset in webkit [7833] by
-
- 13 edits in trunk
WebCore:
Reviewed by Ken.
<rdar://problem/3824626> Change to do colormatching for DeviceRGB colorspace causes ~11% Safari slowdown
- I fixed this by turning off all colormatching for WebKit content. We might turn it back on later. For now, it's possible to turn it on temporarily by defining COLORMATCH_EVERYTHING.
- WebCorePrefix.h:
- khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): (Context2D::colorRefFromValue): (Gradient::getShading):
- khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::createDrawingContext):
- kwq/KWQColor.mm: (QColor::getNSColor):
- kwq/KWQPainter.h:
- kwq/KWQPainter.mm: (CGColorFromNSColor): (QPainter::selectedTextBackgroundColor): (QPainter::rgbColorSpace): (QPainter::grayColorSpace): (QPainter::cmykColorSpace):
- kwq/WebCoreGraphicsBridge.h:
- kwq/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge createRGBColorSpace]): (-[WebCoreGraphicsBridge createGrayColorSpace]): (-[WebCoreGraphicsBridge createCMYKColorSpace]):
WebKit:
Reviewed by Ken.
<rdar://problem/3824626> Change to do colormatching for DeviceRGB colorspace causes ~11% Safari slowdown
- I fixed this by turning off all colormatching for WebKit content. We might turn it back on later. For now, it's possible to turn it on temporarily by defining COLORMATCH_EVERYTHING.
- WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge setFocusRingStyle:radius:color:]): (-[WebGraphicsBridge additionalPatternPhase]): (-[WebGraphicsBridge createRGBColorSpace]): (-[WebGraphicsBridge createGrayColorSpace]): (-[WebGraphicsBridge createCMYKColorSpace]):
- WebCoreSupport.subproj/WebImageData.m:
- WebCoreSupport.subproj/WebImageRenderer.h:
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _adjustSizeToPixelDimensions]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): (-[WebImageRenderer _adjustColorSpace]): (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): (-[WebImageRenderer tileInRect:fromPoint:context:]): (_createImageRef): (WebCGColorSpaceCreateRGB): (WebCGColorSpaceCreateGray): (WebCGColorSpaceCreateCMYK):
- WebKitPrefix.h:
- 5:10 PM Changeset in webkit [7832] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
- khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::merge): A little cleanup. Also, make sure m_lstValues is non-null before appending.
- 5:05 PM Changeset in webkit [7831] by
-
- 4 edits in trunk
Reviewed by me
Update expected results for improved behavior as a result of fix to 3816768.
- layout-tests/editing/deleting/delete-3775172-fix-expected.txt
- layout-tests/editing/deleting/delete-3800834-fix-expected.txt
- layout-tests/editing/deleting/delete-block-merge-contents-002-expected.txt
- 4:35 PM Changeset in webkit [7830] by
-
- 2 edits in trunk/WebCore
Reviewed by Richard
- khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Add support to computed style for getting -khtml-line-break and -khml-nbsp-mode.
- 4:21 PM Changeset in webkit [7829] by
-
- 3 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3816768> REGRESSION (Mail): Deleting last character in block incorrectly
moves caret out of block.
The issue here is that an empty block with no explicit height set by style collapses
to zero height, and does so immediately after the last bit of content is removed from
it (as a result of deleting text with the delete key for instance). Since zero-height
blocks are not eligible caret positions, the caret jumped to the closest eligible spot.
The fix is to detect when a block has not been removed itself, but has had all its
contents removed. In this case, a BR element is placed in the block, one that is
specially marked as a placeholder. Later, if the block ever receives content, this
placeholder is removed.
- khtml/editing/htmlediting.cpp: (khtml::blockPlaceholerClassString): String which acts as a placeholder marker class. (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Adds a placeholder BR if needed. (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Removes a placeholder BR if needed. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Call removeBlockPlaceholderIfNeeded. Also, do some cleanup on some old, crufty code in the move logic that is just so clearly wrong (it's very clear that we needs to be able to move more than just text nodes). This may expose bugs, but these bugs needs to be filed and fixed, not ducked. Besides, undoing this silliness made the test case in the bug work. (khtml::DeleteSelectionCommand::doApply): Call insertBlockPlaceholderIfNeeded and removeBlockPlaceholderIfNeeded. (khtml::InputTextCommand::input): Call removeBlockPlaceholderIfNeeded. (khtml::ReplaceSelectionCommand::doApply): Call removeBlockPlaceholderIfNeeded.
- khtml/editing/htmlediting.h: Declare new functions.
- 3:00 PM Changeset in webkit [7828] by
-
- 2 edits in trunk/WebKit
Don't fill background with transparency unless debug flag
is enabled.
Reviewed by Hyatt.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
- 2:40 PM Changeset in webkit [7827] by
-
- 2 edits in trunk/JavaScriptCore
Moved boolean checks prior to NSNumber checks. booleans are
NSNumbers.
Follow on to <rdar://problem/3821515> binding layer needs to convert NSNumber-bools to js type boolean not number.
Reviewed by John.
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
- 2:31 PM Changeset in webkit [7826] by
-
- 8 edits in trunk/WebCore
Added support for -apple-dashboard-region:none. And fixed
a few computed style problems.
Fixed <rdar://problem/3833532> -apple-dashboard-region: none; is needed
Reviewed by Hyatt.
- khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
- khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText):
- khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseDashboardRegions):
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
- khtml/rendering/render_style.cpp: (RenderStyle::noneDashboardRegions):
- khtml/rendering/render_style.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dashboardRegionsDictionary):
- 1:14 AM Changeset in webkit [7825] by
-
- 2 edits in trunk/WebCore/khtml/rendering
Make the review fixes from kocienda's review.
- 1:04 AM Changeset in webkit [7824] by
-
- 13 edits in trunk
Rework block layout to clean it up and simplify it (r=kocienda).
Also fixing the style sharing bug (r=mjs).
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::MarginInfo::MarginInfo): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::adjustPositionedBlock): (khtml::RenderBlock::adjustFloatingBlock): (khtml::RenderBlock::handleSpecialChild): (khtml::RenderBlock::handleFloatingOrPositionedChild): (khtml::RenderBlock::handleCompactChild): (khtml::RenderBlock::insertCompactIfNeeded): (khtml::RenderBlock::handleRunInChild): (khtml::RenderBlock::collapseMargins): (khtml::RenderBlock::clearFloatsIfNeeded): (khtml::RenderBlock::estimateVerticalPosition): (khtml::RenderBlock::determineHorizontalPosition): (khtml::RenderBlock::setCollapsedBottomMargin): (khtml::RenderBlock::adjustChildIfOverhangingFloatsExist): (khtml::RenderBlock::handleBottomOfBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): (khtml::RenderBlock::addOverHangingFloats):
- khtml/rendering/render_block.h: (khtml::RenderBlock::maxTopMargin): (khtml::RenderBlock::maxBottomMargin): (khtml::RenderBlock::CompactInfo::compact): (khtml::RenderBlock::CompactInfo::block): (khtml::RenderBlock::CompactInfo::matches): (khtml::RenderBlock::CompactInfo::clear): (khtml::RenderBlock::CompactInfo::set): (khtml::RenderBlock::CompactInfo::CompactInfo): (khtml::RenderBlock::MarginInfo::setAtTopOfBlock): (khtml::RenderBlock::MarginInfo::setAtBottomOfBlock): (khtml::RenderBlock::MarginInfo::clearMargin): (khtml::RenderBlock::MarginInfo::setSelfCollapsingBlockClearedFloat): (khtml::RenderBlock::MarginInfo::setTopQuirk): (khtml::RenderBlock::MarginInfo::setBottomQuirk): (khtml::RenderBlock::MarginInfo::setDeterminedTopQuirk): (khtml::RenderBlock::MarginInfo::setPosMargin): (khtml::RenderBlock::MarginInfo::setNegMargin): (khtml::RenderBlock::MarginInfo::setPosMarginIfLarger): (khtml::RenderBlock::MarginInfo::setNegMarginIfLarger): (khtml::RenderBlock::MarginInfo::setMargin): (khtml::RenderBlock::MarginInfo::atTopOfBlock): (khtml::RenderBlock::MarginInfo::canCollapseWithTop): (khtml::RenderBlock::MarginInfo::canCollapseWithBottom): (khtml::RenderBlock::MarginInfo::canCollapseTopWithChildren): (khtml::RenderBlock::MarginInfo::canCollapseBottomWithChildren): (khtml::RenderBlock::MarginInfo::selfCollapsingBlockClearedFloat): (khtml::RenderBlock::MarginInfo::quirkContainer): (khtml::RenderBlock::MarginInfo::determinedTopQuirk): (khtml::RenderBlock::MarginInfo::topQuirk): (khtml::RenderBlock::MarginInfo::bottomQuirk): (khtml::RenderBlock::MarginInfo::posMargin): (khtml::RenderBlock::MarginInfo::negMargin): (khtml::RenderBlock::MarginInfo::margin):
- khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):
- khtml/rendering/render_box.h: (khtml::RenderBox::marginTop): (khtml::RenderBox::marginBottom): (khtml::RenderBox::marginLeft): (khtml::RenderBox::marginRight):
- khtml/rendering/render_image.cpp: (RenderImage::setImage):
- khtml/rendering/render_object.cpp: (RenderObject::sizesToMaxWidth):
- khtml/rendering/render_object.h: (khtml::RenderObject::collapsedMarginTop): (khtml::RenderObject::collapsedMarginBottom): (khtml::RenderObject::maxTopMargin): (khtml::RenderObject::maxBottomMargin): (khtml::RenderObject::marginTop): (khtml::RenderObject::marginBottom): (khtml::RenderObject::marginLeft): (khtml::RenderObject::marginRight):
- khtml/rendering/render_text.h: (khtml::RenderText::marginLeft): (khtml::RenderText::marginRight):
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
Oct 12, 2004:
- 5:09 PM Changeset in webkit [7823] by
-
- 3 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3836158> REGRESSION (Mail): command-right-arrow moves to beginning of next line
- khtml/editing/selection.cpp: (khtml::endOfLastRunAt): Do not let the end of the last run on a line be a BR. This will make it seem like the run ends on the next line.
- 4:25 PM Changeset in webkit [7822] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3836986> Delete code removes elements of table structure; can result in very broken-looking web pages
- khtml/editing/htmlediting.cpp: (khtml::isTableStructureNode): New helper. Determines whether a node is a table cell, row, section, or column. (khtml::CompositeEditCommand::removeFullySelectedNode): New helper that recurses into elements of table structure when doing deletes, rather than deleting the structure elements themselves. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Do not move content between elements of table structure. We may want to revisit this some day, but this seems like the best behavior to me now. (khtml::DeleteSelectionCommand::doApply): Call removeFullySelectedNode instead of removeNode where needed.
- khtml/editing/htmlediting.h: Add declarations for new functions.
- 4:24 PM Changeset in webkit [7821] by
-
- 4 edits in trunk/WebKit
WebKit:
Fixed <rdar://problem/3829705> Need to remove filling w/ transparency when not drawing backgroundy.
Reviewed by Ken.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _transparentBackground]): (-[WebHTMLView _setTransparentBackground:]): (-[WebHTMLView drawRect:]):
- WebView.subproj/WebHTMLViewInternal.h:
- WebView.subproj/WebHTMLViewPrivate.h:
WebBrowser:
As part of fix <rdar://problem/3829705> Need to remove filling w/ transparency when not drawing backgroundy, we can no longer rely on WebHTMLView filling with transparency, so added additional flag to indicate that we should.
- Debug/DebugUtilities.m: (-[BrowserDocument toggleTransparentWindow:]):
- LocationChangeHandler.m: Removed #define to prevent console spew.
- 3:43 PM Changeset in webkit [7820] by
-
- 9 edits in trunk
Fixed access to DOM object via WebScriptObject API.
The execution context for DOM objects wasn't being found.
<rdar://problem/3831372> The valueForKey method for @"offsetLeft" on a paragraph element causes a crash.
Reviewed by Chris.
- bindings/objc/WebScriptObject.mm: (_didExecute): (-[WebScriptObject KJS::Bindings::]): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject stringRepresentation]):
- bindings/objc/WebScriptObjectPrivate.h:
WebCore:
Fixed access to DOM object via WebScriptObject API.
The execution context for DOM objects wasn't being found.
<rdar://problem/3831372> The valueForKey method for @"offsetLeft" on a paragraph element causes a crash.
Reviewed by Chris
Fixed <rdar://problem/3831063> regions use left offset instead of top offset
Reviewed by John
- khtml/khtml_part.h:
- khtml/rendering/render_object.cpp: (RenderObject::addDashboardRegions):
- kwq/DOM.mm: (-[DOMNode isContentEditable]): (-[DOMNode KJS::Bindings::]):
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::executionContextForDOM):
WebBrowser:
Added debugging code (disable) to assist in debugging DOM/WebScriptObjects.
Reviewed by Chris.
- LocationChangeHandler.m: (-[Logger logMessage:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
- 3:25 PM Changeset in webkit [7819] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3834779> Mail crashes when editing HTML message - khtml::Selection::layout()
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::styleForSelectionStart): Table code seems to be more robust when the call to insert our style-checking node is done with an appendChild rather than an insertBefore. Note that this table-related problem was exposed by fixing Selection::layout(), which I did yesterday. This change simply improves things even more so that we do not crash in the scenario described in the bug.
Oct 11, 2004:
- 10:49 AM Changeset in webkit [7818] by
-
- 4 edits in trunk/WebCore
Reviewed by John
This is a partial fix to this bug:
<rdar://problem/3832886> increase quote level on new mail document leads to immediate
crash in caret painting code
To eliminate the bad behavior for good, I have done some investigations in Mail code,
and I have sent a suggested code change on to Grant. Basically, Mail can't add empty
blocks (like blockquote elements used for quoting) to documents without giving those
blocks some content (so they have a height).
I added some other crash protections below.
- khtml/editing/selection.cpp: (khtml::Selection::layout): Check for non-null position after calls to VisiblePosition, since the VisiblePosition constructors may fail to find a visible spot in the document. Also, add a couple position-has-renderer assertion checks.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::styleForSelectionStart): Take out pos.isNotNull() assertion since VisiblePosition may not yield a position. This assertion is a holdover from before we had VisiblePosition. (KWQKHTMLPart::fontForSelection): Rearrange the code a little to deal with possible null results from calls to helpers.
- 10:34 AM Changeset in webkit [7817] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3834230> empty table can result in division by 0
- khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): Added 0 check; rolled in from KDE.
- 10:20 AM Changeset in webkit [7816] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3802039> 8A259: Can't use Grab services to grab selection from screen
Reviewed by john.
- WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]): register service "return types" which are types that can be inserted into a WebView (-[WebHTMLView writeSelectionToPasteboard:types:]): service protocol method, be sure to only write specified types (-[WebHTMLView readSelectionFromPasteboard:]): new, service protocol method, insert types (-[WebHTMLView validRequestorForSendType:returnType:]): moved, handle return types
- 10:13 AM Changeset in webkit [7815] by
-
- 2 adds in trunk/LayoutTests/fast/forms
Added layout test for <input> value bug I just fixed.
- 10:10 AM Changeset in webkit [7814] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3818712> form checkbox value property is read only
The underlying problem was that we were storing two separate values for all
form elements; one for the value property (JavaScript) and the other for the
value attribute (DOM). This is a good idea for text input, but not for other types.
- khtml/html/html_formimpl.h: Changed setValue to take a const DOMString reference. Added private storesValueSeparateFromAttribute function.
- khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::setType): Handle type changes, including detaching and re-attaching if type changed, and moving value from m_value to ATTR_VALUE and vice versa. (DOM::HTMLInputElementImpl::type): Added a case for ISINDEX and moved the default out of the switch so that we will get a warning if a type is left out. (DOM::HTMLInputElementImpl::parseHTMLAttribute): Tweaked comment format. (DOM::HTMLInputElementImpl::reset): Changed to only nuke the value if the value property is stored separately from the attribute. Otherwise, we just want to lave it alone (DOM::HTMLInputElementImpl::value): Changed to always use m_value if it's not null, then fall back on the attribute, and finally fall back to the "on" for the checkbox only if both are null. (DOM::HTMLInputElementImpl::setValue): Changed to set the attribute unless the value property is supposed to be stored separate from the attribute. (DOM::HTMLInputElementImpl::storesValueSeparateFromAttribute): Added. Returns true for text-type input elements, and false for the others.
- 9:38 AM Changeset in webkit [7813] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3834130> nil-object-in-dictionary exception seen in -[WebView _elementAtWindowPoint:]
- WebView.subproj/WebView.m: (-[WebView _elementAtWindowPoint:]): Added a check for nil frame.
- 9:34 AM Changeset in webkit [7812] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3296652> checkbox input type does not respond to onchange
- khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement): Some new code, commented out, for form element colors. (RenderCheckBox::slotStateChanged): Added call to onChange.
- 9:28 AM Changeset in webkit [7811] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3834166> <input type=file> sends onchange even when the same file is chosen twice
- WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton chooseFilename:]): Do nothing if filename is the same as before.
- 9:04 AM Changeset in webkit [7810] by
-
- 35 edits in trunk
WebCore:
Reviewed by Darin
Finish selection affinity implementation. This includes code to set the
affinity correctly when clicking with the mouse, and clearing the
affinity when altering the selection using any of the Selection object
mutation functions.
Each instance of the positionForCoordinates, inlineBox and caretRect
functions have been changed to include an EAffinity argument to give results
which take this bit into account.
- khtml/editing/selection.cpp: (khtml::Selection::init): Default affinity is now UPSTREAM, to match AppKit. (khtml::Selection::modifyAffinity): New function to compute affinity based on modification constants. (khtml::Selection::moveTo): Reset affinity to UPSTREAM. (khtml::Selection::modifyExtendingRightForward): Ditto. (khtml::Selection::modifyMovingRightForward): Ditto. (khtml::Selection::modifyExtendingLeftBackward): Ditto. (khtml::Selection::modifyMovingLeftBackward): Ditto. (khtml::Selection::modify): Support saving, restoring, and then calculating new affinity value as needed. (khtml::Selection::xPosForVerticalArrowNavigation): (khtml::Selection::clear): Reset affinity to UPSTREAM. (khtml::Selection::setBase): Ditto. (khtml::Selection::setExtent): Ditto. (khtml::Selection::setBaseAndExtent): Ditto. (khtml::Selection::layout): Pass affinity to caretRect(). (khtml::Selection::validate): Pass along affinity parameter to new functions that require it. (khtml::startOfFirstRunAt): Changed the way that the y-coordinate search is done, to keep this code working with changes made in selectionForLine(). (khtml::endOfLastRunAt): Ditto. (khtml::selectionForLine): Make this function work for all renderers, not just text renderers.
- khtml/editing/selection.h: (khtml::operator==): Consider affinity in equality check.
- khtml/editing/visible_units.cpp: (khtml::previousLinePosition): Pass affinity argument to function so it can take this information into account while processing. (khtml::nextLinePosition): Ditto. (khtml::previousParagraphPosition): Ditto. (khtml::nextParagraphPosition): Ditto.
- khtml/editing/visible_units.h: Ditto, for each of the functions listed.
- khtml/khtml_events.cpp: (khtml::MouseEvent::offset): Rework code to remove dependence on NodeImpl::positionForCoordinates, as this function is being removed.
- khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): Ditto. (KHTMLPart::selectClosestWordFromMouseEvent): Ditto. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMousePressEventSingleClick): Ditto. Plus, pass affinity argument in call to positionForCoordinates, and set resulting affinity on the selection. (KHTMLPart::handleMouseMoveEventSelection): Rework code to remove dependence on NodeImpl::positionForCoordinates, as this function is being removed. (KHTMLPart::khtmlMouseReleaseEvent): Ditto.
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): Now takes an affinity argument.
- khtml/rendering/render_block.h:
- khtml/rendering/render_box.cpp: (RenderBox::caretRect): Ditto.
- khtml/rendering/render_box.h:
- khtml/rendering/render_br.cpp: (RenderBR::positionForCoordinates): Ditto. (RenderBR::caretRect): Ditto. (RenderBR::inlineBox): Ditto.
- khtml/rendering/render_br.h:
- khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates): Ditto.
- khtml/rendering/render_container.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::caretRect): Ditto.
- khtml/rendering/render_flow.h:
- khtml/rendering/render_inline.cpp: (RenderInline::positionForCoordinates): Ditto.
- khtml/rendering/render_inline.h:
- khtml/rendering/render_object.cpp: (RenderObject::caretRect): Ditto. (RenderObject::positionForCoordinates): Ditto. (RenderObject::inlineBox): Ditto.
- khtml/rendering/render_object.h:
- khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates): Ditto.
- khtml/rendering/render_replaced.h:
- khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Ditto. (firstRendererOnNextLine): New helper used by caretRect(). (RenderText::caretRect): Now takes an affinity argument. (RenderText::inlineBox): Ditto.
- khtml/rendering/render_text.h:
- khtml/xml/dom_nodeimpl.cpp: Remove positionForCoordinates helper.
- khtml/xml/dom_nodeimpl.h: Ditto.
- khtml/xml/dom_position.cpp: (DOM::Position::previousLinePosition): Now takes an affinity argument. (DOM::Position::nextLinePosition): Ditto.
- khtml/xml/dom_position.h:
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge caretRectAtNode:offset:affinity:]): Ditto. (-[WebCoreBridge setSelectedDOMRange:affinity:]): Ditto. (-[WebCoreBridge _positionForPoint:]): Rework code to remove dependence on NodeImpl::positionForCoordinates, as this function is being removed.
WebKit:
Reviewed by Darin
- WebView.subproj/WebHTMLView.m: (-[WebTextCompleteController doCompletion]): bridge call to get caret rect at a node now takes an affinity: caretRectAtNode:offset:affinity:.
- 8:17 AM Changeset in webkit [7809] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3670280> scroll position on overflowed textareas resets when leaving the tab
- kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Scroll to reveal the text area, don't scroll to reveal the text view itself. Scrolling the text view ended up putting it at the top left, regardless of where the insertion point is.
- 8:08 AM Changeset in webkit [7808] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3831546> More text is copied than is visually selected
The bug here is that upstream was moving a position too far.
- khtml/xml/dom_position.cpp: (DOM::Position::upstream): Use the "deep equivalent" node rather than the original node passed in for various checks. Also use local variables a bit more for slightly more efficiency. (DOM::Position::downstream): Ditto.
- 7:58 AM Changeset in webkit [7807] by
-
- 1 edit in trunk/WebKit/ChangeLog
Removed stray conflict marker
- 7:57 AM Changeset in webkit [7806] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris
Fix for this bug:
<rdar://problem/3814236> REGRESSION (Mail): Can't set the color of text in Mail compose window using drag/drag from color panel
- WebView.subproj/WebHTMLView.m: (+[WebHTMLView _insertablePasteboardTypes]): Add NSColorPboardType to list. (-[WebHTMLView _isNSColorDrag:]): New helper. Determines if drag is an NSColor drag. (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Add a case for NSColor drags, else do what we did before. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Add a case for NSColor drags, which creates a CSS style containing color info and calls the bridge to apply the style. Otherwise, do what we did before.
- 7:55 AM Changeset in webkit [7805] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3833841> adding an event listener for keypress events does not work
- khtml/xml/dom2_eventsimpl.h: Added numEventIds and made typeToId take a const DOMString &.
- khtml/xml/dom2_eventsimpl.cpp: (EventImpl::typeToId): Changed to use table. Added "keypress", otherwise, the same as before. (EventImpl::idToType): Changed to use table.
- 7:51 AM Changeset in webkit [7804] by
-
- 2 edits in trunk/WebKit
Reviewed by Ken.
- fixed <rdar://problem/3833848> REGRESSION (133-134): each keydown event is getting sent multiple times
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]): Don't send an event through WebCore if it has already been through once.
Oct 10, 2004:
- 8:14 AM Changeset in webkit [7803] by
-
- 3 edits in trunk/WebKit
Reviewed by Ken.
- fixed <rdar://problem/3777253> Crash in redirect mechanism trying to display error page for bad scheme
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): add retain/autorelease to the request returned from call to super. In this case, the return value was being dealloc'ed before being returned.
- 8:13 AM Changeset in webkit [7802] by
-
- 2 edits in trunk/WebCore
- fixed <rdar://problem/3664375> repro crash in -[KWQAccObject accessibilityAttributeNames]
(-[KWQAccObject accessibilityActionNames]):
check for nil m_renderer
