Timeline
Oct 15, 2004:
- 4:17 PM Changeset in webkit [7847] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3841774> would like to get NSColor from DOM-CSS
Reviewed by john.
- kwq/DOM-CSS.mm: (-[DOMRGBColor _color]): new, returns getNSColor on KWQColor
- kwq/DOMPrivate.h:
- 2:07 PM Changeset in webkit [7846] by
-
- 2 edits4 adds in trunk
Reviewed by Hyatt
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::skipNonBreakingSpace): Also need to forego the skipping after a clean line break, in addition to the cases already checked for.
- layout-tests/editing/inserting/insert-br-007-expected.txt: Added.
- layout-tests/editing/inserting/insert-br-007.html: Added.
- layout-tests/editing/inserting/insert-br-008-expected.txt: Added.
- layout-tests/editing/inserting/insert-br-008.html: Added.
- 11:22 AM Changeset in webkit [7845] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (168u)
- 11:12 AM Changeset in webkit [7844]
-
- 2 copies in tags/Safari-167
This commit was manufactured by cvs2svn to create tag 'Safari-167'.
- 11:12 AM Changeset in webkit [7843] by
-
- 6 edits in trunk
Safari-167 stamp
Oct 14, 2004:
- 5:01 PM Changeset in webkit [7842] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3839989> REGRESSION (Mail): Left arrow does nothing after inserting attachment
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::deepEquivalent): Remove code that attempted to bridge old-style position code to new-style VisiblePosition code. In retrospect, this code was misguided. Since we do a good job of insulating external code from the internal workings of VisiblePosition, the "hop ahead" being done here was not doing anyone any real good, and in the case of this bug, was doing harm. Simply removing this code makes the bug go away and does not cause any editing layout test regresssions.
- 4:51 PM Changeset in webkit [7841] by
-
- 3 edits2 adds in trunk
Reviewed by Hyatt
- khtml/rendering/bidi.cpp: (khtml::skipNonBreakingSpace): New helper. (khtml::RenderBlock::skipWhitespace): Do not skip non-breaking spaces that are at the start of a block. This was preventing users from typing spaces in empty documents.
- layout-tests/editing/inserting/insert-space-in-empty-doc-expected.txt: Added.
- layout-tests/editing/inserting/insert-space-in-empty-doc.html: Added.
- 2:52 PM Changeset in webkit [7840] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin and Ken.
fix for <rdar://problem/3821070> null de-ref in DelectSelectionCommand::doApply()
This change shifts some code around so that the code that determines what typing style
is in effect is called before deleteUnrenderedText is called. Two asserts are also added
to ensure that start and end nodes of the selection are in the document.
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::doApply):
- 2:35 PM Changeset in webkit [7839] by
-
- 4 edits in trunk/WebCore
Reviewed by Ken
This change makes these three functions virtual so that the work is being done in KWQHTMLPart
instead of khtml_part, eliminating the need for the "#if APPLE_CHANGES" statements in the khtml code.
- khtml/khtml_part.cpp: (KHTMLPart::shouldBeginEditing): (KHTMLPart::shouldEndEditing): (KHTMLPart::isContentEditable):
- khtml/khtml_part.h:
- kwq/KWQKHTMLPart.h:
- 1:38 PM Changeset in webkit [7838] by
-
- 10 edits in trunk
WebCore:
Reviewed by John
Final fix for these bugs:
<rdar://problem/3806306> HTML editing puts spaces at start of line
<rdar://problem/3814252> HTML editing groups space with word causing wrapping
This change sets some new CSS properties that have been added to WebCore to
enable whitespace-handling and line-breaking features that make WebView work
more like a text editor.
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Add and remove special editing CSS properties based on property value.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setContentEditable): Add and remove special editing CSS properties based on attribute value.
- khtml/khtml_part.cpp: (KHTMLPart::applyEditingStyleToBodyElement): New helper. Calls applyEditingStyleToElement on body element. (KHTMLPart::removeEditingStyleFromBodyElement): New helper. Calls removeEditingStyleFromElement on body element. (KHTMLPart::applyEditingStyleToElement): Adds special editing CSS properties to passed in element. (KHTMLPart::removeEditingStyleFromElement): Removes special editing CSS properties from passed in element.
- khtml/khtml_part.h: Add new declarations.
- kwq/WebCoreBridge.h: Ditto.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge applyEditingStyleToBodyElement]): Call through to similarly-named function on KHTMLPart. (-[WebCoreBridge removeEditingStyleFromBodyElement]): Ditto. (-[WebCoreBridge applyEditingStyleToElement:]): Ditto. (-[WebCoreBridge removeEditingStyleFromElement:]): Ditto.
WebKit:
Reviewed by John
Final fix for these bugs:
<rdar://problem/3806306> HTML editing puts spaces at start of line
<rdar://problem/3814252> HTML editing groups space with word causing wrapping
This change sets some new CSS properties that have been added to WebCore to
enable whitespace-handling and line-breaking features that make WebView work
more like a text editor.
- WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Turn on special editing CSS properties when loading an HTML document into a WebView that is editable.
- WebView.subproj/WebView.m: (-[WebView setEditable:]): Add and remove special editing CSS properties in current document being displayed.
- 12:51 PM Changeset in webkit [7837] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
- fixed <rdar://problem/3840052> Crash in removeBlockPlaceholderIfNeeded attaching file to empty document
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): needed a nil check to handle empty document case
- 10:14 AM Changeset in webkit [7836] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3823026> making isRoundingHackCharacter use -O3 and an 8-bit lookup-table will speed "XBS" test up by 3% (actually < 1%)
Careful testing shows a small performance gain on very large text files.
I saw large variations in timings, but taking the lowest PLT timing
with and without this change showed a 0.9% gain. Note the cvs-base showed
no improvement. The improvement was for the large page attached to the
bug.
Reviewed by Ken.
- WebCoreSupport.subproj/WebTextRenderer.m: (setupRoundingHackCharacterTable): (isRoundingHackCharacter): (+[WebTextRenderer initialize]):
- 7:31 AM Changeset in webkit [7835] by
-
- 2 edits in trunk/WebKit
Reviewed by me
Fix build breakage. These three functions need to return the values from their
calls to WebCGColorSpaceCreateXXX.
- WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge createRGBColorSpace]) (-[WebGraphicsBridge createGrayColorSpace]) (-[WebGraphicsBridge createCMYKColorSpace])
Oct 13, 2004:
- 6:32 PM Changeset in webkit [7834] by
-
- 2 edits in trunk/WebKit
Addressed concerns in <rdar://problem/3803117> RESP: High complexity in icu uidna_IDNToASCII called by [NSString(WebNSURLExtras) _web_mapHostNameWithRange:encode:makeString:]
In practice I saw NO improvement in performance. Although,
special-case tests could possibly show improvement. Anyway,
the changes don't hurt performance.
Reviewed by Maciej.
- Misc.subproj/WebNSURLExtras.m: (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
- 6:26 PM Changeset in webkit [7833] by
-
- 13 edits in trunk
WebCore:
Reviewed by Ken.
<rdar://problem/3824626> Change to do colormatching for DeviceRGB colorspace causes ~11% Safari slowdown
- I fixed this by turning off all colormatching for WebKit content. We might turn it back on later. For now, it's possible to turn it on temporarily by defining COLORMATCH_EVERYTHING.
- WebCorePrefix.h:
- khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): (Context2D::colorRefFromValue): (Gradient::getShading):
- khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::createDrawingContext):
- kwq/KWQColor.mm: (QColor::getNSColor):
- kwq/KWQPainter.h:
- kwq/KWQPainter.mm: (CGColorFromNSColor): (QPainter::selectedTextBackgroundColor): (QPainter::rgbColorSpace): (QPainter::grayColorSpace): (QPainter::cmykColorSpace):
- kwq/WebCoreGraphicsBridge.h:
- kwq/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge createRGBColorSpace]): (-[WebCoreGraphicsBridge createGrayColorSpace]): (-[WebCoreGraphicsBridge createCMYKColorSpace]):
WebKit:
Reviewed by Ken.
<rdar://problem/3824626> Change to do colormatching for DeviceRGB colorspace causes ~11% Safari slowdown
- I fixed this by turning off all colormatching for WebKit content. We might turn it back on later. For now, it's possible to turn it on temporarily by defining COLORMATCH_EVERYTHING.
- WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge setFocusRingStyle:radius:color:]): (-[WebGraphicsBridge additionalPatternPhase]): (-[WebGraphicsBridge createRGBColorSpace]): (-[WebGraphicsBridge createGrayColorSpace]): (-[WebGraphicsBridge createCMYKColorSpace]):
- WebCoreSupport.subproj/WebImageData.m:
- WebCoreSupport.subproj/WebImageRenderer.h:
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _adjustSizeToPixelDimensions]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): (-[WebImageRenderer _adjustColorSpace]): (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): (-[WebImageRenderer tileInRect:fromPoint:context:]): (_createImageRef): (WebCGColorSpaceCreateRGB): (WebCGColorSpaceCreateGray): (WebCGColorSpaceCreateCMYK):
- WebKitPrefix.h:
- 5:10 PM Changeset in webkit [7832] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
- khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::merge): A little cleanup. Also, make sure m_lstValues is non-null before appending.
- 5:05 PM Changeset in webkit [7831] by
-
- 4 edits in trunk
Reviewed by me
Update expected results for improved behavior as a result of fix to 3816768.
- layout-tests/editing/deleting/delete-3775172-fix-expected.txt
- layout-tests/editing/deleting/delete-3800834-fix-expected.txt
- layout-tests/editing/deleting/delete-block-merge-contents-002-expected.txt
- 4:35 PM Changeset in webkit [7830] by
-
- 2 edits in trunk/WebCore
Reviewed by Richard
- khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Add support to computed style for getting -khtml-line-break and -khml-nbsp-mode.
- 4:21 PM Changeset in webkit [7829] by
-
- 3 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3816768> REGRESSION (Mail): Deleting last character in block incorrectly
moves caret out of block.
The issue here is that an empty block with no explicit height set by style collapses
to zero height, and does so immediately after the last bit of content is removed from
it (as a result of deleting text with the delete key for instance). Since zero-height
blocks are not eligible caret positions, the caret jumped to the closest eligible spot.
The fix is to detect when a block has not been removed itself, but has had all its
contents removed. In this case, a BR element is placed in the block, one that is
specially marked as a placeholder. Later, if the block ever receives content, this
placeholder is removed.
- khtml/editing/htmlediting.cpp: (khtml::blockPlaceholerClassString): String which acts as a placeholder marker class. (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Adds a placeholder BR if needed. (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Removes a placeholder BR if needed. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Call removeBlockPlaceholderIfNeeded. Also, do some cleanup on some old, crufty code in the move logic that is just so clearly wrong (it's very clear that we needs to be able to move more than just text nodes). This may expose bugs, but these bugs needs to be filed and fixed, not ducked. Besides, undoing this silliness made the test case in the bug work. (khtml::DeleteSelectionCommand::doApply): Call insertBlockPlaceholderIfNeeded and removeBlockPlaceholderIfNeeded. (khtml::InputTextCommand::input): Call removeBlockPlaceholderIfNeeded. (khtml::ReplaceSelectionCommand::doApply): Call removeBlockPlaceholderIfNeeded.
- khtml/editing/htmlediting.h: Declare new functions.
- 3:00 PM Changeset in webkit [7828] by
-
- 2 edits in trunk/WebKit
Don't fill background with transparency unless debug flag
is enabled.
Reviewed by Hyatt.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
- 2:40 PM Changeset in webkit [7827] by
-
- 2 edits in trunk/JavaScriptCore
Moved boolean checks prior to NSNumber checks. booleans are
NSNumbers.
Follow on to <rdar://problem/3821515> binding layer needs to convert NSNumber-bools to js type boolean not number.
Reviewed by John.
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
- 2:31 PM Changeset in webkit [7826] by
-
- 8 edits in trunk/WebCore
Added support for -apple-dashboard-region:none. And fixed
a few computed style problems.
Fixed <rdar://problem/3833532> -apple-dashboard-region: none; is needed
Reviewed by Hyatt.
- khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
- khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText):
- khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseDashboardRegions):
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
- khtml/rendering/render_style.cpp: (RenderStyle::noneDashboardRegions):
- khtml/rendering/render_style.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::dashboardRegionsDictionary):
- 1:14 AM Changeset in webkit [7825] by
-
- 2 edits in trunk/WebCore/khtml/rendering
Make the review fixes from kocienda's review.
- 1:04 AM Changeset in webkit [7824] by
-
- 13 edits in trunk
Rework block layout to clean it up and simplify it (r=kocienda).
Also fixing the style sharing bug (r=mjs).
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::MarginInfo::MarginInfo): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::adjustPositionedBlock): (khtml::RenderBlock::adjustFloatingBlock): (khtml::RenderBlock::handleSpecialChild): (khtml::RenderBlock::handleFloatingOrPositionedChild): (khtml::RenderBlock::handleCompactChild): (khtml::RenderBlock::insertCompactIfNeeded): (khtml::RenderBlock::handleRunInChild): (khtml::RenderBlock::collapseMargins): (khtml::RenderBlock::clearFloatsIfNeeded): (khtml::RenderBlock::estimateVerticalPosition): (khtml::RenderBlock::determineHorizontalPosition): (khtml::RenderBlock::setCollapsedBottomMargin): (khtml::RenderBlock::adjustChildIfOverhangingFloatsExist): (khtml::RenderBlock::handleBottomOfBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): (khtml::RenderBlock::addOverHangingFloats):
- khtml/rendering/render_block.h: (khtml::RenderBlock::maxTopMargin): (khtml::RenderBlock::maxBottomMargin): (khtml::RenderBlock::CompactInfo::compact): (khtml::RenderBlock::CompactInfo::block): (khtml::RenderBlock::CompactInfo::matches): (khtml::RenderBlock::CompactInfo::clear): (khtml::RenderBlock::CompactInfo::set): (khtml::RenderBlock::CompactInfo::CompactInfo): (khtml::RenderBlock::MarginInfo::setAtTopOfBlock): (khtml::RenderBlock::MarginInfo::setAtBottomOfBlock): (khtml::RenderBlock::MarginInfo::clearMargin): (khtml::RenderBlock::MarginInfo::setSelfCollapsingBlockClearedFloat): (khtml::RenderBlock::MarginInfo::setTopQuirk): (khtml::RenderBlock::MarginInfo::setBottomQuirk): (khtml::RenderBlock::MarginInfo::setDeterminedTopQuirk): (khtml::RenderBlock::MarginInfo::setPosMargin): (khtml::RenderBlock::MarginInfo::setNegMargin): (khtml::RenderBlock::MarginInfo::setPosMarginIfLarger): (khtml::RenderBlock::MarginInfo::setNegMarginIfLarger): (khtml::RenderBlock::MarginInfo::setMargin): (khtml::RenderBlock::MarginInfo::atTopOfBlock): (khtml::RenderBlock::MarginInfo::canCollapseWithTop): (khtml::RenderBlock::MarginInfo::canCollapseWithBottom): (khtml::RenderBlock::MarginInfo::canCollapseTopWithChildren): (khtml::RenderBlock::MarginInfo::canCollapseBottomWithChildren): (khtml::RenderBlock::MarginInfo::selfCollapsingBlockClearedFloat): (khtml::RenderBlock::MarginInfo::quirkContainer): (khtml::RenderBlock::MarginInfo::determinedTopQuirk): (khtml::RenderBlock::MarginInfo::topQuirk): (khtml::RenderBlock::MarginInfo::bottomQuirk): (khtml::RenderBlock::MarginInfo::posMargin): (khtml::RenderBlock::MarginInfo::negMargin): (khtml::RenderBlock::MarginInfo::margin):
- khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical):
- khtml/rendering/render_box.h: (khtml::RenderBox::marginTop): (khtml::RenderBox::marginBottom): (khtml::RenderBox::marginLeft): (khtml::RenderBox::marginRight):
- khtml/rendering/render_image.cpp: (RenderImage::setImage):
- khtml/rendering/render_object.cpp: (RenderObject::sizesToMaxWidth):
- khtml/rendering/render_object.h: (khtml::RenderObject::collapsedMarginTop): (khtml::RenderObject::collapsedMarginBottom): (khtml::RenderObject::maxTopMargin): (khtml::RenderObject::maxBottomMargin): (khtml::RenderObject::marginTop): (khtml::RenderObject::marginBottom): (khtml::RenderObject::marginLeft): (khtml::RenderObject::marginRight):
- khtml/rendering/render_text.h: (khtml::RenderText::marginLeft): (khtml::RenderText::marginRight):
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
