Timeline
Oct 19, 2004:
- 4:50 PM Changeset in webkit [7864]
-
- 3 copies3 deletes in tags/WebKit-167~1
This commit was manufactured by cvs2svn to create tag 'WebKit-167~1'.
- 4:50 PM Changeset in webkit [7863] by
-
- 2 edits in trunk/WebKit
- bump WebKit version to 167.1, so that we can do a quick dot submission for <rdar://problem/3843951>
- WebKit.pbproj/project.pbxproj:
- 4:28 PM Changeset in webkit [7862] by
-
- 100 edits in trunk/LayoutTests
Check in updated layout tests.
- 4:04 PM Changeset in webkit [7861] by
-
- 5 edits2 adds in trunk
Reviewed by kocienda
More cleanup of block layout. Eliminates the separate step for tables that dont fit on a line with a float
and consolidates it with clearing.
Also patch dom_textimpl.cpp to reduce further the # of RenderTexts created.
- khtml/rendering/render_block.cpp: (khtml::getInlineRun): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::adjustFloatingBlock): (khtml::RenderBlock::collapseMargins): (khtml::RenderBlock::clearFloatsIfNeeded): (khtml::RenderBlock::estimateVerticalPosition): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::markAllDescendantsWithFloatsForLayout): (khtml::RenderBlock::getClearDelta): (khtml::RenderBlock::calcBlockMinMaxWidth):
- khtml/rendering/render_block.h:
- khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
- khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
Fix for 3841060, regression with * in frames. Reviewed by kocienda.
- layout-tests/fast/frames/002-expected.txt: Added.
- layout-tests/fast/frames/002.html: Added.
2004-10-19 Darin Adler <Darin Adler>
Reviewed by Maciej.
- follow-on to my fix yesterday, which broke a layout test because I rolled out a fix that Maciej had done
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): Need to check the actual queue of external scripts being loaded here. If the current code being run is the external script itself, then we don't want to defer parsing. But loadingExtScript has to stay true until after the script runs. The old code would assume that any time we're running a script there's no need to look at loadingExtScript, but that was also wrong since there can be a script loading in that case too. Layout tests check for both problems.
- layout-tests/fast/tokenizer/external-script-document-write-expected.txt: Added.
- layout-tests/fast/tokenizer/external-script-document-write.html: Added.
- layout-tests/fast/tokenizer/resources/external-script-document-write.js: Added.
- layout-tests/fast/tokenizer/004.html: Fixed line endings (were CR, should be LF).
- 3:05 PM Changeset in webkit [7860] by
-
- 2 edits in trunk/WebKit
Change suggested by Maciej during code review.
- WebCoreSupport.subproj/WebTextRenderer.m: Changed rounding hack table to be const so it can be in shared instead of private memory, and doesn't require an initialization function. (+[WebTextRenderer initialize]): Removed initialization.
- 2:56 PM Changeset in webkit [7859] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej.
- fixed <rdar://problem/3838934> Safari stops loading pages after rangeOfCharacterFromSet nil argument exception
- fixed <rdar://problem/3843951> REGRESSION (166-167): Safari crashes in widthForNextCharacter (belkin.com, at startup for others)
- fixed <rdar://problem/3841049> REGRESSION (109-110): control characters render as square boxes
- WebCoreSupport.subproj/WebTextRenderer.m: (isSpace): Merged in isAlternateSpace, never used. (setupRoundingHackCharacterTable): Fixed size of table, was 1 entry too short. Got rid of unneeded call to bzero, since globals start out zeroed automatically. (isRoundingHackCharacter): Fixed backwards logic causing the crash in widthForNextCharacter. Also removed explicit compare with 1; check for non-zero is just fine. (fontContainsString): Change code so we'll just skip the font if the covered character set returns nil rather than throwing an exception like the old version did. This should make bug 3838934 go away, although perhaps covering up the underlying problem. (-[WebTextRenderer _convertCharacters:length:toGlyphs:]): Removed unused skipControlCharacters: parameter and also the unnecessary code to copy the buffer to change newline characters and non-break spaces to spaces. (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): Removed unused local. (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): Added code to set up special cases for control characters, \n and non-break spaces. (-[WebTextRenderer _createATSUTextLayoutForRun:]): Added comment about the cases this code does not handle that are handled by the CG case. (widthForNextCharacter): Call isSpace instead of checking specifically for the space character here. The old code would not handle cases with '\n' coming across from WebCore properly.
- 2:11 PM Changeset in webkit [7858] by
-
- 2 adds in trunk/LayoutTests/fast/lists/resources
Add image for lists test.
- 12:01 PM Changeset in webkit [7857] by
-
- 3 edits3 adds in trunk
2004-10-19 Darin Adler <Darin Adler>
Reviewed by Maciej.
- follow-on to my fix yesterday, which broke a layout test because I rolled out a fix that Maciej had done
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): Need to check the actual queue of external scripts being loaded here. If the current code being run is the external script itself, then we don't want to defer parsing. But loadingExtScript has to stay true until after the script runs. The old code would assume that any time we're running a script there's no need to look at loadingExtScript, but that was also wrong since there can be a script loading in that case too. Layout tests check for both problems.
- layout-tests/fast/tokenizer/external-script-document-write-expected.txt: Added.
- layout-tests/fast/tokenizer/external-script-document-write.html: Added.
- layout-tests/fast/tokenizer/resources/external-script-document-write.js: Added.
- layout-tests/fast/tokenizer/004.html: Fixed line endings (were CR, should be LF).
- 9:33 AM Changeset in webkit [7856]
-
- 25 copies3 deletes in tags/WebKit-125~5~5
This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~5'.
- 9:33 AM Changeset in webkit [7855] by
-
- 2 edits in branches/Safari-1-2-branch/WebKit
WebKit versioning for SUPanNavy WebKit-125.5.5
Oct 18, 2004:
- 5:23 PM Changeset in webkit [7854] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fixed <rdar://problem/3807234> REGRESSION (152-153): can't get element by ID that was just written with document.write in separate JS file (lacoccinelle.net)
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): Use !isEmpty instead of count != 0, since it's cheaper. (khtml::HTMLTokenizer::write): Roll back to the old version of the check here. The fix is that we only want to look at loadingExtScript if m_executingScript is 0.
- 4:33 PM Changeset in webkit [7853] by
-
- 2 edits in branches/Safari-1-2-branch/WebKit
Reviewed by Dave.
This backs out the fix for <rdar://problem/3803113> WebFrame object leaked.
Back out rjw's fix for the frame leak, since it caused the onload handler to fire before
CSS and images had loaded.
- WebView.subproj/WebDataSource.m: (-[WebDataSource _finishedLoading]):
- 2:52 PM Changeset in webkit [7852] by
-
- 4 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3840907> textedit doesn't render italic or bold text in html documents
- khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::getStringValue): This function did not return string values for idents. Also changed the return value to be DOMString, rather than DOMStringImpl, to deal with the lifecycle issues associated with creating a string to be returned in the ident case.
- khtml/css/css_valueimpl.h: Change getStringValue to return DOMString rather than DOMStringImpl.
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Two calls of getStringValue needed updating.
- 10:56 AM Changeset in webkit [7851] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3770135> hang loading page with EMBED tag pointing to same page (tridentantennas.co.uk)
Reviewed by kocienda.
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): use completeURL before comparing the URL of the plug-in with the base URL of the document when avoiding frame recursion
- 10:36 AM Changeset in webkit [7850] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3840916> GC: -[WebNetscapePluginPackage initWithPath:] leaks an NSURL
Reviewed by kevin.
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): use executablePath on NSBundle instead of CFBundleCopyExecutableURL
- 10:30 AM Changeset in webkit [7849] by
-
- 2 edits in trunk/WebKit
- DOM.subproj/DOMPrivate.h: change to copied header that was never committed
- 9:55 AM Changeset in webkit [7848] by
-
- 2 edits in trunk/WebKit
Reviewed by Ken.
- fixed <rdar://problem/3810183> Make WebHTMLView respect return value of webView:doCommandBySelector:
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView doCommandBySelector:]): only do default action if delegate returns NO; this works with Mail as of Tiger 8A275.
Oct 15, 2004:
- 4:17 PM Changeset in webkit [7847] by
-
- 3 edits in trunk/WebCore
Fixed: <rdar://problem/3841774> would like to get NSColor from DOM-CSS
Reviewed by john.
- kwq/DOM-CSS.mm: (-[DOMRGBColor _color]): new, returns getNSColor on KWQColor
- kwq/DOMPrivate.h:
- 2:07 PM Changeset in webkit [7846] by
-
- 2 edits4 adds in trunk
Reviewed by Hyatt
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::skipNonBreakingSpace): Also need to forego the skipping after a clean line break, in addition to the cases already checked for.
- layout-tests/editing/inserting/insert-br-007-expected.txt: Added.
- layout-tests/editing/inserting/insert-br-007.html: Added.
- layout-tests/editing/inserting/insert-br-008-expected.txt: Added.
- layout-tests/editing/inserting/insert-br-008.html: Added.
- 11:22 AM Changeset in webkit [7845] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (168u)
- 11:12 AM Changeset in webkit [7844]
-
- 2 copies in tags/Safari-167
This commit was manufactured by cvs2svn to create tag 'Safari-167'.
- 11:12 AM Changeset in webkit [7843] by
-
- 6 edits in trunk
Safari-167 stamp
Note:
See TracTimeline
for information about the timeline view.
