Timeline



Oct 22, 2004:

5:19 PM Changeset in webkit [7885] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3851491> installedPlugins being called for a page without plugins

Reviewed by mjs.

  • WebView.subproj/WebFrameView.m: (+[WebFrameView _canShowMIMETypeAsHTML:]): call _viewTypesAllowImageTypeOmission instead of using ivar since the ivar is nil until _viewTypesAllowImageTypeOmission is called, this was causing [WebView canShowMIMEType:] to check plug-ins
3:26 PM Changeset in webkit [7884] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3844662> REGRESSION (Mail): Style changes can affect adjacent, unselected text

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::doApply): Move end position downstream to be sure we remove style from everything that could be affected. (khtml::ApplyStyleCommand::removeCSSStyle): Comma in intended function call was outside the braces, making it act as a comma operator, with a zero value as the right value!!! This made an important check always fail!!! It turns out that we do not want the constant at all, since that constant is only needed when checking a computed style, not an inline style as is being done here. (khtml::ApplyStyleCommand::removeStyle): Call nodeFullySelected with new interface. (khtml::ApplyStyleCommand::nodeFullySelected): Change interface and implementation to rely on RangeImpl::compareBoundaryPoints to perform the required check.
  • khtml/editing/htmlediting.h: Changed nodeFullySelected function interface.
1:07 PM Changeset in webkit [7883] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bugs:

<rdar://problem/3848343> REGRESSION (Mail, 166-168u): Typed text after space at end of line before block quote does not appear
<rdar://problem/3848224> REGRESSION (Mail): space typed at end of line vanishes after typing next character

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): When the khtmlLineBreak is in AFTER_WHITE_SPACE mode, as it is when we are editing, add in the space of the current character when calculating the width of committed plus uncommitted characters. If this value exceeds the width of the line, move up the line break object and call skipWhitespace to move past the end of the whitespace.
12:14 PM Changeset in webkit [7882] by vicki
  • 3 edits in trunk

versioning for TOT. the tree is open!

12:04 PM Changeset in webkit [7881]
  • 2 copies in tags/Safari-168

This commit was manufactured by cvs2svn to create tag 'Safari-168'.

12:04 PM Changeset in webkit [7880] by vicki
  • 6 edits in trunk

Safari-168 stamp

9:20 AM Changeset in webkit [7879] by kocienda
  • 6 edits in trunk

JavaScriptCore:

Reviewed by me

  • JavaScriptCore.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.

WebCore:

Reviewed by me

  • WebCore.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.

WebKit:

Reviewed by me

  • WebKit.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.

Oct 21, 2004:

6:08 PM Changeset in webkit [7878] by hyatt
  • 2 edits
    2 adds in trunk

Reviewed by darin

Clean up the inline run function so that it doesn't return incorrect answers when making children non-inline.

<rdar://problem/3848724> REGRESSION (166-168u): RenderText::layout called, firing assertion that kills Mail
<rdar://problem/3848357> RenderText::layout called, firing assertion that kills Safari (www.apple.com/downloads/macosx)

  • khtml/rendering/render_block.cpp: (khtml::getInlineRun): (khtml::RenderBlock::makeChildrenNonInline):
5:00 PM Changeset in webkit [7877] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

Add layout test for dynamic block/inline crash.

4:45 PM Changeset in webkit [7876] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3810389, crash because of continuation() craziness. Revert back to the old behavior of
making sure that all line boxes get deleted and recreated when inlines are split because of a block.

Reviewed darin

  • khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):
2:19 PM Changeset in webkit [7875] by kocienda
  • 27 edits in trunk

Reviewed by Darin

Significant improvement to the way that whitespace is handled during editing.

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): New functions (there are actually two being added with this name) that delete "insignificant" unrendered text. (khtml::CompositeEditCommand::deleteInsignificantTextDownstream): Takes a position, calculates the downstream position to use as the endpoint for the deletion, and then calls deleteInsignificantText with this start and end. (khtml::DeleteSelectionCommand::doApply): Call new deleteInsignificantTextDownstream function. (khtml::InputNewlineCommand::doApply): Ditto. (khtml::InputTextCommand::input): Ditto.
  • khtml/editing/htmlediting.h: Add new declarations.

Modified layout test results:

  • layout-tests/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • layout-tests/editing/deleting/delete-selection-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt:
  • layout-tests/editing/inserting/insert-3659587-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3775316-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3778059-fix-expected.txt:
  • layout-tests/editing/inserting/insert-br-001-expected.txt:
  • layout-tests/editing/inserting/insert-br-004-expected.txt:
  • layout-tests/editing/inserting/insert-br-005-expected.txt:
  • layout-tests/editing/inserting/insert-br-006-expected.txt:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/editing/inserting/insert-text-with-newlines-expected.txt:
  • layout-tests/editing/inserting/typing-001-expected.txt:
  • layout-tests/editing/inserting/typing-around-br-001-expected.txt:
  • layout-tests/editing/inserting/typing-around-image-001-expected.txt:
  • layout-tests/editing/style/typing-style-003-expected.txt:
  • layout-tests/editing/undo/redo-typing-001-expected.txt:
  • layout-tests/editing/undo/undo-typing-001-expected.txt:
2:12 PM Changeset in webkit [7874] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3847054, assertion failure in RenderText::layout() on news.com page. Fix getInlineRun so that
it no longer breaks early (thus causing some children not to get properly wrapped by anonymous blocks).

Reviewed by darin

  • khtml/rendering/render_block.cpp: (khtml::getInlineRun):
10:04 AM Changeset in webkit [7873] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/3847994> REGRESSION: reproducible exception in WebImageRenderer releasePatternColor; afterwards get crash or no more browsing
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage createRendererIfNeeded]): Replaced retainOrCopyIfNeeded with this. This returns nil if a copied renderer isn't needed, and returns a new renderer if a copy is. The old version was sometimes returning a WebInternalImage and other times a WebImageRenderer. (-[WebImageRenderer retainOrCopyIfNeeded]): Returns the result of createRendererIfNeeded or retains self and returns self.

Oct 20, 2004:

5:23 PM Changeset in webkit [7872] by hyatt
  • 16 edits in trunk/LayoutTests/fast

Land updated layout tests with scroll info.

5:20 PM Changeset in webkit [7871] by darin
  • 6 edits in trunk/WebKit

Reviewed by Dave.

  • fixed <rdar://problem/3470715> Pattern cache can get huge with use of css background-image in Safari
  • WebCoreSupport.subproj/WebImageRenderer.h: Change WebImageRenderer to be a subclass of NSObject rather than NSImage and contain a pointer to a WebInternalImage.
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage releasePatternColor]): Added. Releases patternColor. (-[WebImageRenderer initWithMIMEType:]): Added. Makes WebInternalImage and then self. (-[WebImageRenderer initWithData:MIMEType:]): Ditto. (-[WebImageRenderer initWithContentsOfFile:]): Ditto. (-[WebImageRenderer dealloc]): Added. Calls releasePatternColor and then releases WebInternalImage. (-[WebImageRenderer image]): Added. Returns pointer to image. (-[WebImageRenderer MIMEType]): Added. Calls through to image. (-[WebImageRenderer TIFFRepresentation]): Ditto. (-[WebImageRenderer frameCount]): Ditto. (-[WebImageRenderer setOriginalData:]): Added. Sets image data pointer. (+[WebImageRenderer stopAnimationsInView:]): Added. Calls through to image. (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Ditto. (-[WebImageRenderer size]): Ditto. (-[WebImageRenderer resize:]): Ditto. (-[WebImageRenderer drawImageInRect:fromRect:]): Ditto. (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): Ditto. (-[WebImageRenderer stopAnimation]): Ditto. (-[WebImageRenderer tileInRect:fromPoint:context:]): Ditto. (-[WebImageRenderer isNull]): Ditto. (-[WebImageRenderer retainOrCopyIfNeeded]): Ditto. (-[WebImageRenderer increaseUseCount]): Ditto. (-[WebImageRenderer decreaseUseCount]): Ditto. (-[WebImageRenderer flushRasterCache]): Ditto. (-[WebImageRenderer imageRef]): Ditto. (-[WebImageRenderer copyWithZone:]): Ditto.
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): Update for slight changes to WebImageRenderer API.
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]): Ditto. (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): Ditto. (-[WebImageRendererFactory imageRendererWithSize:]): Ditto. (-[WebImageRendererFactory imageRendererWithName:]): Ditto.
  • WebView.subproj/WebImageView.m: (-[WebImageView image]): Ditto.
5:20 PM Changeset in webkit [7870] by hyatt
  • 4 edits in trunk/WebCore

Add better dumping of overflow information for scrolling regions.

Fix for 3726524, crash in updateLayerPosition. Make sure anonymous elements properly remove themselves
from the render tree so that layers and so forth are cleaned up.

Reviewed by darin

  • khtml/rendering/render_container.cpp: (RenderContainer::detach):
  • khtml/rendering/render_layer.h: (khtml::RenderLayer::scrollXOffset): (khtml::RenderLayer::scrollYOffset):
  • kwq/KWQRenderTreeDebug.cpp: (write):
2:34 PM Changeset in webkit [7869] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3791146, make sure all lines are checked when computing overflow.

Reviewed by kocienda

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::checkLinesForOverflow):
  • khtml/rendering/render_block.h:
2:31 PM Changeset in webkit [7868] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3846943> REGRESSION: JNLP files are rendered instead of downloaded

Reviewed by john.

  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isJavaPlugIn]): new
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): don't register the Java plug-in for a document view since Java file should be downloaded when not embedded.
1:58 PM Changeset in webkit [7867] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3790936, make the unicode-breaking on the layout tests match Panther.

Reviewed by kocienda

  • khtml/rendering/break_lines.cpp: (khtml::isBreakable):
12:01 PM Changeset in webkit [7866] by darin
  • 15 edits
    2 deletes in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3317107> text input fields and text areas don't respect background color and text color CSS properties
  • khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement): Create a palette with the background and foreground colors in it and set it on the widget.
  • khtml/rendering/render_style.h: (khtml::StyleVisualData::operator==): No palette to compare with APPLE_CHANGES. Removed palette and palette-related function members.
  • khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): No palette to initialize with APPLE_CHANGES. (RenderStyle::diff): No palette to compare.
  • kwq/KWQLineEdit.h: Added setPalette override. Made text function const.
  • kwq/KWQLineEdit.mm: (QLineEdit::setPalette): Added. Sets foreground and background color based on palette. (QLineEdit::text): Made const.
  • kwq/KWQTextEdit.h: Added setPalette override.
  • kwq/KWQTextEdit.mm: (QTextEdit::setPalette): Added. Sets foreground and background color based on palette.
  • kwq/KWQPalette.h: Removed most things, leaving only background and foreground colors per color group, and only a single color group per palette.
  • kwq/KWQColorGroup.mm: Removed.
  • kwq/KWQPalette.mm: Removed.
  • WebCore.pbproj/project.pbxproj: Removed KWQColorGroup.mm and KWQPalette.mm.
  • kwq/KWQApplication.h: Removed unused palette function.
  • kwq/KWQApplication.mm: Ditto.
  • kwq/KWQWidget.h: Removed unsetPalette.
  • kwq/KWQWidget.mm: Ditto.
  • fixed storage leak
  • khtml/html/html_formimpl.cpp: (DOM::HTMLGenericFormElementImpl::~HTMLGenericFormElementImpl): Roll in storage leak fix from KDE guys.
11:21 AM Changeset in webkit [7865] by cblu
  • 5 edits
    1 add in trunk/WebKit

Fixed:
<rdar://problem/3842030> WebKit needs to pass the mode (NP_FULL, NP_EMBED, etc) when calling plugInViewWithArguments
<rdar://problem/3792852> Safari is loading the new QuickTime Cocoa plugin on Panther

Reviewed by darin.

  • Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): pass "full" as the mode
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): load plug-in with the "webplugin" extension
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): pass "embed" as the mode
  • WebKit.pbproj/project.pbxproj:

Oct 19, 2004:

4:50 PM Changeset in webkit [7864]
  • 3 copies
    3 deletes in tags/WebKit-167~1

This commit was manufactured by cvs2svn to create tag 'WebKit-167~1'.

4:50 PM Changeset in webkit [7863] by vicki
  • 2 edits in trunk/WebKit
  • bump WebKit version to 167.1, so that we can do a quick dot submission for <rdar://problem/3843951>
  • WebKit.pbproj/project.pbxproj:
4:28 PM Changeset in webkit [7862] by hyatt
  • 100 edits in trunk/LayoutTests

Check in updated layout tests.

4:04 PM Changeset in webkit [7861] by hyatt
  • 5 edits
    2 adds in trunk

Reviewed by kocienda

More cleanup of block layout. Eliminates the separate step for tables that dont fit on a line with a float
and consolidates it with clearing.

Also patch dom_textimpl.cpp to reduce further the # of RenderTexts created.

  • khtml/rendering/render_block.cpp: (khtml::getInlineRun): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::adjustFloatingBlock): (khtml::RenderBlock::collapseMargins): (khtml::RenderBlock::clearFloatsIfNeeded): (khtml::RenderBlock::estimateVerticalPosition): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::markAllDescendantsWithFloatsForLayout): (khtml::RenderBlock::getClearDelta): (khtml::RenderBlock::calcBlockMinMaxWidth):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):

Fix for 3841060, regression with * in frames. Reviewed by kocienda.

  • layout-tests/fast/frames/002-expected.txt: Added.
  • layout-tests/fast/frames/002.html: Added.

2004-10-19 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • follow-on to my fix yesterday, which broke a layout test because I rolled out a fix that Maciej had done
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): Need to check the actual queue of external scripts being loaded here. If the current code being run is the external script itself, then we don't want to defer parsing. But loadingExtScript has to stay true until after the script runs. The old code would assume that any time we're running a script there's no need to look at loadingExtScript, but that was also wrong since there can be a script loading in that case too. Layout tests check for both problems.
  • layout-tests/fast/tokenizer/external-script-document-write-expected.txt: Added.
  • layout-tests/fast/tokenizer/external-script-document-write.html: Added.
  • layout-tests/fast/tokenizer/resources/external-script-document-write.js: Added.
  • layout-tests/fast/tokenizer/004.html: Fixed line endings (were CR, should be LF).
3:05 PM Changeset in webkit [7860] by darin
  • 2 edits in trunk/WebKit

Change suggested by Maciej during code review.

  • WebCoreSupport.subproj/WebTextRenderer.m: Changed rounding hack table to be const so it can be in shared instead of private memory, and doesn't require an initialization function. (+[WebTextRenderer initialize]): Removed initialization.
2:56 PM Changeset in webkit [7859] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed <rdar://problem/3838934> Safari stops loading pages after rangeOfCharacterFromSet nil argument exception
  • fixed <rdar://problem/3843951> REGRESSION (166-167): Safari crashes in widthForNextCharacter (belkin.com, at startup for others)
  • fixed <rdar://problem/3841049> REGRESSION (109-110): control characters render as square boxes
  • WebCoreSupport.subproj/WebTextRenderer.m: (isSpace): Merged in isAlternateSpace, never used. (setupRoundingHackCharacterTable): Fixed size of table, was 1 entry too short. Got rid of unneeded call to bzero, since globals start out zeroed automatically. (isRoundingHackCharacter): Fixed backwards logic causing the crash in widthForNextCharacter. Also removed explicit compare with 1; check for non-zero is just fine. (fontContainsString): Change code so we'll just skip the font if the covered character set returns nil rather than throwing an exception like the old version did. This should make bug 3838934 go away, although perhaps covering up the underlying problem. (-[WebTextRenderer _convertCharacters:length:toGlyphs:]): Removed unused skipControlCharacters: parameter and also the unnecessary code to copy the buffer to change newline characters and non-break spaces to spaces. (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): Removed unused local. (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): Added code to set up special cases for control characters, \n and non-break spaces. (-[WebTextRenderer _createATSUTextLayoutForRun:]): Added comment about the cases this code does not handle that are handled by the CG case. (widthForNextCharacter): Call isSpace instead of checking specifically for the space character here. The old code would not handle cases with '\n' coming across from WebCore properly.
2:11 PM Changeset in webkit [7858] by hyatt
  • 2 adds in trunk/LayoutTests/fast/lists/resources

Add image for lists test.

12:01 PM Changeset in webkit [7857] by darin
  • 3 edits
    3 adds in trunk

2004-10-19 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • follow-on to my fix yesterday, which broke a layout test because I rolled out a fix that Maciej had done
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): Need to check the actual queue of external scripts being loaded here. If the current code being run is the external script itself, then we don't want to defer parsing. But loadingExtScript has to stay true until after the script runs. The old code would assume that any time we're running a script there's no need to look at loadingExtScript, but that was also wrong since there can be a script loading in that case too. Layout tests check for both problems.
  • layout-tests/fast/tokenizer/external-script-document-write-expected.txt: Added.
  • layout-tests/fast/tokenizer/external-script-document-write.html: Added.
  • layout-tests/fast/tokenizer/resources/external-script-document-write.js: Added.
  • layout-tests/fast/tokenizer/004.html: Fixed line endings (were CR, should be LF).
9:33 AM Changeset in webkit [7856]
  • 25 copies
    3 deletes in tags/WebKit-125~5~5

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~5'.

9:33 AM Changeset in webkit [7855] by adele
  • 2 edits in branches/Safari-1-2-branch/WebKit

WebKit versioning for SUPanNavy WebKit-125.5.5

Oct 18, 2004:

5:23 PM Changeset in webkit [7854] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/3807234> REGRESSION (152-153): can't get element by ID that was just written with document.write in separate JS file (lacoccinelle.net)
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): Use !isEmpty instead of count != 0, since it's cheaper. (khtml::HTMLTokenizer::write): Roll back to the old version of the check here. The fix is that we only want to look at loadingExtScript if m_executingScript is 0.
4:33 PM Changeset in webkit [7853] by adele
  • 2 edits in branches/Safari-1-2-branch/WebKit

Reviewed by Dave.

This backs out the fix for <rdar://problem/3803113> WebFrame object leaked.

Back out rjw's fix for the frame leak, since it caused the onload handler to fire before
CSS and images had loaded.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _finishedLoading]):
2:52 PM Changeset in webkit [7852] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3840907> textedit doesn't render italic or bold text in html documents

  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::getStringValue): This function did not return string values for idents. Also changed the return value to be DOMString, rather than DOMStringImpl, to deal with the lifecycle issues associated with creating a string to be returned in the ident case.
  • khtml/css/css_valueimpl.h: Change getStringValue to return DOMString rather than DOMStringImpl.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Two calls of getStringValue needed updating.
10:56 AM Changeset in webkit [7851] by cblu
  • 2 edits in trunk/WebCore

Fixed: <rdar://problem/3770135> hang loading page with EMBED tag pointing to same page (tridentantennas.co.uk)

Reviewed by kocienda.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): use completeURL before comparing the URL of the plug-in with the base URL of the document when avoiding frame recursion
10:36 AM Changeset in webkit [7850] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3840916> GC: -[WebNetscapePluginPackage initWithPath:] leaks an NSURL

Reviewed by kevin.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): use executablePath on NSBundle instead of CFBundleCopyExecutableURL
10:30 AM Changeset in webkit [7849] by cblu
  • 2 edits in trunk/WebKit
  • DOM.subproj/DOMPrivate.h: change to copied header that was never committed
9:55 AM Changeset in webkit [7848] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/3810183> Make WebHTMLView respect return value of webView:doCommandBySelector:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView doCommandBySelector:]): only do default action if delegate returns NO; this works with Mail as of Tiger 8A275.
Note: See TracTimeline for information about the timeline view.