Timeline
Oct 25, 2004:
- 5:46 PM Changeset in webkit [7894] by
-
- 3 edits in trunk/WebCore
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::inDesignMode): made inDesignMode const
- khtml/xml/dom_docimpl.h:
- 4:42 PM Changeset in webkit [7893] by
-
- 2 edits in trunk/WebKit
Darin made an internal notification have the Web prefix.
Reviewed by me.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (ConsoleConnectionChangeNotifyProc):
- 4:02 PM Changeset in webkit [7892] by
-
- 2 edits in trunk/WebCore
Reviewed by me, code change by Darin.
- khtml/xml/dom_docimpl.cpp: Moved design mode code outside the XSLT ifdef.
- 3:05 PM Changeset in webkit [7891] by
-
- 3 edits in trunk
Reviewed by me
Oops. These two test results changed with my last checkin, for the better.
- layout-tests/editing/deleting/delete-3800834-fix-expected.txt
- layout-tests/editing/inserting/insert-3775316-fix-expected.txt
- 2:52 PM Changeset in webkit [7890] by
-
- 3 edits6 adds in trunk
Reviewed by Chris
Fix for this bug:
<rdar://problem/3820349> REGRESSION (Mail): select all, delete does not always delete everything
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::startPositionForDelete): New helper that determines when to expand the selection outwards when the selection is on the visible boundary of a root editable element. This fixes the bug. Note that this function also contains a little code I factored out of doApply: it also takes care of adjusting the selection in the smart delete case. (khtml::DeleteSelectionCommand::endPositionForDelete): Ditto. (khtml::DeleteSelectionCommand::doApply): Call new helpers. Refactored out the code as described.
- khtml/editing/htmlediting.h: Declare new helpers.
- layout-tests/editing/deleting/delete-select-all-001-expected.txt: Added.
- layout-tests/editing/deleting/delete-select-all-001.html: Added.
- layout-tests/editing/deleting/delete-select-all-002-expected.txt: Added.
- layout-tests/editing/deleting/delete-select-all-002.html: Added.
- layout-tests/editing/deleting/delete-select-all-003-expected.txt: Added.
- layout-tests/editing/deleting/delete-select-all-003.html: Added.
- 11:49 AM Changeset in webkit [7889] by
-
- 1 edit10 adds in trunk
Reviewed by me
Added some more editing layout tests.
- layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
- layout-tests/editing/deleting/delete-ws-fixup-001.html: Added.
- layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
- layout-tests/editing/deleting/delete-ws-fixup-002.html: Added.
- layout-tests/editing/deleting/delete-ws-fixup-003-expected.txt: Added.
- layout-tests/editing/deleting/delete-ws-fixup-003.html: Added.
- layout-tests/editing/deleting/delete-ws-fixup-004-expected.txt: Added.
- layout-tests/editing/deleting/delete-ws-fixup-004.html: Added.
- layout-tests/editing/inserting/typing-003-expected.txt: Added.
- layout-tests/editing/inserting/typing-003.html: Added.
- 11:48 AM Changeset in webkit [7888] by
-
- 2 edits in trunk/WebCore
Reviewed by John
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): I did not get my fix for 3848343 and 3848224
yesterday quite right: words that should have been placed on the next line were instead
appearing on the line before, beyond the right margin. This was a one-word only error
based on moving the line break object when it should have stayed put. Here is the rule:
The line break object only moves to after the whitespace on the end of a line if that
whitespace caused line overflow when its width is added in.
- 11:26 AM Changeset in webkit [7887] by
-
- 7 edits in trunk/WebCore
Reviewed by Darin.
Fix for <rdar://problem/3619890> Feature request: designMode
This change implements the designMode property of a document. This is an IE property that is also supported by Mozilla.
This will enable more JS editing compatibility.
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): added case for designMode (KJS::HTMLDocument::putValue): added case for designMode
- khtml/ecma/kjs_html.lut.h: (KJS::): regenerated
- khtml/khtml_part.cpp: (KHTMLPart::isContentEditable): Now returns designMode value
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_designMode member variable (DocumentImpl::setDesignMode): added function to assign m_designMode value (DocumentImpl::getDesignMode): return m_designMode value (DocumentImpl::inDesignMode): if designMode is inherited, this will find the appropriate parent document designMode and return that value.
Otherwise, it will just return the m_designMode value.
(DocumentImpl::parentDocument):
- khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::): added InheritedBool enum, prototypes, and m_designMode member variable.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::isContentEditable): added check for isContentEditable function in KHTMLPart
- 10:52 AM Changeset in webkit [7886] by
-
- 3 edits in trunk/WebKit
WebKit:
Reviewed by Chris.
- Cleanup from fix for <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object; eliminated notificationsSuppressed mechanism, which was used only by WebBookmark
- History.subproj/WebHistoryItem.m: removed notificationsSuppressed ivar from private data object (-[WebHistoryItem setAlternateTitle:]): remove notificationsSuppressed guard (-[WebHistoryItem setURLString:]): ditto (-[WebHistoryItem setOriginalURLString:]): ditto (-[WebHistoryItem setTitle:]): ditto (-[WebHistoryItem _setLastVisitedTimeInterval:]): ditto (-[WebHistoryItem setNotificationsSuppressed:]): removed this method (-[WebHistoryItem notificationsSuppressed]): ditto
- History.subproj/WebHistoryItemPrivate.h: removed notificationsSuppressed and setNotificationsSuppressed
WebBrowser:
Reviewed by Chris.
- fixed these bugs: <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object <rdar://problem/3852373> Could eliminate -[WebBookmark lastVisitedTimeInterval] for performance
This reduced RPRVT after launch with the standard set of built-in bookmarks on my machine from
4.12M to 4.09M, and sped up reading bookmarks a little also.
- BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Don't set lastVisitedTimeInterval here
- URLCompletionController.m: (-[URLCompletionController _addStatsForURL:]): Added comment to this #defined-away method explaining that it wouldn't work as-is anymore since it calls the obsolete setLastVisitedTimeInterval
- WebBookmark.h: remove lastVisitedTimeInterval and setLastVisitedTimeInterval
- WebBookmark.m: removed _URL, setLastVisitedTimeInterval, and lastVisitedTimeInterval
- WebBookmarkExporter.m: (-[WebBookmarkExporter stringForBookmarkLeaf:withIndentLevel:]): Don't export last visited time anymore
- WebBookmarkGroup.m: (-[WebBookmarkGroup _addBookmarkToURLStringDictionary:]): use [bookmark URLString] instead of [bookmark _URL]. The latter was getting the URL from its WebHistoryItem, which no longer exists.
- WebBookmarkLeaf.h: remove _entry ivar, add _title ivar
- WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): removed this method, which set up _entry (-[WebBookmarkLeaf initWithURLString:title:group:]): weaned from _entry, also calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase is updated properly (-[WebBookmarkLeaf initFromDictionaryRepresentation:topLevelOnly:withGroup:]): ditto (-[WebBookmarkLeaf dictionaryRepresentation]): weaned from _entry (-[WebBookmarkLeaf dealloc]): calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase is updated properly (-[WebBookmarkLeaf copyWithZone:]): ditto (-[WebBookmarkLeaf title]): weaned from _entry (-[WebBookmarkLeaf setTitle:]): ditto (-[WebBookmarkLeaf icon]): ditto (-[WebBookmarkLeaf URLString]): ditto (-[WebBookmarkLeaf setURLString:]): ditto, also updates WebIconDatabase (-[WebBookmarkLeaf setLastVisitedTimeInterval:]): removed this method (-[WebBookmarkLeaf lastVisitedTimeInterval]): ditto (-[WebBookmarkLeaf _computeIsRSSBookmark]): use isSyndicationURLString on a string instead of isSyndicationURL on a URL
- WebBookmarkPrivate.h: removed _URL method
Oct 22, 2004:
- 5:19 PM Changeset in webkit [7885] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3851491> installedPlugins being called for a page without plugins
Reviewed by mjs.
- WebView.subproj/WebFrameView.m: (+[WebFrameView _canShowMIMETypeAsHTML:]): call _viewTypesAllowImageTypeOmission instead of using ivar since the ivar is nil until _viewTypesAllowImageTypeOmission is called, this was causing [WebView canShowMIMEType:] to check plug-ins
- 3:26 PM Changeset in webkit [7884] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3844662> REGRESSION (Mail): Style changes can affect adjacent, unselected text
- khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::doApply): Move end position downstream to be sure we remove style from everything that could be affected. (khtml::ApplyStyleCommand::removeCSSStyle): Comma in intended function call was outside the braces, making it act as a comma operator, with a zero value as the right value!!! This made an important check always fail!!! It turns out that we do not want the constant at all, since that constant is only needed when checking a computed style, not an inline style as is being done here. (khtml::ApplyStyleCommand::removeStyle): Call nodeFullySelected with new interface. (khtml::ApplyStyleCommand::nodeFullySelected): Change interface and implementation to rely on RangeImpl::compareBoundaryPoints to perform the required check.
- khtml/editing/htmlediting.h: Changed nodeFullySelected function interface.
- 1:07 PM Changeset in webkit [7883] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bugs:
<rdar://problem/3848343> REGRESSION (Mail, 166-168u): Typed text after space at end of line before block quote does not appear
<rdar://problem/3848224> REGRESSION (Mail): space typed at end of line vanishes after typing next character
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): When the khtmlLineBreak is in AFTER_WHITE_SPACE mode, as it is when we are editing, add in the space of the current character when calculating the width of committed plus uncommitted characters. If this value exceeds the width of the line, move up the line break object and call skipWhitespace to move past the end of the whitespace.
- 12:14 PM Changeset in webkit [7882] by
-
- 3 edits in trunk
versioning for TOT. the tree is open!
- 12:04 PM Changeset in webkit [7881]
-
- 2 copies in tags/Safari-168
This commit was manufactured by cvs2svn to create tag 'Safari-168'.
- 12:04 PM Changeset in webkit [7880] by
-
- 6 edits in trunk
Safari-168 stamp
- 9:20 AM Changeset in webkit [7879] by
-
- 6 edits in trunk
Reviewed by me
- JavaScriptCore.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.
WebCore:
Reviewed by me
- WebCore.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.
WebKit:
Reviewed by me
- WebKit.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.
Oct 21, 2004:
- 6:08 PM Changeset in webkit [7878] by
-
- 2 edits2 adds in trunk
Reviewed by darin
Clean up the inline run function so that it doesn't return incorrect answers when making children non-inline.
<rdar://problem/3848724> REGRESSION (166-168u): RenderText::layout called, firing assertion that kills Mail
<rdar://problem/3848357> RenderText::layout called, firing assertion that kills Safari (www.apple.com/downloads/macosx)
- khtml/rendering/render_block.cpp: (khtml::getInlineRun): (khtml::RenderBlock::makeChildrenNonInline):
- 5:00 PM Changeset in webkit [7877] by
-
- 2 adds in trunk/LayoutTests/fast/dynamic
Add layout test for dynamic block/inline crash.
- 4:45 PM Changeset in webkit [7876] by
-
- 2 edits in trunk/WebCore
Fix for 3810389, crash because of continuation() craziness. Revert back to the old behavior of
making sure that all line boxes get deleted and recreated when inlines are split because of a block.
Reviewed darin
- khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):
- 2:19 PM Changeset in webkit [7875] by
-
- 27 edits in trunk
Reviewed by Darin
Significant improvement to the way that whitespace is handled during editing.
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): New functions (there are actually two being added with this name) that delete "insignificant" unrendered text. (khtml::CompositeEditCommand::deleteInsignificantTextDownstream): Takes a position, calculates the downstream position to use as the endpoint for the deletion, and then calls deleteInsignificantText with this start and end. (khtml::DeleteSelectionCommand::doApply): Call new deleteInsignificantTextDownstream function. (khtml::InputNewlineCommand::doApply): Ditto. (khtml::InputTextCommand::input): Ditto.
- khtml/editing/htmlediting.h: Add new declarations.
Modified layout test results:
- layout-tests/editing/deleting/delete-block-merge-contents-016-expected.txt:
- layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt:
- layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt:
- layout-tests/editing/deleting/delete-selection-001-expected.txt:
- layout-tests/editing/deleting/delete-tab-001-expected.txt:
- layout-tests/editing/deleting/delete-tab-004-expected.txt:
- layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt:
- layout-tests/editing/inserting/insert-3659587-fix-expected.txt:
- layout-tests/editing/inserting/insert-3775316-fix-expected.txt:
- layout-tests/editing/inserting/insert-3778059-fix-expected.txt:
- layout-tests/editing/inserting/insert-br-001-expected.txt:
- layout-tests/editing/inserting/insert-br-004-expected.txt:
- layout-tests/editing/inserting/insert-br-005-expected.txt:
- layout-tests/editing/inserting/insert-br-006-expected.txt:
- layout-tests/editing/inserting/insert-tab-001-expected.txt:
- layout-tests/editing/inserting/insert-tab-002-expected.txt:
- layout-tests/editing/inserting/insert-tab-004-expected.txt:
- layout-tests/editing/inserting/insert-text-with-newlines-expected.txt:
- layout-tests/editing/inserting/typing-001-expected.txt:
- layout-tests/editing/inserting/typing-around-br-001-expected.txt:
- layout-tests/editing/inserting/typing-around-image-001-expected.txt:
- layout-tests/editing/style/typing-style-003-expected.txt:
- layout-tests/editing/undo/redo-typing-001-expected.txt:
- layout-tests/editing/undo/undo-typing-001-expected.txt:
- 2:12 PM Changeset in webkit [7874] by
-
- 2 edits in trunk/WebCore
Fix for 3847054, assertion failure in RenderText::layout() on news.com page. Fix getInlineRun so that
it no longer breaks early (thus causing some children not to get properly wrapped by anonymous blocks).
Reviewed by darin
- khtml/rendering/render_block.cpp: (khtml::getInlineRun):
- 10:04 AM Changeset in webkit [7873] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3847994> REGRESSION: reproducible exception in WebImageRenderer releasePatternColor; afterwards get crash or no more browsing
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage createRendererIfNeeded]): Replaced retainOrCopyIfNeeded with this. This returns nil if a copied renderer isn't needed, and returns a new renderer if a copy is. The old version was sometimes returning a WebInternalImage and other times a WebImageRenderer. (-[WebImageRenderer retainOrCopyIfNeeded]): Returns the result of createRendererIfNeeded or retains self and returns self.
