Timeline



Oct 27, 2004:

3:41 PM Changeset in webkit [7907] by kocienda
  • 8 edits in trunk

WebCore:

Reviewed by Chris

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteSelection): Added new mergeBlocksAfterDelete flag to control whether content not in the block containing the start of the selection is moved to that block after the selection is deleted. (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Ditto. (khtml::DeleteSelectionCommand::doApply): Ditto. (khtml::InputNewlineInQuotedContentCommand::InputNewlineInQuotedContentCommand): New command to handle the case of inserting a newline when in quoted content in Mail. (khtml::InputNewlineInQuotedContentCommand::~InputNewlineInQuotedContentCommand): Ditto. (khtml::InputNewlineInQuotedContentCommand::isMailBlockquote): Ditto. (khtml::InputNewlineInQuotedContentCommand::isLastVisiblePositionInBlockquote): Ditto. (khtml::InputNewlineInQuotedContentCommand::doApply): Ditto. (khtml::TypingCommand::insertNewlineInQuotedContent): Support for new newline command. (khtml::TypingCommand::doApply): Ditto. (khtml::TypingCommand::preservesTypingStyle): Ditto.
  • khtml/editing/htmlediting.h: Add new delclarations. (khtml::TypingCommand::): Ditto.
  • kwq/WebCoreBridge.h: Added new bridge method called from WebKit.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge insertNewlineInQuotedContent]): Ditto.

WebKit:

Reviewed by Chris

Added new SPI for Mail so it can get the behavior it needs when the user hits
the return key with the selection in quoted content.

  • WebView.subproj/WebView.m
  • WebView.subproj/WebViewPrivate.h
3:09 PM Changeset in webkit [7906]
  • 11 copies
    3 deletes in tags/WebKit-146~2

This commit was manufactured by cvs2svn to create tag 'WebKit-146~2'.

3:09 PM Changeset in webkit [7905] by vicki
  • 2 edits in branches/WWDC-2004-branch/WebKit

WebKit:

  • bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy
  • WebKit.pbproj/project.pbxproj:

WebBrowser:

  • bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy
  • WebBrowser.pbproj/project.pbxproj:
3:01 PM Changeset in webkit [7904]
  • 11 copies
    2 deletes in tags/WebCore-146~3

This commit was manufactured by cvs2svn to create tag
'WebCore-146~3'.

3:01 PM Changeset in webkit [7903]
  • 16 copies
    3 deletes in tags/JavaScriptCore-146~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~3'.

3:01 PM Changeset in webkit [7902] by vicki
  • 4 edits in branches/WWDC-2004-branch

JavaScriptCore:

  • bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

WebCore:

  • bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy
  • WebCore.pbproj/project.pbxproj:

Oct 26, 2004:

3:13 PM Changeset in webkit [7901] by cblu
  • 4 edits in trunk/WebCore

Fixed: <rdar://problem/3774243> page up/down, arrow up/down, etc in Safari RSS should scroll main content

Reviewed by dave.

  • khtml/ecma/kjs_dom.cpp: (DOMElementProtoFunc::tryCall): added scrollByLines and scrollByPages to HTML element for Safari RSS
  • khtml/ecma/kjs_dom.h: (KJS::DOMElement::):
  • khtml/ecma/kjs_dom.lut.h: (KJS::):
2:08 PM Changeset in webkit [7900] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3848214, deleting a partial word left a repaint artifact if the partial word was pulled back onto
the previous line.

Reviewed by kocienda

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
1:15 PM Changeset in webkit [7899] by hyatt
  • 3 edits in trunk/WebCore

Convert selectionRect() from using a list to a dict and patch it to be like setSelection. It was still trying
to use the old dirty bit optimization (which had been removed), and so it was pathologically slow on large documents.

Reviewed by kocienda

  • khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect):
  • khtml/rendering/render_object.h: (khtml::RenderObject::hasSelectedChildren):
12:57 PM Changeset in webkit [7898] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug

<rdar://problem/3851164> mail crashed when I pasted a large amount of text into a reply

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): This now returns bool to let the caller know if a placeholder was removed. (khtml::ReplaceSelectionCommand::doApply): Use the bool return value from the call to removeBlockPlaceholderIfNeeded. If true, shift the selection to the now-empty block. In some cases, the selection was still set on the removed BR, and this was the cause of the crash.
  • khtml/editing/htmlediting.h: Change removeBlockPlaceholderIfNeeded return type.
11:26 AM Changeset in webkit [7897] by darin
  • 2 edits in trunk/WebCore

Reviewed by Chris.

  • fixed <rdar://problem/3851301> leak of one NSCFDictionary for each XMLHttpRequest issued
  • kwq/KWQLoader.mm: (KWQServeSynchronousRequest): Add a release.
10:40 AM Changeset in webkit [7896] by cblu
  • 2 edits in trunk/WebKit

Fixed exception that Darin encountered in Mail.

Reviewed by darin.

  • Plugins.subproj/WebPluginController.m: (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): if the plug-in returns a nil view, return nil
10:08 AM Changeset in webkit [7895] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): Do not call replaceText with a zero-length string. That triggers an assert. Call deleteText instead, using the same indices that are passed to replaceText.

Cleaned up the asserts in these three functions below, making them
more consistent. This is not needed for the fix, but I tripped over
these in the course of debugging.

(khtml::InsertTextCommand::InsertTextCommand):
(khtml::InsertTextCommand::doApply):
(khtml::InsertTextCommand::doUnapply):

Oct 25, 2004:

5:46 PM Changeset in webkit [7894] by adele
  • 3 edits in trunk/WebCore
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::inDesignMode): made inDesignMode const
  • khtml/xml/dom_docimpl.h:
4:42 PM Changeset in webkit [7893] by cblu
  • 2 edits in trunk/WebKit

Darin made an internal notification have the Web prefix.

Reviewed by me.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (ConsoleConnectionChangeNotifyProc):
4:02 PM Changeset in webkit [7892] by adele
  • 2 edits in trunk/WebCore

Reviewed by me, code change by Darin.

  • khtml/xml/dom_docimpl.cpp: Moved design mode code outside the XSLT ifdef.
3:05 PM Changeset in webkit [7891] by kocienda
  • 3 edits in trunk

Reviewed by me

Oops. These two test results changed with my last checkin, for the better.

  • layout-tests/editing/deleting/delete-3800834-fix-expected.txt
  • layout-tests/editing/inserting/insert-3775316-fix-expected.txt
2:52 PM Changeset in webkit [7890] by kocienda
  • 3 edits
    6 adds in trunk

Reviewed by Chris

Fix for this bug:

<rdar://problem/3820349> REGRESSION (Mail): select all, delete does not always delete everything

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::startPositionForDelete): New helper that determines when to expand the selection outwards when the selection is on the visible boundary of a root editable element. This fixes the bug. Note that this function also contains a little code I factored out of doApply: it also takes care of adjusting the selection in the smart delete case. (khtml::DeleteSelectionCommand::endPositionForDelete): Ditto. (khtml::DeleteSelectionCommand::doApply): Call new helpers. Refactored out the code as described.
  • khtml/editing/htmlediting.h: Declare new helpers.
  • layout-tests/editing/deleting/delete-select-all-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-select-all-001.html: Added.
  • layout-tests/editing/deleting/delete-select-all-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-select-all-002.html: Added.
  • layout-tests/editing/deleting/delete-select-all-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-select-all-003.html: Added.
11:49 AM Changeset in webkit [7889] by kocienda
  • 1 edit
    10 adds in trunk

Reviewed by me

Added some more editing layout tests.

  • layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-001.html: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-002.html: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-003.html: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-004-expected.txt: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-004.html: Added.
  • layout-tests/editing/inserting/typing-003-expected.txt: Added.
  • layout-tests/editing/inserting/typing-003.html: Added.
11:48 AM Changeset in webkit [7888] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): I did not get my fix for 3848343 and 3848224

yesterday quite right: words that should have been placed on the next line were instead

appearing on the line before, beyond the right margin. This was a one-word only error
based on moving the line break object when it should have stayed put. Here is the rule:
The line break object only moves to after the whitespace on the end of a line if that
whitespace caused line overflow when its width is added in.

11:26 AM Changeset in webkit [7887] by adele
  • 7 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/3619890> Feature request: designMode

This change implements the designMode property of a document. This is an IE property that is also supported by Mozilla.
This will enable more JS editing compatibility.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): added case for designMode (KJS::HTMLDocument::putValue): added case for designMode
  • khtml/ecma/kjs_html.lut.h: (KJS::): regenerated
  • khtml/khtml_part.cpp: (KHTMLPart::isContentEditable): Now returns designMode value
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_designMode member variable (DocumentImpl::setDesignMode): added function to assign m_designMode value (DocumentImpl::getDesignMode): return m_designMode value (DocumentImpl::inDesignMode): if designMode is inherited, this will find the appropriate parent document designMode and return that value.

Otherwise, it will just return the m_designMode value.

(DocumentImpl::parentDocument):

  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::): added InheritedBool enum, prototypes, and m_designMode member variable.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::isContentEditable): added check for isContentEditable function in KHTMLPart
10:52 AM Changeset in webkit [7886] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

  • Cleanup from fix for <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object; eliminated notificationsSuppressed mechanism, which was used only by WebBookmark
  • History.subproj/WebHistoryItem.m: removed notificationsSuppressed ivar from private data object (-[WebHistoryItem setAlternateTitle:]): remove notificationsSuppressed guard (-[WebHistoryItem setURLString:]): ditto (-[WebHistoryItem setOriginalURLString:]): ditto (-[WebHistoryItem setTitle:]): ditto (-[WebHistoryItem _setLastVisitedTimeInterval:]): ditto (-[WebHistoryItem setNotificationsSuppressed:]): removed this method (-[WebHistoryItem notificationsSuppressed]): ditto
  • History.subproj/WebHistoryItemPrivate.h: removed notificationsSuppressed and setNotificationsSuppressed

WebBrowser:

Reviewed by Chris.

  • fixed these bugs: <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object <rdar://problem/3852373> Could eliminate -[WebBookmark lastVisitedTimeInterval] for performance

This reduced RPRVT after launch with the standard set of built-in bookmarks on my machine from
4.12M to 4.09M, and sped up reading bookmarks a little also.

  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Don't set lastVisitedTimeInterval here
  • URLCompletionController.m: (-[URLCompletionController _addStatsForURL:]): Added comment to this #defined-away method explaining that it wouldn't work as-is anymore since it calls the obsolete setLastVisitedTimeInterval
  • WebBookmark.h: remove lastVisitedTimeInterval and setLastVisitedTimeInterval
  • WebBookmark.m: removed _URL, setLastVisitedTimeInterval, and lastVisitedTimeInterval
  • WebBookmarkExporter.m: (-[WebBookmarkExporter stringForBookmarkLeaf:withIndentLevel:]): Don't export last visited time anymore
  • WebBookmarkGroup.m: (-[WebBookmarkGroup _addBookmarkToURLStringDictionary:]): use [bookmark URLString] instead of [bookmark _URL]. The latter was getting the URL from its WebHistoryItem, which no longer exists.
  • WebBookmarkLeaf.h: remove _entry ivar, add _title ivar
  • WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): removed this method, which set up _entry (-[WebBookmarkLeaf initWithURLString:title:group:]): weaned from _entry, also calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase is updated properly (-[WebBookmarkLeaf initFromDictionaryRepresentation:topLevelOnly:withGroup:]): ditto (-[WebBookmarkLeaf dictionaryRepresentation]): weaned from _entry (-[WebBookmarkLeaf dealloc]): calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase is updated properly (-[WebBookmarkLeaf copyWithZone:]): ditto (-[WebBookmarkLeaf title]): weaned from _entry (-[WebBookmarkLeaf setTitle:]): ditto (-[WebBookmarkLeaf icon]): ditto (-[WebBookmarkLeaf URLString]): ditto (-[WebBookmarkLeaf setURLString:]): ditto, also updates WebIconDatabase (-[WebBookmarkLeaf setLastVisitedTimeInterval:]): removed this method (-[WebBookmarkLeaf lastVisitedTimeInterval]): ditto (-[WebBookmarkLeaf _computeIsRSSBookmark]): use isSyndicationURLString on a string instead of isSyndicationURL on a URL
  • WebBookmarkPrivate.h: removed _URL method
Note: See TracTimeline for information about the timeline view.