Timeline
Oct 29, 2004:
- 4:51 PM Changeset in webkit [7920] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (170u)
- 4:42 PM Changeset in webkit [7919]
-
- 2 copies in tags/Safari-169
This commit was manufactured by cvs2svn to create tag 'Safari-169'.
- 4:42 PM Changeset in webkit [7918] by
-
- 6 edits in trunk
Safari-169 stamp
- 2:53 PM Changeset in webkit [7917] by
-
- 2 edits in trunk/WebCore
Reviewed by NOBODY (OOPS!).
- fixed <rdar://problem/3751619> Safari crash in khtml::CircularSearchBuffer::append(QChar const&)
- khtml/editing/visible_text.cpp: (khtml::findPlainText): Fix exit condition to check for break before advancing one character; before it did it backwards.
- 2:48 PM Changeset in webkit [7916] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3853262> REGRESSION(166-168) gmail gets blank page when loading
Reviewed by kocienda, adele.
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): remove infinite frame recursion check for iframes
- 1:16 PM Changeset in webkit [7915] by
-
- 2 edits in trunk/WebKit
- WebKit.exp: added _WebPlugInModeKey, forgot to add it earlier
- 11:59 AM Changeset in webkit [7914] by
-
- 3 edits in trunk/WebCore
Reviewed by Chris.
- fixed <rdar://problem/3857395> clicking on calendar in Apple Travel site crashes Safari in invalidateClick (getthere.net)
- khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): Use a SharedPtr<KHTMLView> to make sure the KHTMLView is not deleted before this function finishes running. (KHTMLView::viewportMouseDoubleClickEvent): Ditto. (KHTMLView::viewportMouseReleaseEvent): Ditto. (KHTMLView::dispatchMouseEvent): Removed ref/deref pairs that aren't needed since dispatchEvent is guaranteed to do ref/deref as needed.
- kwq/KWQObject.mm: (QObject::startTimer): Fixed a comment.
- 11:11 AM Changeset in webkit [7913] by
-
- 2 edits in trunk/WebKit
- fixed <rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments
- Plugins.subproj/WebScriptObject.h: Removed unneeded #ifdef protection for multiple includes (since this is an Objective-C header and we use #import for those). Fixed comments as requested in the bug report to match the contents of the file.
Oct 28, 2004:
- 4:14 PM Changeset in webkit [7912] by
-
- 3 edits in trunk/WebCore
Enabled XSLT on Panther. See intrigue mail for compiling instructions.
Reviewed by darin.
- WebCore.pbproj/project.pbxproj: link against xslt unconditionally, link against specific version of libxml on Panther
- WebCorePrefix.h: always use XSLT
- 3:35 PM Changeset in webkit [7911] by
-
- 3 edits in trunk/WebCore
Reviewed by Chris
Fix for these bugs:
<rdar://problem/3854848> Tiger Mail Crash in WebCore - khtml::CompositeEditCommand::insertNodeAfter
<rdar://problem/3803832> REGRESSION (Mail): incorrect behavior after Return + Delete in quoted text
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Added node pointer class members to initialization list, zeroing them out. (khtml::DeleteSelectionCommand::canPerformSpecialCaseBRDelete): New special-case helper to handle a delete of content in special cases where the only thing selected is a BR. This code path is much simpler than the newly-named performGeneralDelete, and detects when no content merging should be done between blocks. This aspect of the change fixes 3854848. One of the special cases added fixes 3803832. (khtml::DeleteSelectionCommand::performGeneralDelete): Renamed, from performDelete. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Made this helper be a no-arg function, just like the other helpers in this class. (khtml::DeleteSelectionCommand::clearTransientState): Fix cut and paste error in deref code. (khtml::DeleteSelectionCommand::doApply): Updated for changed helpers.
- khtml/editing/htmlediting.h: Added new helper and changed an old one.
- 3:05 PM Changeset in webkit [7910] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3856913> Panther-only crash in QString code copying front page of store.apple.com
Reviewed by darin.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): check that the renderer is a list item before making list item calls on it
- 1:07 PM Changeset in webkit [7909] by
-
- 3 edits in trunk/WebCore
Reviewed by Harrison
Reorganization of delete command functionality so that doApply is not
several hundred lines long. This is not a squeaky-clean cleanup, but
it is a step in the right direction. No functionality changes.
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): (khtml::DeleteSelectionCommand::initializePositionData): New helper. (khtml::DeleteSelectionCommand::saveTypingStyleState): Ditto. (khtml::DeleteSelectionCommand::performDelete): Ditto. (khtml::DeleteSelectionCommand::fixupWhitespace): Ditto. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Ditto. (khtml::DeleteSelectionCommand::calculateEndingPosition): Ditto. (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto. (khtml::DeleteSelectionCommand::clearTransientState): Ditto. (khtml::DeleteSelectionCommand::doApply): Factor out code into new helpers.
- khtml/editing/htmlediting.h:
- 9:38 AM Changeset in webkit [7908] by
-
- 2 edits in trunk/WebCore
Reviewed by me
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Typo in initializer caused new mergeBlocksAfterDelete flag to be set improperly, causing layout regressions.
Oct 27, 2004:
- 3:41 PM Changeset in webkit [7907] by
-
- 8 edits in trunk
WebCore:
Reviewed by Chris
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteSelection): Added new mergeBlocksAfterDelete flag to control whether content not in the block containing the start of the selection is moved to that block after the selection is deleted. (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Ditto. (khtml::DeleteSelectionCommand::doApply): Ditto. (khtml::InputNewlineInQuotedContentCommand::InputNewlineInQuotedContentCommand): New command to handle the case of inserting a newline when in quoted content in Mail. (khtml::InputNewlineInQuotedContentCommand::~InputNewlineInQuotedContentCommand): Ditto. (khtml::InputNewlineInQuotedContentCommand::isMailBlockquote): Ditto. (khtml::InputNewlineInQuotedContentCommand::isLastVisiblePositionInBlockquote): Ditto. (khtml::InputNewlineInQuotedContentCommand::doApply): Ditto. (khtml::TypingCommand::insertNewlineInQuotedContent): Support for new newline command. (khtml::TypingCommand::doApply): Ditto. (khtml::TypingCommand::preservesTypingStyle): Ditto.
- khtml/editing/htmlediting.h: Add new delclarations. (khtml::TypingCommand::): Ditto.
- kwq/WebCoreBridge.h: Added new bridge method called from WebKit.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge insertNewlineInQuotedContent]): Ditto.
WebKit:
Reviewed by Chris
Added new SPI for Mail so it can get the behavior it needs when the user hits
the return key with the selection in quoted content.
- WebView.subproj/WebView.m
- WebView.subproj/WebViewPrivate.h
- 3:09 PM Changeset in webkit [7906]
-
- 11 copies3 deletes in tags/WebKit-146~2
This commit was manufactured by cvs2svn to create tag 'WebKit-146~2'.
- 3:09 PM Changeset in webkit [7905] by
-
- 2 edits in branches/WWDC-2004-branch/WebKit
WebKit:
- bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy
- WebKit.pbproj/project.pbxproj:
WebBrowser:
- bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy
- WebBrowser.pbproj/project.pbxproj:
- 3:01 PM Changeset in webkit [7904]
-
- 11 copies2 deletes in tags/WebCore-146~3
This commit was manufactured by cvs2svn to create tag
'WebCore-146~3'.
- 3:01 PM Changeset in webkit [7903]
-
- 16 copies3 deletes in tags/JavaScriptCore-146~3
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~3'.
- 3:01 PM Changeset in webkit [7902] by
-
- 4 edits in branches/WWDC-2004-branch
- bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy
- JavaScriptCore.pbproj/project.pbxproj:
WebCore:
- bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy
- WebCore.pbproj/project.pbxproj:
Oct 26, 2004:
- 3:13 PM Changeset in webkit [7901] by
-
- 4 edits in trunk/WebCore
Fixed: <rdar://problem/3774243> page up/down, arrow up/down, etc in Safari RSS should scroll main content
Reviewed by dave.
- khtml/ecma/kjs_dom.cpp: (DOMElementProtoFunc::tryCall): added scrollByLines and scrollByPages to HTML element for Safari RSS
- khtml/ecma/kjs_dom.h: (KJS::DOMElement::):
- khtml/ecma/kjs_dom.lut.h: (KJS::):
- 2:08 PM Changeset in webkit [7900] by
-
- 2 edits in trunk/WebCore
Fix for 3848214, deleting a partial word left a repaint artifact if the partial word was pulled back onto
the previous line.
Reviewed by kocienda
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
- 1:15 PM Changeset in webkit [7899] by
-
- 3 edits in trunk/WebCore
Convert selectionRect() from using a list to a dict and patch it to be like setSelection. It was still trying
to use the old dirty bit optimization (which had been removed), and so it was pathologically slow on large documents.
Reviewed by kocienda
- khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect):
- khtml/rendering/render_object.h: (khtml::RenderObject::hasSelectedChildren):
- 12:57 PM Changeset in webkit [7898] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt
- Fix for this bug
<rdar://problem/3851164> mail crashed when I pasted a large amount of text into a reply
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): This now returns bool to let the caller know if a placeholder was removed. (khtml::ReplaceSelectionCommand::doApply): Use the bool return value from the call to removeBlockPlaceholderIfNeeded. If true, shift the selection to the now-empty block. In some cases, the selection was still set on the removed BR, and this was the cause of the crash.
- khtml/editing/htmlediting.h: Change removeBlockPlaceholderIfNeeded return type.
- 11:26 AM Changeset in webkit [7897] by
-
- 2 edits in trunk/WebCore
Reviewed by Chris.
- fixed <rdar://problem/3851301> leak of one NSCFDictionary for each XMLHttpRequest issued
- kwq/KWQLoader.mm: (KWQServeSynchronousRequest): Add a release.
- 10:40 AM Changeset in webkit [7896] by
-
- 2 edits in trunk/WebKit
Fixed exception that Darin encountered in Mail.
Reviewed by darin.
- Plugins.subproj/WebPluginController.m: (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): if the plug-in returns a nil view, return nil
- 10:08 AM Changeset in webkit [7895] by
-
- 2 edits in trunk/WebCore
Reviewed by John
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): Do not call replaceText with a zero-length string. That triggers an assert. Call deleteText instead, using the same indices that are passed to replaceText.
Cleaned up the asserts in these three functions below, making them
more consistent. This is not needed for the fix, but I tripped over
these in the course of debugging.
(khtml::InsertTextCommand::InsertTextCommand):
(khtml::InsertTextCommand::doApply):
(khtml::InsertTextCommand::doUnapply):
