Timeline
Nov 1, 2004:
- 3:46 PM Changeset in webkit [7927] by
-
- 3 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3861469> Latest Real player crashes Safari on some sites.
Reviewed by Ken.
- bindings/c/c_instance.cpp: (CInstance::invokeMethod): (CInstance::invokeDefaultMethod): Initialize out parameters to void type.
- bindings/c/c_runtime.cpp: (CField::valueFromInstance): (CField::setValueToInstance): Initialize out parameters to void type. Also added additional checks to protect against classes that don't implement all functions.
- 2:33 PM Changeset in webkit [7926] by
-
- 3 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3861257> WebUndefined should be returned for undefined values
Reviewed by John.
- ChangeLog:
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::root:Bindings::]): Added additional conversion Undefined -> WebUndefined.
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): Added additional conversion WebUndefined -> Undefined.
- 2:21 PM Changeset in webkit [7925] by
-
- 2 edits in branches/Safari-1-2-branch/WebCore
Fixed: <rdar://problem/3860882> Safari URI status bar spoofing using a nested <a> links in a table
Rolled fix from TOT to 1.2 branch.
Reviewed by adele.
- khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPoint): Make sure the URL element is the innermost one, by not setting it once it's already set.
- 2:20 PM Changeset in webkit [7924] by
-
- 2 edits in trunk/WebCore
Reviewed by rjw.
fixed <rdar://problem/3681094> Crash in KJS::WindowFunc::tryCall with application/xhtml+xml Content-Type
once and for all.
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Added a nil check in the case of an empty document lacking a baseURL().
- 1:23 PM Changeset in webkit [7923] by
-
- 2 edits in trunk/JavaScriptCore
- fixed <rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments
- bindings/objc/WebScriptObject.h: Removed unneeded #ifdef protection for multiple includes (since this is an Objective-C header and we use #import for those). Fixed comments as requested in the bug report to match the contents of the file.
- 11:21 AM Changeset in webkit [7922] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
- fixed <rdar://problem/3859381> REGRESSION (167-168): text in form fields should not use body's text color
- khtml/css/html4.css: Use color: initial for textarea and related ones.
- 9:56 AM Changeset in webkit [7921] by
-
- 9 edits6 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3775920> REGRESSION (Mail): Centering doesn't work in HTML mail
- khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::copyInheritableProperties): Factor out the implementation here into new copyPropertiesInSet helper. This now calls the generalized copyPropertiesInSet function with the arguments needed to make copying inheritable work.
- khtml/css/css_computedstyle.h:
- khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::diff): Move this function here from css_computedstyle.cpp. In order to do apply block properties, "regular" style declarations need to do style diffs as well. (CSSStyleDeclarationImpl::copyBlockProperties): New helper. Just like copyInheritableProperties except that it uses a different set of properties that apply only to blocks. (CSSStyleDeclarationImpl::copyPropertiesInSet): New helper that looks at a style declaration and copies out those properties listed in a pre-defined set.
- khtml/css/css_valueimpl.h:
- khtml/editing/htmlediting.cpp: (khtml::StyleChange::StyleChange): Modified to work with style changes that apply to a whole block, factoring out some of the special case code that should now only run in the inline case. (khtml::StyleChange::init): Factored out the code that now is in checkForLegacyHTMLStyleChange. (khtml::StyleChange::checkForLegacyHTMLStyleChange): New helper for case where we want special handling for "legacy" HTML styles like <B> and <I>. (khtml::ApplyStyleCommand::doApply): Much refactoring in this class to divide up the work of style changes into different kinds. CSS specifies certain properties only apply to certain element types. This set of changes now recognizes two such separate cases: styles that apply to blocks, and styles that apply to inlines. (khtml::ApplyStyleCommand::applyBlockStyle): New function to handle apply styles to whole blocks. (khtml::ApplyStyleCommand::applyInlineStyle): New function to handle apply styles to inlines. (khtml::ApplyStyleCommand::isHTMLStyleNode): Is now passed a CSSStyleDeclarationImpl to work with rather than working on the CSSStyleDeclarationImpl member variable of the class. This is done so that the function can be passed a portion of the styles being applied so that block styles and inline styles can be handled separately. (khtml::ApplyStyleCommand::removeCSSStyle): Ditto. (khtml::ApplyStyleCommand::removeBlockStyle): New function to handle removing styles from whole blocks. (khtml::ApplyStyleCommand::removeInlineStyle): New function to removing styles from inlines. (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): New function to handle applying style to whole blocks. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): New function to handle applying style to inlines.
- khtml/editing/htmlediting.h: (khtml::StyleChange::): Changed as described above. (khtml::StyleChange::usesLegacyStyles): (khtml::EditCommand::setEndingSelectionNeedsLayout): New function to that tells the ending selection it needs to layout, even though it has not changed position in the DOM. For instance, this is needed when text align changes.
- khtml/khtml_part.cpp: (KHTMLPart::setTypingStyle): Put in an early bail-out in the case where the current style matches the passed-in argument. (KHTMLPart::applyStyle): Modify this function so that block styles are applied when the selection is a caret. Formerly, this just set typing style and made no visible changes to the document.
New tests.
- layout-tests/editing/editing.js: Added some glue to change text align.
- layout-tests/editing/style/block-style-001-expected.txt: Added.
- layout-tests/editing/style/block-style-001.html: Added.
- layout-tests/editing/style/block-style-002-expected.txt: Added.
- layout-tests/editing/style/block-style-002.html: Added.
- layout-tests/editing/style/block-style-003-expected.txt: Added.
- layout-tests/editing/style/block-style-003.html: Added.
Oct 29, 2004:
- 4:51 PM Changeset in webkit [7920] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (170u)
- 4:42 PM Changeset in webkit [7919]
-
- 2 copies in tags/Safari-169
This commit was manufactured by cvs2svn to create tag 'Safari-169'.
- 4:42 PM Changeset in webkit [7918] by
-
- 6 edits in trunk
Safari-169 stamp
- 2:53 PM Changeset in webkit [7917] by
-
- 2 edits in trunk/WebCore
Reviewed by NOBODY (OOPS!).
- fixed <rdar://problem/3751619> Safari crash in khtml::CircularSearchBuffer::append(QChar const&)
- khtml/editing/visible_text.cpp: (khtml::findPlainText): Fix exit condition to check for break before advancing one character; before it did it backwards.
- 2:48 PM Changeset in webkit [7916] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3853262> REGRESSION(166-168) gmail gets blank page when loading
Reviewed by kocienda, adele.
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): remove infinite frame recursion check for iframes
- 1:16 PM Changeset in webkit [7915] by
-
- 2 edits in trunk/WebKit
- WebKit.exp: added _WebPlugInModeKey, forgot to add it earlier
- 11:59 AM Changeset in webkit [7914] by
-
- 3 edits in trunk/WebCore
Reviewed by Chris.
- fixed <rdar://problem/3857395> clicking on calendar in Apple Travel site crashes Safari in invalidateClick (getthere.net)
- khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): Use a SharedPtr<KHTMLView> to make sure the KHTMLView is not deleted before this function finishes running. (KHTMLView::viewportMouseDoubleClickEvent): Ditto. (KHTMLView::viewportMouseReleaseEvent): Ditto. (KHTMLView::dispatchMouseEvent): Removed ref/deref pairs that aren't needed since dispatchEvent is guaranteed to do ref/deref as needed.
- kwq/KWQObject.mm: (QObject::startTimer): Fixed a comment.
- 11:11 AM Changeset in webkit [7913] by
-
- 2 edits in trunk/WebKit
- fixed <rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments
- Plugins.subproj/WebScriptObject.h: Removed unneeded #ifdef protection for multiple includes (since this is an Objective-C header and we use #import for those). Fixed comments as requested in the bug report to match the contents of the file.
Oct 28, 2004:
- 4:14 PM Changeset in webkit [7912] by
-
- 3 edits in trunk/WebCore
Enabled XSLT on Panther. See intrigue mail for compiling instructions.
Reviewed by darin.
- WebCore.pbproj/project.pbxproj: link against xslt unconditionally, link against specific version of libxml on Panther
- WebCorePrefix.h: always use XSLT
- 3:35 PM Changeset in webkit [7911] by
-
- 3 edits in trunk/WebCore
Reviewed by Chris
Fix for these bugs:
<rdar://problem/3854848> Tiger Mail Crash in WebCore - khtml::CompositeEditCommand::insertNodeAfter
<rdar://problem/3803832> REGRESSION (Mail): incorrect behavior after Return + Delete in quoted text
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Added node pointer class members to initialization list, zeroing them out. (khtml::DeleteSelectionCommand::canPerformSpecialCaseBRDelete): New special-case helper to handle a delete of content in special cases where the only thing selected is a BR. This code path is much simpler than the newly-named performGeneralDelete, and detects when no content merging should be done between blocks. This aspect of the change fixes 3854848. One of the special cases added fixes 3803832. (khtml::DeleteSelectionCommand::performGeneralDelete): Renamed, from performDelete. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Made this helper be a no-arg function, just like the other helpers in this class. (khtml::DeleteSelectionCommand::clearTransientState): Fix cut and paste error in deref code. (khtml::DeleteSelectionCommand::doApply): Updated for changed helpers.
- khtml/editing/htmlediting.h: Added new helper and changed an old one.
- 3:05 PM Changeset in webkit [7910] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3856913> Panther-only crash in QString code copying front page of store.apple.com
Reviewed by darin.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): check that the renderer is a list item before making list item calls on it
- 1:07 PM Changeset in webkit [7909] by
-
- 3 edits in trunk/WebCore
Reviewed by Harrison
Reorganization of delete command functionality so that doApply is not
several hundred lines long. This is not a squeaky-clean cleanup, but
it is a step in the right direction. No functionality changes.
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): (khtml::DeleteSelectionCommand::initializePositionData): New helper. (khtml::DeleteSelectionCommand::saveTypingStyleState): Ditto. (khtml::DeleteSelectionCommand::performDelete): Ditto. (khtml::DeleteSelectionCommand::fixupWhitespace): Ditto. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Ditto. (khtml::DeleteSelectionCommand::calculateEndingPosition): Ditto. (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto. (khtml::DeleteSelectionCommand::clearTransientState): Ditto. (khtml::DeleteSelectionCommand::doApply): Factor out code into new helpers.
- khtml/editing/htmlediting.h:
- 9:38 AM Changeset in webkit [7908] by
-
- 2 edits in trunk/WebCore
Reviewed by me
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Typo in initializer caused new mergeBlocksAfterDelete flag to be set improperly, causing layout regressions.
Note:
See TracTimeline
for information about the timeline view.
