Timeline

Nov 8, 2004:

7:46 PM Changeset in webkit [7959] by harrison

• 2 edits
  2 adds in trunk

Reviewed by Ken Kocienda.

<rdar://problem/3865854> Deleting first line deletes all lines

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::performGeneralDelete): Problem was that the code that deletes fully selected m_downstreamEnd.node() by deleting one of its ancestors, failed to end the loop that deletes all fully selected nodes. Also, fixed this code to clear m_trailingWhitespaceValid. Also removed dead m_endingPosition update because it is handled in calculateEndingPosition now.
• layout-tests/editing/deleting/delete-3865854-fix-expected.txt: Added.
• layout-tests/editing/deleting/delete-3865854-fix.html: Added.

4:32 PM Changeset in webkit [7958] by kocienda

• 7 edits in trunk/WebCore

Reviewed by Hyatt

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Now takes flag to control whether comments are added to the DOM.
• khtml/html/html_elementimpl.h: Ditto.
• khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Ditto. (KHTMLParser::getElement): Remove ifdef for comment processing. Replace with flag check.
• khtml/html/htmlparser.h: Add flag to constructor so callers can request comment nodes.
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): Add flag to constructor so callers can request comment nodes. (khtml::HTMLTokenizer::parseComment): Fix code to handle parsing out comment text correctly. There were a couple of indexing errors that resulted in the comment text containing part of the comment markers. (khtml::HTMLTokenizer::processToken): Don't let token id be reset to ID_TEXT if token is a comment.
• khtml/html/htmltokenizer.h: Add flag to constructor so callers can request comment nodes.

4:22 PM Changeset in webkit [7957] by cblu

• 4 edits in trunk/WebCore

Fixed: <rdar://problem/3870907> WebCore unnecessary links against JavaVM and Security

Reviewed by darin.

• WebCore.pbproj/project.pbxproj: stop unnecessary linking
• khtml/html/html_objectimpl.h: don't unnecessarily include JavaVM header
• kwq/KWQKHTMLPart.h: ditto

4:02 PM Changeset in webkit [7956] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3825966> 8A274 Safari crashes closing window: QTimer::fire() with MallocStackLogging and MallocScribble enabled

• kwq/KWQTimer.mm: (QTimer::fire): Rearrange so we don't access the QTimer object after calling code that possibly deletes the QTimer.

11:11 AM Changeset in webkit [7955] by cblu

• 7 edits in trunk

WebCore:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

• kwq/KWQTextField.mm: (-[KWQTextFieldController textView:shouldHandleEvent:]): let the bridge have a crack at the event so that it can swallow the newline if it wants to
• kwq/WebCoreBridge.h:

WebKit:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge control:textView:shouldHandleEvent:]): new
• WebView.subproj/WebFormDelegate.h:
• WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate control:textView:shouldHandleEvent:inFrame:]): new

WebBrowser:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

• BrowserWebController.m: (-[FormDelegate control:textView:shouldHandleEvent:inFrame:]): new
• CompletionController.h:
• CompletionController.m: (-[CompletionController handleInsertNewline]): new, factored out from next method (-[CompletionController control:textView:doCommandBySelector:]): call handleInsertNewline
• FormCompletionController.h:
• FormCompletionController.m: (-[FormCompletionController control:textView:shouldHandleEvent:]): new, call handleInsertNewline so that WebCore does not submit the form when a newline is entered

10:31 AM Changeset in webkit [7954] by harrison

• 4 edits in trunk/WebCore

Reviewed by Darin.

Renamed NodeImpl::enclosingNonBlockFlowElement to NodeImpl::enclosingInlineElement, per Hyatt.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingInlineElement):
• khtml/xml/dom_nodeimpl.h:

Nov 5, 2004:

4:45 PM Changeset in webkit [7953] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3854218> Safari is sometimes really slow because of increased null events to plug-ins

• Plugins.subproj/WebBaseNetscapePluginView.m: reverted null event interval to 0.02

4:36 PM Changeset in webkit [7952] by cblu

• 7 edits in trunk/WebCore

Fixed: <rdar://problem/3838413> REGRESSION (Mail): "Smart" word paste adds spaces before/after special characters

Reviewed by rjw.

• khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): call isCharacterSmartReplaceExempt on the part to see if a space should be inserted
• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::character): new, returns the character for the position
• khtml/editing/visible_position.h:
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::isCharacterSmartReplaceExempt): new, calls the bridge
• kwq/WebCoreBridge.h:

4:36 PM Changeset in webkit [7951] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3838413> REGRESSION (Mail): "Smart" word paste adds spaces before/after special characters

Reviewed by rjw.

• WebCoreSupport.subproj/WebBridge.m: (_getPreSmartSet): copied from AppKit (_getPostSmartSet): ditto (-[WebBridge isCharacterSmartReplaceExempt:isPreviousCharacter:]): new

3:31 PM Changeset in webkit [7950] by rjw

• 4 edits in trunk/WebKit

Fixed <rdar://problem/3810702> _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector: ASSERTS when reentered from Xcode's man page viewer

Reviewed by Maciej (a long time ago).

• WebView.subproj/WebFrame.m: (-[WebFrame _loadDataSource:withLoadType:formState:]):

Fixed <rdar://problem/3845307> WebKit needs to export _HIWebViewRegisterClass so HIWebViews can work in Carbon nib files

As suggested in the bug, the fix is to actually call
HIWebViewRegisterClass in WebKitInitForCarbon, rather than
exporting the symbol.

Reviewed by Chris.

• Carbon.subproj/CarbonUtils.m: (WebInitForCarbon):
• Carbon.subproj/HIWebView.m:
• WebKit.pbproj/project.pbxproj:

2:11 PM Changeset in webkit [7949] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (170+)

1:59 PM Changeset in webkit [7948]

• 2 copies in tags/Safari-170

This commit was manufactured by cvs2svn to create tag 'Safari-170'.

1:59 PM Changeset in webkit [7947] by vicki

• 6 edits in trunk

Safari-170 stamp

1:14 PM Changeset in webkit [7946] by rjw

• 2 edits in trunk/WebKit/Carbon.subproj

Backing out change because tree is closed.

12:38 PM Changeset in webkit [7945] by rjw

• 3 edits in trunk/WebKit

Fixed <rdar://problem/3845307> WebKit needs to export _HIWebViewRegisterClass so HIWebViews can work in Carbon nib files

Reviewed by Chris.

• Carbon.subproj/CarbonUtils.m: (WebInitForCarbon):
• Carbon.subproj/HIWebView.m:

10:45 AM Changeset in webkit [7944] by adele

• 4 edits in trunk/WebCore

Reviewed by Darin

Fix for <rdar://problem/3854383> REGRESSION(166-168) input fields show black background when background color is set to transparent
and a workaround for displaying transparent backgrounds for textareas.

• kwq/KWQLineEdit.mm: (QLineEdit::setPalette): If the background color is transparent (we check the alpha value) then we set the background to white
• kwq/KWQTextEdit.mm: (QTextEdit::setPalette): If the background color is transparent then we don't draw the background
• kwq/KWQTextArea.mm: (-[KWQTextArea setDrawsBackground:]): added setDrawsBackground function which calls setDrawsBackground on the super class, on the contentView, and on the textView.

10:00 AM Changeset in webkit [7943] by darin

• 2 edits in trunk/WebKit

Reviewed by Chris.

• fixed <rdar://problem/3857151> Assertion failure in "trackingRectOwner" while moving mouse over Slashdot.org page

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Changed to no longer call addTrackingRect to do the work for consistency with the new method below. Not too much copied and pasted code. (-[WebHTMLView _addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): Added an override for this new method in Tiger. No harm in implementing it on Panther, although it won't be called. (-[WebHTMLView _removeTrackingRects:count:]): Ditto.

Nov 4, 2004:

7:09 PM Changeset in webkit [7942] by hyatt

• 13 edits in trunk/LayoutTests

land updated layout tests for the relpositioned change, the ex unit change, and the text-top vertical-align change

6:59 PM Changeset in webkit [7941] by hyatt

• 9 edits in trunk/WebCore

Fix for relpositioned inlines. This was reviewed a long time ago, but I can't recall who reviewed it (either
darin or ken).

Reviewed by darin or ken

• khtml/rendering/bidi.cpp: (khtml::appendRunsForObject): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):
• khtml/rendering/render_box.cpp: (RenderBox::position):
• khtml/rendering/render_box.h: (khtml::RenderBox::staticX): (khtml::RenderBox::staticY):
• khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::convertToLayerCoords):
• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::placeBoxesHorizontally):
• khtml/rendering/render_object.h: (khtml::RenderObject::staticX): (khtml::RenderObject::staticY):

Finish turning on XSLT. Make sure child stylesheets can load.

• khtml/xsl/xslt_processorimpl.cpp: (DOM::stylesheetLoadFunc): (DOM::XSLTProcessorImpl::transformDocument):

5:19 PM Changeset in webkit [7940] by hyatt

• 2 edits in trunk/WebKit

Make sure the dominant line direction is properly set for RTL runs so that spaces will reverse.

Change xHeight to measure the ascent of the x glyph, since the xHeight metrics appear to be
totally bogus in both CG and AppKit.

Reviewed by darin

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): (-[WebTextRenderer _createATSUTextLayoutForRun:style:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):

5:18 PM Changeset in webkit [7939] by hyatt

• 15 edits in trunk/WebCore

Implement CSS3 support for multiple backgrounds. Also fix a bug with background propagation so that it only
happens (from the <body> to the root) for HTML documents. Fixed background-position to handle a mixture of
keyword and length values.

Reviewed by darin

• khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::addBackgroundValue): (CSSParser::parseBackgroundShorthand): (CSSParser::parseBackgroundColor): (CSSParser::parseBackgroundImage): (CSSParser::parseBackgroundPositionXY): (CSSParser::parseBackgroundPosition): (CSSParser::parseBackgroundProperty): (CSSParser::parseColorFromValue):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::mapBackgroundAttachment): (khtml::CSSStyleSelector::mapBackgroundImage): (khtml::CSSStyleSelector::mapBackgroundRepeat): (khtml::CSSStyleSelector::mapBackgroundXPosition): (khtml::CSSStyleSelector::mapBackgroundYPosition):
• khtml/css/cssstyleselector.h:
• khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBoxDecorations): (RenderBox::paintBackgrounds): (RenderBox::paintBackground): (RenderBox::paintBackgroundExtended):
• khtml/rendering/render_box.h:
• khtml/rendering/render_form.cpp: (RenderFieldset::paintBoxDecorations):
• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paintBackgrounds): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder):
• khtml/rendering/render_line.h:
• khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::updateBackgroundImages): (RenderObject::getVerticalPosition):
• khtml/rendering/render_object.h: (khtml::RenderObject::paintBackgroundExtended):
• khtml/rendering/render_style.cpp: (m_next): (BackgroundLayer::BackgroundLayer): (BackgroundLayer::~BackgroundLayer): (BackgroundLayer::operator=): (BackgroundLayer::operator==): (BackgroundLayer::fillUnsetProperties): (BackgroundLayer::cullEmptyLayers): (StyleBackgroundData::StyleBackgroundData): (StyleBackgroundData::operator==): (RenderStyle::diff): (RenderStyle::adjustBackgroundLayers):
• khtml/rendering/render_style.h: (khtml::OutlineValue::operator==): (khtml::OutlineValue::operator!=): (khtml::BackgroundLayer::backgroundImage): (khtml::BackgroundLayer::backgroundXPosition): (khtml::BackgroundLayer::backgroundYPosition): (khtml::BackgroundLayer::backgroundAttachment): (khtml::BackgroundLayer::backgroundRepeat): (khtml::BackgroundLayer::next): (khtml::BackgroundLayer::isBackgroundImageSet): (khtml::BackgroundLayer::isBackgroundXPositionSet): (khtml::BackgroundLayer::isBackgroundYPositionSet): (khtml::BackgroundLayer::isBackgroundAttachmentSet): (khtml::BackgroundLayer::isBackgroundRepeatSet): (khtml::BackgroundLayer::setBackgroundImage): (khtml::BackgroundLayer::setBackgroundXPosition): (khtml::BackgroundLayer::setBackgroundYPosition): (khtml::BackgroundLayer::setBackgroundAttachment): (khtml::BackgroundLayer::setBackgroundRepeat): (khtml::BackgroundLayer::clearBackgroundImage): (khtml::BackgroundLayer::clearBackgroundXPosition): (khtml::BackgroundLayer::clearBackgroundYPosition): (khtml::BackgroundLayer::clearBackgroundAttachment): (khtml::BackgroundLayer::clearBackgroundRepeat): (khtml::BackgroundLayer::setNext): (khtml::BackgroundLayer::operator!=): (khtml::BackgroundLayer::containsImage): (khtml::BackgroundLayer::hasImage): (khtml::BackgroundLayer::hasFixedImage): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::hasBackground): (khtml::RenderStyle::hasFixedBackgroundImage): (khtml::RenderStyle::outlineWidth): (khtml::RenderStyle::outlineStyle): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineColor): (khtml::RenderStyle::backgroundColor): (khtml::RenderStyle::backgroundImage): (khtml::RenderStyle::backgroundRepeat): (khtml::RenderStyle::backgroundAttachment): (khtml::RenderStyle::backgroundXPosition): (khtml::RenderStyle::backgroundYPosition): (khtml::RenderStyle::accessBackgroundLayers): (khtml::RenderStyle::backgroundLayers): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::resetOutline): (khtml::RenderStyle::setBackgroundColor): (khtml::RenderStyle::setOutlineWidth): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineColor): (khtml::RenderStyle::clearBackgroundLayers): (khtml::RenderStyle::inheritBackgroundLayers): (khtml::RenderStyle::setOutlineOffset):
• khtml/rendering/render_table.cpp: (RenderTable::paintBoxDecorations): (RenderTableCell::paintBoxDecorations):

4:32 PM Changeset in webkit [7938] by hyatt

• 2 edits in trunk/WebCore

Make sure the text decoder returns empty strings rather than null strings when the utf8 char ptr is non-null.
Ensures that <a href=""> works with libxml (which returns data in utf-8 buffers).

Reviewed by darin

• kwq/KWQTextCodec.mm: (KWQTextDecoder::convertLatin1): (KWQTextDecoder::convertUTF16): (KWQTextDecoder::convertUsingTEC): (KWQTextDecoder::toUnicode):

4:30 PM Changeset in webkit [7937] by hyatt

• 2 edits in trunk/WebCore

Make sure line-height returns the correct value for normal.

Reviewed by darin

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):

1:07 PM Changeset in webkit [7936] by darin

• 1 delete in trunk/LayoutTests/.cvsignore

Don't ignore results file since it's not here any more.

10:29 AM Changeset in webkit [7935] by harrison

• 4 edits
  2 adds in trunk

Reviewed by Ken Kocienda.

<rdar://problem/3857753> REGRESSION (Mail): Delete incorrectly causes text to take on new style

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Fixed to move entire source subtree (up to, but not including, the enclosingBlockFlowElement) rather than just the source element. Fixed to insert after the destination subtree, rather than the destination element. Handles edge case of deleting back to the top of the tree, where there is nothing left to insert after.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingNonBlockFlowElement): New method to support moveNodesAfterNode changes.
• khtml/xml/dom_nodeimpl.h: Declare NodeImpl::enclosingNonBlockFlowElement
• layout-tests/editing/deleting/delete-3857753-fix-expected.txt: Added.
• layout-tests/editing/deleting/delete-3857753-fix.html: Added.

9:16 AM Changeset in webkit [7934] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed <rdar://problem/3865365> since -[WebScriptObject dealloc] does not call [super dealloc], the build will fail due to a warning
• fixed behavior so that [[WebScriptObject alloc] initWithCoder:] doesn't leak WebUndefined instances and incidentally so that [[WebScriptObject alloc] init] returns the single shared instance rather than allocating a new one

• bindings/objc/WebScriptObject.mm: Removed some stray semicolons. (+[WebUndefined allocWithZone:]): Made this the common bottleneck that returns the single instance of WebUndefined, since it's the single method that normally allocates new instances. Calls super to actually allocate only the very first time it's called. (-[WebUndefined initWithCoder:]): Simplified to just return self (no reason to re-lookup the single shared instance since there can be only one). (-[WebUndefined copyWithZone:]): Ditto. (-[WebUndefined retain]): Ditto. (-[WebUndefined retainCount]): Use UINT_MAX constant here (matches usage in NSObject.m for retain count of class). (-[WebUndefined autorelease]): Simplified to just return self (see above). (-[WebUndefined copy]): No need to override this since it just turns around and calls copyWithZone:. (-[WebUndefined dealloc]): Added an assertion since this method should never be called. Also added a call to [super dealloc] after return; to make the new -Wdealloc-check compiler happy (fixing the bug mentioned above). (+[WebUndefined undefined]): Reimplemented; calls allocWithZone:NULL to get to the shared instance. No need to call init, since that's a no-op for this class.