Timeline
Nov 10, 2004:
- 6:08 PM Changeset in webkit [7971] by
-
- 2 edits in trunk/WebCore
Reviewed by mjs.
Fixed <rdar://problem/3875011> DOMNodeList::tryGet() performs unnecessary (and expensive) dom tree traversals. Improved a loop from 2-n-squared to just n-squared.
- khtml/ecma/kjs_dom.cpp: (DOMNodeList::tryGet): Got rid of an unnecessary node traversal.
- 2:39 PM Changeset in webkit [7970] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/3396872> ICONS: icon DB inconsistencies can cause slowness during startup, idle and quit
Reviewed by john.
- Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase objectForKey:]): added logging code
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): use alloc, init rather than autorelease, retain (-[WebIconDatabase _loadIconDictionaries]): use 1 object for mapping icon URLs to site URLs and vice versa rather than 3. This avoids inconsistencies and is faster. (-[WebIconDatabase _updateFileDatabase]): write 1 object out
- 2:03 PM Changeset in webkit [7969] by
-
- 2 edits in trunk/WebCore
Reviewed by Chris
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Move position adjustments for smart delete from the two functions below to here. There was an unnecessary double calculation of the leading and trailing whitespace positions. Also refined the trailing case so it only acts when the leading position is null (which seems to match TextEdit in my tests). Also removed some unnecessary copying of Position objects. (khtml::DeleteSelectionCommand::startPositionForDelete): Move out smart delete adjustment from here. (khtml::DeleteSelectionCommand::endPositionForDelete): Ditto.
- 11:04 AM Changeset in webkit [7968] by
-
- 4 edits in trunk/WebCore
Reviewed by Harrison
(khtml::DeleteSelectionCommand::performGeneralDelete): Add some more comments to
make things more clear.
- khtml/editing/selection.cpp: (khtml::Selection::toRange): Fixed the upstream and downstream calls so that the resulting positions do not cross block boundaries. This was a bug and caused some delete problems when whole blocks were selected. I will be addressing that issue more fully in upcoming changes.
- 8:58 AM Changeset in webkit [7967] by
-
- 2 edits in trunk/WebCore
Reviewed by Harrison
Some cleanups and fixes in upstream and downstream functions.
Removed redundant checks for isBlockFlow() when calling enclosingBlockFlowElement().
Blocks do not need to skip the call to enclosingBlockFlowElement() for fear that the
block's enclosing block will be returned.
Remove code from upstream that confined the serach to block boundaries outside of
the code which runs in the StayInBlock case. This code was redundant, and caused
incorrect results to be returned in the DoNotStayInBlock case.
In downstream, the check for crossing into a new block should use the equivalentDeepPosition()
node, not the the this pointer's node.
- khtml/xml/dom_position.cpp: (DOM::Position::upstream) (DOM::Position::downstream)
Nov 9, 2004:
- 7:47 PM Changeset in webkit [7966] by
-
- 14 edits in trunk/WebCore
Fix for 3873234, Safari UI is unresponsive when parsing multiple HTML docs and 3873233, Safari hangs when
loading large local files.
Reviewed by mjs
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::stopped): (khtml::HTMLTokenizer::processingData): (khtml::HTMLTokenizer::continueProcessing): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::allDataProcessed): (khtml::HTMLTokenizer::end): (khtml::HTMLTokenizer::finish): (khtml::HTMLTokenizer::notifyFinished):
- khtml/html/htmltokenizer.h:
- khtml/khtml_part.cpp: (KHTMLPart::slotFinished): (KHTMLPart::end): (KHTMLPart::stop):
- khtml/khtml_part.h: (KHTMLPart::tokenizerProcessedData):
- khtml/khtmlview.cpp:
- khtml/xml/dom_docimpl.cpp:
- khtml/xml/xml_tokenizer.h: (khtml::Tokenizer::stopped): (khtml::Tokenizer::processingData):
- kwq/KWQDateTime.h:
- kwq/KWQDateTime.mm: (QDateTime::secsTo): (KWQUIEventTime::uiEventPending):
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::tokenizerProcessedData):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge stop]): (-[WebCoreBridge numPendingOrLoadingRequests]): (-[WebCoreBridge doneProcessingData]):
- 7:46 PM Changeset in webkit [7965] by
-
- 3 edits in trunk/WebKit
Fix for 3873234, Safari UI is unresponsive when parsing multiple HTML docs and 3873233, Safari hangs when
loading large local files.
Reviewed by mjs
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge tokenizerProcessedData]):
- WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource isLoading]):
- 5:04 PM Changeset in webkit [7964] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken Kocienda.
<rdar://problem/3865837> Wrong text style after delete to start of document
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::saveTypingStyleState): Sample computedStyle of m_selectionToDelete.start instead of m_downstreamStart.
- 4:28 PM Changeset in webkit [7963] by
-
- 2 edits1 add in trunk/JavaScriptCore
Fixed: <rdar://problem/3872724> soft link against JavaVM to save ~2MB RSHRD
Reviewed by rjw.
- ChangeLog:
- JavaScriptCore.pbproj/project.pbxproj: don't link against JavaVM
- bindings/softlinking.c: Added. (loadFramework): new (getFunctionPointer): new (JNI_GetCreatedJavaVMs): load JavaVM if not already loaded, get _JNI_GetCreatedJavaVMs symbol if we don't already have it, call JNI_GetCreatedJavaVMs
- 1:52 PM Changeset in webkit [7962] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3872440> NSTimer prematurely released.
Reviewed by Darin.
- kwq/KWQTimer.mm: (QTimer::fire):
- kwq/KWQWidget.mm: (QWidget::paint):
- 12:57 PM Changeset in webkit [7961] by
-
- 3 edits in trunk/WebKit
Fixed <rdar://problem/3870964> 8A300: Safari not recognizing a PDF link (it displays raw data)
Add "text/pdf" as an acceptable PDF MIME type.
Reviewed by Chris.
- WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
- WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
- 12:52 PM Changeset in webkit [7960] by
-
- 2 edits in trunk/WebCore
Reviewed by vicki.
- WebCore.pbproj/project.pbxproj: explicitly link against libxml2.2.6.14.dylib since the version number has been bumped
Nov 8, 2004:
- 7:46 PM Changeset in webkit [7959] by
-
- 2 edits2 adds in trunk
Reviewed by Ken Kocienda.
<rdar://problem/3865854> Deleting first line deletes all lines
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::performGeneralDelete): Problem was that the code that deletes fully selected m_downstreamEnd.node() by deleting one of its ancestors, failed to end the loop that deletes all fully selected nodes. Also, fixed this code to clear m_trailingWhitespaceValid. Also removed dead m_endingPosition update because it is handled in calculateEndingPosition now.
- layout-tests/editing/deleting/delete-3865854-fix-expected.txt: Added.
- layout-tests/editing/deleting/delete-3865854-fix.html: Added.
- 4:32 PM Changeset in webkit [7958] by
-
- 7 edits in trunk/WebCore
Reviewed by Hyatt
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Now takes flag to control whether comments are added to the DOM.
- khtml/html/html_elementimpl.h: Ditto.
- khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Ditto. (KHTMLParser::getElement): Remove ifdef for comment processing. Replace with flag check.
- khtml/html/htmlparser.h: Add flag to constructor so callers can request comment nodes.
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): Add flag to constructor so callers can request comment nodes. (khtml::HTMLTokenizer::parseComment): Fix code to handle parsing out comment text correctly. There were a couple of indexing errors that resulted in the comment text containing part of the comment markers. (khtml::HTMLTokenizer::processToken): Don't let token id be reset to ID_TEXT if token is a comment.
- khtml/html/htmltokenizer.h: Add flag to constructor so callers can request comment nodes.
- 4:22 PM Changeset in webkit [7957] by
-
- 4 edits in trunk/WebCore
Fixed: <rdar://problem/3870907> WebCore unnecessary links against JavaVM and Security
Reviewed by darin.
- WebCore.pbproj/project.pbxproj: stop unnecessary linking
- khtml/html/html_objectimpl.h: don't unnecessarily include JavaVM header
- kwq/KWQKHTMLPart.h: ditto
- 4:02 PM Changeset in webkit [7956] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3825966> 8A274 Safari crashes closing window: QTimer::fire() with MallocStackLogging and MallocScribble enabled
- kwq/KWQTimer.mm: (QTimer::fire): Rearrange so we don't access the QTimer object after calling code that possibly deletes the QTimer.
- 11:11 AM Changeset in webkit [7955] by
-
- 7 edits in trunk
WebCore:
Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus
Reviewed by john.
- kwq/KWQTextField.mm: (-[KWQTextFieldController textView:shouldHandleEvent:]): let the bridge have a crack at the event so that it can swallow the newline if it wants to
- kwq/WebCoreBridge.h:
WebKit:
Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus
Reviewed by john.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge control:textView:shouldHandleEvent:]): new
- WebView.subproj/WebFormDelegate.h:
- WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate control:textView:shouldHandleEvent:inFrame:]): new
WebBrowser:
Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus
Reviewed by john.
- BrowserWebController.m: (-[FormDelegate control:textView:shouldHandleEvent:inFrame:]): new
- CompletionController.h:
- CompletionController.m: (-[CompletionController handleInsertNewline]): new, factored out from next method (-[CompletionController control:textView:doCommandBySelector:]): call handleInsertNewline
- FormCompletionController.h:
- FormCompletionController.m: (-[FormCompletionController control:textView:shouldHandleEvent:]): new, call handleInsertNewline so that WebCore does not submit the form when a newline is entered
- 10:31 AM Changeset in webkit [7954] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin.
Renamed NodeImpl::enclosingNonBlockFlowElement to NodeImpl::enclosingInlineElement, per Hyatt.
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingInlineElement):
- khtml/xml/dom_nodeimpl.h:
