Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 22, 2004:

11:58 PM Changeset in webkit [8075] by hyatt

• 2 edits in trunk/WebCore

Make sure you can use document.createElement to make a <canvas> element.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement):

11:45 PM Changeset in webkit [8074] by mjs

• 6 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3492044> performing JavaScript operations on form elements is slower than WinIE (HTMLFormCollection)
<rdar://problem/3489679> selecting an item on the Apache bugzilla query page is very slow (HTMLFormCollection)
<rdar://problem/3477810> checking 80 check boxes with JavaScript is 10x slower than in IE (HTMLFormCollection)
<rdar://problem/3760962> JavaScript that toggles checkboxes is slow (HTMLCollection,HTMLFormCollection)

• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet):
• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): (DOM::HTMLFormElementImpl::~HTMLFormElementImpl):
• khtml/html/html_formimpl.h:
• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::HTMLCollectionImpl): (HTMLCollectionImpl::~HTMLCollectionImpl): (HTMLCollectionImpl::CollectionInfo::CollectionInfo): (HTMLCollectionImpl::CollectionInfo::reset): (HTMLCollectionImpl::resetCollectionInfo): (HTMLCollectionImpl::checkForNameMatch): (appendToVector): (HTMLCollectionImpl::updateNameCache): (HTMLCollectionImpl::namedItems): (HTMLFormCollectionImpl::HTMLFormCollectionImpl): (HTMLFormCollectionImpl::~HTMLFormCollectionImpl): (HTMLFormCollectionImpl::item): (HTMLFormCollectionImpl::updateNameCache):
• khtml/html/html_miscimpl.h:

11:23 PM Changeset in webkit [8073] by hyatt

• 2 edits in trunk/WebKit

Make sure the WebCore cache grows at 512mb and at 1024mb exactly.

Reviewed by mjs

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getObjectCacheSize]):

11:21 PM Changeset in webkit [8072] by hyatt

• 3 edits in trunk/WebCore

Improve the WebCore cache so that the maximum cacheable object size is scaled based off the total cache
size.

Reviewed by mjs

• khtml/misc/loader.cpp: (CachedObject::finish): (Cache::flush): (Cache::setSize):
• khtml/misc/loader.h: (khtml::Cache::maxCacheableObjectSize):

9:50 PM Changeset in webkit [8071] by hyatt

• 1 edit in trunk/WebCore/khtml/rendering/render_frames.cpp

Fix mistake made with frameset hit testing from previous checkin.

9:08 PM Changeset in webkit [8070] by hyatt

• 30 edits in trunk/WebCore

Fix for 3673381, huge directory listing so slow it seems like a hang. Rework painting and hit testing so that
it crawls the line box tree instead of the render tree. This allows more precise intersection/containment testing
that lets us short circuit earlier when painting and hit testing.

Reviewed by mjs

• khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint): (khtml::RenderBlock::paintChildren): (khtml::RenderBlock::paintObject): (khtml::RenderBlock::paintFloats): (khtml::RenderBlock::nodeAtPoint):
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::nodeAtPoint):
• khtml/rendering/render_box.h:
• khtml/rendering/render_br.h:
• khtml/rendering/render_canvas.cpp: (RenderCanvas::paint):
• khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): (RenderFlow::hitTestLines): (RenderFlow::caretRect): (RenderFlow::addFocusRingRects): (RenderFlow::paintFocusRing): (RenderFlow::paintOutlines): (RenderFlow::paintOutlineForLine):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint):
• khtml/rendering/render_frames.h:
• khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
• khtml/rendering/render_image.h:
• khtml/rendering/render_inline.cpp: (RenderInline::paint): (RenderInline::nodeAtPoint):
• khtml/rendering/render_inline.h:
• khtml/rendering/render_layer.cpp: (RenderLayer::paintLayer): (RenderLayer::hitTest): (RenderLayer::hitTestLayer):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_line.cpp: (khtml::InlineBox::paint): (khtml::InlineBox::nodeAtPoint): (khtml::InlineFlowBox::flowObject): (khtml::InlineFlowBox::nodeAtPoint): (khtml::InlineFlowBox::paint): (khtml::InlineFlowBox::paintBackgrounds): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder): (khtml::InlineFlowBox::paintDecorations): (khtml::EllipsisBox::paint): (khtml::EllipsisBox::nodeAtPoint): (khtml::RootInlineBox::paintEllipsisBox): (khtml::RootInlineBox::paint): (khtml::RootInlineBox::nodeAtPoint):
• khtml/rendering/render_line.h: (khtml::InlineRunBox::paintBackgroundAndBorder):
• khtml/rendering/render_object.cpp: (RenderObject::hitTest): (RenderObject::setInnerNode): (RenderObject::nodeAtPoint):
• khtml/rendering/render_object.h: (khtml::RenderObject::PaintInfo::PaintInfo): (khtml::RenderObject::PaintInfo::~PaintInfo): (khtml::RenderObject::paintingRootForChildren): (khtml::RenderObject::shouldPaintWithinRoot):
• khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTable::paint):
• khtml/rendering/render_text.cpp: (simpleDifferenceBetweenColors): (correctedTextColor): (InlineTextBox::nodeAtPoint): (InlineTextBox::paint): (InlineTextBox::selectionStartEnd): (InlineTextBox::paintSelection): (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::paintDecoration): (RenderText::posOfChar):
• khtml/rendering/render_text.h: (khtml::RenderText::paint): (khtml::RenderText::layout): (khtml::RenderText::nodeAtPoint):
• khtml/xml/dom2_eventsimpl.cpp: (MouseEventImpl::computeLayerPos):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
• kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityHitTest:]):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollOverflowWithScrollWheelEvent): (KWQKHTMLPart::eventMayStartDrag): (KWQKHTMLPart::khtmlMouseMoveEvent):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): (-[WebCoreBridge _positionForPoint:]):

8:48 PM Changeset in webkit [8069] by rjw

• 2 edits in trunk/WebKit

Fixed <rdar://problem/3891737> WebPreferences do not work if they are set before set on the WebView

John found this problem and suggested the fix.

Reviewed by John Louch.

• WebView.subproj/WebView.m: (-[WebView setPreferences:]):

7:02 PM Changeset in webkit [8068] by hyatt

• 1 edit in trunk/WebCore/khtml/html/html_formimpl.cpp

Remove bogus printf.

6:06 PM Changeset in webkit [8067] by mjs

• 5 edits in trunk/JavaScriptCore

Reviewed by Ken.

<rdar://problem/3889696> Enable conservative garbage collection for JavaScript

• kjs/collector.cpp: (KJS::Collector::Thread::Thread): (KJS::destroyRegisteredThread): (KJS::initializeRegisteredThreadKey): (KJS::Collector::registerThread): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively):
• kjs/collector.h:
• kjs/internal.cpp: (lockInterpreter):
• kjs/value.h:

5:44 PM Changeset in webkit [8066] by mjs

• 7 edits in trunk/WebCore

Reviewed by Dave.

<rdar://problem/3890961> selecting an item on the Apache bugzilla query page can be sped up 10% (HTMLFormCollection)
<rdar://problem/3890958> JavaScript that toggles checkboxes can be improved 73% (HTMLCollection,HTMLFormCollection)

This avoids the O(N^{2) penalty for named item traversal for form collections.}

It also combines the item traversal logic for all non-form
collection operations into a single traverseNextItem
function. This avoids having 5 copies of the big switch statement
for this.

Also fixed a bug that prevented the last form element from being removed properly.

• khtml/html/html_formimpl.cpp: (DOM::removeFromVector):
• khtml/dom/html_misc.cpp: (HTMLCollection::namedItems):
• khtml/dom/html_misc.h:
• khtml/ecma/kjs_html.cpp: (KJS::HTMLCollection::getNamedItems):
• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::length): (HTMLCollectionImpl::item): (HTMLCollectionImpl::nextItem): (HTMLCollectionImpl::checkForNameMatch): (HTMLCollectionImpl::namedItem): (HTMLCollectionImpl::namedItems): (HTMLCollectionImpl::nextNamedItem): (HTMLFormCollectionImpl::calcLength): (HTMLFormCollectionImpl::namedItem): (HTMLFormCollectionImpl::nextNamedItem): (HTMLFormCollectionImpl::namedItems):
• khtml/html/html_miscimpl.h:

3:07 PM Changeset in webkit [8065]

• 71 copies
  2 deletes in tags/WebCore-125~8~12

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~12'.

3:07 PM Changeset in webkit [8064] by adele

• 1 edit in branches/Safari-1-2-branch/WebCore/WebCore.pbproj/project.pbxproj

* empty log message *

3:07 PM Changeset in webkit [8063] by adele

• 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

Fixed by Maciej, merged by Darin for SUPanPlum <rdar://problem/3872586>.

2004-11-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3864151> REGRESSION (125-167): Chrysler.com never stops loading

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Don't fire the onload handler if there is a redirect pending. This is a very long-standing bug that was masked by our previously incorrect redirect logic. It used to be that an older redirect would always win. Recently we changed things so that a newer redirect would win, but a script that causes a redirect would stop parsing once complete (so if there are two redirects in the same script, the latter wins). However, we should have also prevented onload in this case. Testing with other browsers shows that onload handlers do not run at all when there is a pending redirect.

9:16 AM Changeset in webkit [8062] by kocienda

• 11 edits in trunk

WebCore:

Reviewed by Harrison

Change around the way we block the Javascript "Paste" command identifier from
being available. Formerly, this was done with an ifdef we never compiled in.
Now, this is done with a couple of cheap runtime checks. The advantage is that
we can now compile this command into development builds, and still yet switch
on the command in deployment builds through the use of WebCore SPI so we can
write and run layout tests with all of our builds.

• khtml/editing/jsediting.cpp: (DOM::JSEditor::queryCommandSupported): Checks state of paste command in case command being queried is the paste command. (DOM::JSEditor::setSupportsPasteCommand): New SPI to turn on paste command.
• khtml/editing/jsediting.h: Ditto.
• khtml/khtml_part.cpp: (KHTMLPart::pasteFromPasteboard): Added. (KHTMLPart::canPaste): Added.
• kwq/KWQKHTMLPart.mm: (KHTMLPart::canPaste): Added.
• kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Turn on paste command.
• kwq/WebCoreBridge.h: Add canPaste call so WebKit can fill in the answer.

WebKit:

Reviewed by Harrison

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canPaste]): Call WebView _canPaste.
• WebView.subproj/WebView.m: (-[WebView _canPaste]): Try to forward to document view's implementation. Only WebHTMLView answers right now. Returns NO otherwise.
• WebView.subproj/WebViewInternal.h: Add _canPaste method to WebView.

2:24 AM Changeset in webkit [8061] by mjs

• 2 edits in trunk/WebKit

Back out the window closing fix, it seems to be causing crashes.

• WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]):

Nov 21, 2004:

8:31 PM Changeset in webkit [8060] by mjs

• 2 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/3889655> HTMLCollectionImpl should use traverseNextNode to improve speed and save recursion

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): (HTMLCollectionImpl::getItem): (HTMLCollectionImpl::item): (HTMLCollectionImpl::nextItem): (HTMLCollectionImpl::getNamedItem): (HTMLCollectionImpl::namedItem): (HTMLCollectionImpl::nextNamedItemInternal): (HTMLFormCollectionImpl::nextNamedItemInternal):

Nov 20, 2004:

2:10 PM Changeset in webkit [8059] by mjs

• 3 edits in trunk/WebKit

WebKit:

Reviewed by John.

<rdar://problem/3710101> _web_userVisibleString makes URL autocomplete roughly 2x slower

• Misc.subproj/WebNSURLExtras.h:

• Misc.subproj/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): New SPI to check if a URL string is already in user-visible form (i.e. converting it to an NSURL and then back via _web_userVisibleString would not change anything).

WebBrowser:

Reviewed by John,

<rdar://problem/3710101> _web_userVisibleString makes URL autocomplete roughly 2x slower

• URLCompletionController.m: (_rawStringFromItem): use URLString from history item when possible, only convert to user visible string when we really have to.

1:44 PM Changeset in webkit [8058] by mjs

• 2 edits in trunk/WebKit

WebKit:

Reviewed by NOBODY (OOPS!).

<rdar://problem/3190977> closing window with many tabs in it can be quite slow

• WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]): autorelease bridge instead of releasing it, to make window and tab closing more responsive - this way the deallocation happens after the windoow or tab appears to close.

WebBrowser:

Reviewed by NOBODY (OOPS!).

<rdar://problem/3190977> closing window with many tabs in it can be quite slow

• BrowserDocument.m: (-[BrowserDocument close]): Don't make an autorelease pool here. This should not be needed for PLT world leak detection any more, and it is necessary to make window closing responsive.

Nov 19, 2004:

6:24 PM Changeset in webkit [8057] by mjs

• 10 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3482935> JavaScript so slow it seems like a hang (hrweb.apple.com) (HTMLCollection?)
<rdar://problem/3759149> PeopleSoft page in Safari twice as slow as Mozilla engine (HTMLFormCollection)
<rdar://problem/3888368> selecting an item on the Apache bugzilla query page can be improved 95% (HTMLFormCollection)

Many optimizations to HTMLFormCollection. Iterating it should not
be N^{2 any more, though finding items by name could still be.}

• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): (DOM::HTMLFormElementImpl::length): (DOM::HTMLFormElementImpl::submitClick): (DOM::HTMLFormElementImpl::formData): (DOM::HTMLFormElementImpl::submit): (DOM::HTMLFormElementImpl::reset): (DOM::HTMLFormElementImpl::radioClicked): (DOM::appendToVector): (DOM::removeFromVector): (DOM::HTMLFormElementImpl::registerFormElement): (DOM::HTMLFormElementImpl::removeFormElement): (DOM::HTMLFormElementImpl::makeFormElementDormant): (DOM::HTMLFormElementImpl::registerImgElement): (DOM::HTMLFormElementImpl::removeImgElement):
• khtml/html/html_formimpl.h:
• khtml/html/html_miscimpl.cpp: (HTMLFormCollectionImpl::FormCollectionInfo::FormCollectionInfo): (void::HTMLFormCollectionImpl::FormCollectionInfo::reset): (HTMLFormCollectionImpl::resetCollectionInfo): (HTMLFormCollectionImpl::calcLength): (HTMLFormCollectionImpl::item): (HTMLFormCollectionImpl::getNamedItem): (HTMLFormCollectionImpl::getNamedFormItem): (HTMLFormCollectionImpl::firstItem): (HTMLFormCollectionImpl::nextItem):
• khtml/html/html_miscimpl.h: (DOM::HTMLFormCollectionImpl::~HTMLFormCollectionImpl):
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute): (ElementImpl::setAttributeMap):
• kwq/KWQPtrVector.h: (QPtrVector::findRef):
• kwq/KWQVectorImpl.h:
• kwq/KWQVectorImpl.mm: (KWQVectorImpl::findRef):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementWithName:inForm:]): (-[WebCoreBridge controlsInForm:]):

5:36 PM Changeset in webkit [8056] by harrison

• 2 edits in trunk/WebCore

Reviewed by Ken and Darin.

<rdar://problem/3856215> Cannot remove bold from the beginning of a message

Problem is that KHTMLPart::computeAndSetTypingStyle always looked upstream
for the existing style, but in this case (hitting cmd-B with caret at top of
file) there is nothing upstream. Changed this to use the VisiblePosition
deepEquivalent instead.

• khtml/khtml_part.cpp: (KHTMLPart::computeAndSetTypingStyle):

5:13 PM Changeset in webkit [8055] by adele

• 1 edit in branches/Safari-1-2-branch/WebCore/ChangeLog-2005-08-23

* empty log message *

5:09 PM Changeset in webkit [8054] by adele

• 1 edit in branches/Safari-1-2-branch/WebCore/khtml/xml/dom_docimpl.cpp

Fixed by Maciej, merged by Darin for SUPanPlum <rdar://problem/3872586>.

2004-11-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3864151> REGRESSION (125-167): Chrysler.com never stops loading

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Don't fire the onload handler if there is a redirect pending. This is a very long-standing bug that was masked by our previously incorrect redirect logic. It used to be that an older redirect would always win. Recently we changed things so that a newer redirect would win, but a script that causes a redirect would stop parsing once complete (so if there are two redirects in the same script, the latter wins). However, we should have also prevented onload in this case. Testing with other browsers shows that onload handlers do not run at all when there is a pending redirect.

4:57 PM Changeset in webkit [8053] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (v172+)

The tree is OPEN!

4:48 PM Changeset in webkit [8052]

• 2 copies in tags/Safari-172

This commit was manufactured by cvs2svn to create tag 'Safari-172'.

4:48 PM Changeset in webkit [8051] by vicki

• 6 edits in trunk

Safari-172 stamp

3:21 PM Changeset in webkit [8050] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3880387> REGRESSION: www.shockplay.com site gives "Unexpected server response"

Reviewed by mjs.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[NSData _web_locationAfterFirstBlankLine]): support both formats ("\r\n\n" and "\r\n\r\n") for separating header data from body data because Shockwave still sends the prior format

1:25 PM Changeset in webkit [8049] by mjs

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3864151> REGRESSION (125-167): Chrysler.com never stops loading

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::close): Don't fire the onload handler if there is a redirect pending. This is a very long-standing bug that was masked by our previously incorrect redirect logic. It used to be that an older redirect would always win. Recently we changed things so that a newer redirect would win, but a script that causes a redirect would stop parsing once complete (so if there are two redirects in the same script, the latter wins). However, we should have also prevented onload in this case. Testing with other browsers shows that onload handlers do not run at all when there is a pending redirect.

11:58 AM Changeset in webkit [8048] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Harrison

Fix some object lifetime issues in these two commands. This fixes some crashes
I am seeing in some new code I am working on, but have not yet reproduced otherwise.

• khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): No longer deref nodes in the ancestor list. They are not ref'ed when put on list. D'uh. (khtml::InsertParagraphSeparatorCommand::doApply): Ref all cloned nodes that are created by the command before putting them on the cloned nodes list. This are still deref'ed in the destructor. (khtml::InsertParagraphSeparatorInQuotedContentCommand::~InsertParagraphSeparatorInQuotedContentCommand): Ditto destructor comment. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto doApply comment.

10:43 AM Changeset in webkit [8047] by kocienda

• 9 edits in trunk

WebCore:

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3655241> setTypingStyle: does not set the real typing style, and typingStyle does not return it

• khtml/khtml_part.cpp: (KHTMLPart::computeAndSetTypingStyle): New helper that does the work of reducing a passed-in style declaration given the current selection, and then sets the minimum necessary style as the typing style on the part. (KHTMLPart::applyStyle): Call new computeAndSetTypingStyle. The guts of computeAndSetTypingStyle used to be here in the selection-as-caret case. But now [WebCoreBridge setTypingStyle:] needs this code as well.
• khtml/khtml_part.h: Declare new computeAndSetTypingStyle() function.
• kwq/WebCoreBridge.h: Declare new typingStyle and setTypingStyle: methods.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge typingStyle]): Calls through to the part to retrieve the typing style. (-[WebCoreBridge setTypingStyle:]): Calls through to the part to set the typing style.

WebKit:

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3655241> setTypingStyle: does not set the real typing style, and typingStyle does not return it

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge respondToChangedContents]): No longer call through to WebKit to set the typing style. The call was part of the misguided use of the setTypingStyle: and typingStyle as a cache of what was stored on the WebCore side. (-[WebBridge respondToChangedSelection]): Ditto.
• WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): Object no longer has typingStyle ivar. (-[WebView setTypingStyle:]): Call over the bridge to set typing style. (-[WebView typingStyle]): Call over the bridge to retrieve typing style.
• WebView.subproj/WebViewInternal.h: Object no longer has typingStyle ivar.

Nov 18, 2004:

10:08 PM Changeset in webkit [8046] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fixed <rdar://problem/3886042> should save history file as binary XML so serialization, parsing, reading and writing is faster

• History.subproj/WebHistory.m: (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]): convert dictionary to binary data before saving

6:03 PM Changeset in webkit [8045] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

Back out Darin's fix for <rdar://problem/3885729>, because the new exception gets triggered by Mail.app.
Filed <rdar://problem/3886832> against Mail.app.

• kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration setProperty:::]):

5:40 PM Changeset in webkit [8044] by cblu

• 2 edits in trunk/WebCore

WebCore:

Fixed: <rdar://problem/3587481> Bug Reporter Login Page: Password AutoFill does not work reliably

Reviewed by john.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::currentForm): just return the current form, don't scan the entire document looking for a form if there is no current form

WebBrowser:

Fixed: <rdar://problem/3587481> Bug Reporter Login Page: Password AutoFill does not work reliably

Reviewed by john.

• FormCompletionController.m: (+[FormCompletionController firstFormInFrame:]): new, currentForm in WebCore used to do this work, but now currentForm just returns the current form (+[FormCompletionController currentOrFirstFrameAndForm:inWebView:]): renamed, if there is no current form, call firstFormInFrame (+[FormCompletionController autoFillInWebView:]): call renamed method (+[FormCompletionController autoFillPasswordInFrame:]): if there is no current form, find a password form from all the forms in the document rather than giving up when the first form is not a password form

5:10 PM Changeset in webkit [8043] by cblu

• 2 edits in trunk/WebKit

• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation currentForm]): removed stray ";"

4:49 PM Changeset in webkit [8042] by mjs

• 2 edits in trunk/WebCore

Reviewed by Chris.

• fix recursive item traversal, use traverseNextNode() instead of the buggy hand-rolled traversal.

• khtml/xml/dom_nodeimpl.cpp: (NodeListImpl::recursiveItem):

4:12 PM Changeset in webkit [8041] by darin

• 35 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3885744> crash with XMLHttpRequest test page (reported by KDE folks)

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::slotFinished): Rolled in fix from KDE; make sure to set job to 0 before calling changeState.

• fixed <rdar://problem/3885729> attempting to modify a computed style does nothing, but should raise a DOM exception
• fixed <rdar://problem/3885731> style declarations use too many malloc blocks; switch to QValueList
• fixed <rdar://problem/3885739> DOM::NodeImpl accessor in DOM::Node class is hot; should be inlined
• changed NodeImpl calls like replaceChild to always ref/deref the parameter; this is a better way to fix an entire category of leaks we have been fixing one by one recently
• changed computed styles so they hold a reference to the DOM node; the old code could end up with a stale RenderObject pointer, although I never saw it do that in practice
• implemented the length and item methods for computed styles
• implemented querying additional properties in computed styles (29 more)

• khtml/khtml_part.h: Update forward declaration of CSSMutableStyleDeclarationImpl since it's now a separate class rather than a typedef. Changed the parameter type of setTypingStyle to take a mutable style.
• khtml/khtml_part.cpp: (KHTMLPart::setTypingStyle): Change parameter to take a mutable style. (KHTMLPart::applyStyle): Add code to make a mutable style in case we are passed a computed style; also change some types to mutable style. (updateState): Update iteration of CSSProperty objects in a style declaration to use the new valuesIterator interface. (KHTMLPart::selectionHasStyle): Add a call to makeMutable. (KHTMLPart::selectionStartHasStyle): Add call to makeMutable and update iteration. (editingStyle): Change type to mutable style, and simplify the style-creation calls, including accomodating the exception code that setCssText has now. (KHTMLPart::applyEditingStyleToElement): Change types to mutable style. (KHTMLPart::removeEditingStyleFromElement): Change code to call setChanged only if removing the style attributes really was a change, although it's not an important optimization it's good to do it right.

• khtml/css/css_base.h: Remove unneeded setParsedValue method.
• khtml/css/css_base.cpp: Remove unneeded setParsedValue method. All the places that were calling it were already removing the old property explicitly, so the code in here to remove the property again was redundant.

• khtml/css/css_computedstyle.h: Updated virtual functions for changes to parameters in base class. Moved all the "set"-type functions so they are private. Store a node pointer instead of a renderer.
• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::CSSComputedStyleDeclarationImpl): Hold a reference to the node we compute style for, so we don't end up with a pointer to a deallocated RenderObject. Before we had no guarantee the object would outlast us. (DOM::CSSComputedStyleDeclarationImpl::setCssText): Add exception parameter, and set the exception to NO_MODIFICATION_ALLOWED_ERR. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Update to use node pointer rather than renderer pointer. Added implementation for box-align, box-direction, box-flex, box-flex-group, box-lines, box-ordinal-group, box-orient, box-pack, caption-side, clear, cursor, direction, list-style-image, list-style-position, list-style-type, marquee-direction, marquee-repetition, marquee-style, user-modify, opacity, orphans, outline-style, page-break-after, page-break-before, page-break-inside, position, unicode-bidi, widows, z-index. (DOM::CSSComputedStyleDeclarationImpl::removeProperty): Add exception parameter, and set the exception to NO_MODIFICATION_ALLOWED_ERR. (DOM::CSSComputedStyleDeclarationImpl::setProperty): Ditto. (DOM::CSSComputedStyleDeclarationImpl::length): Implemented. (DOM::CSSComputedStyleDeclarationImpl::item): Implemented, calls getPropertyValue. (DOM::CSSComputedStyleDeclarationImpl::copyInheritableProperties): Changed return type to CSSMutableStyleDeclarationImpl. (DOM::CSSComputedStyleDeclarationImpl::copy): Added. (DOM::CSSComputedStyleDeclarationImpl::makeMutable): Added.

• khtml/css/css_ruleimpl.h: Update forward declaration of CSSMutableStyleDeclarationImpl since it's now a separate class rather than a typedef.
• khtml/css/cssparser.h: Ditto.

• khtml/css/css_valueimpl.h: Refactor CSSStyleDeclarationImpl into two classes. New derived class CSSMutableStyleDeclarationImpl has the guts, and the base class has only some virtual functions. Removed a bunch of redundant stuff from other classes in this file too. (DOM::DashboardRegionImpl::setNext): Ref new before deref'ing old to handle the set-to-same case. (DOM::CSSProperty::CSSProperty): Added new overload so you can create a CSSProperty with initial values. (DOM::CSSProperty::operator=): Added. (DOM::CSSProperty::setValue): Use ref-before-deref pattern to simplify slightly.

• khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::CSSStyleDeclarationImpl): Remove uneeded things. (DOM::CSSStyleDeclarationImpl::isStyleDeclaration): Put here now that it's no longer inline. (DOM::CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl): Added. (DOM::CSSMutableStyleDeclarationImpl::operator=): Added. (DOM::CSSMutableStyleDeclarationImpl::~CSSMutableStyleDeclarationImpl): Updated. (DOM::CSSMutableStyleDeclarationImpl::getPropertyValue): Removed now-uneeded check. (DOM::CSSMutableStyleDeclarationImpl::get4Values): Moved here from base class. (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue): Ditto. (DOM::CSSMutableStyleDeclarationImpl::getPropertyCSSValue): Update to use QValueList instead of QPtrList. (DOM::CSSMutableStyleDeclarationImpl::removeProperty): Added exception parameter, updated for QValueList. (DOM::CSSMutableStyleDeclarationImpl::setChanged): Moved here from base class. (DOM::CSSMutableStyleDeclarationImpl::getPropertyPriority): Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::setProperty): Added more overloads to match new parameters. (DOM::CSSMutableStyleDeclarationImpl::setStringProperty): Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::setImageProperty): Ditto. (DOM::CSSMutableStyleDeclarationImpl::parseProperty): Remove unneeded initialization code due to QValueList. (DOM::CSSMutableStyleDeclarationImpl::addParsedProperties): Added. (DOM::CSSMutableStyleDeclarationImpl::setLengthProperty): Moved here from base class. (DOM::CSSMutableStyleDeclarationImpl::length): Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::item): Moved here from base class. (DOM::CSSMutableStyleDeclarationImpl::cssText): Return empty string rather than null string when there are no styles in the list. Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::setCssText): Update to use QValueList and to take an exceptionCode parameter and set it. (DOM::CSSMutableStyleDeclarationImpl::merge): Update to use QValueList. (DOM::CSSStyleDeclarationImpl::diff): Update to use QValueList. (DOM::CSSMutableStyleDeclarationImpl::copyBlockProperties): Moved here from base class. Change return type. (DOM::CSSStyleDeclarationImpl::copyPropertiesInSet): Update to use QValueList and use stack, not new/delete. (DOM::CSSMutableStyleDeclarationImpl::makeMutable): Added. (DOM::CSSMutableStyleDeclarationImpl::copy): Added.

• khtml/css/cssparser.cpp: (CSSParser::parseValue): Changed to use addParsedProperties. (CSSParser::parseDeclaration): Ditto. (CSSParser::createStyleDeclaration): Use new constructor to create declaration in a more efficient manner.

• khtml/css/cssproperties.in: Removed unused font-size-adjust and -khtml-flow-mode.
• khtml/css/cssproperties.c: Regenerated.
• khtml/css/cssproperties.h: Regenerated.

• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyDeclarations): Updated to use QValueList interface to CSSMutableStyleDeclarationImpl.

• khtml/dom/css_value.cpp: (DOM::CSSStyleDeclaration::cssText): Removed unneeded cast. (DOM::CSSStyleDeclaration::setCssText): Added exception code handling. (DOM::CSSStyleDeclaration::getPropertyValue): Changed to call getPropertyValue directly instead of first doing getPropertyCSSValue and then doing cssText. (DOM::CSSStyleDeclaration::getPropertyCSSValue): Removed unneeded cast. (DOM::CSSStyleDeclaration::removeProperty): Added exception code handling. (DOM::CSSStyleDeclaration::setProperty): Added exception code handling. (DOM::CSSStyleDeclaration::length): Removed unneeded cast. (DOM::CSSStyleDeclaration::item): Removed unneeded cast. (DOM::CSSStyleDeclaration::parentRule): Removed unneeded cast. (DOM::CSSValue::setCssText): Removed strange non-implementation (still not implemented).

• khtml/dom/dom_node.h: Made isNull and handle functions inline.
• khtml/dom/dom_node.cpp: Ditto.

• khtml/editing/htmlediting.h: Change some types to mutable style.
• khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::typingStyle): Change return type to mutable style. (khtml::EditCommandPtr::setTypingStyle): Change parameter to mutable style. (khtml::StyleChange::init): Convert parameter to mutable style. Update to use QValueList. (khtml::EditCommand::assignTypingStyle): Change parameter to mutable type. (khtml::EditCommand::setTypingStyle): Ditto. (khtml::ApplyStyleCommand::ApplyStyleCommand): Convert parameter to mutable style. (khtml::ApplyStyleCommand::doApply): Change local variables to mutable style. (khtml::ApplyStyleCommand::applyBlockStyle): Change parameter to mutable style. (khtml::ApplyStyleCommand::applyInlineStyle): Ditto. (khtml::ApplyStyleCommand::isHTMLStyleNode): Ditto. (khtml::ApplyStyleCommand::removeCSSStyle): Ditto. Also update to use QValueList. (khtml::ApplyStyleCommand::removeBlockStyle): Change parameter to mutable style. (khtml::ApplyStyleCommand::removeInlineStyle): Ditto. (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Ditto. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto. (khtml::InsertLineBreakCommand::doApply): Convert locals to mutable style. (khtml::InsertTextCommand::prepareForTextInsertion): Ditto. (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Convert parameter to mutable style.

• khtml/editing/jsediting.cpp: Convert types to mutable styles where we create styles.
• khtml/html/html_baseimpl.h: Change type to mutable style.
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::createLinkDecl): Ditto.

• khtml/html/html_elementimpl.h: Make CSSMappedAttributeDeclarationImpl use the mutable style class as a base class, and change types to mutable style as needed.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createInlineStyleDecl): Change type to mutable style. (HTMLElementImpl::parseHTMLAttribute): Call parseProperty method. (HTMLElementImpl::getInlineStyleDecl): Change type to mutable style. (HTMLElementImpl::additionalAttributeStyleDecl): Ditto. (HTMLElementImpl::createContextualFragment): Add ref/deref to fix potential node leak. (HTMLElementImpl::setInnerHTML): Remove ref/deref pair because this leak is now fixed by changes to appendChild. (HTMLElementImpl::setOuterHTML): Remove ref/deref pair because this leak is now fixed by changes to replaceChild.

• khtml/html/html_tableimpl.h: Change types to mutable style.
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::additionalAttributeStyleDecl): Change type to mutable style. (HTMLTableElementImpl::getSharedCellDecl): Change type to mutable style. (HTMLTableCellElementImpl::additionalAttributeStyleDecl): Change type to mutable style.

• khtml/html/htmlparser.cpp: (KHTMLParser::parseToken): Use a local variable to protect the node by ref'ing it. This is better than using an explicit delete to make the node go away, and is required for compatibility with the changes to the NodeImpl functions. (KHTMLParser::insertNode): Ditto. (KHTMLParser::createHead): Get rid of explicit delete, no longer needed because of changes to the NodeImpl functions.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createCSSStyleDeclaration): Call simpler constructor now that there's no need to make the property list explictly.

• kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration setCssText:]): Raise exception when appropriate. (-[DOMCSSStyleDeclaration removeProperty:]): Ditto. (-[DOMCSSStyleDeclaration setProperty:::]): Dito.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::insertBefore): Always do a ref/deref, so callers don't have to worry about whether the function succeeded or not for ownership purposes. (NodeImpl::replaceChild): Ditto. (NodeImpl::appendChild): Ditto. (NodeBaseImpl::insertBefore): Ditto. (NodeBaseImpl::replaceChild): Ditto. (NodeBaseImpl::appendChild): Ditto. (NodeBaseImpl::addChild): Ditto.

• WebCore-tests.exp: Removed CSSStyleDeclaration::length; not sure why it was in here.
• WebCore-combined.exp: Regenerated.

4:08 PM Changeset in webkit [8040] by mjs

• 2 edits in trunk/WebCore

still even more build fixing

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::resetCollectionInfo):

3:09 PM Changeset in webkit [8039] by mjs

• 2 edits in trunk/WebCore

more build fixing

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::resetCollectionInfo):

2:38 PM Changeset in webkit [8038] by mjs

• 2 edits in trunk/WebCore

Fixed build problem.

• khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo): it's haslength, not hasLenght.

1:42 PM Changeset in webkit [8037] by mjs

• 12 edits in trunk/WebCore

Reviewed by Ken.

• merged and cleaned up HTMLCollection and HTMLFormCollection speedups from konqueror

<rdar://problem/3822992> VIP: Program listings pages at directv.com take a really long time to load [HTMLCollection]
<rdar://problem/3701991> Safari unresponsive loading (www.maxim-ic.com) (HTMLCollection)

This is also a start on fixing 5 other bugs, but those need additional work to make
HTMLFormCollection fast.

• khtml/html/html_documentimpl.h: (DOM::HTMLDocumentImpl::collectionInfo):
• khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): (DOM::HTMLFormElementImpl::isURLAttribute): (DOM::HTMLFormElementImpl::registerImgElement): (DOM::HTMLFormElementImpl::removeImgElement):
• khtml/html/html_formimpl.h:
• khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::HTMLImageElementImpl): (HTMLImageElementImpl::~HTMLImageElementImpl):
• khtml/html/html_imageimpl.h:
• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::HTMLCollectionImpl): (HTMLCollectionImpl::~HTMLCollectionImpl): (HTMLCollectionImpl::updateCollectionInfo): (HTMLCollectionImpl::length): (HTMLCollectionImpl::item): (HTMLCollectionImpl::firstItem): (HTMLCollectionImpl::nextItem): (HTMLCollectionImpl::namedItem): (HTMLCollectionImpl::nextNamedItemInternal): (HTMLFormCollectionImpl::getNamedFormItem):
• khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::): (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo):
• khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::incDOMTreeVersion): (DOM::DocumentImpl::domTreeVersion):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::attach): (NodeImpl::detach):

12:50 PM Changeset in webkit [8036] by cblu

• 2 edits in trunk/WebKit

Fixed development build failure.

• Misc.subproj/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): call LOG not Log

11:29 AM Changeset in webkit [8035] by kdecker

• 2 edits in trunk/WebCore

Reviewed by Chris.

fixed: <rdar://problem/3841842> getPropertyID expensive

• kwq/DOM-CSS.mm: (getPropertyID): avoid unnecessary memory allocations by using a fixed-sized stack based buffer.

10:20 AM Changeset in webkit [8034] by cblu

• 2 edits in trunk/WebKit

<rdar://problem/3885708> save memory in icon DB by not using NSSets when holding 1 object

Reviewed by sullivan.

• Misc.subproj/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): added timing code (-[WebIconDatabase _clearDictionaries]): new (-[WebIconDatabase _loadIconDictionaries]): call _clearDictionaries in 2 places before we bail, use _web_setObjectUsingSetIfNecessary:forKey: when adding site URLs to the iconURLToURLs dictionary (-[WebIconDatabase _updateFileDatabase]): fixed comment (-[WebIconDatabase _setIconURL:forURL:]): use _web_setObjectUsingSetIfNecessary:forKey: when adding site URLs to the iconURLToURLs dictionary (-[WebIconDatabase _releaseIconForIconURLString:]): handle NSString objects retured from iconURLToURLs (-[NSMutableDictionary _web_setObjectUsingSetIfNecessary:forKey:]): new, puts a set on the dictionary when there are 2 or more object for s key