Timeline



Dec 6, 2004:

8:11 PM Changeset in webkit [8144] by rjw
  • 2 edits in trunk/WebKit

Use the AppKit's font rendering mode. This fixes 3905347, but we still need to track down
and resolve why metrics have changed for Courier. This may be caused by changes in
AppKit for 3902394.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (_AppkitGetCGRenderingMode): (getUncachedWidth): (_drawGlyphs):
6:26 PM Changeset in webkit [8143] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • fixed <rdar://problem/3906974> assertion failure in QWidget::beforeMouseDown clicking on <select multiple>
  • kwq/KWQListBox.mm: (QListBox::QListBox): Initialize KWQListBoxScrollView with this. (-[KWQListBoxScrollView initWithListBox:]): Make this class a KWQWidgetHolder. (-[KWQListBoxScrollView widget]): See above. (-[KWQTableView mouseDown:]): Pass outerView rather than self to beforeMouseDown and afterMouseDown, to avoid triggering an assertion failure.
6:09 PM Changeset in webkit [8142] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

Add table test to cover the document.write line layout bug.

6:09 PM Changeset in webkit [8141] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3615411, the linesAppended optimization was old and broken, and it's easier with the new code fixes
made by me, kocienda and harrison to just remove it.

Reviewed by mjs

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_block.cpp: (khtml:::RenderFlow):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::dirtyLinesFromChangedChild):
5:36 PM Changeset in webkit [8140] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3787133, some web pages print with many blank pages. Make sure to use the real page print rect and
not a damage rect that can be changed when intersected with the clip regions of the web page.

Reviewed by john

  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::printRect): (khtml::RenderCanvas::setPrintRect):
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::adjustPageHeight):
4:47 PM Changeset in webkit [8139] by cblu
  • 2 edits in trunk/WebKit

Forgot to commit copied header.

  • DOM.subproj/DOMPrivate.h:
4:45 PM Changeset in webkit [8138] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken Kocienda and Dave Hyatt (OOPS!).

<rdar://problem/3849947> Typing after pasting line does not appear until after window resize.

  • khtml/rendering/render_flow.cpp: (RenderFlow::dirtyLinesFromChangedChild):

Dirty the line above because new child can inval the cached line break position of previous line.

4:34 PM Changeset in webkit [8137] by hyatt
  • 15 edits in trunk/WebCore

Fix for 3254464, radio buttons do not work for quiz on netscape.com. Left/top overflow needed to be implemented.
This also fixes 3106907, link hover color only partially set on rollover and the more general architecture bug
3126929, handle top/left overflow.

This patch also fixes 3902891, scroll bar of position:fixed content moves when a page is scrolled.

Finally, the Emerson regression 3869718 (error involving computing the rightmost/lowest position of overflow:auto
regions and web pages) has been fixed.

Reviewed by mjs

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::checkLinesForOverflow):
  • khtml/rendering/render_block.cpp: (khtml:::RenderFlow): (khtml::RenderBlock::overflowHeight): (khtml::RenderBlock::overflowWidth): (khtml::RenderBlock::overflowLeft): (khtml::RenderBlock::overflowTop): (khtml::RenderBlock::overflowRect): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::paint): (khtml::RenderBlock::floatRect): (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition): (khtml::RenderBlock::nodeAtPoint):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.h: (khtml::RenderBox::borderBox): (khtml::RenderBox::borderTopExtra): (khtml::RenderBox::borderBottomExtra):
  • khtml/rendering/render_layer.cpp: (RenderLayer::paintScrollbars): (mustExamineRenderer): (RenderLayer::intersectsDamageRect): (RenderLayer::containsPoint):
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::placeBoxesHorizontally): (khtml::InlineFlowBox::verticallyAlignBoxes):
  • khtml/rendering/render_line.h: (khtml::InlineBox::leftOverflow): (khtml::InlineBox::rightOverflow): (khtml::InlineFlowBox::setVerticalOverflowPositions): (khtml::RootInlineBox::RootInlineBox): (khtml::RootInlineBox::leftOverflow): (khtml::RootInlineBox::rightOverflow): (khtml::RootInlineBox::setVerticalOverflowPositions): (khtml::RootInlineBox::setHorizontalOverflowPositions):
  • khtml/rendering/render_object.h: (khtml::RenderObject::borderBox): (khtml::RenderObject::overflowLeft): (khtml::RenderObject::overflowTop): (khtml::RenderObject::overflowRect): (khtml::RenderObject::floatRect):
  • khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTable::paint): (RenderTable::paintBoxDecorations): (RenderTable::calcMinMaxWidth):
  • khtml/rendering/render_table.h: (khtml::RenderTableCell::borderTopExtra): (khtml::RenderTableCell::borderBottomExtra):
  • kwq/KWQRect.h:
  • kwq/KWQRect.mm: (QRect::inflate):
4:24 PM Changeset in webkit [8136] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3903797> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs

I changed all unprotected places that can navigate a different
window or frame from script to check for a javascript: URL, and if
found, to check for safety using cross-site-script rules.

I considered a few other possible exploits and made no change:

  • document.location is already protected because the document object itself is protected
  • frame.src, frame.location, iframe.src and targetted links are all safe because setting the URL of a frame to a javascript: URL executes the script in the context of the parent
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):
3:57 PM Changeset in webkit [8135] by kocienda
  • 4 edits in trunk

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3890955> 8A314: Forward delete sometimes fails to delete the selected quoted text

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleSpecialCaseBRDelete): Fixed bonehead coding mistake in the check for one of the special cases being checked for in this function. The specific case intends to check for a selection that is only a <br> after a block ends (as in </div><br>). If it sees such markup, it deletes only the <br> and bails. However, this code would run in *any* case where a selection ended in a <br> after a block and would not delete any part of the selection preceding the <br>. Bad. I have tightened the check to see that only a <br> is selected.

Fixing the bug above was accomplished with an additional call to DOM::Position::downstream. This
new use of the function exposed this bug:

<rdar://problem/3907666> Incorrectly coded loop in Position::downstream can lead to infinite loop

  • khtml/xml/dom_position.cpp: (DOM::Position::downstream): I am ashamed of my first cut at this. Rewrote the loop so it does not have this fatal flaw. It is a much better design as well.
  • layout-tests/editing/deleting/delete-3800834-fix-expected.txt: Changes made this test have what I consider to be a better result. Going with it.
3:39 PM Changeset in webkit [8134] by cblu
  • 3 edits in trunk/WebCore

Fixed: <rdar://problem/3871718> REGRESSION (125-168): text marked bold with font that does not have bold variant copies as non-bold

Reviewed by hyatt.

  • kwq/DOM.mm: (-[DOMElement _font]): new SPI for AppKit
  • kwq/DOMPrivate.h:
2:59 PM Changeset in webkit [8133]
  • 3 copies
    3 deletes in tags/WebKit-173~1

This commit was manufactured by cvs2svn to create tag 'WebKit-173~1'.

2:59 PM Changeset in webkit [8132] by vicki
  • 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Bump version number to 173.1. We're doing a dot submission today for <rdar://problem/3903749>.

2:20 PM Changeset in webkit [8131] by cblu
  • 11 edits in trunk/WebKit

Fixed: <rdar://problem/3907381> NSURLConnection and WebKit buffer 2 copies of incoming data

Reviewed by darin.

  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (+[WebBaseResourceHandleDelegate initialize]): cache check to see if Foundation supports access to its buffered data (-[WebBaseResourceHandleDelegate addData:]): don't buffer data if Foundation is buffering it for us (-[WebBaseResourceHandleDelegate saveResource]): when creating a WebResource, pass NO for copyData since we know it won't be mutated (-[WebBaseResourceHandleDelegate resourceData]): return the buffered data from the connection if it supports it (-[WebBaseResourceHandleDelegate willStopBufferingData:]): make a mutable copy of the data from NSURLConnection so we can continue buffering (-[WebBaseResourceHandleDelegate willCacheResponse:]): removed optimization that used the cached response data to save the resource since that is obsolete by this change (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): new callback from NSURLConnection, informs us that NSURLConnection has given up buffering
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedData:]): removed buffering code since that's done by NSURLConnection and the main client (-[WebDataSource _setData:]): removed unnecessary cast since the resourceData ivar is now an NSData instead of NSMutableData (-[WebDataSource data]): return resourceData ivar, else return the resourceData from the main client
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient releaseResources]): store resourceData on the data source so it can continue to have data after the main client has gone away (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):don't call [dataSource data] just to get the length of data received since [dataSource data] can now cause data to be copied (-[WebMainResourceClient connectionDidFinishLoading:]): ditto
  • WebView.subproj/WebResource.m: (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call following method with YES for copyData (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:copyData:]): new initializer, allows caller to choose whether or not the data is copied
  • WebView.subproj/WebResourcePrivate.h:
1:49 PM Changeset in webkit [8130] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3906327> Select All of a large document is slow (>15 secs on my machine for attached specimen)
  • kwq/KWQScrollView.mm: (QScrollView::updateContents): Intersect with visibleRect before calling through to NSView to dirty; NSView could also be more efficient in this case (I filed 3906343).
1:09 PM Changeset in webkit [8129] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3903749> REGRESSION (8A321): WebKit gets incorrect glyph metrics due to change in how AppKit uses CGFont

Use CGFontRef direction when both getting font metrics and drawing
glyphs, instead on depending on [NSFont set].

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (getUncachedWidth): (_drawGlyphs):
11:48 AM Changeset in webkit [8128] by sullivan
  • 2 edits in trunk/WebCore

Darin found what appears to be the real leak that we were falsely blaming
on the 'leaks' tool (3880245). I made the change, and ran layout tests and PLT to make
sure nothing barfed.

  • khtml/css/cssparser.cpp: (CSSParser::parseValue): call clearProperties() instead of just setting numParsedProperties to 0 (CSSParser::parseDeclaration): ditto (CSSParser::createStyleDeclaration): ditto
10:38 AM Changeset in webkit [8127] by kocienda
  • 1 edit
    18 adds in trunk

Reviewed by me

New layout tests.

  • layout-tests/editing/inserting/insert-div-001-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-001.html: Added.
  • layout-tests/editing/inserting/insert-div-002-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-002.html: Added.
  • layout-tests/editing/inserting/insert-div-003-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-003.html: Added.
  • layout-tests/editing/inserting/insert-div-004-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-004.html: Added.
  • layout-tests/editing/inserting/insert-div-005-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-005.html: Added.
  • layout-tests/editing/inserting/insert-div-006-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-006.html: Added.
  • layout-tests/editing/inserting/insert-div-007-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-007.html: Added.
  • layout-tests/editing/inserting/insert-div-008-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-008.html: Added.
  • layout-tests/editing/inserting/insert-div-009-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-009.html: Added.
10:21 AM Changeset in webkit [8126] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3906948> REGRESSION (Mail): Insert paragraph code can make the insertion point "stick" in place.

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Call insertBlockPlaceholderIfNeeded(), passing block being added to this function. This ensures that the added block has a height. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto.
10:21 AM Changeset in webkit [8125] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3906930> Hitting return key in editable content inserts br elements instead of blocks

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView insertNewline:]): One-line change to call insert-block rather than insert-br method on bridge.
9:39 AM Changeset in webkit [8124] by kocienda
  • 6 edits in trunk

Reviewed by John

  • khtml/dom/dom_string.cpp: (DOM::DOMString::substring): Expose method already on DOMStrimgImpl.
  • khtml/dom/dom_string.h: Ditto.
  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::rebalanceWhitespace): New helper to create and execute a RebalanceWhitespaceCommand instance. (khtml::DeleteSelectionCommand::doApply): Call rebalanceWhitespace() after running command. (khtml::InsertLineBreakCommand::doApply): Ditto. (khtml::InsertParagraphSeparatorCommand::doApply): Ditto. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto. (khtml::InsertTextCommand::input): Ditto. (khtml::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): New command. (khtml::RebalanceWhitespaceCommand::~RebalanceWhitespaceCommand): Ditto. (khtml::RebalanceWhitespaceCommand::doApply): Ditto. (khtml::RebalanceWhitespaceCommand::doUnapply): Ditto. (khtml::RebalanceWhitespaceCommand::preservesTypingStyle): Ditto. (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
  • khtml/editing/htmlediting.h: Ditto. (khtml::RebalanceWhitespaceCommand::): Ditto.

Dec 5, 2004:

12:40 PM Changeset in webkit [8123] by darin
  • 2 edits in trunk/WebCore
  • fixed small problem in my check-in from yesterday
  • kwq/KWQEvent.mm: (positionForEvent): Get location from event without raising exception if it's the wrong type. (clickCountForEvent): Same, for clickCount. (QMouseEvent::QMouseEvent): Use the new helper functions so this can be constructed even with the wrong type of NSEvent. Required for cases where a keyboard event causes a "click" and we need to synthesize a QMouseEvent for KHTML internal use, using the key down NSEvent.

Dec 4, 2004:

2:31 PM Changeset in webkit [8122] by darin
  • 15 edits in trunk

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3878329> REGRESSION (169-170): colors are wrong for my.yahoo.com due to CSS background parsing changes
  • khtml/css/cssparser.cpp: (CSSParser::parseBackgroundShorthand): Changed function so it doesn't rely on the position attribute being at the end of the array and then moved position attribute before color attribute so it takes precedence. Since "0" can be both the X coordinate of a position and a legal color (meaning black), we need to do position first.
  • fixed <rdar://problem/3760869> click events for input type=button or type=checkbox don't have flags like shiftKey set
  • khtml/rendering/render_form.h: Remove unused RenderFormElement fields.
  • khtml/rendering/render_form.cpp: (RenderFormElement::RenderFormElement): Take out code to set a bunch of unused fields. (RenderFormElement::slotClicked): Change to create the QMouseEvent from the actual mouse event rather than creating it with all the flags set to 0, using the new QMouseEvent constructor that does so.
  • kwq/KWQEvent.h: Added constructor that takes no parameters which uses the current event from AppKit. Made the click count getter const and added an isDoubleClick that matches the logic used elsewhere. Added a fixState helper method so the constructors can save code.
  • kwq/KWQEvent.mm: (QMouseEvent::QMouseEvent): Factored out the state-fixing code that was in the two existing constructors and added a third constructor that uses the "current event" from AppKit (used above). (QMouseEvent::fixState): Compute state and click count based on event type.
  • fixed first symptom of <rdar://problem/3830936> REGRESSION (125-165): crash due to null font family, hang at changeforamerica.com
  • kwq/KWQFontFamily.mm: (KWQFontFamily::getNSFamily): Handle empty strings specially so we don't run into trouble when the family name is a null string. This prevents the crash, but there are still other problems that may have the same underlying cause in CSS.
  • fixed <rdar://problem/3829808> Safari crashes when adding a DOM node that was removed from an XMLHTTP request result
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): Added nil check before calling scheduleRelayout. This is new code so the nil-dereference is a recent regression.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/3846079> assertion failure in WebHTMLView(WebPrivate) removeTrackingRect at boots.com
  • fixed <rdar://problem/3857737> REGRESSION (165-166): clicking in a text field that's scrolled to the right causes it to scroll all the way left
  • fixed <rdar://problem/3861952> REGRESSION (165-166): selection is cleared when you start to scroll a frame
  • WebView.subproj/WebHTMLViewInternal.h: Added handlingMouseDown flag.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Allow passing in a tracking number of 0, which means no existing tracking number. (-[WebHTMLView _addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): Ditto. (-[WebHTMLView removeTrackingRect:]): Allow removing a tracking number of 0, which is a no-op. (-[WebHTMLView _removeTrackingRects:count:]): Ditto. (-[WebHTMLView acceptsFirstResponder]): Changed check to use handlingMouseDown flag instead of mouseDownEvent field since that field is set up too early in the mouse down event handling process. (-[WebHTMLView mouseDown:]): Added code to set handlingMouseDown flag.
  • fixed part of <rdar://problem/3829808> Safari crashes when adding a DOM node that was removed from an XMLHTTP request result
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Changed code around so that it won't try to create a WebResource when the load fails.
  • moved next/previous links into private structure with the rest of WebFrame fields (We have a rule against putting new fields into obejcts that are part of our public API.)
  • WebView.subproj/WebFrame.h: Remove _nextSibling and _previousSibling.
  • WebView.subproj/WebFramePrivate.h: Added nextSibling and previousSibling fields to private class.
  • WebView.subproj/WebFrame.m: Got rid of some tabs in this file. (-[WebFrame _addChild:]): Changed code to use fields inside _private. (-[WebFrame _removeChild:]): Ditto. (-[WebFrame _nextFrameWithWrap:]): Ditto. (-[WebFrame _previousFrameWithWrap:]): Ditto.
10:37 AM Changeset in webkit [8121] by cblu
  • 22 edits in trunk

WebCore:

New fixes for:
<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)
<rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account
<rdar://problem/3902749> REGRESSION (Tiger): missing image symbol does not appear

Reviewed by darin, rjw, kocienda.

  • khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedCSSStyleSheet::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestScript):
  • khtml/misc/loader.h: (khtml::CachedObject::CachedObject): (khtml::CachedObject::response): (khtml::CachedObject::allData):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): (KIO::TransferJobPrivate::~TransferJobPrivate): (KIO::TransferJob::TransferJob): (KIO::TransferJob::assembleResponseHeaders): (KIO::TransferJob::retrieveCharset): (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQCheckCacheObjectStatus): (KWQIsResponseURLEqualToURL): (KWQResponseURL): (KWQResponseMIMEType): (KWQCacheObjectExpiresTime): (khtml::CachedObject::setResponse): (khtml::CachedObject::setAllData):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap):
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle:]): (-[KWQResourceLoader cancel]): (-[KWQResourceLoader reportError]): (-[KWQResourceLoader finishWithData:]):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreResourceLoader.h:

WebKit:

New fixes for:
<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)
<rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account
<rdar://problem/3902749> REGRESSION (Tiger): missing image symbol does not appear

Reviewed by darin, rjw, kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didFinishLoading]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _internalLoadDelegate]): (-[WebFrame _sendResourceLoadDelegateMessagesForURL:response:length:]):
  • WebView.subproj/WebFrameInternal.h:
10:30 AM Changeset in webkit [8120] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3876093> REGRESSION (166-167): Setting slider control's value from JavaScript has no effect (breaks RSS)
  • khtml/rendering/render_form.cpp: (RenderSlider::updateFromElement): Call setValue to update the value of the DOM element rather than modifying the m_value data member directly. We don't use m_value at all for sliders now, and in fact the code relies on the fact that m_value is null. Setting m_value to a non-null value was causing the bug. (RenderSlider::slotSliderValueChanged): Ditto.
7:31 AM Changeset in webkit [8119] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed remaining bit of <rdar://problem/3814237> REGRESSION (Mail): Copy/paste style does not set color in Mail compose window
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): When translating from an attribute dictionary to a CSS declaration, treat missing values according to the defaults defined in <AppKit/NSAttributedString.h>. Before the code was treating them as "no change", which is incorrect.
  • English.lproj/StringsNotToBeLocalized.txt: Add a string from the above change.

Dec 3, 2004:

5:56 PM Changeset in webkit [8118] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3889411> REGRESSION (125-172): repro crash in khtml::BackgroundLayer::cullEmptyLayers
  • khtml/rendering/render_style.cpp: (BackgroundLayer::cullEmptyLayers): added missing nil check
5:54 PM Changeset in webkit [8117] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (v173+)
The tree is open!

5:42 PM Changeset in webkit [8116]
  • 2 copies in tags/Safari-173

This commit was manufactured by cvs2svn to create tag 'Safari-173'.

5:42 PM Changeset in webkit [8115] by vicki
  • 6 edits in trunk

Safari-173 stamp

2:53 PM Changeset in webkit [8114] by kocienda
  • 26 edits in trunk

WebCore:

Reviewed by me

Roll out some recent changes by Chris that caused a performance regression.
Fix is in hand, but it is a little risky this close to a submission. So,
we have decided to roll back the change with the regression and roll in
the new code after we submit.

  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmltags.c: (hash_tag): (findTag):
  • khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedObject::setResponse): (CachedCSSStyleSheet::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestScript):
  • khtml/misc/loader.h: (khtml::CachedObject::CachedObject): (khtml::CachedObject::response):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): (KIO::TransferJobPrivate::~TransferJobPrivate): (KIO::TransferJob::TransferJob): (KIO::TransferJob::assembleResponseHeaders): (KIO::TransferJob::retrieveCharset): (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse): (KWQIsResponseURLEqualToURL): (KWQResponseURL): (KWQResponseMIMEType): (KWQResponseTextEncodingName): (KWQResponseHeaderString): (KWQCacheObjectExpiresTime): (KWQLoader::KWQLoader):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap):
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle]): (-[KWQResourceLoader cancel]): (-[KWQResourceLoader reportError]): (-[KWQResourceLoader finish]):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreResourceLoader.h:

WebKit:

Reviewed by me

Roll out some recent changes by Chris that caused a performance regression.
Fix is in hand, but it is a little risky this close to a submission. So,
we have decided to roll back the change with the regression and roll in
the new code after we submit.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didFinishLoading]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _internalLoadDelegate]):
  • WebView.subproj/WebFrameInternal.h:
2:01 PM Changeset in webkit [8113] by sullivan
  • 2 edits in trunk/WebCore

Vicki gave me special dispensation to check this in though the tree is closed.

Reviewed by Chris.

  • fixed <rdar://problem/3903990> can't tab to all items on www.google.com any more (other pages too?)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): when checking whether we moved the focus to another view, make sure we didn't "move" it to our documentView, because that's no move at all.
1:01 PM Changeset in webkit [8112] by darin
  • 4 edits in trunk/WebCore

Reviewed by Vicki.

  • fixed <rdar://problem/3901109> REGRESSION (171-172): repro crash in DOM::NodeImpl::setChanged at chick-fil-a.com
  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl): Added missing initialization for base class and node pointer.
  • fixed a few places that could leave dangling node pointers
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::~HTMLBodyElementImpl): Clear out the node pointer when the node is destroyed.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::~HTMLElementImpl): Ditto.
12:06 PM Changeset in webkit [8111] by cblu
  • 11 edits in trunk/WebCore

Fix for performance regression. My original patch added a signal for passing the data of a resource to its WebCore cache object. This patch passes the data with the preexisting "finished" symbol so we make less calls.
Fixed: <rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account

Reviewed by rjw.

  • khtml/misc/loader.cpp: (Loader::servePendingRequests): pass data param to slotFinished, removed allData signal (Loader::slotFinished): take data param
  • khtml/misc/loader.h:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): have m_result take a data param, removed m_allData (KIO::TransferJob::emitResult): take data param and pass it
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle:]): take data param and pass it (-[KWQResourceLoader cancel]): pass nil for data (-[KWQResourceLoader reportError]): ditto (-[KWQResourceLoader finishWithData:]): pass data
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): pass data param to slotFinished (KWQSlot::call): added support for slotFinished_Loader, removed slotAllData
10:57 AM Changeset in webkit [8110] by kocienda
  • 5 edits in trunk/WebCore

Reviewed by John

Did some clean up in the Position class as a result of trying to write some new layout
tests and discovering a bug along the way.

I removed these three functions from the Position class:

  1. bool isFirstRenderedPositionOnLine() const;
  2. bool isLastRenderedPositionOnLine() const;
  3. static bool renderersOnDifferentLine(RenderObject *r1, long o1, RenderObject *r2, long o2);
  4. bool inFirstEditableInRootEditableElement() const;

The first two have replacements in the VisiblePosition class, and some code has been
moved to use these new variants. The third function was a helper used only by these
first two function, and can be removed as well. The fourth function was not used by anyone.

  • khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::input): Change over to use VisiblePosition isFirstVisiblePositionOnLine().
  • khtml/editing/visible_position.cpp: (khtml::visiblePositionsOnDifferentLines): Added an additional check for blocks to this function. Incorrect results were being returned when asking about positions at the starts of blocks.
  • khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): Change over to use VisiblePosition isFirstVisiblePositionOnLine(). (DOM::Position::nextCharacterPosition): Change over to use VisiblePosition isLastVisiblePositionOnLine(). (DOM::Position::rendersInDifferentPosition): Removed use of #3 helper in a log message. We can live without it.
  • khtml/xml/dom_position.h: Update header for deletions.
9:31 AM Changeset in webkit [8109] by kocienda
  • 19 edits in trunk

Reviewed by John

Terminology change in execCommand command identifiers. Specifically, the name of
"InsertNewline" command has been changed to "InsertLineBreak". This matches the
terminology used by AppKit. It is also more accurate, since the insertion of a
"br" element is what the command does. The inspiration for this change is so the
-insertNewline AppKit method can be mapped to insert a new "div" element in
a document and avoid ambiguity with what the javascript editing command does.

  • khtml/editing/jsediting.cpp
  • layout-tests/editing/deleting/delete-tab-004.html
  • layout-tests/editing/editing.js
  • layout-tests/editing/inserting/insert-3654864-fix.html
  • layout-tests/editing/inserting/insert-3659587-fix.html
  • layout-tests/editing/inserting/insert-3775316-fix.html
  • layout-tests/editing/inserting/insert-3800346-fix.html
  • layout-tests/editing/inserting/insert-br-001.html
  • layout-tests/editing/inserting/insert-br-002.html
  • layout-tests/editing/inserting/insert-br-003.html
  • layout-tests/editing/inserting/insert-br-004.html
  • layout-tests/editing/inserting/insert-br-005.html
  • layout-tests/editing/inserting/insert-br-006.html
  • layout-tests/editing/inserting/insert-br-007.html
  • layout-tests/editing/inserting/insert-br-008.html
  • layout-tests/editing/inserting/insert-tab-004.html
  • layout-tests/editing/inserting/insert-text-with-newlines.html
  • layout-tests/editing/pasteboard/paste-text-010.html

Dec 2, 2004:

4:33 PM Changeset in webkit [8108] by kocienda
  • 2 edits
    2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3786362> REGRESSION (Mail): pasted text loses one newline

  • khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::doApply): Added check for strict mode before adding an extra br element at the end of a block. This is only necessary in quirks mode. Also, lower-case "br" used to make element. (khtml::ReplaceSelectionCommand::doApply): If the replacement adds a br element as the last element in a block and the document is in quirks mode, add an additional br to make the one in the replacement content show up. This turns out to be much the same logic as is done in InsertLineBreakCommand.
  • layout-tests/editing/inserting/insert-3786362-fix-expected.txt: Added.
  • layout-tests/editing/inserting/insert-3786362-fix.html: Added.
4:24 PM Changeset in webkit [8107] by rjw
  • 5 edits in trunk

WebKit:

Fixed <rdar://problem/3841332> REGRESSION (125.9-167u): repro crash in -[KWQPageState invalidate] involving .Mac images

Ensure that the document is cleared when leaving a non-HTML page. This ensures that
the b/f cache won't incorrectly trash the previous state when restoring.

Reviewed by John.

  • WebView.subproj/WebFrame.m: (-[WebFrame _setState:]):

WebCore:

Fixed <rdar://problem/3841332> REGRESSION (125.9-167u): repro crash in -[KWQPageState invalidate] involving .Mac images

Ensure that the document is cleared when leaving a non-HTML page. This ensures that
the b/f cache won't incorrectly trash the previous state when restoring.

Reviewed by John.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreBridge canCachePage]): (-[WebCoreBridge clear]):
3:08 PM Changeset in webkit [8106] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Richard

<rdar://problem/3748323> Problem with -[WebView editableDOMRangeForPoint:] (-isFlipped not taken into account?)
<rdar://problem/3852590> REGRESSION (Mail): Dropped content appears in wrong place if Mail message is scrolled down

When implementing drag and drop, moveDragCaretToPoint: and editableDOMRangeForPoint: are used in
concert to track the mouse and determine a drop location, respectively. However, moveDragCaretToPoint:
did a conversion of the passed-in point to the document view's coordinate space, whereas
editableDOMRangeForPoint: did not. Now it does.

Note that I will need to coordinate with Grant to have him roll out some code in Mail that
attempts to work around this problem (unsuccessfully), and actually manages to block the
real fix (which needs to be in WebKit).

  • WebView.subproj/WebView.m: (-[WebView editableDOMRangeForPoint:]): Convert the passed-in point to the document view's coordinate space.
2:17 PM Changeset in webkit [8105] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3895810> FATAL ERROR: <WebTextRenderer: 0x9328a20> unable to initialize with font "Times-Roman 16.00 pt. S ....

We have a hack to replace Times with Times New Roman if we fail
to setup Times. If we then fail to setup Times New Roman we
don't attempt to further fallback to the system font. Added
that additional fallback.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer webFallbackFontFamily]): (-[WebTextRenderer initWithFont:usingPrinterFont:]):
1:37 PM Changeset in webkit [8104] by rjw
  • 2 edits in trunk/WebKit

Fixed build problem on Tiger8A821. Private macro and function
we were using have been deprecated,

Reviewed by Vicki.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
1:04 PM Changeset in webkit [8103] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Richard

Fix for this bug:

<rdar://problem/3857775> 8A293: Mail.app crashes converting copy-pasted text into plain text

  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::commonAncestorContainer): Return the document element if no common ancestor container was found. This can happen in cases where the DOM was built from malformed markup (as in the case of this bug where there is content after the body tag). Did a little code clean up as well. (DOM::RangeImpl::compareBoundaryPoints): Made code more robust by adding some null checks.
11:05 AM Changeset in webkit [8102] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3668157> REGRESSION (Mail): shift-click deselects when selection was created right-to-left

  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventSingleClick): Use RangeImpl::compareBoundaryPoints to figure out which end of the selection to extend.
10:22 AM Changeset in webkit [8101] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3834917> REGRESSION (Mail): double-clicking blank line selects end of previous line
Fixed originally reported bug plus the case of double-clicking whitespace at the beginning of a line, which has a similar result.

  • khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (khtml::SimplifiedBackwardsTextIterator::handleTextNode): (khtml::SimplifiedBackwardsTextIterator::handleReplacedElement): (khtml::SimplifiedBackwardsTextIterator::handleNonTextNode): (khtml::SimplifiedBackwardsTextIterator::emitCharacter): Distinguish BR from whitespace.
  • khtml/editing/visible_text.h: Distinguish BR from whitespace.
  • khtml/editing/visible_units.cpp: (khtml::previousWordBoundary): Use UPSTREAM visible position now that SimplifiedBackwardsTextIterator distinguishes BR from whitespace. Otherwise, double-clicking at end of line would result in caret selection at start of next line.
9:43 AM Changeset in webkit [8100] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3900996> Crash dragging past end of contentEditable DIV, at DOM::RangeImpl::pastEndNode() const + 24

  • khtml/xml/dom_position.cpp: (DOM::Position::equivalentRangeCompliantPosition): Fixed this function so that it constrains the offset of the position to be >= 0 and <= number of kids of its node. Not doing this constraining led to a DOM exception trying to use a Position returned from this function to set the boundary point of a Range (which eventually led to the crash). Since this crash happened, it seems like this function was failing in its contract to return a range-compliant position, hence the need for this fix.
Note: See TracTimeline for information about the timeline view.