Timeline
Dec 10, 2004:
- 5:48 PM Changeset in webkit [8192] by
-
- 2 edits in trunk/WebCore
fixed deployment build bustage that John Louch ran into
- kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): move bool declaration inside exception-handling block to avoid obscure compiler error
- 3:15 PM Changeset in webkit [8191] by
-
- 2 edits in trunk/WebCore
Reviewed by Richard.
<rdar://problem/3907484> REGRESSION (125-173): crash when KWQTextField is dealloc'ed while setting focus (profoundlearning.com)
- kwq/KWQWidget.mm: (QWidget::setFocus): Handle the case where setting focus removed us from the superview - this can happen due to style changes on focus change.
- 3:02 PM Changeset in webkit [8190] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3915008> REGRESSION (Mail): Too much white space between lines separated by carriage returns
There are a number of interesting things we could do to fix this bug, including SPI and involving
the WebKit delegate, etc., however it seems reasonable to start with a hard-coded default that
will fix the bug in the general case until such time as we can come up with more specific
solutions.
So, I added a helper method to create <p> elements with an inline style that sets top and bottom margins
to 0.1em.
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::createParagraphElement): New factory method to create paragraph elements to insert. Also adds style information to keep the <p> from having "too-big" margins. (khtml::InsertParagraphSeparatorCommand::doApply): Call new factory method.
- khtml/editing/htmlediting.h: Add createParagraphElement() declaration.
- 2:15 PM Changeset in webkit [8189] by
-
- 6 edits in trunk/WebCore
Reviewed by Hyatt.
- fixed <rdar://problem/3910419> setting style={overflow:hidden} for <textarea> does not prevent appearance of scrollbars
- khtml/rendering/render_form.h: Remove now-unneeded wrap parameter.
- khtml/rendering/render_form.cpp: (RenderSubmitButton::rawText): Convert to QChar explicitly. (RenderLineEdit::updateFromElement): Ditto. (RenderLineEdit::slotTextChanged): Ditto. (RenderSelect::updateFromElement): Ditto. (TextAreaWidget::TextAreaWidget): Moved out most of the initialization since it's not something that requires a derived class. Now we don't use this class at all for WebCore, but they still have it for KDE. (TextAreaWidget::event): Moved out the ifdefs. (RenderTextArea::RenderTextArea): Moved setting code from TextAreaWidget here. Put a bunch that we don't need at all inside !APPLE_CHANGES, and removed the setting for scroll bars, since that's now done in setStyle. (RenderTextArea::handleFocusOut): Use type QTextEdit instead of TextAreaWidget since that's all that's needed and WebCore no longer has TextAreaWidget. (RenderTextArea::calcMinMaxWidth): Ditto. (RenderTextArea::setStyle): Add code to set scroll bar modes based on wrap setting combined with overflow style. (RenderTextArea::updateFromElement): Use type QTextEdit. (RenderTextArea::text): Ditto. (RenderTextArea::select): Ditto.
- kwq/KWQTextArea.mm: (-[KWQTextArea _configureTextViewForWordWrapMode]): Don't set horizontal scroller visibility here, since it's now handled by QTextEdit. (-[KWQTextArea initWithFrame:]): Don't set vertical scroller visibility or scroller auto-hiding.
- kwq/KWQTextEdit.h: Add setScrollBarModes function to be used instead of separate setter for the horizontal and vertical mode; needed because AppKit switches "autohide" for both at once.
- kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Added.
- 1:57 PM Changeset in webkit [8188] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
Fix for this bug:
<rdar://problem/3915047> HItting return in empty document inserts <p> but
insertion point does not move
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): The issue is that the code to insert the <p> element for the return is not detecting the fact that the document is empty. Inserting a <p> into an empty body will not "add a new line" as the user expects. With this change, we'll add a second <p> when the root editable element has no rendered kids.
- 1:13 PM Changeset in webkit [8187] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
<rdar://problem/3912979> REGRESSION (125-173): repro crash in HTMLCollectionImpl code (www.clubtravel.ie)
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Pass base when traversing the initial one step, otherwise we might inadvertantly step outside the collection base, thereby causing assertion failures or other badness later.
- 1:10 PM Changeset in webkit [8186] by
-
- 2 edits in trunk/WebCore
Reviewed by Chris
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): There is a starting block which is supposed to act as the root node for this operation. However, a loop was incorrectly coded, and a parent node search could escape this node. Also, one other piece to code to move nodes to the new <p> element should do nothing if the starting point for the selection is itself the starting block. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Similar changes, in spirit, to the above function, though the names and concepts are slightly different.
- 1:09 PM Changeset in webkit [8185] by
-
- 6 edits in trunk/WebCore
Reviewed by Ken.
<rdar://problem/3907705> REGRESSION (172-173): DHTML menus are broken at hrweb.apple.com
- khtml/dom/html_document.cpp: (HTMLDocument::nameableItems): New method, wrapper for HTMLCollection creation.
- khtml/dom/html_document.h:
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): use doc.nameableItems(), not doc.all()!
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Added new DOC_NAMEABLE_ITEMS type, this represents the items that can be accessed directly as a document propery, in particular forms, images, objects, applets and embeds. (HTMLCollectionImpl::updateNameCache): Fix some nameCache/idCache confusion. (HTMLFormCollectionImpl::updateNameCache): Ditto.
- khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::): Added new type.
- 12:23 PM Changeset in webkit [8184] by
-
- 5 edits in trunk/WebKit
Fixed <rdar://problem/3898708> REGRESSION (8A314-8A317): World Clock's short hand not displayed (ImageIO problem with PDF?)
Fixed <rdar://problem/3914012> use CG directly for pdf images not ImageIO
Create a PDF document and draw that instead of using ImageIO to create a rasterized image.
Reviewed by Maciej.
- WebCoreSupport.subproj/WebImageData.h:
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData setIsPDF:]): (-[WebImageData isPDF]): (-[WebImageData dealloc]): (-[WebImageData decodeData:isComplete:callback:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]): (-[WebImageData size]): (-[WebImageData animate]): (-[WebImageData _createPDFWithData:]): (-[WebImageData _PDFDocumentRef]): (-[WebImageData _PDFDrawInContext:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
- WebCoreSupport.subproj/WebImageRenderer.h:
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:callback:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): (_createImageRef):
- 10:53 AM Changeset in webkit [8183] by
-
- 2 edits in trunk/WebKit
Reviewed by Ken.
- fixed <rdar://problem/3855127> Error while printing w/o sheet, then window is left in a bad state, if there's no default printer set
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView beginDocument]): Our implementation of knowsPageRange puts the WebHTMLView into a special "printing mode". We must exit the "printing mode" to return to normal behavior. This is normally done in endDocument. However, it turns out that if there's an exception in [super beginDocument], then endDocument will not be called (lame-o AppKit API). So, we handle that case by catching the exception and exiting the "printing mode" in beginDocument when it occurs.
- 10:45 AM Changeset in webkit [8182] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3914779> REGRESSION (Mail): Cannot arrow navigate to position before last character on text-wrapped line
- khtml/rendering/render_text.cpp: (RenderText::caretRect): Code was not detecting space at the end of a line correctly. Now it does.
- 9:11 AM Changeset in webkit [8181] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3914755> REGRESSION (Mail): Insertion point disappears after pasting paragraph
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Selection could end up in a "placeholder" node that was removed from the document when pasting. This caused the disappearance. Now this is detected, and the selection is shifted to a node that is in the document.
- 8:29 AM Changeset in webkit [8180] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Remove conflict marker
Dec 9, 2004:
- 8:38 PM Changeset in webkit [8179] by
-
- 2 edits in trunk/WebCore
Check to disable threaded decoding during
layout tests wasn't invoking function, just checking address of
function, which would always return true.
- kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]):
- 7:09 PM Changeset in webkit [8178] by
-
- 4 edits in trunk/WebKit
Fixed <rdar://problem/3905789> Burn Disc image vibrates rapidly
Restrict our support for animated images to GIF. We used to
use presence of more than one image in a resource to determine
if an image should be animated. This caused us to animate icns!
If we ever support any other animated image formats we'll have
to extend.
Reviewed by Hyatt.
- WebCoreSupport.subproj/WebImageData.h:
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData shouldAnimate]):
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _startOrContinueAnimationIfNecessary]):
- 7:05 PM Changeset in webkit [8177] by
-
- 3 edits in trunk/WebCore
Fix for 3892686, left/top overflow was not being propagated properly up to containing blocks because of a math
error.
Also fix a bug I noticed on the same page where relative position offsets were not being added in properly for
all inlines when repainting.
Reviewed by rjw
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):
- khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
- 5:46 PM Changeset in webkit [8176] by
-
- 2 edits in trunk/WebKit
Make WebPluginDatabase.h private (Dashboard needs SPI).
- WebKit.pbproj/project.pbxproj:
- 5:38 PM Changeset in webkit [8175] by
-
- 1 add in trunk/LayoutTests/fast/block/float/tableshifting-expected.txt
New layout test to cover more details of tables shifting below floats.
- 5:38 PM Changeset in webkit [8174] by
-
- 6 edits1 add in trunk
Fix for 3867545, finance.yahoo.com lays out incorrectly. Add a quirk that will prevent tables from moving
down below floats when there is insufficient space. Instead we will match Gecko and just spill out of the
containing block to the right. This appears to be the more common desired behavior, despite being wrong.
WinIE sometimes wraps and sometimes doesn't, but it's really hard for us to match its inconsistency.
Reviewed by john
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::getClearDelta):
- layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
- layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
- layout-tests/apple-only/base/www.excite.com/index-expected.txt:
- layout-tests/fast/block/margin-collapse/102-expected.txt:
- layout-tests/fast/block/margin-collapse/102.html:
- 5:15 PM Changeset in webkit [8173] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3914078> worldclock crashing gc related
Use ProtectedValue for Context2D instance members.
Reviewed by Maciej.
- khtml/ecma/kjs_html.h:
- 4:37 PM Changeset in webkit [8172] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave.
- fixed <rdar://problem/3731099> Move AXTitle string for image elements to AXDescription
- kwq/KWQAccObject.mm: (-[KWQAccObject title]): moved image alt tag code out of here (-[KWQAccObject accessibilityDescription]): moved image alt tag code into this new method (-[KWQAccObject accessibilityAttributeNames]): include AXDescription in the set of attributes that ordinary elements return; this means that ordinary elements that aren't images will return a nil description, which isn't ideal, but is in keeping with the way the rest of these attributes work here. (-[KWQAccObject accessibilityAttributeValue:]): call accessibilityDescription when asked for AXDescription
- 4:10 PM Changeset in webkit [8171] by
-
- 2 edits in trunk/WebCore
Reviewed by Harrison
Fix for this bug:
<rdar://problem/3910425> REGRESSION (Mail): Crash in ReplaceSelectionCommand; selection is empty, leading to null deref
- khtml/editing/htmlediting.cpp: (khtml::MoveSelectionCommand::doApply): The node representing the destination for the move may have been deleted. If this is the case, set the destination to the node the delete command provides in its ending selection.
- 4:00 PM Changeset in webkit [8170] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (175+)
- 3:53 PM Changeset in webkit [8169]
-
- 2 copies in branches/Safari-175-branch
This commit was manufactured by cvs2svn to create branch
'Safari-175-branch'.
- 3:53 PM Changeset in webkit [8168]
-
- 2 copies in tags/Safari-175
This commit was manufactured by cvs2svn to create tag 'Safari-175'.
- 3:53 PM Changeset in webkit [8167] by
-
- 6 edits in trunk
Safari-175 stamp (skipped Safari-174 because it ends in a "4")
- 2:41 PM Changeset in webkit [8166] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Rolling out change. Tree was closed.
- 2:40 PM Changeset in webkit [8165] by
-
- 2 edits in trunk/WebCore
Rolling out change. Tree was closed.
- 2:37 PM Changeset in webkit [8164] by
-
- 2 edits in trunk/WebCore
Reviewed by Harrison
Fix for this bug:
<rdar://problem/3910425> REGRESSION (Mail): Crash in ReplaceSelectionCommand; selection is empty, leading to null deref
- khtml/editing/htmlediting.cpp: (khtml::MoveSelectionCommand::doApply): The node representing the destination for the move may have been deleted. If this is the case, set the destination to the node the delete command provides in its ending selection.
- 11:49 AM Changeset in webkit [8163] by
-
- 2 edits in trunk/WebKit
Workaround for this exception being raised during download:
[WebDownload connection:willStopBufferingData:]: selector not recognized
Reviewed by john.
- Misc.subproj/WebDownload.m: (-[WebDownload connection:willStopBufferingData:]): implement this method so no exception is raised. It is a bug in Foundation that this method is being called, but it's too late to fix Foundation since it has already been submitted this week. This workaround will prevent any problems from affecting users.
- 11:21 AM Changeset in webkit [8162] by
-
- 4 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3912841> REGRESSION (173-TOT): Some images report 0x0 dimensions on layout tests, causes spurious test failures
The new threaded image decoding capability can throw off layout tests. The issue is that the decoding
callback may not be delivered before the program asks for the dimensions of an image in order to
wrote the layout dimensions. More generally, I think we need to ensure that there are no races in
layout tests, so I have added a flag to the render tree debug code that we can set when debugging.
- kwq/KWQRenderTreeDebug.cpp: (debuggingRenderTree): New function. Returns flag which tells whether the program is debugging the render tree. (externalRepresentation): Sets debuggingRenderTree flag to true;
- kwq/KWQRenderTreeDebug.h:
- kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]): Checks debuggingRenderTree flag and will not do threaded decoding in any case if the flag is set.
- 10:57 AM Changeset in webkit [8161] by
-
- 5 edits in trunk/WebCore
Fix for busting XMLHTTPRequest.
Reviewed by kocienda.
- khtml/misc/loader.cpp: (Loader::servePendingRequests): pass true for deliverAllData
- kwq/KWQKJob.h: (KIO::get): take deliverAllData param (KIO::http_post): ditto
- kwq/KWQKJobClasses.h:
- kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): if deliverAllData, create signal with data param (KIO::TransferJob::emitResult): if deliverAllData, call signal with data param
- 7:32 AM Changeset in webkit [8160] by
-
- 2 edits in trunk/WebCore
Reviewed by John
<rdar://problem/3911011> REGRESSION (Mail): Spaces at end of line causing word wrap lost when copied/pasted
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::renderedText): Fixed the code so that spaces at the end of lines are not skipped.
Dec 8, 2004:
- 5:20 PM Changeset in webkit [8159] by
-
- 3 edits in trunk/WebKit
Fixed <rdar://problem/3911719> REGRESSION: Images no longer scale vertically
Account for scaling correctly when taking into account progressively
loaded images.
Also added implementation of repetition count for animated GIF images.
Also replaced strings with new constants from CFImageProperties.h
Also fixed possible problem with -(NSSize)size implementation,
relevant to Panther only.
Reviewed by Chris.
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _floatProperty:type:at:]): (-[WebImageData _frameDurationAt:]): (-[WebImageData _repetitionCount]):
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]):
- 2:54 PM Changeset in webkit [8158] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
<rdar://problem/3908017> REGRESSION (172-173): assertion in ObjectImp::construct trying to create JS error (24hourfitness.com)
The fix was to implement copy constructor and assignment operator,
the ones that worked on the base class did not replace the
defaults apparently!
- kjs/protect.h: (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::operator=):
Also fixed a bug in the GC test mode that compares the results of
the old collector and the new collector.
- kjs/value.cpp: (ValueImp::mark):
- 1:58 PM Changeset in webkit [8157] by
-
- 4 edits in trunk/WebKit
Removed NPN wrappers since these no longer need to be defined to make the QT plug-in work
since 3828925 has been fixed.
Reviewed by john.
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): use under-bar symbols since non-under-bar wrappers have been removed
- Plugins.subproj/npapi.m: removed NPN wrappers
- WebKit.exp: removed symbols
- 8:30 AM Changeset in webkit [8156] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Work around for this bug: <rdar://problem/3908282> REGRESSION (Mail): No drag image dragging selected text in Blot and Mail The reason for the workaround is that this method is called explicitly from the code to generate a drag image, and at that time, getRectsBeingDrawn:count: will return a zero count. This code change uses the passed-in rect when the count is zero.
Dec 7, 2004:
- 4:27 PM Changeset in webkit [8155] by
-
- 3 edits in trunk/WebKit
WebKit:
Support for fix for:
<rdar://problem/3734309> Safari doesn't open folders in title bar menu with non-Roman names using Cmd+click
Reviewed by john.
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): renamed to take relativeToURL parameter (+[NSURL _web_URLWithUserTypedString:]): call _web_URLWithUserTypedString:relativeToURL: with nil for URL
WebBrowser:
Fixed: <rdar://problem/3734309> Safari doesn't open folders in title bar menu with non-Roman names using Cmd+click
Reviewed by john.
- TitleBarButton.m:
- (-[TitleBarButton showPathRepresentingPopUpMenu]): use …
- since the path returned by [NSURL path] is of the "user typed" variety
- 3:39 PM Changeset in webkit [8154] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3905564> REGRESSION (Tiger); in History menu, pixel size appears but is wrong for standalone images in Safari.
Reviewed by Chris.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]):
- 3:06 PM Changeset in webkit [8153] by
-
- 17 edits4 adds in trunk
WebCore:
Support threaded image decoding on machines w/ > 2 CPUs.
Reviewed by Maciej and Chris.
- khtml/misc/loader.cpp: (CachedImageCallback::notifyUpdate): (CachedImageCallback::notifyFinished): (CachedImageCallback::notifyDecodingError): (CachedImageCallback::handleError): (CachedImageCallback::clear): (CachedImage::CachedImage): (CachedImage::clear): (CachedImage::data): (CachedImage::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::numRequests): (Loader::cancelRequests): (Loader::removeBackgroundDecodingRequest):
- khtml/misc/loader.h: (khtml::CachedImageCallback::CachedImageCallback): (khtml::CachedImageCallback::ref): (khtml::CachedImageCallback::deref): (khtml::CachedImage::decoderCallback):
- khtml/rendering/render_object.cpp: (RenderObject::setPixmap):
- kwq/KWQPixmap.h:
- kwq/KWQPixmap.mm: (-[WebImageCallback initWithCallback:khtml::]): (-[WebImageCallback _commonTermination]): (-[WebImageCallback dealloc]): (-[WebImageCallback finalize]): (-[WebImageCallback notify]): (-[WebImageCallback setImageSourceStatus:]): (-[WebImageCallback status]): (QPixmap::shouldUseThreadedDecoding): (QPixmap::receivedData):
- kwq/WebCoreImageRenderer.h:
- kwq/WebCoreImageRendererFactory.h:
- kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]): (+[WebCoreImageRendererFactory setShouldUseThreadedDecoding:]):
WebKit:
Support threaded image decoding on machines w/ > 2 CPUs.
Reviewed by Maciej and Chris.
- Misc.subproj/WebKitSystemBits.h:
- Misc.subproj/WebKitSystemBits.m: (WebSystemMainMemory): (WebNumberOfCPUs):
- WebCoreSupport.subproj/WebImageData.h:
- WebCoreSupport.subproj/WebImageData.m: (+[WebImageData initialize]): (-[WebImageData init]): (-[WebImageData _commonTermination]): (-[WebImageData dealloc]): (-[WebImageData _invalidateImages]): (-[WebImageData _imageSourceOptions]): (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData _createImages]): (-[WebImageData decodeData:isComplete:callback:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]): (drawPattern): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData isNull]): (-[WebImageData size]): (-[WebImageData _frameDurationAt:]): (-[WebImageData _frameDuration]): (+[WebImageData stopAnimationsInView:]): (-[WebImageData addAnimatingRenderer:inView:]): (-[WebImageData removeAnimatingRenderer:]):
- WebCoreSupport.subproj/WebImageDecodeItem.h: Added.
- WebCoreSupport.subproj/WebImageDecodeItem.m: Added. (+[WebImageDecodeItem decodeItemWithImage:data:isComplete:callback:]): (-[WebImageDecodeItem initWithImage:data:isComplete:callback:]): (-[WebImageDecodeItem finalize]): (-[WebImageDecodeItem dealloc]):
- WebCoreSupport.subproj/WebImageDecoder.h: Added.
- WebCoreSupport.subproj/WebImageDecoder.m: Added. (decoderNotifications): (+[WebImageDecoder initialize]): (+[WebImageDecoder notifyMainThread]): (+[WebImageDecoder sharedDecoder]): (+[WebImageDecoder performDecodeWithImage:data:isComplete:callback:]): (+[WebImageDecoder imageDecodesPending]): (+[WebImageDecoder decodeComplete:status:]): (-[WebImageDecoder init]): (-[WebImageDecoder dealloc]): (-[WebImageDecoder finalize]): (-[WebImageDecoder removeItem]): (-[WebImageDecoder addItem:]): (-[WebImageDecoder decodeItem:]): (decoderThread): (startDecoderThread):
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:callback:]): (-[WebInternalImage incrementalLoadWithBytes:length:complete:callback:]):
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation receivedData:withDataSource:]): (-[WebImageRepresentation receivedError:withDataSource:]): (-[WebImageRepresentation finishedLoadingWithDataSource:]):
WebBrowser:
Added a menu item to enable/disable threaded image decoding.
Reviewed by Maciej and Chris.
- Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleUseATSUForAllTextDrawing:]): (-[BrowserDocument toggleUseThreadedImageDecoding:]): (-[BrowserDocument validate_toggleUseThreadedImageDecoding:]):
- 12:46 PM Changeset in webkit [8152] by
-
- 2 edits in trunk/WebKit
Fix for performance regression.
Reviewed by kevin.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): construct the WebResource without copying the data
- 12:05 PM Changeset in webkit [8151] by
-
- 5 edits in trunk/WebKit
Fixed: <rdar://problem/3909243> REGRESSION: large standalone images stop loading part way through
Reviewed by kevin.
- WebView.subproj/WebBaseResourceHandleDelegate.h:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient addData:]): call super so it buffers the data
- 11:01 AM Changeset in webkit [8150] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Fix my NOBODY (OOPS!). John reviewed.
- 10:13 AM Changeset in webkit [8149] by
-
- 2 edits in trunk/WebCore
Reviewed by NOBODY (OOPS!).
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Fix a problem with my change in thei code yesterday. Call to insertBlockPlaceholderIfNeeded() must be done after new block has been inserted, otherwise a crash can result. Shuffle down call to insertBlockPlaceholderIfNeeded() a couple of lines (where the node is inserted), and all is good.
- 10:01 AM Changeset in webkit [8148] by
-
- 2 edits2 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3907422> REGRESSION (Mail): Pasting quoted content can place content after body element
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Detect when the body element is the "reference block" used for determining the location for inserting content. Do not allow an insert before or after if the reference block is the body. Perform insertNodeAt(0) and appendNode, respectively, in the block-is-body case.
- layout-tests/editing/inserting/insert-3907422-fix-expected.txt: Added.
- layout-tests/editing/inserting/insert-3907422-fix.html: Added.
- 9:45 AM Changeset in webkit [8147] by
-
- 2 edits in trunk/WebCore
Reviewed by Don.
- fixed <rdar://problem/3908701> REGRESSION: Cursor does not change to "hand" over active links
- kwq/KWQEvent.mm: (positionForEvent): Add NSMouseMoved to list of events that have mouse location.
- 9:02 AM Changeset in webkit [8146] by
-
- 4 edits in trunk/WebCore
Reviewed by John
Changed name of constant from KHTMLInterchangeNewline to AppleInterchangeNewline.
I discussed this with Hyatt and he agreed that going with "Apple" names was OK.
- khtml/editing/html_interchange.h: Name change, as described above.
- khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::isInterchangeNewlineComment): Ditto.
- khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): Ditto.
- 7:09 AM Changeset in webkit [8145] by
-
- 1 edit4 adds in trunk
Reviewed by me
Added a couple more layout tests.
- layout-tests/editing/deleting/delete-line-013-expected.txt: Added.
- layout-tests/editing/deleting/delete-line-013.html: Added.
- layout-tests/editing/deleting/delete-line-014-expected.txt: Added.
- layout-tests/editing/deleting/delete-line-014.html: Added.
