Timeline
Dec 13, 2004:
- 8:08 PM Changeset in webkit [8204]
-
- 5 copies2 deletes in tags/WebCore-175~1
This commit was manufactured by cvs2svn to create tag
'WebCore-175~1'.
- 8:08 PM Changeset in webkit [8203] by
-
- 2 edits in branches/Safari-175-branch/WebCore
versioning for dot submission, WebCore-175.1
- 8:00 PM Changeset in webkit [8202] by
-
- 2 edits in branches/Safari-175-branch/WebCore
- fix <rdar://problem/3915008> REGRESSION (Mail): Too much white space between lines separated by carriage returns for dot submission to Tiger.
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
- 6:44 PM Changeset in webkit [8201] by
-
- 6 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3827799> repro. crash with IBM Rational ClearCase Web under Safari (Java/LiveConnect-related)
Add support for calling static Java methods from JavaScript.
Reviewed by Maciej.
- bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bindings/jni/jni_runtime.cpp: (JavaMethod::JavaMethod):
- bindings/jni/jni_runtime.h: (KJS::Bindings::JavaMethod::isStatic):
- bindings/jni/jni_utility.cpp: (callJNIStaticMethod): (KJS::Bindings::callJNIBooleanMethod): (KJS::Bindings::callJNIStaticBooleanMethod):
- bindings/jni/jni_utility.h:
- 4:29 PM Changeset in webkit [8200] by
-
- 7 edits in trunk
WebKit:
Fixed <rdar://problem/3887767> LiveConnect doesn't propagate Java exceptions back to JavaScript (prevents security suite from running)
Reviewed by John.
- Plugins.subproj/WebJavaPlugIn.h:
Fixed <rdar://problem/3887767> LiveConnect doesn't propagate Java exceptions back to JavaScript (prevents security suite from running)
Reviewed by John.
- bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
- bindings/jni/jni_runtime.h:
- bindings/jni/jni_utility.h:
- 4:15 PM Changeset in webkit [8199] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej.
- fixed <rdar://problem/3744583> Safari can not quit when a webpage has a login sheet that can't be cancelled.
The proper fix for this would be to change the class of the NSPanel in the nib file.
But since this would require a localization change, I did a run-time hack instead.
I'll file a bug about fixing this when we're out of localization freeze.
- Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel replacePanelWithSubclassHack]): new method, creates a new panel that is identical to the original one except that it's our subclass, and moves all the subviews of the original panel into the new one. (-[WebAuthenticationPanel loadNib]): call replacePanelWithSubclassHack (-[NonBlockingPanel _blocksActionWhenModal:]): only method of new NSPanel subclass; overrides this SPI to allow the user to quit when one of these panels/sheets is on-screen
- 4:10 PM Changeset in webkit [8198] by
-
- 34 edits3 adds in trunk/WebCore
Reviewed by Ken.
- moved markup-related functions into new sources files in the editing directory
- removed all of the uses of dynamic_cast, preparing to turn off RTTI to make our code smaller and slightly faster
- ForwardingHeaders/editing/markup.h: Added.
- khtml/editing/markup.h: Added.
- khtml/editing/markup.cpp: Added.
- WebCore.pbproj/project.pbxproj: Added markup.h/cpp.
- khtml/dom/dom_node.cpp: (Node::toHTML): Call createMarkup since there's no toHTML in NodeImpl any more.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerHTML): Changed to call createMarkup. (HTMLElementImpl::outerHTML): Ditto.
- khtml/ecma/kjs_window.cpp: (Window::retrieveWindow): Comment out assert that uses dynamic_cast. (Window::retrieveActive): Ditto.
- khtml/editing/htmlediting.h: Added forward class declaration needed now that I removed one elsewhere.
- khtml/xml/dom_docimpl.h: Ditto.
- khtml/khtml_part.cpp: (KHTMLPart::slotDebugDOMTree): Use createMarkup instead of toHTML. (KHTMLPart::processObjectRequest): Use inherits instead of dynamic_cast.
- khtml/rendering/render_image.cpp: (RenderImage::paint): Add an explicit QChar conversion so this code still works even with the additional replace overloads added to QString.
- kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Ditto.
- khtml/rendering/render_object.h: Removed the version of arenaDelete that does not take an object base pointer, because it used dynamic_cast in its implementation. Made the other version public.
- khtml/rendering/render_object.cpp: Ditto.
- khtml/rendering/render_replaced.cpp: (RenderWidget::deref): Pass object base pointer to arenaDelete.
- khtml/xml/dom2_rangeimpl.h: Removed extra parameters from toHTML, and unneeded includes and declarations.
- khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): Changed to call createMarkup, and moved all the support code into markup.cpp.
- khtml/xml/dom_nodeimpl.h: Moved toHTML and related functions into markup.cpp.
- khtml/xml/dom_nodeimpl.cpp: Ditto.
- khtml/xml/dom_position.cpp: (DOM::startPosition): Implemented the version of this that takes a RangeImpl. Also added null checks so these return null positions rather than raising exceptions. (DOM::endPosition): Ditto.
- khtml/khtmlview.h: Added an APPLE_CHANGES function so inherits can detect this class without dynamic_cast.
- kwq/KWQFrame.h: Ditto.
- kwq/KWQFrame.mm: (QFrame::isQFrame): Ditto.
- kwq/KWQKPartsPart.h: Ditto.
- kwq/KWQKPartsPart.mm: (KParts::ReadOnlyPart::isKPartsReadOnlyPart): Ditto.
- kwq/KWQScrollView.h: Ditto.
- kwq/KWQScrollView.mm: (QScrollView::isQScrollView): Ditto.
- kwq/KWQKHTMLPart.h: Ditto.
- kwq/KWQKHTMLPart.mm: (KHTMLView::isKHTMLView): Ditto. (KWQKHTMLPart::setTitle): Added an explicit QChar conversion so this code still works even with the additional replace overloads added to QString. (KWQKHTMLPart::setStatusBarText): Ditto. (KWQKHTMLPart::runJavaScriptAlert): Ditto. (KWQKHTMLPart::runJavaScriptConfirm): Ditto. (KWQKHTMLPart::runJavaScriptPrompt): Ditto. (KWQKHTMLPart::attributedString): Ditto. (KWQKHTMLPart::isCharacterSmartReplaceExempt): Ditto. (KWQKHTMLPart::isKHTMLPart): That dynamic_cast thing (see above).
- kwq/KWQObject.h: Added virtual methods for the few cases where we need dynamic_cast-like behavior.
- kwq/KWQObject.mm: (QObject::inherits): Changed to not use dynamic cast. (QObject::isKHTMLPart): Added. Returns false. (QObject::isKHTMLView): Ditto. (QObject::isKPartsReadOnlyPart): Ditto. (QObject::isQFrame): Ditto. (QObject::isQScrollView): Ditto.
- kwq/KWQRenderTreeDebug.cpp: (write): Changed to use inherits rather than dynamic_cast. (writeSelection): Ditto.
- kwq/KWQSlot.mm: (KWQSlot::call): Call through to the version with just a job pointer parameter rather than going straight on to the "no parameters at all" version.
- kwq/KWQString.h:
- kwq/KWQString.mm: (QString::replace): Added overloads.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]): Changed to call functions in markup.h. (-[WebCoreBridge markupStringFromRange:nodes:]): Ditto. (-[WebCoreBridge selectedString]): Added an explicit QChar conversion so this code still works even with the additional replace overloads added to QString. (-[WebCoreBridge stringForRange:]): Ditto. (-[WebCoreBridge copyDOMNode:copier:]): Changed to call functions in markup.h. (-[WebCoreBridge elementAtPoint:]): QChar conversion. (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): Changed to call functions in markup.h. (-[WebCoreBridge documentFragmentWithText:]): Changed to call functions in markup.h.
- 3:17 PM Changeset in webkit [8197] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3917956> REGRESSION (Mail): pasting can leave insertion point inside pasted text
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Fix coding mistake. Calculations of bool flag based on leading and trailing whitespace positions was reversed! I must have introduced this error recently when changing around this code.
- 2:59 PM Changeset in webkit [8196] by
-
- 3 edits in trunk/WebCore
Fix for 3915787, macobserver doesn't paint. floatRect() needed to be const in the base class. Also hit-testing
and painting was using the wrong rect when setting up the x/y of the rect.
Reviewed by mjs
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint): (khtml::RenderBlock::nodeAtPoint):
- khtml/rendering/render_object.h: (khtml::RenderObject::floatRect):
- 2:41 PM Changeset in webkit [8195] by
-
- 3 edits2 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3917863> REGRESSION (Mail): pasting two lines of plain text copied from an RTF document results in two styles
Code to figuire out the end node to merge was missing the font tag in the second paragraph
written out by AppKit convert-to-HTML function. I refined the algorithm to be smarter.
- khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::mergeEndNode): Refine algorithm used to walk through the fragment being pasted looking for the node that is the last inline in the last block of the fragment. The old algorithm was insufficiently powerful. (khtml::ReplacementFragment::enclosingBlock): New helper function.
- khtml/editing/htmlediting.h: Add declaration for new helper function.
- layout-tests/editing/pasteboard/paste-text-011-expected.txt: Added.
- layout-tests/editing/pasteboard/paste-text-011.html: Added.
- 1:01 PM Changeset in webkit [8194] by
-
- 8 edits in trunk/WebCore
Reviewed by John
WebCore side of fix for this bug:
<rdar://problem/3768372> REGRESSION (Mail): paste of text ending in whitespace loses whitespace
Note that we are coordinating with Doug Davidson on the AppKit team to make a complete fix for this
bug. This change involves our half of the needed changes.
Note that a lot of this change has to do with changing code to use a <br> element instead of
a comment node as the mechanism to annotate HTML with information used to fix the bug. In some
other places, code to handle comments in markup can be removed since we do not use comments for
such annotations after this change.
- khtml/editing/htmlediting.cpp: Remove isComment() helper; no longer needed. (khtml::ReplacementFragment::ReplacementFragment): Change m_hasInterchangeNewlineComment name to m_hasInterchangeNewline. (khtml::ReplacementFragment::isInterchangeNewlineNode): Name changed from isInterchangeNewlineComment. (khtml::ReplacementFragment::isInterchangeConvertedSpaceSpan): Local variable name convertedSpaceSpanClass changed to convertedSpaceSpanClassString to match other uses of the idiom used here. (khtml::ReplaceSelectionCommand::doApply): Change hasInterchangeNewlineComment() name to hasInterchangeNewline().
- khtml/editing/htmlediting.h: Change names as noted in .cpp file. Remove isComment() helper; no longer needed. (khtml::ReplacementFragment::hasInterchangeNewline): Change hasInterchangeNewlineComment() name to hasInterchangeNewline().
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): No longer has includeCommentsInDOM flag; no longer needed as we do not annotate fragments with comments any longer.
- khtml/html/html_elementimpl.h: Ditto.
- khtml/xml/dom2_rangeimpl.cpp: Remove addCommentToHTMLMarkup() helper. No longer needed. (DOM::interchangeNewlineMarkupString): New helper to return <br> element markup we use to annotate content for interchange. (DOM::RangeImpl::toHTML): No longer uses addCommentToHTMLMarkup; now calls interchangeNewlineMarkupString(). Remove spurious semi-colon.
- khtml/xml/dom2_rangeimpl.h: Remove obsolete addCommentToHTMLMarkup() function and EAddToMarkup enum.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): No longer pass bool to ask for including comments in DOM when calling createContextualFragment().
- 12:59 PM Changeset in webkit [8193] by
-
- 3 edits in trunk
Versions were backwards in TOT. They should read Safari 2.0 (175+), not Safari 175+ (2.0).
Dec 10, 2004:
- 5:48 PM Changeset in webkit [8192] by
-
- 2 edits in trunk/WebCore
fixed deployment build bustage that John Louch ran into
- kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): move bool declaration inside exception-handling block to avoid obscure compiler error
- 3:15 PM Changeset in webkit [8191] by
-
- 2 edits in trunk/WebCore
Reviewed by Richard.
<rdar://problem/3907484> REGRESSION (125-173): crash when KWQTextField is dealloc'ed while setting focus (profoundlearning.com)
- kwq/KWQWidget.mm: (QWidget::setFocus): Handle the case where setting focus removed us from the superview - this can happen due to style changes on focus change.
- 3:02 PM Changeset in webkit [8190] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3915008> REGRESSION (Mail): Too much white space between lines separated by carriage returns
There are a number of interesting things we could do to fix this bug, including SPI and involving
the WebKit delegate, etc., however it seems reasonable to start with a hard-coded default that
will fix the bug in the general case until such time as we can come up with more specific
solutions.
So, I added a helper method to create <p> elements with an inline style that sets top and bottom margins
to 0.1em.
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::createParagraphElement): New factory method to create paragraph elements to insert. Also adds style information to keep the <p> from having "too-big" margins. (khtml::InsertParagraphSeparatorCommand::doApply): Call new factory method.
- khtml/editing/htmlediting.h: Add createParagraphElement() declaration.
- 2:15 PM Changeset in webkit [8189] by
-
- 6 edits in trunk/WebCore
Reviewed by Hyatt.
- fixed <rdar://problem/3910419> setting style={overflow:hidden} for <textarea> does not prevent appearance of scrollbars
- khtml/rendering/render_form.h: Remove now-unneeded wrap parameter.
- khtml/rendering/render_form.cpp: (RenderSubmitButton::rawText): Convert to QChar explicitly. (RenderLineEdit::updateFromElement): Ditto. (RenderLineEdit::slotTextChanged): Ditto. (RenderSelect::updateFromElement): Ditto. (TextAreaWidget::TextAreaWidget): Moved out most of the initialization since it's not something that requires a derived class. Now we don't use this class at all for WebCore, but they still have it for KDE. (TextAreaWidget::event): Moved out the ifdefs. (RenderTextArea::RenderTextArea): Moved setting code from TextAreaWidget here. Put a bunch that we don't need at all inside !APPLE_CHANGES, and removed the setting for scroll bars, since that's now done in setStyle. (RenderTextArea::handleFocusOut): Use type QTextEdit instead of TextAreaWidget since that's all that's needed and WebCore no longer has TextAreaWidget. (RenderTextArea::calcMinMaxWidth): Ditto. (RenderTextArea::setStyle): Add code to set scroll bar modes based on wrap setting combined with overflow style. (RenderTextArea::updateFromElement): Use type QTextEdit. (RenderTextArea::text): Ditto. (RenderTextArea::select): Ditto.
- kwq/KWQTextArea.mm: (-[KWQTextArea _configureTextViewForWordWrapMode]): Don't set horizontal scroller visibility here, since it's now handled by QTextEdit. (-[KWQTextArea initWithFrame:]): Don't set vertical scroller visibility or scroller auto-hiding.
- kwq/KWQTextEdit.h: Add setScrollBarModes function to be used instead of separate setter for the horizontal and vertical mode; needed because AppKit switches "autohide" for both at once.
- kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Added.
- 1:57 PM Changeset in webkit [8188] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
Fix for this bug:
<rdar://problem/3915047> HItting return in empty document inserts <p> but
insertion point does not move
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): The issue is that the code to insert the <p> element for the return is not detecting the fact that the document is empty. Inserting a <p> into an empty body will not "add a new line" as the user expects. With this change, we'll add a second <p> when the root editable element has no rendered kids.
- 1:13 PM Changeset in webkit [8187] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
<rdar://problem/3912979> REGRESSION (125-173): repro crash in HTMLCollectionImpl code (www.clubtravel.ie)
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Pass base when traversing the initial one step, otherwise we might inadvertantly step outside the collection base, thereby causing assertion failures or other badness later.
- 1:10 PM Changeset in webkit [8186] by
-
- 2 edits in trunk/WebCore
Reviewed by Chris
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): There is a starting block which is supposed to act as the root node for this operation. However, a loop was incorrectly coded, and a parent node search could escape this node. Also, one other piece to code to move nodes to the new <p> element should do nothing if the starting point for the selection is itself the starting block. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Similar changes, in spirit, to the above function, though the names and concepts are slightly different.
- 1:09 PM Changeset in webkit [8185] by
-
- 6 edits in trunk/WebCore
Reviewed by Ken.
<rdar://problem/3907705> REGRESSION (172-173): DHTML menus are broken at hrweb.apple.com
- khtml/dom/html_document.cpp: (HTMLDocument::nameableItems): New method, wrapper for HTMLCollection creation.
- khtml/dom/html_document.h:
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): use doc.nameableItems(), not doc.all()!
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Added new DOC_NAMEABLE_ITEMS type, this represents the items that can be accessed directly as a document propery, in particular forms, images, objects, applets and embeds. (HTMLCollectionImpl::updateNameCache): Fix some nameCache/idCache confusion. (HTMLFormCollectionImpl::updateNameCache): Ditto.
- khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::): Added new type.
- 12:23 PM Changeset in webkit [8184] by
-
- 5 edits in trunk/WebKit
Fixed <rdar://problem/3898708> REGRESSION (8A314-8A317): World Clock's short hand not displayed (ImageIO problem with PDF?)
Fixed <rdar://problem/3914012> use CG directly for pdf images not ImageIO
Create a PDF document and draw that instead of using ImageIO to create a rasterized image.
Reviewed by Maciej.
- WebCoreSupport.subproj/WebImageData.h:
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData setIsPDF:]): (-[WebImageData isPDF]): (-[WebImageData dealloc]): (-[WebImageData decodeData:isComplete:callback:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]): (-[WebImageData size]): (-[WebImageData animate]): (-[WebImageData _createPDFWithData:]): (-[WebImageData _PDFDocumentRef]): (-[WebImageData _PDFDrawInContext:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
- WebCoreSupport.subproj/WebImageRenderer.h:
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:callback:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): (_createImageRef):
- 10:53 AM Changeset in webkit [8183] by
-
- 2 edits in trunk/WebKit
Reviewed by Ken.
- fixed <rdar://problem/3855127> Error while printing w/o sheet, then window is left in a bad state, if there's no default printer set
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView beginDocument]): Our implementation of knowsPageRange puts the WebHTMLView into a special "printing mode". We must exit the "printing mode" to return to normal behavior. This is normally done in endDocument. However, it turns out that if there's an exception in [super beginDocument], then endDocument will not be called (lame-o AppKit API). So, we handle that case by catching the exception and exiting the "printing mode" in beginDocument when it occurs.
- 10:45 AM Changeset in webkit [8182] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3914779> REGRESSION (Mail): Cannot arrow navigate to position before last character on text-wrapped line
- khtml/rendering/render_text.cpp: (RenderText::caretRect): Code was not detecting space at the end of a line correctly. Now it does.
- 9:11 AM Changeset in webkit [8181] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3914755> REGRESSION (Mail): Insertion point disappears after pasting paragraph
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Selection could end up in a "placeholder" node that was removed from the document when pasting. This caused the disappearance. Now this is detected, and the selection is shifted to a node that is in the document.
- 8:29 AM Changeset in webkit [8180] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Remove conflict marker
Dec 9, 2004:
- 8:38 PM Changeset in webkit [8179] by
-
- 2 edits in trunk/WebCore
Check to disable threaded decoding during
layout tests wasn't invoking function, just checking address of
function, which would always return true.
- kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]):
- 7:09 PM Changeset in webkit [8178] by
-
- 4 edits in trunk/WebKit
Fixed <rdar://problem/3905789> Burn Disc image vibrates rapidly
Restrict our support for animated images to GIF. We used to
use presence of more than one image in a resource to determine
if an image should be animated. This caused us to animate icns!
If we ever support any other animated image formats we'll have
to extend.
Reviewed by Hyatt.
- WebCoreSupport.subproj/WebImageData.h:
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData shouldAnimate]):
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _startOrContinueAnimationIfNecessary]):
- 7:05 PM Changeset in webkit [8177] by
-
- 3 edits in trunk/WebCore
Fix for 3892686, left/top overflow was not being propagated properly up to containing blocks because of a math
error.
Also fix a bug I noticed on the same page where relative position offsets were not being added in properly for
all inlines when repainting.
Reviewed by rjw
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):
- khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
- 5:46 PM Changeset in webkit [8176] by
-
- 2 edits in trunk/WebKit
Make WebPluginDatabase.h private (Dashboard needs SPI).
- WebKit.pbproj/project.pbxproj:
- 5:38 PM Changeset in webkit [8175] by
-
- 1 add in trunk/LayoutTests/fast/block/float/tableshifting-expected.txt
New layout test to cover more details of tables shifting below floats.
- 5:38 PM Changeset in webkit [8174] by
-
- 6 edits1 add in trunk
Fix for 3867545, finance.yahoo.com lays out incorrectly. Add a quirk that will prevent tables from moving
down below floats when there is insufficient space. Instead we will match Gecko and just spill out of the
containing block to the right. This appears to be the more common desired behavior, despite being wrong.
WinIE sometimes wraps and sometimes doesn't, but it's really hard for us to match its inconsistency.
Reviewed by john
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::getClearDelta):
- layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
- layout-tests/apple-only/base/www.ebay.com/index-expected.txt:
- layout-tests/apple-only/base/www.excite.com/index-expected.txt:
- layout-tests/fast/block/margin-collapse/102-expected.txt:
- layout-tests/fast/block/margin-collapse/102.html:
- 5:15 PM Changeset in webkit [8173] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3914078> worldclock crashing gc related
Use ProtectedValue for Context2D instance members.
Reviewed by Maciej.
- khtml/ecma/kjs_html.h:
- 4:37 PM Changeset in webkit [8172] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave.
- fixed <rdar://problem/3731099> Move AXTitle string for image elements to AXDescription
- kwq/KWQAccObject.mm: (-[KWQAccObject title]): moved image alt tag code out of here (-[KWQAccObject accessibilityDescription]): moved image alt tag code into this new method (-[KWQAccObject accessibilityAttributeNames]): include AXDescription in the set of attributes that ordinary elements return; this means that ordinary elements that aren't images will return a nil description, which isn't ideal, but is in keeping with the way the rest of these attributes work here. (-[KWQAccObject accessibilityAttributeValue:]): call accessibilityDescription when asked for AXDescription
- 4:10 PM Changeset in webkit [8171] by
-
- 2 edits in trunk/WebCore
Reviewed by Harrison
Fix for this bug:
<rdar://problem/3910425> REGRESSION (Mail): Crash in ReplaceSelectionCommand; selection is empty, leading to null deref
- khtml/editing/htmlediting.cpp: (khtml::MoveSelectionCommand::doApply): The node representing the destination for the move may have been deleted. If this is the case, set the destination to the node the delete command provides in its ending selection.
- 4:00 PM Changeset in webkit [8170] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (175+)
- 3:53 PM Changeset in webkit [8169]
-
- 2 copies in branches/Safari-175-branch
This commit was manufactured by cvs2svn to create branch
'Safari-175-branch'.
- 3:53 PM Changeset in webkit [8168]
-
- 2 copies in tags/Safari-175
This commit was manufactured by cvs2svn to create tag 'Safari-175'.
- 3:53 PM Changeset in webkit [8167] by
-
- 6 edits in trunk
Safari-175 stamp (skipped Safari-174 because it ends in a "4")
- 2:41 PM Changeset in webkit [8166] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Rolling out change. Tree was closed.
- 2:40 PM Changeset in webkit [8165] by
-
- 2 edits in trunk/WebCore
Rolling out change. Tree was closed.
- 2:37 PM Changeset in webkit [8164] by
-
- 2 edits in trunk/WebCore
Reviewed by Harrison
Fix for this bug:
<rdar://problem/3910425> REGRESSION (Mail): Crash in ReplaceSelectionCommand; selection is empty, leading to null deref
- khtml/editing/htmlediting.cpp: (khtml::MoveSelectionCommand::doApply): The node representing the destination for the move may have been deleted. If this is the case, set the destination to the node the delete command provides in its ending selection.
- 11:49 AM Changeset in webkit [8163] by
-
- 2 edits in trunk/WebKit
Workaround for this exception being raised during download:
[WebDownload connection:willStopBufferingData:]: selector not recognized
Reviewed by john.
- Misc.subproj/WebDownload.m: (-[WebDownload connection:willStopBufferingData:]): implement this method so no exception is raised. It is a bug in Foundation that this method is being called, but it's too late to fix Foundation since it has already been submitted this week. This workaround will prevent any problems from affecting users.
- 11:21 AM Changeset in webkit [8162] by
-
- 4 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3912841> REGRESSION (173-TOT): Some images report 0x0 dimensions on layout tests, causes spurious test failures
The new threaded image decoding capability can throw off layout tests. The issue is that the decoding
callback may not be delivered before the program asks for the dimensions of an image in order to
wrote the layout dimensions. More generally, I think we need to ensure that there are no races in
layout tests, so I have added a flag to the render tree debug code that we can set when debugging.
- kwq/KWQRenderTreeDebug.cpp: (debuggingRenderTree): New function. Returns flag which tells whether the program is debugging the render tree. (externalRepresentation): Sets debuggingRenderTree flag to true;
- kwq/KWQRenderTreeDebug.h:
- kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]): Checks debuggingRenderTree flag and will not do threaded decoding in any case if the flag is set.
- 10:57 AM Changeset in webkit [8161] by
-
- 5 edits in trunk/WebCore
Fix for busting XMLHTTPRequest.
Reviewed by kocienda.
- khtml/misc/loader.cpp: (Loader::servePendingRequests): pass true for deliverAllData
- kwq/KWQKJob.h: (KIO::get): take deliverAllData param (KIO::http_post): ditto
- kwq/KWQKJobClasses.h:
- kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): if deliverAllData, create signal with data param (KIO::TransferJob::emitResult): if deliverAllData, call signal with data param
- 7:32 AM Changeset in webkit [8160] by
-
- 2 edits in trunk/WebCore
Reviewed by John
<rdar://problem/3911011> REGRESSION (Mail): Spaces at end of line causing word wrap lost when copied/pasted
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::renderedText): Fixed the code so that spaces at the end of lines are not skipped.
