Context Navigation

← Previous Period
Next Period →

Timeline

Dec 17, 2004:

7:30 PM Changeset in webkit [8251] by rjw

1 edit in trunk/WebCore/khtml/misc/loader.cpp

Use 40K, not 40MB as min max cacheable object size.

5:31 PM Changeset in webkit [8250] by hyatt

3 edits in trunk/WebCore

Fix for 3923255, specified percentage heights of divs with overflow auto inside tables not honored.

Reviewed by kocienda

khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):
khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):

4:43 PM Changeset in webkit [8249] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Kevin.

<rdar://problem/3926869> Opening caches window after running PLT causes crash

kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): Don't include simple numbers in the protected value table. (KJS::ProtectedValues::increaseProtectCount): Ditto. (KJS::ProtectedValues::decreaseProtectCount): Ditto.

4:38 PM Changeset in webkit [8248] by harrison

2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3924930> REGRESSION: triple click does not select to end of line

khtml/editing/visible_units.cpp: (khtml::endOfParagraph): When includeLineBreak is true, allow traversal to next node after enclosingBlockFlowElement.

4:16 PM Changeset in webkit [8247] by hyatt

1 edit in trunk/WebCore/kwq/KWQFoundationExtras.h

Fix Panther build bustage.

3:32 PM Changeset in webkit [8246] by kocienda

2 edits in trunk/WebCore

Reviewed by Vicki

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Missed deleting some now-obsolete expcetion codes when I added the createBreakElement() function.

3:01 PM Changeset in webkit [8245] by rjw

3 edits in trunk/WebKit

Make image decoding as lazy as possible for non-threaded case; in some cases
can avoid unnecessary decoding work.

Reviewed by Chris.

WebCoreSupport.subproj/WebImageData.h:
WebCoreSupport.subproj/WebImageData.m: (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):

2:56 PM Changeset in webkit [8244] by rjw

2 edits in trunk/WebCore

Set the floor of max cacheable object size to 40K. This restores
the long standing floor. Lower floor deleteriously impacts the PLT.
Reviewed by Hyatt.

khtml/khtml_part.cpp: (KHTMLPart::checkCompleted):
khtml/misc/loader.cpp: (Cache::setSize):

2:21 PM Changeset in webkit [8243] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3926142> REGRESSION (Mail): Deleting text decreases quote level

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Stop merging nodes when a is hit. Formerly checked only for block boundary.

1:58 PM Changeset in webkit [8242] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

Add KWQCFAutorelease for autoreleasing CF objects.

kwq/KWQFoundationExtras.h: (KWQCFAutorelease): New.

1:56 PM Changeset in webkit [8241] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

Fix GC compatibility in getNSString.

kwq/KWQString.mm: (QString::getNSString):

Use NSString allocator instead of CFString, so that autorelease works under GC.

11:58 AM Changeset in webkit [8240] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3890973> REGRESSION (Mail): Deleting reorders remaining text

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Added check to ensure that moving content will not move it after the <body> element.

10:57 AM Changeset in webkit [8239] by kocienda

1 edit
8 adds in trunk

Reviewed by me

Added new layout tests covering cases from recent bug fixes.

layout-tests/editing/inserting/insert-div-018-expected.txt: Added.
layout-tests/editing/inserting/insert-div-018.html: Added.
layout-tests/editing/inserting/insert-div-019-expected.txt: Added.
layout-tests/editing/inserting/insert-div-019.html: Added.
layout-tests/editing/inserting/insert-div-020-expected.txt: Added.
layout-tests/editing/inserting/insert-div-020.html: Added.
layout-tests/editing/inserting/insert-div-021-expected.txt: Added.
layout-tests/editing/inserting/insert-div-021.html: Added.

10:31 AM Changeset in webkit [8238] by kocienda

3 edits in trunk

Reviewed by me

Changes in layout resulting from giving elements no margin rather than 0.1em margin.

layout-tests/editing/inserting/insert-div-013-expected.txt
layout-tests/editing/inserting/insert-div-014-expected.txt

10:01 AM Changeset in webkit [8237] by kocienda

3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3925317> Increase quote in email and with cursor below the quote the new line appears above the quote

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
khtml/editing/visible_position.cpp: Refine rules for whether to use the starting node or the starting block as the reference node for the insertion of the new block. (khtml::isLastVisiblePositionInBlock): Tweak rules again. Descendants of following blocks should answer true. I worked this all out on the whiteboard this time. This should be the last tweak.

8:29 AM Changeset in webkit [8236] by kdecker

2 edits in trunk/WebCore

Reviewed by Ken.

Fixed <rdar://problem/3824438> Need a clean way for Dashboard to detect when an XML parsing error occurs

khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::insertErrorMessageBlock): In the xml error report, instead of a generic <div>, use <parsererror> to match Mozilla.

Dec 16, 2004:

5:05 PM Changeset in webkit [8235] by kocienda

2 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3924888> REGRESSION (Mail): Hitting return key at end of line does not insert visible newline

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Tweaked code I added just before to fix 3924486, so that it checks the downstream node for the starting position.

4:57 PM Changeset in webkit [8234] by kocienda

3 edits in trunk/WebCore

Reviewed by Chris

Added new createBreakElement() function that makes creating a element a one-liner.
Converted all the code that used to call the DocumentImpl, and dealt with the exceptionCode,
over to this new helper.

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Now uses new helper function. (khtml::InsertLineBreakCommand::doApply): Ditto. (khtml::InsertParagraphSeparatorCommand::doApply): Ditto. (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Ditto. (khtml::ReplaceSelectionCommand::doApply): Ditto. (khtml::createBreakElement): New helper.
khtml/editing/htmlediting.h: Ditto.

4:10 PM Changeset in webkit [8233] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed <rdar://problem/3920764> Unimplemented String methods toLocaleLowerCase and toLocaleUpperCase

kjs/string_object.h: Added toLocaleLowerCase and toLocaleUpperCase.
kjs/string_object.cpp: (StringProtoFuncImp::call): Made locale versions be synonmyms for the non-locale-specific versions.
kjs/string_object.lut.h: Regenerated.

4:03 PM Changeset in webkit [8232] by hyatt

2 edits
2 adds in trunk

Fix a bug where vertical-align values that depended on their parent's value went crazy if the parent was
vertical-align top or bottom. The bug is 3771007, bankofamerica's ebills page.

Reviewed by kocienda

khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition):

3:39 PM Changeset in webkit [8231] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for these bugs:

<rdar://problem/3924486> REGRESSION (Mail): Hitting return key does not insert visible newline
<rdar://problem/3924579> REGRESSION (Mail): After deleting, hitting return key does not insert visible newline

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): For the first bug, detect when inserting a will make a visible collapse. For the second bug, move the code that inserts the new after a check which may move the node used as the reference node for the insertion. Also change this code to insert the after the last sibling of the starting position, to move it past the nodes we're going to want to shift into the new .

2:44 PM Changeset in webkit [8230] by sullivan

2 edits in trunk/WebKit

Reviewed by Chris.

One of the assertions from my previous checkin fired, so
I made this code more robust.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _preferences]): new helper method, returns global preferences if webView is nil, otherwise returns webView's preferences (-[WebBridge getObjectCacheSize]): use new helper method, remove now-unnecessary assert (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): ditto

2:10 PM Changeset in webkit [8229] by darin

8 edits in trunk/WebCore

Reviewed by Ken.

use elements rather than when pasting plain text; also use margin of 0 rather than 0.1 em after talking this over with Dave and Ken

khtml/editing/htmlediting.h: Added createDefaultParagraphElement and createBlockPlaceholderElement.
khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Use new createBlockPlaceholderElement helper so this can share code with the plain-text conversion code. (khtml::InsertParagraphSeparatorCommand::createParagraphElement): Use new createDefaultParagraphElement helper so this can share code with the plain-text conversion code. (khtml::createDefaultParagraphElement): Added. (khtml::createBlockPlaceholderElement): Added.

khtml/editing/markup.cpp: (khtml::createFragmentFromText): Use paragraphs rather than elements for pasting plain text.

regenerated these files with the newer gperf

khtml/css/cssproperties.c: Regenerated.
khtml/css/cssvalues.c: Regenerated.
khtml/misc/htmlattrs.c: Regenerated.
khtml/misc/htmltags.c: Regenerated.

1:33 PM Changeset in webkit [8228] by sullivan

12 edits in trunk/WebKit

Reviewed by Darin.

fixed <rdar://problem/3913523> Mail needs SPI for adding tooltips to links
cleaned up some calls to +[WebPreferences standardPreferences] that should have been using -[WebView preferences]

This adds a (currently SPI-only) new feature that shows the URL of the link
under the mouse in a toolTip. I tested this in Safari, but we're adding this
feature for Mail, and Safari won't use it (unless of course you know the
magic defaults command)

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): use -[WebView preferences] instead of +[WebPreferences standardPreferences]

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getObjectCacheSize]): ditto (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): ditto

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willCacheResponse:]): ditto

WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): ditto (-[WebFrame _loadItem:withLoadType:]): ditto

WebView.subproj/WebHTMLViewInternal.h: private struct now keeps ivar for cached value of showsURLsInToolTips so it doesn't have look it up in preferences a zillion times

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): if private->showsURLsInToolTips is true, set the toolTip from the URL. Fall back to showing the title attribute in case some element has a title attribute but no URL. (-[WebHTMLView _mayStartDragAtEventLocation:]): use -[WebView preferences] instead of +[WebPreferences standardPreferences] (-[WebHTMLView _resetCachedWebPreferences:]): get a fresh value for private->showsURLsInToolTips (-[WebHTMLView initWithFrame:]): call _resetCachedWebPreferences the first time, and listen for WebPreferencesChanged notifications (-[WebHTMLView _handleStyleKeyEquivalent:]): use -[WebView preferences] instead of +[WebPreferences standardPreferences]

WebView.subproj/WebPreferenceKeysPrivate.h: added WebKitShowsURLsInToolTipsPreferenceKey

WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): initialize WebKitShowsURLsInToolTipsPreferenceKey to 0 (-[WebPreferences showsURLsInToolTips]): return WebKitShowsURLsInToolTipsPreferenceKey value (-[WebPreferences setShowsURLsInToolTips:]): set WebKitShowsURLsInToolTipsPreferenceKey value

WebView.subproj/WebPreferencesPrivate.h: add declarations for showsURLsInToolTips and setter

WebView.subproj/WebTextView.m: (-[WebTextView _preferences]): new helper method that gets preferences from webView if there is a webView, otherwise gets global preferences (-[WebTextView setFixedWidthFont]): use new helper method rather than always using global preferences (-[WebTextView initWithFrame:]): observe WebPreferencesChangedNotification instead of unnecessarily general NSUserDefaultsChangedNotification

1:15 PM Changeset in webkit [8227] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3924291> REGRESSION (Mail): Crash deleting content following a element

khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingInlineElement): Fixed problem in this function where recursive search for parent that is not an inline would skip past previous siblings of nodes which were blocks. Now it stops looking in this situation. This problem eventually caused the delete code to try to merge a node under a descendent.

11:21 AM Changeset in webkit [8226] by adele

2 edits in trunk/WebCore

Change by Richard, reviewed by me.

Fix for: <rdar://problem/3923983> background image decoding prevents page with 0Kb image from finishing to load

khtml/misc/loader.cpp: (CachedImage::data): Added call to notifyFinished so the 0Kb image case finishes loading.

10:53 AM Changeset in webkit [8225] by adele

2 edits in trunk/WebCore

Reviewed by Chris.

Fix for: <rdar://problem/3534824> VIP: some navigation links on safeway.com don't work due to a JavaScript quirk

Added a call to ObjectImp::get before Window::get just returns Undefined.
This was preventing us from getting the toString function from a Window object.

khtml/ecma/kjs_window.cpp: (Window::get):

10:46 AM Changeset in webkit [8224] by kocienda

3 edits
16 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3918351> REGRESSION (Mail, 173-175+): Return before first char of line leaves insertion point in wrong place

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Basically, did a rewrite of this function to do a better job than it was doing before. Added several test cases to prove I am on a better track.
khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInBlock): Tweaked the rules a bit to fix an issue very similar to the leaving-the-bar-node case problem I just fixed in a recent checkin (relevant markup: foobar). This function was returning true for the first position in "bar". Wrong. Also tightened up other rule: Should not report true when relationship between blocks cannot be determined. (khtml::isLastVisiblePositionInBlock): Tightened up rule as above: Should not report true when relationship between blocks cannot be determined.
layout-tests/editing/inserting/insert-div-010-expected.txt: Added.
layout-tests/editing/inserting/insert-div-010.html: Added.
layout-tests/editing/inserting/insert-div-011-expected.txt: Added.
layout-tests/editing/inserting/insert-div-011.html: Added.
layout-tests/editing/inserting/insert-div-012-expected.txt: Added.
layout-tests/editing/inserting/insert-div-012.html: Added.
layout-tests/editing/inserting/insert-div-013-expected.txt: Added.
layout-tests/editing/inserting/insert-div-013.html: Added.
layout-tests/editing/inserting/insert-div-014-expected.txt: Added.
layout-tests/editing/inserting/insert-div-014.html: Added.
layout-tests/editing/inserting/insert-div-015-expected.txt: Added.
layout-tests/editing/inserting/insert-div-015.html: Added.
layout-tests/editing/inserting/insert-div-016-expected.txt: Added.
layout-tests/editing/inserting/insert-div-016.html: Added.
layout-tests/editing/inserting/insert-div-017-expected.txt: Added.
layout-tests/editing/inserting/insert-div-017.html: Added.

10:18 AM Changeset in webkit [8223] by kocienda

1 edit in trunk/WebCore/khtml/editing/visible_text.h

Failed to check in this file after changing it; I hate having too many changes in my tree at once

10:04 AM Changeset in webkit [8222] by kocienda

1 edit
2 adds in trunk

Reviewed by me

Added a layout test based on my last checkin.

layout-tests/editing/selection/move-by-word-001-expected.txt: Added.
layout-tests/editing/selection/move-by-word-001.html: Added.

9:57 AM Changeset in webkit [8221] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3917929> REGRESSION (Mail): Command-left-arrow leaves insertion point too high after specific steps

khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::advance): Add new check for leaving a text node and iterating backwards into a different block that is an descendent of the block containing the text node (as in leaving the "bar" node in this example: foobar). (khtml::SimplifiedBackwardsTextIterator::handleNonTextNode): Call new emitNewlineForBROrText helper. (khtml::SimplifiedBackwardsTextIterator::emitNewlineForBROrText): Factor out code from handleNonTextNode, since it is called from there, and now also from advance().

Dec 15, 2004:

5:02 PM Changeset in webkit [8220] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed problem where plain-text would put a blank line between each even when they have no margins

khtml/editing/visible_text.cpp: (khtml::TextIterator::exitNode): Add more checks and only set the "add one more newline" flag if the margin is sufficient. A more complete fix would ignore the node type altogether and use the render tree instead.

11:13 AM Changeset in webkit [8219] by sullivan

12 edits
2 adds in trunk

WebCore:

Reviewed by Ken.

rest of WebCore fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

khtml/editing/edit_actions.h: new header, contains EditAction enum (renamed from HTMLEditAction, formerly in htmlediting.h)

ForwardingHeaders/editing/edit_actions.h: new forwarding header

khtml/editing/htmlediting.h:

removed HTMLEditAction enum in favor of including edit_actions.h; …: namespace to EditAction usages; added m_editingAction ivar to ApplyStyleCommand

khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::editingAction): update for enum name change (khtml::EditCommand::editingAction): ditto (khtml::ApplyStyleCommand::ApplyStyleCommand): added editingAction parameter to this constructor (khtml::ApplyStyleCommand::editingAction): return new ivar (khtml::DeleteSelectionCommand::editingAction): update for enum name change (khtml::MoveSelectionCommand::editingAction): ditto (khtml::TypingCommand::editingAction): ditto (khtml::ReplaceSelectionCommand::editingAction): ditto

khtml/khtml_part.h: added EditAction parameter to applyStyle and computeAndSetTypingStyle
khtml/khtml_part.cpp: (KHTMLPart::computeAndSetTypingStyle): added EditAction parameter (KHTMLPart::applyStyle): ditto

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::registerCommandForUndoOrRedo): do the cast from EditAction to WebUndoAction a different way to match other code

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge setTypingStyle:withUndoAction:]): added WebUndoAction parameter, passed into ApplyStyleCommand constructor (-[WebCoreBridge applyStyle:withUndoAction:]): ditto

WebCore.pbproj/project.pbxproj: updated for new files

WebKit:

Reviewed by Ken.

rest of WebKit fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

I only know of one loose end currently, which I wrote up as <rdar://problem/3920971> Edit menu
says "Undo Change Attributes" when it should say "Undo Set Color", from font panel

WebView.subproj/WebHTMLView.m: (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): use WebUndoActionSetColor when dragging color swatch (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): new WebUndoAction parameter, passed across bridge (-[WebHTMLView _toggleBold]): use WebUndoActionSetFont (-[WebHTMLView _toggleItalic]): use WebUndoActionSetFont (-[WebHTMLView pasteFont:]): use WebUndoActionPasteFont (-[WebHTMLView changeFont:]): use WebUndoActionSetFont (-[WebHTMLView changeAttributes:]): use WebUndoActionChangeAttributes (-[WebHTMLView _undoActionFromColorPanelWithSelector:]): new method, returns WebUndoActionSetBackgroundColor or WebUndoActionSetColor (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): now calls _undoActionFromColorPanelWithSelector (-[WebHTMLView changeColor:]): use WebUndoActionSetColor (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): new WebUndoAction parameter, passed through (-[WebHTMLView alignCenter:]): use WebUndoActionCenter (-[WebHTMLView alignJustified:]): use WebUndoActionJustify (-[WebHTMLView alignLeft:]): use WebUndoActionAlignLeft (-[WebHTMLView alignRight:]): use WebUndoActionAlignRight (-[WebHTMLView subscript:]): use WebUndoActionAlignSubscript (-[WebHTMLView superscript:]): use WebUndoActionAlignSuperscript (-[WebHTMLView unscript:]): use WebUndoActionAlignUnscript (-[WebHTMLView underline:]): use WebUndoActionAlignUnderline

WebView.subproj/WebView.m: (-[WebView setTypingStyle:]): pass WebUndoActionUnspecified through as new parameter since we don't have any more specific info (-[WebView applyStyle:]): ditto

Dec 14, 2004:

6:42 PM Changeset in webkit [8218] by hyatt

2 adds in trunk/LayoutTests/fast/table

Add layout test for large rowspans.

6:41 PM Changeset in webkit [8217] by hyatt

4 edits in trunk/WebCore

Fix for 3562458, rowspan and colspan converted to ints so that large values will work for them. Remove
the ridiculous 1024 limit on the span values.

khtml/html/html_tableimpl.cpp: (HTMLTableCellElementImpl::parseHTMLAttribute):
khtml/rendering/render_table.cpp: (RenderTableCell::collapsedBottomBorder):
khtml/rendering/render_table.h: (khtml::RenderTableCell::colSpan): (khtml::RenderTableCell::setColSpan): (khtml::RenderTableCell::rowSpan): (khtml::RenderTableCell::setRowSpan): (khtml::RenderTableCol::span): (khtml::RenderTableCol::setSpan):

6:27 PM Changeset in webkit [8216] by hyatt

3 edits in trunk/WebCore

Make sure <col> and <colgroup> can have spans updated dynamically as well.

Reviewed by rjw

khtml/html/html_tableimpl.cpp: (HTMLTableColElementImpl::parseHTMLAttribute):
khtml/rendering/render_table.cpp: (RenderTableCell::updateFromElement): (RenderTableCol::updateFromElement):

6:20 PM Changeset in webkit [8215] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_table.cpp

Fix crasher caused by lack of null style check.

6:09 PM Changeset in webkit [8214] by hyatt

3 edits
2 adds in trunk

Fix for 3833123, setting a cell's colspan does not update rendering like it should.

Reviewed by rjw

khtml/html/html_tableimpl.cpp: (HTMLTableCellElementImpl::parseHTMLAttribute):
khtml/rendering/render_table.cpp: (RenderTableCell::RenderTableCell): (RenderTableCell::updateFromElement):

6:00 PM Changeset in webkit [8213] by rjw

4 edits in trunk

WebKit:

Helper method to get URL of plugin view.

Reviewed by Chris.

Misc.subproj/WebNSViewExtras.m: (-[NSView _webViewURL]):

JavaScriptCore:

Pass URL of plugin view when call into JNI.

Reviewed by Chris.

bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):

5:53 PM Changeset in webkit [8212] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3864536> crash copying text from other apps and pasting in a sticky in dashboard

Reviewed by hyatt.

khtml/editing/markup.cpp: (khtml::createFragmentFromText): ref and deref the fragment since calling appendChild can completely deref it

5:13 PM Changeset in webkit [8211] by hyatt

2 edits
5 adds in trunk

Fix for 3785211. Make sure to do a layout with the old position before doing a layout after changing to the new position.
This is actually a regression from my positioned object DHTML optimization.

Reviewed by kocienda

khtml/rendering/render_object.cpp: (RenderObject::setStyle):

4:36 PM Changeset in webkit [8210] by hyatt

4 edits
2 adds in trunk

Make sure the class attribute works when newlines are present in the attribute.

Reviewed by kocienda

khtml/html/html_elementimpl.cpp: (HTMLNamedAttrMapImpl::parseClassAttribute):

2:34 PM Changeset in webkit [8209] by vicki

2 edits in trunk/WebKit

Reviewed by rjw.

<rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments

Plugins.subproj/WebPlugin.h: changed instances of "WebScriptMethods" to "WebScripting" in this file as well, as requested in the bug report

1:23 PM Changeset in webkit [8208] by mjs

2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/3912488> Mail throws an exception after backspacing "away" inline input

WebView.subproj/WebHTMLView.m: (-[WebHTMLView setMarkedText:selectedRange:]): Don't try to set a selection if we end up with no marked text, since that case fails and is unnecessary.

11:52 AM Changeset in webkit [8207] by sullivan

3 edits in trunk/WebCore

Reviewed by Ken.

added Undo action names for Cut, Paste, and Drag

khtml/editing/htmlediting.h:
khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::editingAction): overridden to return HTMLEditActionCut (khtml::MoveSelectionCommand::editingAction): overridden to return HTMLEditActionDrag (khtml::ReplaceSelectionCommand::editingAction): overridden to return HTMLEditActionPaste

11:17 AM Changeset in webkit [8206] by sullivan

8 edits in trunk

WebCore:

Reviewed by Ken.

architecture for WebCore part of fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

The remaining step is to make each EditCommand subclass override editingAction() to return an
appropriate value. (Unfortunately the mapping between subclass and user-distinguishable action
is not completely straightforward, so this next step isn't trivial.)

khtml/editing/htmlediting.h: new enum for HTMLEditAction

khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::editingAction): new method, calls through to EditCommand (khtml::EditCommand::editingAction): new method for subclasses to override, returns HTMLEditActionUnspecified at this level (khtml::TypingCommand::editingAction): proof of concept override, returns HTMLEditActionTyping

kwq/KWQKHTMLPart.h: declare new private bottleneck method registerCommandForUndoOrRedo
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::registerCommandForUndoOrRedo): new bottleneck method to reduce code duplication; now calls over the bridge to get the localized string to use for the Undo action name (KWQKHTMLPart::registerCommandForUndo): now calls new bottleneck method (KWQKHTMLPart::registerCommandForRedo): now calls new bottleneck method

kwq/WebCoreBridge.h: new enum for WebUndoAction, maps directly to HTMLEditAction. Declaration of nameForUndoAction:

WebKit:

Reviewed by Ken.

WebKit part of fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge nameForUndoAction:]): renamed from setUndoActionNamePlaceholder, replaced arbitrary integers with enum values, and handled new "unspecified" case as a fallback

9:26 AM Changeset in webkit [8205] by darin

2 edits in trunk/WebCore

Reviewed by John.

added a bunch of missing nil checks; our old version of inherits used to work for nil (by accident)

khtml/rendering/render_frames.cpp: (RenderPart::~RenderPart): Check widget for nil. (RenderPart::setWidget): Ditto. (RenderFrame::slotViewCleared): Ditto. (RenderPartObject::slotViewCleared): Ditto.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed