Timeline

Jan 3, 2005:

10:04 PM Changeset in webkit [8290] by hyatt

• 4 edits in trunk/WebCore

Fix for float painting regressions 3932524, 3931664, and 3933068. Make the noPaint flag setting more
robust and make it work regardless of which objects get a layout or not.

Reviewed by mjs

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::insertFloatingObject): (khtml::RenderBlock::addOverhangingFloats): (khtml::RenderBlock::addIntrudingFloats):
• khtml/rendering/render_block.h: (khtml::RenderBlock::FloatingObject::FloatingObject):

7:24 PM Changeset in webkit [8289] by mjs

• 2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/3935390> Tiger 8A341: nil deref crash in DOM::NodeImpl::traverseNextNode

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Assert that the starting point is not nil, it should not ever be (now). (HTMLCollectionImpl::item): When traversing items stop when we hit nil, meaning the end to avoid triggering above assert (formerly crash).

7:10 PM Changeset in webkit [8288] by mjs

• 2 edits in trunk/WebCore

Reviewed by John and Kevin.

<rdar://problem/3870317> REGRESSION(125.9-125.11) broken behavior at test.profoundlearning.com - used to

• khtml/ecma/kjs_window.cpp: (Window::get): Look up frame names before buitin window properties to match other browsers. This regressed because we added a builtin "toolbar" property but this site had a frame with that name.

5:44 PM Changeset in webkit [8287] by mjs

• 1 edit in trunk/WebCore/khtml/ecma/kjs_window.cpp

Back out accidentally committed change.

5:28 PM Changeset in webkit [8286] by mjs

• 11 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Added opener bridge method to help WebKit implement security check
for named frame visibility.

• khtml/khtml_part.h:
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge opener]):

WebKit:

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Implement a security check on name frame visbility. This is the
same rule as mozilla. You can only target frames by name if you
are in the same window, have the same domain as the frame or an
ancestor, or if it's a top level window have the same domain as
the opener.

• WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame _descendantFrameNamed:sourceFrame:]): (-[WebFrame findFrameNamed:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebView.m: (-[WebView _findFrameInThisWindowNamed:sourceFrame:]): (-[WebView _findFrameNamed:sourceFrame:]):
• WebView.subproj/WebViewPrivate.h:

2:08 PM Changeset in webkit [8285] by kocienda

• 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3933926> Tiger8A341: Mail crashes while forwarding embedded HTML message in -[WebCoreBridge ensureSelectionVisible]

• kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureSelectionVisible]): Put in some null checks to prevent crash experienced in bug.

1:43 PM Changeset in webkit [8284] by hyatt

• 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutPositionedObjects):

1:38 PM Changeset in webkit [8283] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3928250> REGRESSION (Mail): Typing style lost after hitting return key

• khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::preservesTypingStyle): Now implemented, returning yes for this command. (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Initialize new typing style member variable. (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Deref new typing style member variable. (khtml::InsertParagraphSeparatorCommand::preservesTypingStyle): Now implemented, returning yes for this command. (khtml::InsertParagraphSeparatorCommand::setFullTypingStyleBeforeInsertion): New function to set the typing style (khtml::InsertParagraphSeparatorCommand::calculateAndSetTypingStyleAfterInsertion): Function called after the <p> insertion is done. This function diffs the style created in setFullTypingStyleBeforeInsertion() with the style of the new <p> and only sets those styles needed to preserve the style in effect before the insertion. (khtml::InsertParagraphSeparatorCommand::doApply): Call new functions. (khtml::TypingCommand::preservesTypingStyle): Now yes for inserting line breaks and paragraphs.
  • khtml/editing/htmlediting.h: Declare new functions.

11:49 AM Changeset in webkit [8282] by kdecker

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fixed: <rdar://problem/3505072> hang in KHTMLParser::parseToken (consulting.soroos.net)

• khtml/html/dtd.cpp: <label> needed a much higher priority such that it will close block elements. Malformed HTML (ugh) is the only reason why we need to do this.