Timeline
Jan 5, 2005:
- 4:46 PM Changeset in webkit [8307] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Fix changelog
- 2:56 PM Changeset in webkit [8306] by
-
- 14 edits in trunk/WebCore
Reviewed by Ken.
- re-landing a subset of my custom tag change that does not fix the bug, but also does not introduce a performance regression
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): Changed some code that used ID_LAST_TAG in a slightly wrong, but harmless, way.
- khtml/editing/htmlediting.cpp: (khtml::debugPosition): Use nodeName rather than getTagName, since the latter works for per-document tags and is just better all around for things like the document. (khtml::debugNode): Ditto.
- khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Ditto.
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Ditto.
- khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
- khtml/html/dtd.cpp: (DOM::checkChild): Use ID_LAST_TAG rather than 1000 for the check that allows non-HTML elements to be nested as desired.
- khtml/misc/htmlhashes.h: Changed return types to unsigned short.
- khtml/misc/htmlhashes.cpp: (khtml::getTagID): Changed return type to unsigned short. (khtml::getAttrID): Ditto.
- khtml/xml/dom_docimpl.h: Added overload of createHTMLElement, made it non-virtual since it's not overriden.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement): Refactored into two separate functions, one that takes the tag ID. Also updated for a few tags that the parser handled but this did not.
- kwq/KWQRenderTreeDebug.cpp: (getTagName): Added. Works for custom nodes, because it calls nodeName rather than using getTagName on the tag ID directly, which only works for standard nodes. (operator<<): Update to call getTagName. (nodePositionRelativeToRoot): Ditto. (writeSelection): Ditto.
- 2:43 PM Changeset in webkit [8305] by
-
- 5 edits2 adds in trunk
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3941203> REGRESSION (Mail): Paste inserts content in wrong place
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Some cleanup and refinement of the concepts used to make this operation work correctly, particularly in the logic to figure out whether to merge content, and also performing merges.
- khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInBlock): Simplification of test used to make this determination.
- khtml/editing/visible_units.cpp: (khtml::isStartOfParagraph): New helper, used in khtml::ReplaceSelectionCommand::doApply(). (khtml::isEndOfParagraph): Ditto.
- khtml/editing/visible_units.h: Declare new functions.
- 1:08 PM Changeset in webkit [8304] by
-
- 3 edits in trunk
change all version numbers to 177+
- 12:50 PM Changeset in webkit [8303]
-
- 3 copies3 deletes in tags/WebKit-177~1
This commit was manufactured by cvs2svn to create tag 'WebKit-177~1'.
- 12:50 PM Changeset in webkit [8302] by
-
- 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj
versioning for today's WebKit dot submission, WebKit-177.1
- 11:01 AM Changeset in webkit [8301] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3936865> REGRESSION: canvas.drawImage no longer scales properly
Reviewed by john.
- WebCoreSupport.subproj/WebImageData.m: use the height of the inRect instead of the fromRect when setting the origin of the context
- 7:59 AM Changeset in webkit [8300] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3926522> Pressing return in a quoted block inserts too many newlines
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Call to insertBlockPlaceholderIfNeeded() for the block we are adding was being done at the wrong time, which led to the placeholder remaining in the document when it was not needed. This resulted in the extra space reported in the bug.
Jan 4, 2005:
- 3:25 PM Changeset in webkit [8299] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
Fixed: <rdar://problem/3936879> nil-deref, crash in InlineFlowBox::nodeAtPoint closing DHTML menus at hrweb.apple.com
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillInlineSelectionGaps): Added a nil check. If there is no selection, don't try to get the selection's containing block. If we do, we'll crash.
- 3:21 PM Changeset in webkit [8298] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3928329> WebKit should pass nil for "language" to checkSpellingOfString:
Reviewed by kocienda.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): pass nil not @"" for language
- 3:19 PM Changeset in webkit [8297] by
-
- 2 edits in trunk/WebCore
Fix for 3937203, force an update of the dashboard regions when scrollbars are added/removed.
Reviewed by kevin
- khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):
- 2:55 PM Changeset in webkit [8296] by
-
- 2 edits2 adds in trunk
Reviewed by John
Fix for these two bugs:
<rdar://problem/3938935> REGRESSION (Mail): Pasting into an empty document mangles content
<rdar://problem/3939148> REGRESSION (Mail): Pasting mistakenly reverses lines
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): For 3938935, add one more case to handle an empty document; merge neither start nor end. For 3939148, improve the code which adjusts the insertion point during the process of pasting. It formerly handled only one of the possible cases.
- layout-tests/editing/pasteboard/paste-text-015-expected.txt: Added.
- layout-tests/editing/pasteboard/paste-text-015.html: Added.
- 2:34 PM Changeset in webkit [8295] by
-
- 4 edits in trunk/WebCore
Fix for 3936571, placeholder attribute should work for normal inputs for Dashboard.
Reviewed by john
- khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement):
- kwq/KWQLineEdit.mm: (QLineEdit::setPlaceholderString):
- 12:08 PM Changeset in webkit [8294] by
-
- 3 edits in trunk/WebCore
Fix for 3830936, hang on changeforamerica.com. Make sure to ignore the style not yet available option when
returning pseudo-styles.
Reviewed by john
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::pseudoStyleForElement):
- khtml/rendering/render_style.cpp: (RenderStyle::addPseudoStyle):
- 11:12 AM Changeset in webkit [8293] by
-
- 20 edits in trunk/WebCore
- rolled out my custom tag name change again -- it caused a 1 ms PLT regression
- khtml/css/cssstyleselector.cpp:
- khtml/editing/htmlediting.cpp:
- khtml/editing/selection.cpp:
- khtml/editing/visible_position.cpp:
- khtml/html/dtd.cpp:
- khtml/html/htmlparser.cpp:
- khtml/html/htmlparser.h:
- khtml/html/htmltokenizer.cpp:
- khtml/misc/htmlhashes.cpp:
- khtml/misc/htmlhashes.h:
- khtml/misc/htmltags.c:
- khtml/misc/htmltags.h:
- khtml/misc/maketags:
- khtml/xml/dom_docimpl.cpp:
- khtml/xml/dom_docimpl.h:
- khtml/xml/dom_nodeimpl.cpp:
- khtml/xml/dom_position.cpp:
- kwq/KWQRenderTreeDebug.cpp:
- 10:35 AM Changeset in webkit [8292] by
-
- 3 edits2 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3927554> Style info applied to remainder of document after a newline is entered
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Clean up and simplification in code that inserts a paragraph separator. The bug was all about applying styles to the new paragraph that did not need to be applied. Now the code will detect when at the end of a style run and will not move and apply that ending style to the new paragraph, though it will place that style into the typing style. This seems to match NSText behavior.
- layout-tests/editing/inserting/insert-div-021-expected.txt: This test result exhibited the bug fixed here. The only reason it was not noticed is that the erroneously copied inline was a span, and so did not have any visible effect on the document.
- layout-tests/editing/inserting/insert-div-022-expected.txt: Added.
- layout-tests/editing/inserting/insert-div-022.html: Added.
- 10:11 AM Changeset in webkit [8291] by
-
- 2 edits in trunk/WebCore
Fix for 3904562, make sure to clear the outline dictionary when drawing so that random focus rings dont get drawn
all over the place.
Reviewed by john
- khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):
Jan 3, 2005:
- 10:04 PM Changeset in webkit [8290] by
-
- 4 edits in trunk/WebCore
Fix for float painting regressions 3932524, 3931664, and 3933068. Make the noPaint flag setting more
robust and make it work regardless of which objects get a layout or not.
Reviewed by mjs
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::insertFloatingObject): (khtml::RenderBlock::addOverhangingFloats): (khtml::RenderBlock::addIntrudingFloats):
- khtml/rendering/render_block.h: (khtml::RenderBlock::FloatingObject::FloatingObject):
- 7:24 PM Changeset in webkit [8289] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin.
<rdar://problem/3935390> Tiger 8A341: nil deref crash in DOM::NodeImpl::traverseNextNode
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Assert that the starting point is not nil, it should not ever be (now). (HTMLCollectionImpl::item): When traversing items stop when we hit nil, meaning the end to avoid triggering above assert (formerly crash).
- 7:10 PM Changeset in webkit [8288] by
-
- 2 edits in trunk/WebCore
Reviewed by John and Kevin.
<rdar://problem/3870317> REGRESSION(125.9-125.11) broken behavior at test.profoundlearning.com - used to
- khtml/ecma/kjs_window.cpp: (Window::get): Look up frame names before buitin window properties to match other browsers. This regressed because we added a builtin "toolbar" property but this site had a frame with that name.
- 5:44 PM Changeset in webkit [8287] by
-
- 1 edit in trunk/WebCore/khtml/ecma/kjs_window.cpp
Back out accidentally committed change.
- 5:28 PM Changeset in webkit [8286] by
-
- 11 edits in trunk
WebCore:
Reviewed by Darin.
<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another
Added opener bridge method to help WebKit implement security check
for named frame visibility.
- khtml/khtml_part.h:
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge opener]):
WebKit:
Reviewed by Darin.
<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another
Implement a security check on name frame visbility. This is the
same rule as mozilla. You can only target frames by name if you
are in the same window, have the same domain as the frame or an
ancestor, or if it's a top level window have the same domain as
the opener.
- WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame _descendantFrameNamed:sourceFrame:]): (-[WebFrame findFrameNamed:]):
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebView.m: (-[WebView _findFrameInThisWindowNamed:sourceFrame:]): (-[WebView _findFrameNamed:sourceFrame:]):
- WebView.subproj/WebViewPrivate.h:
- 2:08 PM Changeset in webkit [8285] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3933926> Tiger8A341: Mail crashes while forwarding embedded HTML message in -[WebCoreBridge ensureSelectionVisible]
- kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureSelectionVisible]): Put in some null checks to prevent crash experienced in bug.
- 1:43 PM Changeset in webkit [8284] by
-
- 2 edits in trunk/WebCore
Reviewed by NOBODY (OOPS!).
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutPositionedObjects):
- 1:38 PM Changeset in webkit [8283] by
-
- 3 edits in trunk/WebCore
Reviewed by Harrison
Fix for this bug:
<rdar://problem/3928250> REGRESSION (Mail): Typing style lost after hitting return key
- khtml/editing/htmlediting.cpp:
(khtml::InsertLineBreakCommand::preservesTypingStyle): Now implemented, returning yes for this command.
(khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Initialize new typing style member variable.
(khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Deref new typing style member variable.
(khtml::InsertParagraphSeparatorCommand::preservesTypingStyle): Now implemented, returning yes for this command.
(khtml::InsertParagraphSeparatorCommand::setFullTypingStyleBeforeInsertion): New function to set the typing style
(khtml::InsertParagraphSeparatorCommand::calculateAndSetTypingStyleAfterInsertion): Function called after the <p>
insertion is done. This function diffs the style created in setFullTypingStyleBeforeInsertion() with the style
of the new <p> and only sets those styles needed to preserve the style in effect before the insertion.
(khtml::InsertParagraphSeparatorCommand::doApply): Call new functions.
(khtml::TypingCommand::preservesTypingStyle): Now yes for inserting line breaks and paragraphs.
- khtml/editing/htmlediting.h: Declare new functions.
- 11:49 AM Changeset in webkit [8282] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
Fixed: <rdar://problem/3505072> hang in KHTMLParser::parseToken (consulting.soroos.net)
- khtml/html/dtd.cpp: <label> needed a much higher priority such that it will close block elements. Malformed HTML (ugh) is the only reason why we need to do this.
