Timeline



Jan 7, 2005:

4:17 PM Changeset in webkit [8321] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3942619> AX: Support sentence ax attributes

Needed to use the unicode utilities properly. Twas lame before.

  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary): (khtml::startOfWord): (khtml::endOfWord): (khtml::previousWordPosition): (khtml::nextWordPosition): (khtml::startOfSentence): (khtml::endOfSentence): (khtml::previousSentencePosition): (khtml::nextSentencePosition):
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
  • kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): (KWQFindSentenceBoundary): (KWQFindNextSentenceFromIndex):
2:42 PM Changeset in webkit [8320] by kocienda
  • 2 edits
    4 adds in trunk

Reviewed by Kevin

Fix for these bugs:

<rdar://problem/3939523> in some cases, text does not retain style info after pressing return twice
<rdar://problem/3944492> after pressing return twice, text is bold when it shouldn't be

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::setFullTypingStyleBeforeInsertion): Merge the typing style with the computed style for the current position. Fixes both bugs.
  • khtml/editing/htmlediting.h:
  • layout-tests/editing/inserting/insert-div-023-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-023.html: Added.
  • layout-tests/editing/inserting/insert-div-024-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-024.html: Added.
12:38 PM Changeset in webkit [8319] by hyatt
  • 5 edits in trunk/LayoutTests/fast

Fix the layout tests.

12:22 PM Changeset in webkit [8318] by hyatt
  • 7 edits in trunk/WebCore

Fix for 3941364, make sure tables reset overflowWidth/Height when they lay out again. Fixes the odd scrolling
behavior on worldofwarcraft.com.

Reviewed by kevin

  • ChangeLog:
  • khtml/rendering/render_table.cpp: (RenderTable::layout):
12:13 PM Changeset in webkit [8317] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3848412> for forwarded message, tabbing to message view scrolls to bottom of view

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Don't scroll the focus node to visible if it is not in the document, or if it is not a descendent of the document element. In the case of the bug, since the selection has not yet been set up, the focus node passed here is the HTML element, and that does not yield a rect that is useful to us here. So now, in the case the bug mentions, we do nothing.

Jan 6, 2005:

6:30 PM Changeset in webkit [8316] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by mjs.

Fixed: <rdar://problem/3932215> REGRESSION (125-177): iFrame example at developer.apple.com fails in Safari

  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): m_bComplete was never true for frames generated by Javascript due to our synchronous loading and as a result, scheduled redirects wouldn't fire in KHTMLPart::scheduleLocationChange(). By virtue of being an empty document, a document is complete. In this special case it's safe at this point to call checkCompleted() which sets m_bComplete true.
4:35 PM Changeset in webkit [8315] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (178+)

4:27 PM Changeset in webkit [8314]
  • 1 copy in tags/Safari-178

This commit was manufactured by cvs2svn to create tag 'Safari-178'.

4:27 PM Changeset in webkit [8313] by vicki
  • 6 edits in trunk

Safari-178 stamp

1:56 PM Changeset in webkit [8312] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Chris.

(addendum to previous checkin for this bug)
<rdar://problem/3776056> AX: Editable HTML should not be viewed as AXStaticText

Fix line navigation. Add AXUIElementForTextMarker.

  • ChangeLog:
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject doAXUIElementForTextMarker:]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): (-[KWQAccObject accessibilityAttributeValue:forParameter:]):
1:13 PM Changeset in webkit [8311] by darin
  • 7 edits in trunk/WebCore

Reviewed by Ken.

  • re-fixed <rdar://problem/3760910> Request to include support for custom tag names in HTML (they already work in XML)

(turns out the PLT regression was a false alarm)

  • khtml/html/htmlparser.h: Change forbidden tag array to be allocated in the object rather than on the heap. Also use ID_LAST_TAG for the array size; the old code used ID_CLOSE_TAG which is now a much larger number.
  • khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Remove code that creates the forbidden tag array on the heap; makes more sense to just have the array be a member so we don't have to use new and delete on it. Also needed to eliminate code that used ID_CLOSE_TAG for an array size. (KHTMLParser::~KHTMLParser): Remove code that deletes the forbidden tag array. Also changed the code that manages isindex to use deref instead of delete. (KHTMLParser::reset): Use safer sizeof for clearing the forbidden tag array. Old code had the mistake of using ID_CLOSE_TAG for the array size too. (KHTMLParser::parseToken): Removed code that checks for bogus tags; it's not clear why it was ever there and it would prevent custom tags from working. Added range check before using the forbidden tag array with the token ID since custom tags will use index values past the end of the array. (KHTMLParser::getElement): Removed most of the code that makes an element by ID; now the work is done inside the DocumentImpl createHTMLElement. Any code that needs to be different than a dynamic createElement call is still here. Last time I left out a few form element types from this switch; fixed now.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): Call the tagId function in the document if getTagID fails; this creates a unique per-document ID.
  • khtml/misc/htmltags.c: Regenerated.
  • khtml/misc/htmltags.h: Regenerated.
  • khtml/misc/maketags: Changed the generated constants to use "const unsigned short" instead of "#define". Changed ID_CLOSE_TAG to be a fixed value of 32000 rather than being just past the IDs of the HTML tags. Also rewrote getTagName to work with the new scheme.
11:04 AM Changeset in webkit [8310] by harrison
  • 2 edits in trunk/WebCore

Fixed Panther build. Also, do not advertize sentence support since it is incomplete.

  • kwq/KWQAccObject.mm: (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject accessibilityIsAttributeSettable:]):
10:20 AM Changeset in webkit [8309] by harrison
  • 17 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/3776056> AX: Editable HTML should not be viewed as AXStaticText
<rdar://problem/3588548> AX: tabbing does not work correctly with the screen reader and a focused link; need AXFocusedUIElement to work

Many more AX attributes supported. Numerous fixes to previous AX work.

  • khtml/editing/visible_units.cpp: (khtml::startSentenceBoundary): (khtml::startOfSentence): (khtml::endSentenceBoundary): (khtml::endOfSentence): (khtml::previousSentencePositionBoundary): (khtml::previousSentencePosition): (khtml::nextSentencePositionBoundary): (khtml::nextSentencePosition):
  • khtml/editing/visible_units.h:
  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/misc/helper.cpp: (khtml::findSentenceBoundary): (khtml::nextSentenceFromIndex):
  • khtml/misc/helper.h:
  • khtml/misc/htmltags.c: (hash_tag): (findTag):
  • khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_object.cpp: (RenderObject::remove):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::getAccObjectCache): (DocumentImpl::updateSelection): (DocumentImpl::close): (DocumentImpl::setFocusNode): (DocumentImpl::parentDocument): (DocumentImpl::topDocument):
  • khtml/xml/dom_docimpl.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityShouldUseUniqueId]): (-[KWQAccObject detach]): (-[KWQAccObject anchorElement]): (-[KWQAccObject firstChild]): (-[KWQAccObject lastChild]): (-[KWQAccObject previousSibling]): (-[KWQAccObject nextSibling]): (-[KWQAccObject parentObject]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject textMarkerForVisiblePosition:]): (-[KWQAccObject visiblePositionForTextMarker:]): (-[KWQAccObject textMarkerRangeFromVisiblePositions:andEndPos:]): (-[KWQAccObject topDocument]): (-[KWQAccObject topRenderer]): (-[KWQAccObject topView]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXStringForTextMarkerRange:]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject doAXBoundsForTextMarkerRange:]): (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]): (-[KWQAccObject doAXTextMarkerRangeForUnorderedTextMarkers:]): (-[KWQAccObject doAXNextTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousTextMarkerForTextMarker:]): (-[KWQAccObject doAXLeftWordTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightWordTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXSentenceTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXParagraphTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXLengthForTextMarkerRange:]): (-[KWQAccObject accessibilityAttributeValue:forParameter:]): (-[KWQAccObject accessibilityHitTest:]): (-[KWQAccObject accessibilityFocusedUIElement]): (-[KWQAccObject accessibilityIsAttributeSettable:]): (-[KWQAccObject doSetAXSelectedTextMarkerRange:]): (-[KWQAccObject setAccObjectID:]): (-[KWQAccObject removeAccObjectID]):
  • kwq/KWQAccObjectCache.h:
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::visiblePositionForTextMarker): (KWQAccObjectCache::postNotificationToTopWebArea): (KWQAccObjectCache::postNotification): (KWQAccObjectCache::handleFocusedUIElementChanged):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedContents):
  • kwq/KWQTextUtilities.h:
  • kwq/KWQTextUtilities.mm: (KWQFindNextWordFromIndex): (KWQFindSentenceBoundary): (KWQFindNextSentenceFromIndex):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge accessibilityTree]):
10:19 AM Changeset in webkit [8308] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Dave Hyatt

<rdar://problem/3588548> AX: tabbing does not work correctly with the screen reader and a focused link; need AXFocusedUIElement to work.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView accessibilityFocusedUIElement]): Implement this so that AppKit can use it from NSAccessibilityHandleFocusChanged.

Jan 5, 2005:

4:46 PM Changeset in webkit [8307] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix changelog

2:56 PM Changeset in webkit [8306] by darin
  • 14 edits in trunk/WebCore

Reviewed by Ken.

  • re-landing a subset of my custom tag change that does not fix the bug, but also does not introduce a performance regression
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector): Changed some code that used ID_LAST_TAG in a slightly wrong, but harmless, way.
  • khtml/editing/htmlediting.cpp: (khtml::debugPosition): Use nodeName rather than getTagName, since the latter works for per-document tags and is just better all around for things like the document. (khtml::debugNode): Ditto.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Ditto.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
  • khtml/html/dtd.cpp: (DOM::checkChild): Use ID_LAST_TAG rather than 1000 for the check that allows non-HTML elements to be nested as desired.
  • khtml/misc/htmlhashes.h: Changed return types to unsigned short.
  • khtml/misc/htmlhashes.cpp: (khtml::getTagID): Changed return type to unsigned short. (khtml::getAttrID): Ditto.
  • khtml/xml/dom_docimpl.h: Added overload of createHTMLElement, made it non-virtual since it's not overriden.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement): Refactored into two separate functions, one that takes the tag ID. Also updated for a few tags that the parser handled but this did not.
  • kwq/KWQRenderTreeDebug.cpp: (getTagName): Added. Works for custom nodes, because it calls nodeName rather than using getTagName on the tag ID directly, which only works for standard nodes. (operator<<): Update to call getTagName. (nodePositionRelativeToRoot): Ditto. (writeSelection): Ditto.
2:43 PM Changeset in webkit [8305] by kocienda
  • 5 edits
    2 adds in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3941203> REGRESSION (Mail): Paste inserts content in wrong place

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Some cleanup and refinement of the concepts used to make this operation work correctly, particularly in the logic to figure out whether to merge content, and also performing merges.
  • khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInBlock): Simplification of test used to make this determination.
  • khtml/editing/visible_units.cpp: (khtml::isStartOfParagraph): New helper, used in khtml::ReplaceSelectionCommand::doApply(). (khtml::isEndOfParagraph): Ditto.
  • khtml/editing/visible_units.h: Declare new functions.
1:08 PM Changeset in webkit [8304] by vicki
  • 3 edits in trunk

change all version numbers to 177+

12:50 PM Changeset in webkit [8303]
  • 3 copies
    3 deletes in tags/WebKit-177~1

This commit was manufactured by cvs2svn to create tag 'WebKit-177~1'.

12:50 PM Changeset in webkit [8302] by vicki
  • 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

versioning for today's WebKit dot submission, WebKit-177.1

11:01 AM Changeset in webkit [8301] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3936865> REGRESSION: canvas.drawImage no longer scales properly

Reviewed by john.

  • WebCoreSupport.subproj/WebImageData.m: use the height of the inRect instead of the fromRect when setting the origin of the context
7:59 AM Changeset in webkit [8300] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3926522> Pressing return in a quoted block inserts too many newlines

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Call to insertBlockPlaceholderIfNeeded() for the block we are adding was being done at the wrong time, which led to the placeholder remaining in the document when it was not needed. This resulted in the extra space reported in the bug.

Jan 4, 2005:

3:25 PM Changeset in webkit [8299] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fixed: <rdar://problem/3936879> nil-deref, crash in InlineFlowBox::nodeAtPoint closing DHTML menus at hrweb.apple.com

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillInlineSelectionGaps): Added a nil check. If there is no selection, don't try to get the selection's containing block. If we do, we'll crash.
3:21 PM Changeset in webkit [8298] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3928329> WebKit should pass nil for "language" to checkSpellingOfString:

Reviewed by kocienda.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): pass nil not @"" for language
3:19 PM Changeset in webkit [8297] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3937203, force an update of the dashboard regions when scrollbars are added/removed.

Reviewed by kevin

  • khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):
2:55 PM Changeset in webkit [8296] by kocienda
  • 2 edits
    2 adds in trunk

Reviewed by John

Fix for these two bugs:

<rdar://problem/3938935> REGRESSION (Mail): Pasting into an empty document mangles content
<rdar://problem/3939148> REGRESSION (Mail): Pasting mistakenly reverses lines

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): For 3938935, add one more case to handle an empty document; merge neither start nor end. For 3939148, improve the code which adjusts the insertion point during the process of pasting. It formerly handled only one of the possible cases.
  • layout-tests/editing/pasteboard/paste-text-015-expected.txt: Added.
  • layout-tests/editing/pasteboard/paste-text-015.html: Added.
2:34 PM Changeset in webkit [8295] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3936571, placeholder attribute should work for normal inputs for Dashboard.

Reviewed by john

  • khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement):
  • kwq/KWQLineEdit.mm: (QLineEdit::setPlaceholderString):
12:08 PM Changeset in webkit [8294] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3830936, hang on changeforamerica.com. Make sure to ignore the style not yet available option when
returning pseudo-styles.

Reviewed by john

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::pseudoStyleForElement):
  • khtml/rendering/render_style.cpp: (RenderStyle::addPseudoStyle):
11:12 AM Changeset in webkit [8293] by darin
  • 20 edits in trunk/WebCore
  • rolled out my custom tag name change again -- it caused a 1 ms PLT regression
  • khtml/css/cssstyleselector.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/selection.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/html/dtd.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/htmlhashes.cpp:
  • khtml/misc/htmlhashes.h:
  • khtml/misc/htmltags.c:
  • khtml/misc/htmltags.h:
  • khtml/misc/maketags:
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_position.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
10:35 AM Changeset in webkit [8292] by kocienda
  • 3 edits
    2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3927554> Style info applied to remainder of document after a newline is entered

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Clean up and simplification in code that inserts a paragraph separator. The bug was all about applying styles to the new paragraph that did not need to be applied. Now the code will detect when at the end of a style run and will not move and apply that ending style to the new paragraph, though it will place that style into the typing style. This seems to match NSText behavior.
  • layout-tests/editing/inserting/insert-div-021-expected.txt: This test result exhibited the bug fixed here. The only reason it was not noticed is that the erroneously copied inline was a span, and so did not have any visible effect on the document.
  • layout-tests/editing/inserting/insert-div-022-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-022.html: Added.
10:11 AM Changeset in webkit [8291] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3904562, make sure to clear the outline dictionary when drawing so that random focus rings dont get drawn
all over the place.

Reviewed by john

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):

Jan 3, 2005:

10:04 PM Changeset in webkit [8290] by hyatt
  • 4 edits in trunk/WebCore

Fix for float painting regressions 3932524, 3931664, and 3933068. Make the noPaint flag setting more
robust and make it work regardless of which objects get a layout or not.

Reviewed by mjs

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::insertFloatingObject): (khtml::RenderBlock::addOverhangingFloats): (khtml::RenderBlock::addIntrudingFloats):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::FloatingObject::FloatingObject):
7:24 PM Changeset in webkit [8289] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/3935390> Tiger 8A341: nil deref crash in DOM::NodeImpl::traverseNextNode

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem): Assert that the starting point is not nil, it should not ever be (now). (HTMLCollectionImpl::item): When traversing items stop when we hit nil, meaning the end to avoid triggering above assert (formerly crash).
7:10 PM Changeset in webkit [8288] by mjs
  • 2 edits in trunk/WebCore

Reviewed by John and Kevin.

<rdar://problem/3870317> REGRESSION(125.9-125.11) broken behavior at test.profoundlearning.com - used to

  • khtml/ecma/kjs_window.cpp: (Window::get): Look up frame names before buitin window properties to match other browsers. This regressed because we added a builtin "toolbar" property but this site had a frame with that name.
5:44 PM Changeset in webkit [8287] by mjs
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_window.cpp

Back out accidentally committed change.

5:28 PM Changeset in webkit [8286] by mjs
  • 11 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Added opener bridge method to help WebKit implement security check
for named frame visibility.

  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge opener]):

WebKit:

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Implement a security check on name frame visbility. This is the
same rule as mozilla. You can only target frames by name if you
are in the same window, have the same domain as the frame or an
ancestor, or if it's a top level window have the same domain as
the opener.

  • WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame _descendantFrameNamed:sourceFrame:]): (-[WebFrame findFrameNamed:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _findFrameInThisWindowNamed:sourceFrame:]): (-[WebView _findFrameNamed:sourceFrame:]):
  • WebView.subproj/WebViewPrivate.h:
2:08 PM Changeset in webkit [8285] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3933926> Tiger8A341: Mail crashes while forwarding embedded HTML message in -[WebCoreBridge ensureSelectionVisible]

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureSelectionVisible]): Put in some null checks to prevent crash experienced in bug.
1:43 PM Changeset in webkit [8284] by hyatt
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutPositionedObjects):
1:38 PM Changeset in webkit [8283] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3928250> REGRESSION (Mail): Typing style lost after hitting return key

  • khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::preservesTypingStyle): Now implemented, returning yes for this command. (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Initialize new typing style member variable. (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Deref new typing style member variable. (khtml::InsertParagraphSeparatorCommand::preservesTypingStyle): Now implemented, returning yes for this command. (khtml::InsertParagraphSeparatorCommand::setFullTypingStyleBeforeInsertion): New function to set the typing style (khtml::InsertParagraphSeparatorCommand::calculateAndSetTypingStyleAfterInsertion): Function called after the <p> insertion is done. This function diffs the style created in setFullTypingStyleBeforeInsertion() with the style of the new <p> and only sets those styles needed to preserve the style in effect before the insertion. (khtml::InsertParagraphSeparatorCommand::doApply): Call new functions. (khtml::TypingCommand::preservesTypingStyle): Now yes for inserting line breaks and paragraphs.
    • khtml/editing/htmlediting.h: Declare new functions.
11:49 AM Changeset in webkit [8282] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fixed: <rdar://problem/3505072> hang in KHTMLParser::parseToken (consulting.soroos.net)

  • khtml/html/dtd.cpp: <label> needed a much higher priority such that it will close block elements. Malformed HTML (ugh) is the only reason why we need to do this.
Note: See TracTimeline for information about the timeline view.