Timeline
Jan 17, 2005:
- 5:44 PM Changeset in webkit [8394] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
<rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line
<rdar://problem/3949848> AX: paragraph marker routines do not work when given a paragraph end marker
Also fixed sentence support in the same way.
- kwq/KWQAccObject.mm: (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): Move one position in desired direction before calling visible_units.cpp code.
- 5:33 PM Changeset in webkit [8393] by
-
- 8 edits in trunk
Updated expected test results.
<rdar://problem/3945880> line-ending space seems not to be present
- layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt:
- layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt:
- layout-tests/editing/inserting/insert-div-020-expected.txt:
- layout-tests/editing/inserting/insert-div-021-expected.txt:
- layout-tests/editing/inserting/insert-div-022-expected.txt:
- layout-tests/editing/inserting/insert-div-023-expected.txt:
- layout-tests/editing/inserting/insert-div-024-expected.txt:
- 5:07 PM Changeset in webkit [8392] by
-
- 4 edits in trunk/WebCore
Reviewed by Dave Hyatt (bidi.cpp) and Darin Adler (selection.cpp).
<rdar://problem/3945880> line-ending space seems not to be present
- khtml/editing/selection.cpp: (khtml::Selection::validate): Extend AFTER_WHITE_SPACE code to support white spac in the middle of paragraphs, not just the end.
- khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Pick left/rightness of word selection based on being at the end of paragraph (i.e. after a hard line break).
- 5:06 PM Changeset in webkit [8391] by
-
- 2 edits in trunk/WebKit
- DOM.subproj/DOMPrivate.h: Check in generated file.
- 4:43 PM Changeset in webkit [8390] by
-
- 5 edits in trunk/WebCore
Reviewed by John Louch.
- fixed <rdar://problem/3958503> need screenX and screenY to use WebKit windowFrame delegate
- khtml/ecma/kjs_window.cpp: (Window::get): Change screenX and screenY to use frameGeometry instead of using mapToGlobal and screen in a complicated way.
- kwq/KWQKHTMLView.mm: Removed unused mapToGlobal function.
- kwq/KWQWindowWidget.h: Ditto.
- kwq/KWQWindowWidget.mm: Ditto.
- 3:30 PM Changeset in webkit [8389] by
-
- 2 adds in trunk/LayoutTests/fast/block/float
Add layout test for overflow float bug.
- 3:27 PM Changeset in webkit [8388] by
-
- 2 edits in trunk/WebCore
Fix a screwup in rightmost/lowets position computation. 3955207. Make sure floats with layers are still checked.
Reviewed by kocienda
- khtml/rendering/render_block.cpp
- 3:23 PM Changeset in webkit [8387] by
-
- 7 edits1 add in trunk/WebKit
Reviewed by John and Richard.
- fixed <rdar://problem/3907453> printing a multi-page PDF document from Safari doesn't produce correct output
- WebView.subproj/WebFrameViewPrivate.h: Added.
- WebView.subproj/WebFrameView.m: (-[WebFrameView canPrintHeadersAndFooters]): Added. Returnes NO for documents that can't print headers or footers, and delegates to the document view to answer the question. Defaults to NO, since only a view that actively does the work is compatible with our header and footer code. (-[WebFrameView printOperationWithPrintInfo:]): Added. Returns an NSPrintOperation set up for printing. The reason we return this rather than an NSView is that in the PDFView case, the print info is changed around before creating the NSPrintOperation, and also the PDFKit SPI works this way.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView canPrintHeadersAndFooters]): Added. Returns YES.
- WebView.subproj/WebImageView.m: (-[WebImageView canPrintHeadersAndFooters]): Ditto.
- WebView.subproj/WebTextView.m: (-[WebTextView canPrintHeadersAndFooters]): Ditto.
- WebView.subproj/WebPDFView.m: (-[WebPDFView canPrintHeadersAndFooters]): Added. Returns NO. (-[WebPDFView printOperationWithPrintInfo:]): Added. Calls getPrintOperationForPrintInfo: autoRotate:YES on the PDFView.
- WebKit.pbproj/project.pbxproj: Added WebFrameViewPrivate.h as a new private header.
- 3:08 PM Changeset in webkit [8386] by
-
- 1 edit in trunk/WebCore/khtml/ecma/kjs_binding.cpp
Fixed build snafu.
- 2:54 PM Changeset in webkit [8385] by
-
- 2 edits in trunk/WebCore
Reviewed by John
<rdar://problem/3953366> Problems with typing attributes in HTML compose
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Remove misguided "optimization" that tried to sense when typing style could be cleared without actually doing a style diff between before-delete and after-delete positions. Removing this extra check and running the general-purpose code fixes the bug.
- 2:41 PM Changeset in webkit [8384] by
-
- 26 edits in trunk
WebCore:
Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)
Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.
Reviewed by David Harrison.
- khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::isGlobalObject): (ScriptInterpreter::isSafeScript): (ScriptInterpreter::interpreterForGlobalObject):
- khtml/ecma/kjs_binding.h:
- khtml/ecma/kjs_window.cpp: (Window::interpreter): (Window::isSafeScript):
- khtml/ecma/kjs_window.h:
- kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::windowScriptNPObject):
- kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)
Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.
Reviewed by David Harrison.
- bindings/NP_jsobject.cpp: (_isSafeScript): (_NPN_CreateScriptObject): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException):
- bindings/NP_jsobject.h:
- bindings/c/c_instance.cpp: (CInstance::CInstance): (CInstance::stringValue):
- bindings/c/c_instance.h:
- bindings/c/c_utility.cpp: (convertValueToNPVariant):
- bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::valueOf):
- bindings/jni/jni_instance.h:
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject _initializeWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): (-[WebScriptObject _initWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): (-[WebScriptObject KJS::Bindings::]): (-[WebScriptObject _setOriginExecutionContext:KJS::Bindings::]): (-[WebScriptObject _isSafeScript]): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
- bindings/objc/WebScriptObjectPrivate.h:
- bindings/objc/objc_instance.h:
- bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
- bindings/runtime.cpp: (Instance::Instance): (Instance::operator=):
- bindings/runtime.h: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::setExecutionContext): (KJS::Bindings::Instance::executionContext):
- bindings/runtime_root.cpp: (RootObject::setInterpreter):
- bindings/runtime_root.h:
- kjs/interpreter.h: (KJS::Interpreter::isGlobalObject): (KJS::Interpreter::interpreterForGlobalObject): (KJS::Interpreter::isSafeScript):
- 2:20 PM Changeset in webkit [8383] by
-
- 1 edit in trunk/WebCore/khtml/editing/htmlediting.cpp
Roll out unintended work-in-progress change
- 2:18 PM Changeset in webkit [8382] by
-
- 11 edits8 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with
"size up" and "size down" NSFontManager changes
- khtml/css/cssparser.cpp: (CSSParser::parseValue): Add support for parsing new font size delta property.
- khtml/css/cssproperties.c: Generated file.
- khtml/css/cssproperties.h: Ditto.
- khtml/css/cssproperties.in: Add support for parsing new font size delta property.
- khtml/editing/htmlediting.cpp: (khtml::isEmptyStyleSpan): New helper function. Code existed before, but now factored out for convenient use. (khtml::CompositeEditCommand::removeNodeAttribute): Does check on value to see it exists before creating and running command to do the removal. (khtml::ApplyStyleCommand::doApply): Now calls new applyRelativeFontStyleChange() function as part of its work. (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): New function that does the "heavy lifting" to handle relative font size changes. (khtml::ApplyStyleCommand::applyInlineStyle): Range check the start and end positions to make sure the start is before or equal to the end. Swap them if not true. I ran into this problem in some similar code in applyRelativeFontStyleChange(). Moving that goodness here too. (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): Uses a local variable to save a value used often. Code is the same, but reads better now. Function now returns bool as well, just like splitTextAtStartIfNeeded. I use the bool return value now (I obviously did not need it before). (khtml::ApplyStyleCommand::computedFontSize): New helper function. (khtml::ApplyStyleCommand::joinChildTextNodes): Ditto. (khtml::createStyleSpanElement): Ditto.
- khtml/editing/htmlediting.h: Update header accordingly.
- khtml/editing/jsediting.cpp: Add new command string to enable relative font size changes.
- kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration _fontSizeDelta]): New convenience. (-[DOMCSSStyleDeclaration _setFontSizeDelta:]): Ditto.
- kwq/DOMPrivate.h: Declare new conveniences.
- layout-tests/editing/editing.js: Add new JS to enable relative font size changes, as well as explicit font size setting.
- layout-tests/editing/style/relative-font-size-change-001-expected.txt: Added.
- layout-tests/editing/style/relative-font-size-change-001.html: Added.
- layout-tests/editing/style/relative-font-size-change-002-expected.txt: Added.
- layout-tests/editing/style/relative-font-size-change-002.html: Added.
- layout-tests/editing/style/relative-font-size-change-003-expected.txt: Added.
- layout-tests/editing/style/relative-font-size-change-003.html: Added.
- layout-tests/editing/style/relative-font-size-change-004-expected.txt: Added.
- layout-tests/editing/style/relative-font-size-change-004.html: Added.
Jan 14, 2005:
- 3:55 PM Changeset in webkit [8381] by
-
- 5 edits in trunk/WebCore
- khtml/css/cssproperties.c: Regenerated with gperf 3.0.1.
- khtml/css/cssvalues.c: Regenerated with gperf 3.0.1.
- khtml/misc/htmlattrs.c: Regenerated with gperf 3.0.1.
- khtml/misc/htmltags.c: Regenerated with gperf 3.0.1.
- 12:09 PM Changeset in webkit [8380] by
-
- 5 edits in trunk/WebCore
Fixed: <rdar://problem/3886415> arrow keys don't work when the user hits Back to return to RSS page
Reviewed by hyatt.
(KWQKHTMLPart::openURLFromPageCache): restore mousePressNode
(KWQKHTMLPart::mousePressNode): new
- kwq/KWQPageState.h:
- kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): save the mousePressNode (-[KWQPageState clear]): clear the mousePressNode (-[KWQPageState dealloc]): deref the mousePressNode (-[KWQPageState mousePressNode]): new
Jan 13, 2005:
- 6:14 PM Changeset in webkit [8379]
-
- 25 copies2 deletes in tags/WebKit-85~8~5
This commit was manufactured by cvs2svn to create tag
'WebKit-85~8~5'.
- 6:14 PM Changeset in webkit [8378] by
-
- 2 edits in branches/Safari-1-0-branch/WebKit
fixed mismatched_CFBundleShortVersionStrings verification failure by correcting
version string to 1.0.3
- 5:40 PM Changeset in webkit [8377] by
-
- 2 edits in branches/Safari-1-0-branch/WebKit
- bump WebKit version number to 85.8.5; the tag "WebKit-85~8~3" is already taken, and
version numbers with a "4" are not allowed because of Netscape 4 compatibility
- 5:30 PM Changeset in webkit [8376] by
-
- 2 edits in branches/Safari-1-0-branch/WebKit
versioning for January 2005 Security Update, WebKit-85.8.3
- 5:24 PM Changeset in webkit [8375]
-
- 23 copies2 deletes in tags/WebCore-85~6~6
This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~6'.
- 5:24 PM Changeset in webkit [8374] by
-
- 3 edits in branches/Safari-1-0-branch/WebCore
versioning for January 2005 Security Update, WebCore-85.6.6
- 5:01 PM Changeset in webkit [8373] by
-
- 6 edits in trunk/WebKit
Fixed: <rdar://problem/3932107> Safari does not load QT Cocoa plug-in if the WebPluginMIMETypes key is not in the info.plist
Fixing this bug required that we allow WebKit plug-ins (as well as Netscape plug-ins) support BP_CreatePluginMIMETypesPreferences
which allows plug-ins create an auxiliary MIME types file.
Reviewed by adele.
- Plugins.subproj/WebBasePluginPackage.h:
- Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage preferredLocalizationName]): moved from WebNetscapePluginPackage (-[WebBasePluginPackage pListForPath:createFile:]): ditto (-[WebBasePluginPackage getPluginInfoFromPLists]): ditto (-[WebBasePluginPackage isLoaded]): return isLoaded ivar (-[WebBasePluginPackage load]): if loaded, get BP_CreatePluginMIMETypesPreferences symbol
- Plugins.subproj/WebNetscapePluginPackage.h:
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
- Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): call getPluginInfoFromPLists (-[WebPluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
- 4:29 PM Changeset in webkit [8372] by
-
- 12 edits in branches/Safari-1-0-branch
WebCore:
<rdar://problem/3939323> frame naming allows malicious site to bring up a window when you click on a link in another
<rdar://problem/3939484> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs
<rdar://problem/3943552> WebKit needs to restrict access to certain window operations by domain
merged these fixes from Tiger:
2004-12-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another
Added opener bridge method to help WebKit implement security check
for named frame visibility.
- khtml/khtml_part.h:
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge opener]):
2004-12-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by John.
- fixed <rdar://problem/3903797> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs
I changed all unprotected places that can navigate a different
window or frame from script to check for a javascript: URL, and if
found, to check for safety using cross-site-script rules.
I considered a few other possible exploits and made no change:
- document.location is already protected because the document object itself is protected
- frame.src, frame.location, iframe.src and targetted links are all safe because setting the URL of a frame to a javascript: URL executes the script in the context of the parent
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):
2004-12-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by John.
<rdar://problem/3929187> WebKit needs to restrict access to certain window operations by domain
- khtml/ecma/kjs_window.cpp: (Window::get): Change most window functions to be restricted by XSS domain check.
The following files were changed to complete the merge. Added compareIgnoringCaseForASCIIOnly and startsWith functions
to match how it is in later versions.
- kwq/KWQString.h:
- kwq/KWQString.mm: (compareIgnoringCaseForASCIIOnly): (QString::startsWith): (QString::find):
WebKit:
<rdar://problem/3939323> frame naming allows malicious site to bring up a window when you click on a link in another
merged fix for this from Tiger:
2004-12-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another
Implement a security check on name frame visbility. This is the
same rule as mozilla. You can only target frames by name if you
are in the same window, have the same domain as the frame or an
ancestor, or if it's a top level window have the same domain as
the opener.
- WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame _descendantFrameNamed:sourceFrame:]): (-[WebFrame findFrameNamed:]):
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebView.m: (-[WebView _findFrameInThisWindowNamed:sourceFrame:]): (-[WebView _findFrameNamed:sourceFrame:]):
- WebView.subproj/WebViewPrivate.h:
- 4:17 PM Changeset in webkit [8371] by
-
- 1 edit in trunk/WebKit/Plugins.subproj/WebJavaPlugIn.h
Changed another place where the method name was incorrect in
the comment.
Reviewed (and found) by Darin.
- 4:11 PM Changeset in webkit [8370] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3952809> WebJavaPlugIn.h comments need method name corrected (webPlugInCallJava)
Reviewed by Maciej.
- Plugins.subproj/WebJavaPlugIn.h:
- 4:05 PM Changeset in webkit [8369] by
-
- 3 edits in trunk
Safari-179+ for TOT. The tree is open!
- 3:58 PM Changeset in webkit [8368]
-
- 1 copy in tags/Safari-179
This commit was manufactured by cvs2svn to create tag 'Safari-179'.
- 3:58 PM Changeset in webkit [8367] by
-
- 6 edits in trunk
Safari-179 stamp
- 3:54 PM Changeset in webkit [8366] by
-
- 6 edits in trunk
Reviewed by Adele.
- fix <rdar://problem/3946836> Safari about box lists 2004 instead of 2005
- 2:13 PM Changeset in webkit [8365] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3951911> REGRESSION: Animated GIF images with loop counts no longer update
Draw last image after animation loop terminates. (We
were drawing the image at index+1, which doesn't exist!)
Reviewed by Darin.
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _nextFrame:]):
- 2:02 PM Changeset in webkit [8364] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3952084> REGRESSION: Links at projectseven.com now draw and update incorrectly during hover
Turn off use of new CGContextStrokeLineSegments API. We should
turn back on when 3952944 is fixed.
Reviewed by Darin.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
- 1:17 PM Changeset in webkit [8363] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
fixed incorrect check-in date
- 11:45 AM Changeset in webkit [8362] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken Kocienda.
Better fix for 3905066.
- khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
- 11:41 AM Changeset in webkit [8361] by
-
- 4 edits in trunk/WebKit
Fixed: <rdar://problem/3937663> repro assertion failure and crash dragging image that has PDF source
Reviewed by adele.
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): if [WebImageRenderer image] returns nil, fallback to code that uses a file icon as the drag image
- WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]): removed code that omits PDF and PostScript from the list since this omission is only needed in WebImageView
- WebView.subproj/WebImageView.m: (+[WebImageView supportedImageMIMETypes]): added code that omits PDF and PostScript since we don't want WebImageView to render these types
- 11:09 AM Changeset in webkit [8360] by
-
- 12 edits in trunk
WebCore:
Reviewed by Darin.
<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)
- khtml/rendering/render_text.cpp: (InlineTextBox::paint): Support painting custom underline markers for marked text in place of generic yellow. (InlineTextBox::paintMarkedTextUnderline): New method that handles this.
- khtml/rendering/render_text.h:
- kwq/KWQKHTMLPart.h: Declare new methods and structs.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clear): Clear marked test underlines. (KWQKHTMLPart::setMarkedTextRange): Takes attributes and ranges now. (convertAttributesToUnderlines): Converts NSAttributedString attributes to simplified and C++-friendly form. (KWQKHTMLPart::markedTextUsesUnderlines): New method. (KWQKHTMLPart::markedTextUnderlines): New method.
- kwq/KWQPainter.mm: (QPainter::drawLineForText): Handle pen width.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge setMarkedTextDOMRange:customAttributes:ranges:]): Take attributes and ranges.
- kwq/WebCoreTextRenderer.h:
WebKit:
Reviewed by Darin.
<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): Changed to support underline thickness. Also added a bit of a hack here to move thickness 2 underlines down by .5 pixels, since the rendering engine can't give a fractional pixel offset.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView validAttributesForMarkedText]): Support underline, underline color and marked clause attributes. Others that NSText supports are unimplemented for now. (-[WebHTMLView firstRectForCharacterRange:]): Remove needless logging. (-[WebHTMLView unmarkText]): Updated for new WebCore SPI. (-[WebHTMLView _extractAttributes:ranges:fromAttributedString:]): New method to pull the attributes and ranges out of an attributed string. (-[WebHTMLView setMarkedText:selectedRange:]): Extract attributes and pass to WebCore. (-[WebHTMLView insertText:]): Add comment noting that we don't really handle attributed strings here.
