Timeline
Jan 30, 2005:
- 10:21 AM Changeset in webkit [8479] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3977000> form data set posted for <input type="image" ...> omits name/value pair
- khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::appendFormData): Append a name/value pair for type IMAGE in addition to the X/Y coordinates.
- 10:08 AM Changeset in webkit [8478] by
-
- 4 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3974246> REGRESSION (125-180): popup menus are missing item text on Harmony Remote web site
- khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::text): Change this function to traverse the entire tree and gather all the text rather than just looking at immediate children.
- khtml/xml/dom_nodeimpl.h: Added const.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::traverseNextNode): Added const. (NodeImpl::traverseNextSibling): Ditto. (NodeImpl::traversePreviousNodePostOrder): Ditto. (NodeImpl::detach): Add a missing nil check.
- 9:52 AM Changeset in webkit [8477] by
-
- 3 edits in trunk/WebKit
WebKit:
Reviewed by John.
- fixed <rdar://problem/3965265> Safari displays HTML as source when default encoding is Hebrew (due to direction overrides added by encoding converter)
- WebView.subproj/WebPreferencesPrivate.h: Added _systemCFStringEncoding, and changed _setInitialDefaultTextEncodingToSystemEncoding to be a class method.
- WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]): Added. New SPI to be used by Safari. Broken out of _setInitialDefaultTextEncodingToSystemEncoding, but also added cases for MacArabic and MacHebrew. (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Refactor to use _systemCFStringEncoding.
WebBrowser:
- fixed <rdar://problem/3965265> Safari displays HTML as source when default encoding is Hebrew (due to direction overrides added by encoding converter)
- Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences awakeFromNib]): Use the new +[WebPreferences _systemCFStringEncoding] instead of CFStringGetSystemEncoding because the latter can return Mac-specific encodings that we never want to use.
- TextEncodingMenu.m: (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Same as above.
- AppController.m: (-[AppController applicationDidFinishLaunching:]): Update call to use class method.
- 9:33 AM Changeset in webkit [8476] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3864536> crash copying text from other apps and pasting in a sticky in dashboard
- khtml/editing/markup.cpp: (khtml::createFragmentFromText): Added missing ref/deref of newly created element.
Jan 28, 2005:
- 4:38 PM Changeset in webkit [8475] by
-
- 2 edits in trunk/WebCore
- khtml/css/cssproperties.c: Regenerated with newer gperf.
- 4:13 PM Changeset in webkit [8474] by
-
- 4 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3980389> JavaScript bindings access incorrect runtime object
Only use special 'back door' property to get the runtime object if thisObj isn't
already a runtime object.
<gratuitous> Cleaned up a couple of strcmp on ClassInfo name. Used == on
ClassInfo pointer instead.
Reviewed by Chris.
- bindings/c/c_utility.cpp: (convertValueToNPVariant):
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
- bindings/runtime_method.cpp: (RuntimeMethodImp::call):
- 3:19 PM Changeset in webkit [8473] by
-
- 3 edits in trunk/WebKit
[3727680] printing some page with WebKit generates a PDF with a 1x1 image with soft mask
- 3:02 PM Changeset in webkit [8472] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
<rdar://problem/3968144> AX need to be able to focus an AXLink by setting AXFocused to true
- kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject accessibilityIsAttributeSettable:]): Add AXFocused for AXLinks.
- 1:26 PM Changeset in webkit [8471] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
<rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch
Use AppKit SPI _accessibilityParentForSubview to return KWQAccObject parent of AppKit AX object.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _accessibilityParentForSubview:]): New.
- 1:04 PM Changeset in webkit [8470] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch
Use AppKit SPI _accessibilityParentForSubview to return KWQAccObject parent of AppKit AX object.
- kwq/KWQAccObject.mm: (-[KWQAccObject _accessibilityParentForSubview:]): New.
- 11:30 AM Changeset in webkit [8469] by
-
- 4 edits in trunk/WebKit
WebKit side of: <rdar://problem/3951283> can view pages from the back/forward cache that should be disallowed by Parental Controls
Reviewed by john.
- WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:shouldGoToHistoryItem:]): new private delegate method
- WebView.subproj/WebFrame.m: (-[WebFrame _goToItem:withLoadType:]): call new delegate method
- WebView.subproj/WebPolicyDelegatePrivate.h:
Jan 27, 2005:
- 7:20 PM Changeset in webkit [8468] by
-
- 2 edits in trunk/WebCore
fixed by Darin, reviewed by me.
<rdar://problem/3976314> REGRESSION (180-TOT): submitting password fields fail on Panther
- kwq/KWQTextField.mm: (-[KWQTextFieldController string]): on panther, the secure text field's editor does not contain the real string, so now we just call stringValue on the field in that case.
- 5:16 PM Changeset in webkit [8467] by
-
- 1 edit in trunk/WebCore/kwq/KWQLineEdit.mm
Tweak the previous checkin to deal with a dynamic change to 0 results properly.
- 5:13 PM Changeset in webkit [8466] by
-
- 19 edits16 adds in trunk
WebCore:
Reviewed by Darin, Hyatt and Ken.
<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration
- khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Add support for -khtml-text-decorations-in-effect property. This works like text-docration but follows proper inline semantics, that is, if a parent is causing text decoration then -khtml-text-decorations-in-effect on this element will reflect that.
- khtml/css/cssproperties.in: Add -khtml-text-decorations-in-effect property.
- khtml/css/cssproperties.h: regenerated
- khtml/css/cssvalues.c: regenerated
- khtml/css/cssparser.cpp: regenerated
- khtml/css/cssproperties.c: regenerated
- khtml/css/css_valueimpl.h: Made copyPropertiesInSet public.
- khtml/editing/htmlediting.cpp: (khtml::StyleChange::init): Handle -khtml-text-decorations-in-effect specially, translate to text-decoration (khtml::ApplyStyleCommand::applyInlineStyle): Fix a comment. (khtml::ApplyStyleCommand::removeInlineStyle): Add new way of pushing down text-decoration styles around the edges of the selected range. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Helper for this. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): ditto (khtml::ApplyStyleCommand::nodeFullyUnselected): ditto (khtml::hasTextDecorationProperty): ditto (khtml::highestAncestorWithTextDecoration): ditto (khtml::ApplyStyleCommand::extractTextDecorationStyle): ditto (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): ditto (khtml::ApplyStyleCommand::applyTextDecorationStyle): ditto
- khtml/editing/htmlediting.h: Prototype new methods.
- khtml/editing/jsediting.cpp: Make underline execCommand use the new CSS property.
- as a necessary part of the fix, fixed the longstanding problem that mutating an element's inlineStyleDecl would not property update its style attribute. now it does.
- khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::setChanged): If this is an inline style declaration, tell the element it's style attribute needs updating.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::invalidateStyleAttribute): New method, just calls down to the dom element. (HTMLElementImpl::updateStyleAttribute): Regenerate style attribute from inline style declaration.
- khtml/html/html_elementimpl.h: Prototype new stuff.
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): Initialize new attribute. (ElementImpl::updateStyleAttributeIfNeeded): New method to check if the style is dirty and this is an html element, and if so call the html element to regenerate the style attribute. (ElementImpl::attributes): update style if needed (ElementImpl::getAttribute): ditto (ElementImpl::hasAttributes): ditto (ElementImpl::dump): ditto (XMLElementImpl::cloneNode): ditto
- khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::isStyleAttributeValid): new method to manage style attr dirty bit (DOM::ElementImpl::setStyleAttributeValid): ditto
- added new layout tests for underlining:
- layout-tests/editing/editing.js:
- layout-tests/editing/style/remove-underline-across-paragraph-expected.txt: Added.
- layout-tests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Added.
- layout-tests/editing/style/remove-underline-across-paragraph-in-bold.html: Added.
- layout-tests/editing/style/remove-underline-across-paragraph.html: Added.
- layout-tests/editing/style/remove-underline-after-paragraph-expected.txt: Added.
- layout-tests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Added.
- layout-tests/editing/style/remove-underline-after-paragraph-in-bold.html: Added.
- layout-tests/editing/style/remove-underline-after-paragraph.html: Added.
- layout-tests/editing/style/remove-underline-expected.txt: Added.
- layout-tests/editing/style/remove-underline-from-stylesheet-expected.txt: Added.
- layout-tests/editing/style/remove-underline-from-stylesheet.html: Added.
- layout-tests/editing/style/remove-underline-in-bold-expected.txt: Added.
- layout-tests/editing/style/remove-underline-in-bold.html: Added.
- layout-tests/editing/style/remove-underline.html: Added.
- layout-tests/editing/style/underline-expected.txt: Added.
- layout-tests/editing/style/underline.html: Added.
WebKit:
Reviewed by Darin, Hyatt and Ken.
<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): Use new -khtml-text-decorations-in-effect property (-[WebHTMLView _styleForAttributeChange:]): likewise (-[WebHTMLView underline:]): likewise
- 4:56 PM Changeset in webkit [8465] by
-
- 3 edits in trunk/WebCore
Fix for 3875199, search field needs to be able to show a magnifying glass without a dropdown menu.
Reviewed by kocienda
- khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::HTMLInputElementImpl): (DOM::HTMLInputElementImpl::parseHTMLAttribute):
- kwq/KWQLineEdit.mm: (QLineEdit::setMaxResults):
- 4:43 PM Changeset in webkit [8464] by
-
- 9 edits4 adds in trunk
WebCore:
Reviewed by Maciej
Fix for this bug:
<rdar://problem/3973254> Deletions of ranges does not coalesce correctly with subsequent typing
- khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::deleteCharacter): Remove this dead code. (khtml::ReplaceSelectionCommand::editingAction): Moved this code to a better place in the file. It was in with unrelated functions. (khtml::TypingCommand::TypingCommand): Reorganize initialization list so it is easier to read. (khtml::TypingCommand::issueCommandForDeleteKey): Remove dead code. Roll in remaining code into deleteKeyPressed. (khtml::TypingCommand::deleteKeyPressed): Add in support for carrying along smart delete flag. (khtml::TypingCommand::forwardDeleteKeyPressed): New function. Makes forward delete work like "regular" delete in terms of coalescing typing. (khtml::TypingCommand::doApply): Add case for ForwardDeleteKey. (khtml::TypingCommand::preservesTypingStyle): Ditto.
- khtml/editing/htmlediting.h: (khtml::TypingCommand::): Add ForwardDeleteKey constant. Remove a couple declarations for now-dead code. (khtml::TypingCommand::smartDelete): New accessor. (khtml::TypingCommand::setSmartDelete): Ditto.
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge deleteKeyPressedWithSmartDelete:]): Add smart delete flag. (-[WebCoreBridge forwardDeleteKeyPressedWithSmartDelete:]): New method.
- khtml/editing/jsediting.cpp: Add supprt for ForwardDelete command
- layout-tests/editing/editing.js: Ditto.
- layout-tests/editing/deleting/delete-and-undo-expected.txt: Added.
- layout-tests/editing/deleting/delete-and-undo.html: Added.
- layout-tests/editing/deleting/forward-delete-expected.txt: Added.
- layout-tests/editing/deleting/forward-delete.html: Added.
WebKit:
Reviewed by Maciej
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleKillRing:prepend:]): New helper function. Code factored out from _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:. (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:]): No longer takes unused preflight argument. Now takes new isTypingAction argument. Uses isTypingAction to determine which flavor of delete command to call. (-[WebHTMLView _deleteSelection]): No longer passes unused preflight argument. Now passes new isTypingAction argument. (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Rearranged code to call correct flavor of delete command, based on whether typing should be preserved. Some other cleanups. (-[WebHTMLView deleteForward:]): Add _isEditable check. (-[WebHTMLView deleteBackward:]): Now calls _deleteWithDirection instead of having unique behavior different from forward delete. (-[WebHTMLView deleteWordForward:]): Add new isTypingAction flag to _deleteWithDirection call. (-[WebHTMLView deleteWordBackward:]): Ditto. (-[WebHTMLView deleteToBeginningOfLine:]): Ditto. (-[WebHTMLView deleteToEndOfLine:]): Ditto. (-[WebHTMLView deleteToBeginningOfParagraph:]): Ditto. (-[WebHTMLView deleteToEndOfParagraph:]): Ditto. (-[WebHTMLView deleteToMark:]): Ditto.
- 3:45 PM Changeset in webkit [8463] by
-
- 3 edits in trunk
Versioning for tip of tree, Safari 2.0 (181+).
The tree is open!
- 3:35 PM Changeset in webkit [8462]
-
- 1 copy in tags/Safari-181
This commit was manufactured by cvs2svn to create tag 'Safari-181'.
- 3:35 PM Changeset in webkit [8461] by
-
- 6 edits in trunk
Safari-181 stamp
- 11:36 AM Changeset in webkit [8460] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
<rdar://problem/3962214> AX: AXLeftLineTextMarkerRangeForTextMarker returns incorrect range
- kwq/KWQAccObject.mm: (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): Allowed for selection to end of line including the linebreak.
- 11:30 AM Changeset in webkit [8459] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin, Ken.
<rdar://problem/3964470> AX: Include attachments in AXAttributedStringForTextMarkerRange
- kwq/KWQAccObject.mm: (-[KWQAccObject isAttachment]): (-[KWQAccObject attachmentView]): (-[KWQAccObject role]): (-[KWQAccObject subrole]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject accessibilityDescription]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): Make attachments accessible.
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetFont):
(AXAttributeStringSetStyle):
(AXAttributeStringSetElement):
(AXLinkElementForNode):
(AXAttributedStringAppendText):
(AXAttributedStringAppendReplaced):
(-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
Add attachments and more text attributes to AXAttributedStringForTextMarkerRange.
- 11:27 AM Changeset in webkit [8458] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3807935> DOM CSS computed style line-height is wrong in two ways
- khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Use specified size rather than computed size when dealing with a percentage for line height.
- 11:24 AM Changeset in webkit [8457] by
-
- 3 edits1 add in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3971372> SWB: template function DOM_cast() won't compile with gcc 4.0
- fixed other gcc 4.0 compiling problems Patrick Beard pointed out on the phone
- kwq/DOMInternal.h: (DOM_cast): Change the "failToCompile()" trick to use a dependent name. Nowadays, if a name is not dependent, it is checked at template definition time. But we want a failure only at template instantiation time.
- ForwardingHeaders/editing/text_granularity.h: Added. Needed but a bug in the 3.3 compiler made it compile anyway without this.
- other changes
- khtml/html/html_miscimpl.h: For clarity, mark these functions virtual too. They are automatically virtual because the base class ones are virtual, but it's ugly to leave it this way.
- 10:46 AM Changeset in webkit [8456] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3973272> REGRESSION: Safari uses QT plugin to display PNG images
Reviewed by john.
- Plugins.subproj/WebBasePluginPackage.m: use renamed QT bundle ID
- 8:02 AM Changeset in webkit [8455] by
-
- 6 edits in trunk/WebCore
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3971609> REGRESSION (Mail): up/down arrow navigation broken after rewrapping text by resizing window
<rdar://problem/3975661> REGRESSION (Mail): left/right arrow navigation can place insertion point after last character on line
- khtml/editing/selection.cpp: (khtml::Selection::modifyAffinity): PARAGRAPH and LINE movements should not alter affinity. This was just a mistake before when it reset to upstream in some cases.
- khtml/rendering/render_line.cpp: (khtml::RootInlineBox::closestLeafChildForXPos): Move this function down from InlineBox, and rework the implementation. This fixes 3971609.
- khtml/rendering/render_line.h:
- khtml/rendering/render_text.cpp: (RenderText::caretRect): Rework the algorithm to fix 3975661. This regressed when we began placing the spaces on the end of lines in text boxes when lines wrap.
Jan 26, 2005:
- 6:01 PM Changeset in webkit [8454] by
-
- 4 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3829517> WebView still draws white when setDrawsBackground set to NO and no content loaded yet
- WebView.subproj/WebFrameView.m: (-[WebFrameView drawRect:]): Check drawsBackground, and don't draw the white "no document" background if it's NO. This fixes things for frames with no document.
- WebView.subproj/WebImageView.m: (-[WebImageView drawRect:]): Same as above. This fixes things for frames with just an image.
- WebView.subproj/WebFrame.m: (-[WebFrame _updateDrawsBackground]): Call setDrawsBackground: on the document view if it implements it. This fixes things for frames with plain text.
- 1:38 PM Changeset in webkit [8453] by
-
- 12 edits in trunk
Fixed <rdar://problem/3972522> (179-180) 40% slowdown on iBench JavaScript test
I added a member variable to ObjectImp. This changed it's size and consequently
hampered the optimizations built into the garbage collector. Objects no longer
fit within the allocators cell size, and thus allocation fell back to a slower
allocator.
As a result of this fix I also dramatically cleaned up how runtime objects are
accessed. The path mostly *removes* code.
Reviewed by Chris.
- bindings/runtime_method.cpp: (RuntimeMethodImp::call):
- bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue):
- bindings/runtime_object.h:
- kjs/object.cpp: (KJS::ObjectImp::ObjectImp):
- kjs/object.h:
WebCore:
Fixed <rdar://problem/3972522> (179-180) 40% slowdown on iBench JavaScript test
I added a member variable to ObjectImp. This changed it's size and consequently
hampered the optimizations built into the garbage collector. Objects no longer
fit within the allocators cell size, and thus allocation fell back to a slower
allocator.
As a result of this fix I also dramatically cleaned up how runtime objects are
accessed. The path mostly *removes* code.
Reviewed by Chris.
- khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (KJS::getRuntimeObject):
- khtml/ecma/kjs_dom.h:
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLElement::implementsCall): (KJS::HTMLElement::call): (KJS::HTMLElement::tryPut): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):
- khtml/ecma/kjs_html.h:
- khtml/ecma/kjs_window.cpp: (Window::get):
- 1:26 PM Changeset in webkit [8452] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3757712> REGRESSION (Mail): WebCore does not allow Devanagari ligature input
For now we are using ICU UBreakIterator to determine grapheme boundaries for
cursor and deletion. This does not match what Cocoa does exactly, but does match
what Carbon does. The areas are difference are obscure, but, according to
Deborah Goldsmith, using the UBreakIterator is the reasonable approach.
Reviewed by Ken.
- khtml/rendering/render_text.cpp: (RenderText::previousOffset): (RenderText::nextOffset):
