Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jan 31, 2005:

5:20 PM Changeset in webkit [8491] by sullivan

• 3 edits in trunk/WebCore

Reviewed by Dave Hyatt.

• fixed <rdar://problem/3983097> Tabbing on RSS pages gets stuck in search field with "full keyboard navigation" off

• kwq/KWQSlider.h:
• kwq/KWQSlider.mm: (QSlider::focusPolicy): Implemented this method for KWQSlider. It is needed for our widget subclasses that can become focused in some situations. I missed this when fixing 3949203 because it only comes into play when tab-to-controls is on, and because the other relevant methods are objective-C methods.

4:40 PM Changeset in webkit [8490] by cblu

• 5 edits in trunk/WebKit

Fixed: <rdar://problem/3949806> REGRESSION: Source window fails to refresh correctly on reload

The data method was being called on WebDataSource before the data was set. This fix makes WebDataSource set the data before releasing the main client instead of waiting for the main client to set it when it is dealloced.

Reviewed by darin.

• WebView.subproj/WebDataSource.m: (-[WebDataSource _setData:]): moved within file (-[WebDataSource _setPrimaryLoadComplete:]): call _setData: with the data from the main client before letting go of the main client
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient releaseResources]): removed call to _setData: since the data source may need the data before releaseResources is called

4:04 PM Changeset in webkit [8489] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3946285> Seed: Safari crashed by selecting all at internet-moebel.com

Reviewed by john.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): new, factored hit test hack to this method (-[WebHTMLView _updateMouseoverWithEvent:): call _hitViewForEvent: (-[WebHTMLView acceptsFirstMouse:]): call _setMouseDownEvent: and _isSelectionEvent: on the hit HTMLView or else when it's asked to drag it will assert (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto

3:52 PM Changeset in webkit [8488] by harrison

• 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3961239> AX Setting AXFocused on AXScrollArea of AXWebArea will cause keyboard selection change

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView maintainsInactiveSelection]): Keep the selection when the new first respomder is our own scrollview, in both editable and non-editaqble content.

3:16 PM Changeset in webkit [8487] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3964164> AXWebArea needs to unregister on going invisible

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Detach the AX UIElement for the AXWebArea.

3:08 PM Changeset in webkit [8486] by harrison

• 4 edits in trunk/WebCore

Reviewed by Darin

<rdar://problem/3850876> AX: button exposed as only an AXImage at ​http://appleseed.apple.com/ site (<input type=image>)

• khtml/rendering/render_form.h: (khtml::RenderImageButton::isImageButton): New.
• khtml/rendering/render_image.h: (khtml::RenderImage::isImageButton): New.
• kwq/KWQAccObject.mm: (-[KWQAccObject isImageButton]): (-[KWQAccObject actionElement]): (-[KWQAccObject role]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityPerformAction:]): Represent RenderImageButton elements as buttons instead of images.

12:12 PM Changeset in webkit [8485] by harrison

• 2 edits in trunk/WebCore

Prevent nil dereference in debug code.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayTree): Stop when parent is 0, too.

11:14 AM Changeset in webkit [8484] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

• fixed <rdar://problem/3949203> cannot tab to, within, or out of the RSS sidebar

• kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]): (-[KWQSlider nextKeyView]): (-[KWQSlider previousKeyView]): (-[KWQSlider canBecomeKeyView]): (-[KWQSlider nextValidKeyView]): (-[KWQSlider previousValidKeyView]): Copied these methods from KWQButton. The lack of special handling for first-responder-ness here was causing the focus to get "stuck" on the RSS page's slider widget. Added FIXME about how it would be nice to share more of this code rather than replicating it in each KWQ widget subclass.

10:58 AM Changeset in webkit [8483] by darin

• 4 edits in trunk/WebCore

Reviewed by Harrison.

• fixed <rdar://problem/3980066> Double-click on single character moves insertion point to previous line

• khtml/khtml_part.cpp: (KHTMLPart::selectClosestWordFromMouseEvent): Set affinity too. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMouseMoveEventSelection): Ditto. (KHTMLPart::khtmlMouseReleaseEvent): Ditto.

• khtml/editing/selection.cpp: (khtml::Selection::modifyExtendingRightForward): Use endOfLine and endOfDocument. (khtml::Selection::modifyMovingRightForward): Ditto. (khtml::Selection::modifyExtendingLeftBackward): Use startOfLine and startOfDocument. (khtml::Selection::modifyMovingLeftBackward): Ditto. (khtml::Selection::validate): Rewrote the section that handles double-click. Two main fixes: 1) use isStartOfLine to check for another case where we want to select the word to the right, and 2) use isEndOfParagraph, which seems to work correctly in cases where isLastVisiblePositionInParagraph is giving the wrong answer. Also changed the line code to use startOfLine/endOfLine and the document code to use startOfDocument/endOfDocument.

10:49 AM Changeset in webkit [8482] by darin

• 2 edits in trunk/WebCore

Reviewed by Harrison.

• fixed <rdar://problem/3935275> unexpected quit scrolling over link; last.fm (works in IE and Firefox)

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): By using the correct document, fix the crash reported here. The page still crashes when you close the browser window, but it's not trivial to fix so I'll file a new bug after that.

10:48 AM Changeset in webkit [8481] by jens

• 2 edits in trunk/WebKit

[3903199] Large background patterns slide around while loading

10:03 AM Changeset in webkit [8480] by darin

• 4 edits in trunk/WebCore

Reviewed by Ken and Harrison.

• fixed <rdar://problem/3947901> REGRESSION (Mail): Pasting paragraph of rich text leaves insertion point before pasted text
• fixed <rdar://problem/3949790> hitting return after underlined line results in too much or too little underlined
• fixed <rdar://problem/3981759> nil-deref and crash when pasting just a paragraph break
• fixed a couple problems I discovered while working with bug 3949790

• khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyInlineStyle): Pass StayInBlock to upstream. Without this, we end up going too far upstream in the test case in bug 3949790. (khtml::ApplyStyleCommand::removeInlineStyle): Pass StayInBlock to upstream and downstream. Same reason as above. (khtml::ReplaceSelectionCommand::doApply): Update endPos if inserting a new node and endPos is using that node's parent and an offset past the node being inserted. That change fixes a problem with the position of the insertion point after pasting into the top level of a document (from test cases in 3947901 and 3949790). When setting insertionPos, use code that works when lastNodeInserted is a block rather than a text node. That change fixes a problem where a newline is not added when pasting an entire paragraph into the end of a document (from test case in 3949790). Added nil check before checking if lastNodeInserted is a <br> element, which fixes the crash when pasting just a paragraph break.

• khtml/editing/visible_units.h: Filled out the set of calls to add some boolean checks for lines (needed for the bug fix), and calls for blocks (not yet implemented), and documents. The document checks may need refinement to properly handle documents with a mix of editable and non-editable content, but for now they just refactor code and make things a little clearer. Also removed the "include line break" parameter from endOfSentence.
• khtml/editing/visible_units.cpp: (khtml::rootBoxForLine): Added. (khtml::startOfLine): Added. Algorithm taken from selectionForLine in selection.cpp. (khtml::endOfLine): Ditto. (khtml::inSameLine): Added. (khtml::isStartOfLine): Added. (khtml::isEndOfLine): Added. (khtml::endOfSentence): Removed "include line break" parameter. (khtml::inSameParagraph): Added a null check. (khtml::isStartOfParagraph): Ditto. (khtml::isEndOfParagraph): Ditto. (khtml::startOfBlock): Added. (khtml::endOfBlock): Added. (khtml::inSameBlock): Added. (khtml::isStartOfBlock): Added. (khtml::isEndOfBlock): Added. (khtml::startOfDocument): Added. (khtml::endOfDocument): Added. (khtml::inSameDocument): Added. (khtml::isStartOfDocument): Added. (khtml::isEndOfDocument): Added.

Jan 30, 2005:

10:21 AM Changeset in webkit [8479] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3977000> form data set posted for <input type="image" ...> omits name/value pair

• khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::appendFormData): Append a name/value pair for type IMAGE in addition to the X/Y coordinates.

10:08 AM Changeset in webkit [8478] by darin

• 4 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3974246> REGRESSION (125-180): popup menus are missing item text on Harmony Remote web site

• khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::text): Change this function to traverse the entire tree and gather all the text rather than just looking at immediate children.

• khtml/xml/dom_nodeimpl.h: Added const.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::traverseNextNode): Added const. (NodeImpl::traverseNextSibling): Ditto. (NodeImpl::traversePreviousNodePostOrder): Ditto. (NodeImpl::detach): Add a missing nil check.

9:52 AM Changeset in webkit [8477] by darin

• 3 edits in trunk/WebKit

WebKit:

Reviewed by John.

• fixed <rdar://problem/3965265> Safari displays HTML as source when default encoding is Hebrew (due to direction overrides added by encoding converter)

• WebView.subproj/WebPreferencesPrivate.h: Added _systemCFStringEncoding, and changed _setInitialDefaultTextEncodingToSystemEncoding to be a class method.
• WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]): Added. New SPI to be used by Safari. Broken out of _setInitialDefaultTextEncodingToSystemEncoding, but also added cases for MacArabic and MacHebrew. (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Refactor to use _systemCFStringEncoding.

WebBrowser:

• fixed <rdar://problem/3965265> Safari displays HTML as source when default encoding is Hebrew (due to direction overrides added by encoding converter)

• Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences awakeFromNib]): Use the new +[WebPreferences _systemCFStringEncoding] instead of CFStringGetSystemEncoding because the latter can return Mac-specific encodings that we never want to use.
• TextEncodingMenu.m: (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Same as above.

• AppController.m: (-[AppController applicationDidFinishLaunching:]): Update call to use class method.

9:33 AM Changeset in webkit [8476] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3864536> crash copying text from other apps and pasting in a sticky in dashboard

• khtml/editing/markup.cpp: (khtml::createFragmentFromText): Added missing ref/deref of newly created element.

Jan 28, 2005:

4:38 PM Changeset in webkit [8475] by darin

• 2 edits in trunk/WebCore

• khtml/css/cssproperties.c: Regenerated with newer gperf.

4:13 PM Changeset in webkit [8474] by rjw

• 4 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3980389> JavaScript bindings access incorrect runtime object

Only use special 'back door' property to get the runtime object if thisObj isn't
already a runtime object.

<gratuitous> Cleaned up a couple of strcmp on ClassInfo name. Used == on
ClassInfo pointer instead.

Reviewed by Chris.

• bindings/c/c_utility.cpp: (convertValueToNPVariant):
• bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
• bindings/runtime_method.cpp: (RuntimeMethodImp::call):

3:19 PM Changeset in webkit [8473] by jens

• 3 edits in trunk/WebKit

[3727680] printing some page with WebKit generates a PDF with a 1x1 image with soft mask

3:02 PM Changeset in webkit [8472] by harrison

• 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/3968144> AX need to be able to focus an AXLink by setting AXFocused to true

• kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject accessibilityIsAttributeSettable:]): Add AXFocused for AXLinks.

1:26 PM Changeset in webkit [8471] by harrison

• 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch

Use AppKit SPI _accessibilityParentForSubview to return KWQAccObject parent of AppKit AX object.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _accessibilityParentForSubview:]): New.

1:04 PM Changeset in webkit [8470] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch

Use AppKit SPI _accessibilityParentForSubview to return KWQAccObject parent of AppKit AX object.

• kwq/KWQAccObject.mm: (-[KWQAccObject _accessibilityParentForSubview:]): New.

11:30 AM Changeset in webkit [8469] by cblu

• 4 edits in trunk/WebKit

WebKit side of: <rdar://problem/3951283> can view pages from the back/forward cache that should be disallowed by Parental Controls

Reviewed by john.

• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:shouldGoToHistoryItem:]): new private delegate method
• WebView.subproj/WebFrame.m: (-[WebFrame _goToItem:withLoadType:]): call new delegate method
• WebView.subproj/WebPolicyDelegatePrivate.h:

Jan 27, 2005:

7:20 PM Changeset in webkit [8468] by adele

• 2 edits in trunk/WebCore

fixed by Darin, reviewed by me.

<rdar://problem/3976314> REGRESSION (180-TOT): submitting password fields fail on Panther

• kwq/KWQTextField.mm: (-[KWQTextFieldController string]): on panther, the secure text field's editor does not contain the real string, so now we just call stringValue on the field in that case.

5:16 PM Changeset in webkit [8467] by hyatt

• 1 edit in trunk/WebCore/kwq/KWQLineEdit.mm

Tweak the previous checkin to deal with a dynamic change to 0 results properly.

5:13 PM Changeset in webkit [8466] by mjs

• 19 edits
  16 adds in trunk

WebCore:

Reviewed by Darin, Hyatt and Ken.

<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Add support for -khtml-text-decorations-in-effect property. This works like text-docration but follows proper inline semantics, that is, if a parent is causing text decoration then -khtml-text-decorations-in-effect on this element will reflect that.
• khtml/css/cssproperties.in: Add -khtml-text-decorations-in-effect property.
• khtml/css/cssproperties.h: regenerated
• khtml/css/cssvalues.c: regenerated
• khtml/css/cssparser.cpp: regenerated
• khtml/css/cssproperties.c: regenerated

• khtml/css/css_valueimpl.h: Made copyPropertiesInSet public.

• khtml/editing/htmlediting.cpp: (khtml::StyleChange::init): Handle -khtml-text-decorations-in-effect specially, translate to text-decoration (khtml::ApplyStyleCommand::applyInlineStyle): Fix a comment. (khtml::ApplyStyleCommand::removeInlineStyle): Add new way of pushing down text-decoration styles around the edges of the selected range. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Helper for this. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): ditto (khtml::ApplyStyleCommand::nodeFullyUnselected): ditto (khtml::hasTextDecorationProperty): ditto (khtml::highestAncestorWithTextDecoration): ditto (khtml::ApplyStyleCommand::extractTextDecorationStyle): ditto (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): ditto (khtml::ApplyStyleCommand::applyTextDecorationStyle): ditto
• khtml/editing/htmlediting.h: Prototype new methods.
• khtml/editing/jsediting.cpp: Make underline execCommand use the new CSS property.

• as a necessary part of the fix, fixed the longstanding problem that mutating an element's inlineStyleDecl would not property update its style attribute. now it does.

• khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::setChanged): If this is an inline style declaration, tell the element it's style attribute needs updating.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::invalidateStyleAttribute): New method, just calls down to the dom element. (HTMLElementImpl::updateStyleAttribute): Regenerate style attribute from inline style declaration.
• khtml/html/html_elementimpl.h: Prototype new stuff.
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): Initialize new attribute. (ElementImpl::updateStyleAttributeIfNeeded): New method to check if the style is dirty and this is an html element, and if so call the html element to regenerate the style attribute. (ElementImpl::attributes): update style if needed (ElementImpl::getAttribute): ditto (ElementImpl::hasAttributes): ditto (ElementImpl::dump): ditto (XMLElementImpl::cloneNode): ditto
• khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::isStyleAttributeValid): new method to manage style attr dirty bit (DOM::ElementImpl::setStyleAttributeValid): ditto

• added new layout tests for underlining:

• layout-tests/editing/editing.js:
• layout-tests/editing/style/remove-underline-across-paragraph-expected.txt: Added.
• layout-tests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Added.
• layout-tests/editing/style/remove-underline-across-paragraph-in-bold.html: Added.
• layout-tests/editing/style/remove-underline-across-paragraph.html: Added.
• layout-tests/editing/style/remove-underline-after-paragraph-expected.txt: Added.
• layout-tests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt: Added.
• layout-tests/editing/style/remove-underline-after-paragraph-in-bold.html: Added.
• layout-tests/editing/style/remove-underline-after-paragraph.html: Added.
• layout-tests/editing/style/remove-underline-expected.txt: Added.
• layout-tests/editing/style/remove-underline-from-stylesheet-expected.txt: Added.
• layout-tests/editing/style/remove-underline-from-stylesheet.html: Added.
• layout-tests/editing/style/remove-underline-in-bold-expected.txt: Added.
• layout-tests/editing/style/remove-underline-in-bold.html: Added.
• layout-tests/editing/style/remove-underline.html: Added.
• layout-tests/editing/style/underline-expected.txt: Added.
• layout-tests/editing/style/underline.html: Added.

WebKit:

Reviewed by Darin, Hyatt and Ken.

<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): Use new -khtml-text-decorations-in-effect property (-[WebHTMLView _styleForAttributeChange:]): likewise (-[WebHTMLView underline:]): likewise

4:56 PM Changeset in webkit [8465] by hyatt

• 3 edits in trunk/WebCore

Fix for 3875199, search field needs to be able to show a magnifying glass without a dropdown menu.

Reviewed by kocienda

• khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::HTMLInputElementImpl): (DOM::HTMLInputElementImpl::parseHTMLAttribute):
• kwq/KWQLineEdit.mm: (QLineEdit::setMaxResults):

4:43 PM Changeset in webkit [8464] by kocienda

• 9 edits
  4 adds in trunk

WebCore:

Reviewed by Maciej

Fix for this bug:

<rdar://problem/3973254> Deletions of ranges does not coalesce correctly with subsequent typing

• khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::deleteCharacter): Remove this dead code. (khtml::ReplaceSelectionCommand::editingAction): Moved this code to a better place in the file. It was in with unrelated functions. (khtml::TypingCommand::TypingCommand): Reorganize initialization list so it is easier to read. (khtml::TypingCommand::issueCommandForDeleteKey): Remove dead code. Roll in remaining code into deleteKeyPressed. (khtml::TypingCommand::deleteKeyPressed): Add in support for carrying along smart delete flag. (khtml::TypingCommand::forwardDeleteKeyPressed): New function. Makes forward delete work like "regular" delete in terms of coalescing typing. (khtml::TypingCommand::doApply): Add case for ForwardDeleteKey. (khtml::TypingCommand::preservesTypingStyle): Ditto.
• khtml/editing/htmlediting.h: (khtml::TypingCommand::): Add ForwardDeleteKey constant. Remove a couple declarations for now-dead code. (khtml::TypingCommand::smartDelete): New accessor. (khtml::TypingCommand::setSmartDelete): Ditto.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge deleteKeyPressedWithSmartDelete:]): Add smart delete flag. (-[WebCoreBridge forwardDeleteKeyPressedWithSmartDelete:]): New method.
• khtml/editing/jsediting.cpp: Add supprt for ForwardDelete command
• layout-tests/editing/editing.js: Ditto.
• layout-tests/editing/deleting/delete-and-undo-expected.txt: Added.
• layout-tests/editing/deleting/delete-and-undo.html: Added.
• layout-tests/editing/deleting/forward-delete-expected.txt: Added.
• layout-tests/editing/deleting/forward-delete.html: Added.

WebKit:

Reviewed by Maciej

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleKillRing:prepend:]): New helper function. Code factored out from _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:. (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:]): No longer takes unused preflight argument. Now takes new isTypingAction argument. Uses isTypingAction to determine which flavor of delete command to call. (-[WebHTMLView _deleteSelection]): No longer passes unused preflight argument. Now passes new isTypingAction argument. (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Rearranged code to call correct flavor of delete command, based on whether typing should be preserved. Some other cleanups. (-[WebHTMLView deleteForward:]): Add _isEditable check. (-[WebHTMLView deleteBackward:]): Now calls _deleteWithDirection instead of having unique behavior different from forward delete. (-[WebHTMLView deleteWordForward:]): Add new isTypingAction flag to _deleteWithDirection call. (-[WebHTMLView deleteWordBackward:]): Ditto. (-[WebHTMLView deleteToBeginningOfLine:]): Ditto. (-[WebHTMLView deleteToEndOfLine:]): Ditto. (-[WebHTMLView deleteToBeginningOfParagraph:]): Ditto. (-[WebHTMLView deleteToEndOfParagraph:]): Ditto. (-[WebHTMLView deleteToMark:]): Ditto.

3:45 PM Changeset in webkit [8463] by vicki

• 3 edits in trunk

Versioning for tip of tree, Safari 2.0 (181+).

The tree is open!

3:35 PM Changeset in webkit [8462]

• 1 copy in tags/Safari-181

This commit was manufactured by cvs2svn to create tag 'Safari-181'.

3:35 PM Changeset in webkit [8461] by vicki

• 6 edits in trunk

Safari-181 stamp

11:36 AM Changeset in webkit [8460] by harrison

• 2 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3962214> AX: AXLeftLineTextMarkerRangeForTextMarker returns incorrect range

• kwq/KWQAccObject.mm: (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): Allowed for selection to end of line including the linebreak.

11:30 AM Changeset in webkit [8459] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin, Ken.

<rdar://problem/3964470> AX: Include attachments in AXAttributedStringForTextMarkerRange

• kwq/KWQAccObject.mm: (-[KWQAccObject isAttachment]): (-[KWQAccObject attachmentView]): (-[KWQAccObject role]): (-[KWQAccObject subrole]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (-[KWQAccObject title]): (-[KWQAccObject accessibilityDescription]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): Make attachments accessible.

(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetFont):
(AXAttributeStringSetStyle):
(AXAttributeStringSetElement):
(AXLinkElementForNode):
(AXAttributedStringAppendText):
(AXAttributedStringAppendReplaced):
(-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
Add attachments and more text attributes to AXAttributedStringForTextMarkerRange.

11:27 AM Changeset in webkit [8458] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3807935> DOM CSS computed style line-height is wrong in two ways

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Use specified size rather than computed size when dealing with a percentage for line height.

11:24 AM Changeset in webkit [8457] by darin

• 3 edits
  1 add in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3971372> SWB: template function DOM_cast() won't compile with gcc 4.0
• fixed other gcc 4.0 compiling problems Patrick Beard pointed out on the phone

• kwq/DOMInternal.h: (DOM_cast): Change the "failToCompile()" trick to use a dependent name. Nowadays, if a name is not dependent, it is checked at template definition time. But we want a failure only at template instantiation time.

• ForwardingHeaders/editing/text_granularity.h: Added. Needed but a bug in the 3.3 compiler made it compile anyway without this.

• other changes

• khtml/html/html_miscimpl.h: For clarity, mark these functions virtual too. They are automatically virtual because the base class ones are virtual, but it's ugly to leave it this way.

10:46 AM Changeset in webkit [8456] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3973272> REGRESSION: Safari uses QT plugin to display PNG images

Reviewed by john.

• Plugins.subproj/WebBasePluginPackage.m: use renamed QT bundle ID

8:02 AM Changeset in webkit [8455] by kocienda

• 6 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3971609> REGRESSION (Mail): up/down arrow navigation broken after rewrapping text by resizing window
<rdar://problem/3975661> REGRESSION (Mail): left/right arrow navigation can place insertion point after last character on line

• khtml/editing/selection.cpp: (khtml::Selection::modifyAffinity): PARAGRAPH and LINE movements should not alter affinity. This was just a mistake before when it reset to upstream in some cases.
• khtml/rendering/render_line.cpp: (khtml::RootInlineBox::closestLeafChildForXPos): Move this function down from InlineBox, and rework the implementation. This fixes 3971609.
• khtml/rendering/render_line.h:
• khtml/rendering/render_text.cpp: (RenderText::caretRect): Rework the algorithm to fix 3975661. This regressed when we began placing the spaces on the end of lines in text boxes when lines wrap.