Timeline



Feb 1, 2005:

6:51 PM Changeset in webkit [8500] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/3985535> QT Plug-in JavaScript support now fails in <embed> tag only case

Reviewed by Maciej.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet):
6:13 PM Changeset in webkit [8499] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3977727> WebKit should use new SPI to support faster GIF rendering

Note: This REQUIRES build >= 3A362 when building on Tiger.

Reviewed by John.

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]):
5:54 PM Changeset in webkit [8498] by sullivan
  • 2 edits in trunk/WebCore

Written by Darin, reviewed and tested by me

  • fixed <rdar://problem/3969684> Panther-only: extra blank lines between pasted content from Blot
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): don't emit paragraph breaks if the margins are tiny; matches what we do for plain-text conversion
5:06 PM Changeset in webkit [8497] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (182+)
the tree is open!

4:50 PM Changeset in webkit [8496]
  • 1 copy in tags/Safari-182

This commit was manufactured by cvs2svn to create tag 'Safari-182'.

4:50 PM Changeset in webkit [8495] by vicki
  • 6 edits in trunk

Safari-182 stamp

3:06 PM Changeset in webkit [8494] by rjw
  • 1 edit in trunk/WebKit/WebView.subproj/WebViewPrivate.h

Additional part of last checkin that I missed.

2:28 PM Changeset in webkit [8493] by rjw
  • 4 edits in trunk/WebKit

WebKit:

Added new SPI for <rdar://problem/3967063> need spi on WebView to turn of lcd text for Dashboard

Reviewed by Chris.

  • WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs):
  • WebView.subproj/WebView.m: (-[WebView drawRect:]): (-[WebView _dashboardBehavior:]): (+[WebView _setShouldUseFontSmoothing:]): (+[WebView _shouldUseFontSmoothing]):
  • WebView.subproj/WebViewInternal.h:
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Used new SPI (from <rdar://problem/3967063> need spi on WebView to turn of lcd text for Dashboard)

Reviewed by Chris.

  • EtchedStringButtonCell.m: (-[EtchedStringButtonCell drawInteriorWithFrame:inView:]):
1:23 PM Changeset in webkit [8492] by kocienda
  • 13 edits in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3985160> Deficiencies in pasting architecture blocking progress on other bugs

  • khtml/editing/html_interchange.h: Move style span text used to mark element added to add style to this header.
  • khtml/editing/htmlediting.cpp: (khtml::styleSpanClassString): Change to use constant moved to html_interchange.h. (khtml::isStyleSpan): New helper function. Checks if this is a span we added to apply style. (khtml::CompositeEditCommand::insertNodeBefore): Added an assert to check that the node we are inserting before is not the body. (khtml::CompositeEditCommand::insertNodeAfter): Ditto, but check is for after. (khtml::ReplacementFragment::ReplacementFragment): Added code to process the "default style" that is added by the copy code. (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): first and last nodes inserted are now member variables instead of function locals. Initialize them here. (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand): Deref first and last nodes inserted if necessary. (khtml::ReplaceSelectionCommand::doApply): Change design to fix the bug. Major change is to separate out the code that inserts nodes into the tree so additional styling checks can be done in a centralized way. Also got rid of the notion of "merging into the end block." That concept was just wrong. (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Tweak interface now that first and last nodes inserted are member variables. (khtml::ReplaceSelectionCommand::insertNodeAfterAndUpdateNodesInserted): New helper used by replace code to do the stated DOM operation and update state internal to the command. This will also be a catch point to handle the kinds of additional style checks needed to make paste work right. (khtml::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted): Ditto. (khtml::ReplaceSelectionCommand::insertNodeBeforeAndUpdateNodesInserted): Ditto. (khtml::ReplaceSelectionCommand::updateNodesInserted): Ditto.
  • khtml/editing/htmlediting.h: Update declarations as needed.
  • khtml/editing/markup.cpp: (khtml::createMarkup): Adds a "default style" span to the content written to the pasteboard. This will help us to fix some of the bugs blocked by the bug above.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::lastDescendent): New helper.
  • khtml/xml/dom_nodeimpl.h: Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): Fixed a bug which would allow the upstream position returned to be in unrendered content. (DOM::Position::downstream): Ditto.
  • layout-tests/editing/deleting/delete-3775172-fix-expected.txt: Ending positions tweaked due to changes in upstream() and downstream() functions.
  • layout-tests/editing/inserting/insert-3851164-fix-expected.txt: Ditto
  • layout-tests/editing/inserting/insert-3907422-fix-expected.txt: Ditto
  • layout-tests/editing/selection/extend-by-character-006-expected.txt: Ditto
  • layout-tests/editing/pasteboard/paste-text-003-expected.txt: Changed what we expect, given new behavior of paste code.

Jan 31, 2005:

5:20 PM Changeset in webkit [8491] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/3983097> Tabbing on RSS pages gets stuck in search field with "full keyboard navigation" off
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (QSlider::focusPolicy): Implemented this method for KWQSlider. It is needed for our widget subclasses that can become focused in some situations. I missed this when fixing 3949203 because it only comes into play when tab-to-controls is on, and because the other relevant methods are objective-C methods.
4:40 PM Changeset in webkit [8490] by cblu
  • 5 edits in trunk/WebKit

Fixed: <rdar://problem/3949806> REGRESSION: Source window fails to refresh correctly on reload

The data method was being called on WebDataSource before the data was set. This fix makes WebDataSource set the data before releasing the main client instead of waiting for the main client to set it when it is dealloced.

Reviewed by darin.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _setData:]): moved within file (-[WebDataSource _setPrimaryLoadComplete:]): call _setData: with the data from the main client before letting go of the main client
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient releaseResources]): removed call to _setData: since the data source may need the data before releaseResources is called
4:04 PM Changeset in webkit [8489] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3946285> Seed: Safari crashed by selecting all at internet-moebel.com

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): new, factored hit test hack to this method (-[WebHTMLView _updateMouseoverWithEvent:): call _hitViewForEvent: (-[WebHTMLView acceptsFirstMouse:]): call _setMouseDownEvent: and _isSelectionEvent: on the hit HTMLView or else when it's asked to drag it will assert (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto
3:52 PM Changeset in webkit [8488] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3961239> AX Setting AXFocused on AXScrollArea of AXWebArea will cause keyboard selection change

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView maintainsInactiveSelection]): Keep the selection when the new first respomder is our own scrollview, in both editable and non-editaqble content.
3:16 PM Changeset in webkit [8487] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3964164> AXWebArea needs to unregister on going invisible

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Detach the AX UIElement for the AXWebArea.
3:08 PM Changeset in webkit [8486] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Darin

<rdar://problem/3850876> AX: button exposed as only an AXImage at ​http://appleseed.apple.com/ site (<input type=image>)

  • khtml/rendering/render_form.h: (khtml::RenderImageButton::isImageButton): New.
  • khtml/rendering/render_image.h: (khtml::RenderImage::isImageButton): New.
  • kwq/KWQAccObject.mm: (-[KWQAccObject isImageButton]): (-[KWQAccObject actionElement]): (-[KWQAccObject role]): (-[KWQAccObject accessibilityActionNames]): (-[KWQAccObject accessibilityPerformAction:]): Represent RenderImageButton elements as buttons instead of images.
12:12 PM Changeset in webkit [8485] by harrison
  • 2 edits in trunk/WebCore

Prevent nil dereference in debug code.

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayTree): Stop when parent is 0, too.
11:14 AM Changeset in webkit [8484] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/3949203> cannot tab to, within, or out of the RSS sidebar
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]): (-[KWQSlider nextKeyView]): (-[KWQSlider previousKeyView]): (-[KWQSlider canBecomeKeyView]): (-[KWQSlider nextValidKeyView]): (-[KWQSlider previousValidKeyView]): Copied these methods from KWQButton. The lack of special handling for first-responder-ness here was causing the focus to get "stuck" on the RSS page's slider widget. Added FIXME about how it would be nice to share more of this code rather than replicating it in each KWQ widget subclass.
10:58 AM Changeset in webkit [8483] by darin
  • 4 edits in trunk/WebCore

Reviewed by Harrison.

  • fixed <rdar://problem/3980066> Double-click on single character moves insertion point to previous line
  • khtml/khtml_part.cpp: (KHTMLPart::selectClosestWordFromMouseEvent): Set affinity too. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMouseMoveEventSelection): Ditto. (KHTMLPart::khtmlMouseReleaseEvent): Ditto.
  • khtml/editing/selection.cpp: (khtml::Selection::modifyExtendingRightForward): Use endOfLine and endOfDocument. (khtml::Selection::modifyMovingRightForward): Ditto. (khtml::Selection::modifyExtendingLeftBackward): Use startOfLine and startOfDocument. (khtml::Selection::modifyMovingLeftBackward): Ditto. (khtml::Selection::validate): Rewrote the section that handles double-click. Two main fixes: 1) use isStartOfLine to check for another case where we want to select the word to the right, and 2) use isEndOfParagraph, which seems to work correctly in cases where isLastVisiblePositionInParagraph is giving the wrong answer. Also changed the line code to use startOfLine/endOfLine and the document code to use startOfDocument/endOfDocument.
10:49 AM Changeset in webkit [8482] by darin
  • 2 edits in trunk/WebCore

Reviewed by Harrison.

  • fixed <rdar://problem/3935275> unexpected quit scrolling over link; last.fm (works in IE and Firefox)
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): By using the correct document, fix the crash reported here. The page still crashes when you close the browser window, but it's not trivial to fix so I'll file a new bug after that.
10:48 AM Changeset in webkit [8481] by jens
  • 2 edits in trunk/WebKit

[3903199] Large background patterns slide around while loading

10:03 AM Changeset in webkit [8480] by darin
  • 4 edits in trunk/WebCore

Reviewed by Ken and Harrison.

  • fixed <rdar://problem/3947901> REGRESSION (Mail): Pasting paragraph of rich text leaves insertion point before pasted text
  • fixed <rdar://problem/3949790> hitting return after underlined line results in too much or too little underlined
  • fixed <rdar://problem/3981759> nil-deref and crash when pasting just a paragraph break
  • fixed a couple problems I discovered while working with bug 3949790
  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyInlineStyle): Pass StayInBlock to upstream. Without this, we end up going too far upstream in the test case in bug 3949790. (khtml::ApplyStyleCommand::removeInlineStyle): Pass StayInBlock to upstream and downstream. Same reason as above. (khtml::ReplaceSelectionCommand::doApply): Update endPos if inserting a new node and endPos is using that node's parent and an offset past the node being inserted. That change fixes a problem with the position of the insertion point after pasting into the top level of a document (from test cases in 3947901 and 3949790). When setting insertionPos, use code that works when lastNodeInserted is a block rather than a text node. That change fixes a problem where a newline is not added when pasting an entire paragraph into the end of a document (from test case in 3949790). Added nil check before checking if lastNodeInserted is a <br> element, which fixes the crash when pasting just a paragraph break.
  • khtml/editing/visible_units.h: Filled out the set of calls to add some boolean checks for lines (needed for the bug fix), and calls for blocks (not yet implemented), and documents. The document checks may need refinement to properly handle documents with a mix of editable and non-editable content, but for now they just refactor code and make things a little clearer. Also removed the "include line break" parameter from endOfSentence.
  • khtml/editing/visible_units.cpp: (khtml::rootBoxForLine): Added. (khtml::startOfLine): Added. Algorithm taken from selectionForLine in selection.cpp. (khtml::endOfLine): Ditto. (khtml::inSameLine): Added. (khtml::isStartOfLine): Added. (khtml::isEndOfLine): Added. (khtml::endOfSentence): Removed "include line break" parameter. (khtml::inSameParagraph): Added a null check. (khtml::isStartOfParagraph): Ditto. (khtml::isEndOfParagraph): Ditto. (khtml::startOfBlock): Added. (khtml::endOfBlock): Added. (khtml::inSameBlock): Added. (khtml::isStartOfBlock): Added. (khtml::isEndOfBlock): Added. (khtml::startOfDocument): Added. (khtml::endOfDocument): Added. (khtml::inSameDocument): Added. (khtml::isStartOfDocument): Added. (khtml::isEndOfDocument): Added.

Jan 30, 2005:

10:21 AM Changeset in webkit [8479] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3977000> form data set posted for <input type="image" ...> omits name/value pair
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::appendFormData): Append a name/value pair for type IMAGE in addition to the X/Y coordinates.
10:08 AM Changeset in webkit [8478] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3974246> REGRESSION (125-180): popup menus are missing item text on Harmony Remote web site
  • khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::text): Change this function to traverse the entire tree and gather all the text rather than just looking at immediate children.
  • khtml/xml/dom_nodeimpl.h: Added const.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::traverseNextNode): Added const. (NodeImpl::traverseNextSibling): Ditto. (NodeImpl::traversePreviousNodePostOrder): Ditto. (NodeImpl::detach): Add a missing nil check.
9:52 AM Changeset in webkit [8477] by darin
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by John.

  • fixed <rdar://problem/3965265> Safari displays HTML as source when default encoding is Hebrew (due to direction overrides added by encoding converter)
  • WebView.subproj/WebPreferencesPrivate.h: Added _systemCFStringEncoding, and changed _setInitialDefaultTextEncodingToSystemEncoding to be a class method.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]): Added. New SPI to be used by Safari. Broken out of _setInitialDefaultTextEncodingToSystemEncoding, but also added cases for MacArabic and MacHebrew. (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Refactor to use _systemCFStringEncoding.

WebBrowser:

  • fixed <rdar://problem/3965265> Safari displays HTML as source when default encoding is Hebrew (due to direction overrides added by encoding converter)
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences awakeFromNib]): Use the new +[WebPreferences _systemCFStringEncoding] instead of CFStringGetSystemEncoding because the latter can return Mac-specific encodings that we never want to use.
  • TextEncodingMenu.m: (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Same as above.
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Update call to use class method.
9:33 AM Changeset in webkit [8476] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3864536> crash copying text from other apps and pasting in a sticky in dashboard
  • khtml/editing/markup.cpp: (khtml::createFragmentFromText): Added missing ref/deref of newly created element.

Jan 28, 2005:

4:38 PM Changeset in webkit [8475] by darin
  • 2 edits in trunk/WebCore
  • khtml/css/cssproperties.c: Regenerated with newer gperf.
4:13 PM Changeset in webkit [8474] by rjw
  • 4 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3980389> JavaScript bindings access incorrect runtime object

Only use special 'back door' property to get the runtime object if thisObj isn't
already a runtime object.

<gratuitous> Cleaned up a couple of strcmp on ClassInfo name. Used == on
ClassInfo pointer instead.

Reviewed by Chris.

  • bindings/c/c_utility.cpp: (convertValueToNPVariant):
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::call):
3:19 PM Changeset in webkit [8473] by jens
  • 3 edits in trunk/WebKit

[3727680] printing some page with WebKit generates a PDF with a 1x1 image with soft mask

3:02 PM Changeset in webkit [8472] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/3968144> AX need to be able to focus an AXLink by setting AXFocused to true

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject accessibilityIsAttributeSettable:]): Add AXFocused for AXLinks.
1:26 PM Changeset in webkit [8471] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch

Use AppKit SPI _accessibilityParentForSubview to return KWQAccObject parent of AppKit AX object.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _accessibilityParentForSubview:]): New.
1:04 PM Changeset in webkit [8470] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch

Use AppKit SPI _accessibilityParentForSubview to return KWQAccObject parent of AppKit AX object.

  • kwq/KWQAccObject.mm: (-[KWQAccObject _accessibilityParentForSubview:]): New.
11:30 AM Changeset in webkit [8469] by cblu
  • 4 edits in trunk/WebKit

WebKit side of: <rdar://problem/3951283> can view pages from the back/forward cache that should be disallowed by Parental Controls

Reviewed by john.

  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:shouldGoToHistoryItem:]): new private delegate method
  • WebView.subproj/WebFrame.m: (-[WebFrame _goToItem:withLoadType:]): call new delegate method
  • WebView.subproj/WebPolicyDelegatePrivate.h:
Note: See TracTimeline for information about the timeline view.