Timeline
Feb 4, 2005:
- 5:49 PM Changeset in webkit [8527] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
Rolled out Ken's accidental checkin when committing <rdar://problem/3986155> fix yesterday.
- khtml/editing/selection.cpp: (khtml::Selection::validate):
- 5:45 PM Changeset in webkit [8526] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Fix for <rdar://problem/3758785> Safari no longer works at BankOfAmerica online banking for military users
When closing the document, if a body doesn't exist we now create one. This bug was preventing the onload handler from
firing in cases where there wasn't a body. In the BankOfAmerica case, the page was just a bit of script where the onload
handler redirected to the correct page.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::close):
- 2:41 PM Changeset in webkit [8525] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3802781> rtf->html pasteboard conversion using xhtml
Reviewed by kocienda.
- WebView.subproj/WebHTMLView.m: (+[WebHTMLView _excludedElementsForAttributedStringConversion]): new (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call _excludedElementsForAttributedStringConversion
- 2:18 PM Changeset in webkit [8524] by
-
- 6 edits12 adds in trunk
Reviewed by Chris
Fix for this bug:
<rdar://problem/3986155> Insertion point goes to beginning of doc after deleting
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::setStartNode): New convenience to handle reference counting when setting. (khtml::DeleteSelectionCommand::handleGeneralDelete): This contains the crux of the bug fix. Improve tests that detect when a selected node needs to be retained, rather than deleted, to preserve the intent of the user. This has the side effect of causing the insertion point placement code to succeed rather than fail. Before this fix, the failure of the insertion point placement code caused the insertion point to jump to the start of the document, which is the symptom that can be perceived by users when editing.
- khtml/editing/htmlediting.h: Add setStartNode declaration.
- khtml/editing/visible_units.cpp: (khtml::startOfBlock): This function had a stubbed-in non-tested implementation. Implement and
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-001.html: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-002.html: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-003.html: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-004.html: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-005.html: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt: Added.
- layout-tests/editing/deleting/delete-at-paragraph-boundaries-006.html: Added.
- 10:45 AM Changeset in webkit [8523]
-
- 3 copies in tags/Safari-183
This commit was manufactured by cvs2svn to create tag 'Safari-183'.
- 10:45 AM Changeset in webkit [8522] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Move the Safari-183 marker in the ChangeLog, since we're going to include <rdar://problem/3972905> in today's Safari-183 submission
- 10:25 AM Changeset in webkit [8521] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3832973> copy text from PowerPoint, paste into Blot (or presumably Mail) and get a single missing image icon
Reviewed by john.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): prefer RTF and RTFD over images just as NSTextView does
Feb 3, 2005:
- 5:44 PM Changeset in webkit [8520] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3555137> REGRESSION (125-173): Flash animation can erase parts of chrome (bookmarks bar & tab bar)
convertRect:toView: returns incorrect results inside of viewWillMoveToWindow: with a nil window. Workaround this by catching this case.
Reviewed by darin.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): new (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): clip out the plug-in view when superviewsHaveSuperviews returns NO
- 5:41 PM Changeset in webkit [8519] by
-
- 2 edits in trunk/JavaScriptCore
Fixed <rdar://problem/3972905> CrashTracer: ...36 crashes at com.apple.WebCore: khtml::CSSStyleSelector::applyDeclarations + 120
Revert to old (and correct) behavior of returning runtime object
when passed as a parameter, rather than it's corresponding DOM
object.
Reviewed by Chris.
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
- 4:02 PM Changeset in webkit [8518] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3893513> Sun iPlanet app: when saving to a file it brings up a window with the thing to be saved instead
Reviewed by adele.
- WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/ldif" to the list of MIME types that our text view doesn't handle
- 3:57 PM Changeset in webkit [8517] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (183+)
The tree is open!
- 3:46 PM Changeset in webkit [8516] by
-
- 6 edits in trunk
Safari-183 stamp
- 2:22 PM Changeset in webkit [8515] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3987419> Stocks and Weather leak what appears to XMLHTTPRequest results
XMLHTTPRequests were causing massive leaks. _webcore_initWithHeaderString: did funky things with
self replacement. Re-wrote to use more traditional factory constructor avoiding self replacement.
Reviewed by David Harrison.
- kwq/KWQLoader.mm: (+[NSDictionary _webcore_dictionaryWithHeaderString:]): (KWQServeRequest): (KWQServeSynchronousRequest):
- 2:09 PM Changeset in webkit [8514] by
-
- 2 edits in trunk/WebKit
- English.lproj/StringsNotToBeLocalized.txt: updated
- 1:59 PM Changeset in webkit [8513] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3989611> Evite style "add vCalendar to calendar" do not work
Reviewed by adele.
- WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/x-vcalendar" to the list of MIME types our text view doesn't handle
- 11:56 AM Changeset in webkit [8512] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3938763> Cannot view Windows Media Player videos (soundtrack is played twice with delay)
Reviewed by hyatt.
- khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): set needWidgetUpdate to false right after calling updateWidget because dispatchHTMLEvent can end up calling this method again (HTMLObjectElementImpl::recalcStyle): ditto
- 10:17 AM Changeset in webkit [8511] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
- fix deployment build breakage on Panther
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView toggleBaseWritingDirection:]):
Feb 2, 2005:
- 5:44 PM Changeset in webkit [8510] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris.
- WebKit part of fix for <rdar://problem/3980651> REGRESSION (125-180): Huge number of pages printed from certain page, iFrame involved
This also fixes the problems with printing from GMail, yay!
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): Don't adjust margins for header/footer here, because this is called for each subframe. (-[WebHTMLView knowsPageRange:]): Do adjust margins for header/footer here (analogous to WebTextView and WebImageView). Also, round the page height to an integer here (noticed in passing).
- 5:44 PM Changeset in webkit [8509] by
-
- 3 edits in trunk/WebCore
Reviewed by Chris.
- WebCore part of fix for <rdar://problem/3980651> REGRESSION (125-180): Huge number of pages printed from certain page, iFrame involved
This also fixes the problems with printing from GMail, yay!
- khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): If the current line is taller than the entire page height (e.g. tall iFrame), don't try to avoid splitting it across pages.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): Handle error cases in a more obvious manner; this will cause future problems like this to print a blank page and complain to the console on debug builds, rather than print a zillionty mostly-blank pages.
- 4:47 PM Changeset in webkit [8508] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3960304> can't load a particular applet (at www.escape.de) unless it's the first applet to be loaded
Reviewed by hyatt.
- khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): when getting the MIME type from the PARAM tag, make sure the MIME type is the text from the left of the semi-colon if there is one. We do this elsewhere as well.
- 4:14 PM Changeset in webkit [8507] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3986546> Cut, delete, and paste menu items are active when a image is opened in window
Reviewed by john.
- WebView.subproj/WebView.m: (-[WebView _responderValidateUserInterfaceItem:]): new, has the responder validate the item (-[WebView validateUserInterfaceItem:]): call VALIDATE for each repsonder selector using FOR_EACH_RESPONDER_SELECTOR macro (-[WebView _performResponderOperation:with:]): call factored out method _responderForResponderOperations (-[WebView _responderForResponderOperations]): new, code from _performResponderOperation:with:
- 2:01 PM Changeset in webkit [8506] by
-
- 8 edits in trunk
WebCore:
Fixed: <rdar://problem/3983628> control-click on WebView is not selecting the word under the cursor (Mail, non-editable WebView)
Reviewed by rjw.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): check if SPI to always enable selecting closest word is enabled
- kwq/WebCoreBridge.h:
WebKit:
Fixed: <rdar://problem/3983628> control-click on WebView is not selecting the word under the cursor (Mail, non-editable WebView)
Reviewed by rjw.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge selectWordBeforeMenuEvent]): new
- WebView.subproj/WebView.m: (-[WebView _selectWordBeforeMenuEvent]): new SPI (-[WebView _setSelectWordBeforeMenuEvent:]): new SPI
- WebView.subproj/WebViewInternal.h:
- WebView.subproj/WebViewPrivate.h:
- 1:31 PM Changeset in webkit [8505] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3986013> Assertion failure going back after page load error (no apparent problem in nondebug build)
Reviewed by rjw.
- WebView.subproj/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]): don't set the data source data when the main client is nil
- 11:53 AM Changeset in webkit [8504] by
-
- 2 edits in trunk/WebCore
Reviewed by me
- khtml/editing/markup.cpp: (khtml::createMarkup): Removed debug spam I committed earlier in error.
- 11:23 AM Changeset in webkit [8503] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Missed adding changelog comments for one of a batch of fixes I landed
- 11:09 AM Changeset in webkit [8502] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin
Fix for this bug:
<rdar://problem/3823109> WebKit should support -toggleBaseWritingDirection: (bidi editing support)
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]): New function that calls through to new feature that allows callers to force all properties in a style to be applied as block styles. (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): Removed FIXME comment for something that has been fixed. (-[WebHTMLView toggleBaseWritingDirection:]): Implemented.
- 11:09 AM Changeset in webkit [8501] by
-
- 11 edits in trunk/WebCore
Reviewed by Darin
Fix for this bug:
<rdar://problem/3823109> WebKit should support -toggleBaseWritingDirection: (bidi editing support)
Since base writing direction is a paragraph-level property in AppKit, and we use the CSS direction
property in WebCore, which can be applied to inline elements as well as blocks, a new notion has
been added to the WebCore apply style logic. It is now possible to force all properties in a
style declaration to be applied as though they were block properties.
- khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::ApplyStyleCommand): Add an enum and a flag to this command that controls whether to force all properties in the style to be applied as block styles. Default is "no", retaining previous behavior. (khtml::ApplyStyleCommand::doApply): Switch on new flag to apply styles as before, or force all preoperties to be applied as block styles.
- khtml/editing/htmlediting.h: (khtml::ApplyStyleCommand::): Add an enum and a flag, as above.
- khtml/khtml_part.cpp: (KHTMLPart::applyParagraphStyle): New method to force application of all style properties as block styles.
- khtml/khtml_part.h: Update header declarations.
- kwq/KWQKHTMLPart.h: Update header declarations.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::baseWritingDirectionForSelectionStart): Accessor to help WebKit do a toggle operation on writing direction.
- kwq/WebCoreBridge.h: Update header declarations.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge applyParagraphStyle:withUndoAction:]): New method to force application of all style properties as block styles. (-[WebCoreBridge baseWritingDirectionForSelectionStart]): Accessor to help WebKit do a toggle operation on writing direction.
Feb 1, 2005:
- 6:51 PM Changeset in webkit [8500] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3985535> QT Plug-in JavaScript support now fails in <embed> tag only case
Reviewed by Maciej.
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet):
- 6:13 PM Changeset in webkit [8499] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3977727> WebKit should use new SPI to support faster GIF rendering
Note: This REQUIRES build >= 3A362 when building on Tiger.
Reviewed by John.
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]):
- 5:54 PM Changeset in webkit [8498] by
-
- 2 edits in trunk/WebCore
Written by Darin, reviewed and tested by me
- fixed <rdar://problem/3969684> Panther-only: extra blank lines between pasted content from Blot
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): don't emit paragraph breaks if the margins are tiny; matches what we do for plain-text conversion
- 5:06 PM Changeset in webkit [8497] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (182+)
the tree is open!
- 4:50 PM Changeset in webkit [8496]
-
- 1 copy in tags/Safari-182
This commit was manufactured by cvs2svn to create tag 'Safari-182'.
- 4:50 PM Changeset in webkit [8495] by
-
- 6 edits in trunk
Safari-182 stamp
- 3:06 PM Changeset in webkit [8494] by
-
- 1 edit in trunk/WebKit/WebView.subproj/WebViewPrivate.h
Additional part of last checkin that I missed.
- 2:28 PM Changeset in webkit [8493] by
-
- 4 edits in trunk/WebKit
WebKit:
Added new SPI for <rdar://problem/3967063> need spi on WebView to turn of lcd text for Dashboard
Reviewed by Chris.
- WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs):
- WebView.subproj/WebView.m: (-[WebView drawRect:]): (-[WebView _dashboardBehavior:]): (+[WebView _setShouldUseFontSmoothing:]): (+[WebView _shouldUseFontSmoothing]):
- WebView.subproj/WebViewInternal.h:
- WebView.subproj/WebViewPrivate.h:
WebBrowser:
Used new SPI (from <rdar://problem/3967063> need spi on WebView to turn of lcd text for Dashboard)
Reviewed by Chris.
- EtchedStringButtonCell.m: (-[EtchedStringButtonCell drawInteriorWithFrame:inView:]):
- 1:23 PM Changeset in webkit [8492] by
-
- 13 edits in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3985160> Deficiencies in pasting architecture blocking progress on other bugs
- khtml/editing/html_interchange.h: Move style span text used to mark element added to add style to this header.
- khtml/editing/htmlediting.cpp: (khtml::styleSpanClassString): Change to use constant moved to html_interchange.h. (khtml::isStyleSpan): New helper function. Checks if this is a span we added to apply style. (khtml::CompositeEditCommand::insertNodeBefore): Added an assert to check that the node we are inserting before is not the body. (khtml::CompositeEditCommand::insertNodeAfter): Ditto, but check is for after. (khtml::ReplacementFragment::ReplacementFragment): Added code to process the "default style" that is added by the copy code. (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): first and last nodes inserted are now member variables instead of function locals. Initialize them here. (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand): Deref first and last nodes inserted if necessary. (khtml::ReplaceSelectionCommand::doApply): Change design to fix the bug. Major change is to separate out the code that inserts nodes into the tree so additional styling checks can be done in a centralized way. Also got rid of the notion of "merging into the end block." That concept was just wrong. (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Tweak interface now that first and last nodes inserted are member variables. (khtml::ReplaceSelectionCommand::insertNodeAfterAndUpdateNodesInserted): New helper used by replace code to do the stated DOM operation and update state internal to the command. This will also be a catch point to handle the kinds of additional style checks needed to make paste work right. (khtml::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted): Ditto. (khtml::ReplaceSelectionCommand::insertNodeBeforeAndUpdateNodesInserted): Ditto. (khtml::ReplaceSelectionCommand::updateNodesInserted): Ditto.
- khtml/editing/htmlediting.h: Update declarations as needed.
- khtml/editing/markup.cpp: (khtml::createMarkup): Adds a "default style" span to the content written to the pasteboard. This will help us to fix some of the bugs blocked by the bug above.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::lastDescendent): New helper.
- khtml/xml/dom_nodeimpl.h: Ditto.
- khtml/xml/dom_position.cpp: (DOM::Position::upstream): Fixed a bug which would allow the upstream position returned to be in unrendered content. (DOM::Position::downstream): Ditto.
- layout-tests/editing/deleting/delete-3775172-fix-expected.txt: Ending positions tweaked due to changes in upstream() and downstream() functions.
- layout-tests/editing/inserting/insert-3851164-fix-expected.txt: Ditto
- layout-tests/editing/inserting/insert-3907422-fix-expected.txt: Ditto
- layout-tests/editing/selection/extend-by-character-006-expected.txt: Ditto
- layout-tests/editing/pasteboard/paste-text-003-expected.txt: Changed what we expect, given new behavior of paste code.
