Timeline



Feb 8, 2005:

6:11 PM Changeset in webkit [8549] by rjw
  • 1 edit in branches/Safari-1-2-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

More changes for Java update.

6:05 PM Changeset in webkit [8548] by rjw
  • 2 edits in branches/Safari-1-2-branch/JavaScriptCore/bindings

More stuff for Java update.

5:45 PM Changeset in webkit [8547] by rjw
  • 23 edits
    2 deletes in branches/Safari-1-2-branch/JavaScriptCore

ck-ported Java LiveConnect implementation from Tiger/SUPanWheat.

Reviewed by Darin.

  • JavaScriptCore.pbproj/project.pbxproj:
  • Makefile.am:
  • bindings/jni/jni_class.cpp: (JavaClass::methodsNamed): (JavaClass::fieldNamed):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::invokeMethod): (JavaInstance::invokeDefaultMethod):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_jsobject.cpp: Added. (isJavaScriptThread): (JSObject::invoke): (JSObject::JSObject): (JSObject::call): (JSObject::eval): (JSObject::getMember): (JSObject::setMember): (JSObject::removeMember): (JSObject::getSlot): (JSObject::setSlot): (JSObject::toString): (JSObject::finalize): (JSObject::createNative): (JSObject::convertValueToJObject): (JSObject::convertJObjectToValue): (JSObject::listFromJArray):
  • bindings/jni/jni_jsobject.h: Added. (KJS::Bindings::):
  • bindings/jni/jni_objc.mm: Added. (convertNSStringToString): (KJS::Bindings::dispatchJNICall): (KJS::Bindings::getLastPolledView): (pollForAppletInView): (initializeWorkaround):
  • bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaArray::convertJObjectToArray): (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance): (JavaMethod::JavaMethod): (JavaArray::JavaArray): (JavaArray::valueAt):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaString::JavaString): (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring): (KJS::Bindings::JavaMethod::returnType): (KJS::Bindings::JavaMethod::isStatic): (KJS::Bindings::JavaArray::operator=): (KJS::Bindings::JavaArray::executionContext):
  • bindings/jni/jni_utility.cpp: (callJNIStaticMethod): (KJS::Bindings::getMethodID): (KJS::Bindings::callJNIStaticBooleanMethod): (KJS::Bindings::getJNIField): (KJS::Bindings::convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/jni_jsobject.cpp: Removed.
  • bindings/jni_jsobject.h: Removed.
  • bindings/runtime.cpp: (MethodList::MethodList): (MethodList::operator=): (Instance::setDidExecuteFunction): (Instance::didExecuteFunction): (Instance::getValueOfField): (Instance::setValueOfField): (Instance::createBindingForLanguageInstance): (Instance::createRuntimeObject): (Instance::Instance): (Instance::operator=):
  • bindings/runtime.h: (KJS::Bindings::Class::fallbackObject): (KJS::Bindings::Instance::): (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::supportsSetValueOfUndefinedField): (KJS::Bindings::Instance::setValueOfUndefinedField): (KJS::Bindings::Instance::valueOf): (KJS::Bindings::Instance::setExecutionContext): (KJS::Bindings::Instance::executionContext):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::RuntimeArrayImp): (RuntimeArrayImp::get):
  • bindings/runtime_array.h:
  • bindings/runtime_method.cpp: (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::call):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::implementsCall): (RuntimeObjectImp::call):
  • bindings/runtime_object.h:
  • kjs/ustring.cpp: (KJS::CString::operator=):
5:45 PM Changeset in webkit [8546]
  • 5 copies in branches/Safari-1-2-branch/JavaScriptCore/bindings

This commit was manufactured by cvs2svn to create branch
'Safari-1-2-branch'.

3:41 PM Changeset in webkit [8545] by vicki
  • 3 edits in trunk

Versioning for TOT, Safari 2.0 (185+). The tree is open.

3:31 PM Changeset in webkit [8544]
  • 1 copy in tags/Safari-185

This commit was manufactured by cvs2svn to create tag 'Safari-185'.

3:31 PM Changeset in webkit [8543] by vicki
  • 6 edits in trunk

Safari-185 stamp (can't use 184 b/c of the "4", of course)

9:33 AM Changeset in webkit [8542] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3996344> Entire document content is deleted when only the first paragraph was supposed to be

Problem stems from my attempt to fix this bug: <rdar://problem/3986155> Insertion point goes
to beginning of doc after deleting.

I added an "optimization" that proved to do more harm than good. So, basically, the fix is to remove code.

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete)
8:53 AM Changeset in webkit [8541] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by Kevin.

  • fixed <rdar://problem/3890352> REGRESSION (125-170, Panther-only): pasted textarea contents disappear (exception in NSText)
  • kwq/KWQTextArea.mm: (-[KWQTextArea tile]): Don't resize the text view immediately here. Use performWithDelay to defer it to avoid the re-entrancy that bothers the Panther version of NSTextView. On Tiger, leave the code alone.
8:52 AM Changeset in webkit [8540] by darin
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • fixed <rdar://problem/3890352> REGRESSION (125-170, Panther-only): pasted textarea contents disappear (exception in NSText)
  • kwq/KWQTextArea.mm: (-[KWQTextArea tile]): Don't resize the text view immediately here. Use performWithDelay to defer it to avoid the re-entrancy that bothers the Panther version of NSTextView. On Tiger, leave the code alone.

Feb 7, 2005:

5:33 PM Changeset in webkit [8539] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/3993628> REGRESSION (180-181): Logitelnet bank's website doesn't work

This fixes an oversight in the fix for <rdar://problem/3964286>.
We're now making sure there is a document before calling checkCompleted in slotLoaderRequestDone.

That function is called even when other parts finish loads of their subresources, so we could end

up calling checkCompleted before we had a document. We also looked over all the other calls to
checkCompleted to convince ourselves no other call sites had a similar issue.

  • khtml/khtml_part.cpp: (KHTMLPart::slotLoaderRequestDone): Check if doc is nil before calling checkCompleted.
2:42 PM Changeset in webkit [8538] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3993354> Safari claims to put RTFD on the pasteboard, but doesn't, in some cases

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _stripAttachmentCharactersFromAttributedString:]): moved (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): take cachedAttributedString parameter in case the attributed string was gotten already (-[WebHTMLView _writeSelectionToPasteboard:]): omit RTFD from the types list when there are no attachments
1:09 PM Changeset in webkit [8537] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Ken.

<rdar://problem/3990693> REGRESSION (8A373): ctrl-k now deletes just one character instead of line

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Set the selection so that deleteKeyPressedWithSmartDelete knows what to delete.
8:32 AM Changeset in webkit [8536] by kocienda
  • 11 edits in trunk

Reviewed by Darin

Fix for this bug:

<rdar://problem/3953302> Replacing quoted text ends up with blue-colored text that is not quoted

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::doApply): Removed special case delete code for select all. It was causing as many bugs as it fixed. What's more, the design concept is a bit shaky. By removing this special case, the bug goes away.
  • khtml/editing/htmlediting.h: Remove declaration.

Test results using selectAll() updated to reflect changed behavior.

  • layout-tests/editing/deleting/delete-3775172-fix-expected.txt:
  • layout-tests/editing/deleting/delete-select-all-001-expected.txt:
  • layout-tests/editing/deleting/delete-select-all-003-expected.txt:
  • layout-tests/editing/inserting/insert-3654864-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3775316-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3851164-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3907422-fix-expected.txt:
  • layout-tests/editing/pasteboard/paste-text-015-expected.txt:
8:26 AM Changeset in webkit [8535] by darin
  • 4 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3994164> setting a new style attribute with setAttribute("style") doesn't blow away the old style
  • khtml/css/css_valueimpl.h: Renamed parseProperty to parseDeclaration, since it's used to parse an entire style declaration, not a single property.
  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::parseDeclaration): Renamed, and added code to clear m_values.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Call function by its new name, and remove some unnecessary comments.

Feb 6, 2005:

10:44 PM Changeset in webkit [8534] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3993722> need oncut and onpaste handlers implemented for <textarea> (needed for widgets)
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView dispatchHTMLEvent:]): Added. (-[KWQTextAreaTextView cut:]): Dispatch "before cut" and "cut" events. (-[KWQTextAreaTextView copy:]): Dispatch "before copy" and "copy" events. (-[KWQTextAreaTextView paste:]): Dispatch "before paste" and "paste" events. (-[KWQTextAreaTextView pasteAsPlainText:]): Ditto. (-[KWQTextAreaTextView pasteAsRichText:]): Ditto.
10:37 PM Changeset in webkit [8533] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3943038> <input type=search> that is focused in onload handler doesn't have a visible editor
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Always update layout before giving focus to a widget. This prevents the bad case where we give a widget focus before it has been positioned or sized, causing us to exercise edge cases AppKit doesn't handle well.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): Remove workaround code I added to fix bug 3943049. Updating the layout fixes the same problem in a cleaner, safer way, and solves another problem, with the way the clip view is set up.
10:31 PM Changeset in webkit [8532] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3425232> textarea won't trigger onchange action when clicking to new field
  • khtml/rendering/render_form.h: Added new m_dirty data member.
  • khtml/rendering/render_form.cpp: (RenderTextArea::RenderTextArea): Initialize m_dirty to false. (RenderTextArea::detach): Call value() on the DOM element to cause it to fetch the value from this object. (RenderTextArea::handleFocusOut): Ditto. Also send the onchange event based only on the m_dirty flag. (RenderTextArea::updateFromElement): Clear the m_dirty flag if the edited value is blown away by a value that comes from the DOM element. Remove code to clear the element's m_dirtyvalue flag; that's an unnecessary optimization, and ideally we'll stop having code in the render object that knows about that flag later. (RenderTextArea::slotTextChanged): Set the m_dirty flag.
10:26 PM Changeset in webkit [8531] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • re-fixed <rdar://problem/3760910> please add support for custom tag names in HTML
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::tagId): Use ID_LAST_TAG + 1 for the ID of the first assigned tag ID. Before we'd use ID_LAST_TAG, which resulted in the same number being used for ID_COMMENT and the first custom tag. (DocumentImpl::tagName): Use ID_LAST_TAG + 1, as above. (DocumentImpl::namespaceURI): Change a < ID_LAST_TAG to <= ID_LAST_TAG in the same spirit as above.
10:18 PM Changeset in webkit [8530] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3986639> Crash occurs after choosing Undo Typing from the Edit menu
  • kwq/KWQTextArea.mm: (-[KWQTextArea viewWillMoveToWindow:]): Remove actions from undo manager when the view is removed from the window. Unfortunately, to do this the code has to know that the target of NSTextView actions will be the text storage object, but given the NSText architecture, that's pretty clear.
10:13 PM Changeset in webkit [8529] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed <rdar://problem/3963166> PDFView SPI print method is being deprecated, moving to PDFDocument; please update WebKit
  • WebView.subproj/WebPDFView.m: (-[WebPDFView printOperationWithPrintInfo:]): Target the document instead of the view.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes and also moved one translation to be a file-specific item rather than a file-independent one.
12:19 PM Changeset in webkit [8528] by cblu
  • 6 edits in trunk

WebCore:

Fixed: <rdar://problem/3991974> REGRESSION: www.jabra.com world location screen does not work

Reviewed by hyatt.

  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): fallback to the document's base URL if there is no baseURL attribute
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge baseURL]): new

WebKit:

Fixed: <rdar://problem/3991974> REGRESSION: www.jabra.com world location screen does not work

Reviewed by hyatt.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): use the baseURL from the bridge rather than from the response

Feb 4, 2005:

5:49 PM Changeset in webkit [8527] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Rolled out Ken's accidental checkin when committing <rdar://problem/3986155> fix yesterday.

  • khtml/editing/selection.cpp: (khtml::Selection::validate):
5:45 PM Changeset in webkit [8526] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/3758785> Safari no longer works at BankOfAmerica online banking for military users

When closing the document, if a body doesn't exist we now create one. This bug was preventing the onload handler from
firing in cases where there wasn't a body. In the BankOfAmerica case, the page was just a bit of script where the onload
handler redirected to the correct page.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::close):
2:41 PM Changeset in webkit [8525] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3802781> rtf->html pasteboard conversion using xhtml

Reviewed by kocienda.

  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _excludedElementsForAttributedStringConversion]): new (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call _excludedElementsForAttributedStringConversion
2:18 PM Changeset in webkit [8524] by kocienda
  • 6 edits
    12 adds in trunk

Reviewed by Chris

Fix for this bug:

<rdar://problem/3986155> Insertion point goes to beginning of doc after deleting

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::setStartNode): New convenience to handle reference counting when setting. (khtml::DeleteSelectionCommand::handleGeneralDelete): This contains the crux of the bug fix. Improve tests that detect when a selected node needs to be retained, rather than deleted, to preserve the intent of the user. This has the side effect of causing the insertion point placement code to succeed rather than fail. Before this fix, the failure of the insertion point placement code caused the insertion point to jump to the start of the document, which is the symptom that can be perceived by users when editing.
  • khtml/editing/htmlediting.h: Add setStartNode declaration.
  • khtml/editing/visible_units.cpp: (khtml::startOfBlock): This function had a stubbed-in non-tested implementation. Implement and
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-001.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-002.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-003.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-004.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-005.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-006.html: Added.
10:45 AM Changeset in webkit [8523]
  • 3 copies in tags/Safari-183

This commit was manufactured by cvs2svn to create tag 'Safari-183'.

10:45 AM Changeset in webkit [8522] by vicki
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Move the Safari-183 marker in the ChangeLog, since we're going to include <rdar://problem/3972905> in today's Safari-183 submission

10:25 AM Changeset in webkit [8521] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3832973> copy text from PowerPoint, paste into Blot (or presumably Mail) and get a single missing image icon

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): prefer RTF and RTFD over images just as NSTextView does
Note: See TracTimeline for information about the timeline view.