Timeline
Feb 16, 2005:
- 5:39 PM Changeset in webkit [8605] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3954842> Forward/reply to an HTML email can result in nothing (in cases with <link> tags for CSS)
Reviewed by john.
- khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::addChild): don't call insertedIntoDocument on the added child if "this" itself is not in the document.
- 5:34 PM Changeset in webkit [8604] by
-
- 3 edits in trunk/WebCore
Written by Darin, reviewed by Maciej and me
- change required to make previous checkin work with English language RSS pages
- kwq/KWQKURL.h: new private method isHierarchical
- kwq/KWQKURL.mm: (KURL::KURL): add hierarchical base URL check when determining whether the URL is absolute (KURL::isHierarchical): new method, returns true if this is a valid URL with a slash just past the scheme's trailing colon
- 4:55 PM Changeset in webkit [8603] by
-
- 1 edit in trunk/JavaScriptCore/kjs/date_object.cpp
- added extensions to toLocalString, toLocaleTimeString, toLocaleDateString to give more control over date formating (4007277)
- 4:15 PM Changeset in webkit [8602] by
-
- 2 edits in trunk/WebKit
Written by Darin, reviewed by me.
- WebKit part of fix for <rdar://problem/4007384> FILTER: Bookmark of RSS with Japanese search word & multiple RSS pages loses filter
- DOM.subproj/DOMPrivate.h: updated this file, which is a copy of the WebCore version
- 4:14 PM Changeset in webkit [8601] by
-
- 3 edits in trunk/WebCore
Written by Darin, reviewed by me.
- WebCore part of fix for <rdar://problem/4007384> FILTER: Bookmark of RSS with Japanese search word & multiple RSS pages loses filter
- kwq/DOM.mm: (-[DOMElement _getURLAttribute:]): new SPI method, uses parseURL and completeURL to get valid URL from attribute value
- kwq/DOMPrivate.h: declare new SPI method
- 1:20 PM Changeset in webkit [8600] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3966973> Tiger 8A357: Binary Compatiblity: frequent Webstractor.app crashes [WebImageData _nextFrame]
Webstractor.app was playing tricks to create thumbnails of
pages. This caused the 'focusView' to be incorrect during
animated GIF frame rendering.
Reviewed by Chris.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer _startOrContinueAnimationIfNecessary]):
- 11:55 AM Changeset in webkit [8599] by
-
- 2 edits in trunk/WebKit
Reviewed by me, code change by Darin.
- fixed the build on Panther
- WebView.subproj/WebFormDataStream.m: (webSetHTTPBody): Added a Panther-specific code path that just loads all the data into one big NSData object. This means that bug 3686434 won't be fixed on SUPanWheat; we'll still load the file into memory before sending it to the server on Panther.
Feb 15, 2005:
- 4:31 PM Changeset in webkit [8598] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3998368> Tiger8A376: WebTextRenderer assertion failure in Safari while browsing news.bbc.co.uk
Removed use of FATAL_ALWAYS from getUncachedWidth(). It's unclear
why we would trigger the FATAL_ALWAYS. In the past we've seen
the message triggered because of corrupt fonts. Anyway, in this
particular case, we will now return 0 for the character width,
rather than exiting.
Reviewed by David Harrison.
- WebCoreSupport.subproj/WebTextRenderer.m: (getUncachedWidth):
- 3:48 PM Changeset in webkit [8597] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/3942428> reproducible crash loading cbs.sportsline.com
This change reverts the fix for <rdar://problem/3805311>, and
re-fixes it in a different (better) way. Instead of preventing
programmatic open from setting the parsing flag, instead make sure
that programmatic close resets it.
- khtml/khtml_part.cpp: (KHTMLPart::openURL): (KHTMLPart::didExplicitOpen): (KHTMLPart::closeURL): (KHTMLPart::begin): (KHTMLPart::end): (KHTMLPart::endIfNotLoading): (KHTMLPart::slotFinishedParsing): (KHTMLPart::checkEmitLoadEvent):
- khtml/khtml_part.h:
- khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::open): (DocumentImpl::implicitOpen): (DocumentImpl::close): (DocumentImpl::implicitClose):
- khtml/xml/dom_docimpl.h:
- 3:41 PM Changeset in webkit [8596] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
<rdar://problem/3933665> smart delete seems to delete too much after expanding selection with arrow keys
Fixed by updating the selection granularity. Only byWord granularity enables smart delete, but in this
case the granularity changed from byWord to byCharacter.
- khtml/khtml_part.cpp: (KHTMLPart::setSelectionGranularity):
- khtml/khtml_part.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreBridge alterCurrentSelection:direction:granularity:]):
- 3:31 PM Changeset in webkit [8595] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
(continued) <rdar://problem/4004305> REGRESSION (Mail): Command-right-arrow on wrapped text goes to end of previous line
This was supposed have been committed yesterday with the other part of the fix, but was not.
- khtml/editing/visible_units.cpp: (khtml::endOfWord):
- 2:53 PM Changeset in webkit [8594] by
-
- 4 edits in trunk/WebKit
Fixed <rdar://problem/3999467> when Osaka-Mono is specified as fixed width font, Osaka used instead
Lie about Osaka-Mono. Treat it as fixed pitch, even though,
strictly speaking it isn't. (Similar to what we do with
Courier New.)
Reviewed by David Harrison.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _computeWidthForSpace]):
- WebCoreSupport.subproj/WebTextRendererFactory.h:
- WebCoreSupport.subproj/WebTextRendererFactory.m: (-[NSFont _web_isFakeFixedPitch]): (-[WebTextRendererFactory isFontFixedPitch:]): (-[WebTextRendererFactory fontWithFamily:traits:size:]):
- 9:01 AM Changeset in webkit [8593] by
-
- 4 edits2 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/3951178> REGRESSION (Mail): blank line lost after pasting as quotation
Problem was that the blank line after the selection was getting deleted incorrectly since the
paste code thought this was an unneeded placeholder rather than a placeholder outside of the
selection.
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Now calls findBlockPlaceholder. (khtml::CompositeEditCommand::findBlockPlaceholder): Moved finding code formerly in removeBlockPlaceholderIfNeeded to this new helper. (khtml::ReplaceSelectionCommand::doApply): Do not delete placeholder up front. Call findBlockPlaceholder, and delete it later if needed in the already-existing cleanup step.
- khtml/editing/htmlediting.h: Add new function.
New layout test.
- layout-tests/editing/pasteboard/paste-text-017-expected.txt: Added.
- layout-tests/editing/pasteboard/paste-text-017.html: Added.
Result changed for the better.
- layout-tests/editing/pasteboard/paste-text-011-expected.txt
Feb 14, 2005:
- 5:52 PM Changeset in webkit [8592] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4004305> REGRESSION (Mail): Command-right-arrow on wrapped text goes to end of previous line
- khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::advance): Add BR in for <rdar://problem/3917929> fix only if leaving a visible text node.
- khtml/editing/visible_units.cpp: (khtml::endOfWord): Do not move left over a paragraph boundary.
- 1:09 PM Changeset in webkit [8591] by
-
- 6 edits4 deletes in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3686434> Safari uses too much RAM on file upload, leading to malloc errors and crashes (HP printers)
- khtml/html/html_formimpl.cpp: (DOM::FormDataList::begin): Updated to use a list of FormDataListItem instead of QCString. (DOM::FormDataList::end): Ditto. (DOM::HTMLFormElementImpl::formData): Same here, and also use appendFile rather than appendData when we encounter a path name rather than data. (DOM::HTMLInputElementImpl::appendFormData): Use appendFile here rather than reading the file in; the reading now happens inside WebKit. (DOM::FormDataList::appendString): Updated for FormDataListItem. (DOM::FormDataList::appendFile): Added.
- ForwardingHeaders/kfileitem.h: Emptied out the file; no longer includes KWQKFileItem.h.
- ForwardingHeaders/netaccess.h: Emptied out the file; no longer includes KWQKIONetAccess.h.
- kwq/KWQKFileItem.h: Removed.
- kwq/KWQKFileItem.mm: Removed.
- kwq/KWQKIONetAccess.h: Removed.
- kwq/KWQKIONetAccess.mm: Removed.
- WebCore.pbproj/project.pbxproj: Removed the 4 files above.
- small unrelated fix (not reviewed by John)
- khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Put some logging code outside if statements so it works all the time.
- 12:06 PM Changeset in webkit [8590] by
-
- 8 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3686434> Safari uses too much RAM on file upload, leading to malloc errors and crashes (HP printers)
- WebView.subproj/WebFormDataStream.h: Added webSetHTTPBody, which creates and connects an appropriate stream to an NSMutableURLRequest.
- WebView.subproj/WebFormDataStream.m: Added implementation here.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Use webSetHTTPBody.
- WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Use webSetHTTPBody.
- WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Use webSetHTTPBody. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
- English.lproj/StringsNotToBeLocalized.txt: Updated for this change and other recent changes.
- 10:19 AM Changeset in webkit [8589] by
-
- 28 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4004305> REGRESSION (Mail): Command-right-arrow on wrapped text goes to end of previous line
Fixed nextLinePosition to calculate affinity rather than take it as a parameter. Propagated the parameter change out to related methods.
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::InsertLineBreakCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertTextCommand::input): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::applyStyleToInsertedNodes):
- khtml/editing/selection.cpp: (khtml::Selection::modifyExtendingRightForward): (khtml::Selection::modifyMovingRightForward): (khtml::Selection::modifyExtendingLeftBackward): (khtml::Selection::modifyMovingLeftBackward): (khtml::Selection::modify): (khtml::Selection::validate):
- khtml/editing/visible_position.cpp: (khtml::visiblePositionsOnDifferentLines):
- khtml/editing/visible_units.cpp: (khtml::rootBoxForLine): (khtml::startOfLine): (khtml::endOfLine): (khtml::inSameLine): (khtml::isStartOfLine): (khtml::isEndOfLine): (khtml::previousLinePosition): (khtml::nextLinePosition): (khtml::previousSentencePosition): (khtml::nextSentencePosition): (khtml::previousParagraphPosition): (khtml::nextParagraphPosition):
- khtml/editing/visible_units.h:
- khtml/khtml_events.cpp: (khtml::MouseEvent::offset):
- khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates):
- khtml/rendering/render_block.h:
- khtml/rendering/render_br.cpp: (RenderBR::positionForCoordinates):
- khtml/rendering/render_br.h:
- khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates):
- khtml/rendering/render_container.h:
- khtml/rendering/render_inline.cpp: (RenderInline::positionForCoordinates):
- khtml/rendering/render_inline.h:
- khtml/rendering/render_object.cpp: (RenderObject::caretRect): (RenderObject::positionForCoordinates):
- khtml/rendering/render_object.h:
- khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates):
- khtml/rendering/render_replaced.h:
- khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates):
- khtml/rendering/render_text.h:
- khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): (DOM::Position::nextCharacterPosition): (DOM::Position::leadingWhitespacePosition): (DOM::Position::trailingWhitespacePosition):
- khtml/xml/dom_position.h:
- kwq/KWQAccObject.mm: (-[KWQAccObject value]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]):
- kwq/KWQKHTMLPart.mm:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge _visiblePositionForPoint:]):
Feb 12, 2005:
- 8:08 PM Changeset in webkit [8588] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken and John.
Re-fixed a specific case of the following:
<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration
Oddly, Cmd-B, Cmd-U, type some text, return, Cmd-U, Cmd-B, type
some text, worked fine. But hitting the second Cmd-B before the
second Cmd-U still failed to remove underlining. The reason for
this is that our code to compute the style of the current position
did not work when you had a typing style and were positioned right
at a <br> element. For various reasons, this did not show up for
bold and italic, since those are handled through the font manager.
The following change fixes this - for elements that can't have
children, we add the dummy span after the element of interest,
rather than as a child of it.
- khtml/khtml_part.cpp: (KHTMLPart::selectionComputedStyle):
