Timeline
Mar 8, 2005:
- 5:06 PM Changeset in webkit [8831] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for these bugs:
<rdar://problem/4039661> crash in ApplyStyleCommand::applyBlockStyle pasting contents of webpage into Mail or Blot
<rdar://problem/4039672> hang in moveParagraphContentsToNewBlockIfNecessary after pasting contents of webpage into Blot
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Fix for 4039672. Iteration needs to do a traverseNextSibling(), not a traverseNextNode(). The latter might iterate into a child that already got moved, and the code can infinite loop as a result. (khtml::ApplyStyleCommand::applyBlockStyle): Fix for 4039661. This function iterates over a set of nodes to apply block styles. Before, the iteration would go from the start to the end of the selection, and apply block styles as it went. However, the act of applying style could confuse the iteration. Now I iterate and store the relevant nodes in QPtrList before doing any style manipulation, and then iterate that set of nodes.
- 4:23 PM Changeset in webkit [8830] by
-
- 2 edits in trunk/WebCore
Change written by Hyatt, reviewed by me.
- fixed <rdar://problem/3952698> Function buttons do not display properly with Telia Webmail
- khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth): Only use a minWidth of 0 for images with a percentage value. Other replaced elements aren't scalable so their minWidth should be their calculated width. This has been wrong all along, but it's a relatively safe change because it only affects replaced elements' min-width.
- 4:08 PM Changeset in webkit [8829] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
<rdar://problem/4039006> REGRESSION (Mail): Command-left-arrow goes to the start of the wrong line in particular message
- khtml/editing/visible_units.cpp: (khtml::startOfLine): Use firstLeafChild() instead of firstChild().
- 4:00 PM Changeset in webkit [8828] by
-
- 3 edits in trunk/WebKit
Fixed <rdar://problem/4042570> Need to check image properties for presence of width/height properties
ImageIO-55 changed how image properties are created. They
are now created incrementally. So we need "re-get" the image
properties if the properties we care about (width/height) aren't
in the property dictionary.
Reviewed by John.
- WebCoreSupport.subproj/WebImageData.h:
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData init]): (-[WebImageData fileProperties]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData _isSizeAvailable]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]): (-[WebImageData size]):
- 1:31 PM Changeset in webkit [8827] by
-
- 2 edits in trunk/WebCore
Fixed by Tom Madden.
Fixed <rdar://problem/4038586> 8A402: Osaka-Mono text overlaps when typing with input method
We weren't clearing the "all ascii" flag when setting text on
RenderText.
Reviewed by Richard Williamson.
- khtml/rendering/render_text.cpp: (RenderText::setText):
- 11:05 AM Changeset in webkit [8826] by
-
- 2 edits in trunk/WebKit
A couple of tweaks to the previous patch, from Darin's review.
- Misc.subproj/WebNSPasteboardExtras.m: (_writableTypesForImageWithoutArchive): remove unnecessary _web prefix (_writableTypesForImageWithArchive): ditto (+[NSPasteboard _web_writableTypesForImageIncludingArchive:]): use mutableCopy rather than initWithArray:, and adjust for name changes
- 10:53 AM Changeset in webkit [8825] by
-
- 6 edits in trunk/WebKit
Reviewed by Ken.
- fixed <rdar://problem/4031826> REGRESSION (Mail): standalone images from Safari can't be pasted into Mail (WebKit part of fix)
We were always declaring webarchive-related pasteboard types, even in the standalone
image cases where we had no webarchive. Unfortunately, the WebView pasteboard-related
API doesn't prevent this kind of thing from happening, because the code that
declares the types isn't guaranteed to be anywhere near the code that writes
the pasteboard data.
After this fix, I discovered that pasting standalone images into Mail still doesn't
work right, but the remaining issues seem to be entirely in Mail. I wrote up 4041671
to cover these.
- Misc.subproj/WebNSPasteboardExtras.h: (+[NSPasteboard _web_writableTypesForImageIncludingArchive:]): Added boolean parameter; clients must specify whether or not there's an archive involved, because the array of types is different if there is.
- Misc.subproj/WebNSPasteboardExtras.m: (_web_writableTypesForImageWithoutArchive): new static function, constructs (once) and returns the array of types for images that don't have archives (_web_writableTypesForImageWithArchive): new static function, constructs (once) and returns the array of types for images that do have archives (+[NSPasteboard _web_writableTypesForImageIncludingArchive:]): added boolean parameter, now calls one of the two new static functions
(-[NSPasteboard _web_writeImage:URL:title:archive:types:]):
added asserts that we aren't declaring the archive types if we don't have archive data
(-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
updated to pass parameter to _web_writableTypesForImageIncludingArchive:
- WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyImageToClipboard:]): updated to pass parameter to _web_writableTypesForImageIncludingArchive:
- WebView.subproj/WebImageView.m: (-[WebImageView copy:]): updated to pass parameter to _web_writableTypesForImageIncludingArchive:
- WebView.subproj/WebView.m: (-[WebView pasteboardTypesForElement:]): updated to pass parameter to _web_writableTypesForImageIncludingArchive:
- 9:42 AM Changeset in webkit [8824] by
-
- 6 edits in trunk/WebCore
Reviewed by Ken and Maciej.
- fixed <rdar://problem/3988809> REGRESSION (Mail): wide space characters are turned into plain old spaces when typed or pasted
Changed the few places where it matters to use a "collapsible whitespace" concept instead of
the general whitespace concept. This means treating only ' ' and '\n' specially instead of
including other space characters, which matches what the space-collapsing logic does in RenderText,
although it really needs to behave differently based on whitespace mode.
- khtml/editing/visible_text.h: (khtml::isCollapsibleWhitespace): Added. This returns true only for ' ' and '\n' since they are the only characters collapsed once text is in the DOM. But really it can't do the job ignoring white-space mode, so some day it must go.
- khtml/editing/html_interchange.cpp: (convertHTMLTextToInterchangeFormat): Changed to use isCollapsibleWhitespace and removed unnecessary calls to latin1().
- khtml/editing/htmlediting.cpp: (khtml::isNBSP): Removed unnecessary creation/destruction of QChar each time this is called. (khtml::nextCharacterIsCollapsibleWhitespace): Renamed from isWS and changed to use isCollapsibleWhitespace. (khtml::DeleteSelectionCommand::fixupWhitespace): Use isCollapsibleWhitespace instead of isWS, since we only want to do our NBSP tricks for collapsible whitespace. (khtml::InsertTextCommand::input): Changed use of isTab to instead say == "\t" since that does the same thing and is arguably just as clear. Changed use of isWS to == " " since the input text can't include any "\n" characters, and really a plain old space is the only collapsible thing that can be passed in. Use isCollapsibleWhitespace instead of isWS since we want to do NBSP tricks only for collapsible whitespace, not all whitespace. (khtml::InsertTextCommand::insertSpace): Use isCollapsibleWhitespace instead of isWS since we want to do NBSP tricks only for collapsible whitespace, not all whitespace. (khtml::RebalanceWhitespaceCommand::doApply): Ditto.
- khtml/xml/dom_position.h: Changed treatNBSPAsWhiteSpace parameters to considerNonCollapsibleWhitespace parameters. The most common callers are only interested in collapsible whitespace, and the smart copy and paste callers want to include all whitespace, including non-breaking spaces and all the Unicode spaces.
- khtml/xml/dom_position.cpp: (DOM::Position::leadingWhitespacePosition): Rename the parameter, and use either QChar::isSpace or isCollapsibleWhitespace depending on the boolean passed in. (DOM::Position::trailingWhitespacePosition): Ditto.
Mar 7, 2005:
- 6:27 PM Changeset in webkit [8823] by
-
- 2 edits in trunk/WebKit
More bullet proofing for <rdar://problem/4038304> CrashTracer: ....9 crashes at com.apple.WebKit: -[WebTextRenderer initWithFont:usingPrinterFont:] + 840
Protect against removal of Times and Times New Roman from
system. If these fonts are removed attempt to get system font
instead of FATAL_ALWAYS.
Reviewed by John.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
- 6:27 PM Changeset in webkit [8822] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- <rdar://problem/4040868> REGRESSION (Mail, 403-403+): Drag and drop deletes text, many other bad editing problems
- khtml/rendering/render_text.cpp: (RenderText::caretMaxOffset): A "-" should have been a "+" in this method that was tweaked an hour ago. Editing was completely horked.
- 5:46 PM Changeset in webkit [8821] by
-
- 2 edits in trunk/WebCore
Additional nil check from fix for 4040749.
- khtml/rendering/render_box.cpp: (RenderBox::setStyle):
- 5:38 PM Changeset in webkit [8820] by
-
- 2 edits in trunk/WebCore
Additional nil check from fix for 4040749.
- khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
- 5:30 PM Changeset in webkit [8819] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4033202> REGRESSION (Mail): Can't arrow up at a particular spot in a particular Mail message
Doublecheck that new position is really on a different line, because the VisiblePosition constructor does not.
Filed <rdar://problem/4040763> for that problem.
- khtml/editing/visible_units.cpp: (khtml::previousLinePosition):
- 5:11 PM Changeset in webkit [8818] by
-
- 3 edits in trunk/WebCore
Fixed <rdar://problem/4040749> REGRESSION (125-178): opacity style not working, breaks fading images on okcupid.com
When layers are dynamically created/removed as a result of changing opacity they weren't being correctly
sized and positioned. This happens whenever opacity goes from < 1 to 1.
Reviewed by Darin.
- khtml/rendering/render_box.cpp: (RenderBox::setStyle):
- khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
- 5:05 PM Changeset in webkit [8817]
-
- 28 copies3 deletes in tags/WebKit-125~5~7
This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~7'.
- 5:05 PM Changeset in webkit [8816] by
-
- 2 edits in branches/Safari-1-2-branch/WebKit
versioning for Security Update 2005-003, WebKit-125.5.7
- 5:00 PM Changeset in webkit [8815] by
-
- 2 edits in trunk/WebCore
- fixed handling of min max caret position to take into account the possibility of BIDI text (4016072)
- 4:24 PM Changeset in webkit [8814] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
<rdar://problem/4029225> REGRESSION (Mail): Crash if hit return after dragging in attachment - DeleteSelectionCommand::initializePositionData
Work around the fact that the height() of a BR is 0 if there are no text elements on the line, even if there are replaced elements.
Filed <rdar://problem/4040358> RenderBR height() is not accurate.
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): When height is 0, double check that the placeholder is the first position on the line.
- 3:35 PM Changeset in webkit [8813] by
-
- 3 edits in trunk
versioning for TOT, Safari 2.0 (403+). The tree is open!
- 3:23 PM Changeset in webkit [8812]
-
- 1 copy in tags/Safari-303
This commit was manufactured by cvs2svn to create tag 'Safari-303'.
- 3:23 PM Changeset in webkit [8811] by
-
- 3 edits in trunk
versioning for SUPanWheat, Safari 1.3 (v303)
- 3:17 PM Changeset in webkit [8810]
-
- 1 copy in tags/Safari-403
This commit was manufactured by cvs2svn to create tag 'Safari-403'.
- 3:17 PM Changeset in webkit [8809] by
-
- 6 edits in trunk
Safari-403 stamp
- 2:36 PM Changeset in webkit [8808] by
-
- 2 edits in branches/Safari-1-2-branch/WebKit
2005-03-07 Adele Amchan <adele@apple.com>
Reviewed by Darin.
- Resources/IDNScriptWhiteList.txt: Took out Katakana_Or_Hiragana, since the Panther version of ICU doesn't have this script.
- 2:04 PM Changeset in webkit [8807] by
-
- 3 edits in trunk/WebCore
Reviewed by Vicki
Fix for this bug:
<rdar://problem/4040136> Expose SPI for WebCore's functions to create document fragments from plain text and markup strings
- kwq/DOMHTML.mm: Add two new SPI functions. (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]) (-[DOMHTMLDocument _createDocumentFragmentWithText:])
- kwq/DOMPrivate.h: Declare the new SPI here, a privately-exported header, so Mail can make use of it.
- 1:18 PM Changeset in webkit [8806] by
-
- 3 edits2 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/4039676> REGRESSION (Mail): in reply, <cr> on pasted text (without trailing newline) is eaten when pasted above date
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Code to "eat" a <br> element, that was creating an otherwise empty line, was running when it should not. If the content being pasted in does not end in a "logical" newline itself, then the <br> already in the content needs to be preserved. A simple one-line change now sees to this.
- layout-tests/editing/pasteboard/paste-text-010-expected.txt: This test now has an extra, but harmless, <br> at the end of a paragraph. This makes sense given the code change.
New test:
- layout-tests/editing/pasteboard/paste-text-018-expected.txt: Added.
- layout-tests/editing/pasteboard/paste-text-018.html: Added.
- 8:19 AM Changeset in webkit [8805] by
-
- 2 edits2 adds in trunk
Reviewed by John
Fix for this bug:
<rdar://problem/4035648> REGRESSION (Mail): line feed in source HTML file causes bad copy/paste behavior
The createMarkup() function in markup.cpp iterates over the nodes in a range,
and does some bookkeeping to figure out when to add close tags to the markup.
Some code added at the start of the loop to prevent markup from being written
for unrendered nodes short-circuited the rest of the loop, and so prevented
the close-tag-writing code from running when it should.
This is why the "plain" text wound up inside of the bold tag in the example
above. The addition of the unrendered return character caused an incorrect
delay in the close tag for the bold element from being written out, with the
result being that it wound up including additional content.
The fix is to add checks for node renderers throughout the loop at the points
where markup is written out for each node. This allows the additional close
tag logic to run as needed.
All layout tests pass with this change.
- khtml/editing/markup.cpp: (khtml::createMarkup)
New test:
- layout-tests/editing/pasteboard/paste-4035648-fix-expected.txt: Added.
- layout-tests/editing/pasteboard/paste-4035648-fix.html: Added.
Mar 6, 2005:
- 7:48 PM Changeset in webkit [8804] by
-
- 2 edits in branches/Safari-1-2-branch/WebKit
Rolled in fix from Tiger for IDN spoofing.
2005-03-06 Darin Adler <Darin Adler>
- fixed obvious mistake in IDN script code (luckily it hasn't been in a submission yet!)
- Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Use "index" to index into the array, not "script", which is the script number, not the 32-bit-word index.
- 7:46 PM Changeset in webkit [8803] by
-
- 2 edits in trunk/WebKit
- fixed obvious mistake in IDN script code (luckily it hasn't been in a submission yet!)
- Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Use "index" to index into the array, not "script", which is the script number, not the 32-bit-word index.
- 2:33 PM Changeset in webkit [8802] by
-
- 2 edits in trunk/WebCore
- fixed text box search code for caret rect to properly account for BIDI text (4038674)
- 12:03 AM Changeset in webkit [8801] by
-
- 3 edits in trunk/WebCore
- fixed problem with searching for BIDI text boxes (3587609)
- fixed missing initalizer of RTL flag in WebCoreStyle
Mar 5, 2005:
- 7:36 PM Changeset in webkit [8800] by
-
- 5 edits in trunk/WebKit
Reviewed by Darin.
Fixed: <rdar://problem/4038529> Infinite progress bar loading webcams and other sites that use multipart/x-mixed-replace
The previous patch I landed prevented us from loading multipart/x-mixed-replace but did not always update the progress bar accordingly.
This stops websites from having seemingly infinite progress in the browser UI.
- WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didReceiveResponse:]): If this is "multipart/x-mixed-replace", remove the WebBaseResourceHandleDelegate client from the datasource's subresource array, otherwise -[WebDataSource isLoading] incorrectly returns YES. Also it's possible at this point in time we're done loading now (loaded everything else except for the multipart/x-mixed-replace content) so go ahead and check to see if in fact we're complete.
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): ditto
- 5:37 PM Changeset in webkit [8799] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed <rdar://problem/4038417> Mail crashed in StyleChange::checkForLegacyHTMLStyleChange when composing a reply
- khtml/editing/htmlediting.cpp: (khtml::StyleChange::checkForLegacyHTMLStyleChange): Added missing nil check.
- 3:35 PM Changeset in webkit [8798] by
-
- 2 edits in trunk/WebKit
Fixed panther build problem. Shouldn't include
changes for 3968753 on panther.
Reviewed by John.
- WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
- 3:20 PM Changeset in webkit [8797] by
-
- 2 edits in trunk/WebCore
Reviewed by Don.
- fixed <rdar://problem/4038478> Crash in renderer viewing RSS feed at feed://wvs.topleftpixel.com/index.rdf
- khtml/xml/dom_docimpl.cpp: (widgetForNode): Check for nil before going from node to renderer.
- 3:08 PM Changeset in webkit [8796] by
-
- 2 edits in trunk/WebCore
Reviewed by Richard.
- fixed <rdar://problem/4037700> Every character typed causes stat call for /usr/share/icu/icudt32b_char.brk
- khtml/rendering/render_text.cpp: (getCharacterBreakIterator): Added. Helper that sets up an iterator for the passed-in text. Shares a single global iterator (fast, albeit not thread-safe). (RenderText::previousOffset): Changed to call getCharacterBreakIterator. (RenderText::nextOffset): Ditto.
- 2:40 PM Changeset in webkit [8795] by
-
- 2 edits2 adds in trunk
Reviewed by Darin
Fix for this bug:
<rdar://problem/4038267> REGRESSION (Mail): Crash copying and pasting end of paragraph
Code to handle content that has a "logical" newline at the end of the pasted content, and the code
to adjust the selection at the end of the paste operation made an assumption that at least one
node had been inserted by the paste command. This is not necessarily true in the case where the sole content
in the pasted content is one of these "logical" newlines. Adjust some code around so that we don't deref
null, but still adjust the selection correctly for this case. In each of the two functions below, some
null checks have been added, and some code has been rearranged a little bit to continue on through
the end of completeHTMLReplacement, even if no nodes have been inserted. The patch looks bigger and more
complicated than the conceptual change.
- khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply) (khtml::ReplaceSelectionCommand::completeHTMLReplacement)
- layout-tests/editing/pasteboard/paste-4038267-fix-expected.txt: Added.
- layout-tests/editing/pasteboard/paste-4038267-fix.html: Added.
- 11:20 AM Changeset in webkit [8794] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/4025918> images copied from Safari with relative src URLs aren't pasted into Mail messages (KURL resolves base URLs incorrectly)
- kwq/KWQKURL.mm: (KURL::KURL): Add a slash at the start of the path if a relative part is adding a path onto a URL that has "pre-path" bits like host name, but no path yet. This doesn't come up for http because in that case we add a trailing "/" as part of canonicalization.
- 11:17 AM Changeset in webkit [8793] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/4034603> REGRESSION (185-188): RadarWeb can't send enclosures anymore
- WebView.subproj/WebFormDataStream.m: (closeCurrentStream): Release currentData when closing the stream. (advanceCurrentStream): Set up and retain currentData when the current stream is reading that data, so the data won't be released while in use. (formCreate): Initialize currentData to NULL.
- fixed <rdar://problem/4037562> Tiger8A402: Help Viewer crashed when viewing help for iChat (infinite recursion in WebView)
- WebView.subproj/WebView.m: (-[WebView _responderValidateUserInterfaceItem:]): Check for the case where we ourselves are the responder. This avoids an infinite loop. The actual code to perform operations avoids this with a global variable, but this lighter weight solution is sufficient here because validate operations don't call through to the next responder.
- 7:39 AM Changeset in webkit [8792] by
-
- 1 edit in trunk/WebCore/khtml/editing/htmlediting.cpp
Rolled out a couple of assertion-related changes I accidentally checked in.
Mar 4, 2005:
- 7:15 PM Changeset in webkit [8791] by
-
- 1 edit in trunk/WebCore/khtml/rendering/render_text.cpp
- forgot to check this in for the previous fix
- 5:50 PM Changeset in webkit [8790] by
-
- 3 edits in trunk/WebCore
Reviewed by Kevin.
- fixed <rdar://problem/4033705> REGRESSION (Mail): Copy/Paste from Excel crashes Mail in KWQKHTMLPart::fontForSelection(bool*) const + 232
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection): Check for nil startNode, not just nil renderer.
- 5:33 PM Changeset in webkit [8789] by
-
- 2 edits in trunk/WebKit
Fixed <rdar://problem/3968753> REGRESSION: Poor performance with differing multiple animated GIFs (was fast in Panther)
Disable coalesced updates (in CG). This restores the
panther behavior.
Reviewed by David Harrison.
- WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
- 5:28 PM Changeset in webkit [8788] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
- English.lproj/StringsNotToBeLocalized.txt: added new strings "text/x-vcf" and "text/x-csv" to the list
- 5:17 PM Changeset in webkit [8787] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken, Richard.
<rdar://problem/3996383> REGRESSION (Mail): Deleting all of first line also deletes line ending
Problem was the placeholder check was based on 0 height block, but the block in this
case is the BODY, which has other content even though the paragraph is gone.
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::insertBlockPlaceholder): Now does insert instead of append!
(khtml::CompositeEditCommand::appendBlockPlaceholder):
New. Actually does append.
(khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded):
Renamed from insertBlockPlaceholderIfNeeded because it can insert or append. Also accepts "force insert" flag.
(khtml::CompositeEditCommand::removeBlockPlaceholder):
Renamed for succinctness from removeBlockPlaceholderIfNeeded.
(khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent):
(khtml::DeleteSelectionCommand::moveNodesAfterNode):
Use renamed methods.
(khtml::DeleteSelectionCommand::doApply):
Use addBlockPlaceholderIfNeeded "force insert" flag if deleting whole paragraphs did not leave an empty one.
(khtml::InsertParagraphSeparatorCommand::doApply):
(khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply):
(khtml::InsertTextCommand::input):
Use renamed methods.
- khtml/editing/htmlediting.h: Renamed and new methods per above.
- 5:02 PM Changeset in webkit [8786] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/4032840> REGRESSION (Mail): crash in RemoveNodeCommand after pasting attachment at end of message
Reviewed by darin.
- khtml/editing/visible_units.cpp: (khtml::endOfParagraph): don't consider text nodes that have no rendered characters
- 4:02 PM Changeset in webkit [8785] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris.
Fix for <rdar://problem/4032982> Sun iPlanet app: not able to import AddressBook CSV format addresses properly
Fix for <rdar://problem/4032985> Sun iPlanet app: not able to import vCard format addresses properly
- WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/x-csv" and "text/x-vcf" to the list of MIME types that our text view doesn't handle
- 3:59 PM Changeset in webkit [8784] by
-
- 4 edits in trunk/WebCore
Fixed <rdar://problem/4034764> REGRESSION(125-188)Viewing text/plain page and going back/forward corrupts HTML pages (google.com)
The parse mode wasn't be restored to the document when going
back.
Reviewed by Hyatt.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):
- kwq/KWQPageState.h:
- kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]):
- 2:47 PM Changeset in webkit [8783] by
-
- 3 edits in branches/Safari-1-2-branch/WebKit
Rolled in changes from Tiger for IDN spoofing.
2005-03-04 Darin Adler <Darin Adler>
Reviewed by John.
- fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters
- Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Added. Reads file and parses script names. (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession. (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense. Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of containsPossibleLatinLookalikes.
- Resources/IDNScriptWhiteList.txt: Added.
- WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.
- Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
- English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
2005-02-21 Darin Adler <Darin Adler>
Reviewed by John.
- fixed <rdar://problem/4016358> don't ever display IDN URLs with characters from "possible Latin look-alike" scripts
- Misc.subproj/WebNSURLExtras.m: (containsPossibleLatinLookalikes): Added. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call containsPossibleLatinLookalikes, and if true, don't decode the host name.
- 2:47 PM Changeset in webkit [8782] by
-
- 2 edits in trunk
Reviewed by me
- layout-tests/editing/style/create-block-for-style-012-expected.txt: Shame on me! I landed my last fix without running layout tests. This one changes in a subtle, but acceptable way.
- 2:32 PM Changeset in webkit [8781] by
-
- 6 edits in trunk/WebCore
Reviewed by Harrison
Fix for this bug:
<rdar://problem/4032543> REGRESSION (Mail): Mail hangs when quoted text is pasted twice
This code change fixes the bug in a non-obvious way. The root cause of the problem was
that a VisiblePosition created using an affinity originating in Mail code caused
two VisiblePosition objects that should have been equal to differ only in their
affinities, which in turn caused us to run a code path that should not have run.
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): Added copy constructor. (khtml::VisiblePosition::next): Factored out inline code that used to be here into new setAffinityUsingLinePosition() function. (khtml::isEqualIgnoringAffinity): New helper to handle cases when affinity in equality check does not matter. However, we want to know about such cases where a VisiblePosition differs only by affinity, and the code will assert in development when this happens. (khtml::isNotEqualIgnoringAffinity): Ditto, but not. :) (khtml::setAffinityUsingLinePosition): New helper function mentioned above. This will "correct" upstream affinity to downstream if the affinity does not make a difference for the position.
- khtml/editing/visible_position.h:
- khtml/editing/visible_range.h: Wacky bug. The operator== for this class took VisiblePosition classes!
- khtml/editing/visible_units.cpp: (khtml::isStartOfParagraph): Now performs equality check without regard to affinity. (khtml::isEndOfParagraph): Ditto. (khtml::isStartOfBlock): Ditto. (khtml::isEndOfBlock): Ditto.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): Adjusts the affinity using setAffinityUsingLinePosition() if necessary.
- 2:24 PM Changeset in webkit [8780] by
-
- 7 edits in trunk
WebCore:
Reviewed by John.
- fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut
- khtml/editing/htmlediting.h: Added insertTextRunWithoutNewlines.
- khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::input): Added assertion to make sure strings with newlines don't get down to this level. (khtml::TypingCommand::insertText): Added. Takes the name of the old function, but is a new level that breaks runs into lines and inserts each one separately. (khtml::TypingCommand::insertTextRunWithoutNewlines): Renamed old insertText to this.
- khtml/dom/dom_string.h: Made substring be a const member function.
- khtml/dom/dom_string.cpp: (DOM::DOMString::substring): Made this const.
WebKit:
Reviewed by John.
- fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): Merged _handleKillRing behavior into this function, since there's now a more-complicated way the startNewKillRingSequence boolean needs to be handled. Set the startNewKillRingSequence boolean after the entire process so changing the selection before and during the editing dosn't clear it. Also change "isTypingAction" parameter to "deletionAction" so we can handle forward delete with this method. (-[WebHTMLView _deleteSelection]): Pass deleteSelectionAction for action rather than NO for isTypingAction, which is the way to say the same thing using the new parameter. (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Refactor to use the _deleteRange method above. Also calls _shouldDeleteRange: for the pre-existing selection case; not doing that before was a bug. (-[WebHTMLView deleteToMark:]): Pass deleteSelectionAction for action rather than NO for isTypingAction, which is the way to say the same thing using the new parameter.
- 11:37 AM Changeset in webkit [8779] by
-
- 5 edits in trunk
WebCore:
Reviewed by John.
- fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)
- khtml/css/css_valueimpl.cpp: (DOM::isLegalIdentifier): Added. Commented out and not used. (DOM::quoteStringIfNeeded): Quotes the string if needed. For now only if it starts with "#". (DOM::CSSPrimitiveValueImpl::cssText): Call quoteStringIfNeeded when asked for cssText for an arbitrary string, since we need text you can re-parse. (DOM::FontFamilyValueImpl::cssText): Ditto.
- khtml/editing/markup.cpp: (khtml::startMarkup): Added comments about lack of quoting for attributes. (khtml::createMarkup): Ditto.
WebKit:
Reviewed by John.
- fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): Quote font name when calling setFontFamily. (-[WebHTMLView _addToStyle:fontA:fontB:]): Ditto.
- 11:16 AM Changeset in webkit [8778] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej
Fix for <rdar://problem/4021711> REGRESSION(125-188) blank pages when browsing forum at cooperativeresearch.org - cached external script problem
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): set flag needToRefCachedScript so we can make sure notifyFinished is called after pendingSrc is set up with the right data from the cached script
- 9:54 AM Changeset in webkit [8777]
-
- 1 copy in branches/Safari-1-2-branch/WebKit/Resources/IDNScriptWhiteList.txt
This commit was manufactured by cvs2svn to create branch
'Safari-1-2-branch'.
- 9:54 AM Changeset in webkit [8776] by
-
- 4 edits1 add1 delete in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters
- Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Added. Reads file and parses script names. (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession. (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense. Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of containsPossibleLatinLookalikes.
- Resources/IDNScriptWhiteList.txt: Added.
- WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.
- Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
- English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
- 9:37 AM Changeset in webkit [8775] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed <rdar://problem/3937667> REGRESSION (Mail): Zooming a window from titlebar button doesn't paint newly-exposed portions of window
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Re-set-up the visRect if the bounds changes due to layout.
- 9:18 AM Changeset in webkit [8774] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/4029632> Tiger 8A398:- Mail crashes in DOM::NodeImpl::isBlockFlow() after pasting text with alignment style and BR element from Safari
- khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): VisiblePosition constructor was failing to yield a position for a node just pasted into the document since a layout was needed for the calculation to come out right. Layout added. Crash gone.
- 12:58 AM Changeset in webkit [8773] by
-
- 1 edit in trunk/WebCore/khtml/rendering/render_text.cpp
- made RenderText::caretRect handle BIDI text correctly in its calculations (3587614)
