Context Navigation

Plugins.subproj/WebPluginContainerPrivate.h: Added.
Plugins.subproj/WebPluginController.m: (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): (-[WebPluginController _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
WebKit.pbproj/project.pbxproj:

3:48 PM Changeset in webkit [8944] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3923903> REGRESSION (164-165): Repro Safari crash in khtml::RenderLayer::scrollToOffset

khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset): Check canvas for nil.

1:31 PM Changeset in webkit [8943] by harrison

3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4055127> Dictionary pop-up panel misplaced at beginning of text blocks (breaks double-clicking in Dictionary.app)

SimplifiedBackwardsTextIterator::advance() needed to not limit to textnodes
when checking whether moving back across block boundaries

VisibleUnits previousBoundary() needed to INIT_DOWN when creating result VisiblePosition

All editing tests pass.

khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::advance):
khtml/editing/visible_units.cpp: (khtml::previousBoundary):

1:18 PM Changeset in webkit [8942] by darin

4 edits in trunk/WebCore

Reviewed by Harrison.

fixed <rdar://problem/4059914> when you select all of a frame's content, need to select the frame in the parent document so it can be easily deleted

khtml/khtml_part.h: Added selectFrameElementInParentIfFullySelected.
khtml/khtml_part.cpp: (isFrame): Added. (KHTMLPart::setFocusNodeIfNeeded): Changed to not set focus to a frame; was not what this function was intended to do, and caused trouble when trying to select a frame element. (KHTMLPart::khtmlMouseReleaseEvent): Call selectFrameElementInParentIfFullySelected. (KHTMLPart::selectAll): Call selectFrameElementInParentIfFullySelected. (KHTMLPart::selectFrameElementInParentIfFullySelected): Added. Selects the frame element in the parent if a frame is entirely selected, which makes it easier to delete or replace the frame and is consistent with the changes Maciej made recently for other elements.

kwq/WebCoreBridge.mm: (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Call selectFrameElementInParentIfFullySelected. (-[WebCoreBridge alterCurrentSelection:verticalDistance:]): Call selectFrameElementInParentIfFullySelected.

12:19 PM Changeset in webkit [8941] by darin

2 edits in trunk/WebCore

Reviewed by me, code change by Ken.

fixed <rdar://problem/4059852> Deleting from first element of list makes content jump to wrong place

khtml/editing/htmlediting.cpp: (khtml::isListStructureNode): Added. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Check for list nodes as well as table nodes.

9:36 AM Changeset in webkit [8940] by kocienda

1 edit
11 adds in trunk

Reviewed by me

Added tests to cover new "unsupported content" editing code.

layout-tests/editing/unsupported-content/list-delete-001-expected.txt: Added.
layout-tests/editing/unsupported-content/list-delete-001.html: Added.
layout-tests/editing/unsupported-content/list-delete-002-expected.txt: Added.
layout-tests/editing/unsupported-content/list-delete-002.html: Added.
layout-tests/editing/unsupported-content/list-delete-003-expected.txt: Added.
layout-tests/editing/unsupported-content/list-delete-003.html: Added.
layout-tests/editing/unsupported-content/list-type-after-expected.txt: Added.
layout-tests/editing/unsupported-content/list-type-after.html: Added.
layout-tests/editing/unsupported-content/list-type-before-expected.txt: Added.
layout-tests/editing/unsupported-content/list-type-before.html: Added.

8:26 AM Changeset in webkit [8939] by kocienda

2 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/4059578> Entire list deleted, and caret disappears, when delete key hit at end of list

The problem is that a new case in the delete code did not consider when the
downstream end node of the selection might be an ancestor of the upstream start
node. That is the case in this bug. The downstream end is the body element, and
this line of code would delete all the children of the downstream end:

removeChildrenInRangePreservingPosition(m_downstreamEnd.node(), 0,

m_downstreamEnd.offset(), m_upstreamStart);

The fix is to check for this "is ancestor" case, and do some tree logic to find
the right offset of the downstream end node for the call to
removeChildrenInRangePreservingPosition().

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Fixed as described.

Mar 19, 2005:

8:58 PM Changeset in webkit [8938] by harrison

2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4059479> Misspelling underline does underline the whole word, could go farther to the right

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer misspellingLinePatternGapWidth]): (-[WebTextRenderer drawLineForMisspelling:withWidth:]): Consider that the last pixel in the underline dot pattern is transparent.

6:22 PM Changeset in webkit [8937] by kocienda

2 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/4059384> Cannot place insertion point correctly in editable text that avoids floating elements

Note: I strongly suspect this bug blocks a complete solution to this other Tiger/P2:
<rdar://problem/4055748> AX: Dictionary pop-up panel shows at wrong place on specific parts of particular pages

khtml/rendering/render_text.cpp: (RenderText::caretRect): Change the y-coordinate used to calculate the available width for a line. Height is wrong. Top of the box containing the text where the click is done is correct. Also, add in the x-offset for the start of the text box when calculating the available width. If this text box is avoiding a float at the y-coordinate for the relevant box, failure to add in the amount of float-avoidance will make the text at the coordinates greater than end-of-line minus float-avoidance ineligible for caret placement.

4:58 PM Changeset in webkit [8936] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/4057594> REGRESSION (125-406): Unrepro crash in HTMLTokenizer::allDataProcessed after hitting Back button

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::allDataProcessed): To get the part safely after calling end, save a guarded pointer to the view. The old way could end trying to call a virtual function a part that was destroyed.

2:36 PM Changeset in webkit [8935] by mjs

13 edits in trunk

Reviewed by Darin.

<rdar://problem/4053506> Pasting Tables and Cells in Mail does not allow editing before or after
<rdar://problem/4005954> REGRESSION (Mail): After copy/paste of content containing list element cannot go back to entering text at left side of page

khtml/editing/htmlediting.cpp: (khtml::maxDeepOffset): (khtml::CompositeEditCommand::removeFullySelectedNodePreservingPosition): (khtml::CompositeEditCommand::removeChildrenInRangePreservingPosition): (khtml::CompositeEditCommand::removeNodePreservingPosition): (khtml::CompositeEditCommand::insertBlockPlaceholder): (khtml::CompositeEditCommand::appendBlockPlaceholder): (khtml::CompositeEditCommand::forceBlockPlaceholder): (khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded): (khtml::isSpecialElement): (khtml::isFirstVisiblePositionInSpecialElementInFragment): (khtml::positionBeforePossibleContainingSpecialElement): (khtml::positionAfterPossibleContainingSpecialElement): (khtml::ApplyStyleCommand::applyInlineStyle): (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): (khtml::DeleteSelectionCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::ReplacementFragment::ReplacementFragment): (khtml::ReplaceSelectionCommand::doApply):
khtml/editing/htmlediting.h:
khtml/editing/visible_position.cpp: (khtml::isRenderedBR): (khtml::VisiblePosition::initDownstream): (khtml::isLastVisiblePositionInBlock):
khtml/rendering/render_line.cpp: (khtml::RootInlineBox::closestLeafChildForXPos):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isBlockFlowOrTable): (NodeImpl::isEditableBlock): (NodeImpl::enclosingBlockFlowOrTableElement):
khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_position.cpp: (DOM::Position::upstream): (DOM::Position::downstream):
layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
layout-tests/editing/deleting/delete-select-all-001-expected.txt:
layout-tests/editing/deleting/delete-select-all-003-expected.txt:
layout-tests/editing/inserting/insert-3786362-fix-expected.txt:

11:34 AM Changeset in webkit [8934] by darin

2 edits in trunk/WebKit

Reviewed by Maciej (a while back).

fixed <rdar://problem/4059323> local-file security check is allowing plug-in streams, but must not

Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): Roll out change I made on 3-13. That change is needed for subresource, but not for plug-in streams. For plug-in streams it's too risky, and leaves a serious security hole open.

9:09 AM Changeset in webkit [8933] by darin

2 edits in trunk/WebKit

Reviewed by Ken and John.

fixed <rdar://problem/4059123> REGRESSION (402-403): deleteWordForward: and deleteWordBackward: start deleting single characters after the first delete

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Fixed backwards logic in here and added missing check. Set action to one of the two typing actions only if isTypingAction is YES.

8:21 AM Changeset in webkit [8932] by sullivan

2 edits in trunk/WebCore

Reviewed by Darin.

fixed <rdar://problem/4058740> Crash (nil-deref) editing Mail reply message in KWQKHTMLPart::fontForSelection (MailViewer-723)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection): Add nil check to loop. It shouldn't be necessary, but this crash trace seems to be running into it. We're not completely certain, but the check is harmless at worst.

8:07 AM Changeset in webkit [8931] by harrison

2 edits in trunk/WebKit

Reviewed by me (written by Patti Yeh).

<rdar://problem/4029491> <TCIM> CangJie: the candidate window appears at the top left hand corner during typing in Mail and iChat

WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Use selected range if there is no marked range.

Mar 18, 2005:

6:19 PM Changeset in webkit [8930] by vicki

3 edits in trunk

versioning for TOT, Safari 2.0 (408+)

6:12 PM Changeset in webkit [8929]

1 copy in tags/Safari-308

This commit was manufactured by cvs2svn to create tag 'Safari-308'.

6:12 PM Changeset in webkit [8928] by vicki

3 edits in trunk

versioning for SUPanWheat, Safari 1.3 (308)

6:07 PM Changeset in webkit [8927]

1 copy in tags/Safari-408

This commit was manufactured by cvs2svn to create tag 'Safari-408'.

6:07 PM Changeset in webkit [8926] by vicki

6 edits in trunk

Safari-408 stamp

4:56 PM Changeset in webkit [8925] by harrison

2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch

WebView.subproj/WebFrameView.m: (-[WebFrameView webCoreBridge]): New to conform to WebCoreBridgeHolder protocol.

4:53 PM Changeset in webkit [8924] by harrison

3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch

Also changed WebKit.

kwq/KWQAccObject.mm: (-[KWQAccObject rendererForView:]): New to cover both the WebCore and WebKit NSViews.

(-[KWQAccObject _accessibilityParentForSubview:]):
Use rendererForView.

kwq/WebCoreFrameView.h: Add WebCoreBridgeHolder protocol to get access to WebKit NSViews.

4:34 PM Changeset in webkit [8923] by harrison

18 edits in trunk/WebCore

Reviewed by Darin, Ken.

<rdar://problem/3735625> AX: add AXPress action if an element has an onclick handler

khtml/dom/html_form.cpp: (HTMLInputElement::click):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::click): (HTMLElementImpl::accessKeyAction):
khtml/html/html_elementimpl.h:
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::submitClick): (DOM::HTMLButtonElementImpl::click): (DOM::HTMLButtonElementImpl::accessKeyAction): (DOM::HTMLInputElementImpl::click): (DOM::HTMLInputElementImpl::accessKeyAction): (DOM::HTMLInputElementImpl::defaultEventHandler): (DOM::HTMLLabelElementImpl::accessKeyAction): (DOM::HTMLSelectElementImpl::accessKeyAction): (DOM::HTMLTextAreaElementImpl::accessKeyAction):
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): (HTMLAnchorElementImpl::accessKeyAction):
khtml/html/html_inlineimpl.h:
khtml/rendering/render_form.cpp: (RenderFileButton::click):
khtml/rendering/render_form.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler):
khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::accessKeyAction):
kwq/DOMHTML.mm: (-[DOMHTMLInputElement click]):
kwq/KWQButton.h:
kwq/KWQButton.mm: (QButton::click):
kwq/KWQFileButton.h:
kwq/KWQFileButton.mm: (KWQFileButton::click):

Add accessKeyAction parameter about whether to limit to HTMLElementImpl subclasses that JavaScript wants, or to apply to others as well.

Add click() parameter about whether to send the mousedown and mouseup events in addition to the click event.

kwq/KWQAccObject.mm: (-[KWQAccObject mouseButtonListener]): Locate a mousedown, mouseup, or click handler in the current element and its ancestors.

(-[KWQAccObject actionElement]):
(-[KWQAccObject accessibilityIsIgnored]):
(-[KWQAccObject accessibilityPerformAction:]):
Consider mouseButtonListener.

2:56 PM Changeset in webkit [8922] by rjw

4 edits in trunk/WebKit

Fixed <rdar://problem/4057004> Data from XMLHTTPRequest is never dealloced

WebDataSource keeps an array of all the NSURLResponses associated
with the load for a page. This is used to playback delegate messages
when loading from the page cache. However, after the document
has completed it's initial load, we continue to keep track of responses.
So, this has the consequence of keeping all the responses for a page
around for the life of the page. NSURLResponses are now very
heavy. They indirectly reference the resource data (via the
download assessment dictionary). This fix will keep
references to responses around for those resources loaded during initial
page load, but not after that point.

Reviewed by Ken.

WebView.subproj/WebDataSource.m: (-[WebDataSource _addResponse:]): (-[WebDataSource _stopRecordingResponses]):
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame _opened]):

12:41 PM Changeset in webkit [8921] by sullivan

7 edits in trunk/WebCore

Reviewed by Darin.

fixed <rdar://problem/4002164> maps that include start and end location don't print right from maps.google.com

I thought I checked this in yesterday but a ChangeLog conflict aborted my checkin
without me noticing.

khtml/rendering/render_style.cpp: (RenderStyle::diff): flag name changed from _should_correct_text_color to _force_backgrounds_to_white

khtml/rendering/render_style.h: (khtml::RenderStyle::InheritedFlags::operator==): flag name changed from _should_correct_text_color to _force_backgrounds_to_white (khtml::RenderStyle::setBitDefaults): ditto (khtml::RenderStyle::forceBackgroundsToWhite): ditto, and method name changed too (khtml::RenderStyle::setForceBackgroundsToWhite): ditto

khtml/rendering/render_text.cpp: (InlineTextBox::paint): updated for name change; also, compare text against white instead of current bg color because we no longer actually modify the bg color (previously we would always set the bg color to white, so the result is the same)

khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): updated for name change

kwq/WebCoreBridge.mm: (-[WebCoreBridge styleSheetForPrinting]): removed this method (-[WebCoreBridge reapplyStylesForDeviceType:]): removed the code that called styleSheetForPrinting; we no longer use a stylesheet for this behavior.

khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended): If forceBackgroundsToWhite flag is set, convert background images and background colors to white background color with no background image.

9:49 AM Changeset in webkit [8920] by kocienda

2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/4053729> Copy/paste of page with frames into Blot or Mail does nothing and loses insertion point

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedArchive]): Wrap frameset documents in an iframe, so they can be pasted into existing documents which will have a body or frameset of their own.

9:32 AM Changeset in webkit [8919] by kocienda

3 edits in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/4056718> Pasting quotes the entire message

khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): After pasting, nodes are moved to the block containing the end of the pasted content in certain cases. This move logic used to stop once it moved all the siblings of the node following the last node of the pasted-in content. This means that block elements could get moved, and if the pasted-in content included a mail blockquote, this could result in one quote level getting added. The fix is to stop the move of nodes once a <br>, block element, or <table> is seen. This only affected one of the many test cases we have for such scenarios, and the change to that result makes sense given the code change.
layout-tests/editing/pasteboard/paste-text-003-expected.txt: This test result changed in a way that adequately tests the behavior change, so I did not add a new test.

7:56 AM Changeset in webkit [8918] by kocienda

2 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/4051809> 8A413: Cursor-up in a mail message sometimes gets stuck (with specific reproducible case)

khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Consider two lines: line-above and line-below. If the caret position in line-below was at an x coordinate between half way through the x coordinate of the last character on the line-above and the end of that same character, this bug would happen since the positioning code would assume that it could create a VisiblePosition with a DOWNSTREAM affinity. Now, I check to see if the character position on the line-above is the last character on that line, and if it is, I use UPSTREAM as the affinity.

Mar 17, 2005:

2:59 PM Changeset in webkit [8917] by vicki

3 edits in trunk

versioning for TOT, Safari 2.0 (407+)

2:48 PM Changeset in webkit [8916]

1 copy in tags/Safari-307

This commit was manufactured by cvs2svn to create tag 'Safari-307'.

2:48 PM Changeset in webkit [8915] by vicki

3 edits in trunk

versioning for Safari 1.3 (307) on SUPanWheat

2:41 PM Changeset in webkit [8914]

1 copy in tags/Safari-407

This commit was manufactured by cvs2svn to create tag 'Safari-407'.

2:41 PM Changeset in webkit [8913] by vicki

6 edits in trunk

Safari-407 stamp

1:43 PM Changeset in webkit [8912] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/4055562> REGRESSION (Tiger): Safari doesn't draw progressively-loaded JPEGs (www.theregister.co.uk, www.titantalk.com)

Anothe side effect of lazy loading of image meta data. We now
don't cache image size until size meta data is actually available.

Reviewed by Darin.

WebCoreSupport.subproj/WebImageData.m: (-[WebImageData size]):

11:09 AM Changeset in webkit [8911] by harrison

2 edits in trunk/WebCore

Reviewed by Darin, Ken.

khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::setEndingSelection): Fixed typo so that it calls setEndingSelection rather than setStartingSelection. Commented out this unused method, tho, since this is late in Tiger. Proved unused by successful build after temporarily removing method declaration or implemenation.

9:57 AM Changeset in webkit [8910] by kdecker

2 edits in trunk/WebCore

Reviewed by mjs.

Fixed <rdar://problem/4046665> REGRESSION (403-405): mypage.apple.com login does not work (hits assertion in Development build)

kwq/WebCoreBridge.mm: (-[WebCoreBridge canLoadURL:fromReferrer:hideReferrer:]): Check always came back false when callers would send a nil NSURL to this method. Now we allow the empty url cases, eg., <frame src="">

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed