Context Navigation

Use Patti Yeh's hack to determine the appropriate rectangle
to place the "associated word" window.
If there is no marked text firstRectForCharacterRange: will
use the selected range to determine the returned rectangle,
ignoring the input range. This is the fix from
4029491 that I previously backed out.

Reviewed by Vicki.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]):

5:47 PM Changeset in webkit [8966] by rjw

2 edits in trunk/WebCore

Further fix for 4053515.

Covered cases where text position doesn't lie inside a
text node.

Reviewed by Richard.

khtml/editing/visible_text.cpp: (khtml::TextIterator::setRangeFromLocationAndLength):

3:55 PM Changeset in webkit [8965] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/4062490> REGRESSION (WebKit-408): no subresources reported in Activity window after going back at hrweb.apple.com

Stop collecting subresource responses after the document
had loaded, not after it has been opened.

Reviewed by Chris.

WebView.subproj/WebFrame.m: (-[WebFrame _setState:]): (-[WebFrame _opened]):

2:09 PM Changeset in webkit [8964] by mjs

6 edits
2 adds in trunk/WebKit

WebKit:

Reviewed by Darin.

<rdar://problem/4051145> The QuickTime Cocoa plug-in needs an SPI that it can call to check for URL policy

Plugins.subproj/WebPluginContainerCheck.h: Added.
Plugins.subproj/WebPluginContainerCheck.m: Added this new helper class to encapsulate an async plugin navigation check. (+[WebPluginContainerCheck checkWithRequest:target:resultObject:selector:controller:]): Convenience allocator that gives autoreleased value. (-[WebPluginContainerCheck initWithRequest:target:resultObject:selector:controller:]): Initializer. (-[WebPluginContainerCheck finalize]): Just assert that we're done, it would be bad to deallocate this object while request is still outstanding. (-[WebPluginContainerCheck dealloc]): Ditto. (-[WebPluginContainerCheck _continueWithPolicy:]): Method to continue after async policy check. (-[WebPluginContainerCheck _isDisallowedFileLoad]): Do "file: URL from remote content" check. (-[WebPluginContainerCheck _actionInformationWithURL:]): Helper to make action dictionary. (-[WebPluginContainerCheck _askPolicyDelegate]): Call policy delegate to let the app decide if this load is allowed. (-[WebPluginContainerCheck start]): Start the check. (-[WebPluginContainerCheck cancel]): Cancel a check in progress.
Plugins.subproj/WebPluginController.h:
Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithDocumentView:]): Initialize new _checksInProgress field. (-[WebPluginController _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Implement this new SPI method. (-[WebPluginController _cancelOutstandingChecks]): New helper to make sure to cancel all outstanding requests when destroying all plugins. (-[WebPluginController destroyAllPlugins]): Call above helper. (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): Implement this new plug-in SPI method. (-[WebPluginController bridge]): New helper method. (-[WebPluginController webView]): New helper method.
WebView.subproj/WebPolicyDelegatePrivate.h: Add new navigation type WebNavigationTypePlugInRequest.
WebKit.pbproj/project.pbxproj: Add new files.
WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Don't open externally on a plug-in request.

WebBrowser:

Reviewed by Darin.

<rdar://problem/4051145> The QuickTime Cocoa plug-in needs an SPI that it can call to check for URL policy

BrowserWebController.m: (-[BrowserWebView decidePolicyForAction:request:frame:newFrameName:decisionListener:]): In case this is a plugin load request, accept it early to avoid throwing up UI or causing external loads.

11:49 AM Changeset in webkit [8963] by rjw

7 edits in trunk

WebCore:

Fixed <rdar://problem/4053515> REGRESSION (Mail): Kotoeri input method reconversion does not work in WebViews

We now use actual document NSRanges to represent both marked text
ranges and selection ranges.

Reviewed by Ken.

khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeLength): (khtml::TextIterator::setRangeFromLocationAndLength):
khtml/editing/visible_text.h:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]): (-[WebCoreBridge DOM::convertToDOMRange:]): (-[WebCoreBridge selectNSRange:]): (-[WebCoreBridge markedTextDOMRange]): (-[WebCoreBridge markedTextNSRange]):

WebKit:

Fixed <rdar://problem/4053515> REGRESSION (Mail): Kotoeri input method reconversion does not work in WebViews

We now use actual document NSRanges to represent both marked text
ranges and selection ranges.

Reviewed by Ken Kocienda.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView validAttributesForMarkedText]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView markedRange]): (-[WebHTMLView _selectMarkedText]): (-[WebHTMLView setMarkedText:selectedRange:]):

Mar 22, 2005:

6:42 PM Changeset in webkit [8962] by kdecker

3 edits in trunk/WebCore

Reviewed by Vicki.

Fixed <rdar://problem/4062336> REGRESSION (406-407): HTML submenus not working at hrweb.apple.com after going back

Rolled out the fix for <rdar://problem/4041374> REGRESSION (185-186): unload handlers (at least those added with addEventListener) are broken

We clearly need a better solution to 4041374. We can't indiscriminately remove event listeners in closeURL() after-all. Since event listeners are registered in a <script> tag, which is evaluated and executed at page load time, this becomes a problem since we don't reevaluate a page's <script> that is in the back/forward cache. Thus once you leave the page, the listeners are gone for good. This is the problem.

khtml/khtml_part.cpp: (KHTMLPart::closeURL):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach):

6:03 PM Changeset in webkit [8961]

3 copies in tags/Safari-410

This commit was manufactured by cvs2svn to create tag 'Safari-410'.

6:03 PM Changeset in webkit [8960]

3 copies in tags/Safari-310

This commit was manufactured by cvs2svn to create tag 'Safari-310'.

6:03 PM Changeset in webkit [8959] by vicki

2 edits in trunk/WebCore

roll the fix for <rdar://problem/4060266> back in, since its now approved by CCC (and move the Safari-410 release marker)

khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextBox):

5:50 PM Changeset in webkit [8958] by vicki

3 edits in trunk

versioning for TOT, Safari 2.0 (410+)

5:45 PM Changeset in webkit [8957] by vicki

3 edits in trunk

versioning for SUPanWheat, Safari 1.3 (310)

5:39 PM Changeset in webkit [8956] by vicki

6 edits in trunk

Safari-410 stamp

5:32 PM Changeset in webkit [8955] by vicki

2 edits in trunk/WebCore

roll out the fix for <rdar://problem/4060266> since it was denied by CCC

khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextBox):

2:12 PM Changeset in webkit [8954] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4060266> Double-clicking in Dictionary.app doesn't work for some words (coming just after style change)

khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextBox): Complete the check of whether to emit space for collapsed space.

9:59 AM Changeset in webkit [8953] by harrison

2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4061443> REGRESSION (8A420-8A421): Pasting in the Stickies widget is broken again

khtml/editing/htmlediting.cpp: (khtml::positionBeforeContainingSpecialElement): (khtml::positionAfterContainingSpecialElement): Return unchanged Position rather than a null or non-editable one.

5:10 AM Changeset in webkit [8952] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

Mar 20, 2005:

7:18 PM Changeset in webkit [8951] by vicki

3 edits in trunk

Versioning for TOT, Safari 2.0 (409+).
The tree is open!

7:12 PM Changeset in webkit [8950]

1 copy in tags/Safari-309

This commit was manufactured by cvs2svn to create tag 'Safari-309'.

7:12 PM Changeset in webkit [8949] by vicki

3 edits in trunk

versioning for SUPanWheat, Safari 1.3 (309)

7:06 PM Changeset in webkit [8948]

1 copy in tags/Safari-409

This commit was manufactured by cvs2svn to create tag 'Safari-409'.

7:06 PM Changeset in webkit [8947] by vicki

6 edits in trunk

Safari-409 stamp

4:33 PM Changeset in webkit [8946] by kocienda

3 edits
10 adds in trunk

Reviewed by me

I made an error in this test earlier. It was not testing what I intended. Fixed.

layout-tests/editing/unsupported-content/list-delete-001-expected.txt
layout-tests/editing/unsupported-content/list-delete-001.html

New tests:

layout-tests/editing/unsupported-content/table-delete-001-expected.txt: Added.
layout-tests/editing/unsupported-content/table-delete-001.html: Added.
layout-tests/editing/unsupported-content/table-delete-002-expected.txt: Added.
layout-tests/editing/unsupported-content/table-delete-002.html: Added.
layout-tests/editing/unsupported-content/table-delete-003-expected.txt: Added.
layout-tests/editing/unsupported-content/table-delete-003.html: Added.
layout-tests/editing/unsupported-content/table-type-after-expected.txt: Added.
layout-tests/editing/unsupported-content/table-type-after.html: Added.
layout-tests/editing/unsupported-content/table-type-before-expected.txt: Added.
layout-tests/editing/unsupported-content/table-type-before.html: Added.

4:27 PM Changeset in webkit [8945] by mjs

3 edits
1 add in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4060020> Add stub version of security SPI for QuickTime plug-in so QuickTime team has something to compile and link against

Plugins.subproj/WebPluginContainerPrivate.h: Added.
Plugins.subproj/WebPluginController.m: (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): (-[WebPluginController _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
WebKit.pbproj/project.pbxproj:

3:48 PM Changeset in webkit [8944] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3923903> REGRESSION (164-165): Repro Safari crash in khtml::RenderLayer::scrollToOffset

khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset): Check canvas for nil.

1:31 PM Changeset in webkit [8943] by harrison

3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4055127> Dictionary pop-up panel misplaced at beginning of text blocks (breaks double-clicking in Dictionary.app)

SimplifiedBackwardsTextIterator::advance() needed to not limit to textnodes
when checking whether moving back across block boundaries

VisibleUnits previousBoundary() needed to INIT_DOWN when creating result VisiblePosition

All editing tests pass.

khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::advance):
khtml/editing/visible_units.cpp: (khtml::previousBoundary):

1:18 PM Changeset in webkit [8942] by darin

4 edits in trunk/WebCore

Reviewed by Harrison.

fixed <rdar://problem/4059914> when you select all of a frame's content, need to select the frame in the parent document so it can be easily deleted

khtml/khtml_part.h: Added selectFrameElementInParentIfFullySelected.
khtml/khtml_part.cpp: (isFrame): Added. (KHTMLPart::setFocusNodeIfNeeded): Changed to not set focus to a frame; was not what this function was intended to do, and caused trouble when trying to select a frame element. (KHTMLPart::khtmlMouseReleaseEvent): Call selectFrameElementInParentIfFullySelected. (KHTMLPart::selectAll): Call selectFrameElementInParentIfFullySelected. (KHTMLPart::selectFrameElementInParentIfFullySelected): Added. Selects the frame element in the parent if a frame is entirely selected, which makes it easier to delete or replace the frame and is consistent with the changes Maciej made recently for other elements.

kwq/WebCoreBridge.mm: (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Call selectFrameElementInParentIfFullySelected. (-[WebCoreBridge alterCurrentSelection:verticalDistance:]): Call selectFrameElementInParentIfFullySelected.

12:19 PM Changeset in webkit [8941] by darin

2 edits in trunk/WebCore

Reviewed by me, code change by Ken.

fixed <rdar://problem/4059852> Deleting from first element of list makes content jump to wrong place

khtml/editing/htmlediting.cpp: (khtml::isListStructureNode): Added. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Check for list nodes as well as table nodes.

9:36 AM Changeset in webkit [8940] by kocienda

1 edit
11 adds in trunk

Reviewed by me

Added tests to cover new "unsupported content" editing code.

layout-tests/editing/unsupported-content/list-delete-001-expected.txt: Added.
layout-tests/editing/unsupported-content/list-delete-001.html: Added.
layout-tests/editing/unsupported-content/list-delete-002-expected.txt: Added.
layout-tests/editing/unsupported-content/list-delete-002.html: Added.
layout-tests/editing/unsupported-content/list-delete-003-expected.txt: Added.
layout-tests/editing/unsupported-content/list-delete-003.html: Added.
layout-tests/editing/unsupported-content/list-type-after-expected.txt: Added.
layout-tests/editing/unsupported-content/list-type-after.html: Added.
layout-tests/editing/unsupported-content/list-type-before-expected.txt: Added.
layout-tests/editing/unsupported-content/list-type-before.html: Added.

8:26 AM Changeset in webkit [8939] by kocienda

2 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/4059578> Entire list deleted, and caret disappears, when delete key hit at end of list

The problem is that a new case in the delete code did not consider when the
downstream end node of the selection might be an ancestor of the upstream start
node. That is the case in this bug. The downstream end is the body element, and
this line of code would delete all the children of the downstream end:

removeChildrenInRangePreservingPosition(m_downstreamEnd.node(), 0,

m_downstreamEnd.offset(), m_upstreamStart);

The fix is to check for this "is ancestor" case, and do some tree logic to find
the right offset of the downstream end node for the call to
removeChildrenInRangePreservingPosition().

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Fixed as described.

Mar 19, 2005:

8:58 PM Changeset in webkit [8938] by harrison

2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4059479> Misspelling underline does underline the whole word, could go farther to the right

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer misspellingLinePatternGapWidth]): (-[WebTextRenderer drawLineForMisspelling:withWidth:]): Consider that the last pixel in the underline dot pattern is transparent.

6:22 PM Changeset in webkit [8937] by kocienda

2 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

<rdar://problem/4059384> Cannot place insertion point correctly in editable text that avoids floating elements

Note: I strongly suspect this bug blocks a complete solution to this other Tiger/P2:
<rdar://problem/4055748> AX: Dictionary pop-up panel shows at wrong place on specific parts of particular pages

khtml/rendering/render_text.cpp: (RenderText::caretRect): Change the y-coordinate used to calculate the available width for a line. Height is wrong. Top of the box containing the text where the click is done is correct. Also, add in the x-offset for the start of the text box when calculating the available width. If this text box is avoiding a float at the y-coordinate for the relevant box, failure to add in the amount of float-avoidance will make the text at the coordinates greater than end-of-line minus float-avoidance ineligible for caret placement.

4:58 PM Changeset in webkit [8936] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/4057594> REGRESSION (125-406): Unrepro crash in HTMLTokenizer::allDataProcessed after hitting Back button

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::allDataProcessed): To get the part safely after calling end, save a guarded pointer to the view. The old way could end trying to call a virtual function a part that was destroyed.

2:36 PM Changeset in webkit [8935] by mjs

13 edits in trunk

Reviewed by Darin.

<rdar://problem/4053506> Pasting Tables and Cells in Mail does not allow editing before or after
<rdar://problem/4005954> REGRESSION (Mail): After copy/paste of content containing list element cannot go back to entering text at left side of page

khtml/editing/htmlediting.cpp: (khtml::maxDeepOffset): (khtml::CompositeEditCommand::removeFullySelectedNodePreservingPosition): (khtml::CompositeEditCommand::removeChildrenInRangePreservingPosition): (khtml::CompositeEditCommand::removeNodePreservingPosition): (khtml::CompositeEditCommand::insertBlockPlaceholder): (khtml::CompositeEditCommand::appendBlockPlaceholder): (khtml::CompositeEditCommand::forceBlockPlaceholder): (khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded): (khtml::isSpecialElement): (khtml::isFirstVisiblePositionInSpecialElementInFragment): (khtml::positionBeforePossibleContainingSpecialElement): (khtml::positionAfterPossibleContainingSpecialElement): (khtml::ApplyStyleCommand::applyInlineStyle): (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): (khtml::DeleteSelectionCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::ReplacementFragment::ReplacementFragment): (khtml::ReplaceSelectionCommand::doApply):
khtml/editing/htmlediting.h:
khtml/editing/visible_position.cpp: (khtml::isRenderedBR): (khtml::VisiblePosition::initDownstream): (khtml::isLastVisiblePositionInBlock):
khtml/rendering/render_line.cpp: (khtml::RootInlineBox::closestLeafChildForXPos):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::isBlockFlowOrTable): (NodeImpl::isEditableBlock): (NodeImpl::enclosingBlockFlowOrTableElement):
khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_position.cpp: (DOM::Position::upstream): (DOM::Position::downstream):
layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
layout-tests/editing/deleting/delete-select-all-001-expected.txt:
layout-tests/editing/deleting/delete-select-all-003-expected.txt:
layout-tests/editing/inserting/insert-3786362-fix-expected.txt:

11:34 AM Changeset in webkit [8934] by darin

2 edits in trunk/WebKit

Reviewed by Maciej (a while back).

fixed <rdar://problem/4059323> local-file security check is allowing plug-in streams, but must not

Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): Roll out change I made on 3-13. That change is needed for subresource, but not for plug-in streams. For plug-in streams it's too risky, and leaves a serious security hole open.

9:09 AM Changeset in webkit [8933] by darin

2 edits in trunk/WebKit

Reviewed by Ken and John.

fixed <rdar://problem/4059123> REGRESSION (402-403): deleteWordForward: and deleteWordBackward: start deleting single characters after the first delete

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Fixed backwards logic in here and added missing check. Set action to one of the two typing actions only if isTypingAction is YES.

8:21 AM Changeset in webkit [8932] by sullivan

2 edits in trunk/WebCore

Reviewed by Darin.

fixed <rdar://problem/4058740> Crash (nil-deref) editing Mail reply message in KWQKHTMLPart::fontForSelection (MailViewer-723)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection): Add nil check to loop. It shouldn't be necessary, but this crash trace seems to be running into it. We're not completely certain, but the check is harmless at worst.

8:07 AM Changeset in webkit [8931] by harrison

2 edits in trunk/WebKit

Reviewed by me (written by Patti Yeh).

<rdar://problem/4029491> <TCIM> CangJie: the candidate window appears at the top left hand corner during typing in Mail and iChat

WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Use selected range if there is no marked range.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed